Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On Tue, Nov 12, 2019 at 5:15 PM Markus Armbruster wrote: > I apologize for my slooow response; KVM Forum happened. > It doesn't matter. I attended KVM forum, too :) > > Han Han writes: > > > On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik > > wrote: > > > >> On 10/15/19 7:23 AM, Han Han

Re: [libvirt] [PATCH] qemu: Warn verbosely if using old loader:nvram pairs

On 11/11/19 9:42 AM, Michal Privoznik wrote: > There are two ways for specifying loader:nvram pairs: > >1) --with-loader-nvram configure option >2) nvram variable in qemu.conf > > Since we have FW descriptors, using this old style is > discouraged, but not as strong as one would expect.

[libvirt] [PATCH Rust 2/4] libvirt-rust: stream: add more functions in stream

* added virStreamEventAddCallback function * added new types: StreamEventCallback and FreeCallback * added new field: callback for storing event callback * drop: will drop the Box if any * added wrapper event_callback for easier callback authoring for the user (so that closures with Fn or FnMut

[libvirt] [PATCH Rust 3/4] libvirt-rust: stream: automated lint

* used rustfmt to clean up the code Signed-off-by: Zixing Liu --- src/stream.rs | 97 +-- 1 file changed, 56 insertions(+), 41 deletions(-) diff --git a/src/stream.rs b/src/stream.rs index 1ffd186..0d84fd7 100644 --- a/src/stream.rs +++

[libvirt] [PATCH Rust 1/4] libvirt-rust: stream: add more functions in stream

* added new functions: virStreamNew virStreamEventUpdateCallback virStreamEventRemoveCallback * added new constants: VIR_STREAM_NONBLOCK * added new types/aliases: StreamFlags * changed the previous `new` associate function to `from_ptr` to avoid naming conflicts * added basic tests to test

[libvirt] [PATCH Rust 0/4] Map more functions in stream module

This set of patches will add more functions to the Rust bindings. Newly mapped functions from C library: virStreamNew virStreamEventUpdateCallback virStreamEventRemoveCallback virStreamEventAddCallback. virStreamEventAddCallback can accept normal fn functions or closures (can capture variables

[libvirt] [PATCH Rust 4/4] libvirt-rust: use reference instead of moving

Signed-off-by: Zixing Liu --- src/domain.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/domain.rs b/src/domain.rs index acb9e6e..4d4f593 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -1397,7 +1397,7 @@ impl Domain { } } -pub fn open_console(,

[libvirt] [PATCH v2 3/3] tests: remove unneeded cleanup labels

Signed-off-by: Daniel Henrique Barboza --- tests/commandtest.c | 17 - tests/networkxml2firewalltest.c | 10 ++--- tests/nsstest.c | 27 ++--- tests/nwfilterebiptablestest.c | 4 +- tests/nwfilterxml2firewalltest.c | 16 +++-

[libvirt] [PATCH v2 1/3] qemu: remove unneeded cleanup labels

Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_cgroup.c | 15 ++-- src/qemu/qemu_domain.c | 84 +++ src/qemu/qemu_domain_address.c | 31 +++ src/qemu/qemu_driver.c | 145 - src/qemu/qemu_hotplug.c|

[libvirt] [PATCH v2 0/3] remove 'cleanup: return' labels

changes from v1 [1], all suggested by Ján Tomko: - qemu patch (former patch 10): * qemu_driver.c: using 'return -1' instead of 'return ret' in qemuDumpToFd() and qemuDomainBlockPivot() * qemu_hotplug.c: removed the use of 'ret' variable in qemuDomainChangeGraphics(), returning

[libvirt] [PATCH v2 2/3] vbox: remove unneeded cleanup labels

Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c| 12 +++--- src/vbox/vbox_snapshot_conf.c | 75 +++ 2 files changed, 36 insertions(+), 51 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index

[libvirt] [PATCH Rust v2] api_tests.py: update to use Python 3

Signed-off-by: Zixing Liu --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else:

Re: [libvirt] [PATCH Rust] api_tests.py: update to use Python 3

On Tuesday, November 12, 2019 6:17:21 AM MST Sahid Orentino Ferdjaoui wrote: > On Tue, Nov 12, 2019 at 11:36:49AM +0100, Andrea Bolognani wrote: > > On Fri, 2019-11-01 at 14:23 -0600, liushuyu wrote: > > > From: liushuyu > > > > Please include a Signed-off-by: tag with your full legal name and >

Re: [libvirt] [PATCH] qemu: hotplug: ensure address generation for vfio-ccw

Ján Tomko [2019-11-12, 04:45PM +0100]: > On Tue, Nov 12, 2019 at 12:06:46PM +0100, Bjoern Walk wrote: > > Somewhere on my TODO-list I have a point to go over the address > > generation for CCW and clean it up. For now, this must suffice. > > It does seem to be more complicated than it needs to

Re: [libvirt] [PATCH 6/6] docs: add page describing the libvirt daemons

On Fri, 2019-11-08 at 11:21 +, Daniel P. Berrangé wrote: > > +Systemd Integration > +--- > + > +When the `libvirtd` daemon is managed by `systemd` a number of > desirable > +features are available, most notably socket activation. > + > +Libvirt ships a number of unit files for

Re: [libvirt] NOTE: building libvirt requires srcdir != builddir now

Hi, Aside from what Daniel already said I want to add that, at least in my environments, 'make install' fails if I attempt the following: mkdir build cd build ../autogen.sh --prefix=$PWD make make install or mkdir build cd build ../autogen.sh --prefix=$PWD/..

Re: [libvirt] [PATCH v1 10/21] qemu: remove unneeded cleanup labels

On 11/12/19 1:40 PM, Ján Tomko wrote: On Mon, Oct 21, 2019 at 03:19:00PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_cgroup.c |  15 ++-- src/qemu/qemu_domain.c |  92 -- src/qemu/qemu_domain_address.c | 

Re: [libvirt] [PATCH v1 13/21] vbox: remove unneeded cleanup labels

On 11/12/19 1:42 PM, Ján Tomko wrote: On Mon, Oct 21, 2019 at 03:19:03PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c    | 12 +++--- src/vbox/vbox_snapshot_conf.c | 75 +++ 2 files changed, 36

Re: [libvirt] [tck PATCH 2/3] hooks: Refresh the service status after performing an action

On Tue, Nov 12, 2019 at 03:44:07PM +, Daniel P. Berrangé wrote: > On Tue, Nov 12, 2019 at 04:10:19PM +0100, Erik Skultety wrote: > > Presumably, the original intent of the code was to query the status of > > the service to refresh the internal state variable, but the intended > > method was

Re: [libvirt] [PATCH 0/7] util: buffer: Simplify child buffer init

On Tue, Nov 12, 2019 at 03:18:13PM +0100, Peter Krempa wrote: This applies on top of https://www.redhat.com/archives/libvir-list/2019-November/msg00397.html Peter Krempa (7): util: buffer: Add init macro for automatically setting child XML indent qemu: domain: Convert child buffers to use

Re: [libvirt] [PATCH 0/3] capabilities: Sanitize handling of 'features'

On Tue, Nov 12, 2019 at 02:33:43PM +0100, Peter Krempa wrote: Peter Krempa (3): schema: capabilities: Add 'hap' feature flag conf: Refactor storage of guest capabilities conf: capabilities: Refactor API for setting guest capability features docs/schemas/capability.rng| 6 +

Re: [libvirt] [PATCH 3/3] conf: capabilities: Refactor API for setting guest capability features

On Tue, Nov 12, 2019 at 02:33:46PM +0100, Peter Krempa wrote: Remove the need to pass around strings and switch to the enum values instead. Signed-off-by: Peter Krempa --- src/conf/capabilities.c| 68 ++ src/conf/capabilities.h| 11 --

Re: [libvirt] [PATCH v5 01/23] build-aux: rewrite duplicate header checker in Python

On Mon, Nov 11, 2019 at 02:38:04PM +, Daniel P. Berrangé wrote: As part of an goal to eliminate Perl from libvirt build tools, rewrite the prohibit-duplicate-header.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus

[libvirt] [PATCHv2] conf: remove NULL check from virDomainQemuMonitorEventNew

The qemu_domain_monitor_event_msg struct in qemu_protocol.x defines event as a nonnull_string and qemuMonitorJSONIOProcessEvent also errors out on a non-NULL event. Drop the check completely. This essentially reverts commit d343e8203d248635f5e7a0d86dd077f74d49e3af Signed-off-by: Ján Tomko ---

[libvirt] [PATCH 5/9] Remove VIR_STRNDUP usage with subtraction

Remove all the uses that use subtraction in their length argument. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_parse_command.c | 6 ++ src/libxl/xen_common.c | 8 +++- src/libxl/xen_xm.c | 3 +-- src/lxc/lxc_driver.c| 3 +-- src/qemu/qemu_driver.c

[libvirt] [PATCH 6/9] Remove the rest of VIR_STRNDUP

Replace all the uses passing a single parameter as the length. Signed-off-by: Ján Tomko --- src/conf/nwfilter_conf.c | 4 ++-- src/conf/nwfilter_params.c | 6 ++ src/interface/interface_backend_udev.c | 8 ++-- src/libxl/xen_common.c | 3 +--

[libvirt] [PATCH 4/9] Remove VIR_STRNDUP usage with checked pointers

Remove the usage where sanity of the length argument is verified by other conditions not matching the previous patches. Signed-off-by: Ján Tomko --- src/libxl/xen_common.c | 18 -- tools/vsh.c| 5 ++--- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH 7/9] tests: delete tests for VIR_STR(N)DUP

Signed-off-by: Ján Tomko --- tests/virstringtest.c | 136 -- 1 file changed, 136 deletions(-) diff --git a/tests/virstringtest.c b/tests/virstringtest.c index 1e408f2757..992b25df92 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@

[libvirt] [PATCH 8/9] util: remove VIR_STRDUP and VIR_STRNDUP

Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 2 -- src/util/virstring.c | 49 src/util/virstring.h | 69 3 files changed, 120 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms

[libvirt] [PATCH 9/9] docs: hacking: document removal of VIR_STR(N)DUP

Signed-off-by: Ján Tomko --- docs/hacking.html.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 06deab9e90..74aba5d46b 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -1040,9 +1040,6 @@ BAD:

[libvirt] [PATCH 0/9] Remove remaining usage of VIR_STR(N)DUP (glib chronicles)

Almost. Patch 8/9 depends on Jirka removing VIR_STRNDUP in [PATCH v3 04/52] conf: Drop nameLen parameter from virDomainCapsCPUModelsAdd https://www.redhat.com/archives/libvir-list/2019-November/msg00068.html Ján Tomko (9): Remove VIR_STRDUP usage that snuck in Remove VIR_STRNDUP usage that

[libvirt] [PATCH 2/9] Remove VIR_STRNDUP usage that passes -1

Replace all the usage of VIR_STRNDUP(dest, b, p ? p - b : -1) with separate calls to g_strndup/g_strdup. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_parse_command.c | 38 + src/libxl/xen_common.c | 15 +++-- src/remote/remote_driver.c |

[libvirt] [PATCH 1/9] Remove VIR_STRDUP usage that snuck in

Fixes: 224d269f19f0a6c496dd2218f934a54742d51708 Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9c517597bb..ffac73dd42 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH 3/9] Remove VIR_STRNDUP usage that subtracts from a non-NULL pointer

Use g_strndup in all the cases where we check upfront whether a pointer is non-NULL and then use it to calculate the copied length. Signed-off-by: Ján Tomko --- src/util/virsysinfo.c | 241 -- 1 file changed, 112 insertions(+), 129 deletions(-) diff

Re: [libvirt] [PATCH v1 20/21] tests: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:10PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- tests/commandtest.c| 17 tests/domainconftest.c | 5 +-- tests/networkxml2firewalltest.c| 13 ++ tests/nsstest.c| 27

Re: [libvirt] [PATCH v1 21/21] bhyve_device.c: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:11PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/bhyve/bhyve_device.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH v1 19/21] tools: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:09PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- tools/virsh-completer-network.c | 8 ++- tools/virsh-domain.c| 41 +++-- tools/vsh.c | 14 +-- 3 files

Re: [libvirt] [PATCH v1 18/21] suspend.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:19:08PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- examples/c/domain/suspend.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH v1 17/21] bridge_driver.c: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:07PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/network/bridge_driver.c | 172 ++-- 1 file changed, 68 insertions(+), 104 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH v1 16/21] libxl_driver.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:19:06PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/libxl/libxl_driver.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH v1 15/21] libvirt.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:19:05PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/libvirt.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH v1 14/21] util: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:04PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/util/vircgroupv1.c | 18 - src/util/vircommand.c | 11 +++- src/util/virdbus.c | 30 +++-- src/util/virfile.c | 19

Re: [libvirt] [PATCH v1 13/21] vbox: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:03PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c| 12 +++--- src/vbox/vbox_snapshot_conf.c | 75 +++ 2 files changed, 36 insertions(+), 51 deletions(-) diff --git

Re: [libvirt] [PATCH v1 11/21] rpc: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:01PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/rpc/virnetserver.c| 15 +-- src/rpc/virnetserverprogram.c | 13 - src/rpc/virnetsocket.c| 9 +++-- src/rpc/virnettlscontext.c| 20

Re: [libvirt] [PATCH v1 12/21] vz_sdk.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:19:02PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/vz/vz_sdk.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing

Re: [libvirt] [PATCH v1 10/21] qemu: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:19:00PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_cgroup.c | 15 ++-- src/qemu/qemu_domain.c | 92 -- src/qemu/qemu_domain_address.c | 31 +++- src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v1 09/21] qemu_monitor_json.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:18:59PM -0300, Daniel Henrique Barboza wrote: qemuMonitorJSONBlockIoThrottleInfo uses a macro called GET_THROTTLE_STATS that's defined outside of the function, which references a 'cleanup' label. GET_THROTTLE_STATS is only used inside qemuMonitorJSONBlockIoThrottleInfo

Re: [libvirt] [PATCH v1 07/21] secret_driver.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:18:57PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/secret/secret_driver.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH v1 06/21] node_device: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:56PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/node_device/node_device_driver.c | 11 +++ src/node_device/node_device_udev.c | 8 ++-- 2 files changed, 5 insertions(+), 14 deletions(-) Reviewed-by: Ján

Re: [libvirt] [PATCH v1 08/21] openvz_conf.c: remove unneeded cleanup label

On Mon, Oct 21, 2019 at 03:18:58PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/openvz/openvz_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 4646308c48..f12c91aa88

Re: [libvirt] [PATCH v1 05/21] lxc: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:55PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/lxc/lxc_cgroup.c | 70 src/lxc/lxc_container.c | 17 -- src/lxc/lxc_controller.c | 44 +++--

Re: [libvirt] [PATCH v1 04/21] remote: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:54PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/remote/remote_daemon.c | 38 +- src/remote/remote_driver.c | 15 +-- 2 files changed, 22 insertions(+), 31 deletions(-)

Re: [libvirt] [PATCH v1 03/21] nwfilter: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:53PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/nwfilter/nwfilter_ebiptables_driver.c | 132 +- 1 file changed, 56 insertions(+), 76 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH v1 02/21] storage: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:52PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/storage/storage_backend_fs.c | 13 +++ src/storage/storage_backend_rbd.c | 58 ++- src/storage/storage_backend_zfs.c | 21 ---

Re: [libvirt] [PATCH v1 01/21] conf: remove unneeded cleanup labels

On Mon, Oct 21, 2019 at 03:18:51PM -0300, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_addr.c | 23 +-- src/conf/domain_capabilities.c | 21 +- src/conf/domain_conf.c | 334 +++

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

On 11/9/19 1:12 AM, Jonathon Jongsma wrote: Thanks for the thorough review Michal, clearly it needs more work. In particular, I was not yet aware of the private xml save/restore stuff. Thanks for the pointers in that regard. But I have one particular question below: On Fri, 2019-11-08 at 11:46

[libvirt] [PATCH] docs: hacking: add missing code element

Wrap the 'g_renew()' call for VIR_SHRINK_N in . Signed-off-by: Ján Tomko --- Pushed as trivial. docs/hacking.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 5d13e4f71d..06deab9e90 100644 --- a/docs/hacking.html.in

Re: [libvirt] [PATCH] qemu: hotplug: ensure address generation for vfio-ccw

On Tue, Nov 12, 2019 at 12:06:46PM +0100, Bjoern Walk wrote: Ján Tomko [2019-11-12, 10:47AM +0100]: > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index fd4bafef..7b775159 100644 > --- a/src/qemu/qemu_hotplug.c > +++ b/src/qemu/qemu_hotplug.c > @@ -2790,6 +2790,8 @@

Re: [libvirt] [tck PATCH 2/3] hooks: Refresh the service status after performing an action

On Tue, Nov 12, 2019 at 04:10:19PM +0100, Erik Skultety wrote: > Presumably, the original intent of the code was to query the status of > the service to refresh the internal state variable, but the intended > method was never called because of a typo. > --- > lib/Sys/Virt/TCK/Hooks.pm | 2 +- > 1

Re: [libvirt] [PATCH 00/75] Drop virAsprintf() in favor of g_strdup_printf()

On 11/11/19 12:00 AM, Daniel Henrique Barboza wrote: Hey, On 10/22/19 10:57 AM, Michal Privoznik wrote: You can find these also on my github:    https://github.com/zippy2/libvirt/tree/virasprintf_void Good luck. What's the status on this? I am waiting this big boy to land upstream so I

Re: [libvirt] [PATCH] qemu: driver: Remove unused 'driver' from qemuDomainSnapshotFSFreeze/Thaw

On 11/12/19 3:33 PM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Michal Privoznik Michal -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] src: Wrap long lines in Makefiles

In my previous commit of v5.9.0-83-g4ae7181376 I've fixed check-aclrules but whilst doing so, I forgot to wrap long lines that I've added. Signed-off-by: Michal Privoznik --- Pushed under trivial rule. src/interface/Makefile.inc.am | 3 ++- src/network/Makefile.inc.am | 4 +++-

[libvirt] [tck PATCH 0/3] A couple of fixes for daemon hooks tests assuming system V only

Erik Skultety (3): hooks: Add systemd detection hooks: Refresh the service status after performing an action hooks: Use internal variable holding the state of the libvirtd service lib/Sys/Virt/TCK/Hooks.pm | 26 +++--- scripts/hooks/051-daemon-hook.t | 8

[libvirt] [tck PATCH 1/3] hooks: Add systemd detection

The hooks assume System V. On RPM-based distros, there's the initscripts package introducing the 'service' command mapping the old style syntax to the systemd format. However, we can't assume this will be the case all the time, so some kind of detection of the init system would prevent test

[libvirt] [tck PATCH 2/3] hooks: Refresh the service status after performing an action

Presumably, the original intent of the code was to query the status of the service to refresh the internal state variable, but the intended method was never called because of a typo. --- lib/Sys/Virt/TCK/Hooks.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [tck PATCH 3/3] hooks: Use internal variable holding the state of the libvirtd service

Rather than assuming the existence of the 'service' command, use the object variable holding the current state of the libvirtd service which got populated right after we performed the tested action on the service. --- scripts/hooks/051-daemon-hook.t | 8 1 file changed, 4 insertions(+),

Re: [libvirt] [PATCH v3 52/52] qemu: Store default CPU in domain XML

On Tue, Nov 05, 2019 at 02:27:50PM +0100, Jiri Denemark wrote: When starting a domain without a CPU model specified in the domain XML, QEMU will choose a default one. Which is fine unless the domain gets migrated to another host because libvirt doesn't perform any CPU ABI checks and the virtual

Re: [libvirt] [PATCH v3 47/52] qemuxml2argvtest: Update host arch for DO_TEST*ARCH* tests

On Tue, Nov 05, 2019 at 02:27:45PM +0100, Jiri Denemark wrote: To avoid mismatch between host and QEMU capabilities. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch tests/qemuxml2argvtest.c | 4 tests/testutilsqemu.c| 6 +++--- tests/testutilsqemu.h| 1 + 3

Re: [libvirt] [PATCH v3 42/52] qemu: Probe machine types for both KVM and TCG

On Tue, Nov 05, 2019 at 02:27:40PM +0100, Jiri Denemark wrote: Almost all TCG query-machines replies match KVM. The only exceptions are 4.2.0 replies on s390x which differ in the reported default CPU type. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch Reviewed-by:

Re: [libvirt] [PATCH v3 40/52] qemu: Introduce virQEMUCapsCopyMachineTypes

On Tue, Nov 05, 2019 at 02:27:38PM +0100, Jiri Denemark wrote: The function copies machine type data from one QEMU caps structure to another. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 31 --- 1 file changed,

Re: [libvirt] [PATCH v3 41/52] qemu: Make probed machine types depend on accelerator

On Tue, Nov 05, 2019 at 02:27:39PM +0100, Jiri Denemark wrote: Some specifics of machine types may depend on the accelerator and thus the data should be moved to virQEMUCapsAccel. The TCG machine types are just copied from the ones probed for KVM to simplify the changes to qemucapabilitiestest

Re: [libvirt] [PATCH v3 38/52] qemu: Move machine type data in capabilities cache

On Tue, Nov 05, 2019 at 02:27:36PM +0100, Jiri Denemark wrote: In preparation for making machine types dependent on the accelerator, the elements are formatted between and . Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c |

Re: [libvirt] [PATCH v3 39/52] qemu: Use typedef for virQEMUCapsMachineType

On Tue, Nov 05, 2019 at 02:27:37PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

Re: [libvirt] [PATCH v3 37/52] qemu: Pass virDomainVirtType to APIs dealing with machine types

On Tue, Nov 05, 2019 at 02:27:35PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 64 +--- src/qemu/qemu_capabilities.h | 8 - src/qemu/qemu_domain.c | 8 +++--

Re: [libvirt] [PATCH v3 36/52] qemu: Refactor virQEMUCapsFormatCache a bit

dtto On Tue, Nov 05, 2019 at 02:27:34PM +0100, Jiri Denemark wrote: All the code for formatting machine type data was moved to a standalone virQEMUCapsFormatMachines function. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 37

Re: [libvirt] [PATCH v3 35/52] qemu: Refactor virQEMUCapsLoadCache a bit

s/Refactor virQEMUCapsLoadCache/Split out virQEMUCapsLoadMachines/ maybe On Tue, Nov 05, 2019 at 02:27:33PM +0100, Jiri Denemark wrote: All the code for loading machine type data was moved to a standalone virQEMUCapsLoadMachines function. Signed-off-by: Jiri Denemark --- Notes: Version 3:

Re: [libvirt] [PATCH v3 34/52] qemu: Make virQEMUCapsIsMachineSupported static

On Tue, Nov 05, 2019 at 02:27:32PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 28 ++-- src/qemu/qemu_capabilities.h | 3 --- 2 files changed, 14 insertions(+), 17 deletions(-)

Re: [libvirt] [PATCH v3 32/52] qemu: Refactor probing of accelerator dependent data

On Tue, Nov 05, 2019 at 02:27:30PM +0100, Jiri Denemark wrote: To avoid duplicating code which selects the right virQEMUCapsAccel data to be filled during probing. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 51

Re: [libvirt] [PATCH v3 33/52] qemu: Make virQEMUCapsGetMachineTypesCaps static

On Tue, Nov 05, 2019 at 02:27:31PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 150 ++- src/qemu/qemu_capabilities.h | 3 - 2 files changed, 76 insertions(+), 77 deletions(-)

Re: [libvirt] [PATCH v3 30/52] qemu: Refactor virQEMUCapsFormatAccel

On Tue, Nov 05, 2019 at 02:27:28PM +0100, Jiri Denemark wrote: And make it use virQEMUCapsGetAccel once rather than repeating the same code in all functions called from virQEMUCapsFormatAccel. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c |

Re: [libvirt] [PATCH v3 31/52] qemu: Introduce virQEMUCapsProbeCPUDefinitionsTest

On Tue, Nov 05, 2019 at 02:27:29PM +0100, Jiri Denemark wrote: It is a tiny wrapper around virQEMUCapsProbeQMPCPUDefinitions which will soon get private parameters and thus it cannot be exposed outside qemu_capabilities. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new ptach

Re: [libvirt] [PATCH v3 29/52] qemu: Refactor virQEMUCapsLoadAccel

On Tue, Nov 05, 2019 at 02:27:27PM +0100, Jiri Denemark wrote: And make it use virQEMUCapsGetAccel once rather than repeating the same code in all functions called from virQEMUCapsLoadAccel. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c |

Re: [libvirt] [PATCH v3 28/52] qemu: Drop virQEMUCapsGetHostCPUData

On Tue, Nov 05, 2019 at 02:27:26PM +0100, Jiri Denemark wrote: It was very similar to virQEMUCapsGetAccel. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-)

Re: [libvirt] [PATCH v3 27/52] qemu: Introduce and use virQEMUCapsGetAccel

On Tue, Nov 05, 2019 at 02:27:25PM +0100, Jiri Denemark wrote: The function can be used to get the pointer to all data which depend on the accelerator. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 36

Re: [libvirt] [PATCH v3 26/52] qemu: Introduce virQEMUCapsAccelClear

On Tue, Nov 05, 2019 at 02:27:24PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH v3 25/52] qemu: Introduce virQEMUCapsAccelCopy

On Tue, Nov 05, 2019 at 02:27:23PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH v3 24/52] qemu: Introduce virQEMUCapsAccel structure

On Tue, Nov 05, 2019 at 02:27:22PM +0100, Jiri Denemark wrote: This is container for capabilities data that depend on the accelerator. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c | 66 1 file changed,

Re: [libvirt] [PATCH v3 23/52] qemu: Add virQEMUCaps{Load, Format}Accel

On Tue, Nov 05, 2019 at 02:27:21PM +0100, Jiri Denemark wrote: The new functions are designed to load and format capabilities which depend on the accelerator (host CPU expansion and CPU models). Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch src/qemu/qemu_capabilities.c

[libvirt] [PATCH] qemu: driver: Remove unused 'driver' from qemuDomainSnapshotFSFreeze/Thaw

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 45363b0d6d..982a7d61cf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14496,8

Re: [libvirt] [PATCH v3 18/52] qemu: Switch qemuCaps to use qemuMonitorCPUDefs

On Tue, Nov 05, 2019 at 02:27:16PM +0100, Jiri Denemark wrote: We will need to keep some QEMU-specific data for each CPU model supported by a QEMU binary. Instead of complicating the generic virDomainCapsCPUModelsPtr, we can just directly store qemuMonitorCPUDefsPtr returned by the capabilities

Re: [libvirt] [PATCH v3 14/52] qemu: Use virDomainCapsCPUUsable in qemuMonitorCPUDefInfo

On Tue, Nov 05, 2019 at 02:27:12PM +0100, Jiri Denemark wrote: While virDomainCapsCPUModel structure contains 'usable' field with virDomainCapsCPUUsable type, the lower level structure specific to QEMU driver used virTriStateBool for the same thing and we had to translate between them.

Re: [libvirt] [PATCH v3 12/52] qemu: Add qemuMonitorCPUDefsCopy

On Tue, Nov 05, 2019 at 02:27:10PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 2: - no change Version 3: - more glib functions - the function now returns the pointer to the copy rather than int as it can never fail src/qemu/qemu_monitor.c |

Re: [libvirt] [PATCH v3 04/52] conf: Drop nameLen parameter from virDomainCapsCPUModelsAdd

On Tue, Nov 05, 2019 at 02:27:02PM +0100, Jiri Denemark wrote: All callers use nameLen == -1 anyway. Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- Notes: Version 2: - no change Version 3: - no change src/conf/domain_capabilities.c | 7 +++

Re: [libvirt] [PATCH v3 02/52] tests: Update 4.2.0 capabilities data on ppc64

On Tue, Nov 05, 2019 at 02:27:00PM +0100, Jiri Denemark wrote: Generated with "spapr/kvm: Set default cpu model for all machine classes" fix for QEMU applied. Signed-off-by: Jiri Denemark --- Notes: Version 3: - new patch .../caps_4.2.0.ppc64.replies | 38

[libvirt] [PATCH 7/7] util: buffer: remove virBufferSetChildIndent

Promote usage of separate buffers for separate formatting passes by removing the now unused virBufferSetChildIndent. Signed-off-by: Peter Krempa --- src/util/virbuffer.h | 9 - 1 file changed, 9 deletions(-) diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index

[libvirt] [PATCH 0/7] util: buffer: Simplify child buffer init

This applies on top of https://www.redhat.com/archives/libvir-list/2019-November/msg00397.html Peter Krempa (7): util: buffer: Add init macro for automatically setting child XML indent qemu: domain: Convert child buffers to use VIR_BUFFER_INIT_CHILD util: sysinfo: Convert child buffers

[libvirt] [PATCH 5/7] conf: cpu: Convert child buffers to use VIR_BUFFER_INIT_CHILD

Use the new helper to initialize child XML element buffers. Signed-off-by: Peter Krempa --- src/conf/cpu_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 2b644638a7..ca048d899a 100644 --- a/src/conf/cpu_conf.c +++

[libvirt] [PATCH 6/7] conf: domain: Convert child buffers to use VIR_BUFFER_INIT_CHILD

Use the new helper to initialize child XML element buffers. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 101 +++-- 1 file changed, 27 insertions(+), 74 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 1/7] util: buffer: Add init macro for automatically setting child XML indent

Add a new macro which initializes a virBuffer on the stack and also sets the indent level to be used for child XML element formatting. Signed-off-by: Peter Krempa --- src/util/virbuffer.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h

[libvirt] [PATCH 3/7] util: sysinfo: Convert child buffers to use VIR_BUFFER_INIT_CHILD

Use the new helper to initialize child XML element buffers. Signed-off-by: Peter Krempa --- src/util/virsysinfo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 9d013067fe..d656b23731 100644 --- a/src/util/virsysinfo.c

  1   2   >