On 11/18/19 11:38 PM, Jonathon Jongsma wrote:
Signed-off-by: Jonathon Jongsma
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
Reviewed-by: Michal Privoznik
and pushed. Thanks!
Michal
--
libvir-list mailing list
libvir-list@redhat.com
On 11/18/19 5:21 PM, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> guests/configs/autoinst.xml | 86 +++
> .../libvirt-opensuse-15.1/docker.yml | 2 +
> .../libvirt-opensuse-15.1/install.yml | 2 +
>
Signed-off-by: Jim Fehlig
---
guests/configs/autoinst.xml | 86 +++
.../libvirt-opensuse-15.1/docker.yml | 2 +
.../libvirt-opensuse-15.1/install.yml | 2 +
.../host_vars/libvirt-opensuse-15.1/main.yml | 22 +
guests/inventory
Signed-off-by: Jonathon Jongsma
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 240d288c37..72c0edb317 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -66,6 +66,19 @@
initialized the vGPU.
+
On 10/25/19 4:28 AM, Patrik Martinsson wrote:
> Hi Tim,
>
> I recently stumbled on the same thing, accidentally shrinking a blockdevice.
>
> I have written a patch for virsh that will force the user to append a
> '--force' flag if shrinking is desired.
>
> The behavior is somewhat still
On 11/18/19 12:02 PM, Peter Krempa wrote:
> Historically we've only supported the as an output-only
> element for domain disks. The documentation states that it may become
> supported on input. To allow management apps detectin once that happens
> add a domain capability which will be asserted if
On 11/13/19 11:05 AM, Peter Krempa wrote:
> For future extensions of the domain caps it's useful to have a single
> point that initializes all capabilities as unsupported by a driver. The
> driver then can enable specific ones.
>
> Signed-off-by: Peter Krempa
> ---
>
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> This series is an effort to reduce the number of different
> languages we use by eliminating most use of perl in favour
> of python.
>
I tested all the new scripts, see individual mails. I didn't really
'review' any of them; since many are just
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> Makefile.am | 1 +
> {src/hyperv => scripts}/hyperv_wmi_generator.py | 0
> src/hyperv/Makefile.inc.am | 5 ++---
> 3 files changed, 3
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the genaclperms.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the hvsupport.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the check-file-access.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the group-qemu-caps.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
>
On Mon, Nov 18, 2019 at 10:06:34AM -0700, Alex Williamson wrote:
> Hey folks,
>
> We had some discussions at KVM Forum around mdev live migration and
> what that might mean for libvirt handling of mdev devices and
> potential libvirt/mdevctl[1] flows. I believe the current situation is
> that
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the test-wrap-argv.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
>
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the pdwtags processing script in Python.
>
> The original inline shell and perl code was completely
> unintelligible. The new python code is a manual conversion
> that
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the genpolkit.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the check-aclrules.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
>
On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the check-driverimpls.pl tool in Python.
>
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
On Fri, Nov 15, 2019 at 03:07:32PM -0500, Cole Robinson wrote:
> On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> > This series is an effort to reduce the number of different
> > languages we use by eliminating most use of perl in favour
> > of python.
>
> I'm testing the series now. On fedora
On Fri, Nov 15, 2019 at 04:50:57PM -0500, Cole Robinson wrote:
> On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> > As part of an goal to eliminate Perl from libvirt build tools,
> > rewrite the check-drivername.pl tool in Python.
> >
> > This was mostly a straight conversion, manually going
On 11/15/19 4:14 PM, Jiri Denemark wrote:
On Fri, Nov 15, 2019 at 15:55:04 +0100, Christian Borntraeger wrote:
On 15.11.19 15:47, Jiri Denemark wrote:
On Fri, Nov 15, 2019 at 15:12:18 +0100, Boris Fiuczynski wrote:
Just a heads up.
After installing libvirt rpms of this branch all my
On Mon, Nov 04, 2019 at 12:24:07PM +0100, Simon Kobyda wrote:
> Changes since v2:
> Implement and use virtDBusDomainSnapshotGetVirDomainSnapshot
> Add domain snapshot xml file to data/meson.build
> Fix flake8 style errors
>
> Simon Kobyda (2):
> Introduce Domain Snapshot Interface
>
On Fri, Nov 15, 2019 at 03:30:15PM -0500, Cole Robinson wrote:
> On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> > As part of an goal to eliminate Perl from libvirt build tools,
> > rewrite the check-spacing.pl tool in Python.
> >
> > This was a straight conversion, manually going line-by-line
Hey folks,
We had some discussions at KVM Forum around mdev live migration and
what that might mean for libvirt handling of mdev devices and
potential libvirt/mdevctl[1] flows. I believe the current situation is
that libvirt knows nothing about an mdev beyond the UUID in the XML.
It expects the
Initial implementation of 'auto-read-only' didn't reopen the backing
files when needed. For '-blockdev' to work we need to be able to tel
qemu to open a file read-only and change it during blockjobs as we label
backing chains with a sVirt label which does not allow writing. The
dynamic
Now that all pieces are in place (hopefully) let's enable -blockdev.
We base the capability on presence of the fix for 'auto-read-only' on
files so that blockdev works properly, mandate that qemu supports
explicit SCSI id strings to avoid ABI regression and that the fix for
'savevm' is present so
The 'savevm' HMP command didn't work properly with blockdev as it tried
to do snapshot of everything including the protocol nodes accessing
files which are not snapshottable. Qemu fixed this bug so now we need to
detect it to allow enabling blockdev.
Signed-off-by: Peter Krempa
---
The top level commands now can have 'feature' flags for fixes so add
support for querying those as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_qapi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c
index
Historically we've only supported the as an output-only
element for domain disks. The documentation states that it may become
supported on input. To allow management apps detectin once that happens
add a domain capability which will be asserted if the hypervisor driver
will be able to obey the
Until now we've only supported in an output mode. The
documentation for the element states that hypervisor drivers may start
to obey it in the future.
Update the documentation so that it mentions the recently added
'backingStoreInput' domain capability and explain what happens if it is
supported
The qemu driver will obey when we support blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 7c30768379..a057318432 100644
---
This patchset depends on:
https://www.redhat.com/archives/libvir-list/2019-November/msg00762.html
everything together is available at:
git fetch https://gitlab.com/pipo.sk/libvirt.git blockdev-enable
Looks like finally all pieces are together. Let's enable it.
Peter Krempa (8):
conf:
On Mon, Nov 18, 2019 at 17:49:25 +0100, Ján Tomko wrote:
> This flag is not implied by g_mkostemp_full, only by g_mkostemp.
Your patch fixes 'g_mkstemp_full' not mkostemp.
> Signed-off-by: Ján Tomko
> Reported-by: Bjoern Walk
> Fixes: 4ac47730408eaf91683f6502ec10541f4f711a5c
> ---
Since I
This flag is not implied by g_mkostemp_full, only by g_mkostemp.
Signed-off-by: Ján Tomko
Reported-by: Bjoern Walk
Fixes: 4ac47730408eaf91683f6502ec10541f4f711a5c
---
src/qemu/qemu_driver.c | 4 ++--
src/storage/storage_util.c | 2 +-
src/util/virlog.c | 2 +-
On Mon, Nov 18, 2019 at 05:12:23PM +0100, Bjoern Walk wrote:
> Hey all,
>
> commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh
> edit` (at least on S390):
This change didn't request any access bits so the temp files are
all being created with O_RDONLY.
openat(AT_FDCWD,
On Mon, Nov 18, 2019 at 05:12:23PM +0100, Bjoern Walk wrote:
Hey all,
commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh
Oops,
edit` (at least on S390):
virsh # edit test
error: write: /tmp/virshQ7SXB0.xml: failed to write to temporary file: Bad
file descriptorx
Hey all,
commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh
edit` (at least on S390):
virsh # edit test
error: write: /tmp/virshQ7SXB0.xml: failed to write to temporary file: Bad
file descriptorx
I didn't find out why, everything looks normal:
# ls -l
On Mon, Nov 18, 2019 at 11:28:08 -0300, Daniel Henrique Barboza wrote:
>
>
> On 11/18/19 10:53 AM, Peter Krempa wrote:
> > On Mon, Nov 18, 2019 at 14:47:03 +0100, Michal Privoznik wrote:
> > > On 11/18/19 2:27 PM, Daniel Henrique Barboza wrote:
> > >
> > > I believe it was John who persuaded us
On 11/18/19 10:53 AM, Peter Krempa wrote:
On Mon, Nov 18, 2019 at 14:47:03 +0100, Michal Privoznik wrote:
On 11/18/19 2:27 PM, Daniel Henrique Barboza wrote:
I believe it was John who persuaded us to use explicit integer comparison
for integer variables. The idea is that it's clear from the
On Mon, Nov 18, 2019 at 03:20:00PM +0100, Erik Skultety wrote:
> On Mon, Nov 18, 2019 at 01:50:03PM +, Daniel P. Berrangé wrote:
> > On Mon, Nov 18, 2019 at 02:26:31PM +0100, Erik Skultety wrote:
> > > On Mon, Nov 18, 2019 at 01:04:01PM +, Daniel P. Berrangé wrote:
> > > > On Mon, Nov 18,
On Mon, Nov 18, 2019 at 01:50:03PM +, Daniel P. Berrangé wrote:
> On Mon, Nov 18, 2019 at 02:26:31PM +0100, Erik Skultety wrote:
> > On Mon, Nov 18, 2019 at 01:04:01PM +, Daniel P. Berrangé wrote:
> > > On Mon, Nov 18, 2019 at 01:18:19PM +0100, Erik Skultety wrote:
> > > > It doesn't make
On Mon, Nov 18, 2019 at 14:47:03 +0100, Michal Privoznik wrote:
> On 11/18/19 2:27 PM, Daniel Henrique Barboza wrote:
> >
> >
> > On 11/14/19 6:58 PM, John Ferlan wrote:
> > > We go through the trouble of checking {old|new}Bandwidth[->in] and
> > > storing the result in local @old_floor and
On Mon, Nov 18, 2019 at 02:26:31PM +0100, Erik Skultety wrote:
> On Mon, Nov 18, 2019 at 01:04:01PM +, Daniel P. Berrangé wrote:
> > On Mon, Nov 18, 2019 at 01:18:19PM +0100, Erik Skultety wrote:
> > > It doesn't make sense to pass a target buffer into an API, declaring its
> > > size as 0 and
On 11/18/19 2:27 PM, Daniel Henrique Barboza wrote:
On 11/14/19 6:58 PM, John Ferlan wrote:
We go through the trouble of checking {old|new}Bandwidth[->in] and
storing the result in local @old_floor and @new_floor, but then
we don't use them. Instead we make derefs to the longer name. This
On Mon, Nov 18, 2019 at 01:04:01PM +, Daniel P. Berrangé wrote:
> On Mon, Nov 18, 2019 at 01:18:19PM +0100, Erik Skultety wrote:
> > It doesn't make sense to pass a target buffer into an API, declaring its
> > size as 0 and expect some meaningful result. Since this used to work
> > pre-Glib
On 11/14/19 6:58 PM, John Ferlan wrote:
We go through the trouble of checking {old|new}Bandwidth[->in] and
storing the result in local @old_floor and @new_floor, but then
we don't use them. Instead we make derefs to the longer name. This
caused Coverity to note dereferencing newBandwidth->in
On 11/14/19 6:58 PM, John Ferlan wrote:
If networkAllocatePort calls networkPlugBandwidth eventually the
port->bandwidth would be passed to virNetDevBandwidthPlug which
requires that the parameter is non-NULL. Coverity additionally
notes that since (!port->bandwidth) is checked earlier in
On 11/14/19 6:58 PM, John Ferlan wrote:
Since g_strdup_printf will abort, we know @newfile won't be NULL.
Found by Coverity
Signed-off-by: John Ferlan
---
Reviewed-by: Daniel Henrique Barboza
--
libvir-list mailing list
libvir-list@redhat.com
On 11/18/19 9:57 AM, Erik Skultety wrote:
qemuDomainDefFormatBufInternal function wasn't testing whether the CPU
was actually defined in the XML and saving such a domain resulted in the
following backtrace:
0 in qemuDomainMakeCPUMigratable (cpu=0x0)
1 in qemuDomainDefFormatBufInternal()
2 in
On Mon, Nov 18, 2019 at 01:18:19PM +0100, Erik Skultety wrote:
> It doesn't make sense to pass a target buffer into an API, declaring its
> size as 0 and expect some meaningful result. Since this used to work
> pre-Glib era, we shouldn't end with an error, but we can return 0
> for the number of
qemuDomainDefFormatBufInternal function wasn't testing whether the CPU
was actually defined in the XML and saving such a domain resulted in the
following backtrace:
0 in qemuDomainMakeCPUMigratable (cpu=0x0)
1 in qemuDomainDefFormatBufInternal()
2 in qemuDomainDefFormatXMLInternal()
3 in
It doesn't make sense to pass a target buffer into an API, declaring its
size as 0 and expect some meaningful result. Since this used to work
pre-Glib era, we shouldn't end with an error, but we can return 0
for the number of domains immediately, instead of calling into the
daemon, which is
After libvirt switched to GLib, we also started to use glib allocation
primitives as of commit e85e34f3. Unlike malloc which is ambiguous with
regards to size == 0 (which in our case returned a unique pointer safe
to be passed to free), g_malloc0 strictly returns NULL on size == 0.
This change
This happens because of the switch to glib whose method g_malloc0 actually
correctly returns NULL on size 0 which doesn't make sense to do. The outcome of
that is that because virAllocN always returns 0, the dispatch code never fails
allocation and passes the NULL pointer to the server-side public
Signed-off-by: Erik Skultety
---
src/rpc/gendispatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
index 7c868191d1..8656c8f205 100755
--- a/src/rpc/gendispatch.pl
+++ b/src/rpc/gendispatch.pl
@@ -1062,7 +1062,7 @@
On Sat, 2019-11-16 at 00:35 +, Jim Fehlig wrote:
> On 9/13/19 9:28 AM, Andrea Bolognani wrote:
> > [...] you're definitely going to have to:
> >
> >* add OpenSUSE 12 and 15 to inventory and host_vars/;
> >
> >* write an AutoYaST configuration file that can be used to install
> >
On 11/8/19 11:20 AM, Pavel Hrdina wrote:
Commit reworked process
affinity setting but did not take cgroups into account which introduced
an issue when starting VM with custom cpuset.cpus for the whole machine
group.
If the machine group is limited to some pCPUs libvirt should not try to
set a
On Sun, 2019-11-17 at 20:17 -0500, Cole Robinson wrote:
> On 11/15/19 10:58 AM, Jonathon Jongsma wrote:
> > Signed-off-by: Jonathon Jongsma
> > ---
> > v2:
> > Made changes suggested by Andrea. I'll need somebody to push this for me ;)
>
> I pushed it with Andrea's RB tag
Oh, I forgot you
In virCgroupV2DevicesReallocMap() we are debug printing both
arguments passed to the function. However, the @size argument is
type of size_t but '%lu' is used to format it.
Signed-off-by: Michal Privoznik
---
src/util/vircgroupv2devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Both are trivial and fix a build issue on my 32bit machine so I've
pushed them already.
Michal Prívozník (2):
vircgroupv2devices: Fix format string for size_t variable
virbpf: Fix typecast to __aligned_u64 type
src/util/virbpf.c | 32
In functions implemented here we fill this attr union (type of
bpf_attr) and just pass it to syscall(2). Thing is that some of
the union members are type of __aligned_u64. This is not regular
uint64_t. This one is explicitly aligned to 8 bytes, while
uint64_t can be aligned to 4 bytes (on 32
62 matches
Mail list logo
