On Mon, Nov 11, 2019 at 02:38:14PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-driverimpls.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the
On Tue, Nov 19, 2019 at 3:25 PM Pavel Hrdina wrote:
>
> Last usage was removed by commit
> <41f6198e231285cc813f8c0687c8ec5c9488> and commit
> <0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
>
> Signed-off-by: Pavel Hrdina
> ---
> bootstrap.conf | 1 -
>
On Tue, Nov 19, 2019 at 9:00 PM Jonathon Jongsma wrote:
>
> Signed-off-by: Jonathon Jongsma
> ---
> src/libvirt-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 02622cb2ca..2d9c4061e2 100644
> ---
On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
>
> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> > On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> >> Signed-off-by: Jim Fehlig
> >> ---
> >> guests/configs/autoinst.xml | 86 +++
> >>
On Wed, Nov 20, 2019 at 12:11 AM Jim Fehlig wrote:
>
> On 11/19/19 6:52 AM, Fabiano Fidêncio wrote:
> > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani
> > wrote:
> >>
> >> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> >>> Signed-off-by: Jim Fehlig
> >>> ---
> >>>
On Mon, Nov 11, 2019 at 02:38:13PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-drivername.pl tool in Python.
This was mostly a straight conversion, manually going line-by-line
to change the syntax from Perl to Python. Thus
On Mon, Nov 11, 2019 at 02:38:12PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the gensystemtap.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
On Mon, Nov 11, 2019 at 02:38:11PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the dtrace2systemtap.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the
On Mon, Nov 11, 2019 at 02:38:10PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-symfile.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
> From: Alex Williamson
> Sent: Wednesday, November 20, 2019 6:58 AM
>
> On Fri, 15 Nov 2019 04:24:35 +
> "Tian, Kevin" wrote:
>
> > > From: Alex Williamson
> > > Sent: Thursday, November 7, 2019 2:45 AM
> > >
> > > On Wed, 6 Nov 2019 12:20:31 +0800
> > > Zhenyu Wang wrote:
> > >
> > > >
On 11/19/19 6:52 AM, Fabiano Fidêncio wrote:
> On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani wrote:
>>
>> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
>>> Signed-off-by: Jim Fehlig
>>> ---
>>> guests/configs/autoinst.xml | 86 +++
>>>
On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
>> Signed-off-by: Jim Fehlig
>> ---
>> guests/configs/autoinst.xml | 86 +++
>> .../libvirt-opensuse-15.1/docker.yml | 2 +
>>
On Fri, 15 Nov 2019 04:24:35 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Thursday, November 7, 2019 2:45 AM
> >
> > On Wed, 6 Nov 2019 12:20:31 +0800
> > Zhenyu Wang wrote:
> >
> > > On 2019.11.05 14:10:42 -0700, Alex Williamson wrote:
> > > > On Thu, 24 Oct 2019
On Thu, 14 Nov 2019, Cole Robinson wrote:
> On 10/24/19 4:57 AM, Arnaud Patard wrote:
> > When emulating smartcard with host certificates, qemu needs to
> > be able to read the certificates files, which is denied by apparmor.
> > Add necessary code to add the smartcard certificates related
On Thu, 14 Nov 2019, Christian Ehrhardt wrote:
> It was mentioned that the pointers in loops like:
> for (i = 0; i < ctl->def->nserials; i++)
> if (ctl->def->serials[i] ...
> will always be !NULL or we would have a much more serious problem.
>
> Simplify the if chains in get_files by
On Tue, 22 Oct 2019, Christian Ehrhardt wrote:
> Shared memory devices need qemu to be able to access certain paths
> either for the shared memory directly (mostly ivshmem-plain) or for a
> socket (mostly ivshmem-doorbell).
>
> Add logic to virt-aa-helper to render those apparmor rules based
>
On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> There are currently broken use cases, e.g. snapshotting more than one disk at
> once like:
> $ virsh snapshot-create-as --domain eoan --disk-only --atomic
>--diskspec vda,snapshot=no --diskspec vdb,snapshot=no
>--diskspec
On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> A lot of the code in AppArmorSetSecurityImageLabel is a duplicate of
> what is in reload_profile, this refactors AppArmorSetSecurityImageLabel
> to use reload_profile instead.
>
> Signed-off-by: Christian Ehrhardt
> ---
>
On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> reload_profile calls get_profile_name for no particular gain, lets
> remove that call. The string isn't used in that function later on
> and not registered/passed anywhere.
>
> It can only fail if it either can't allocate or if the
>
On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> While only used internally from libvirt the options still are misleading
> enough to cause issues every now and then.
> Group modes, options and an adding extra file and extend the wording of
> the latter which had the biggest lack of clarity.
>
Signed-off-by: Jonathon Jongsma
---
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 02622cb2ca..2d9c4061e2 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12272,7 +12272,7 @@
On 11/19/19 12:39 PM, LanceLiu wrote:
(gdb) thread 23
[Switching to thread 23 (Thread 0x7fbb54810700 (LWP 296966))]
(gdb) bt
at rpc/virnetserverclient.c:1503
client=client@entry=0x5641d20e20a0, msg=0x7fbb08003ab0,
rerr=rerr@entry=0x7fbb5480f7b0, procedure=201,
type=type@entry=3,
On Mon, Nov 11, 2019 at 02:38:09PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the check-symsorting.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the
Hi Cole!
Thanks for your review and suggestion.
I admit that I'm not a CGroups expert.
IHMO, when you allow a device (with virCgroupAllowDevice) for a
specific CGroup that device would be automatically added into
io_serviced monitor.
But this is not happening. I tested with a stand alone
On 11/12/19 9:46 PM, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_cgroup.c | 15 ++--
src/qemu/qemu_domain.c | 84 +++
src/qemu/qemu_domain_address.c | 31 +++
src/qemu/qemu_driver.c | 145
On 11/12/19 9:46 PM, Daniel Henrique Barboza wrote:
changes from v1 [1], all suggested by Ján Tomko:
- qemu patch (former patch 10):
* qemu_driver.c: using 'return -1' instead of 'return ret' in
qemuDumpToFd()
and qemuDomainBlockPivot()
* qemu_hotplug.c: removed the use of
(gdb) thread 23
[Switching to thread 23 (Thread 0x7fbb54810700 (LWP 296966))]
(gdb) bt
at rpc/virnetserverclient.c:1503
client=client@entry=0x5641d20e20a0, msg=0x7fbb08003ab0,
rerr=rerr@entry=0x7fbb5480f7b0, procedure=201,
type=type@entry=3, serial=9) at rpc/virnetserverprogram.c:173
Last usage was removed by commit
<41f6198e231285cc813f8c0687c8ec5c9488> and commit
<0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 1 -
src/qemu/qemu_monitor_json.c | 1 -
2 files changed, 2 deletions(-)
diff
On 11/19/19 12:08 PM, Peter Krempa wrote:
Peter Krempa (3):
tests: schema: Simplify memory handling using g_autofree
tests: utils: Introduce helper for dispatching libvirt errors
tests: virschema: Propagate errors from directory traversal in
testSchemaDir
tests/testutils.c |
On Mon, Nov 18, 2019 at 18:34:36 +0100, Boris Fiuczynski wrote:
>
>
> On 11/15/19 4:14 PM, Jiri Denemark wrote:
> > On Fri, Nov 15, 2019 at 15:55:04 +0100, Christian Borntraeger wrote:
> >>
> >>
> >> On 15.11.19 15:47, Jiri Denemark wrote:
> >>> On Fri, Nov 15, 2019 at 15:12:18 +0100, Boris
On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani wrote:
>
> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> > Signed-off-by: Jim Fehlig
> > ---
> > guests/configs/autoinst.xml | 86 +++
> > .../libvirt-opensuse-15.1/docker.yml | 2 +
> >
If user starts a blockcommit without --pivot or a blockcopy also
without --pivot then we modify access for qemu on both images and
leave it like that until pivot is executed. So far so good.
Problem is, if user instead of issuing pivot calls destroy on the
domain or if qemu dies whilst executing
On Mon, Nov 11, 2019 at 02:38:08PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
I just realized all of these say "an goal" in the commit message.
rewrite the check-aclperms.pl tool in Python.
This was a straight conversion, manually going
On Mon, Nov 11, 2019 at 02:38:07PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the header-ifdef.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
On 11/19/19 10:31 AM, Peter Krempa wrote:
On Tue, Nov 19, 2019 at 10:14:09 +0100, Michal Privoznik wrote:
In subject, please remove 'Simulate blockjob --abort' and replace it
e.g. with: 'remove image metadata for running mirror jobs' or something
similar, because this patch does not really do
On Mon, Nov 11, 2019 at 02:38:06PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the mock-noinline.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
Peter Krempa (3):
tests: schema: Simplify memory handling using g_autofree
tests: utils: Introduce helper for dispatching libvirt errors
tests: virschema: Propagate errors from directory traversal in
testSchemaDir
tests/testutils.c | 29 +
testSchemaDir is a helper which invokes the schema test using virTestRun
on all schema files. Since the function itself is not called inside
virTestRun any helper function call is not dispatched to the user and
thus it's hard to debug the test. Propagate errors from the directory
traversal.
In cases when we call a libvirt helper which reports an error the error
would be hidden unless libvirt library debug is on. This produces a lot
of output and is hard to debug.
The helper provides a way to dispatch the libvirt error in specific
cases sice we do already dispatch it in case when
Refactor various functions to avoid multiple freeing function calls.
Signed-off-by: Peter Krempa
---
tests/virschematest.c | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index 5d092d8c8e..8a2322b3bd
On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> guests/configs/autoinst.xml | 86 +++
> .../libvirt-opensuse-15.1/docker.yml | 2 +
> .../libvirt-opensuse-15.1/install.yml | 2 +
>
It has come to our attention that many, possibly even all, people with
non-redhat.com email addresses are unable to send mail to most libvirt
mailing lists, receiving bounce messages saying the address doesn't
exist eg
Final-Recipient: rfc822; libvirt-us...@redhat.com
Action: failed
Status:
On Tue, Nov 19, 2019 at 10:14:09 +0100, Michal Privoznik wrote:
In subject, please remove 'Simulate blockjob --abort' and replace it
e.g. with: 'remove image metadata for running mirror jobs' or something
similar, because this patch does not really do anything with the job
itself.
> If user
On 11/19/19 10:04 AM, Erik Skultety wrote:
On Tue, Nov 19, 2019 at 09:58:42AM +0100, Michal Privoznik wrote:
The @def variable holds pointer to the domain defintion, but is
set only somewhere in the middle of the function. This is
suboptimal.
Signed-off-by: Michal Privoznik
---
On Tue, Nov 19, 2019 at 10:14:08 +0100, Michal Privoznik wrote:
> There are four places where we remove image XATTRs and in all of
> them we have the same for() loop with the same body. Move it into
> a separate function because I'm about to introduce fifth place
> where the same needs to be done.
See 2/2 for explanation.
Michal Prívozník (2):
qemu: Separate image metadata removal into a function
qemuProcessStop: Simulate blockjob --abort on destroy
src/qemu/qemu_block.c| 25 ++
src/qemu/qemu_block.h| 6 ++
src/qemu/qemu_blockjob.c | 45
There are four places where we remove image XATTRs and in all of
them we have the same for() loop with the same body. Move it into
a separate function because I'm about to introduce fifth place
where the same needs to be done.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_block.c| 25
If user starts a blockcommit without --pivot then we modify
access for qemu on both images and leave it like that until
pivot is executed. So far so good. Problem is, if user instead
of issuing pivot calls destroy on the domain. In this case we
don't ever clear the access we granted at the
On Tue, Nov 19, 2019 at 09:58:42AM +0100, Michal Privoznik wrote:
> The @def variable holds pointer to the domain defintion, but is
> set only somewhere in the middle of the function. This is
> suboptimal.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_process.c | 4 ++--
> 1 file
The @def variable holds pointer to the domain defintion, but is
set only somewhere in the middle of the function. This is
suboptimal.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_process.c
Jim,
On Tue, Nov 19, 2019 at 1:40 AM Jim Fehlig wrote:
>
> On 11/18/19 5:21 PM, Jim Fehlig wrote:
> > Signed-off-by: Jim Fehlig
> > ---
> > guests/configs/autoinst.xml | 86 +++
> > .../libvirt-opensuse-15.1/docker.yml | 2 +
> >
51 matches
Mail list logo
