On Wed, Nov 20, 2019 at 18:12:18 +0100, Pavel Mores wrote:
> On Wed, Nov 20, 2019 at 12:14:11PM +0100, Peter Krempa wrote:
> > On Wed, Nov 20, 2019 at 11:44:52 +0100, Pavel Mores wrote:
> > > Since the blockcommit operation is asynchronous, this has conceptually two
> > > parts. First, we have to
On Thu, Nov 14, 2019 at 12:23 PM Christian Ehrhardt
wrote:
>
> On Thu, Nov 14, 2019 at 1:23 AM Cole Robinson wrote:
> >
> > On 10/16/19 10:27 AM, Christian Ehrhardt wrote:
> > > Hi,
> > > the bugs [1][2] that made me debug into this actually only need the
> > > last patch (one line), but while
On Thu, Nov 14, 2019 at 12:20 PM Christian Ehrhardt
wrote:
>
> Cole was recently adding a few of the usual apparmor suspects to BZ 1761645
> and I was taking a look at the low hanging fruits of it today. It isn't
> perfect, but would resolve the reported issue - so I'd appreciate a
> review.
>
>
On Wed, Nov 20, 2019 at 10:46 PM Jim Fehlig wrote:
>
> On 11/20/19 2:16 PM, Fabiano Fidêncio wrote:
> > On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote:
> >>
> >> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
> >>> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
>
> On 11/19/19
On 11/20/19 2:16 PM, Fabiano Fidêncio wrote:
> On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote:
>>
>> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
>>> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> On Tue, 2019-11-19 at 00:21
On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote:
>
> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
> > On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
> >>
> >> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> >>> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
>
> [...]
>
> +++
On 11/20/19 1:03 AM, Andrea Bolognani wrote:
> On Wed, 2019-11-20 at 07:56 +0100, Fabiano Fidêncio wrote:
>> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
>>> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
As for os_version, if you look at all existing entries we use the
major
On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
>>
>> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
>>> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
[...]
+++ b/guests/host_vars/libvirt-opensuse-15.1/main.yml
+package_format:
On 11/20/19 4:34 PM, Daniel Henrique Barboza wrote:
On 11/20/19 3:32 PM, Ján Tomko wrote:
This shaves off 4 % of syntax-check runtime on my 8-core system,
which is enough of a reason for me.
Around 10% increase on my system running 'make -j syntax-check'.
In time: *performance*
On 11/20/19 3:32 PM, Ján Tomko wrote:
This shaves off 4 % of syntax-check runtime on my 8-core system,
which is enough of a reason for me.
Around 10% increase on my system running 'make -j syntax-check'.
All patches:
Reviewed-by: Daniel Henrique Barboza
--
libvir-list mailing
Signed-off-by: Ján Tomko
---
scripts/check-aclrules.py| 2 +-
scripts/check-driverimpls.py | 2 +-
scripts/check-symfile.py | 6 +++---
scripts/dtrace2systemtap.py | 4 ++--
scripts/genpolkit.py | 4 ++--
scripts/gensystemtap.py | 2 +-
6 files changed, 10 insertions(+), 10
Running regular expressions with capture groups is expensive.
Bail out early if the line does not start with a '#'.
This reduces the runtime of the check by two thirds.
Signed-off-by: Ján Tomko
---
scripts/prohibit-duplicate-header.py | 4
1 file changed, 4 insertions(+)
diff --git
Use a simple
if "substr" in line
before running a regular expression, which saves time,
especially if the regex has a capture group.
This reduces runtime of the check by almost 78 % for me.
Signed-off-by: Ján Tomko
---
scripts/check-aclrules.py | 26 +++---
1 file
For checking whether a substring is present in a string,
using the pattern:
"str" in string
is slightly faster than:
string.find("str") != -1
Use it to shave off 4 % of the runtime of this script that
processes quite a few long source files.
Signed-off-by: Ján Tomko
---
This shaves off 4 % of syntax-check runtime on my 8-core system,
which is enough of a reason for me.
Surely it saves more on our overloaded CI workers.
Ján Tomko (3):
scripts: speedup prohibit-duplicate-header
scripts: check-aclrules: use in instead of find
scripts: check-aclrules: use
On 11/20/19 9:40 AM, Peter Krempa wrote:
> On Mon, Nov 18, 2019 at 14:43:08 -0500, Cole Robinson wrote:
>> On 11/13/19 11:05 AM, Peter Krempa wrote:
>>> For future extensions of the domain caps it's useful to have a single
>>> point that initializes all capabilities as unsupported by a driver. The
On 11/20/19 12:25 PM, Jamie Strandboge wrote:
> On Wed, 20 Nov 2019, Cole Robinson wrote:
>
>> On 11/19/19 4:31 PM, Jamie Strandboge wrote:
>>> On Thu, 14 Nov 2019, Christian Ehrhardt wrote:
>>>
It was mentioned that the pointers in loops like:
for (i = 0; i < ctl->def->nserials; i++)
On Wed, 20 Nov 2019, Cole Robinson wrote:
> On 11/19/19 4:31 PM, Jamie Strandboge wrote:
> > On Thu, 14 Nov 2019, Christian Ehrhardt wrote:
> >
> >> It was mentioned that the pointers in loops like:
> >> for (i = 0; i < ctl->def->nserials; i++)
> >> if (ctl->def->serials[i] ...
> >> will
On Wed, 20 Nov 2019, Christian Ehrhardt wrote:
> On Tue, Nov 19, 2019 at 10:25 PM Jamie Strandboge wrote:
> > On Tue, 22 Oct 2019, Christian Ehrhardt wrote:
> > > +for (i = 0; i < ctl->def->nshmems; i++) {
> > > +if (ctl->def->shmems[i]) {
> > > +virDomainShmemDef *shmem =
On Wed, 20 Nov 2019, Christian Ehrhardt wrote:
> On Wed, Nov 20, 2019 at 3:40 PM Christian Ehrhardt
> wrote:
> >
> > On Tue, Nov 19, 2019 at 10:12 PM Jamie Strandboge
> > wrote:
> > >
> > > On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> > >
> > > > There are currently broken use cases, e.g.
On Wed, Nov 20, 2019 at 12:14:11PM +0100, Peter Krempa wrote:
> On Wed, Nov 20, 2019 at 11:44:52 +0100, Pavel Mores wrote:
> > Since the blockcommit operation is asynchronous, this has conceptually two
> > parts. First, we have to propagate the flag from qemuDomainBlockCommit()
> > (which was
On Wed, Nov 20, 2019 at 03:28:47PM +, Daniel P. Berrangé wrote:
> Some of the web content is only present in the source tree, thus when
> viewing pages from the build tree they appear missing.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/Makefile.am | 24
> 1
Jamie Strandboge writes:
> On Thu, 14 Nov 2019, Cole Robinson wrote:
>
>> On 10/24/19 4:57 AM, Arnaud Patard wrote:
>> > When emulating smartcard with host certificates, qemu needs to
>> > be able to read the certificates files, which is denied by apparmor.
>> > Add necessary code to add the
On 11/19/19 4:31 PM, Jamie Strandboge wrote:
> On Thu, 14 Nov 2019, Christian Ehrhardt wrote:
>
>> It was mentioned that the pointers in loops like:
>> for (i = 0; i < ctl->def->nserials; i++)
>> if (ctl->def->serials[i] ...
>> will always be !NULL or we would have a much more serious
On 11/20/19 2:35 PM, Pino Toscano wrote:
Getting the hostname of guest usually requires a in-guest agent, or
generally can be determined only on active domains.
Signed-off-by: Pino Toscano
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Michal
On Tue, Nov 19, 2019 at 10:00:05AM +, Daniel P. Berrangé wrote:
> It has come to our attention that many, possibly even all, people with
> non-redhat.com email addresses are unable to send mail to most libvirt
> mailing lists, receiving bounce messages saying the address doesn't
> exist eg
>
On Wed, Nov 20, 2019 at 3:40 PM Christian Ehrhardt
wrote:
>
> On Tue, Nov 19, 2019 at 10:12 PM Jamie Strandboge wrote:
> >
> > On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
> >
> > > There are currently broken use cases, e.g. snapshotting more than one
> > > disk at
> > > once like:
> > > $
The XSL generator loads included HTML files relative to the source dir
but we need to tell it to load them from the build dir instead.
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 1 +
docs/newapi.xsl | 1 -
docs/page.xsl| 4 +++-
3 files changed, 4 insertions(+), 2
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 5 -
1 file changed, 5 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index db9470ae07..50b2fd7066 100644
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -232,11 +232,6 @@ timestamp="$(shell if test -n
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index 5f59d057f1..a360b546d6 100644
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -146,18 +146,6 @@ dot_html =
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 44 +++-
docs/docs.html.in | 4
docs/newapi.xsl | 13 +++--
3 files changed, 54 insertions(+), 7 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index
Some of the web content is only present in the source tree, thus when
viewing pages from the build tree they appear missing.
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 24
1 file changed, 24 insertions(+)
diff --git a/docs/Makefile.am b/docs/Makefile.am
The API cross reference files are not used since
commit d3043afe5ceebd5002bff45db38bb33e090bb4af
Author: Daniel Veillard
Date: Mon Jan 21 08:08:33 2008 +
Remove docs/API*.html
* docs/API* docs/api.xsl docs/site.xsl docs/Makefile.am: remove the
generation of the
There were a few problems in the docs build from the vpath build
https://www.redhat.com/archives/libvir-list/2019-November/msg00308.html
- We can't browse the website from the build dir
- Including of the acl permissions was broken
This series fixes those two problems and also fixes the
Define automake variables for all the data we need built and installed
and let automake generate the install rules normally.
Signed-off-by: Daniel P. Berrangé
---
docs/Makefile.am | 80 +---
1 file changed, 21 insertions(+), 59 deletions(-)
diff
Signed-off-by: Pavel Hrdina
---
src/internal.h | 4 ++--
tests/virhashtest.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/internal.h b/src/internal.h
index 0ff9f496ac..0780e2a2a3 100644
--- a/src/internal.h
+++ b/src/internal.h
@@ -75,9 +75,9 @@
/* String
Signed-off-by: Pavel Hrdina
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index f1e976ec76..047c48ae83 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -588,7 +588,7
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index abb03bf3a2..d0a39537eb 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -21,7 +21,6 @@ gnulib_modules='
accept
bind
c-ctype
-c-strcase
canonicalize-lgpl
On 11/20/19 10:35 AM, Pino Toscano wrote:
Getting the hostname of guest usually requires a in-guest agent, or
generally can be determined only on active domains.
Signed-off-by: Pino Toscano
---
Reviewed-by: Daniel Henrique Barboza
--
libvir-list mailing list
libvir-list@redhat.com
Signed-off-by: Pavel Hrdina
---
src/internal.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/internal.h b/src/internal.h
index 0780e2a2a3..3d1e21f0cf 100644
--- a/src/internal.h
+++ b/src/internal.h
@@ -63,7 +63,6 @@
#include "libvirt/libvirt-admin.h"
#include
Pavel Hrdina (4):
use g_ascii_strcasecmp instead of c_strcasecmp from gnulib
use g_ascii_strncasecmp instead of c_strncasecmp from gnulib
syntax-check: update strcase check to refer to GLib
bootstrap.conf: drop usage of c-strcase gnulib module
bootstrap.conf| 1 -
On Tue, Nov 19, 2019 at 10:31 PM Jamie Strandboge wrote:
>
> On Thu, 14 Nov 2019, Christian Ehrhardt wrote:
>
> > It was mentioned that the pointers in loops like:
> > for (i = 0; i < ctl->def->nserials; i++)
> > if (ctl->def->serials[i] ...
> > will always be !NULL or we would have a
Signed-off-by: Pavel Hrdina
---
src/util/virmacaddr.c | 6 +++---
src/util/virutil.c| 2 +-
src/util/viruuid.c| 5 ++---
src/vmx/vmx.c | 2 +-
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c
index 3eb6407c45..a6893faf9a
Signed-off-by: Pavel Hrdina
---
src/bhyve/bhyve_parse_command.c| 3 +--
src/conf/nwfilter_conf.c | 3 +--
src/interface/interface_backend_udev.c | 3 +--
src/rpc/virnetsocket.c | 3 +--
src/util/virhostcpu.c | 7 +++
Signed-off-by: Pavel Hrdina
---
build-aux/syntax-check.mk | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index f1e976ec76..fd8c2c6be5 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@
Signed-off-by: Pavel Hrdina
---
src/conf/network_conf.c | 3 +--
src/qemu/qemu_domain.c | 3 +--
src/qemu/qemu_qapi.c| 4 +---
src/util/virconf.c | 2 +-
src/util/virfile.c | 4 ++--
5 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/conf/network_conf.c
Signed-off-by: Pavel Hrdina
---
src/remote/remote_driver.c | 3 +--
src/util/virmacaddr.c | 5 ++---
src/util/virutil.c | 5 ++---
src/vmx/vmx.c | 6 ++
tools/virsh-domain.c | 3 +--
tools/vsh.c| 3 +--
6 files changed, 9 insertions(+), 16
Signed-off-by: Pavel Hrdina
---
src/util/virstring.c | 3 +--
tools/virsh-console.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/util/virstring.c b/src/util/virstring.c
index 311c9058db..bd7c640042 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_agent.c | 3 +--
src/qemu/qemu_monitor.c | 3 +--
src/util/virstring.c| 4 ++--
tools/vsh-table.c | 3 +--
4 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index abb03bf3a2..e1f715db37 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -20,7 +20,6 @@
gnulib_modules='
accept
bind
-c-ctype
c-strcase
canonicalize-lgpl
Signed-off-by: Pavel Hrdina
---
src/util/virutil.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index f965bb0e5d..f3cf494353 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -393,11 +393,11 @@ int
Signed-off-by: Pavel Hrdina
---
src/node_device/node_device_udev.c | 3 +--
src/util/virconf.c | 2 +-
src/util/virkeyfile.c | 4 ++--
tools/vsh.c| 2 +-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git
Signed-off-by: Pavel Hrdina
---
src/interface/interface_backend_udev.c | 2 +-
src/libxl/libxl_conf.c | 3 +--
src/storage/parthelper.c | 5 ++---
src/util/virbitmap.c | 5 ++---
src/util/virconf.c | 7 +++
GLib doesn't provide alternative to c_isascii and this is the only usage
of that macro so define a replacement ourselves.
Signed-off-by: Pavel Hrdina
---
src/util/virkeyfile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virkeyfile.c b/src/util/virkeyfile.c
Signed-off-by: Pavel Hrdina
---
tools/vsh-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/vsh-table.c b/tools/vsh-table.c
index 9008b0d431..28072c9719 100644
--- a/tools/vsh-table.c
+++ b/tools/vsh-table.c
@@ -226,7 +226,7 @@ vshTableSafeEncode(const char *s,
Changes in v2:
- fixed missing parentheses in patch 01
- added patch 02 to cover c_isascii
Pavel Hrdina (14):
util: define IS_BLANK instead of using c_isblank from gnulib
virkeyfile: define IS_ASCII instead c_isascii from gnulib
use g_ascii_isalnum instead of c_isalnum from gnulib
The same way how we have IS_EOL in two files where we actually need it
defince IS_BLANK so we can drop usage of c_isblank.
Signed-off-by: Pavel Hrdina
---
src/util/virconf.c| 7 ---
src/util/virkeyfile.c | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git
On Tue, Nov 19, 2019 at 10:25 PM Jamie Strandboge wrote:
>
> On Tue, 22 Oct 2019, Christian Ehrhardt wrote:
>
> > Shared memory devices need qemu to be able to access certain paths
> > either for the shared memory directly (mostly ivshmem-plain) or for a
> > socket (mostly ivshmem-doorbell).
> >
On Mon, Nov 18, 2019 at 14:54:50 -0500, Cole Robinson wrote:
> On 11/18/19 12:02 PM, Peter Krempa wrote:
> > Historically we've only supported the as an output-only
> > element for domain disks. The documentation states that it may become
> > supported on input. To allow management apps detectin
On Mon, Nov 18, 2019 at 14:43:08 -0500, Cole Robinson wrote:
> On 11/13/19 11:05 AM, Peter Krempa wrote:
> > For future extensions of the domain caps it's useful to have a single
> > point that initializes all capabilities as unsupported by a driver. The
> > driver then can enable specific ones.
>
On Tue, Nov 19, 2019 at 10:12 PM Jamie Strandboge wrote:
>
> On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
>
> > There are currently broken use cases, e.g. snapshotting more than one disk
> > at
> > once like:
> > $ virsh snapshot-create-as --domain eoan --disk-only --atomic
> >--diskspec
On Wed, Nov 20, 2019 at 15:10:17 +0100, Michal Privoznik wrote:
> On 11/20/19 12:17 PM, Peter Krempa wrote:
> > On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote:
> > > If user starts a blockcommit without --pivot or a blockcopy also
> > > without --pivot then we modify access for
On Wed, Nov 20, 2019 at 03:07:42PM +0100, Pavel Hrdina wrote:
> Pavel Hrdina (13):
> util: define IS_BLANK instead of using c_isblank from gnulib
> use g_ascii_isalnum instead of c_isalnum from gnulib
> use g_ascii_isalpha instead of c_isalpha from gnulib
> use g_ascii_iscntrl instead of
On Wed, Nov 20, 2019 at 14:56:18 +0100, Pavel Mores wrote:
> On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote:
> > On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote:
> > > When blockcommit finishes successfully, one of the
> > > qemuBlockJobProcessEventCompletedCommit() and
> >
On Tue, Nov 19, 2019 at 9:59 PM Jamie Strandboge wrote:
>
> On Wed, 16 Oct 2019, Christian Ehrhardt wrote:
>
> > A lot of the code in AppArmorSetSecurityImageLabel is a duplicate of
> > what is in reload_profile, this refactors AppArmorSetSecurityImageLabel
> > to use reload_profile instead.
> >
Signed-off-by: Pavel Hrdina
---
src/util/virmacaddr.c | 6 +++---
src/util/virutil.c| 2 +-
src/util/viruuid.c| 5 ++---
src/vmx/vmx.c | 2 +-
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c
index 3eb6407c45..a6893faf9a
On 11/20/19 12:17 PM, Peter Krempa wrote:
On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote:
If user starts a blockcommit without --pivot or a blockcopy also
without --pivot then we modify access for qemu on both images and
leave it like that until pivot is executed. So far so
Signed-off-by: Pavel Hrdina
---
build-aux/syntax-check.mk | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index f1e976ec76..fd8c2c6be5 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@
Signed-off-by: Pavel Hrdina
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index abb03bf3a2..e1f715db37 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -20,7 +20,6 @@
gnulib_modules='
accept
bind
-c-ctype
c-strcase
canonicalize-lgpl
Signed-off-by: Pavel Hrdina
---
src/interface/interface_backend_udev.c | 2 +-
src/libxl/libxl_conf.c | 3 +--
src/storage/parthelper.c | 5 ++---
src/util/virbitmap.c | 5 ++---
src/util/virconf.c | 7 +++
Signed-off-by: Pavel Hrdina
---
src/node_device/node_device_udev.c | 3 +--
src/util/virconf.c | 2 +-
src/util/virkeyfile.c | 4 ++--
tools/vsh.c| 2 +-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git
The same way how we have IS_EOL in two files where we actually need it
defince IS_BLANK so we can drop usage of c_isblank.
Signed-off-by: Pavel Hrdina
---
src/util/virconf.c| 7 ---
src/util/virkeyfile.c | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Pavel Hrdina
---
src/bhyve/bhyve_parse_command.c| 3 +--
src/conf/nwfilter_conf.c | 3 +--
src/interface/interface_backend_udev.c | 3 +--
src/rpc/virnetsocket.c | 3 +--
src/util/virhostcpu.c | 7 +++
Signed-off-by: Pavel Hrdina
---
src/remote/remote_driver.c | 3 +--
src/util/virmacaddr.c | 5 ++---
src/util/virutil.c | 5 ++---
src/vmx/vmx.c | 6 ++
tools/virsh-domain.c | 3 +--
tools/vsh.c| 3 +--
6 files changed, 9 insertions(+), 16
Pavel Hrdina (13):
util: define IS_BLANK instead of using c_isblank from gnulib
use g_ascii_isalnum instead of c_isalnum from gnulib
use g_ascii_isalpha instead of c_isalpha from gnulib
use g_ascii_iscntrl instead of c_iscntrl from gnulib
use g_ascii_isdigit instead of c_isdigit frum
Signed-off-by: Pavel Hrdina
---
src/util/virstring.c | 3 +--
tools/virsh-console.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/util/virstring.c b/src/util/virstring.c
index 311c9058db..bd7c640042 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_agent.c | 3 +--
src/qemu/qemu_monitor.c | 3 +--
src/util/virstring.c| 4 ++--
tools/vsh-table.c | 3 +--
4 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index
Signed-off-by: Pavel Hrdina
---
src/util/virutil.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index f965bb0e5d..f3cf494353 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -393,11 +393,11 @@ int
Signed-off-by: Pavel Hrdina
---
src/conf/network_conf.c | 3 +--
src/qemu/qemu_domain.c | 3 +--
src/qemu/qemu_qapi.c| 4 +---
src/util/virconf.c | 2 +-
src/util/virfile.c | 4 ++--
5 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/conf/network_conf.c
Signed-off-by: Pavel Hrdina
---
tools/vsh-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/vsh-table.c b/tools/vsh-table.c
index 9008b0d431..28072c9719 100644
--- a/tools/vsh-table.c
+++ b/tools/vsh-table.c
@@ -226,7 +226,7 @@ vshTableSafeEncode(const char *s,
On Wed, Nov 20, 2019 at 02:13:37PM +0100, Ján Tomko wrote:
> On Mon, Nov 11, 2019 at 02:38:17PM +, Daniel P. Berrangé wrote:
> > As part of an goal to eliminate Perl from libvirt build tools,
> > rewrite the pdwtags processing script in Python.
> >
> > The original inline shell and perl code
On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote:
> On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote:
> > When blockcommit finishes successfully, one of the
> > qemuBlockJobProcessEventCompletedCommit() and
> > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is
Getting the hostname of guest usually requires a in-guest agent, or
generally can be determined only on active domains.
Signed-off-by: Pino Toscano
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
On Mon, Nov 11, 2019 at 02:38:17PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the pdwtags processing script in Python.
The original inline shell and perl code was completely
unintelligible. The new python code is a manual conversion
On Wed, Nov 20, 2019 at 13:07:18 +0100, Ján Tomko wrote:
> After commits 4ac47730408eaf91683f6502ec10541f4f711a5c and
> ef88698668e4a87c794d70879eeffefb52aa0017, we use the GLib versions
> of these functions.
>
> Remove the corresponding gnulib modules.
>
> Signed-off-by: Ján Tomko
>
On Mon, Nov 11, 2019 at 02:38:16PM +, Daniel P. Berrangé wrote:
As part of an goal to eliminate Perl from libvirt build tools,
rewrite the genpolkit.pl tool in Python.
This was a straight conversion, manually going line-by-line to
change the syntax from Perl to Python. Thus the overall
On Wed, Nov 20, 2019 at 12:42:09PM +0100, Peter Krempa wrote:
From: Pavel Hrdina
Last usage was removed by commit
<41f6198e231285cc813f8c0687c8ec5c9488> and commit
<0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
After commits 4ac47730408eaf91683f6502ec10541f4f711a5c and
ef88698668e4a87c794d70879eeffefb52aa0017, we use the GLib versions
of these functions.
Remove the corresponding gnulib modules.
Signed-off-by: Ján Tomko
Reviewed-by: Peter Krempa
---
With respect to established traditions, I already
On Wed, Nov 20, 2019 at 12:42:06PM +0100, Peter Krempa wrote:
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
s/g_snpritnf/g_snprintf/
On Wed, Nov 20, 2019 at 12:42:05PM +0100, Peter Krempa wrote:
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
build-aux/syntax-check.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
with that fixed:
Reviewed-by: Ján Tomko
On Wed, Nov 20, 2019 at 12:42:01PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Nov 20, 2019 at 12:42:04PM +0100, Peter Krempa wrote:
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing
From: Ján Tomko
Now that we use GRegex everywhere, there is no need for this module.
Signed-off-by: Ján Tomko
Reviewed-by: Peter Krempa
---
bootstrap.conf | 1 -
po/POTFILES.in | 1 -
2 files changed, 2 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 4ba3ebfdd5..f13fcae11a
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 6b62e20ed4..f1e976ec76 100644
--- a/build-aux/syntax-check.mk
+++
From: Ján Tomko
Signed-off-by: Ján Tomko
Reviewed-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 6156fa8499..1d80640c0a 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -20,7 +20,6 @@
gnulib_modules='
accept
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
build-aux/syntax-check.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index ba941746a1..6b62e20ed4 100644
---
From: Ján Tomko
Signed-off-by: Ján Tomko
Reviewed-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 1d80640c0a..c93daf5a8d 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -88,7 +88,6 @@ ttyname_r
uname
unsetenv
From: Pavel Hrdina
Last usage was removed by commit
<41f6198e231285cc813f8c0687c8ec5c9488> and commit
<0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
Reviewed-by: Fabiano Fidêncio
---
bootstrap.conf |
Signed-off-by: Peter Krempa
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 4c784487e2..6156fa8499 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -19,7 +19,6 @@
# gnulib modules used by this package.
gnulib_modules='
accept
This is a series of patches collecting gnulib module removals.
Patches from Jano and Pavel have alreadny my R-bs but at least one of my
patches does not.
Jano, I couldn't find your patch for removal of the mkostemp functions
so please provide it.
I'll push it later today once I get Jano's patch
1 - 100 of 136 matches
Mail list logo
