Re: [libvirt] [PATCH RFC V2 jenkins-ci] guests: Add support for openSUSE

On Tue, Nov 26, 2019 at 2:11 AM Jim Fehlig wrote: > > Grrr, I keep forgetting something within '--subject-prefix=' when sending > these > patches... Are you aware of git-publish? https://github.com/stefanha/git-publish Best Regards, -- Fabiano Fidêncio -- libvir-list mailing list libvir-list

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

On Tue, Nov 26, 2019 at 2:21 AM Jim Fehlig wrote: > > On 11/19/19 6:52 AM, Fabiano Fidêncio wrote: > > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani > > wrote: > >> > >> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote: > >>> Signed-off-by: Jim Fehlig > >>> --- > >>> guests/configs/aut

Re: [libvirt] [PATCH] remote_daemon_stream: Hold an extra reference to stream in daemonStreamFilter

Yeah, your patch is perfectly fine for stream freed problem. But I have reviewed code in daemonStreamEvent() and daemonStreamFilter() again, and I think there still two issue need to be reconsidered: 1. stream->ref only ++ in daemonStreamFilter, except for error occurred call daemonRemoveClientStre

Re: [libvirt] [PATCH v2 0/4] Update news for versions from 5.7 to 5.8

ping. Any reviews? On Mon, Nov 11, 2019 at 9:58 AM Han Han wrote: > Remove news of unmanaged macvtap devices since Laine has update that. > v1: > https://www.redhat.com/archives/libvir-list/2019-November/msg00176.html > > Han Han (4): > news: Support for kvm dedicated performance hint in 5.7 >

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

On 11/19/19 6:52 AM, Fabiano Fidêncio wrote: > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani wrote: >> >> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>> guests/configs/autoinst.xml | 86 +++ >>> .../libvirt-o

Re: [libvirt] [PATCH RFC V2 jenkins-ci] guests: Add support for openSUSE

Grrr, I keep forgetting something within '--subject-prefix=' when sending these patches... On 11/25/19 5:50 PM, Jim Fehlig wrote: > This change adds support for the latest openSUSE Leap and > openSUSE Tumbleweed guests. > > Signed-off-by: Jim Fehlig > --- > > This version of the patch overcome

[libvirt] [PATCH RFC V2] guests: Add support for openSUSE

This change adds support for the latest openSUSE Leap and openSUSE Tumbleweed guests. Signed-off-by: Jim Fehlig --- This version of the patch overcomes the 'lci build' issues noted in V1 and works well for openSUSE Leap 15.1 and Tumbleweed. I'm still of the opinion of only supporting the latest

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

On 11/14/19 10:44 AM, Jiri Denemark wrote: > On s390 machines host-passthrough and host-model CPUs result in the same > guest ABI (with QEMU new enough to be able to tell us what "host" CPU is > expanded to, which was implemented around 2.9.0). So instead of using > host-passthrough CPU when there'

Re: [libvirt] [PATCH 2/2] util: virNetDevBandwidthPlug: Drop ATTRIBUTE_UNUSED(4)

On 11/25/19 3:40 AM, Erik Skultety wrote: > On Mon, Nov 25, 2019 at 09:30:26AM +0100, Jiri Denemark wrote: >> On Fri, Nov 22, 2019 at 17:09:00 +0100, Erik Skultety wrote: >>> Since we know for sure that the @bandwidth parameter is properly handled >>> in networkCheckBandwidth (@ifaceBand), it ca

Re: [libvirt] libvirt mdev migration, mdevctl integration

On Mon, Nov 25, 2019 at 06:14:33PM +0100, Cornelia Huck wrote: > On Mon, 18 Nov 2019 19:00:25 + > Daniel P. Berrangé wrote: > > > On Mon, Nov 18, 2019 at 10:06:34AM -0700, Alex Williamson wrote: > > > Hey folks, > > > > > > We had some discussions at KVM Forum around mdev live migration and

Re: [libvirt] libvirt mdev migration, mdevctl integration

On Mon, 18 Nov 2019 19:00:25 + Daniel P. Berrangé wrote: > On Mon, Nov 18, 2019 at 10:06:34AM -0700, Alex Williamson wrote: > > Hey folks, > > > > We had some discussions at KVM Forum around mdev live migration and > > what that might mean for libvirt handling of mdev devices and > > potenti

[libvirt] [PATCH] remote_daemon_stream: Hold an extra reference to stream in daemonStreamFilter

In v5.9.0-273-g8ecab214de I've tried to fix a lock ordering problem, but introduced a crasher. Problem is that because the client lock is unlocked (in order to honour lock ordering) the stream we are currently checking in daemonStreamFilter() might be freed and thus stream->priv might not even exis

Re: [libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl

On 11/25/19 4:58 PM, Erik Skultety wrote: On Mon, Nov 25, 2019 at 04:37:36PM +0100, Peter Krempa wrote: Commit d30a1ad0443 translated the symbol file checker from perl to python by doing a literal translation in most cases. Unfortunately one string formatting operation was not really translated

Re: [libvirt] [PATCH 1/2] driver: Include source parameter to virDomainGetHostname

On 11/24/19 10:33 PM, Julio Faracco wrote: Thanks for your explanation, Peter! I will focus on LXC side then... You may still implement the API for other drivers too. The way we addressed this problem in the past is to create new API and have the old one call the new one. That's why we have

Re: [libvirt] [PATCH] qemu_capabilities: Use proper free function for caps->cpuModels

On Mon, Nov 25, 2019 at 16:41:33 +0100, Michal Privoznik wrote: > The cpuModels member of _virQEMUCapsAccel struct is not a > virObject but regular struct with a free function defined: > qemuMonitorCPUDefsFree(). Use that when clearing parent structure > instead of virObjectUnref() to avoid a memle

Re: [libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl

On Mon, Nov 25, 2019 at 04:37:36PM +0100, Peter Krempa wrote: > Commit d30a1ad0443 translated the symbol file checker from perl to > python by doing a literal translation in most cases. Unfortunately one > string formatting operation was not really translated into python > leaving users with non-he

Re: [libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl

On 11/25/19 4:37 PM, Peter Krempa wrote: Commit d30a1ad0443 translated the symbol file checker from perl to python by doing a literal translation in most cases. Unfortunately one string formatting operation was not really translated into python leaving users with non-helpful error: 'Symbol $1 is

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On 11/25/19 9:40 AM, Daniel P. Berrangé wrote: Please don't start any deprecation process. This requires certain consultation within my company. Rest assured that everyone's opinion will be taken into account while doing consiltation. The idea of having a deprecation process is precisely to al

Re: [libvirt] [PATCH v3 0/4] qemu: fix type of default video device

On Mon, Nov 25, 2019 at 10:04:58AM -0500, Cole Robinson wrote: > On 11/25/19 9:40 AM, Pavel Mores wrote: > > On Mon, Nov 25, 2019 at 08:54:43AM -0500, Cole Robinson wrote: > >> On 11/25/19 5:54 AM, Pavel Mores wrote: > >>> This new version mostly integrates Cole's comments about the second > >>> v

[libvirt] [PATCH] qemu_capabilities: Use proper free function for caps->cpuModels

The cpuModels member of _virQEMUCapsAccel struct is not a virObject but regular struct with a free function defined: qemuMonitorCPUDefsFree(). Use that when clearing parent structure instead of virObjectUnref() to avoid a memleak: ==212322== 57,275 (48 direct, 57,227 indirect) bytes in 3 blocks ar

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > On Monday, November 25, 2019, Philippe Mathieu-Daudé > wrote: > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > logical change was in 2005 (9542611a6). After we can count 164 > > maintenance commits (QE

[libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl

Commit d30a1ad0443 translated the symbol file checker from perl to python by doing a literal translation in most cases. Unfortunately one string formatting operation was not really translated into python leaving users with non-helpful error: 'Symbol $1 is listed twice' Signed-off-by: Peter Krempa

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On 2019-11-25 11:41, Philippe Mathieu-Daudé wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd5a). > > T

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On Monday, November 25, 2019, Philippe Mathieu-Daudé wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd

Re: [libvirt] [PATCH v3 0/4] qemu: fix type of default video device

On 11/25/19 9:40 AM, Pavel Mores wrote: > On Mon, Nov 25, 2019 at 08:54:43AM -0500, Cole Robinson wrote: >> On 11/25/19 5:54 AM, Pavel Mores wrote: >>> This new version mostly integrates Cole's comments about the second version. >>> Refactoring and behaviour change are now separate commits. Tests

[libvirt] [PATCH 1/9] virsh: domain: Extract the code converting domain job stats to virDomainJobInfo

To simplify the stats printer code we convert the new statistics from the typed parameter list into the old stats structure. Extract this code since it takes a lot of space. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 72 +++- 1 file changed, 3

[libvirt] [PATCH 5/9] virsh: domjobinfo: Print also job operation for failed jobs

Printing that a job failed is rather unhelpful. Print at least the operation which failed. Achieve this by moving the check whether to print stats later but replace it with a check which will skip printing of the operation if there's no job. Signed-off-by: Peter Krempa --- tools/virsh-domain.c

[libvirt] [PATCH 4/9] qemu: Implement VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 669c12d6ca..5d6a82bc13 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13958,7 +13958,8 @@ qem

[libvirt] [PATCH 8/9] API: Introduce VIR_DOMAIN_JOB_SUCCESS field for virDomainGetJobStats

The statistics fields are used in two places: 1) virDomainGetJobStats where the job type which ultimately holds whether the job was successful or not is returned via a different argument. 2) The virConnectDomainEventJobCompleted event where we report just the statistics via typed parameters. Sin

[libvirt] [PATCH 2/9] api: Allow keeping completed domain job stats when reading them

virDomainGetJobStats destroys the completed statistics on the first read. Give the user possibility to keep them around if they wish so. Add a flag VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP which will read the stats without destroying them. Signed-off-by: Peter Krempa --- include/libvirt/libvirt-doma

[libvirt] [PATCH 7/9] virsh: domjobinfo: Add switch to print raw fields

Introduce --rawstats which prints all statistics fields from the new API similarly to how the virsh event handler prints them. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 24 +--- tools/virsh.pod | 6 +- 2 files changed, 26 insertions(+), 4 deletions(-)

[libvirt] [PATCH 9/9] qemu: Always reset @info in qemuDomainGetJobInfo

qemuDomainGetJobInfo didn't always reset the return data in @info. Thankfully this wouldn't be a problem as the RPC layer does it but we should do it anyways. Since we reset the struct we don't have to set the type to VIR_DOMAIN_JOB_NONE is as the value is 0. Signed-off-by: Peter Krempa --- src

[libvirt] [PATCH 6/9] virsh: domjobinfo: Allow printing stats also for failed and other jobs

Introduce the --anystats flag which does not skip the printing of the stats if the job was unsuccessful. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 7 ++- tools/virsh.pod | 5 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/v

[libvirt] [PATCH 0/9] domain job stats handling improvements (incremental backup prequels)

Improve few aspecs of the domain job stats handling. I felt these make life simpler when using the domain stats specifically when trying to figure out how stuff works. Peter Krempa (9): virsh: domain: Extract the code converting domain job stats to virDomainJobInfo api: Allow keeping compl

[libvirt] [PATCH 3/9] virsh: Implement VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP for 'domjobinfo'

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 9 + tools/virsh.pod | 7 --- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 99194c2f81..6e3814f1fd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On 11/25/19 3:45 PM, Aleksandar Markovic wrote: On Monday, November 25, 2019, Philippe Mathieu-Daudé > wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commit

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 13:47:15 +, Daniel Berrange wrote: > On Mon, Nov 25, 2019 at 02:18:54PM +0100, Peter Krempa wrote: > > On Mon, Nov 25, 2019 at 13:11:10 +, Daniel Berrange wrote: > > > On Mon, Nov 25, 2019 at 02:07:13PM +0100, Peter Krempa wrote: > > > > On Mon, Nov 25, 2019 at 12:59

Re: [libvirt] [PATCH v3 0/4] qemu: fix type of default video device

On Mon, Nov 25, 2019 at 08:54:43AM -0500, Cole Robinson wrote: > On 11/25/19 5:54 AM, Pavel Mores wrote: > > This new version mostly integrates Cole's comments about the second version. > > Refactoring and behaviour change are now separate commits. Tests succeed > > for > > every individual patch

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

On 11/25/19 11:53 AM, Lance Liu wrote: We first produce this bug in rhel7.4's libvir daemon。For easily produce the bug, the step can be as follows: 1. add sleep(3) in daemonStreamFilter() pre virMutexLock(&stream->priv->lock), then build libvirtd bin executable, then restart libvirtd 2. use vi

Re: [libvirt] [PATCH v3 0/4] qemu: fix type of default video device

On 11/25/19 5:54 AM, Pavel Mores wrote: > This new version mostly integrates Cole's comments about the second version. > Refactoring and behaviour change are now separate commits. Tests succeed for > every individual patch in the series. > > Pavel Mores (4): > qemu: default video device type se

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 02:18:54PM +0100, Peter Krempa wrote: > On Mon, Nov 25, 2019 at 13:11:10 +, Daniel Berrange wrote: > > On Mon, Nov 25, 2019 at 02:07:13PM +0100, Peter Krempa wrote: > > > On Mon, Nov 25, 2019 at 12:59:00 +, Daniel Berrange wrote: > > > > On Mon, Nov 25, 2019 at 01:53

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 13:11:10 +, Daniel Berrange wrote: > On Mon, Nov 25, 2019 at 02:07:13PM +0100, Peter Krempa wrote: > > On Mon, Nov 25, 2019 at 12:59:00 +, Daniel Berrange wrote: > > > On Mon, Nov 25, 2019 at 01:53:47PM +0100, Peter Krempa wrote: > > > > The redetection was originall

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 02:07:13PM +0100, Peter Krempa wrote: > On Mon, Nov 25, 2019 at 12:59:00 +, Daniel Berrange wrote: > > On Mon, Nov 25, 2019 at 01:53:47PM +0100, Peter Krempa wrote: > > > The redetection was originally added in 43c01d3838 as a way to recover > > > from libvirtd upgrade f

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 12:59:00 +, Daniel Berrange wrote: > On Mon, Nov 25, 2019 at 01:53:47PM +0100, Peter Krempa wrote: > > The redetection was originally added in 43c01d3838 as a way to recover > > from libvirtd upgrade from the time when we didn't persist the qemu > > capabilities in the s

Re: [libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

On Mon, Nov 25, 2019 at 01:53:47PM +0100, Peter Krempa wrote: > The redetection was originally added in 43c01d3838 as a way to recover > from libvirtd upgrade from the time when we didn't persist the qemu > capabilities in the status XML. Also this the oldest supported qemu by > more than two years

[libvirt] [PATCH 1/9] qemu: process: Make it obvious that virDomainDefPostParse is called with NULL opaque

Commit c90fb5a828a added explicit use of the private copy of the qemu capabilities to various places. The change to qemuProcessInit was bogus though as at the point where we re-initiate the post parse callbacks priv->qemuCaps is still NULL as we clear it after shutdown of the VM and don't initiate

[libvirt] [PATCH 7/9] qemu: caps: Don't check capability before clearing it

Checking whether a qemu capability set right before clearing it without any other logic doesn't make sense. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities

[libvirt] [PATCH 9/9] qemu: process: Re-process qemu capability lockout in qemuProcessPrepareQEMUCaps

We clear some capabilities here so the lockouts need to be re-evaluated. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f170554198..bc97ec3bb4 100644 --- a/src/qemu/qemu_proces

[libvirt] [PATCH 3/9] qemu: Move and rename qemuDomainUpdateQEMUCaps

The function is now used only in qemu_process.c so move it there and name it 'qemuProcessPrepareQEMUCaps' which is more appropriate to what it's doing. The reworded comment now mentions that it will also post-process the caps for VM startup. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.

[libvirt] [PATCH 5/9] qemu: process: Move clearing of QEMU_CAPS_CHARDEV_FD_PASS to qemuProcessPrepareQEMUCaps

Move the post-processing of the QEMU_CAPS_CHARDEV_FD_PASS flag to the new function. The clearing of the capability is based on the presence of VIR_QEMU_PROCESS_START_STANDALONE so we must also pass in the process start flags. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 12 +++-

[libvirt] [PATCH 4/9] qemu: process: Move clearing of the BLOCKDEV capability to qemuProcessPrepareQEMUCaps

Start aggregating all capability post-processing code in one place. The comment was modified while moving it as it was mentioning floppies which are no longer clearing the blockdev capability. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 17 + 1 file changed, 9 inse

[libvirt] [PATCH 6/9] qemu: process: Move handling of qemu capability overrides

Do all post-processing of capabilities in qemuProcessPrepareQEMUCaps. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f36d03b0a6..f170554198 100644 --- a/sr

[libvirt] [PATCH 0/9] qemu: clean up capability handling during startup (incremental backup prequels)

For libvirt to use incremental backup we will require that blockdev is enabled. Clean up how we handle caps during startup since blockdev may be masked out there and add infrastructure to interlock flags. Peter Krempa (9): qemu: process: Make it obvious that virDomainDefPostParse is called w

[libvirt] [PATCH 8/9] qemu: capabilities: Lock out incremental backup capability without blockdev

Blockdev is required to do incremental backups properly. Add a helper function for locking out capabilities and export it to allow re-doing the processing if a different code path modifies capabilities. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 17 + src/qemu

[libvirt] [PATCH 2/9] qemu: process: Don't try to redetect missing qemuCaps on reconnect

The redetection was originally added in 43c01d3838 as a way to recover from libvirtd upgrade from the time when we didn't persist the qemu capabilities in the status XML. Also this the oldest supported qemu by more than two years. Even if somebody would have a running VM running at least qemu 1.5

[libvirt] [tck PATCH 0/2] Enable the storage encryption test

The test was present, but at the time the test was added libvirt (apparently) didn't fully support LUKS encryption with disks. Erik Skultety (2): scripts: qemu: Fix the disk encryption test description scripts: qemu: Enable disk encryption test scripts/qemu/100-disk-encryption.t | 16 +++

[libvirt] [tck PATCH 2/2] scripts: qemu: Enable disk encryption test

At the time the test was added, volume encryption wasn't fully supported in libvirt. For disks of type 'raw', this is not the case anymore, so let's adjust the test according to that fact and enable it. Signed-off-by: Erik Skultety --- scripts/qemu/100-disk-encryption.t | 9 - 1 file cha

[libvirt] [tck PATCH 1/2] scripts: qemu: Fix the disk encryption test description

The original text was a copy-paste from a different test case. Signed-off-by: Erik Skultety --- scripts/qemu/100-disk-encryption.t | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t index 12386ae..2c

Re: [libvirt] [PATCH] Use virNetServerClientImmediateClose() rather than virNetServerClientClose()

On Mon, Nov 25, 2019 at 07:23:07PM +0800, LanceLiu wrote: Please include a description why this change is needed in the commit message, to give the people looking at the git history some understanding of it without having to go through the mailing list archives. See the following blog post for s

Re: [libvirt] [PATCH] Use virNetServerClientImmediateClose() rather than virNetServerClientClose()

As I mentioned, I think add this patch will solve the problem you worried about LanceLiu 于2019年11月25日周一 下午7:23写道： > --- > src/remote/remote_daemon_stream.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/remote/remote_daemon_stream.c > b/src/remote/re

[libvirt] [PATCH] Use virNetServerClientImmediateClose() rather than virNetServerClientClose()

--- src/remote/remote_daemon_stream.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index de0dca3..d206d12 100644 --- a/src/remote/remote_daemon_stream.c +++ b/src/remote/remote_daemon_strea

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

On Thu, Nov 14, 2019 at 04:44:54PM +0100, Jiri Denemark wrote: On s390 machines host-passthrough and host-model CPUs result in the same guest ABI (with QEMU new enough to be able to tell us what "host" CPU is expanded to, which was implemented around 2.9.0). So instead of using host-passthrough C

[libvirt] [PATCH v3 2/4] qemu: prepare existing test for change of the default video device type

The test relied implicitly on default video device being cirrus. As we're about to change that the test would start failing. To avoid this, just make the test's requirement explicit. Signed-off-by: Pavel Mores --- tests/qemuxml2xmltest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[libvirt] [PATCH v3 1/4] qemu: default video device type selection algoritm moved into its own function

The default video device type selection algorithm we're about to deploy will increase the amount of code dedicated to the task by amount enough to warrant factoring the whole thing into its own function so as not to pollute the caller qemuDomainDeviceVideoDefPostParse(). Do it now so that the actu

[libvirt] [PATCH v3 0/4] qemu: fix type of default video device

This new version mostly integrates Cole's comments about the second version. Refactoring and behaviour change are now separate commits. Tests succeed for every individual patch in the series. Pavel Mores (4): qemu: default video device type selection algoritm moved into its own function q

[libvirt] [PATCH v3 3/4] qemu: the actual change of default video devide type selection algorithm

If a graphics device was added to XML that had no video device, libvirt automatically added a video device which was always of type 'cirrus' on x86_64, even if the underlying qemu didn't support cirrus. This patch refines a bit the decision about the type of the video device. Based on QEMU capabil

[libvirt] [PATCH v3 4/4] qemu: added tests of the new default video type selection algorithm

The test case for x86_64 and neither cirrus nor vga capability is of the xml2argv type because it actually fails to parse the XML at all [*] which is something that xml2xml tests don't seem to handle. xml2argv test fails to produce a qemu argv for this case which xml2argv tests can handle. [*] Th

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

We first produce this bug in rhel7.4's libvir daemon。For easily produce the bug, the step can be as follows: 1. add sleep(3) in daemonStreamFilter() pre virMutexLock(&stream->priv->lock), then build libvirtd bin executable, then restart libvirtd 2. use virsh console open one vm's console, for this

[libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) with the exception of 1 fix in 2015 (memory leak, commit 3ad9fd5a). This machine was introduced as a proof of concept to run a MIPS

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

On 11/25/19 8:34 AM, LanceLiu wrote: --- src/libvirt_remote.syms | 1 + src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletion(-) Please for

Re: [libvirt] [PATCH 2/2] util: virNetDevBandwidthPlug: Drop ATTRIBUTE_UNUSED(4)

On Mon, Nov 25, 2019 at 09:30:26AM +0100, Jiri Denemark wrote: > On Fri, Nov 22, 2019 at 17:09:00 +0100, Erik Skultety wrote: > > Since we know for sure that the @bandwidth parameter is properly handled > > in networkCheckBandwidth (@ifaceBand), it cannot ever be NULL, but > > coverity doesn't see

[libvirt] Plans for next release

We are getting close to the end of the month, I suggest to enter freeze tomorrow Tuesday, the end of the week will be quiet due to US ThanksGiving, that should give plenty of time to test ! So RC2 on Thursday and if all goes well a release on Monday 2nd ! Hope this works for everybody,

Re: [libvirt] [PATCH 2/2] util: virNetDevBandwidthPlug: Drop ATTRIBUTE_UNUSED(4)

On Fri, Nov 22, 2019 at 17:09:00 +0100, Erik Skultety wrote: > Since we know for sure that the @bandwidth parameter is properly handled > in networkCheckBandwidth (@ifaceBand), it cannot ever be NULL, but > coverity doesn't see this fact. In order to prevent coverity from > reporting a false positi

Re: [libvirt] [PATCH 2/2] util: virNetDevBandwidthPlug: Drop ATTRIBUTE_UNUSED(4)

On 11/22/19 5:09 PM, Erik Skultety wrote: Since we know for sure that the @bandwidth parameter is properly handled in networkCheckBandwidth (@ifaceBand), it cannot ever be NULL, but coverity doesn't see this fact. In order to prevent coverity from reporting a false positive here, drop ATTRIBUTE_U

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

On 11/24/19 9:12 PM, Julio Faracco wrote: Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety escreveu: This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: This kind of issue sh

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

On 11/22/19 5:08 PM, Erik Skultety wrote: This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: unsupported configuration: QOS must be defined for network 'default' Coverity didn't s

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

On Sun, Nov 24, 2019 at 06:12:58PM -0200, Julio Faracco wrote: > Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety > escreveu: > > > > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > > > This patch results in the following error when trying to start > > essentially any VM with

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

On Fri, Nov 22, 2019 at 17:08:59 +0100, Erik Skultety wrote: > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > This patch results in the following error when trying to start > essentially any VM with default network: > > unsupported configuration: QOS must be defined for network