Re: [libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

2019-12-06 Thread Jim Fehlig
On 12/6/19 4:44 PM, Jim Fehlig wrote: > Jim Fehlig (2): >guests: Add support for openSUSE >guests: Add lci build support for openSUSE I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still fails in the Configure hostname task TASK [Configure hostname]

[libvirt] [PATCH V3 jenkins-ci 1/2] guests: Add support for openSUSE

2019-12-06 Thread Jim Fehlig
This change adds support for installing and updating openSUSE Leap 15.1 using lcilool. Signed-off-by: Jim Fehlig --- guests/configs/autoinst.xml | 77 +++ .../host_vars/libvirt-opensuse-151/docker.yml | 2 + .../libvirt-opensuse-151/install.yml | 2 +

[libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

2019-12-06 Thread Jim Fehlig
Jim Fehlig (2): guests: Add support for openSUSE guests: Add lci build support for openSUSE guests/configs/autoinst.xml | 77 +++ .../host_vars/libvirt-opensuse-151/docker.yml | 2 + .../libvirt-opensuse-151/install.yml | 2 +

[libvirt] [PATCH V3 jenkins-ci 2/2] guests: Add lci build support for openSUSE

2019-12-06 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- guests/playbooks/build/jobs/defaults.yml| 1 + guests/playbooks/build/projects/libvirt.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/guests/playbooks/build/jobs/defaults.yml b/guests/playbooks/build/jobs/defaults.yml index 48cf643..43ab882 100644

Re: [libvirt] [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

2019-12-06 Thread Eric Blake
On 12/4/19 9:25 PM, Yan Zhao wrote: when vfio-pci is bound to a physical device, almost all the hardware resources are passthroughed. The intent is obvious, but it sounds awkward to a native speaker. s/passthroughed/passed through/ Sometimes, vendor driver of this physcial device may want to

Re: [libvirt] [PATCH 8/8] qemu: migration: Properly setup mirror for blockdev configurations

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: With blockdev we need to refer to the nodename of the disk source image as the source argument for the blockdev-mirror operation while still keeping the old job name. With blockdev we must also persist the job in qemu. Signed-off-by: Peter Krempa ---

Re: [libvirt] [PATCH 7/8] qemu: migration: Mention disk target rather than the drive name in debug msg

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 8bf23e9f30..27023c94b1 100644 ---

Re: [libvirt] [PATCH 6/8] qemu: migration: Split out setup of the migration target

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: Separate out allocation of the virStorageSource corresponding to the target NBD export of the migration. As part of the splitout we allocate the export name explicitly as that one must not change regardless whether blockdev is used or not to provide

Re: [libvirt] [PATCH 5/8] qemu: blockjob: Allow NULL 'mirror' for block copy jobs due to migration

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: The non-shared-storage migration tracks the storage source used explicitly in the migration data so we must allow for processing of the block job which has NULL mirror as the mirror will not be populated. Signed-off-by: Peter Krempa ---

Re: [libvirt] [PATCH 4/8] qemu: migration: Simplify cleanup in qemuMigrationSrcNBDCopyCancelOne

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: Now that the cleanup section does not exist remove the label. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal

Re: [libvirt] [PATCH 3/8] qemu: migration: Access job name from job struct

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: qemuMigrationSrcNBDCopyCancelOne uses the block job data structure but generated it's own job name rather than taking it from the block job data. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 7 +-- 1 file changed, 1 insertion(+), 6

Re: [libvirt] [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

2019-12-06 Thread Alex Williamson
On Fri, 6 Dec 2019 02:56:55 -0500 Yan Zhao wrote: > On Fri, Dec 06, 2019 at 07:55:19AM +0800, Alex Williamson wrote: > > On Wed, 4 Dec 2019 22:25:36 -0500 > > Yan Zhao wrote: > > > > > when vfio-pci is bound to a physical device, almost all the hardware > > > resources are passthroughed. >

Re: [libvirt] [PATCH 2/8] qemu: migration: Properly export backend for NBD storage migration

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: With -blockdev we must use the nodename as the export but we must keep the name of the export as it was before to ensure compatiblity. compatibility Makes sense - this is code on the destination, but we may be migrating storage from an older libvirt

Re: [libvirt] [PATCH 1/8] qemu: migration: Simplify handling of 'diskAlias' when adding NBD exports

2019-12-06 Thread Eric Blake
On 12/6/19 12:09 PM, Peter Krempa wrote: Declare the variable inside the loop with automatic clearing. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer

Re: [libvirt] [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Eric Blake
On 12/6/19 1:02 PM, John Snow wrote: I'm afraid that the only thing is not remove persistent bitmaps, which were never synced to the image. So, instead the sequence above, we need 1. create persistent bitmap A 2. shutdown vm 3. start vm 4. create persistent bitmap B 5. remember, that we want

Re: [libvirt] Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread John Snow
On 12/6/19 5:37 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.12.2019 1:37, John Snow wrote: >> This has come up in the past, and I believe we discussed this at KVM >> Forum, too: >> >> There have been requests from oVirt (via Nir Soffer) to add some offline >> bitmap manipulation functionality.

Re: [libvirt] [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread John Snow
On 12/6/19 9:36 AM, Eric Blake wrote: > [adding in Peter Maydell, as there is now potential talk of other > 4.2-worthy patches] > > On 12/6/19 4:18 AM, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 23:16, John Snow wrote: >>> >>> >>> On 12/5/19 3:09 PM, Eric Blake wrote: On 12/5/19

[libvirt] [jenkins-ci PATCH v2 3/3] guests: add libprlsdk package to libvirt project

2019-12-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/vars/projects/libvirt.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 780a5aa..1efa846 100644 --- a/guests/vars/projects/libvirt.yml +++

[libvirt] [jenkins-ci PATCH v2 1/3] guests: add openvz repository on CentOS 7

2019-12-06 Thread Daniel P . Berrangé
The OpenVZ site provides a yum repo built against RHEL-7 that includes the prlsdk-devel RPM needed for the VZ driver. This repo has quite alot of packages that replace stuff from standard RHEL repos, so the yum config file is set to whitelist only the minimal RPMs we need to do builds. Fortunately

[libvirt] [jenkins-ci PATCH v2 2/3] guests: define mapping for the libprlsdk package

2019-12-06 Thread Daniel P . Berrangé
Add a mapping exclusively for CentOS 7 to pull in the libprlsdk package, since other distros don't have it available at this time. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 4 1 file changed, 4 insertions(+) diff --git a/guests/vars/mappings.yml

[libvirt] [jenkins-ci PATCH v2 0/3] Enable building of the VZ driver on CentOS 7

2019-12-06 Thread Daniel P . Berrangé
The VZ driver in libvirt periodically gets broken by refactoring in libvirt. This is not noticed either before or after merge because none of our CI tests nor common developer build hosts includ the deps needed for the VZ driver. The OpenVZ project, however, does provide builds of the required

[libvirt] [PATCH 5/8] qemu: blockjob: Allow NULL 'mirror' for block copy jobs due to migration

2019-12-06 Thread Peter Krempa
The non-shared-storage migration tracks the storage source used explicitly in the migration data so we must allow for processing of the block job which has NULL mirror as the mirror will not be populated. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 11 --- 1 file changed,

[libvirt] [PATCH 6/8] qemu: migration: Split out setup of the migration target

2019-12-06 Thread Peter Krempa
Separate out allocation of the virStorageSource corresponding to the target NBD export of the migration. As part of the splitout we allocate the export name explicitly as that one must not change regardless whether blockdev is used or not to provide compatibility. Signed-off-by: Peter Krempa

[libvirt] [PATCH 3/8] qemu: migration: Access job name from job struct

2019-12-06 Thread Peter Krempa
qemuMigrationSrcNBDCopyCancelOne uses the block job data structure but generated it's own job name rather than taking it from the block job data. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[libvirt] [PATCH 7/8] qemu: migration: Mention disk target rather than the drive name in debug msg

2019-12-06 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 8bf23e9f30..27023c94b1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -829,7 +829,7

[libvirt] [PATCH 4/8] qemu: migration: Simplify cleanup in qemuMigrationSrcNBDCopyCancelOne

2019-12-06 Thread Peter Krempa
Now that the cleanup section does not exist remove the label. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b14a1bcd15..9062be38ab 100644

[libvirt] [PATCH 1/8] qemu: migration: Simplify handling of 'diskAlias' when adding NBD exports

2019-12-06 Thread Peter Krempa
Declare the variable inside the loop with automatic clearing. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index dabdda2715..af22dfb48d 100644 ---

[libvirt] [PATCH 8/8] qemu: migration: Properly setup mirror for blockdev configurations

2019-12-06 Thread Peter Krempa
With blockdev we need to refer to the nodename of the disk source image as the source argument for the blockdev-mirror operation while still keeping the old job name. With blockdev we must also persist the job in qemu. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 24

[libvirt] [PATCH 2/8] qemu: migration: Properly export backend for NBD storage migration

2019-12-06 Thread Peter Krempa
With -blockdev we must use the nodename as the export but we must keep the name of the export as it was before to ensure compatiblity. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 0/8] qemu: Fix non-shared storage migration over NBD (blockdev-add sequels)

2019-12-06 Thread Peter Krempa
I put some blockdev awareness into the non-shared storage migration NBD code but it was not complete. Seeing it there mislead me thinking that it's done. Fix it now. Peter Krempa (8): qemu: migration: Simplify handling of 'diskAlias' when adding NBD exports qemu: migration: Properly

[libvirt] [PATCH] docs: switch to use rst2html5 instead of rst2html

2019-12-06 Thread Daniel P . Berrangé
Now that we don't have to support CentOS 7's python2-docutils, we can use the rst2html5 tool instead, which generates HTML5 output instead of HTML4 output. This matches what we used for the original HTML docs since commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7 Author: Daniel P. Berrangé

Re: [libvirt] [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Alex Williamson
On Fri, 6 Dec 2019 17:40:02 +0800 Jason Wang wrote: > On 2019/12/6 下午4:22, Yan Zhao wrote: > > On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: > >> On 2019/12/5 下午4:51, Yan Zhao wrote: > >>> On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: > Hi: > > On

[libvirt] [PATCH] docs: fix duplication variable name for rst files

2019-12-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 5f5dce28eb..9462f77458 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -173,10 +173,10 @@ gif = \

[libvirt] [PATCH] scripts: ignore remote protocol checks if pdwtags crashes

2019-12-06 Thread Daniel P . Berrangé
On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote protocol files. This crash was previously ignored by 'make check' because of the way we piped the pdwtags output to the perl post-processing scripts. When this was converted to use python it mistakenly started being a fatal

Re: [libvirt] [RFC PATCH 4/9] vfio-pci: register default dynamic-trap-bar-info region

2019-12-06 Thread Alex Williamson
On Fri, 6 Dec 2019 01:04:07 -0500 Yan Zhao wrote: > On Fri, Dec 06, 2019 at 07:55:30AM +0800, Alex Williamson wrote: > > On Wed, 4 Dec 2019 22:26:50 -0500 > > Yan Zhao wrote: > > > > > Dynamic trap bar info region is a channel for QEMU and vendor driver to > > > communicate dynamic trap

Re: [libvirt] [PATCH 0/3] qemu: fix setting of block job speed (blockdev-add sequels)

2019-12-06 Thread Eric Blake
On 12/6/19 9:07 AM, Peter Krempa wrote: See patch 3. Peter Krempa (3): qemu: domain: Mention searched disk in error of qemuDomainDiskByName qemu: driver: Use qemuDomainDiskByName instead of virDomainDiskByName qemu: driver: Use appropriate job name when setting blockjob speed Series:

Re: [libvirt] [PATCH 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2019-12-06 Thread Eric Blake
On 12/5/19 11:36 PM, Thomas Huth wrote: Now that the "name" parameter is gone, there is hardly any difference between NetLegacy and Netdev anymore. Drop NetLegacy and always use Netdev to simplify the code quite a bit. Signed-off-by: Thomas Huth --- Initial focus on the QAPI change: +++

[libvirt] [PATCH 0/3] qemu: fix setting of block job speed (blockdev-add sequels)

2019-12-06 Thread Peter Krempa
See patch 3. Peter Krempa (3): qemu: domain: Mention searched disk in error of qemuDomainDiskByName qemu: driver: Use qemuDomainDiskByName instead of virDomainDiskByName qemu: driver: Use appropriate job name when setting blockjob speed src/qemu/qemu_domain.c | 4 ++--

[libvirt] [PATCH 1/3] qemu: domain: Mention searched disk in error of qemuDomainDiskByName

2019-12-06 Thread Peter Krempa
Mention the argument used if the disk can't be located. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 470d342afc..7e9b2db9eb 100644 --- a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH 1/2] net: Drop the legacy "name" parameter from the -net option

2019-12-06 Thread Eric Blake
On 12/5/19 11:36 PM, Thomas Huth wrote: It's been deprecated since QEMU v3.1, so it's time to finally remove it. The "id" parameter can simply be used instead. Signed-off-by: Thomas Huth --- net/net.c| 10 +- qapi/net.json| 4 +--- qemu-deprecated.texi | 12

[libvirt] [PATCH 3/3] qemu: driver: Use appropriate job name when setting blockjob speed

2019-12-06 Thread Peter Krempa
qemuDomainBlockJobSetSpeed was not converted to get the job name from the block job data. This means that after enabling blockdev the API call would fail as we wouldn't use the appropriate name. https://bugzilla.redhat.com/show_bug.cgi?id=1780497 Signed-off-by: Peter Krempa ---

[libvirt] [PATCH 2/3] qemu: driver: Use qemuDomainDiskByName instead of virDomainDiskByName

2019-12-06 Thread Peter Krempa
Where appropriate replace the open coded call with the qemu wrapper which already reports the error. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 17/17] docs: remove build recipes related to pod2man usage

2019-12-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/Makefile.am | 18 -- tools/Makefile.am | 47 --- 2 files changed, 65 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 239596624c..0267f16625 100644 --- a/src/Makefile.am +++

Re: [libvirt] [PATCH 1/3] qemu: fix crash due to freeing an uninitialised pointer

2019-12-06 Thread Pavel Mores
On Fri, Dec 06, 2019 at 02:49:26PM +0100, Michal Privoznik wrote: > On 12/6/19 10:11 AM, Pavel Mores wrote: > > The bug was fairly though not 100% reproducible, presumably due to the fact > > that some of the time, 'safename' might turn out NULL by chance, in which > > case > > freeing it is OK.

[libvirt] [PATCH 08/17] docs: convert virtlogd man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am| 2 + docs/manpages/index.rst | 1 +

[libvirt] [PATCH 14/17] docs: convert virt-admin man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 1 + docs/manpages/index.rst | 1 +

[libvirt] [PATCH 09/17] docs: convert virt-host-validate man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 5 ++ docs/manpages/index.rst | 5 ++

[libvirt] [PATCH 11/17] docs: convert virt-xml-validate man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 1 + docs/manpages/index.rst

[libvirt] [PATCH 16/17] docs: convert virkeycode*/virkeyname* man pages from pod to rst

2019-12-06 Thread Daniel P . Berrangé
The keycodemap tool is told to generate docs in rst format now instead of pod. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 30 docs/manpages/index.rst | 16 +++ src/util/Makefile.inc.am | 43 +---

[libvirt] [PATCH 07/17] docs: convert virtlockd man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am| 2 + docs/manpages/index.rst | 1 +

[libvirt] [PATCH 10/17] docs: convert virt-pki-validate man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am| 1 + docs/manpages/index.rst | 1 +

[libvirt] [PATCH 13/17] docs: convert virt-login-shell man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 5 + docs/manpages/index.rst| 1 +

[libvirt] [PATCH 04/17] docs: introduce rst2man as a mandatory tool for building docs

2019-12-06 Thread Daniel P . Berrangé
The rst2man tool is provided by python docutils, and as the name suggests, it converts RST documents into man pages. The intention is that our current POD docs will be converted to RST format, allowing one more use of Perl to be eliminated from libvirt. The manual pages will now all be kept in

[libvirt] [PATCH 12/17] docs: convert virt-sanlock-cleanup man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 1 + docs/manpages/index.rst| 1

[libvirt] [PATCH 06/17] docs: convert libvirtd man page from pod to rst

2019-12-06 Thread Daniel P . Berrangé
This was a semi-automated conversion. First it was run through pod2rst, and then it was manually editted to use a rst structure that matches expectations of rst2man. Signed-off-by: Daniel P. Berrangé --- docs/Makefile.am | 9 ++ docs/manpages/index.rst| 5 +

[libvirt] [PATCH 01/17] src: update keycodemapdb submodule

2019-12-06 Thread Daniel P . Berrangé
Pull in changes which support use of RST for docs output format instead of POD. The generator tool has changed its command line arg handling so all args must be after the command name. The docs title and subtitle must be specified separately too. Signed-off-by: Daniel P. Berrangé ---

[libvirt] [PATCH 03/17] rpm: use python3-docutils as the direct dep

2019-12-06 Thread Daniel P . Berrangé
We no longer support python2, so using a file based dep for rst2html is not required. We do still have to do special casing for RHEL-7 though as the RPM is annoyingly different. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[libvirt] [PATCH 05/17] docs: describe the basic RST structure for a man page

2019-12-06 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/styleguide.rst | 86 + 1 file changed, 86 insertions(+) diff --git a/docs/styleguide.rst b/docs/styleguide.rst index 71f29320cb..2998e90963 100644 --- a/docs/styleguide.rst +++ b/docs/styleguide.rst @@ -64,3

[libvirt] [PATCH 02/17] rpm: move pod2man & rst2html deps outside the autotools conditional

2019-12-06 Thread Daniel P . Berrangé
The generated man pages were previously bundled in the dist, so pod2man was inside the autotools conditional. We no longer bundle any generated files in the dist though, so pod2man must always be present. rst2html then mistakenly just followed what pod2man did. Signed-off-by: Daniel P. Berrangé

[libvirt] [PATCH 00/17] docs: remove all use of POD for man pages in favour of RST

2019-12-06 Thread Daniel P . Berrangé
As part of the goal to eliminate Perl from libvirt, this gets rid of the use of POD format for man pages. There's nothing especially bad about POD as a markup language compared to other lightweight markup languages like RST or Markdown. It hasn't found widespread usage outside of the Perl world

Re: [libvirt] [PATCH v2 20/25] qemu: Implement backup job APIs and qemu handling

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 21:13, Eric Blake wrote: > [adding some qemu visibility] > > On 12/5/19 7:34 AM, Peter Krempa wrote: > +    if (!(mergebitmapsstore = virJSONValueCopy(mergebitmaps))) +    return -1; + +    if (qemuMonitorTransactionBitmapAdd(actions, + 

Re: [libvirt] [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Eric Blake
[adding in Peter Maydell, as there is now potential talk of other 4.2-worthy patches] On 12/6/19 4:18 AM, Vladimir Sementsov-Ogievskiy wrote: 05.12.2019 23:16, John Snow wrote: On 12/5/19 3:09 PM, Eric Blake wrote: On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: Here is double

Re: [libvirt] [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:09, Eric Blake wrote: > On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Here is double bug: >> >> First, return error but not set errp. This may lead to: >> qmp block-dirty-bitmap-remove may report success when actually failed >> >> block-dirty-bitmap-remove used in a

Re: [libvirt] [PATCH 1/3] qemu: fix crash due to freeing an uninitialised pointer

2019-12-06 Thread Michal Privoznik
On 12/6/19 10:11 AM, Pavel Mores wrote: The bug was fairly though not 100% reproducible, presumably due to the fact that some of the time, 'safename' might turn out NULL by chance, in which case freeing it is OK. Signed-off-by: Pavel Mores --- src/qemu/qemu_monitor_text.c | 2 -- 1 file

Re: [libvirt] [PATCH] qemu: remove nested branching to enhance readability

2019-12-06 Thread Michal Privoznik
On 12/6/19 10:45 AM, Pavel Mores wrote: This is a follow-up to patch series posted in https://www.redhat.com/archives/libvir-list/2019-November/msg01180.html It implements a suggestion made by Cole in https://www.redhat.com/archives/libvir-list/2019-November/msg01207.html and discussed in

Re: [libvirt] [PATCH 0/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param

2019-12-06 Thread Pavel Hrdina
On Tue, Dec 03, 2019 at 04:33:54PM +0100, Jiri Denemark wrote: > Normally the TLS certificate from the destination host must match the > host's name for TLS verification to succeed. When the certificate does > not match the destination hostname and the expected cetificate's > hostname is known,

Re: [libvirt] [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 05:40:02PM +0800, Jason Wang wrote: > > On 2019/12/6 下午4:22, Yan Zhao wrote: > > On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: > >> On 2019/12/5 下午4:51, Yan Zhao wrote: > >>> On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: > Hi: > >

Re: [libvirt] [PATCH] qemu: remove nested branching to enhance readability

2019-12-06 Thread Daniel Henrique Barboza
On 12/6/19 6:45 AM, Pavel Mores wrote: This is a follow-up to patch series posted in https://www.redhat.com/archives/libvir-list/2019-November/msg01180.html It implements a suggestion made by Cole in https://www.redhat.com/archives/libvir-list/2019-November/msg01207.html and discussed in

Re: [libvirt] [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks

2019-12-06 Thread Gerd Hoffmann
> > $ git-grep pc-0 > > hw/display/vga-pci.c:/* compatibility with pc-0.13 and older */ > > hw/display/vga.c:/* With pc-0.12 and below we map both the PCI BAR and > > the fixed VBE region, > > hw/display/vmware_vga.c:/* compatibility with pc-0.13 and older */ > > These are

Re: [libvirt] Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 1:37, John Snow wrote: > This has come up in the past, and I believe we discussed this at KVM > Forum, too: > > There have been requests from oVirt (via Nir Soffer) to add some offline > bitmap manipulation functionality. In the past, our stance has generally > been "Use QEMU without

Re: [libvirt] [PATCH 3/3] hw/pci: Remove the "command_serr_enable" property

2019-12-06 Thread Paolo Bonzini
On 05/12/19 17:06, Thomas Huth wrote: > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index db75c6dfd0..5b6ebd15c6 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -174,9 +174,6 @@ enum { > #define QEMU_PCI_CAP_MULTIFUNCTION_BITNR3 >

Re: [libvirt] [PATCH for-4.2?] block/qcow2-bitmap: fix crash bug in qcow2_co_remove_persistent_dirty_bitmap

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 23:16, John Snow wrote: > > > On 12/5/19 3:09 PM, Eric Blake wrote: >> On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Here is double bug: >>> >>> First, return error but not set errp. This may lead to: >>> qmp block-dirty-bitmap-remove may report success when actually

Re: [libvirt] Offline manipulation of Dirty Bitmaps by qemu-img

2019-12-06 Thread Peter Krempa
On Thu, Dec 05, 2019 at 17:37:11 -0500, John Snow wrote: > This has come up in the past, and I believe we discussed this at KVM > Forum, too: > > There have been requests from oVirt (via Nir Soffer) to add some offline > bitmap manipulation functionality. In the past, our stance has generally >

[libvirt] [PATCH] qemu: remove nested branching to enhance readability

2019-12-06 Thread Pavel Mores
This is a follow-up to patch series posted in https://www.redhat.com/archives/libvir-list/2019-November/msg01180.html It implements a suggestion made by Cole in https://www.redhat.com/archives/libvir-list/2019-November/msg01207.html and discussed in follow-up messages as there were no

Re: [libvirt] [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Jason Wang
On 2019/12/6 下午4:22, Yan Zhao wrote: On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: On 2019/12/5 下午4:51, Yan Zhao wrote: On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: Hi: On 2019/12/5 上午11:24, Yan Zhao wrote: For SRIOV devices, VFs are passthroughed into guest

[libvirt] [PATCH] qemu_monitor_text: Drop unused variable and avoid crash

2019-12-06 Thread Michal Privoznik
In v5.8.0-rc1~122 we've removed the only use of @safename in qemuMonitorTextLoadSnapshot(). What we are left with is an declared but not initialized variable that is passed to VIR_FREE(). Caught by libvirt-php test suite. Signed-off-by: Michal Privoznik --- Pushed under trivial rule.

Re: [libvirt] [PATCH v2 21/25] qemu: backup: Implement stats gathering while the job is running

2019-12-06 Thread Peter Krempa
On Thu, Dec 05, 2019 at 13:54:33 -0600, Eric Blake wrote: > On 12/3/19 11:17 AM, Peter Krempa wrote: > > We can use the output of 'query-jobs' to figure out some useful > > information about a backup job. That is progress in case of a push job > > and scratch file use in case of a pull job. > >

[libvirt] [PATCH 0/3] qemu: fix crash bugs in snapshot revert

2019-12-06 Thread Pavel Mores
The aim of this series is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1610207 however before getting to that we first need to fix an unrelated (and much more recent) bug in patch 1. We clean up the fix in patch 2 by converting the whole function to the new allocation idioms. The actual

[libvirt] [PATCH 2/3] qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot()

2019-12-06 Thread Pavel Mores
While at bugfixing, convert the whole function to the new-style memory allocation handling. Signed-off-by: Pavel Mores --- src/qemu/qemu_monitor_text.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c

[libvirt] [PATCH 3/3] qemu: fix concurrency crash bug in snapshot revert

2019-12-06 Thread Pavel Mores
Although qemuDomainRevertToSnapshot() correctly begins a job at the start, the job is implicitly ended if qemuProcessStop() is called because it lives in the QEMU driver's private data that is purged during qemuProcessStop(). This commit restores the job by calling qemuProcessBeginJob() after

[libvirt] [PATCH 1/3] qemu: fix crash due to freeing an uninitialised pointer

2019-12-06 Thread Pavel Mores
The bug was fairly though not 100% reproducible, presumably due to the fact that some of the time, 'safename' might turn out NULL by chance, in which case freeing it is OK. Signed-off-by: Pavel Mores --- src/qemu/qemu_monitor_text.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [libvirt] [PATCH] news: Update the qemu version that dedicated performance hint is from

2019-12-06 Thread Andrea Bolognani
On Fri, 2019-12-06 at 10:50 +0800, Han Han wrote: > KVM dedicated performance hint is added since qemu version 2.10.0 not > 2.10.1. > > Signed-off-by: Han Han > --- > docs/news.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/news.xml b/docs/news.xml > index

[libvirt] [PATCH] docs: Update minimum QEMU version for kvm-hint-dedicated

2019-12-06 Thread Andrea Bolognani
Same fix that was applied to release notes in a595c66a134d. Signed-off-by: Andrea Bolognani --- Pushed as trivial. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6df4a8b26e..5c0a00350b

Re: [libvirt] [RFC PATCH 0/9] Introduce mediate ops in vfio-pci

2019-12-06 Thread Yan Zhao
On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote: > > On 2019/12/5 下午4:51, Yan Zhao wrote: > > On Thu, Dec 05, 2019 at 02:33:19PM +0800, Jason Wang wrote: > >> Hi: > >> > >> On 2019/12/5 上午11:24, Yan Zhao wrote: > >>> For SRIOV devices, VFs are passthroughed into guest directly without

Re: [libvirt] [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks

2019-12-06 Thread Thomas Huth
On 06/12/2019 07.49, Markus Armbruster wrote: > Thomas Huth writes: > >> These have been on the deprecation list since a year now, so it's >> time to finally remove the pc-0.x machine types. >> >> We then can also remove some compatibility hacks in the devices, i.e. >> the "use_broken_id" in

Re: [libvirt] [RFC PATCH 1/9] vfio/pci: introduce mediate ops to intercept vfio-pci ops

2019-12-06 Thread Yan Zhao
On Fri, Dec 06, 2019 at 07:55:19AM +0800, Alex Williamson wrote: > On Wed, 4 Dec 2019 22:25:36 -0500 > Yan Zhao wrote: > > > when vfio-pci is bound to a physical device, almost all the hardware > > resources are passthroughed. > > Sometimes, vendor driver of this physcial device may want to