[libvirt] [rust PATCH v2 4/5] libvirt-rust: use reference instead of moving

2019-12-23 Thread Zixing Liu
Signed-off-by: Zixing Liu --- src/domain.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/domain.rs b/src/domain.rs index 40a18d8..61ca411 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -1546,7 +1546,7 @@ impl Domain { } } -pub fn open_console(,

[libvirt] [rust PATCH v2 0/5] Map more functions in stream module

2019-12-23 Thread Zixing Liu
This set of patches will add more functions to the Rust bindings. Newly mapped functions from C library: virStreamNew virStreamEventUpdateCallback virStreamEventRemoveCallback virStreamEventAddCallback. virStreamEventAddCallback can accept normal fn functions or closures (can capture variables

[libvirt] [rust PATCH v2 1/5] libvirt-rust: stream: add more functions in stream

2019-12-23 Thread Zixing Liu
* added new functions: virStreamNew virStreamEventUpdateCallback virStreamEventRemoveCallback * added new constants: VIR_STREAM_NONBLOCK * added new types/aliases: StreamFlags * changed the previous `new` associate function to `from_ptr` to avoid naming conflicts * added basic tests to test

[libvirt] [rust PATCH v2 2/5] libvirt-rust: stream: add more functions in stream

2019-12-23 Thread Zixing Liu
* added virStreamEventAddCallback function * added new types: StreamEventCallback and FreeCallback * added new field: callback for storing event callback * drop: will drop the Box if any * added wrapper event_callback for easier callback authoring for the user (so that closures with Fn or FnMut

[libvirt] [rust PATCH v2 3/5] libvirt-rust: stream: automated lint

2019-12-23 Thread Zixing Liu
* used rustfmt to clean up the code Signed-off-by: Zixing Liu --- src/stream.rs | 97 +-- 1 file changed, 56 insertions(+), 41 deletions(-) diff --git a/src/stream.rs b/src/stream.rs index 1ffd186..0d84fd7 100644 --- a/src/stream.rs +++

[libvirt] [rust PATCH v2 5/5] libvirt-rust: stream: addressed comments

2019-12-23 Thread Zixing Liu
* minimized unsafe scope * removed pub from `from_ptr` function Signed-off-by: Zixing Liu --- src/stream.rs | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/stream.rs b/src/stream.rs index 0d84fd7..ea623f6 100644 --- a/src/stream.rs +++ b/src/stream.rs @@

Re: [libvirt] [PATCH v3 1/3] Storage: Use rc hold intermediate function return values.

2019-12-23 Thread 李义
On Tue, Dec 24, 2019 at 3:32 AM Cole Robinson wrote: > > On 12/22/19 8:15 PM, Yi Li wrote: > > most libvirt code uses 'int rc' to hold intermediate > > function return values. consistent with the rest of libvirt. > > > > Signed-off-by: Yi Li > > --- > > src/storage/storage_backend_rbd.c | 202

Re: [libvirt] [PATCH v2 1/1] qemu: hide details of fake reboot

2019-12-23 Thread Cole Robinson
On 12/19/19 5:50 AM, Nikolay Shirokovskiy wrote: > If we use fake reboot then domain goes thru running->shutdown->running > state changes with shutdown state only for short period of time. At > least this is implementation details leaking into API. And also there is > one real case when this is

Re: [libvirt] [PATCH v3 1/3] Storage: Use rc hold intermediate function return values.

2019-12-23 Thread Cole Robinson
On 12/22/19 8:15 PM, Yi Li wrote: > most libvirt code uses 'int rc' to hold intermediate > function return values. consistent with the rest of libvirt. > > Signed-off-by: Yi Li > --- > src/storage/storage_backend_rbd.c | 202 > ++ > 1 file changed, 96

Re: [libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

2019-12-23 Thread Cole Robinson
On 12/23/19 5:02 AM, Daniel P. Berrangé wrote: > On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote: >> It was comparing against spapr-vio >> >> Signed-off-by: Cole Robinson >> --- >> All this virtio-s390 stuff is kinda bogus though, because it is >> never actually output in libvirt

Re: [libvirt] [PATCH] create a thread to handle MigrationParamReset to avoid deadlock

2019-12-23 Thread Daniel P . Berrangé
On Mon, Dec 23, 2019 at 04:50:00PM +0100, Michal Prívozník wrote: > On 12/23/19 11:12 AM, Daniel P. Berrangé wrote: > > On Mon, Dec 23, 2019 at 03:13:10PM +0800, Yi Wang wrote: > >> From: Li XueLei > >> > >> Libvirtd no longer receives external requests, after I do the following. > >> > >> Steps

Re: [libvirt] [PATCH] create a thread to handle MigrationParamReset to avoid deadlock

2019-12-23 Thread Michal Prívozník
On 12/23/19 11:12 AM, Daniel P. Berrangé wrote: > On Mon, Dec 23, 2019 at 03:13:10PM +0800, Yi Wang wrote: >> From: Li XueLei >> >> Libvirtd no longer receives external requests, after I do the following. >> >> Steps to reproduce: >> 1.Virsh tool initiates a non-p2p migrations. >> 2.After the

Re: [libvirt] [jenkins-ci PATCH] guests: update FreeBSD to use py37 packages

2019-12-23 Thread Daniel P . Berrangé
On Mon, Dec 23, 2019 at 10:38:23AM +, Daniel P. Berrangé wrote: > The base python3 package was updated to python 3.7.5, so we must update > all the modules to match this version. > > Signed-off-by: Daniel P. Berrangé > --- > guests/vars/mappings.yml | 20 ++-- > 1 file

[libvirt] [jenkins-ci PATCH] guests: update FreeBSD to use py37 packages

2019-12-23 Thread Daniel P . Berrangé
The base python3 package was updated to python 3.7.5, so we must update all the modules to match this version. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/guests/vars/mappings.yml

Re: [libvirt] [PATCH] create a thread to handle MigrationParamReset to avoid deadlock

2019-12-23 Thread Daniel P . Berrangé
On Mon, Dec 23, 2019 at 03:13:10PM +0800, Yi Wang wrote: > From: Li XueLei > > Libvirtd no longer receives external requests, after I do the following. > > Steps to reproduce: > 1.Virsh tool initiates a non-p2p migrations. > 2.After the phase of qemuDomainMigratePerform3 and before the phase of

Re: [libvirt] [PATCH] docs/auth.html.in: fixed typos

2019-12-23 Thread Daniel P . Berrangé
On Thu, Dec 19, 2019 at 06:01:28PM +0300, Andrew Miloradovsky wrote: > Signed-off-by: Andrew Miloradovsky > --- > docs/auth.html.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé and merged, thanks for your first contribution to libvirt

Re: [libvirt] [PATCH] gconfig: Add GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_QEMU_XHCI

2019-12-23 Thread Daniel P . Berrangé
On Wed, Dec 18, 2019 at 03:36:07PM +0100, Felipe Borges wrote: > Modern operating systems support qemu-xhci and that's available > since libvirt 3.3.x and qemu 2.9.x > > Signed-off-by: Felipe Borges > --- > libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 3 ++- > 1 file changed, 2

Re: [libvirt] [go-xml PATCH 2/2] Support domain address type='unassigned'

2019-12-23 Thread Daniel P . Berrangé
On Fri, Dec 20, 2019 at 05:22:26PM -0500, Cole Robinson wrote: > Signed-off-by: Cole Robinson > --- > This should fix the libvirt-go-xml CI > > domain.go | 23 +++ > 1 file changed, 23 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |:

[libvirt] [PATCH] docs/auth.html.in: fixed typos

2019-12-23 Thread Andrew Miloradovsky
Signed-off-by: Andrew Miloradovsky --- docs/auth.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/auth.html.in b/docs/auth.html.in index 62af43a915..c81c1e58ad 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -274,7 +274,7 @@ to turn on SASL auth in

[libvirt] [PATCH] create a thread to handle MigrationParamReset to avoid deadlock

2019-12-23 Thread Yi Wang
From: Li XueLei Libvirtd no longer receives external requests, after I do the following. Steps to reproduce: 1.Virsh tool initiates a non-p2p migrations. 2.After the phase of qemuDomainMigratePerform3 and before the phase of qemuDomainMigrateConfirm3, kill the virsh client which initiated the

Re: [libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

2019-12-23 Thread Daniel P . Berrangé
On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote: > It was comparing against spapr-vio > > Signed-off-by: Cole Robinson > --- > All this virtio-s390 stuff is kinda bogus though, because it is > never actually output in libvirt XML. Hmm, I wonder what I was thinking when i added

[libvirt] [PATCH] gconfig: Add GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_QEMU_XHCI

2019-12-23 Thread Felipe Borges
Modern operating systems support qemu-xhci and that's available since libvirt 3.3.x and qemu 2.9.x Signed-off-by: Felipe Borges --- libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH RFC 09/11] conf: backup: Allow configuration of names exported via NBD

2019-12-23 Thread Daniel P . Berrangé
On Fri, Dec 20, 2019 at 02:49:07PM -0600, Eric Blake wrote: > On 12/20/19 8:00 AM, Daniel P. Berrangé wrote: > > On Fri, Dec 20, 2019 at 02:25:27PM +0100, Peter Krempa wrote: > > > If users wish to use different name for exported disks or bitmaps > > > the new fields allow to do so. Additionally

Re: [libvirt] [PATCH 0/5] Get rid of "no_memory" labels

2019-12-23 Thread Daniel P . Berrangé
On Fri, Dec 20, 2019 at 03:29:42PM -0500, Cole Robinson wrote: > On 12/20/19 7:43 AM, Fabiano Fidêncio wrote: > > As pointed out by Ján Tomko, "no_memory seems suspicious in the times of > > abort()". > > > > As libvirt decided to take the path to not report OOM and simply abort > > when it