[libvirt] [PATCH 4/7] qemu: fix using defaults when setting persistent iotune params

virDomainSetBlockIoTune not simply sets the iotune params given in API but use current settings for all the omitted params. Unfortunately it uses current settings for active config when setting inactive params. Let's fix it. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 10

[libvirt] [PATCH 7/7] qemu: when leaving iotune group update xml properly

Currently when disk is removed from iotune group (by setting all tunables to zero) group name is leaved in config. Let's fix it. Given iotune defaults are taken from the destination group setting tunables to zero may require different set of zero settings in API call. Let's prohibit removing from

[libvirt] [PATCH 2/7] conf: expand iotune params if only group name is given

Currenly if only iotune group name is given for some disk and no any params then later start of domain will fail. I guess it will be convinient to allow such configuration if there is another disk in the same iotune group with iotune params set. The meaning is that the first disk have same iotunes

[libvirt] [PATCH 1/7] conf: refactor virDomainBlockIoTuneInfoHas*

And introduce virDomainBlockIoTuneInfoHasAny. Signed-off-by: Nikolay Shirokovskiy --- src/conf/domain_conf.c | 46 + src/conf/domain_conf.h | 12 ++ src/libvirt_private.syms | 4 src/qemu/qemu_command.c | 49

[libvirt] [PATCH 6/7] qemu: get defaults from iotune group we move disk into

For example if disk is not in the group and we want to move it there then it makes sense to specify only the group name in API call. Currently the destination group iotune settings will be overwritten with the disk settings which I would say is not what one would expect. Thus let's get defaults

[libvirt] [PATCH 5/7] qemu: propagate iotune settings to all disks in the group

Currently upon successfull call to qemu's implementation of virDomainSetBlockIoTune iotune settings are changed only for the disk given in API if the disk is in iotune group while we need to change the settings for all disks in the group. Signed-off-by: Nikolay Shirokovskiy ---

[libvirt] [PATCH 0/7] qemu: block iotune group fixes/improvements

Currently iotune group impl has several bugs/oddities this patchset aims to fix. Also patches (2) and (3) add/change functionality so that group iotune became easier/saner to use. TODO: add docs to API/virsh in respect to using iotune group Nikolay Shirokovskiy (7): conf: refactor

[libvirt] [PATCH 3/7] qemu: check iotune params same for all disk in group

Currently it is possible to start a domain which have disks in same iotune group and at the same time having different iotune params. Both params set are passed to qemu in command line and the one that is passed later down command line is get actually set. Let's prohibit such configurations.

Re: [libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

On Tue, Jan 07, 2020 at 02:43:23PM +0100, Michal Privoznik wrote: > This simplifies condition when matching FW interface by having a > single line condition instead of multiline one. Also, it prepares > the code for future expansion. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libosinfo-build » libvirt-debian-9 #307

On Tue, Jan 07, 2020 at 07:01:53PM +, c...@centos.org wrote: > See > > : >

Re: [libvirt] [PATCH 0/5] introduce support for CPU dies in host/guest topology

A few nits and minor comments but LGTM. All patches: Reviewed-by: Daniel Henrique Barboza On 1/7/20 11:50 AM, Daniel P. Berrangé wrote: Ping On Thu, Dec 19, 2019 at 12:42:03PM +, Daniel P. Berrangé wrote: Latest generation CPUs (CascadeLake-AP) support a new topology level known as

Re: [libvirt] [PATCH 1/5] conf: add support for specifying CPU "dies" parameter

FWIW, this patch is conflicting with current master to apply due to changes of labels made recently. The fix is rather simple: On 12/19/19 9:42 AM, Daniel P. Berrangé wrote: Recently CPU hardware vendors have started to support a new level of inside the CPU package topology known as a "die".

Re: [libvirt] [PATCH 5/5] tests: add host CPU data files for validating die_id

This patch made git am complain about whitespace errors: Applying: tests: add host CPU data files for validating die_id .git/rebase-apply/patch:2068: new blank line at EOF. + warning: 1 line adds whitespace errors. If I have to guess, I think it's right ... On 12/19/19 9:42 AM, Daniel P.

Re: [libvirt] [PATCH 4/5] hostcpu: add support for reporting die_id in NUMA topology

On 12/19/19 9:42 AM, Daniel P. Berrangé wrote: Update the host CPU code to report the die_id in the NUMA topology capabilities. On systems with mulitple dies, this fixes the bug s/mulitple/multiple where CPU cores can't be distinguished: Notes core_id is

Re: [libvirt] [PATCH] po/Makefile.am: use SOURCE_DATE_EPOCH to set POT creation date

On 1/7/20 2:09 PM, Daniel Henrique Barboza wrote: I believe this patch is making my 'make syntax-check' unhappy: build-aux/syntax-check.mk: skipping test sc_flake8: flake8 not installed make[1]: Entering directory '/home/danielhb/kvm-project/libvirt/build/src' make[1]: Nothing to be done for

Re: [libvirt] [RFC PATCH 1/1] src: remove NULL check before VIR_FREE()

On Tue, Jan 07, 2020 at 02:12:05PM -0300, Daniel Henrique Barboza wrote: > Functions virDomainSoundCodecDefFree(), virCapabilitiesFreeStoragePool() > and virStorageSourceNVMeDefFree() are doing 'if (ptr)' NULL > checks right before a 'VIR_FREE(ptr)' call. > > VIR_FREE() is a wrapper for g_free().

[libvirt] [RFC PATCH 1/1] src: remove NULL check before VIR_FREE()

Functions virDomainSoundCodecDefFree(), virCapabilitiesFreeStoragePool() and virStorageSourceNVMeDefFree() are doing 'if (ptr)' NULL checks right before a 'VIR_FREE(ptr)' call. VIR_FREE() is a wrapper for g_free(). g_free(mem) documentation [1] states: 'If mem is NULL it simply returns, so there

Re: [libvirt] [PATCH] po/Makefile.am: use SOURCE_DATE_EPOCH to set POT creation date

I believe this patch is making my 'make syntax-check' unhappy: build-aux/syntax-check.mk: skipping test sc_flake8: flake8 not installed make[1]: Entering directory '/home/danielhb/kvm-project/libvirt/build/src' make[1]: Nothing to be done for 'generated-sources'. make[1]: Leaving directory

[libvirt] [PATCH] po: Fix indentation of SED_PO_FIXUP_ARGS variable

The variable value is split on multiple lines, which have too long indentation prefix leading to needless long lines. Signed-off-by: Michal Privoznik --- Pushed under trivial and build breaker rules. po/Makefile.am | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [libvirt] [jenkins-ci PATCH 1/3] lcitool: Rename temp -> resolved

On Tue, Jan 07, 2020 at 04:50:18PM +0100, Andrea Bolognani wrote: > Since we're using the dictionary to resolve the mappings for the > specific target OS, this is a much more suitable name. > > Signed-off-by: Andrea Bolognani > --- > guests/playbooks/update/tasks/packages.yml | 46

[libvirt] [PATCH] virt-aa-helper: Drop unused variable in verify_xpath_context()

After one of previous commits (v5.10.0-524-gce56408e5f) there is a variable left unused in verify_xpath_context() which breaks the build. Signed-off-by: Michal Privoznik --- Pushed under trivial and build breaker rules. src/security/virt-aa-helper.c | 1 - 1 file changed, 1 deletion(-) diff

[libvirt] [jenkins-ci PATCH 1/3] lcitool: Rename temp -> resolved

Since we're using the dictionary to resolve the mappings for the specific target OS, this is a much more suitable name. Signed-off-by: Andrea Bolognani --- guests/playbooks/update/tasks/packages.yml | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

[libvirt] [jenkins-ci PATCH 0/3] lcitool: Some pip-related fixes

Andrea Bolognani (3): lcitool: Rename temp -> resolved lcitool: Fix flattening of pip mappings lcitool: Fix pip use on CentOS 7 guests/playbooks/update/tasks/packages.yml | 61 -- 1 file changed, 32 insertions(+), 29 deletions(-) -- 2.24.1 -- libvir-list mailing

[libvirt] [jenkins-ci PATCH 2/3] lcitool: Fix flattening of pip mappings

Right now we're looping in the wrong place: instead of unconditionally adding to the flattened list of pip packages and then calling pip multiple times with that same list, we should conditionally add items to the flattened list and then call pip a single time with the result. Signed-off-by:

[libvirt] [jenkins-ci PATCH 3/3] lcitool: Fix pip use on CentOS 7

The 'pip' Ansible module doesn't work correctly when there is a mismatch between the Python version we're adding packages to and the one used to run Ansible itself: this is the case on CentOS 7, where we have Python 3 for the former but Python 2 for the latter. Call pip3 manually using the

Re: [libvirt] [jenkins-ci PATCH] guests: optionally wait for installation completion

On Tue, Jan 07, 2020 at 02:17:29PM +, Daniel P. Berrangé wrote: > The install command is hardcoded to put the virt-install command into > the background. It is useful to be able to wait for completion, so you > know when you can go onto the package update step of setup, without > having to

Re: [libvirt] [PATCH v2 4/4] qemu_firmware: Try to autofill for old style UEFI specification

On Tue, Jan 07, 2020 at 02:43:25PM +0100, Michal Privoznik wrote: > While we discourage people to use the old style of specifying > UEFI for their domains (the old style is putting path to the FW > image under /domain/os/loader/ whilst the new one is using > /domain/os/@firmware), some

Re: [libvirt] [PATCH v2 3/4] src: Introduce and use virDomainDefHasOldStyleUEFI() and virDomainDefHasOldStyleROUEFI()

$SUBJECT could be cut down in length a bit "src: introduce helpers for checking UEFI config" On Tue, Jan 07, 2020 at 02:43:24PM +0100, Michal Privoznik wrote: > These functions are meant to replace verbose check for the old > style of specifying UEFI with a simple function call. > >

Re: [libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

On Tue, Jan 07, 2020 at 02:43:23PM +0100, Michal Privoznik wrote: > This simplifies condition when matching FW interface by having a > single line condition instead of multiline one. Also, it prepares > the code for future expansion. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH v2 1/4] qemu_firmware: Pass virDomainDef into qemuFirmwareFillDomain()

On Tue, Jan 07, 2020 at 02:43:22PM +0100, Michal Privoznik wrote: > This function needs domain definition really, we don't need to > pass the whole domain object. This saves couple of dereferences > and characters esp. in more checks to come. > > Signed-off-by: Michal Privoznik > Reviewed-by:

Re: [libvirt] [PATCH 0/5] introduce support for CPU dies in host/guest topology

Ping On Thu, Dec 19, 2019 at 12:42:03PM +, Daniel P. Berrangé wrote: > Latest generation CPUs (CascadeLake-AP) support a new topology level > known as a 'die', sitting between a socket and a core. > > QEMU supports this with -smp arg since 4.1.0 > > Linux can report this via

Re: [libvirt] [PATCH] po/Makefile.am: use SOURCE_DATE_EPOCH to set POT creation date

On Tue, Jan 07, 2020 at 03:37:44PM +0100, Pavel Hrdina wrote: > When building RPMs for libvirt the PO files are part of libvirt-libs > package. Now that we generate libvirt.pot during build time the POT > creation date is also generated at that time. > > The issue here is that when building

[libvirt] [PATCH] po/Makefile.am: use SOURCE_DATE_EPOCH to set POT creation date

When building RPMs for libvirt the PO files are part of libvirt-libs package. Now that we generate libvirt.pot during build time the POT creation date is also generated at that time. The issue here is that when building libvirt-libs for x86_64 and i686 the generated libvirt.pot file will have

Re: [libvirt] [PATCH] Improve security driver error message

On Tue, Jan 07, 2020 at 02:15:19PM +, Sebastian Mitterle wrote: > Currently, when security driver is not available users are informed that > it wasn't found which can be confusing. > 1. Update error message > 2. Add comment to domain doc > > Signed-off-by Sebastian Mitterle > --- >

Re: [libvirt] [PATCH v1] virSecuritySELinuxSetTapFDLabel: Use fd_path instead of /dev/tap* to get context

On Tue, Jan 07, 2020 at 03:22:30PM +0100, Dominick Grift wrote: > /dev/tap* is an invalid path but it works with lax policy. Make it work with > more accurate policy as well > > v1: fix typo in description > Signed-off-by: Dominick Grift > --- > src/security/security_selinux.c | 4 ++-- > 1

[libvirt] [PATCH v1] virSecuritySELinuxSetTapFDLabel: Use fd_path instead of /dev/tap* to get context

/dev/tap* is an invalid path but it works with lax policy. Make it work with more accurate policy as well v1: fix typo in description Signed-off-by: Dominick Grift --- src/security/security_selinux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [jenkins-ci PATCH] guests: optionally wait for installation completion

The install command is hardcoded to put the virt-install command into the background. It is useful to be able to wait for completion, so you know when you can go onto the package update step of setup, without having to check back to see if the guest has finished installing. Using --noautoconsole

[libvirt] [PATCH] Improve security driver error message

Currently, when security driver is not available users are informed that it wasn't found which can be confusing. 1. Update error message 2. Add comment to domain doc Signed-off-by Sebastian Mitterle --- docs/formatdomain.html.in | 3 ++- src/security/security_manager.c | 2 +- 2 files

Re: [libvirt] [PATCH 3/3] cmdDomIfAddr: Move domain lookup down a few lines

On Tue, Jan 07, 2020 at 09:41:54AM +0100, Michal Privoznik wrote: > The 'domifaddr' command accepts several arguments. Let's validate > them first and look up domain to work with only after to save > some RPC cycles should validation fail. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 2/3] virsh: Fix virshDomainInterfaceSourceCompleter

On Tue, Jan 07, 2020 at 09:41:53AM +0100, Michal Privoznik wrote: > Introduced in v5.10.0-449-gcf44ec5577 it used > virshCommaStringListComplete() to generate list of options. But > this is not correct because the '--source' argument of the > 'domifaddr' doesn't accept a string list (for instance

Re: [libvirt] [PATCH 1/3] virsh: Use VIR_ENUM_* instead of open coding string -> enum conversion

On Tue, Jan 07, 2020 at 09:41:52AM +0100, Michal Privoznik wrote: > There are more occurrences, but I'm converting --source argument > of domifaddr command only, because I will need it in next commit. > > Signed-off-by: Michal Privoznik > --- > tools/virsh-domain-monitor.c | 22

Re: [libvirt] [PATCH 2/2] qemu: backup: roll-back checkpoint metadata if the checkpoint wasn't taken

On Mon, Jan 06, 2020 at 03:37:10PM +0100, Peter Krempa wrote: > We insert the checkpoint metadata into the list of checkpoints prior to > actually creating the on-disk bits. If the 'transaction' or any other > steps done between inserting the checkpoint and creating the on-disk > data fail we'd

Re: [libvirt] [PATCH 1/2] qemu: checkpoint: Extract and export rollback of checkpoint metadata storing

On Mon, Jan 06, 2020 at 03:37:09PM +0100, Peter Krempa wrote: > If we are certain that the checkpoint creation failed we remove the > metadata from the list. To allow reusing this in the backup code add a > new helper and export it. > > Signed-off-by: Peter Krempa > --- >

Re: [libvirt] [PATCH 8/9] qemu: command: take fsdriver type into account

On Mon, Jan 06, 2020 at 03:26:04PM +0100, Ján Tomko wrote: > Split the formatting by fsdriver type to allow adding a new type. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_command.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [libvirt] [PATCH 9/9] docs: formatdomain: use 'element' instead of 'block'

On Mon, Jan 06, 2020 at 03:26:05PM +0100, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > docs/formatdomain.html.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH 7/9] qemu: address: take fsdriver type into account

On Mon, Jan 06, 2020 at 03:26:03PM +0100, Ján Tomko wrote: > Split the switch by fsdriver type to allow adding a new one. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_domain_address.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-)

Re: [libvirt] [PATCH 6/9] qemu: pass private data to qemuBuildFilesystemCommandLine

On Mon, Jan 06, 2020 at 03:26:02PM +0100, Ján Tomko wrote: > This will be used by a future patch. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_command.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |:

Re: [libvirt] [PATCH 5/9] qemu: add private data to virDomainFSDef

On Mon, Jan 06, 2020 at 03:26:01PM +0100, Ján Tomko wrote: > Wire up the allocation and disposal of private data. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_domain.c | 38 ++ > src/qemu/qemu_domain.h | 12 > 2 files changed, 50

Re: [libvirt] [PATCH 4/9] conf: add private data to virDomainFSDef

On Mon, Jan 06, 2020 at 03:26:00PM +0100, Ján Tomko wrote: > Add an object to hold the private data and call the > allocation function if it's present in xmlopt. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.c | 7 ++- > src/conf/domain_conf.h | 2 ++ > 2 files changed, 8

Re: [libvirt] [PATCH 3/9] conf: add xmlopt to virDomainFSDefNew

On Mon, Jan 06, 2020 at 03:25:59PM +0100, Ján Tomko wrote: > This will be needed in the future for allocating private data. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.c | 4 ++-- > src/conf/domain_conf.h | 2 +- > src/lxc/lxc_native.c | 2 +- > src/lxc/lxc_process.c|

Re: [libvirt] [PATCH 2/9] qemu: rename gluster_debug_entry

On Mon, Jan 06, 2020 at 03:25:58PM +0100, Ján Tomko wrote: > Remove the 'gluster' part and decouple the return from > the gluster_debug_level parsing to allow adding more options > to this section. > > Signed-off-by: Ján Tomko > --- > src/qemu/libvirtd_qemu.aug | 4 ++-- > src/qemu/qemu_conf.c

Re: [libvirt] [PATCH 1/9] build: error out when check-augeas fails

On Mon, Jan 06, 2020 at 03:25:57PM +0100, Ján Tomko wrote: > Fixes: 2ffbdabb859594256d45c1b48521dd6501629852 > > Signed-off-by: Ján Tomko > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |:

[libvirt] [PATCH v2 1/4] qemu_firmware: Pass virDomainDef into qemuFirmwareFillDomain()

This function needs domain definition really, we don't need to pass the whole domain object. This saves couple of dereferences and characters esp. in more checks to come. Signed-off-by: Michal Privoznik Reviewed-by: Cole Robinson --- src/qemu/qemu_firmware.c | 12 ++--

[libvirt] [PATCH v2 4/4] qemu_firmware: Try to autofill for old style UEFI specification

While we discourage people to use the old style of specifying UEFI for their domains (the old style is putting path to the FW image under /domain/os/loader/ whilst the new one is using /domain/os/@firmware), some applications might have not adopted yet. They still rely on libvirt autofilling NVRAM

[libvirt] [PATCH v2 0/4] qemu_firmware: Try to autofill for old style UEFI specification

v2 of: https://www.redhat.com/archives/libvir-list/2019-December/msg01076.html diff to v1: - split 2/2 in the original series into 3 patches as suggested by Cole Note, 1/4 is reviewed, but I haven't pushed it yet and sending it here for completeness. Michal Prívozník (4): qemu_firmware:

[libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

This simplifies condition when matching FW interface by having a single line condition instead of multiline one. Also, it prepares the code for future expansion. Signed-off-by: Michal Privoznik --- src/qemu/qemu_firmware.c | 25 + 1 file changed, 21 insertions(+), 4

[libvirt] [PATCH v2 3/4] src: Introduce and use virDomainDefHasOldStyleUEFI() and virDomainDefHasOldStyleROUEFI()

These functions are meant to replace verbose check for the old style of specifying UEFI with a simple function call. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 3 +-- src/conf/domain_conf.c | 16 src/conf/domain_conf.h | 6 ++

Re: [libvirt] [PATCH v1 00/26] remove more unneeded labels

On 1/7/20 8:55 AM, Erik Skultety wrote: On Mon, Jan 06, 2020 at 06:57:24PM -0300, Daniel Henrique Barboza wrote: Hi, This is a follow up of a cleanup I did last year [1], which was more focused on 'cleanup' labels. In this one I covered all labels that are simply a 'return' proxy call.

[libvirt] [PATCH] virSecuritySELinuxSetTapFDLabel: Use fd_path instead of /dev/tap* to get context

/dev/tap* is an invalid path but it works with lacks policy. Make it work with more accurate policy as well Signed-off-by: Dominick Grift --- src/security/security_selinux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/security_selinux.c

Re: [libvirt] [PATCH v1 00/26] remove more unneeded labels

On Mon, Jan 06, 2020 at 06:57:24PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is a follow up of a cleanup I did last year [1], which was > more focused on 'cleanup' labels. In this one I covered all > labels that are simply a 'return' proxy call. > > This wasn't a 'purge all return

Re: [libvirt] [PATCH v1 23/26] util: remove remaining unneeded labels

On Mon, Jan 06, 2020 at 06:57:47PM -0300, Daniel Henrique Barboza wrote: > This patch remove the remaining unneeded labels in 'util' > files: > > virnetdev.c > virnetdevmacvlan.c > virnetdevtap.c > virtpm.c > virtypedparam.c > viruuid.c > > Signed-off-by: Daniel Henrique Barboza > --- I'd squash

Re: [libvirt] [PATCH v1 17/26] qemu: remove remaining unneeded labels

On Mon, Jan 06, 2020 at 06:57:41PM -0300, Daniel Henrique Barboza wrote: > This patch finishes cleaning up unneeded labels on the > QEMU files. > > Signed-off-by: Daniel Henrique Barboza > --- I'll squash this into the previous patch. Erik -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v1 14/26] secret/secret_driver.c: remove unneeded label

On Mon, Jan 06, 2020 at 06:57:38PM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza > --- > src/secret/secret_driver.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c > index

Re: [libvirt] [PATCH v1 01/26] bhyve: remove unneeded labels

On Mon, Jan 06, 2020 at 06:57:25PM -0300, Daniel Henrique Barboza wrote: > Labels that are simply a jump to a 'return' call are > unneeded and can be replaced by the return value instead. > > Signed-off-by: Daniel Henrique Barboza > --- There are a few candidates suitable for a trivial g_autoFOO

Re: [libvirt] [PATCH v1 04/26] conf/domain_conf.c: remove unneeded labels

On Mon, Jan 06, 2020 at 06:57:28PM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza > --- I'll squash 2-4 together. Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v3 5/7] projects: add gtk-vnc project

On Fri, Dec 13, 2019 at 06:20:57PM +0100, Andrea Bolognani wrote: > On Fri, 2019-12-13 at 14:36 +, Daniel P. Berrangé wrote: > > +++ b/guests/playbooks/build/projects/gtk-vnc+mingw64.yml > > @@ -0,0 +1,12 @@ > > +--- > > +- set_fact: > > +name: gtk-vnc+mingw64 > > +machines: '{{

[libvirt] [jenkins-ci PATCH v4 3/7] mappings: add gdk-pixbuf

Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 12 1 file changed, 12 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 368ff59..1298a40 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -177,6 +177,12 @@

[libvirt] [jenkins-ci PATCH v4 5/7] projects: add gtk-vnc project

Signed-off-by: Daniel P. Berrangé --- guests/playbooks/build/jobs/defaults.yml | 2 ++ .../build/projects/gtk-vnc+mingw32.yml| 12 ++ .../build/projects/gtk-vnc+mingw64.yml| 12 ++ guests/playbooks/build/projects/gtk-vnc.yml | 19

[libvirt] [jenkins-ci PATCH v4 7/7] mappings: remove gtk-vnc2

Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 13 - 1 file changed, 13 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 1298a40..b80a9b4 100644 --- a/guests/vars/mappings.yml +++

[libvirt] [jenkins-ci PATCH v4 6/7] projects: make virt-viewer depend on gtk-vnc jobs

Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/playbooks/build/jobs/defaults.yml | 1 + guests/vars/projects/virt-viewer+mingw32.yml | 1 - guests/vars/projects/virt-viewer+mingw64.yml | 1 - guests/vars/projects/virt-viewer.yml | 1 -

[libvirt] [jenkins-ci PATCH v4 1/7] mappings: add libgcrypt

Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 12 1 file changed, 12 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 7b97546..d48556c 100644 --- a/guests/vars/mappings.yml +++

[libvirt] [jenkins-ci PATCH v4 4/7] guests: pull in deps for gtk-vnc project

Signed-off-by: Daniel P. Berrangé --- guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-centos-8/main.yml| 1 + guests/host_vars/libvirt-debian-10/main.yml | 1 + guests/host_vars/libvirt-debian-9/main.yml| 1 +

[libvirt] [jenkins-ci PATCH v4 0/7] Add support for gtk-vnc builds

Support gtk-vnc and make virt-viewer depend on it v3: https://www.redhat.com/archives/libvir-list/2019-December/msg00957.html Daniel P. Berrangé (7): mappings: add libgcrypt mappings: add PulseAudio mappings: add gdk-pixbuf guests: pull in deps for gtk-vnc project projects: add gtk-vnc

[libvirt] [jenkins-ci PATCH v4 2/7] mappings: add PulseAudio

Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index d48556c..368ff59 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml

[libvirt] [jenkins-ci PATCH] guests: add more detailed docs on deploying FreeBSD

Provide instructions on how to download & deploy a working FreeBSD install that's suitable for CI, as there are several gotchas not mentioned in the current docs. Signed-off-by: Daniel P. Berrangé --- guests/README.markdown | 31 +++ 1 file changed, 31 insertions(+)

Re: [libvirt] [PATCH 1/7] util: always replace g_fsync usage with our wrapper

On Tue, Jan 07, 2020 at 09:08:03AM +0100, Pavel Hrdina wrote: > On Mon, Jan 06, 2020 at 05:26:49PM +, Daniel P. Berrangé wrote: > > g_fsync was introduced in 2.63 which is newer than our minimum > > glib version. A future commit will introduce compile time > > checking of API versions to

Re: [libvirt] [PATCH] man: virsh: Mention how to disable snapshot of disk in snapshot-create-as

On Tue, Jan 07, 2020 at 09:26:16AM +0100, Peter Krempa wrote: > Document that --diskspec DISK,snapshot=no disables snapshot for the > given disk. > > Signed-off-by: Peter Krempa > --- > docs/manpages/virsh.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Pavel Hrdina

[libvirt] [PATCH 0/3] virsh: Fix virshDomainInterfaceSourceCompleter

*** BLURB HERE *** Michal Prívozník (3): virsh: Use VIR_ENUM_* instead of open coding string -> enum conversion virsh: Fix virshDomainInterfaceSourceCompleter cmdDomIfAddr: Move domain lookup down a few lines tools/virsh-completer-domain.c | 17 ++---

[libvirt] [PATCH 2/3] virsh: Fix virshDomainInterfaceSourceCompleter

Introduced in v5.10.0-449-gcf44ec5577 it used virshCommaStringListComplete() to generate list of options. But this is not correct because the '--source' argument of the 'domifaddr' doesn't accept a string list (for instance "arp,agent,lease") rather than a single string. Therefore, the completer

[libvirt] [PATCH 3/3] cmdDomIfAddr: Move domain lookup down a few lines

The 'domifaddr' command accepts several arguments. Let's validate them first and look up domain to work with only after to save some RPC cycles should validation fail. Signed-off-by: Michal Privoznik --- tools/virsh-domain-monitor.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[libvirt] [PATCH 1/3] virsh: Use VIR_ENUM_* instead of open coding string -> enum conversion

There are more occurrences, but I'm converting --source argument of domifaddr command only, because I will need it in next commit. Signed-off-by: Michal Privoznik --- tools/virsh-domain-monitor.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

Re: [libvirt] [PATCH 3/7] qemu: Implement builtin rng backend

On Mon, Jan 6, 2020 at 6:22 PM Peter Krempa wrote: > On Mon, Jan 06, 2020 at 11:11:01 +0100, Peter Krempa wrote: > > On Wed, Jan 01, 2020 at 13:06:33 +0800, Han Han wrote: > > > Since v4.2-rc0, QEMU introduced a builtin rng backend that uses > > > getrandom() syscall to generate random. Add it

Re: [libvirt] [PATCH 2/7] util: Do not assume comma after object id

On Mon, Jan 6, 2020 at 5:58 PM Peter Krempa wrote: > On Wed, Jan 01, 2020 at 13:06:32 +0800, Han Han wrote: > > From: Han Han > > > > For qemu object like rng-builtin, there are no properties after id > > property. We should always set comma after object id. Otherwise it will > > cause trailing

[libvirt] [PATCH] man: virsh: Mention how to disable snapshot of disk in snapshot-create-as

Document that --diskspec DISK,snapshot=no disables snapshot for the given disk. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index d0f9e15c38..4522259657 100644 ---

Re: [libvirt] [PATCH 0/7] fix debian 9 incompatibility with recent changes

On Mon, Jan 06, 2020 at 05:26:48PM +, Daniel P. Berrangé wrote: > Previous commits to eliminate gnulib modules accidentally > used some glib APIs not available in Debian 9. > > GLib has support for compile time version checking of > APIs but we mistakenly havent enabled it in libvirt. > >

Re: [libvirt] [PATCH 2/7] util: keep glib compat methods in alphabetical order

On Mon, Jan 06, 2020 at 05:26:50PM +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/util/glibcompat.c | 26 +- > src/util/glibcompat.h | 2 +- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/src/util/glibcompat.c

Re: [libvirt] [PATCH 1/7] util: always replace g_fsync usage with our wrapper

On Mon, Jan 06, 2020 at 05:26:49PM +, Daniel P. Berrangé wrote: > g_fsync was introduced in 2.63 which is newer than our minimum > glib version. A future commit will introduce compile time > checking of API versions to prevent accidental usage of APIs > from glib newer than our min declared. >