[libvirt] [PATCH] gnulib: Pull in latest changes

2020-01-14 Thread Andrea Bolognani
In particular, we're interested in the following commits: commit 43b5194d5b156f8dd7ae576952568d331978f5f0 Author: Bruno Haible Date: Sun Jan 5 20:42:12 2020 +0100 tests: Avoid GCC over-optimization caused by _GL_ARG_NONNULL attributes. * lib/stdlib.in.h: Tweak last commit.

Re: [libvirt] [PATCH 10/12] src: add check for termios.h and conditionally include it

2020-01-14 Thread Pavel Hrdina
On Tue, Jan 14, 2020 at 03:21:31PM +, Daniel P. Berrangé wrote: > On Tue, Jan 14, 2020 at 04:12:15PM +0100, Pavel Hrdina wrote: > > On Fri, Jan 10, 2020 at 03:41:14PM +, Daniel P. Berrangé wrote: > > > The GNULIB termios module ensures termios.h exists, but > > > this is not neccessary and

Re: [libvirt] [PATCH 11/12] src: replace gmtime_r/localtime_r/strftime with GDateTime

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:15PM +, Daniel P. Berrangé wrote: > gmtime_r/localtime_r are mostly used in combination with > strftime to format timestamps in libvirt. This can all > be replaced with GDateTime resulting in simpler code > that is also more portable. > > There is some boundary

Re: [libvirt] [PATCH 10/12] src: add check for termios.h and conditionally include it

2020-01-14 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 04:12:15PM +0100, Pavel Hrdina wrote: > On Fri, Jan 10, 2020 at 03:41:14PM +, Daniel P. Berrangé wrote: > > The GNULIB termios module ensures termios.h exists, but > > this is not neccessary and libvirt doesn't use any of its > > functionality on platforms where it is

Re: [libvirt] [PATCH 10/12] src: add check for termios.h and conditionally include it

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:14PM +, Daniel P. Berrangé wrote: > The GNULIB termios module ensures termios.h exists, but > this is not neccessary and libvirt doesn't use any of its > functionality on platforms where it is missing. It is > thus sufficient to conditonallyinclude termios.h > >

Re: [libvirt] [PATCH 09/12] src: replace verify(expr) with G_STATIC_ASSERT(expr)

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:13PM +, Daniel P. Berrangé wrote: > G_STATIC_ASSERT() is a drop-in functional equivalent of > the GNULIB verify() macro. > > Signed-off-by: Daniel P. Berrangé > --- > build-aux/syntax-check.mk | 6 -- > src/conf/snapshot_conf.h |

Re: [libvirt] [PATCH 08/12] util: replace atomic ops impls with g_atomic_int*

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:12PM +, Daniel P. Berrangé wrote: > Libvirt's original atomic ops impls were largely copied > from GLib's code at the time. The only API difference > was that libvirt's virAtomicIntInc() would return a > value, but g_atomic_int_inc was void. We thus use >

Re: [libvirt] [PATCH 3/3] qemu: backup: Implement support for backup disk bitmap name configuration

2020-01-14 Thread Eric Blake
On 1/9/20 12:31 PM, Peter Krempa wrote: Use the user-configured name of the bitmap when merging the appropriate bitmaps for an incremental backup so that the user can see it as configured. Additionally expose the default bitmap name if nothing is configured. Signed-off-by: Peter Krempa ---

Re: [libvirt] [PATCH 2/3] qemu: backup: Implement support for backup disk export name configuration

2020-01-14 Thread Eric Blake
On 1/9/20 12:31 PM, Peter Krempa wrote: Pass the exportname as configured when exporting the image via NBD and fill it with the default if it's not configured. Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by:

Re: [libvirt] [PATCH 1/3] conf: backup: Allow configuration of names exported via NBD

2020-01-14 Thread Eric Blake
On 1/9/20 12:31 PM, Peter Krempa wrote: If users wish to use different name for exported disks or bitmaps the new fields allow to do so. Additionally they also document the current settings. Signed-off-by: Peter Krempa --- docs/formatbackup.html.in | 9 +

[libvirt] [PATCH 8/8] qemu-slirp: register helper for migration

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau When the helper supports DBus, connect it to the bus and set its ID. If the helper supports migration, register its ID to the list of dbus-vmstate ID to migrate, and specify --dbus-incoming when restoring the VM. Signed-off-by: Marc-André Lureau ---

[libvirt] [PATCH 7/8] qemu: add dbus-vmstate helper migration support

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Helper processes may have their state migrated with QEMU data stream thanks to the QEMU "dbus-vmstate". libvirt maintains the list of helpers to be migrated. The "dbus-vmstate" is added when required, and given the list of helper Ids that must be migrated, on save & load

[libvirt] [PATCH 6/8] qemu: prepare and stop the dbus daemon

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/qemu/qemu_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4195042194..845a7caa55 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[libvirt] [PATCH 1/8] qemu: remove dbus-vmstate code

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau This code was based on a per-helper instance and peer-to-peer connections. The code that landed in qemu master for v5.0 is relying on a single instance and DBus bus. Instead of trying to adapt the existing dbus-vmstate code, let's remove it and resubmit. That should make

[libvirt] [PATCH 5/8] domain: save/restore the state of dbus-daemon running

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau This avoids trying to start a dbus-daemon when its already running. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_domain.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7722a53c62..dda3cb781f 100644

[libvirt] [PATCH 4/8] qemu: add a DBus daemon helper unit

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Add a unit to start & stop a private dbus-daemon. The daemon is meant to be started on demand, and associated with a QEMU process. It should be stopped when the QEMU process is stopped. The current policy is permissive like a session bus. Stricter policies can be added

[libvirt] [PATCH 2/8] qemu-conf: add configurable dbus-daemon location

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- m4/virt-driver-qemu.m4 | 6 ++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 +++ src/qemu/qemu_conf.c | 5 + src/qemu/qemu_conf.h | 1 +

[libvirt] [PATCH 3/8] qemu-conf: add dbusStateDir

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Location of DBus daemon state configuration, socket, pid... Signed-off-by: Marc-André Lureau --- src/qemu/qemu_conf.c | 4 src/qemu/qemu_conf.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH 0/8] Second take on slirp-helper & dbus-vmstate

2020-01-14 Thread marcandre . lureau
From: Marc-André Lureau Hi, The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has been merged and partially reverted. Meanwhile, qemu dbus-vmstate design has been changed and merged upstream. This new series fixes the slirp-helper support. The significant change is that

Re: [libvirt] libvirt 6.0.0 make check-TESTS fails "FAIL: test-ptsname_r"

2020-01-14 Thread Satheesh Rajendran
On Mon, Jan 13, 2020 at 04:13:43PM -0300, Daniel Henrique Barboza wrote: > Satheesh, > > Did you update the .gnulib submodule as well? I am asking this because commit > Hi Daniel, 1. Thanks for reverting back, I guess libvirt repository yet to update submodule with those commit, it is still

Re: [libvirt] [PATCH] news: News for RDT-MBM feature

2020-01-14 Thread Han Han
On Tue, Jan 14, 2020 at 4:23 PM Andrea Bolognani wrote: > On Tue, 2020-01-14 at 13:48 +0800, Han Han wrote: > > + > > + > > + qemu: Support to report the stats of memory bandwidth usage > > + > > + > > + Implement Intel RDT-MBM to libvirt. The

Re: [libvirt] [PATCH 7/7] conf: do not generate machine names ending with a dash

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:41AM +0100, Ján Tomko wrote: > As of systemd commit: > > commit d65652f1f21a4b0c59711320f34266c635393c89 > Author: Zbigniew Jędrzejewski-Szmek > CommitDate: 2018-12-10 09:56:56 +0100 > > Partially unify hostname_is_valid() and dns_name_is_valid() > > Dashes

Re: [libvirt] [PATCH 04/12] util: add detection of openpty function

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:08PM +, Daniel P. Berrangé wrote: > All UNIX platforms we care about have openpty() in the libutil > library. Use of pty.h must also be made conditional, excluding > Win32. > > Signed-off-by: Daniel P. Berrangé > --- > configure.ac | 4 >

Re: [libvirt] [PATCH 03/12] build: validate headers against local gnulib not git repo

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:07PM +, Daniel P. Berrangé wrote: > Some syntax check rules validate usage of headers provided > by gnulib. We want to validate these only against the gnulib > modules we've chosen to use, not all modules, since we're > trying to eliminate them. > >

Re: [libvirt] [PATCH 02/12] tests: always declare environ

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:06PM +, Daniel P. Berrangé wrote: > Some UNIX platforms don't declare 'environ' in their > header files. We can unconditionally declare it ourselves > to avoid this problem. > > There is no need to do this in the aa-helper code > since that is Linux only code. >

Re: [libvirt] [PATCH 01/12] src: import gnulib's intprops.h header

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:05PM +, Daniel P. Berrangé wrote: > This copies intprops.h to virintprops.h. A couple of > conditionals were cut out since we don't need to support > OpenVMS or ancient GCC 2.x > > Signed-off-by: Daniel P. Berrangé > --- > build-aux/syntax-check.mk

Re: [libvirt] [PATCH 6/7] util: add virBufferTrimChars

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:40AM +0100, Ján Tomko wrote: > A new helper for trimming combinations of specified characters from > the tail of the buffer. > > Signed-off-by: Ján Tomko > --- > ... > /** > * virBufferAddStr: > diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h > index

Re: [libvirt] [PATCH v4 2/7] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

2020-01-14 Thread Marc Hartmayer
On Fri, Dec 13, 2019 at 03:32 PM -0500, Cole Robinson wrote: > On 12/12/19 8:46 AM, Marc Hartmayer wrote: >> On Wed, Dec 11, 2019 at 08:11 PM -0500, Cole Robinson >> wrote: >>> On 11/14/19 12:44 PM, Marc Hartmayer wrote: The commit 'close callback: move it to driver' (88f09b75eb99) moved

Re: [libvirt] [PATCH 5/7] virbuftest: use field names when initalizing test info

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:39AM +0100, Ján Tomko wrote: > Allow adding new fields without changing all the macros. It would be IMO worth mentioning the error your compiler gave you in the next patch when you hadn't done this adjustment. > > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik

Re: [libvirt] [PATCH 4/7] virbuftest: declare testBufAddStrData earlier

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:38AM +0100, Ján Tomko wrote: > Move the declaration to the beginning of the file for reuse. > > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/7] virbuftest: remove unnecessary labels

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:37AM +0100, Ján Tomko wrote: > Remove the ret variables and labels from functions that no longer need > them. > > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 2/7] virbuftest: use g_autofree

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:36AM +0100, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/7] virbuftest: remove extra G_GNUC_UNUSED markers

2020-01-14 Thread Erik Skultety
On Tue, Jan 14, 2020 at 08:35:35AM +0100, Ján Tomko wrote: > These functions do use the opaque argument. > > Signed-off-by: Ján Tomko > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH for 6.0.0] news: Document

2020-01-14 Thread Andrea Bolognani
On Tue, 2020-01-14 at 09:25 +0100, Michal Privoznik wrote: > + > + > + qemu: Allow accessing NVMe disks directly > + > + > + Before this release there were two ways to configure a NVMe disk > for > + a domain. The first was using disk/

[libvirt] [PATCH for 6.0.0] news: Document

2020-01-14 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 16 1 file changed, 16 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index acb63709da..e9863dacf3 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -106,6 +106,22 @@ hostname and the information stored in

Re: [libvirt] [PATCH] news: News for RDT-MBM feature

2020-01-14 Thread Andrea Bolognani
On Tue, 2020-01-14 at 13:48 +0800, Han Han wrote: > + > + > + qemu: Support to report the stats of memory bandwidth usage > + > + > + Implement Intel RDT-MBM to libvirt. The stats can be got via > + virsh domstats --memory. > + > +