On 1/13/20 3:53 AM, Sahid Orentino Ferdjaoui wrote:
> On Fri, Jan 10, 2020 at 11:35:32AM -0700, Zixing Liu wrote:
>> On 2020-01-10 04:48, Sahid Orentino Ferdjaoui wrote:
>>
>>> On Tue, Dec 24, 2019 at 12:12:53AM -0700, Zixing Liu wrote:
* used rustfmt to clean up the code
On Thu, Jan 16, 2020 at 05:17:43PM +, Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 05:56:38PM +0100, Peter Krempa wrote:
> > See patch 2 please.
> >
> > Peter Krempa (2):
> > tests: storage: Add test data for json specified raw image with
> > offset/size
> > qemu: Handle
On Thu, Jan 16, 2020 at 05:56:38PM +0100, Peter Krempa wrote:
> See patch 2 please.
>
> Peter Krempa (2):
> tests: storage: Add test data for json specified raw image with
> offset/size
> qemu: Handle 'offset' and 'size' parameters of 'raw' driver
>
> src/conf/domain_conf.c| 19
You normally want to run the locally compiled copy of virsh. Trying
to run the installed version with the locally compiled library is a
recipe for problems with missing symbols and so on. By adding tools
to the path we can ensure that (eg) the libguestfs test suite will use
compatible copies of
This has been used in libguestfs and libnbd for quite a while as it
makes the ./run script easier to read and write.
See also:
http://stackoverflow.com/a/9631350
Signed-off-by: Richard W.M. Jones
---
run.in | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git
The ./run script is a very useful way to run the libguestfs and
virt-v2v test suites against a locally compiled copy of libvirt.
These two patches contain some minor fixes.
Rich.
QEMU allows specifying the offset and size into a raw file to expose a
sub-slice of the image to the guest with the raw driver. Libvirt
currently doesn't support it but we can add test case for future
reference.
Signed-off-by: Peter Krempa
---
tests/virstoragetest.c | 10 ++
1 file
Prior to using -blockdev if a user created an overlay file with some
json properties we'd not put them on the command line at all. This meant
that qemu then obeyed them.
Now since we do configure all known backing files, we must also pass in
all of the parameters. Otherwise we'd configure
See patch 2 please.
Peter Krempa (2):
tests: storage: Add test data for json specified raw image with
offset/size
qemu: Handle 'offset' and 'size' parameters of 'raw' driver
src/conf/domain_conf.c| 19 +++
src/qemu/qemu_block.c | 10 --
On Thu, 2020-01-16 at 09:46 -0600, Eric Blake wrote:
> On 1/10/20 5:32 PM, Jonathon Jongsma wrote:
> > We have to assume that the guest agent may be malicious, so we
> > don't want to
> > allow any agent queries to block any other libvirt API. By holding
> > a monitor
> > job and an agent job
On 1/10/20 5:32 PM, Jonathon Jongsma wrote:
We have to assume that the guest agent may be malicious, so we don't want to
allow any agent queries to block any other libvirt API. By holding a monitor
job and an agent job while we're querying the agent, any other threads will be
blocked from using
On 1/11/20 12:32 AM, Jonathon Jongsma wrote:
The qemuAgentDiskInfo structure is filled with information received from
the agent command response, except for the 'alias' field, which is
retrieved from the vm definition. Limit this structure only to data that
was received from the agent message.
On 1/11/20 12:32 AM, Jonathon Jongsma wrote:
We have to assume that the guest agent may be malicious, so we don't want to
allow any agent queries to block any other libvirt API. By holding a monitor
job and an agent job while we're querying the agent, any other threads will be
blocked from using
We don't need all the platforms gnulib deals with, so
this is a cut down version of GNULIB's physmem.c
code. This also allows us to integrate libvirt's
error reporting functions closer to the error cause.
Signed-off-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk | 2 +-
Libvirt's original atomic ops impls were largely copied
from GLib's code at the time. The only API difference
was that libvirt's virAtomicIntInc() would return a
value, but g_atomic_int_inc was void. We thus use
g_atomic_int_add(v, 1) instead, though this means
virAtomicIntInc() now returns the
Some UNIX platforms don't declare 'environ' in their
header files. We can unconditionally declare it ourselves
to avoid this problem.
There is no need to do this in the aa-helper code
since that is Linux only code.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrangé
---
The GNULIB termios module ensures termios.h exists (but
is none the less empty) when building for Windows. We
already exclude usage of the functions that would exist
in a real termios.h, so having an empty termios.h is
not especially useful.
It is simpler to just put all use of termios.h related
* send, recv: we use write & read for sockets so don't
need these portability wrappers
* ioctl, fcntl, fcntl-h: any usage of these is conditionally
compiled and excludes Windows
* ttyname_r: this exists in all supported platforms that
we require now
* environ: the tests explicitly
All UNIX platforms we care about have openpty() in the libutil
library. Use of pty.h must also be made conditional, excluding
Win32.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk | 3 +++
configure.ac | 4
src/util/Makefile.inc.am
Windows sockets take a SOCKET HANDLE object instead of a
file descriptor. Wrap them in the same way that gnulib
does so that they use C runtime file descriptors.
While we could in theory use GSocket, it is hard to get
the exact same semantics libvirt has for its current
socket usage. Wrapping the
Convert to use socket wrappers. Aside from the header file
include change, this requires changing close -> closesocket
since our portability isn't trying to replace the close
function.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrangé
---
src/rpc/virnetsocket.c | 34
gmtime_r/localtime_r are mostly used in combination with
strftime to format timestamps in libvirt. This can all
be replaced with GDateTime resulting in simpler code
that is also more portable.
There is some boundary condition problem in parsing POSIX
timezone offsets in GLib which tickles our
Some syntax check rules validate usage of headers provided
by gnulib. We want to validate these only against the gnulib
modules we've chosen to use, not all modules, since we're
trying to eliminate them.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk
Introduce a vastly simpler VIR_INT64_STR_BUFLEN constant
which is large enough for all cases where we currently
use INT_BUFSIZE_BOUND. This eliminates most use of the
gnulib intprops.h header.
Signed-off-by: Daniel P. Berrangé
---
src/hyperv/hyperv_driver.c| 3 +-
G_STATIC_ASSERT() is a drop-in functional equivalent of
the GNULIB verify() macro.
Reviewed-by: Pavel Hrdina
Signed-off-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk | 6 --
examples/c/misc/event-test.c | 12 ++--
src/conf/snapshot_conf.h |
A continued effort to purge gnulib from the libvirt build
system. The bulk of the win comes from implementing our
own Winsock portability wrappers. The use of GSocket turned
out to have many complications, making it hard for us to
achieve the same level of functionality as we currently
have. Thus
The GLib g_size_checked_mul() function is not quite the
same signature, and gives compiler warnings due to not
correctly casting from gsize to guint64/32. Implementing
a replacement for INT_MULTIPLY_OVERFLOW is easy enough
to do ourselves.
Signed-off-by: Daniel P. Berrangé
---
Test that adding a duplicate entry is rejected properly. This also
allows to see the error message of the duplicate key addition in verbose
mode.
Signed-off-by: Peter Krempa
---
tests/virhashtest.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tests/virhashtest.c
If we get an user reporting this error message being shown it's pretty
useless in terms of actually debugging it since we don't know which hash
and which key are actually subject to the error.
This patch adds a new hash table callback which formats the
user-readable version of the hash key and
See patch 1 for rationale.
Peter Krempa (2):
util: hash: Improve debugability of "Duplicate key" error message
tests: hash: Test case for adding duplicate hash entry
src/conf/domain_addr.c | 9 +
src/util/vircgroup.c | 8
src/util/virhash.c | 22
On Thu, 16 Jan 2020 13:06:28 +
Daniel P. Berrangé wrote:
> On Thu, Jan 16, 2020 at 01:37:03PM +0100, Igor Mammedov wrote:
> > On Thu, 16 Jan 2020 11:42:09 +0100
> > Michal Privoznik wrote:
> >
> > > On 1/15/20 5:52 PM, Igor Mammedov wrote:
> > > > On Wed, 15 Jan 2020 16:34:53 +0100
> >
On Thu, 16 Jan 2020 14:03:12 +0100
Michal Privoznik wrote:
> On 1/16/20 1:37 PM, Igor Mammedov wrote:
> > On Thu, 16 Jan 2020 11:42:09 +0100
> > Michal Privoznik wrote:
> >
> >> On 1/15/20 5:52 PM, Igor Mammedov wrote:
> >>> On Wed, 15 Jan 2020 16:34:53 +0100
> >>> Peter Krempa wrote:
>
On 1/16/20 7:42 AM, Christian Ehrhardt wrote:
Reported at buld time by litian:
s/buld/build
manpage-section-mismatch usr/share/man/man8/virt-sanlock-cleanup.8.gz:3 8 != 1
And indeed the rst file says 1 while the makefile say 8:
if WITH_SANLOCK
manpages8_rst +=
On Thu, Jan 16, 2020 at 02:17:49PM +0100, Jiri Denemark wrote:
When pause-before-switchover QEMU capability is enabled, we get STOP
event before MIGRATION event with postcopy-active state. To properly
handle post-copy migration and emit correct events commit
v4.10.0-rc1-4-geca9d21e6c added a
On Thu, Jan 16, 2020 at 13:13:38 +, Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 12:41:37PM +0100, Peter Krempa wrote:
> > When parsing legacy NBD backing file strings such as
> > 'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
> > VIR_STORAGE_NET_HOST_TRANS_UNIX.
On Thu, Jan 16, 2020 at 01:13:38PM +, Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 12:41:37PM +0100, Peter Krempa wrote:
> > When parsing legacy NBD backing file strings such as
> > 'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
> > VIR_STORAGE_NET_HOST_TRANS_UNIX.
When pause-before-switchover QEMU capability is enabled, we get STOP
event before MIGRATION event with postcopy-active state. To properly
handle post-copy migration and emit correct events commit
v4.10.0-rc1-4-geca9d21e6c added a hack to
qemuProcessHandleMigrationStatus which translates the paused
On 1/16/20 2:02 PM, Erik Skultety wrote:
...
@@ -184,10 +177,8 @@ static int virChrdevLockFileCreate(const char *dev)
*/
static void virChrdevLockFileRemove(const char *dev)
{
-char *path = virChrdevLockFilePath(dev);
-if (path)
-unlink(path);
-VIR_FREE(path);
+
On Thu, Jan 16, 2020 at 12:41:37PM +0100, Peter Krempa wrote:
> When parsing legacy NBD backing file strings such as
> 'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
> VIR_STORAGE_NET_HOST_TRANS_UNIX. This started to be a problem once we
> actually started to generate config
On Thu, Jan 16, 2020 at 01:37:03PM +0100, Igor Mammedov wrote:
> On Thu, 16 Jan 2020 11:42:09 +0100
> Michal Privoznik wrote:
>
> > On 1/15/20 5:52 PM, Igor Mammedov wrote:
> > > On Wed, 15 Jan 2020 16:34:53 +0100
> > > Peter Krempa wrote:
> > >
> > >> On Wed, Jan 15, 2020 at 16:07:37 +0100,
On Wed, Jan 08, 2020 at 09:18:30AM +0100, Michal Privoznik wrote:
> This is only a theoretical leak, but in virChrdevAlloc() we
> initialize a mutex and if creating a hash table fails,
> then virChrdevFree() is called which because of incorrect check
> doesn't deinit the mutex.
>
> Signed-off-by:
On 1/16/20 1:37 PM, Igor Mammedov wrote:
On Thu, 16 Jan 2020 11:42:09 +0100
Michal Privoznik wrote:
On 1/15/20 5:52 PM, Igor Mammedov wrote:
On Wed, 15 Jan 2020 16:34:53 +0100
Peter Krempa wrote:
On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
Deprecation period is ran
On 1/16/20 6:51 AM, Peter Krempa wrote:
Add few test cases for nbd+unix style URIs with few corner cases.t
s/t$//
Signed-off-by: Peter Krempa
---
tests/virstoragetest.c | 20
1 file changed, 20 insertions(+)
Might want to mention
Ping
On 1/9/20 3:33 PM, Daniel Henrique Barboza wrote:
Hi,
These are a few cleanups in some files that I'll end up
messing with in a future series (which isn't Glibfied ATM).
Figured it's best to clean them up now instead of adding
more non-Glibfied code on top.
Patches 7 and 8 are stuff that
...
> @@ -184,10 +177,8 @@ static int virChrdevLockFileCreate(const char *dev)
> */
> static void virChrdevLockFileRemove(const char *dev)
> {
> -char *path = virChrdevLockFilePath(dev);
> -if (path)
> -unlink(path);
> -VIR_FREE(path);
> +g_autofree char *path =
On Wed, Jan 08, 2020 at 09:18:32AM +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Thu, Jan 16, 2020 at 01:51:20PM +0100, Peter Krempa wrote:
Add few test cases for nbd+unix style URIs with few corner cases.t
Signed-off-by: Peter Krempa
---
tests/virstoragetest.c | 20
1 file changed, 20 insertions(+)
Reviewed-by: Ján Tomko
Jano.t
signature.asc
On Thu, Jan 16, 2020 at 12:38:07PM +, Daniel P. Berrangé wrote:
On Thu, Jan 16, 2020 at 12:36:20PM +, Daniel P. Berrangé wrote:
Now that we removed the subject prefix tag from the mailman config
we should set 'libvirt' as the subject when sending patches.
Signed-off-by: Daniel P.
Add few test cases for nbd+unix style URIs with few corner cases.t
Signed-off-by: Peter Krempa
---
tests/virstoragetest.c | 20
1 file changed, 20 insertions(+)
diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index 370e19252b..4341c04b1e 100644
---
On Thu, Jan 16, 2020 at 12:36:20PM +, Daniel P. Berrangé wrote:
> Now that we removed the subject prefix tag from the mailman config
> we should set 'libvirt' as the subject when sending patches.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .gitpublish | 1 +
> 1 file changed, 1
On Thu, 16 Jan 2020 11:42:09 +0100
Michal Privoznik wrote:
> On 1/15/20 5:52 PM, Igor Mammedov wrote:
> > On Wed, 15 Jan 2020 16:34:53 +0100
> > Peter Krempa wrote:
> >
> >> On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
> >>> Deprecation period is ran out and it's a time to
Now that we removed the subject prefix tag from the mailman config
we should set 'libvirt' as the subject when sending patches.
Signed-off-by: Daniel P. Berrangé
---
.gitpublish | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitpublish b/.gitpublish
index 857f0d552c..d37bf4174a 100644
---
On Wed, Jan 08, 2020 at 09:18:29AM +0100, Michal Privoznik wrote:
> When opening a console to a domain, we put a tuple of {path,
> virStreamPtr} into a hash table that's private to the domain.
> This is to ensure only one client at most has the console stream
> open. Later, when the console is
On 1/16/20 5:41 AM, Peter Krempa wrote:
When parsing legacy NBD backing file strings such as
'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
VIR_STORAGE_NET_HOST_TRANS_UNIX. This started to be a problem once we
actually started to generate config of the backing store on the
When parsing legacy NBD backing file strings such as
'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
VIR_STORAGE_NET_HOST_TRANS_UNIX. This started to be a problem once we
actually started to generate config of the backing store on the command
line with -blockdev as the JSON
On Thu, Jan 16, 2020 at 11:07:28AM +, Daniel P. Berrangé wrote:
> RHEL7 has libcurl 7.29.0, which is the oldest of any
> supported build platform. Thus we no longer need the
> back compat for libcurl < 7.28.0.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/esx/esx_vi.c | 151
RHEL7 has libcurl 7.29.0, which is the oldest of any
supported build platform. Thus we no longer need the
back compat for libcurl < 7.28.0.
Signed-off-by: Daniel P. Berrangé
---
src/esx/esx_vi.c | 151 ---
src/esx/esx_vi.h | 9 ---
2 files changed,
On Wed, Jan 15, 2020 at 06:47:41PM +, Daniel P. Berrangé wrote:
> On Thu, Jan 09, 2020 at 03:53:10PM +0100, Pavel Hrdina wrote:
> > This patch series is motivated by the effort to adopt Meson as our
> > build system but all of it improves the current build system on its own.
> >
> > It moves
Reported at buld time by litian:
manpage-section-mismatch usr/share/man/man8/virt-sanlock-cleanup.8.gz:3 8 != 1
And indeed the rst file says 1 while the makefile say 8:
if WITH_SANLOCK
manpages8_rst += manpages/virt-sanlock-cleanup.rst
else ! WITH_SANLOCK
8 "System administration commands
On 1/15/20 5:52 PM, Igor Mammedov wrote:
On Wed, 15 Jan 2020 16:34:53 +0100
Peter Krempa wrote:
On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
Deprecation period is ran out and it's a time to flip the switch
introduced by cd5ff8333a.
Disable legacy option for new machine types
On Wed, Jan 15, 2020 at 04:07:37PM +0100, Igor Mammedov wrote:
> Deprecation period is ran out and it's a time to flip the switch
> introduced by cd5ff8333a.
> Disable legacy option for new machine types and amend documentation.
>
> Signed-off-by: Igor Mammedov
ppc parts
Acked-by: David Gibson
On Thu, Dec 5, 2019 at 6:25 PM Arnaud Patard wrote:
> When emulating smartcard with host certificates, qemu needs to
> be able to read the certificates files. Add necessary code to
> add the smartcard certificates file path to the apparmor profile.
>
> Passthrough support has been tested with
After debugging for a while and eventually finding the root cause we
discussed this on IRC today:
danpb: BTW the test crash in 6.0 that I'm tracing (asked yesterday)
is virHostdevManagerInitialize failing
the test goes on with mgr set to 0x0 and that is the segfault
later
In certain build environments (e.g. Debian and Ubuntu) $HOME is set
to a non existing path intentionally. That breaks and crashes
qemuhotplugtest by failing the init in virHostdevManagerGetDefault.
Avoid that issue by mocking the virFileMakePath behavior if it is
passed a path that matches $HOME
If virHostdevManagerGetDefault in qemuhotplugtest fails it works
for quite a while to later segfault when accessing
mgr->activePCIHostdevs.
Report the error details and break on a failed init to see the
real issue right away.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Christian
On 1/9/20 1:45 PM, Michal Privoznik wrote:
Pushed now.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
66 matches
Mail list logo
