Re: [PATCH] qemu-nbd: Removed deprecated --partition option

2020-01-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200122214328.1413664-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] qemu-nbd: Removed deprecated --partition option

2020-01-22 Thread Eric Blake
The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been long enough with no complaints to follow through with that process. Signed-off-by: Eric Blake --- qemu-deprecated.texi | 49 ++-- qemu-nbd.c | 133 +--

Re: [libvirt PATCH] src: remove WITH_GNUTLS usage

2020-01-22 Thread Ján Tomko
On Wed, Jan 22, 2020 at 05:33:02PM +0100, Pavel Hrdina wrote: Since commit <60d9ad6f1e42618fce10baeb0f02c35e5ebd5b24> we require GnuTLS so it doesn't make sense to ifdef the code. The important commit is ac0d21c762351f58dd5d2dafa2014ed48a8b49f3 Michal's commit

Re: [libvirt PATCH] src: remove WITH_GNUTLS usage

2020-01-22 Thread Daniel P . Berrangé
On Wed, Jan 22, 2020 at 05:33:02PM +0100, Pavel Hrdina wrote: > Since commit <60d9ad6f1e42618fce10baeb0f02c35e5ebd5b24> we require > GnuTLS so it doesn't make sense to ifdef the code. > > Signed-off-by: Pavel Hrdina > --- > src/libvirt.c | 6 +- > src/remote/remote_driver.c |

[libvirt PATCH] src: remove WITH_GNUTLS usage

2020-01-22 Thread Pavel Hrdina
Since commit <60d9ad6f1e42618fce10baeb0f02c35e5ebd5b24> we require GnuTLS so it doesn't make sense to ifdef the code. Signed-off-by: Pavel Hrdina --- src/libvirt.c | 6 +- src/remote/remote_driver.c | 19 --- src/rpc/virnetclient.c | 20

Re: [libvirt PATCH 12/12] conf/qemu: new attribute "useBackupMAC"

2020-01-22 Thread Dan Kenigsberg
On Tue, Jan 21, 2020 at 4:47 PM Daniel P. Berrangé wrote: > > On Tue, Jan 21, 2020 at 12:46:38PM +0200, Dan Kenigsberg wrote: > > On Mon, Jan 20, 2020 at 8:33 PM Daniel P. Berrangé > > wrote: > > > > > > On Sun, Jan 19, 2020 at 10:24:19PM -0500, Laine Stump wrote: > > > > Current virtio-net

Re: [libvirt] [PATCH v2 2/2] test: qemuhotplugtest mock virFileMakePath

2020-01-22 Thread Christian Ehrhardt
On Fri, Jan 17, 2020 at 6:47 PM Andrea Bolognani wrote: > On Thu, 2020-01-16 at 09:28 +0100, Christian Ehrhardt wrote: > > +VIR_MOCK_IMPL_RET_ARGS(virFileMakePath, int, > > + const char *, path) > > +{ > > +const char *home; > > + > > +

Re: [libvirt] [PATCH v2 1/2] test: let qemuhotplugtest report details of init fails

2020-01-22 Thread Christian Ehrhardt
On Fri, Jan 17, 2020 at 6:32 PM Andrea Bolognani wrote: > On Thu, 2020-01-16 at 09:28 +0100, Christian Ehrhardt wrote: > > If virHostdevManagerGetDefault in qemuhotplugtest fails it works > > for quite a while to later segfault when accessing > > mgr->activePCIHostdevs. > > > > Report the error