Re: [libvirt PATCH] conf: use correct free function for virDomainDeviceDef

2020-02-04 Thread Peter Krempa
On Wed, Feb 05, 2020 at 01:26:11 +0100, Ján Tomko wrote: > Simple g_autofree is not enough if we put allocated > data into the device structure. > > Define the AUTOPTR_CLEANUP function and use it here. > > Signed-off-by: Ján Tomko > Reported-by: Xu Yandong Ah, so this bug was actually introduc

[libvirt PATCH] conf: use correct free function for virDomainDeviceDef

2020-02-04 Thread Ján Tomko
Simple g_autofree is not enough if we put allocated data into the device structure. Define the AUTOPTR_CLEANUP function and use it here. Signed-off-by: Ján Tomko Reported-by: Xu Yandong --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 1 + 2 files changed, 2 insertions(+), 1 deletio

Re: [libvirt PATCHv3 06/12] conf: add virtiofs-related elements and attributes

2020-02-04 Thread Masayoshi Mizuma
On Thu, Jan 30, 2020 at 06:06:22PM +0100, Ján Tomko wrote: > Add more elements for tuning the virtiofsd daemon > and the vhost-user-fs device: > > > /usr/libexec/virtiofsd > > > Above config doesn't work... Following? The code looks go

Re: [libvirt PATCHv3 10/12] qemu: add code for handling virtiofsd

2020-02-04 Thread Masayoshi Mizuma
On Tue, Feb 04, 2020 at 05:36:23PM +0100, Ján Tomko wrote: > On Mon, Feb 03, 2020 at 10:16:29PM -0500, Masayoshi Mizuma wrote: > > On Thu, Jan 30, 2020 at 06:06:26PM +0100, Ján Tomko wrote: > > > Start virtiofsd for each device using it. > > > > > > Pre-create the socket for communication with QE

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-04 Thread Daniel P . Berrangé
On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > Although I've never experienced it, due to not running Windows guests, I've > recently learned that a Windows guest permits a user (hopefully only one > with local admin privileges??!) to "hot-unplug" any PCI device. I've also > learned

Re: [libvirt PATCHv3 10/12] qemu: add code for handling virtiofsd

2020-02-04 Thread Ján Tomko
On Mon, Feb 03, 2020 at 10:16:29PM -0500, Masayoshi Mizuma wrote: On Thu, Jan 30, 2020 at 06:06:26PM +0100, Ján Tomko wrote: Start virtiofsd for each device using it. Pre-create the socket for communication with QEMU and pass it to virtiofsd. Note that virtiofsd needs to run as root. https:/

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2020 at 05:13:54PM +0100, Julia Suvorova wrote: > On Tue, Feb 4, 2020 at 11:26 AM Michael S. Tsirkin wrote: > > > > On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > > > 3) qemu could add a "hotpluggable=no" commandline option to all PCI > > > devices > > > (including

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-04 Thread Julia Suvorova
On Tue, Feb 4, 2020 at 11:26 AM Michael S. Tsirkin wrote: > > On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > > 3) qemu could add a "hotpluggable=no" commandline option to all PCI devices > > (including vfio-pci) and then do whatever is necessary to make sure this is > > honored in

Re: [PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

2020-02-04 Thread Pavel Hrdina
On Mon, Jan 27, 2020 at 06:58:01PM +0100, Peter Krempa wrote: > The flag for the virDomainUndefine API is supported even if we report > that . Mention it in the docs. > > Signed-off-by: Peter Krempa > --- > docs/formatdomaincaps.html.in | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

2020-02-04 Thread Peter Krempa
On Mon, Jan 27, 2020 at 18:58:01 +0100, Peter Krempa wrote: > The flag for the virDomainUndefine API is supported even if we report > that . Mention it in the docs. > > Signed-off-by: Peter Krempa > --- > docs/formatdomaincaps.html.in | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-04 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > 3) qemu could add a "hotpluggable=no" commandline option to all PCI devices > (including vfio-pci) and then do whatever is necessary to make sure this is > honored in the emulated hardware (is it possible to set this on a per-slot > bas

Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc

2020-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 10:24:07AM +0100, Michal Privoznik wrote: > On 2/3/20 5:50 PM, Daniel P. Berrangé wrote: > > On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote: > > > Both of these binaries are spawn by libvirt. Add a rule to the > > > default profile to allow that. > > > > >

Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc

2020-02-04 Thread Michal Privoznik
On 2/3/20 5:50 PM, Daniel P. Berrangé wrote: On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote: Both of these binaries are spawn by libvirt. Add a rule to the default profile to allow that. Signed-off-by: Michal Privoznik --- src/security/apparmor/usr.sbin.libvirtd.in | 2 ++