Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

On 2/24/20 1:58 PM, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Yay! It applied properly, so you have all the pieces of patch submission properly in line! :-)

[libvirt PATCH] node_device: hal: include virutil.h

Signed-off-by: Ján Tomko Fixes: b11e8cccdd5163727fd4cecda0076ac2b63fe32d --- Pushed as a build fix. Also re-ran configure on my FreeBSD guest to pick up HAL. src/node_device/node_device_hal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_device/node_device_hal.c

Re: [libvirt PATCH 0/7] tests: libxl: clean up test mocking

On 2/22/20 7:25 AM, Ján Tomko wrote: Refactor libxlDriverConfigNew to remove the need for mocking virFilePath and add libxlDomainGetEmulatorType to the mock to remove the need to invoke a binary for nearly every domain we parse Ján Tomko (7): testutilsxen: error out on initialization failure

Re: [libvirt PATCH 7/7] tests: libxl: do not run the emulator

On 2/22/20 7:25 AM, Ján Tomko wrote: Ever since commit c5a00350 the libxl parser invokes the emulator to probe which device model to use. Commit b90c4b5 introduced a workaround that used a stable path which was very likely to result in the answer matching the default. However the test is still

[PATCH] virt-aa-helper: Fix build by including virutil.h

Commit fb01e1a44d missed including virutil.h, causing the following compilation error ../../src/security/virt-aa-helper.c:1055:43: error: implicit declaration of function 'virHostGetDRMRenderNode' [-Werror=implicit-function-declaration] 1055 | char *defaultRenderNode =

Re: [PATCH] build: stop running aclocal manually

On Mon, Feb 24, 2020 at 05:50:17PM +, Daniel P. Berrangé wrote: The autoreconf script will already run aclocal for us, so there's no need todo that ahead of time. s/todo/to do/ Signed-off-by: Daniel P. Berrangé --- autogen.sh | 1 - 1 file changed, 1 deletion(-) Neat, that's 3.5 s

[libvirt PATCH] bhyve: utils: use relative path for virclosecallbacks.h

When moving virclosecallbacks to src/hypervisor, I did not adjust all the possible includes in Makefiles. Use a path relative to src to fix the build. Signed-off-by: Ján Tomko Fixes: 25c29ac2f5842a7d48d9f9619317f68acf5d9995 --- Pushed as a build fix. src/bhyve/bhyve_utils.h | 2 +- 1 file

Re: [libvirt PATCH 0/8] Reduce usage of virutil.h (include epistles)

On 2/23/20 8:25 PM, Ján Tomko wrote: With the introduction of virenum.h and GLib, the need for including this file diminishes. Remove its transitive inclusion from almost anywhere to discourage its use as a generic helper dump. The remaining functions should be repatriated into other files

[PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 7bbde5c6a9..fde33b5d38 100644 ---

Re: [PATCH v1 10/12] add hostdev handling for bhyve

> Can you split this patch up into a few pieces. > > We generally want the changes to the XML parser/formatter to > be separate from any driver code, as the first part. > > Then I'd suggest a separate patch for the PCI and the SCSI > hostdev support in bhyve. > For the conf stuff we'll need a

[libvirt PATCH] docs: add page describing the libvirt daemons

Now that we have more than just the libvirtd daemon, we should be explaining to users what they are all for & important aspects of their configuration. Signed-off-by: Daniel P. Berrangé --- docs/daemons.rst | 682 ++ docs/docs.html.in | 3 + 2

Re: [PATCH v1 00/12] Bhyve driver improvements

Awesome, thank you! I'll try to address the remaining feedback when I get a chance. This work isn't exactly my primary job function so it's been more of a nights and weekends labor of love kind of thing. Thanks again for taking the time to review and push these patches! On Mon, Feb 24, 2020 at

Re: [PATCH v1 00/12] Bhyve driver improvements

On Mon, Feb 24, 2020 at 01:46:12AM -0500, Ryan Moeller wrote: > Rebased and updated from previous patch set to address feedback: > > * Tried to match local convention for subjects where obvious > * Split patch 01 into two patches, with updated messages > * Use g_autofree to fix use after free

network: bridge_driver: Use new helpers for storing libvirt errors

>From c2028d3b27e20eb0d15a553139d2c987325d977e Mon Sep 17 00:00:00 2001 From: Gaurav Agrawal Date: Mon, 24 Feb 2020 22:49:21 +0530 Subject: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++--

Re: [PATCH v1 11/12] bhyve: command: enable booting from hostdevs

On Mon, Feb 24, 2020 at 01:46:23AM -0500, Ryan Moeller wrote: > It is possible to boot from virtio-scsi with UEFI-devel, for example. > > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_command.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git

Re: [PATCH v1 10/12] add hostdev handling for bhyve

On Mon, Feb 24, 2020 at 01:46:22AM -0500, Ryan Moeller wrote: > Handle PCI passthrough and virtio-scsi using hostdev devices. > > Example PCI passthrough: > domain xml snippet > ``` > > > > > > > > > function='0x00'/> > > > ``` > loader.conf snippet > ``` >

Re: [libvirt PATCH 0/3] Remove usage of virHexToBin (glib chronicles)

On 2/23/20 3:20 PM, Ján Tomko wrote: Prefer g_ascii_xdigit_value Ján Tomko (3): util: uuid: remove use of virHexToBin Remove all use of virHexToBin util: remove virHexToBin src/libvirt_private.syms | 1 - src/util/virbitmap.c | 3 +-- src/util/virmacaddr.c| 5 ++---

[PATCH] build: stop running aclocal manually

The autoreconf script will already run aclocal for us, so there's no need todo that ahead of time. Signed-off-by: Daniel P. Berrangé --- autogen.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 671dd63eb6..4e1bbceb0a 100755 --- a/autogen.sh +++ b/autogen.sh @@

Re: [PATCH 3/3] qemu-img: Deprecate use of -b without -F

On Mon, Feb 24, 2020 at 10:08:31 -0600, Eric Blake wrote: > On 2/24/20 5:38 AM, Peter Krempa wrote: > > On Sat, Feb 22, 2020 at 05:23:41 -0600, Eric Blake wrote: > > > Creating an image that requires format probing of the backing image is > > > inherently unsafe (we've had several CVEs over the

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

On Mon, Feb 24, 2020 at 14:24:15 +, Daniel Berrange wrote: > On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote: > > On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote: [...] > > I'll reiterate the historical state of the problem because I think it's > > important: > > > >

Re: [PATCH v1 09/12] bhyve: parse_command: slot, bus, func -> bus, slot, func

On Mon, Feb 24, 2020 at 01:46:21AM -0500, Ryan Moeller wrote: > This *is* a no-op, but there was a period of sickening dread while > auditing to be sure that no actual confusion between bus and slot had > occurred. I hope to avoid that by following the conventional order. > > Signed-off-by: Ryan

Re: [PATCH v1 08/12] bhyve: command: refactor virBhyveProcessBuildBhyveCmd

On Mon, Feb 24, 2020 at 01:46:20AM -0500, Ryan Moeller wrote: > Reduce the complexity by isolating loop bodies in separate functions. > > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_command.c | 115 ++ > 1 file changed, 67 insertions(+), 48

Re: [PATCH v1 06/12] bhyve: add hooks

Will do, thanks! On Mon, Feb 24, 2020 at 12:01 PM Daniel P. Berrangé wrote: > > On Mon, Feb 24, 2020 at 01:46:18AM -0500, Ryan Moeller wrote: > > Signed-off-by: Ryan Moeller > > --- > > src/bhyve/bhyve_process.c | 33 + > > src/util/virhook.c| 15

Re: [PATCH v1 07/12] bhyve: add reboot support

On Mon, Feb 24, 2020 at 01:46:19AM -0500, Ryan Moeller wrote: > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_driver.c | 30 ++ > src/bhyve/bhyve_monitor.c | 19 +- > src/bhyve/bhyve_monitor.h | 2 ++ > src/bhyve/bhyve_process.c | 52

Re: [PATCH v1 06/12] bhyve: add hooks

On Mon, Feb 24, 2020 at 01:46:18AM -0500, Ryan Moeller wrote: > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_process.c | 33 + > src/util/virhook.c| 15 +++ > src/util/virhook.h| 11 +++ > 3 files changed, 59

Re: [PATCH v1 05/12] bhyve: monitor: refactor register/unregister

On Mon, Feb 24, 2020 at 01:46:17AM -0500, Ryan Moeller wrote: > Pull the code for registering and unregistering a bhyve monitor object > into separate functions to improve code clarity. > > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_monitor.c | 50

Re: [PATCH v1 04/12] bhyve: monitor: Make bhyveMonitor a virClass

On Mon, Feb 24, 2020 at 01:46:16AM -0500, Ryan Moeller wrote: > This makes lifecycle management a bit easier thanks to ref counting, and > it is closer to what the qemu driver does. FWIW, if you want todo any more conversions in the future, note that we're intending to replace virObject with

Re: [PATCH v1 02/12] conf: fix use after free

On Mon, Feb 24, 2020 at 01:46:14AM -0500, Ryan Moeller wrote: > Signed-off-by: Ryan Moeller > --- > src/conf/virnetworkobj.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v1 03/12] bhyve: process: don't bother seeking to end of log

On Mon, Feb 24, 2020 at 01:46:15AM -0500, Ryan Moeller wrote: > The file is opened O_APPEND. > > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_process.c | 5 - > 1 file changed, 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v1 01/12] bhyve: process: remove unneeded header

On Mon, Feb 24, 2020 at 01:46:13AM -0500, Ryan Moeller wrote: > Signed-off-by: Ryan Moeller > --- > src/bhyve/bhyve_process.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange

Re: [PATCH 0/3] Tighten qemu-img rules on missing backing format

On 2/24/20 5:01 AM, Peter Krempa wrote: On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote: In the past, we have had CVEs caused by qemu probing one image type when an image started out as another but the guest was able to modify content. The solution to those CVEs was to encode backing

Re: [PATCH 3/3] qemu-img: Deprecate use of -b without -F

On 2/24/20 5:38 AM, Peter Krempa wrote: On Sat, Feb 22, 2020 at 05:23:41 -0600, Eric Blake wrote: Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on probes leaking information to the guest on a subsequent

Re: [libvirt] [PATCH 0/8] Second take on slirp-helper & dbus-vmstate

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > Sorry for late review. I will reply to individual patches with suggested > changes. I have them locally as a fixup patches, so I can squash

Re: [PATCH 2/8] qemu-conf: add configurable dbus-daemon location

On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > m4/virt-driver-qemu.m4 | 6 ++ > > src/qemu/libvirtd_qemu.aug | 1 + > >

Re: [PATCH 7/8] qemu: add dbus-vmstate helper migration support

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Helper processes may have their state migrated with QEMU data stream > > thanks to the QEMU "dbus-vmstate". > > > > libvirt maintains the

Re: [PATCH 8/8] qemu-slirp: register helper for migration

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > When the helper supports DBus, connect it to the bus and set its ID. > > > > If the helper supports migration, register its ID to the list

Re: [PATCH 3/8] qemu-conf: add dbusStateDir

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Location of DBus daemon state configuration, socket, pid... > > > > Signed-off-by: Marc-André Lureau > > --- > > src/qemu/qemu_conf.c | 4

Re: [PATCH 1/8] qemu: remove dbus-vmstate code

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This code was based on a per-helper instance and peer-to-peer > > connections. The code that landed in qemu master for v5.0 is relying > >

Re: [PATCH 4/8] qemu: add a DBus daemon helper unit

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add a unit to start & stop a private dbus-daemon. > > > > The daemon is meant to be started on demand, and associated with a > > QEMU

Re: [PATCH 5/8] domain: save/restore the state of dbus-daemon running

Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: > > On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This avoids trying to start a dbus-daemon when its already running. > > > > Signed-off-by: Marc-André Lureau > > --- > >

Re: [libvirt PATCH 1/3] util: uuid: remove use of virHexToBin

On 2/23/20 3:20 PM, Ján Tomko wrote: Prefer g_ascii_xdigit_value to virHexToBin. Check the return value of the function and remove the g_ascii_isxdigit calls, since they're done anyway internally. Signed-off-by: Ján Tomko Reviewed-by: Laine Stump (The two functions behave differently in

Re: [libvirt PATCH 3/4] virhostdev: move to src/hypervisor

On 2/23/20 3:16 PM, Ján Tomko wrote: This module depends on domain_conf and is used directly by various hypervisor drivers. Move it to src/hypervisor. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 2 +- po/POTFILES.in| 2 +-

Re: [libvirt PATCH 0/4] Do not depend on conf/ in util/

On 2/23/20 3:16 PM, Ján Tomko wrote: Ján Tomko (4): syntax-check: inclusion rule for src/hypervisor conf: move virHostdevIs functions virhostdev: move to src/hypervisor virclosecallbacks: move to src/hypervisor build-aux/syntax-check.mk| 5 +-

[libvirt PATCH] ci: Fix handling of $PKG_CONFIG_LIBDIR

There are two environment variables that are baked into our cross-compilation container images at build time, $CONFIGURE_OPTS and $PKG_CONFIG_LIBDIR: the former contain the options necessary to convince configure to perform a cross build rather than a native one, and the latter is necessary so

[PATCH v4 3/5] lxc: Replacing default strings definitions by g_autofree statement

There are a lots of strings being handled inside some LXC functions. They can be moved to g_autofree to avoid declaring a return value to get proper code cleanups. This commit is changing functions from lxc_{controller,cgroup,fuse} only. Signed-off-by: Julio Faracco --- src/lxc/lxc_cgroup.c

[PATCH v4 5/5] lxc: Count max VCPUs based on cpuset.cpus in native config

Native config files sometimes can setup cpuset.cpus to pin some CPUs. Before this, LXC was using a fixed number of 1 VCPU. After this commit, XML definition will generate a dynamic number of VCPUs based on that cgroup attribute. Signed-off-by: Julio Faracco --- src/lxc/lxc_container.c

[PATCH v4 2/5] lxc: Add HPET device into allowed devices

This commit is related to RTC timer device too. HPET is being shared from host device through `localtime` clock. This timer is available creating a new timer using `hpet` name. Signed-off-by: Julio Faracco --- docs/formatdomain.html.in | 2 +- src/lxc/lxc_cgroup.c | 17 +

[PATCH v4 4/5] lxc: Implement virtual /proc/cpuinfo via LXC fuse

This commit tries to fix lots of issues related to LXC VCPUs. One of them is related to /proc/cpuinfo content. If only 1 VCPU is set, LXC containers will show all CPUs available for host. The second one is related to CPU share, if an user set only 1 VCPU, the container/process will use all

[PATCH v4 1/5] lxc: Add Real Time Clock device into allowed devices

This commit share host Real Time Clock device (rtc) into LXC containers to support hardware clock. This should be available setting up a `rtc` timer under clock section. Since this option is not emulated, it should be available only for `localtime` clock. This option should be readonly due to

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote: > On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote: > > [adding qemu] > > Adding Daniel as he objected to qemu-img. > > > > > On 2/19/20 12:57 PM, Peter Krempa wrote: > > [...] > > > > Additionally I think that we could

[PATCH v4 0/5] lxc: Add VCPU features for LXC

This series cover a lots of functionalities to LXC VCPUs. It enables sharing some timer devices between host and LXC guest using `timer` settings. It still has other improvements related to VCPU and LXC such as virtual cpuinfo content based on VCPU settings and some better resource limits. Each

Re: [PATCH] apparmor: allow to call vhost-user-gpu

On Fri, Feb 14, 2020 at 10:19 PM Jim Fehlig wrote: > On 2/14/20 1:14 PM, Christian Ehrhardt wrote: > > > > > > On Fri, Feb 14, 2020 at 6:00 PM Jim Fehlig > > wrote: > > > > On 2/13/20 4:32 AM, Christian Ehrhardt wrote: > > > Configuring vhost-user-gpu like: > >

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote: > [adding qemu] Adding Daniel as he objected to qemu-img. > > On 2/19/20 12:57 PM, Peter Krempa wrote: [...] > > Additionally I think that we could just get rid of the copy of the image > > detection copy in libvirt and replace it by

Re: [libvirt PATCH 0/2] travis: Use dedicated images for MinGW builds

On Mon, 2020-02-10 at 18:21 +0100, Andrea Bolognani wrote: > Andrea Bolognani (2): > ci: Make container environment available to scripts > travis: Use dedicated images for MinGW builds > > .travis.yml | 10 -- > ci/Makefile | 2 ++ > 2 files changed, 6 insertions(+), 6 deletions(-)

Re: [libvirt PATCH] qemu: use correct backendType when checking memfd capability

On Mon, Feb 24, 2020 at 01:34:51PM +0100, Ján Tomko wrote: > The backend name is memory-backend-memfd but we've been checking > for memory-backend-memory. > > Reported by GCC on rawhide: > ../../../src/internal.h:75:22: error: 'strcmp' of a string of length 21 and > an array of size 21 evaluates

[libvirt PATCH] qemu: use correct backendType when checking memfd capability

The backend name is memory-backend-memfd but we've been checking for memory-backend-memory. Reported by GCC on rawhide: ../../../src/internal.h:75:22: error: 'strcmp' of a string of length 21 and an array of size 21 evaluates to nonzero [-Werror=string-compare]

Re: [PATCH 0/3] Tighten qemu-img rules on missing backing format

On Mon, Feb 24, 2020 at 12:01:45 +0100, Peter Krempa wrote: > On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote: [...] > > libvirt HAS to use blockdev-open on the backing chain and supply a > > backing format there, and thus has to probe images. If libvirt ever > > probes differently

Re: [libvirt RFC PATCH] util: vireventglibwatch: watch for G_IO_HUP and G_IO_ERR

On Wed, Feb 19, 2020 at 01:31:22AM +0100, Ján Tomko wrote: > To more closely match the previous usage in virEventPollDispatchHandles, > where called the handle callback for any revents returned by poll. > > This should fix the virtlogd error on subsequent domain startup: > error: can't connect

Re: [PATCH 3/3] qemu-img: Deprecate use of -b without -F

On Sat, Feb 22, 2020 at 05:23:41 -0600, Eric Blake wrote: > Creating an image that requires format probing of the backing image is > inherently unsafe (we've had several CVEs over the years based on > probes leaking information to the guest on a subsequent boot). If our > probing algorithm ever

[libvirt-dockerfiles PATCH 1/2] Refresh after turning MinGW into a cross-building target

As a result of the change, the regular Fedora 30 container images no longer include any MinGW-related package. The corresponding libvirt-jenkins-ci commit is 0f6e1f237d65. Signed-off-by: Andrea Bolognani --- buildenv-libosinfo-fedora-30.zip | Bin 605 -> 544 bytes

[libvirt-dockerfiles PATCH 0/2] Update for MinGW changes

Pushed under the Dockerfile refresh rule. As usual, these patches cannot be applied to the git repository and are posted to the list for humans' convenience only. Andrea Bolognani (2): Refresh after turning MinGW into a cross-building target Add Dockerfiles for MinGW cross-compilation

[libvirt-dockerfiles PATCH 2/2] Add Dockerfiles for MinGW cross-compilation

These build upon the Fedora 30 Dockerfiles and add the MinGW packages on top, ensuring layers are shared. The corresponding libvirt-jenkins-ci commit is 0f6e1f237d65. Signed-off-by: Andrea Bolognani --- buildenv-libosinfo-fedora-30-cross-mingw32.zip | Bin 0 -> 687 bytes

Re: [PATCH 0/3] Tighten qemu-img rules on missing backing format

On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote: > In the past, we have had CVEs caused by qemu probing one image type > when an image started out as another but the guest was able to modify > content. The solution to those CVEs was to encode backing format > information into qcow2, to

Re: [dockerfiles PATCH] refresh: Drop MinGW hacks

On Mon, 2020-02-10 at 18:19 +0100, Andrea Bolognani wrote: > Up until now we have had to hardcode some information in our > refresh script, but with the recent improvements to lcitool that's > no longer necessary. > > Signed-off-by: Andrea Bolognani > --- > This patch needs > >

Re: [libvirt PATCH 00/11] qemu: introduce a per-VM event loop thread

On Sat, Feb 22, 2020 at 01:41:06PM +0100, Michal Prívozník wrote: > On 2/14/20 1:51 PM, Daniel P. Berrangé wrote: > > This series changes the way we manage the QEMU monitor and > > QEMU agent, such that all I/O is processed by a dedicated > > event loop thread. > > > > Many times in the past

Re: [libvirt PATCH 4/8] conf: rename virNetDevSupportBandwidth to virNetDevSupportsBandwidth

On Sat, Feb 22, 2020 at 05:31:55PM +0100, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > src/conf/netdev_bandwidth_conf.c | 2 +- > src/conf/netdev_bandwidth_conf.h | 2 +- > src/lxc/lxc_driver.c | 4 ++-- > src/lxc/lxc_process.c| 2 +- > src/qemu/qemu_command.c

Re: [libvirt PATCH] esx: Same order of arguments in definition and declaration

On Sun, Feb 23, 2020 at 12:22:25AM +0100, Rikard Falkeborn wrote: The order of arguments were not the same in the definition and declaration. All callers use the same order as the definition, so there is no bug, but change the function declaration to match the implementation to avoid confusion.

Re: [libvirt PATCH] vz: Fix return value in error path

On Sun, Feb 23, 2020 at 12:22:47AM +0100, Rikard Falkeborn wrote: If PrlVmDev_GetType(), PrlVmDev_GetIndex() or PrlVmCfg_GetBootDevCount() fails, return false to indicate error. Returning -1 would be interpreted as true when used in an if-statement. Fixes:

[libvirt PATCH] vz: Fix return value in error path

If PrlVmDev_GetType(), PrlVmDev_GetIndex() or PrlVmCfg_GetBootDevCount() fails, return false to indicate error. Returning -1 would be interpreted as true when used in an if-statement. Fixes: 8c9252aa6d95247537da0939b54fdd2f31695e32 Signed-off-by: Rikard Falkeborn --- src/vz/vz_sdk.c | 6 +++---

[libvirt PATCH] esx: Same order of arguments in definition and declaration

The order of arguments were not the same in the definition and declaration. All callers use the same order as the definition, so there is no bug, but change the function declaration to match the implementation to avoid confusion. Signed-off-by: Rikard Falkeborn --- src/esx/esx_vi.h | 4 ++-- 1

Re: Requesting Guidance

On 2/23/20 7:28 AM, Ritish kr singh wrote: Hello, Sir Hey! Firstly, I suggest going through our GSoC FAQ [1]. Our student selection process is documented there. Secondly, we should start simple, by fixing a small bug, or extending functionality a bit so that we get to know libvirt