Re: [libvirt PATCHv4 10/15] qemu: forbid migration with vhost-user-fs device

2020-02-25 Thread Peter Krempa
On Thu, Feb 20, 2020 at 15:32:47 +0100, Ján Tomko wrote: > This is not yet supported. > > Signed-off-by: Ján Tomko > Reviewed-by: Daniel P. Berrangé > --- > src/qemu/qemu_migration.c | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Peter Krempa

Re: [libvirt PATCHv4 09/15] qemu: validate virtiofs filesystems

2020-02-25 Thread Peter Krempa
On Thu, Feb 20, 2020 at 15:32:46 +0100, Ján Tomko wrote: > Reject unsupported configurations. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_domain.c | 61 +++--- > 1 file changed, 58 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_domain.c

Re: [libvirt PATCHv4 08/15] qemu: add virtiofsd_debug to qemu.conf

2020-02-25 Thread Peter Krempa
On Thu, Feb 20, 2020 at 15:32:45 +0100, Ján Tomko wrote: > Add a 'virtiofsd_debug' option for tuning whether to run virtiofsd > in debug mode. > > Signed-off-by: Ján Tomko > Reviewed-by: Daniel P. Berrangé > --- > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf |

Re: [libvirt PATCHv4 07/15] conf: add virtiofs-related elements and attributes

2020-02-25 Thread Peter Krempa
On Thu, Feb 20, 2020 at 15:32:44 +0100, Ján Tomko wrote: > Add more elements for tuning the virtiofsd daemon > and the vhost-user-fs device: > > > > > > > > > Signed-off-by: Ján Tomko > Reviewed-by: Daniel P. Berrangé > Reviewed-by: Masayoshi Mizuma > --- >

Re: [libvirt PATCHv4 06/15] conf: qemu: add virtiofs fsdriver type

2020-02-25 Thread Peter Krempa
On Thu, Feb 20, 2020 at 15:32:43 +0100, Ján Tomko wrote: > Introduce a new 'virtiofs' driver type for filesystem. > > > > > > > > > Signed-off-by: Ján Tomko > Reviewed-by: Daniel P. Berrangé > --- [...] > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in >

Re: [libvirt PATCH 5/6] Make PATHs unique for a VM object instance

2020-02-25 Thread Shaju Abraham
On Tue, Feb 25, 2020 at 6:29 PM Daniel P. Berrangé wrote: > On Wed, Feb 19, 2020 at 02:39:22AM +, Shaju Abraham wrote: > > > > > > On 2/11/20, 7:06 PM, "Daniel P. Berrangé" wrote: > > > > On Tue, Feb 11, 2020 at 10:05:53AM +0100, Martin Kletzander wrote: > > > > On Wed, Feb 05, 2020

[PATCH] docs: document port isolated property in domain/network/networkport

2020-02-25 Thread Laine Stump
Signed-off-by: Laine Stump --- I had thought I'd included documentation with the patch that added parsing/formatting for this, but after crobinso noticed it was missing, I realized that I had only put documentation in an earlier version of the patches (that put the option inside ). Oops :-/

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

2020-02-25 Thread Laine Stump
On 2/25/20 1:10 PM, Gaurav Agrawal wrote: Hi Laine, I am sure that I did --subject-prefix , not sure why it did not landed. Now am wondering about this situation do I still need a PATCH-3 or it's handled ? Nah, Jano pointed out what I thought of late last night - this is different from the

Plans for next release

2020-02-25 Thread Daniel Veillard
I'm a bit late, but it seems that if we freeze tomorrow, then RC2 could be provided on Friday and if everythig looks fine we can push 6.1.0 on Monday 2nd, so that's the plan, I hope this works for everyone ! Daniel -- Daniel Veillard | Red Hat Developers Tools

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

2020-02-25 Thread Gaurav Agrawal
Hi Laine, I am sure that I did --subject-prefix , not sure why it did not landed. Now am wondering about this situation do I still need a PATCH-3 or it's handled ? Thanks for giving your one last pass! Best Regards Gaurav On Tue, Feb 25, 2020, 22:46 Laine Stump wrote: > On 2/25/20 7:37 AM,

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

2020-02-25 Thread Laine Stump
On 2/25/20 7:37 AM, Ján Tomko wrote: On Mon, Feb 24, 2020 at 10:09:05PM -0500, Laine Stump wrote: On 2/24/20 1:58 PM, Gaurav Agrawal wrote: Yes, networkSetupPrivateChains is only called once (via virOnce, as suggested by the comment on the top of the function) on initialization and if either

Re: [libvirt PATCH 2/8] bridge: include netdev_bandwidth_conf.h

2020-02-25 Thread Ján Tomko
On Tue, Feb 25, 2020 at 04:37:28PM +0100, Michal Privoznik wrote: On 2/22/20 5:31 PM, Ján Tomko wrote: This file uses the virNetDevBandwidth*Floor helpers without including the correct include, relying on virnetworkportdef.h to include it. Signed-off-by: Ján Tomko Fixes:

[libvirt PATCH 1/2] conf: only allow virtio bus for input passthrough

2020-02-25 Thread Ján Tomko
Other buses are not supported. Signed-off-by: Ján Tomko https://bugzilla.redhat.com/show_bug.cgi?id=1724928 --- src/conf/domain_conf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17867eeece..e7d370e9c6 100644 ---

[libvirt PATCH 0/2] conf: only allow virtio bus for input passthrough

2020-02-25 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1724928 Ján Tomko (2): conf: only allow virtio bus for input passthrough conf: default to virtio bus for input passthrough src/conf/domain_conf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.24.1

[libvirt PATCH 2/2] conf: default to virtio bus for input passthrough

2020-02-25 Thread Ján Tomko
Other buses are not supported. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e7d370e9c6..ef5809ee54 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

Re: [libvirt PATCH] qemu: Do not set default CPU for archs without CPU driver

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 04:45:50PM +0100, Jiri Denemark wrote: > Whenever there is a guest CPU configured in domain XML, we will call > some CPU driver APIs to validate the CPU definition and check its > compatibility with the hypervisor. Thus domains with guest CPU > specification can only be

[libvirt PATCH] docs: fix docs about bandwidth setting with bridge networks

2020-02-25 Thread Daniel P . Berrangé
We now support setting bandwidth on networks with type bridge. Signed-off-by: Daniel P. Berrangé --- docs/formatnetwork.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 3d807ecab6..ec055c8360 100644

[libvirt PATCH] qemu: Do not set default CPU for archs without CPU driver

2020-02-25 Thread Jiri Denemark
Whenever there is a guest CPU configured in domain XML, we will call some CPU driver APIs to validate the CPU definition and check its compatibility with the hypervisor. Thus domains with guest CPU specification can only be started if the guest architecture is supported by the CPU driver. But we

Re: [libvirt PATCH 0/8] Include networkportdef.h in domain_conf.h

2020-02-25 Thread Michal Privoznik
On 2/22/20 5:31 PM, Ján Tomko wrote: The netdev_bandwidth_conf module contains XML parsing and formatting functions operating on types from util/virnetdevbandwidth.h as well as helper functions using types from domain_conf.h and network_conf.h It does not, however, introduce any new types, so

Re: [PATCH] virt-aa-helper: Fix build by including virutil.h

2020-02-25 Thread Jim Fehlig
On 2/25/20 4:35 AM, Michal Privoznik wrote: On 2/25/20 10:06 AM, Christian Ehrhardt wrote: On Tue, Feb 25, 2020 at 12:36 AM Jim Fehlig > wrote:     Commit fb01e1a44d missed including virutil.h, causing the following     compilation error    

Re: [libvirt PATCH 2/8] bridge: include netdev_bandwidth_conf.h

2020-02-25 Thread Michal Privoznik
On 2/22/20 5:31 PM, Ján Tomko wrote: This file uses the virNetDevBandwidth*Floor helpers without including the correct include, relying on virnetworkportdef.h to include it. Signed-off-by: Ján Tomko Fixes: 17f430eb5cfaaa3388077f2b0856f011f0b2a4c3 I have a question about this "Fixes" field.

Re: [libvirt PATCH] tests: fix missing test data for network port XML

2020-02-25 Thread Michal Privoznik
On 2/25/20 12:09 PM, Daniel P. Berrangé wrote: The network port XML files were not including any usage of vlan tags or port options, and one of the files was not even processed. Signed-off-by: Daniel P. Berrangé --- tests/virnetworkportxml2xmldata/plug-network.xml | 5 +

[libvirt PATCH] ci: Drop handling of $PKG_CONFIG_LIBDIR

2020-02-25 Thread Andrea Bolognani
As of libvirt-jenkins-ci commit e41e341f0d8f, we no longer bake this environment variable into our container images. Signed-off-by: Andrea Bolognani --- ci/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/ci/Makefile b/ci/Makefile index 577b130d2f..bc1dac11e3 100644 ---

Re: [libvirt PATCH v2 6/9] qemu: prepare and stop the dbus daemon

2020-02-25 Thread Marc-André Lureau
Hi On Tue, Feb 25, 2020 at 12:49 PM Daniel P. Berrangé wrote: > > On Tue, Feb 25, 2020 at 10:55:10AM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > src/qemu/qemu_process.c | 6 ++ > > 1 file changed, 6

[libvirt-dockerfiles PATCH] Refresh after changes to cross-building environments

2020-02-25 Thread Andrea Bolognani
The new configurations are simpler and more reliable. The corresponding libvirt-jenkins-ci commit is 483dfc62c86f. Signed-off-by: Andrea Bolognani --- As usual, this is merely the plain-text representation of a binary patch. Pushed under the Dockerfile update rule.

Re: [PATCH v2 3/3] kbase: backing_chains: Clarify some aspects of image probing

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 02:25:45PM +0100, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > docs/kbase/backing_chains.rst | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v2 2/3] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 02:25:44PM +0100, Peter Krempa wrote: > Allow format probing to work around lazy clients which did not specify > their format in the overlay. Format probing will be allowed only, if we > are able to probe the image, the probing result was successful and the > probed image

Re: [PATCH v2 1/3] qemu: domain: Convert detected 'iso' image format into 'raw'

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 02:25:43PM +0100, Peter Krempa wrote: > While our code can detect ISO as a separate format, qemu does not use it > as such and just passes it through as raw. Add conversion for detected > parts of the backing chain so that the validation code does not reject > it right

Re: [libvirt-jenkins-ci PATCH 0/4] Fixes and improvements to cross-build environments

2020-02-25 Thread Fabiano Fidêncio
On Tue, Feb 25, 2020 at 1:17 PM Andrea Bolognani wrote: > > The first two commits are necessary to build container images that > can successfully be used in libosinfo's GitLab CI setup, which is > currently not performing MinGW builds because of the issues they > address. > > Andrea Bolognani

[PATCH v2 0/3] Re-think stance towards image format probing

2020-02-25 Thread Peter Krempa
We decided that use of qemu-img would not be possible for this case. I'm thus re-sending the patch with fixes to docs and the ISO image format probe. This approach is the simplest and most straightforward and deals with most cases. Specifically we don't have to fix half of blockjob code by doing

[PATCH v2 2/3] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

2020-02-25 Thread Peter Krempa
Allow format probing to work around lazy clients which did not specify their format in the overlay. Format probing will be allowed only, if we are able to probe the image, the probing result was successful and the probed image does not have any backing or data file. This relaxes the restrictions

[PATCH v2 3/3] kbase: backing_chains: Clarify some aspects of image probing

2020-02-25 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/kbase/backing_chains.rst | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/docs/kbase/backing_chains.rst b/docs/kbase/backing_chains.rst index 3b3f0583e5..12ed6253ac 100644 --- a/docs/kbase/backing_chains.rst +++

[PATCH v2 1/3] qemu: domain: Convert detected 'iso' image format into 'raw'

2020-02-25 Thread Peter Krempa
While our code can detect ISO as a separate format, qemu does not use it as such and just passes it through as raw. Add conversion for detected parts of the backing chain so that the validation code does not reject it right away. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 4

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

2020-02-25 Thread Peter Krempa
On Tue, Feb 25, 2020 at 12:50:21 +, Daniel Berrange wrote: > On Mon, Feb 24, 2020 at 06:10:46PM +0100, Peter Krempa wrote: > > On Mon, Feb 24, 2020 at 14:24:15 +, Daniel Berrange wrote: > > > On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote: [...] > > > Would there be any

Re: [libvirt PATCH 5/6] Make PATHs unique for a VM object instance

2020-02-25 Thread Daniel P . Berrangé
On Wed, Feb 19, 2020 at 02:39:22AM +, Shaju Abraham wrote: > > > On 2/11/20, 7:06 PM, "Daniel P. Berrangé" wrote: > > On Tue, Feb 11, 2020 at 10:05:53AM +0100, Martin Kletzander wrote: > > > On Wed, Feb 05, 2020 at 05:32:50PM +, Daniel P. Berrangé wrote: > > > > On Mon, Feb

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 06:10:46PM +0100, Peter Krempa wrote: > On Mon, Feb 24, 2020 at 14:24:15 +, Daniel Berrange wrote: > > On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote: > > > On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote: > > [...] > > > > I'll reiterate the

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

2020-02-25 Thread Ján Tomko
On Mon, Feb 24, 2020 at 10:09:05PM -0500, Laine Stump wrote: On 2/24/20 1:58 PM, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Yay! It applied properly, so you have

Re: [PATCH v4 5/5] lxc: Count max VCPUs based on cpuset.cpus in native config

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 11:24:29AM -0300, Julio Faracco wrote: > Native config files sometimes can setup cpuset.cpus to pin some CPUs. > Before this, LXC was using a fixed number of 1 VCPU. After this commit, > XML definition will generate a dynamic number of VCPUs based on that > cgroup

Re: [PATCH v4 3/5] lxc: Replacing default strings definitions by g_autofree statement

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 11:24:27AM -0300, Julio Faracco wrote: > There are a lots of strings being handled inside some LXC functions. > They can be moved to g_autofree to avoid declaring a return value to get > proper code cleanups. This commit is changing functions from >

Re: [PATCH v4 2/5] lxc: Add HPET device into allowed devices

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 11:24:25AM -0300, Julio Faracco wrote: > This commit is related to RTC timer device too. HPET is being shared > from host device through `localtime` clock. This timer is available > creating a new timer using `hpet` name. > > Signed-off-by: Julio Faracco > --- >

Re: [PATCH v4 1/5] lxc: Add Real Time Clock device into allowed devices

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 11:24:24AM -0300, Julio Faracco wrote: > This commit share host Real Time Clock device (rtc) into LXC containers > to support hardware clock. This should be available setting up a `rtc` > timer under clock section. Since this option is not emulated, it should > be available

[libvirt-jenkins-ci PATCH 1/4] lcitool: Install dpkg-dev when doing cross-builds on Debian

2020-02-25 Thread Andrea Bolognani
When invoked as $triplet-pkg-config, pkg-config is smart enough to search the paths corresponding to the target architecture; on Debian, however, this currently only works when dpkg-dev is installed, which by default it is not. Work around the issue on our side by installing dpkg-dev explicitly

[libvirt-jenkins-ci PATCH 2/4] Don't set $PKG_CONFIG_LIBDIR anywhere

2020-02-25 Thread Andrea Bolognani
When invoked as $triplet-pkg-config, pkg-config is smart enough to search the paths corresponding to the target architecture, so we don't need to point it to them directly. This works for both MinGW builds and non-x86_64 Linux builds, and avoids the problems that come from setting

[libvirt-jenkins-ci PATCH 0/4] Fixes and improvements to cross-build environments

2020-02-25 Thread Andrea Bolognani
The first two commits are necessary to build container images that can successfully be used in libosinfo's GitLab CI setup, which is currently not performing MinGW builds because of the issues they address. Andrea Bolognani (4): lcitool: Install dpkg-dev when doing cross-builds on Debian

[libvirt-jenkins-ci PATCH 4/4] lcitool: Don't specify --target in $CONFIGURE_OPTS

2020-02-25 Thread Andrea Bolognani
If --target is not specified, the value of --host will be used, so having both is unnecessary; --target is mostly intended for building toolchains, which we're not doing. In fact, we're already not using --target in either the Jenkins and Ansible build scripts, thus proving that we don't need it.

[libvirt-jenkins-ci PATCH 3/4] lcitool: Drop duplicated code

2020-02-25 Thread Andrea Bolognani
Now that we no longer set $PKG_CONFIG_LIBDIR, there is no need to have separate code paths for Debian and Fedora. Signed-off-by: Andrea Bolognani --- guests/lcitool | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 053e46a..80e725c

Re: [libvirt PATCH v2 6/9] qemu: prepare and stop the dbus daemon

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 10:55:10AM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > src/qemu/qemu_process.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index

[PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

2020-02-25 Thread Gaurav Agrawal
From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 7bbde5c6a9..ac92d884b9 100644 ---

Re: [PATCH] virt-aa-helper: Fix build by including virutil.h

2020-02-25 Thread Michal Privoznik
On 2/25/20 10:06 AM, Christian Ehrhardt wrote: On Tue, Feb 25, 2020 at 12:36 AM Jim Fehlig > wrote: Commit fb01e1a44d missed including virutil.h, causing the following compilation error ../../src/security/virt-aa-helper.c:1055:43: error: implicit

Re: [PATCH v4 4/5] lxc: Implement virtual /proc/cpuinfo via LXC fuse

2020-02-25 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 11:24:28AM -0300, Julio Faracco wrote: > This commit tries to fix lots of issues related to LXC VCPUs. One of > them is related to /proc/cpuinfo content. If only 1 VCPU is set, LXC > containers will show all CPUs available for host. The second one is > related to CPU share,

Re: [PATCH 5/8] domain: save/restore the state of dbus-daemon running

2020-02-25 Thread Michal Privoznik
On 2/24/20 4:58 PM, Marc-André Lureau wrote: Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This avoids trying to start a dbus-daemon when its already running. Signed-off-by: Marc-André Lureau

Re: [PATCH 3/8] qemu-conf: add dbusStateDir

2020-02-25 Thread Michal Privoznik
On 2/24/20 4:57 PM, Marc-André Lureau wrote: Hi On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Location of DBus daemon state configuration, socket, pid... Signed-off-by: Marc-André Lureau ---

Re: [libvirt PATCH] docs: add page describing the libvirt daemons

2020-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2020 at 10:26:32AM +0100, Erik Skultety wrote: > On Mon, Feb 24, 2020 at 06:20:54PM +, Daniel P. Berrangé wrote: > > Now that we have more than just the libvirtd daemon, we should be > > explaining to users what they are all for & important aspects of their > > configuration. >

[libvirt PATCH] tests: fix missing test data for network port XML

2020-02-25 Thread Daniel P . Berrangé
The network port XML files were not including any usage of vlan tags or port options, and one of the files was not even processed. Signed-off-by: Daniel P. Berrangé --- tests/virnetworkportxml2xmldata/plug-network.xml | 5 + tests/virnetworkportxml2xmltest.c| 1 + 2 files

[libvirt PATCH] src: add virutil.h to more source files for geteuid() compat

2020-02-25 Thread Daniel P . Berrangé
The virutil.h header defines a geteuid() macro for Windows platforms. This fixes a few missed cases from: commit b11e8cccdd5163727fd4cecda0076ac2b63fe32d Author: Ján Tomko Date: Sun Feb 16 23:09:15 2020 +0100 Remove virutil.h from all header files Signed-off-by: Daniel P. Berrangé

[libvirt PATCH v2 6/9] qemu: prepare and stop the dbus daemon

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/qemu/qemu_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8c1ed76677..3a6cb4b2b0 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[libvirt PATCH v2 8/9] qemu-slirp: register helper for migration

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau When the helper supports DBus, connect it to the bus and set its ID. If the helper supports migration, register its ID to the list of dbus-vmstate ID to migrate, and specify --dbus-incoming when restoring the VM. Signed-off-by: Marc-André Lureau ---

[libvirt PATCH v2 2/9] qemu-conf: add configurable dbus-daemon location

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- m4/virt-driver-qemu.m4 | 6 ++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 +++ src/qemu/qemu_conf.c | 5 + src/qemu/qemu_conf.h | 1 +

[libvirt PATCH v2 7/9] qemu: add dbus-vmstate helper migration support

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Helper processes may have their state migrated with QEMU data stream thanks to the QEMU "dbus-vmstate". libvirt maintains the list of helpers to be migrated. The "dbus-vmstate" is added when required, and given the list of helper Ids that must be migrated, on save & load

[libvirt PATCH v2 9/9] WIP: qemu-slirp: update to follow current spec

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau The WIP specification is hosted on slirp wiki at this point: https://gitlab.freedesktop.org/slirp/libslirp/-/wikis/Slirp-Helper We would need more feedback from various parties (including libvirt, podman, and other developpers) before declaring a frozen version. So for

[libvirt PATCH v2 5/9] domain: save/restore the state of dbus-daemon running

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau This avoids trying to start a dbus-daemon when its already running. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_domain.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 4c6814a676..663938c9ff 100644

[libvirt PATCH v2 4/9] qemu: add a DBus daemon helper unit

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Add a unit to start & stop a private dbus-daemon. The daemon is meant to be started on demand, and associated with a QEMU process. It should be stopped when the QEMU process is stopped. The current policy is permissive like a session bus. Stricter policies can be added

[libvirt PATCH v2 3/9] qemu-conf: add dbusStateDir

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Location of DBus daemon state configuration, socket, pid... Signed-off-by: Marc-André Lureau --- src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt PATCH v2 0/9] Second take on slirp-helper & dbus-vmstate

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau Hi, The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has been merged and partially reverted. Meanwhile, qemu dbus-vmstate design has been changed and merged upstream. This new series fixes the slirp-helper support. The significant change is that

[libvirt PATCH v2 1/9] qemu: remove dbus-vmstate code

2020-02-25 Thread marcandre . lureau
From: Marc-André Lureau This code was based on a per-helper instance and peer-to-peer connections. The code that landed in qemu master for v5.0 is relying on a single instance and DBus bus. Instead of trying to adapt the existing dbus-vmstate code, let's remove it and resubmit. That should make

Re: [libvirt PATCH] docs: add page describing the libvirt daemons

2020-02-25 Thread Erik Skultety
On Mon, Feb 24, 2020 at 06:20:54PM +, Daniel P. Berrangé wrote: > Now that we have more than just the libvirtd daemon, we should be > explaining to users what they are all for & important aspects of their > configuration. > > Signed-off-by: Daniel P. Berrangé > --- > docs/daemons.rst | 682

Re: [PATCH] virt-aa-helper: Fix build by including virutil.h

2020-02-25 Thread Christian Ehrhardt
On Tue, Feb 25, 2020 at 12:36 AM Jim Fehlig wrote: > Commit fb01e1a44d missed including virutil.h, causing the following > compilation error > > ../../src/security/virt-aa-helper.c:1055:43: error: implicit declaration of > function 'virHostGetDRMRenderNode'

Re: [PATCH 0/3] security: Don't fail if locking a file on NFS mount fails

2020-02-25 Thread Peter Krempa
On Fri, Feb 21, 2020 at 10:33:00 +0100, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Prívozník (3): > virSecurityManagerMetadataLock: Store locked paths > security: Don't remember seclabel for paths we haven't locked > successfully > security: Don't fail if locking a file on