[PATCH 2/3] qemu_hotplug.c: remove dimm auto-align on hotplug/unplug

2020-02-29 Thread Daniel Henrique Barboza
ppc64 guests need the dimm to be aligned to 256MiB. The existing auto-align mechanic in qemuDomainAttachMemory(), via qemuDomainMemoryDeviceAlignSize(), is rounding up the dimms to the next 256MiB alignment. This leads to confusing situations in which the user intended to hotplug 300MiB, but see

[PATCH 3/3] qemu_domain.c: remove qemuDomainMemoryDeviceAlignSize()

2020-02-29 Thread Daniel Henrique Barboza
Previous patch removed all the callers of the function. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 16 src/qemu/qemu_domain.h | 2 -- 2 files changed, 18 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[PATCH 1/3] qemu_domain.c: make qemuDomainGetMemoryModuleSizeAlignment() public

2020-02-29 Thread Daniel Henrique Barboza
This function will be used in qemu_hotplug.c in the next patch. While we're at it, we can remove the virDomainMemoryDef argument since the alignment size doesn't change with this object. The only existent caller can also be brought out of a loop which iterates in a virDomainMemoryDef list.

[PATCH 0/3] remove dimm auto-align on hotplug/unplug

2020-02-29 Thread Daniel Henrique Barboza
This series fixes bug [1]. See patch 2 for details. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1780506 Daniel Henrique Barboza (3): qemu_domain.c: make qemuDomainGetMemoryModuleSizeAlignment() public qemu_hotplug.c: remove dimm auto-align on hotplug/unplug qemu_domain.c: remove

Re: Availability of 6.1.0 RC2

2020-02-29 Thread Daniel Veillard
On Sat, Feb 29, 2020 at 04:51:34PM +0100, Ján Tomko wrote: > On a Saturday in 2020, Daniel Veillard wrote: > > Completely forgot to push it yesterday, I had a really busy week. > > It is tagged in git and signed source tarbal and rpm are available at > > the usual place: > > > >

Re: [libvirt PATCH 0/3] gitdm: Fixes and updates

2020-02-29 Thread Ján Tomko
On a Friday in 2020, Andrea Bolognani wrote: blurb.com *** BLURB HERE ***, Inc. Andrea Bolognani (3): gitdm: Add entry for example.com gitdm: Fix sorting gitdm: Add missing entries docs/gitdm/companies/others| 5 - docs/gitdm/groups/unaffiliated | 5 + 2 files changed, 9

Re: [PATCH] admin: use g_autofree

2020-02-29 Thread Ján Tomko
On a Saturday in 2020, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Your author name is in all caps, consider using the same form as below: Signed-off-by: Gaurav Agrawal To see where it comes from you can use --show-origin: $ git config --show-origin user.name

Re: [libvirt PATCH] news: Update for libvirt 6.1.0

2020-02-29 Thread Ján Tomko
On a Friday in 2020, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani --- I probably won't be able to check my computer between now and the release, so if anyone gets a chance to review the patch in the meantime please feel free to push it as well :) docs/news.xml | 36

Re: Availability of 6.1.0 RC2

2020-02-29 Thread Ján Tomko
On a Saturday in 2020, Daniel Veillard wrote: Completely forgot to push it yesterday, I had a really busy week. It is tagged in git and signed source tarbal and rpm are available at the usual place: https://libvirt.org/sources/ This looks fine to me, but I'm obviously on linux, and since

[PATCH] admin: use g_autofree

2020-02-29 Thread Gaurav Agrawal
From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/admin/libvirt-admin.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index 4099a54854..d841a15f95 100644 --- a/src/admin/libvirt-admin.c +++

Re: [PATCH 3/8] qemu-conf: add dbusStateDir

2020-02-29 Thread Ján Tomko
On a Friday in 2020, Marc-André Lureau wrote: Hi On Tue, Feb 25, 2020 at 12:24 PM Michal Privoznik wrote: On 2/24/20 4:57 PM, Marc-André Lureau wrote: > Hi > > On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote: >> >> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote: >>> From:

Availability of 6.1.0 RC2

2020-02-29 Thread Daniel Veillard
Completely forgot to push it yesterday, I had a really busy week. It is tagged in git and signed source tarbal and rpm are available at the usual place: https://libvirt.org/sources/ This looks fine to me, but I'm obviously on linux, and since this release removes the glib support I