On a Wednesday in 2020, Lan wrote:
Create a new function virDaemonSetupLogging (src/util/virdaemon.c)
for shared code in
virLockDaemonSetupLogging (src/locking/lock_daemon.c)
virLogDaemonSetupLogging (src/logging/log_daemon.c)
daemonSetupLogging (src/remote/remote_daemon.c)
As mentioned in
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
On 3/4/20 3:06 PM, Gaurav Agrawal wrote:
Signed-off-by: Gaurav Agrawal
---
src/admin/libvirt-admin.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c
On 3/4/20 3:06 PM, Gaurav Agrawal wrote:
Signed-off-by: Gaurav Agrawal
---
src/admin/libvirt-admin.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c
index 4099a54854..709e009467 100644
---
Signed-off-by: Gaurav Agrawal
---
src/admin/libvirt-admin.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c
index 4099a54854..709e009467 100644
--- a/src/admin/libvirt-admin.c
+++ b/src/admin/libvirt-admin.c
Merge the bitmaps into base of the block commit after the job finishes.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 50
1 file changed, 50 insertions(+)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index
I'll be adding more fields to care about so splitting the code out will
be better long-term.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 57 ++
1 file changed, 36 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_domain.c
If a block-copy fails we should at least re-enable the bitmaps so that
the operation can be re-tried.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 42 ++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c
Active layer block commit makes the 'base' image the new top image of
the disk after it finishes. This means that all bitmap operations need
to be handled prior to this happening as we'd lose writes otherwise.
The ideal place is to handle it when pivoting to the new image as only
guest-writes
Add an argument to qemuBlockJobDiskNewCommit to propagate the list of
disabled bitmaps into the job data structure.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 2 ++
src/qemu/qemu_blockjob.h | 1 +
src/qemu/qemu_driver.c | 2 +-
3 files changed, 4 insertions(+), 1 deletion(-)
Use the 'snapshots-synthetic-broken' test data for block-commit.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 13
.../snapshots-synthetic-broken-1-2| 30
.../snapshots-synthetic-broken-1-3| 66
On start of the commit job, we need to disable any active bitmap in the
base. Use qemuBlockBitmapsHandleCommitStart to calculate which and call
the appropriate QMP APIs. We use blockdev-reopen to make the 'base'
writable to disable the bitmaps.
Signed-off-by: Peter Krempa
---
Test handling of more complex cases of merging bitmaps accross
snapshots.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 15 ++
.../bitmapblockcommit/snapshots-1-2 | 49 +++
.../bitmapblockcommit/snapshots-1-3 | 76 ++
Add code for testing the two necessary steps of handling bitmaps during
block commit and excercise the code on the test data which we have for
bitmap handling.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 95 ++
.../bitmapblockcommit/basic-1-2
I'll be adding more fields to care about so splitting the code out will
be better long-term.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
Starting a commit job will require disabling bitmaps in the base image
so that they are not dirtied by the commit job. We need to store a list
of the bitmaps so that we can later re-enable them.
Add a field and status XML handling code as well as a test.
Signed-off-by: Peter Krempa
---
qemuBlockBitmapsHandleCommitStart prepares for disabling the bitmaps in
the 'base' of the commit job so that the bitmaps are not dirtied by the
commit job. This needs to be done prior to start of the commit job.
qemuBlockBitmapsHandleCommitFinish then calculates the necessary merges
that agregate
Set the 'id' field of the backing chain properly so that we can look
up images and initialize 6 images instead of 10 as we don't use more
currently.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemublocktest.c
This implements handling of bitmaps during block-commit so that
incremental backups are not broken after commit.
Note that this applies on top of
https://www.redhat.com/archives/libvir-list/2020-February/msg01125.html
or can be fetched at
git fetch https://gitlab.com/pipo.sk/libvirt.git
On Wed, Mar 04, 2020 at 09:42:38AM -0500, Cole Robinson wrote:
> I see the 6.1.0 commit in libvirt-python, but it seems the release
> .tar.gz wasn't uploaded:
>
> https://libvirt.org/sources/python/
Dohhh, way too much multitasking going on I'm afraid :-\
hopefully fixed,
thanks for
On Wed, Mar 04, 2020 at 16:56:02 +0100, Ján Tomko wrote:
> We recognize three return values from tests:
> * OK-> 0
> * SKIP -> EXIT_AM_SKIP
> * ERROR -> anything else
>
> Also check for EXIT_AM_SKIP when building a bitmap of failed tests,
> otherwise the skipped tests would be printed in the
We recognize three return values from tests:
* OK-> 0
* SKIP -> EXIT_AM_SKIP
* ERROR -> anything else
Also check for EXIT_AM_SKIP when building a bitmap of failed tests,
otherwise the skipped tests would be printed in the suggested range
of tests that shoud be re-run.
Reported-by: Peter
On 3/4/20 11:16 AM, Peter Krempa wrote:
I take a look at Markus' QMP deprecation-introspection series. While
that requires a lot more work I've fixed a few things along.
Peter Krempa (3):
util: json: Convert virJSONValueNewObject() to g_new0
qemuMonitorJSONSetMigrationParams: Refactor
I see the 6.1.0 commit in libvirt-python, but it seems the release
.tar.gz wasn't uploaded:
https://libvirt.org/sources/python/
Thanks,
Cole
On 3/4/20 4:40 AM, Daniel Veillard wrote:
> It's out, one day late, though I did the build and pushed the tag
> in git yesterday, but I had forgotten to
On Wed, Mar 04, 2020 at 03:13:41PM +0100, Peter Krempa wrote:
> On Wed, Mar 04, 2020 at 15:01:07 +0100, Pavel Mores wrote:
> > On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote:
> > > On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote:
> > > > On Wed, Mar 04, 2020 at 01:00:59PM
Use the new command in the test suite by asserting the capability
and adjusting test data to the correct field names as they changed
compared to 'query-cpus'.
Signed-off-by: Peter Krempa
---
tests/qemuhotplugtest.c | 2 +
.../ppc64-modern-bulk-monitor.json|
Make it obvious that the function always returns a valid pointer and fix
all callers.
Signed-off-by: Peter Krempa
---
src/admin/admin_server_dispatch.c | 3 ---
src/locking/lock_daemon.c | 8 +---
src/logging/log_daemon.c | 8 +---
src/logging/log_handler.c |
qemuMonitorJSONMakeCommandInternal does the full command construction if
you pass in what would become the value of the 'arguments' key. Refactor
the open-coded implementation to use the helper and use modern cleanup
helpers at the same time.
Signed-off-by: Peter Krempa
---
I take a look at Markus' QMP deprecation-introspection series. While
that requires a lot more work I've fixed a few things along.
Peter Krempa (3):
util: json: Convert virJSONValueNewObject() to g_new0
qemuMonitorJSONSetMigrationParams: Refactor command construction and
cleanup
Hi Rohan,
Thank you for your interest in the RedFish project idea. I'll will
answer you back the same thing I already said to the other students
that reached me.
In order to prepare a good application, throughly read the RedFish
specification and come up with a paper describing how you would map
On Wed, Mar 04, 2020 at 15:01:07 +0100, Pavel Mores wrote:
> On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote:
> > On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote:
> > > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> > > > On Wed, Mar 04, 2020 at 11:12:37
On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote:
> On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote:
> > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> > > > A new command-line option --top was
On Wed, Mar 04, 2020 at 14:55:30 +0100, Pavel Mores wrote:
> On Wed, Mar 04, 2020 at 02:41:09PM +0100, Pavel Mores wrote:
> > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> > > > A new command-line option --top was
On Wed, Mar 04, 2020 at 02:41:09PM +0100, Pavel Mores wrote:
> On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> > > A new command-line option --top was added to virsh's blockpull command.
> > > Similar to how --base is
On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote:
> On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> > > A new command-line option --top was added to virsh's blockpull command.
> > > Similar to how --base is
Markus Armbruster writes:
> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is intended for testing users of
> the
On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote:
> On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> > A new command-line option --top was added to virsh's blockpull command.
> > Similar to how --base is handled, in presence of --top the operation is
> > implemented
We've been doing alot of refactoring of code in recent times, and also
have plans for significant infrastructure changes. We still need to
spend time delivering interesting features to users / applications.
This mail is to introduce an idea for a solution to an specific
area applications have had
On Wed, 2020-03-04 at 15:15 +0800, Zhenyu Zheng wrote:
> Hello Libvirt,
>
> With more and more ARM servers on the market and increasing amount of
> users, we got reported alot that Libvirt cannot provide as much
> function on ARM platform as on other platforms(mainly x86), some basic
> founctions
On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote:
> A new command-line option --top was added to virsh's blockpull command.
> Similar to how --base is handled, in presence of --top the operation is
> implemented internally as a rebase. To that end, a corresponding new 'top'
> parameter
On Tue, Mar 03, 2020 at 17:34:35 +0100, Markus Armbruster wrote:
> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is
Rebase implementation in QEMU driver extended with a new 'top' parameter.
Support for 'top' added to RPC's remote_domain_block_rebase_args structure.
Signed-off-by: Pavel Mores
---
src/driver-hypervisor.h | 1 +
src/libvirt-domain.c | 2 +-
src/qemu/qemu_driver.c | 3 ++-
qemuDomainBlockPullCommon() is one of the functions in block pull
implementation that have to support 'top' to make block pull as
a whole to support it.
Signed-off-by: Pavel Mores
---
src/qemu/qemu_driver.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git
This commit only handles submission of block-stream command. Since
block-stream is a job, we'll need to handle its completion as well
in an upcoming commit.
Signed-off-by: Pavel Mores
---
src/qemu/qemu_driver.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git
'top' handling basically requires two changes: besides the obvious
adjustments to the code that fixes our backing chains (for both
active and inactive configuration) after a pull, we need to make
the top image read-only again if it's not identical with the
active layer (it had to be made writable
A new command-line option --top was added to virsh's blockpull command.
Similar to how --base is handled, in presence of --top the operation is
implemented internally as a rebase. To that end, a corresponding new 'top'
parameter was added to virDomainBlockRebase().
Signed-off-by: Pavel Mores
QEMU's block-stream command supports pulling ("streaming" in QMP lingo) into
arbitrary layer, however libvirt can only pull into an active layer. This
series is a proof-of-concept work to extend libvirt's pull to support pulling
into non-active layers as well.
While this doesn't seem to be a
It's out, one day late, though I did the build and pushed the tag
in git yesterday, but I had forgotten to push the commit, thanks
Boris for raising this to me. So it's now available as signed tarball
and rpm source package at the usual place:
https://libvirt.org/sources/
This release come
Signed-off-by: Michal Privoznik
---
Pushed.
configure.ac | 2 +-
docs/news.xml | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index ac4052afb6..e565437062 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You should
Peter Maydell writes:
> On Wed, 4 Mar 2020 at 08:18, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > How much do you think this is likely to affect the
>> > generate-rst-from-qapi-docs series? I'd really like
>> > that to go in for this release, but this looks like
>> > it's shaping up
On Wed, 4 Mar 2020 at 08:18, Markus Armbruster wrote:
> Peter Maydell writes:
> > How much do you think this is likely to affect the
> > generate-rst-from-qapi-docs series? I'd really like
> > that to go in for this release, but this looks like
> > it's shaping up to be a big conflict :-(
>
> I
Create a new function virDaemonSetupLogging (src/util/virdaemon.c)
for shared code in
virLockDaemonSetupLogging (src/locking/lock_daemon.c)
virLogDaemonSetupLogging (src/logging/log_daemon.c)
daemonSetupLogging (src/remote/remote_daemon.c)
One of the BiteSizedTasks
---
src/libvirt_private.syms
Peter Maydell writes:
> On Tue, 3 Mar 2020 at 16:37, Markus Armbruster wrote:
>>
>> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>>
>> This series extends QMP introspection to cover deprecation.
>> Additionally, new option -compat lets you configure what to do when
>> deprecated
> >>> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module
> >>>
> >>>
> >>> On 2020/1/19 下午5:10, Zhang, Chen wrote:
> Hi~
>
> Anyone have comments about this module?
> >>> Hi Chen:
> >>>
> >>> I will take a look at this series.
> >> Sorry for slow reply due to CNY and
53 matches
Mail list logo
