On 3/12/20 2:28 PM, Eric Blake wrote:
v3 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01730.html
In v4:
- old patch 1 was reworked into new patch 1-3, with stricter rules
on which backing formats are accepted [Kevin]
- patch 4 is new: amend is handled differently from
Mea-culpa I forgot to push RC2 on Tuesday, rather than pushing the
release off by 2 more days, I decided to push the release today to stay
on schedule. As a result 6.2.0 is out, tagged in git and source tarball
and rpm are available at the usual place:
https://libvirt.org/sources/
I also
On 4/1/20 11:10 AM, Han Han wrote:
Signed-off-by: Han Han
---
Looks good. I'd just rename the commit to "domainsnapshot.rng: Support
encryption
and slices element" because prefixing the commit with "rng" can be misleading
with commits related to the "rng" virtio backend.
DHB
On Thu, 2020-04-02 at 10:26 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 11:24:25AM +0200, Andrea Bolognani wrote:
> > On Thu, 2020-04-02 at 09:41 +0100, Daniel P. Berrangé wrote:
> > > Please ignore all the RPMs you see there, they really shouldn't be
> > > used.
> >
> > Can we
When the comment in libvirtd.sasl was last updated with
commit fe772f24a6809b3d937ed6547cbaa9d820e514b6
Author: Cole Robinson
Date: Sat Oct 20 14:10:03 2012 -0400
daemon: Avoid 'Could not find keytab file' in syslog
it was noted that only old versions of kerberos would need the
While not terribly useful in general, tweaking each daemon's
timeout (or disabling it off altogether) is a valid use case which
we can very easily support while being consistent with what already
happens for libvirtd. This is a first step in that direction.
Signed-off-by: Andrea Bolognani
This follows the example set by libvirtd, and makes it easier for
the admin to tweak the timeout or disable it altogether.
Signed-off-by: Andrea Bolognani
---
src/interface/virtinterfaced.service.in | 2 +-
src/interface/virtinterfaced.sysconf| 2 +-
src/libxl/virtxend.service.in
Changes from [v1]:
* move timeout setting from the service files to the sysconf files
instead of the other way around;
* remove obsolete KRB5_KTNAME override completely, including from
OpenRC init scripts;
* don't enable timeout for virtlogd, as it's not safe, and
virtlockd,
We're going to add many more later, so start by adjusting the
existing ones to more closely follow the example set by libvirtd.
Signed-off-by: Andrea Bolognani
---
src/locking/virtlockd.sysconf | 6 +++---
src/logging/virtlogd.sysconf | 6 +++---
tools/libvirt-guests.sysconf | 2 ++
3 files
When using systemd we want to take advantage of socket activation
instead of keeping daemons running all the time, so we default to
shutting them down after two minutes of inactivity.
At the same time, we want it to be possible for the admin to opt
out of this behavior and disable timeouts
libvirtd supports this feature, and virtqemud ultimately calls to
the same code so it does as well: advertise it in the sysconf file
for the latter, as is already the case for the former.
Signed-off-by: Andrea Bolognani
Reviewed-by: Ján Tomko
---
src/qemu/virtqemud.sysconf | 9 +
1
Thanks!
чт, 2 апр. 2020 г. в 13:22, Daniel P. Berrangé :
> On Thu, Apr 02, 2020 at 01:05:28PM +0300, Vasiliy Tolstov wrote:
> > Hi! i need to have passwordless auth to spice (because it is restricted
> to
> > 127.0.0.1 and nobody can connect to it, in feature i want to use it via
> > unix
As mentioned on https://wiki.libvirt.org/page/Main_Page
I'd like to request a wiki account for contributions on wiki.libvirt.org
Preferred username: smitterl
Thank you in advance,
Sebastian
On Thu, Apr 02, 2020 at 05:34:03PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-04-02 at 13:38 +0100, Daniel P. Berrangé wrote:
> > On Thu, Apr 02, 2020 at 02:16:46PM +0200, Andrea Bolognani wrote:
> > > On Thu, 2020-04-02 at 13:00 +0100, Daniel P. Berrangé wrote:
> > > > The effect on this
On Thu, 2020-04-02 at 13:38 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 02:16:46PM +0200, Andrea Bolognani wrote:
> > On Thu, 2020-04-02 at 13:00 +0100, Daniel P. Berrangé wrote:
> > > The effect on this though is that --timeout arg now has to be
> > > specified twice so we'll get a
On Thu, Mar 26, 2020 at 12:18:01PM +0100, Peter Krempa wrote:
> See 2/2.
>
> Peter Krempa (2):
> qemuSecurityChownCallback: Remove 'cleanup' section
> qemuSecurityChownCallback: Don't initialize storage file subsystem for
> local file
>
> src/qemu/qemu_driver.c | 31
On a Wednesday in 2020, Peter Krempa wrote:
Peter Krempa (5):
qemumonitorjsontest: Space out test name concatenation
qemuMonitorTestProcessCommandDefaultValidate: Output validator output
to stderr
qemumonitorjsontest: AddNetdev: Use real variant
syntax-check: Exempt
On Thu, 2020-04-02 at 14:01 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 02:51:13PM +0200, Andrea Bolognani wrote:
> > I started a VM, waited a bit, and sure enough virtlogd quit on its
> > own. However, after I ssh'd into the VM and executed poweroff,
> > virtlogd was
On Thu, Apr 02, 2020 at 02:51:13PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-04-02 at 13:36 +0100, Daniel P. Berrangé wrote:
> > On Thu, Apr 02, 2020 at 02:20:27PM +0200, Andrea Bolognani wrote:
> > > On Thu, 2020-04-02 at 13:10 +0100, Daniel P. Berrangé wrote:
> > > > virLogDaemonInhibitor
On Thu, Apr 02, 2020 at 14:51:13 +0200, Andrea Bolognani wrote:
> On Thu, 2020-04-02 at 13:36 +0100, Daniel P. Berrangé wrote:
> > On Thu, Apr 02, 2020 at 02:20:27PM +0200, Andrea Bolognani wrote:
> > > On Thu, 2020-04-02 at 13:10 +0100, Daniel P. Berrangé wrote:
> > > > virLogDaemonInhibitor only
On Thu, 2020-04-02 at 13:36 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 02:20:27PM +0200, Andrea Bolognani wrote:
> > On Thu, 2020-04-02 at 13:10 +0100, Daniel P. Berrangé wrote:
> > > virLogDaemonInhibitor only inhibits timer shutdown for the unprivileged
> > > daemon. This setting
On Thu, Apr 02, 2020 at 02:16:46PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-04-02 at 13:00 +0100, Daniel P. Berrangé wrote:
> > On Wed, Apr 01, 2020 at 08:53:39PM +0200, Andrea Bolognani wrote:
> > > There is nothing really systemd-specific about passing extra
> > > arguments to daemons so
On Thu, Apr 02, 2020 at 02:20:27PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-04-02 at 13:10 +0100, Daniel P. Berrangé wrote:
> > On Wed, Apr 01, 2020 at 08:53:41PM +0200, Andrea Bolognani wrote:
> > > [Service]
> > > EnvironmentFile=-@sysconfdir@/sysconfig/virtlogd
> > >
On Thu, 2020-04-02 at 13:05 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 01, 2020 at 08:53:38PM +0200, Andrea Bolognani wrote:
> > -if (timeout != -1) {
> > +if (timeout > 0) {
> > VIR_DEBUG("Registering shutdown timeout %d", timeout);
> >
On Thu, 2020-04-02 at 13:10 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 01, 2020 at 08:53:41PM +0200, Andrea Bolognani wrote:
> > [Service]
> > EnvironmentFile=-@sysconfdir@/sysconfig/virtlogd
> > -ExecStart=@sbindir@/virtlogd $VIRTLOGD_ARGS
> > +ExecStart=@sbindir@/virtlogd --timeout 120
On Thu, 2020-04-02 at 13:00 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 01, 2020 at 08:53:39PM +0200, Andrea Bolognani wrote:
> > There is nothing really systemd-specific about passing extra
> > arguments to daemons so it's reasonable, although not currently the
> > case, that startup scripts
On Wed, Apr 01, 2020 at 08:53:41PM +0200, Andrea Bolognani wrote:
> This is consistent with what is already done for all other
> daemons.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 2 +-
> src/logging/virtlogd.service.in | 2 +-
> 2 files changed, 2
On Wed, Apr 01, 2020 at 08:53:38PM +0200, Andrea Bolognani wrote:
> When using systemd we want to take advantage of socket activation
> instead of keeping daemons running all the time, so we default to
> shutting them down after two minutes of inactivity.
>
> At the same time, we want it to be
On Thu, 2020-04-02 at 12:56 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 01, 2020 at 08:53:43PM +0200, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani
> > ---
> > libvirt.spec.in | 11 +++
> > 1 file changed, 11 insertions(+)
>
> This should be in the same commit that adds
On Wed, Apr 01, 2020 at 08:53:39PM +0200, Andrea Bolognani wrote:
> There is nothing really systemd-specific about passing extra
> arguments to daemons so it's reasonable, although not currently the
> case, that startup scripts written for other init systems might want
> to source these sysconf
On Wed, Apr 01, 2020 at 08:53:43PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 11 +++
> 1 file changed, 11 insertions(+)
This should be in the same commit that adds the files, for bisectability
Regards,
Daniel
--
|: https://berrange.com
On a Wednesday in 2020, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 11 +++
1 file changed, 11 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Wednesday in 2020, Andrea Bolognani wrote:
While not terribly useful in general, turning off each daemon's
timeout is a valid use case which we can very easily support while
being consistent with what already happens for libvirtd, virtlogd
and virtlockd.
Signed-off-by: Andrea Bolognani
On a Wednesday in 2020, Andrea Bolognani wrote:
This is consistent with what is already done for all other
daemons.
Signed-off-by: Andrea Bolognani
---
src/locking/virtlockd.service.in | 2 +-
src/logging/virtlogd.service.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
On a Wednesday in 2020, Andrea Bolognani wrote:
There is nothing really systemd-specific about passing extra
arguments to daemons so it's reasonable, although not currently the
case, that startup scripts written for other init systems might want
to source these sysconf files; for those init
On a Wednesday in 2020, Andrea Bolognani wrote:
The sysconf file is not the correct place for this.
This reverts commit 02b6005063d6e8b5c6c695ed1ffaf10ef45143b0.
Same comment about the trailing period.
Signed-off-by: Andrea Bolognani
---
src/logging/virtlogd.sysconf | 2 +-
1 file changed,
On a Wednesday in 2020, Andrea Bolognani wrote:
When using systemd we want to take advantage of socket activation
instead of keeping daemons running all the time, so we default to
shutting them down after two minutes of inactivity.
At the same time, we want it to be possible for the admin to
On Thu, Mar 26, 2020 at 01:39:41PM +0100, Peter Krempa wrote:
> Add a comment noting that job update can cause the pointer to be invalid
> and thus should not be accessed after.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_blockjob.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
On Thu, Mar 26, 2020 at 01:39:39PM +0100, Peter Krempa wrote:
> Upcoming patch will remove it.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 17 +++--
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c
On Thu, Mar 26, 2020 at 01:39:40PM +0100, Peter Krempa wrote:
> No callers use it any more. Additionally if qemuBlockJobUpdate was
> called with the last reference of the job e.g. in
> qemuBlockJobRefreshJobs, the reading of the job state would happen from
> freed memory.
>
> Reported-by: Pavel
On Thu, 2020-04-02 at 12:39 +0200, Ján Tomko wrote:
> You can delete the following occurrennccess too:
> $ git grep KRB5_KTNAME
> src/remote/libvirtd.init.in:start_stop_daemon_args="--env
> KRB5_KTNAME=/etc/libvirt/krb5.tab"
> src/remote/virtproxyd.init.in:start_stop_daemon_args="--env
>
On a Wednesday in 2020, Andrea Bolognani wrote:
When the comment in libvirtd.sasl was last updated with
commit fe772f24a6809b3d937ed6547cbaa9d820e514b6
Author: Cole Robinson
Date: Sat Oct 20 14:10:03 2012 -0400
daemon: Avoid 'Could not find keytab file' in syslog
it was noted that
On Thu, Apr 02, 2020 at 01:05:28PM +0300, Vasiliy Tolstov wrote:
> Hi! i need to have passwordless auth to spice (because it is restricted to
> 127.0.0.1 and nobody can connect to it, in feature i want to use it via
> unix socket).
> I'm checking docs at libvirt site and don't see any
On a Thursday in 2020, Peter Krempa wrote:
Commit 2ace7a87a8aced68c250 introduced a logic bug by an improperly
modified condition where we'd skip to the else branch when reusing of
external images was requested and blockdev is available.
The original intentions were to skip the backing store
Hi! i need to have passwordless auth to spice (because it is restricted to
127.0.0.1 and nobody can connect to it, in feature i want to use it via
unix socket).
I'm checking docs at libvirt site and don't see any disable-ticketing
options.
SO how can I pass this option and allow access without a
On Thu, Apr 02, 2020 at 11:24:25AM +0200, Andrea Bolognani wrote:
> [moving to libvir-list]
>
> On Thu, 2020-04-02 at 09:41 +0100, Daniel P. Berrangé wrote:
> > On Thu, Apr 02, 2020 at 08:47:30AM +0800, FuLong Wang wrote:
> > > Do we have libvirt source rpms (version above 5.9.0) for CentOS or
[moving to libvir-list]
On Thu, 2020-04-02 at 09:41 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 02, 2020 at 08:47:30AM +0800, FuLong Wang wrote:
> > Do we have libvirt source rpms (version above 5.9.0) for CentOS or RHEL?
> >
> > I only find source rpms for fedora in below public link.
> >
>
Hi Daniel,
Thanks for the review and tips, I've done some learning and finally found
the way to read and parse vendor_id, part_id and cpu flags of an ARM
CPU directly from registers just like what has been done in X86 drivers.
And I've uploaded a V2 patch for these.
BR,
Zhenyu Zhengh
On Mon,
Introduce getHost support for ARM CPU driver. First add
some data about commonly used ARM CPU models, and their
vendors into cpu_map, then added some helper methods as
callbacks to load them. Read and parse vendor_id, part_id
and CPU flags of local CPU from corresponding registers.
Signed-off-by:
Introduce getHost support for ARM CPU driver, read
CPU vendor_id, part_id and flags from registers
directly.
Signed-off-by: Zhenyu Zheng
---
src/cpu/cpu_arm.c | 194 +-
1 file changed, 193 insertions(+), 1 deletion(-)
diff --git a/src/cpu/cpu_arm.c
Introduce vendors and some commonly used models
for ARM arch, these will be used for virConnectionGetCapabilities
for ARM CPUs.
Signed-off-by: Zhenyu Zheng
---
src/cpu_map/Makefile.inc.am | 7 +++
src/cpu_map/arm_Falkor.xml| 16
Introduce virCPUarmData to virCPUData
Signed-off-by: Zhenyu Zheng
---
src/cpu/Makefile.inc.am | 1 +
src/cpu/cpu.h | 2 ++
src/cpu/cpu_arm_data.h | 31 +++
3 files changed, 34 insertions(+)
create mode 100644 src/cpu/cpu_arm_data.h
diff --git
Introduce vendor and model struct and related
cleanup functions for ARM cpu.
Signed-off-by: Zhenyu Zheng
---
src/cpu/cpu_arm.c | 75 +++
1 file changed, 75 insertions(+)
diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c
index ee5802198f..c757c24a37
Add helper functions to parse vendor and model from
xml for ARM arch, and use them as callbacks when
load cpu maps.
Signed-off-by: Zhenyu Zheng
---
src/cpu/cpu_arm.c | 176 +-
1 file changed, 174 insertions(+), 2 deletions(-)
diff --git
54 matches
Mail list logo
