Re: [PATCH] libxl: enable Xen's e820_host setting

On 4/9/20 7:14 AM, Daniel P. Berrangé wrote: On Wed, Apr 08, 2020 at 02:29:16PM -0600, Jim Fehlig wrote: Hotplugging PCI devices to Xen PV guests is only possible if the libxl_domain_build_info struct has the e820_host field enabled when the guest is created. By default it is disabled but libxl

[PATCH] formatdomain.html.in: document emulator/vcpu pin delay

In a guest with only one vcpu, when pinning the emulator in say CPU184 and the vcpu0 in CPU0 of the host, the user might expect that only CPU0 and CPU184 of the host will be used by the guest. The reality is that Libvirt takes some time to honor the emulator and vcpu pinning, taking care of NUMA c

Re: [libvirt-ci PATCH v2] dco: build and publish a container image for DCO check

On Thu, 2020-04-09 at 18:21 +0100, Daniel P. Berrangé wrote: > This builds a container image containing the DCO checking script. > It is then published at: > >registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master s/jenkins-// With that fixed, Reviewed-by: Andrea Bolognani --

[libvirt-ci PATCH v2] dco: build and publish a container image for DCO check

This builds a container image containing the DCO checking script. It is then published at: registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master from where it can be used in all other project repositories. This avoids having to copy the check-dco.py script into every repo when we wan

Re: [libvirt-jenkins-ci PATCH] dco: build and publish a container image for DCO check

On Thu, 2020-04-09 at 17:44 +0100, Daniel P. Berrangé wrote: > On Wed, Apr 08, 2020 at 04:54:17PM +0200, Andrea Bolognani wrote: > > On Wed, 2020-04-08 at 15:26 +0100, Daniel P. Berrangé wrote: > > > On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote: > > > > On Wed, 2020-04-08 at 12:

Re: [PATCH v2] apparmor: avoid denials on libpmem initialization

On Thu, 09 Apr 2020, Christian Ehrhardt wrote: > With libpmem support compiled into qemu it will trigger the following > denials on every startup. > apparmor="DENIED" operation="open" name="/" > apparmor="DENIED" operation="open" name="/sys/bus/nd/devices/" > > This is due to [1] that tries t

Re: [libvirt-jenkins-ci PATCH] dco: build and publish a container image for DCO check

On Wed, Apr 08, 2020 at 04:54:17PM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-08 at 15:26 +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote: > > > On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote: > > > > +- docker push ${CI_R

Re: [libvirt PATCH] gitdm: Add missing entries

On Wed, Apr 01, 2020 at 12:15:37PM +0200, Andrea Bolognani wrote: > One new company has contributed to libvirt since the last time > the gitdm configuration was updated. > > Signed-off-by: Andrea Bolognani > --- > docs/gitdm/companies/others | 1 + > 1 file changed, 1 insertion(+) Reviewed-by:

Re: [libvirt PATCH] gitdm: Add missing entries

On Wed, 2020-04-01 at 12:15 +0200, Andrea Bolognani wrote: > One new company has contributed to libvirt since the last time > the gitdm configuration was updated. > > Signed-off-by: Andrea Bolognani > --- > docs/gitdm/companies/others | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc

Re: [libvirt PATCH 1/6] docs: point users to gitlab for issue tracking

On Thu, Apr 09, 2020 at 04:33:04PM +0200, Ján Tomko wrote: > On a Thursday in 2020, Daniel P. Berrangé wrote: > > Currently we use the "Virtualization Tools" product in Red Hat Bugzilla > > for issue tracking upstream. This changes to point people to GitLab for > > issue tracking. > > > > Note tha

Re: [libvirt PATCH 6/6] docs: replace site name with link type in download table

On Thu, Apr 09, 2020 at 04:48:19PM +0200, Ján Tomko wrote: > On a Thursday in 2020, Daniel P. Berrangé wrote: > > Instead of repeating the sitename "gitlab" over and over for the git and > > bug tracker links, use the words "git" and "bugs" to distinguish them. > > This makes it easier to distingui

Re: [libvirt PATCH v2] docs: list settings required in creating a new git repo

On Thu, 2020-04-09 at 15:40 +0100, Daniel P. Berrangé wrote: > +GitHub configuration > + > + > +The `GitHub organization `_ hosts read-only > +mirrors of all the libvirt Git repositories. > + > +When creating a new repository the following changes to

Re: [libvirt PATCH 6/6] docs: replace site name with link type in download table

On a Thursday in 2020, Daniel P. Berrangé wrote: Instead of repeating the sitename "gitlab" over and over for the git and bug tracker links, use the words "git" and "bugs" to distinguish them. This makes it easier to distinguish links when the table header has scrolled off the screen. Signed-off

Re: [libvirt PATCH 5/6] docs: add link to bug tracker against each download

On a Thursday in 2020, Daniel P. Berrangé wrote: Help people to see where to report bugs when they download a libvirt release. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 79 ++ 1 file changed, 79 insertions(+) Reviewed-by: Ján Tomko

[libvirt PATCH v2] docs: list settings required in creating a new git repo

The libvirt project has alot of git repositories, and they must all be configured in the same way, more or less. This page documents the settings changes that I have made in GitLab and GitHub when configuring projects, both as a reminder for myself, and to help anyone else doing the same in future.

Re: [libvirt PATCH 4/6] docs: update for rename of libvirt-jenkins.ci repository

On a Thursday in 2020, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 3/6] docs: style git mirror links less prominently

On a Thursday in 2020, Daniel P. Berrangé wrote: To discourage people from using the git mirror links, style them in a smaller italic font, with plain colour. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 52 +- docs/libvirt.css | 9

Re: [libvirt PATCH 2/6] docs: point to gitlab as primary git repo host

On a Thursday in 2020, Daniel P. Berrangé wrote: Change the download page so that gitlab is referred to as the primary git host and libvirt.org is related to mirror status. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 104 - 1 file change

Re: [libvirt PATCH 1/6] docs: point users to gitlab for issue tracking

On a Thursday in 2020, Daniel P. Berrangé wrote: Currently we use the "Virtualization Tools" product in Red Hat Bugzilla for issue tracking upstream. This changes to point people to GitLab for issue tracking. Note that Bugzilla still has plenty of bugs present against libvirt. Triaging these to

[libvirt PATCH 6/6] docs: replace site name with link type in download table

Instead of repeating the sitename "gitlab" over and over for the git and bug tracker links, use the words "git" and "bugs" to distinguish them. This makes it easier to distinguish links when the table header has scrolled off the screen. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.i

[libvirt PATCH 0/6] docs: misc updates for gitlab changes

Daniel P. Berrangé (6): docs: point users to gitlab for issue tracking docs: point to gitlab as primary git repo host docs: style git mirror links less prominently docs: update for rename of libvirt-jenkins.ci repository docs: add link to bug tracker against each download docs: repla

[libvirt PATCH 4/6] docs: update for rename of libvirt-jenkins.ci repository

Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index aa3f5b73a9..cbd5283c02 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -325,14 +325,14

[libvirt PATCH 3/6] docs: style git mirror links less prominently

To discourage people from using the git mirror links, style them in a smaller italic font, with plain colour. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 52 +- docs/libvirt.css | 9 2 files changed, 35 insertions(+), 26

[libvirt PATCH 5/6] docs: add link to bug tracker against each download

Help people to see where to report bugs when they download a libvirt release. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 79 ++ 1 file changed, 79 insertions(+) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index cbd5283

[libvirt PATCH 1/6] docs: point users to gitlab for issue tracking

Currently we use the "Virtualization Tools" product in Red Hat Bugzilla for issue tracking upstream. This changes to point people to GitLab for issue tracking. Note that Bugzilla still has plenty of bugs present against libvirt. Triaging these to determine what is still valid will be a separate ex

[libvirt PATCH 2/6] docs: point to gitlab as primary git repo host

Change the download page so that gitlab is referred to as the primary git host and libvirt.org is related to mirror status. Signed-off-by: Daniel P. Berrangé --- docs/downloads.html.in | 104 - 1 file changed, 52 insertions(+), 52 deletions(-) diff --git

Re: [PATCH] virsh: cmdUndefine: Properly extract delete-storage-volume-snapshots flag

On a Thursday in 2020, Peter Krempa wrote: Commit 86608f787ee added the above flag as an alias for ambiguous 'delete-snapshots' flag, but forgot to actually change the code that there's another occurrence in VSH_REQUIRE_OPTION below extracts it, thus the new version actually doesn't work. ht

[libvirt-dockerfiles PATCH 1/5] README: Update git URLs to point to GitLab

Signed-off-by: Andrea Bolognani --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ccd7ad1..8a08ab5 100644 --- a/README.md +++ b/README.md @@ -47,6 +47,6 @@ Information about build dependencies The list of build dependencies for libvir

[libvirt-dockerfiles PATCH 0/5] Update after libvirt-ci repo rename

All pushed as trivial. Andrea Bolognani (5): README: Update git URLs to point to GitLab README: Update after libvirt-ci repo rename refresh: Update after libvirt-ci repo rename trigger: Update after libvirt-ci repo rename monitor: Update after libvirt-ci repo rename README.md | 5 ++---

[libvirt-dockerfiles PATCH 5/5] monitor: Update after libvirt-ci repo rename

Signed-off-by: Andrea Bolognani --- monitor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor b/monitor index fd27140..d7e8964 100755 --- a/monitor +++ b/monitor @@ -1,6 +1,6 @@ #!/bin/sh -QUAYADMIN="../libvirt-jenkins-ci/guests/quayadmin" +QUAYADMIN="../libvirt-ci/gu

[libvirt-dockerfiles PATCH 2/5] README: Update after libvirt-ci repo rename

Signed-off-by: Andrea Bolognani --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 8a08ab5..3508517 100644 --- a/README.md +++ b/README.md @@ -47,6 +47,5 @@ Information about build dependencies The list of build dependencies for l

[libvirt-dockerfiles PATCH 4/5] trigger: Update after libvirt-ci repo rename

Signed-off-by: Andrea Bolognani --- trigger | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trigger b/trigger index 4e71d32..6ee79fb 100755 --- a/trigger +++ b/trigger @@ -1,6 +1,6 @@ #!/bin/sh -QUAYADMIN="../libvirt-jenkins-ci/guests/quayadmin" +QUAYADMIN="../libvirt-ci/gu

[libvirt-dockerfiles PATCH 3/5] refresh: Update after libvirt-ci repo rename

Signed-off-by: Andrea Bolognani --- refresh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/refresh b/refresh index 6b644de..1d8812a 100755 --- a/refresh +++ b/refresh @@ -145,13 +145,13 @@ class Application: self.here = me.parent # If an argument has b

[PATCH] virsh: cmdUndefine: Properly extract delete-storage-volume-snapshots flag

Commit 86608f787ee added the above flag as an alias for ambiguous 'delete-snapshots' flag, but forgot to actually change the code that extracts it, thus the new version actually doesn't work. https://bugzilla.redhat.com/show_bug.cgi?id=1821988 Signed-off-by: Peter Krempa --- tools/virsh-domain.

Re: [PATCH 1/2] qemu: Add some cpu hotpluggable inforamtion in vm xml when run "virsh setvcpus vm --count --live".

On Thu, Apr 09, 2020 at 20:38:47 +0800, Jidong Xia wrote: > From: xiajidong > > The optional cpu attribute current can be used to specify whether > fewer than the maximum number of virtual CPUs should be enabled. > when run "virsh setvcpus vm --count --live", it can > display cpu hotpluggable in

Re: [PATCH] libxl: enable Xen's e820_host setting

On Wed, Apr 08, 2020 at 02:29:16PM -0600, Jim Fehlig wrote: > Hotplugging PCI devices to Xen PV guests is only possible if the > libxl_domain_build_info struct has the e820_host field enabled when the > guest is created. By default it is disabled but libxl will automatically > enable e820_host if t

Re: [PATCH 3/3] xenconfig: Add support for max_event_channels

On Wed, Apr 08, 2020 at 02:08:55PM -0600, Jim Fehlig wrote: > Add support in the domXML<->native config converter for max_event_channels. > The parser and formater functions for max_grant_frames were reworked to > also parse max_event_channels. In doing so the xenbus controller is added > earlier i

[jenkins-ci PATCH 3/3] github: Update repo-lockdown config after repo rename

Signed-off-by: Andrea Bolognani --- .github/lockdown.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/lockdown.yml b/.github/lockdown.yml index 1183cb8..5410b9f 100644 --- a/.github/lockdown.yml +++ b/.github/lockdown.yml @@ -15,7 +15,7 @@ issues: We ki

[jenkins-ci PATCH 2/3] git-publish: Update config after repo rename

Signed-off-by: Andrea Bolognani --- .gitpublish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index 331b33b..6cbfb62 100644 --- a/.gitpublish +++ b/.gitpublish @@ -1,4 +1,4 @@ [gitpublishprofile "default"] base = master to = libvir-list@redhat.co

[jenkins-ci PATCH 0/3] Update various files after repo rename

All pushed as trivial. Andrea Bolognani (3): guests: Update README after repo rename git-publish: Update config after repo rename github: Update repo-lockdown config after repo rename .github/lockdown.yml | 6 +++--- .gitpublish| 2 +- guests/README.markdown | 2 +- 3 files c

[jenkins-ci PATCH 1/3] guests: Update README after repo rename

Signed-off-by: Andrea Bolognani --- guests/README.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/README.markdown b/guests/README.markdown index f225da7..ed9be06 100644 --- a/guests/README.markdown +++ b/guests/README.markdown @@ -80,7 +80,7 @@ you'll want to u

Re: [PATCH 2/3] libxl: Add support for max_event_channels

On Wed, Apr 08, 2020 at 02:08:54PM -0600, Jim Fehlig wrote: > Add support for setting event_channels in libxl domain config object and > include a test to check that it is properly converted from XML to libxl > domain config. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_conf.c

Re: [PATCH 1/3] conf: Add a new xenbus controller option for event channels

On Wed, Apr 08, 2020 at 02:08:53PM -0600, Jim Fehlig wrote: > Event channels are like PV interrupts and in conjuction with grant frames > form a data transfer mechanism for PV drivers. They are also used for > inter-processor interrupts. Guests with a large number of vcpus and/or > many PV devices

Re: [RFC] Faster libvirtd restart with nwfilter rules, one more time

On Thu, Apr 09, 2020 at 11:53:46AM +0100, Daniel P. Berrangé wrote: > Copying Eric Garver as a knowledgeable maintainer of firewalld to > confirm a question I have > > On Fri, Mar 20, 2020 at 12:25:49PM +0300, nshirokovskiy wrote: > > Hi, all. > > > > Some time ago I posted RFC [1] concerning

[PATCH 2/2] qemu: Add some cpu hotpluggable inforamtion in vm xml when run "virsh setvcpus vm --count --config".

when run "virsh setvcpus vm --count --config", and destroy vm, then start vm, it can display cpu hotpluggable information when run "virsh dumpxml vm | grep vcpu". so we can know the value of enabled and hotpluggable attributes of the current vcpus. Signed-off-by: Jidong Xia --- src/qemu/qemu_ho

[PATCH 1/2] qemu: Add some cpu hotpluggable inforamtion in vm xml when run "virsh setvcpus vm --count --live".

From: xiajidong The optional cpu attribute current can be used to specify whether fewer than the maximum number of virtual CPUs should be enabled. when run "virsh setvcpus vm --count --live", it can display cpu hotpluggable information when run "virsh dumpxml vm | grep vcpu". so we can know the

[PATCH 0/2] qemu: Add some cpu hotpluggable infomation when run "virsh setvcpus command"

The optional cpu attribute current can be used to specify whether fewer than the maximum number of virtual CPUs should be enabled. With this patch, when run "virsh setvcpus vm --count " with --live or --config, we can see some cpu information in vm xml. Jidong Xia (1): qemu: Add some cpu hotplu

[PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Introduce getHost support for ARM CPU driver, read CPU vendor_id, part_id and flags from registers directly. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 193 +- 1 file changed, 192 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c b/

[PATCH V2 4/5] cpu: Add helper funtions to parse vendor and model

Add helper functions to parse vendor and model from xml for ARM arch, and use them as callbacks when load cpu maps. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 170 +- 1 file changed, 168 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_

[PATCH V2 3/5] cpu: Introduce ARM related structs

Introduce vendor and model struct and related cleanup functions for ARM cpu. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index ee5802198f..d8f571cae3 1

[RFC] Adding docker driver to libvirt

Hi, all. Does it make sense to add such a driver? I can't say I have a big picture of docker functionality in mind but at least container lifecycle management and container networking are common to both. Nikolay

Re: [PATCH V2 3/5] cpu: Introduce ARM related structs

Introduce vendor and model struct and related cleanup functions for ARM cpu. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index ee5802198f..d8f571cae3 1

[PATCH V2 3/5] cpu: Introduce ARM related structs

Introduce vendor and model struct and related cleanup functions for ARM cpu. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index ee5802198f..d8f571cae3 1

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Thanks for the info, as for ARM testing, we are happy to provide some machines if the community likes. BR, On Thu, Apr 9, 2020 at 8:03 PM Daniel P. Berrangé wrote: > On Thu, Apr 09, 2020 at 07:52:27PM +0800, Zhenyu Zheng wrote: > > Hi, > > > > Thanks alot for all the reviews, I'm updating the c

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Thu, Apr 09, 2020 at 07:52:27PM +0800, Zhenyu Zheng wrote: > Hi, > > Thanks alot for all the reviews, I'm updating the codes, as for those > headers, > hwcap.h is here: > https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h and > should be available for 5.6, > auxv.h is from

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Hi, Thanks alot for all the reviews, I'm updating the codes, as for those headers, hwcap.h is here: https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h and should be available for 5.6, auxv.h is from glibc: https://sourceware.org/git/?p=glibc.git;a=blob;f=misc/sys/auxv.h;h=1a5

Re: [libvirt PATCH] docs: list settings required in creating a new git repo

On Wed, 2020-04-08 at 17:41 +0100, Daniel P. Berrangé wrote: > +GitLab Configuration > + > + > +The `GitLab organization `_ hosts the master copy > +of all the libvirt Git repositories. > + > +When creating a new repository the following changes to th

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > Introduce getHost support for ARM CPU driver, read > CPU vendor_id, part_id and flags from registers > directly. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 194 +- > 1 file

ALERT: libvirt-jenkins-ci.git renamed to libvirt-ci.git

As the subject says, we have renamed the repository libvirt-jenkins-ci.git to be libvirt-ci.git, since it does more than just Jenkins and we are aiming to eliminate Jenkins If you have a checkout then you need to update the URL using: git remote set-url origin https://gitlab.com/libvirt/libvir

[PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

The ZPCI address validation or autogeneration does not work as expected in the following scenarios 1. uid = 0 and fid = 0 2. uid = 0 and fid > 0 3. uid = 0 and fid not specified 4. uid not specified and fid > 0 5. 2 ZPCI devices with uid > 0 and fid not specified. This is because of the following

[PATCH libvirt v1 2/6] tests: qemu: add tests for ZPCI on s390

Add test to verify ZPCI address validation with uid set to 0x0 Signed-off-by: Bjoern Walk Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- .../hostdev-vfio-zpci-uid-set-zero.xml| 20 +++ tests/qemuxml2argvtest.c

Re: [RFC] Faster libvirtd restart with nwfilter rules, one more time

Copying Eric Garver as a knowledgeable maintainer of firewalld to confirm a question I have On Fri, Mar 20, 2020 at 12:25:49PM +0300, nshirokovskiy wrote: > Hi, all. > > Some time ago I posted RFC [1] concerning an issue of unresponsive > libvird during restart if there is large number of VMs

[PATCH libvirt v1 6/6] tests: add test with PCI and CCW device

Add test with a ZPCI host device and a CCW memballoon device to ensure that CCW address remains the default address assigned. Signed-off-by: Boris Fiuczynski Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- .../hostdev-vfio-zpci-ccw-memball

[PATCH libvirt v1 4/6] qemu: move ZPCI uid validation into device validation

The ZPCI device validation is specific to qemu. So, let us move the ZPCI uid validation out of domain xml parsing into qemu domain device validation. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/conf/device_conf.c | 3 --- src/lib

[PATCH libvirt v1 1/6] conf: fix ZPCI address validation on s390

Currently, there are two issues with handling the ZPCI address extension. Firstly, when the uid is to be auto-generated with a specified fid, .i.e.: ... ... we expect uid='0x0001' (or the next available uid for the domain). However, we get a parsing error: $ virsh

[PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

Currently, if uid/fid is specified as zero by the user, it is treated as if the value is not specified. This bug is fixed by introducing two boolean values to identify if uid and fid are specified by the user. Also, if either uid or fid is specified by the user, it is incorrectly assumed that both

[PATCH libvirt v1 5/6] tests: qemu: add more tests for ZPCI on S390

1. Test for auto-generating uids while specifying valid fids 2. Test for auto-generating fids while specifying valid uids 3. Test for parse error while specifying a valid fid and an invalid uid 4. Test for parse error while specifying two ZPCI devices with same uid and fid addresses 5. Test f

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Thu, Apr 09, 2020 at 11:28:04 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 02, 2020 at 05:03:59PM +0800, Zhenyu Zheng wrote: > > Introduce getHost support for ARM CPU driver, read > > CPU vendor_id, part_id and flags from registers > > directly. > > > > Signed-off-by: Zhenyu Zheng > > --- >

Re: [libvirt-jenkins-ci PATCH v3 5/5] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > +++ b/guests/lcitool > @@ -477,6 +517,8 @@ class Application: > "selected_projects": selected_projects, > "git_remote": git_remote, > "git_branch": git_branch, > +"gitlab_url_file": gitlab_u

Re: [libvirt-jenkins-ci PATCH v3 4/5] guests: Introduce the new 'gitlab' flavor

On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > +++ b/guests/playbooks/update/tasks/gitlab.yml > +- name: Make {{ gitlab_runner_config_dir }} world readable > + file: > +path: '{{ gitlab_runner_config_dir }}' > +mode: '0755' > + > +- name: Make {{ gitlab_runner_config_dir }}/conf

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Thu, Apr 02, 2020 at 05:03:59PM +0800, Zhenyu Zheng wrote: > Introduce getHost support for ARM CPU driver, read > CPU vendor_id, part_id and flags from registers > directly. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 194 +- > 1 fil

Re: [PATCH V2 4/5] cpu: Add helper funtions to parse vendor and model

On Thu, Apr 02, 2020 at 05:03:57PM +0800, Zhenyu Zheng wrote: > Add helper functions to parse vendor and model from > xml for ARM arch, and use them as callbacks when > load cpu maps. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 176 +- >

Re: [libvirt-jenkins-ci PATCH v3 3/5] guests: templates: Introduce a gitlab-runner RC init service template

On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > Based on > https://docs.gitlab.com/runner/install/freebsd.html#installing-gitlab-runner > > Signed-off-by: Erik Skultety > --- > .../update/templates/gitlab-runner.j2 | 31 +++ > 1 file changed, 31 insertions(+) >

Re: [libvirt-jenkins-ci PATCH v3 2/5] guests: templates: Introduce a gitlab-runner systemd service template

On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote: > +++ b/guests/playbooks/update/templates/gitlab-runner.service.j2 > +[Install] > +WantedBy=multi-user.target > + This blank line is unnecessary and 'git am' complains about it: .git/rebase-apply/patch:25: new blank line at EOF. + Once

Re: [PATCH V2 3/5] cpu: Introduce ARM related structs

On Thu, Apr 02, 2020 at 05:03:55PM +0800, Zhenyu Zheng wrote: > Introduce vendor and model struct and related > cleanup functions for ARM cpu. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 75 +++ > 1 file changed, 75 insertions(+) > > d

Re: [PATCH V2 2/5] cpu: Introduce virCPUarmData to virCPUData

On Thu, Apr 02, 2020 at 05:03:53PM +0800, Zhenyu Zheng wrote: > Introduce virCPUarmData to virCPUData > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/Makefile.inc.am | 1 + > src/cpu/cpu.h | 2 ++ > src/cpu/cpu_arm_data.h | 31 +++ > 3 files changed, 34 i

Re: [PATCH V2 1/5] cpu_map: Introduce ARM cpu models

On Thu, Apr 02, 2020 at 05:03:51PM +0800, Zhenyu Zheng wrote: > Introduce vendors and some commonly used models > for ARM arch, these will be used for virConnectionGetCapabilities > for ARM CPUs. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu_map/Makefile.inc.am | 7 +++ > src/cpu_ma

Re: Wiki page audit - possible page deleteion

On Wed, Apr 08, 2020 at 04:45:46PM +0100, Daniel P. Berrangé wrote: > Various GSoC pages, the per-year pages, and for 2016 only > some reports from the contributors. Most of the latter is > outdated info that's no longer really relevant, so I'd > probablyjust delete the last 4 pages, and move the

Re: [PATCH 17/36] datatypes: convert virNWFilter to GObject

On Wed, Apr 08, 2020 at 04:12:04PM -0500, Jonathon Jongsma wrote: > On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote: > > @@ -503,14 +503,13 @@ virNWFilterGetXMLDesc(virNWFilterPtr nwfilter, > > unsigned int flags) > > int > > virNWFilterRef(virNWFilterPtr nwfilter) > > { > > -VIR_DEB

Re: [PATCH 00/36] convert virObjects to GObject

On Wed, Apr 08, 2020 at 07:38:33PM -0500, Jonathon Jongsma wrote: > On Fri, 2020-04-03 at 17:03 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 03, 2020 at 05:15:28PM +0200, Rafael Fonseca wrote: > > > This patch series convert various simple instances of virObject to > > > a > > > GObject equival

Re: [libvirt PATCH] docs: add 'edit this page' link to footer of every page

On a Wednesday in 2020, Daniel P. Berrangé wrote: On Wed, Apr 08, 2020 at 06:08:59PM +0200, Ján Tomko wrote: On a Wednesday in 2020, Daniel P. Berrangé wrote: > This gives a way to contribute > content that is arguably easier than our wiki which requires manual > account creation, while this wil