Re: [PATCH 03/43] conf: nwfilter_ipaddrmap: convert virMutex to GMutex

On 4/10/20 1:01 PM, Laine Stump wrote: On 4/10/20 9:54 AM, Rafael Fonseca wrote: Signed-off-by: Rafael Fonseca ---   src/conf/nwfilter_ipaddrmap.c | 14 +++---   1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c

Re: [PATCH 03/43] conf: nwfilter_ipaddrmap: convert virMutex to GMutex

On 4/10/20 9:54 AM, Rafael Fonseca wrote: Signed-off-by: Rafael Fonseca --- src/conf/nwfilter_ipaddrmap.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index 672a58be3a..3c1927f9ff 100644 ---

[PATCH 43/43] util: virthread: remove GMutex and Gcond

All instances where they were used have now been converted to the Glib equivalents. Signed-off-by: Rafael Fonseca --- examples/systemtap/lock-debug.stp | 4 +- src/libvirt_private.syms | 11 src/util/virthread.c | 101 --

[PATCH 40/43] util: virObjectRWLockable: convert virRWLock to GRWLock

Signed-off-by: Rafael Fonseca --- src/conf/virdomainobjlist.c | 35 ++- src/conf/virinterfaceobj.c | 18 +- src/conf/virnetworkobj.c | 20 +-- src/conf/virnodedeviceobj.c | 16 - src/conf/virnwfilterbindingobjlist.c

[PATCH 31/43] remote: convert virMutex to GMutex in daemonClientPrivate

Signed-off-by: Rafael Fonseca --- src/remote/remote_daemon.h | 2 +- src/remote/remote_daemon_dispatch.c | 100 +++- src/remote/remote_daemon_stream.c | 29 3 files changed, 37 insertions(+), 94 deletions(-) diff --git a/src/remote/remote_daemon.h

[PATCH 36/43] util: virnetlink: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virnetlink.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 3117dcbe65..e9f2c273d9 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -62,7 +62,7 @@

[PATCH 38/43] nwfilter: nwfilter_learnipaddr: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/nwfilter/nwfilter_learnipaddr.c | 43 + 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index 4ce8d5ba03..c46fbca40d 100644 ---

[PATCH 35/43] util: virnetdevveth: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virnetdevveth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdevveth.c b/src/util/virnetdevveth.c index b3eee1afce..d1fc4c372d 100644 --- a/src/util/virnetdevveth.c +++ b/src/util/virnetdevveth.c @@ -34,7

[PATCH 37/43] tools: virsh: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- tools/virsh.c | 11 --- tools/virt-admin.c | 11 --- tools/vsh.c| 4 ++-- tools/vsh.h| 2 +- 4 files changed, 11 insertions(+), 17 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 197a90636d..f2da8ad340 100644

[PATCH 22/43] vmware: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/vmware/vmware_conf.c | 2 +- src/vmware/vmware_conf.h | 2 +- src/vmware/vmware_driver.c | 7 +++ 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index fd62bb96f7..dbe67fcd97 100644

[PATCH 39/43] util: virthreadpool: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virthreadpool.c | 149 +-- 1 file changed, 50 insertions(+), 99 deletions(-) diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index 379d2369ad..147943f395 100644 --- a/src/util/virthreadpool.c +++

[PATCH 41/43] util: virthread: remove virRWLock

All instances where virRWLock where used were replaced by GRWLock. Signed-off-by: Rafael Fonseca --- src/libvirt_private.syms | 5 - src/util/virthread.c | 33 - src/util/virthread.h | 16 3 files changed, 54 deletions(-) diff --git

[PATCH 42/43] util: virObjectLockable: convert virMutex to GMutex

Because virCond usage is connected to virMutex, this patch also converts virCond to GCond. An important note to make here: GMutex doesn't like when you try to clear a lock that's still locked. So I had to hunt the few cases where that happened and add an explicit virObjectUnlock call before

[PATCH 32/43] util: virfirewall: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virfirewall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 22760e6389..3bf85020af 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -83,7 +83,7 @@

[PATCH 29/43] storage: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/virstorageobj.h | 2 +- src/storage/storage_driver.c | 11 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/conf/virstorageobj.h b/src/conf/virstorageobj.h index 54100ac22a..0f1f7c3d8d 100644 ---

[PATCH 20/43] network: bridge_driver: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/network/bridge_driver.c | 11 --- src/network/bridge_driver_platform.h | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f06099297a..2eaab9c667 100644 ---

[PATCH 17/43] nwfilter: nwfilter_gentech_driver: convert virMutex to GRecMutex

Signed-off-by: Rafael Fonseca --- src/nwfilter/nwfilter_gentech_driver.c | 38 -- 1 file changed, 12 insertions(+), 26 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 4b369e5b1a..fd98d7f07e 100644 ---

[PATCH 19/43] lxc: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/lxc/lxc_conf.h | 6 +++--- src/lxc/lxc_controller.c | 25 ++--- src/lxc/lxc_driver.c | 7 ++- tests/testutilslxc.c | 9 ++--- 4 files changed, 17 insertions(+), 30 deletions(-) diff --git a/src/lxc/lxc_conf.h

[PATCH 33/43] util: virlockspace: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virlockspace.c | 83 +++-- 1 file changed, 22 insertions(+), 61 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index 9a54192cd1..c29d6f37fe 100644 --- a/src/util/virlockspace.c +++

[PATCH 34/43] util: virnetdevmacvlan: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virnetdevmacvlan.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index dcea93a5fe..bcdb2322b5 100644 --- a/src/util/virnetdevmacvlan.c +++

[PATCH 25/43] qemu: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/qemu/qemu_conf.c | 4 ++-- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_driver.c | 9 ++--- tests/testutilsqemu.c | 5 ++--- 4 files changed, 7 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[PATCH 24/43] tests: qemumonitortestutils: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- tests/qemumonitortestutils.c | 37 +--- 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 992d2a4e71..78fc94e710 100644 ---

[PATCH 27/43] nwfilter: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterobj.h | 2 +- src/nwfilter/nwfilter_driver.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/conf/virnwfilterobj.h b/src/conf/virnwfilterobj.h index a6bdfb3864..f862f78650 100644 ---

[PATCH 26/43] remote: remote_driver: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/remote/remote_driver.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 7bae0c2514..6cd38e86ef 100644 --- a/src/remote/remote_driver.c +++

[PATCH 15/43] test: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/test/test_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7759847c2d..1c23d569d5 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -125,7 +125,7

[PATCH 10/43] vz: vz_driver: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/vz/vz_driver.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index d882b91def..058e5b8614 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -67,7 +67,7 @@

[PATCH 03/43] conf: nwfilter_ipaddrmap: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/nwfilter_ipaddrmap.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index 672a58be3a..3c1927f9ff 100644 --- a/src/conf/nwfilter_ipaddrmap.c +++

[PATCH 16/43] nwfilter: nwfilter_dhcpsnoop: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterobj.c | 15 -- src/nwfilter/nwfilter_dhcpsnoop.c | 48 +-- 2 files changed, 25 insertions(+), 38 deletions(-) diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c index

[PATCH 18/43] lxc: lxc_fuse: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/lxc/lxc_fuse.c | 13 + src/lxc/lxc_fuse.h | 2 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c index e73b4d0690..e35086c859 100644 --- a/src/lxc/lxc_fuse.c +++ b/src/lxc/lxc_fuse.c @@

[PATCH 04/43] conf: virchrdev: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/virchrdev.c | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c index 800e82869e..8280f8e188 100644 --- a/src/conf/virchrdev.c +++ b/src/conf/virchrdev.c @@ -44,7

[PATCH 23/43] tests: qemusecuritymock: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- tests/qemusecuritymock.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c index ad182c7bf7..0aef565bf9 100644 --- a/tests/qemusecuritymock.c +++

[PATCH 28/43] openvz: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/openvz/openvz_conf.h | 2 +- src/openvz/openvz_driver.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/openvz/openvz_conf.h b/src/openvz/openvz_conf.h index 9892f39481..1680227e95 100644 --- a/src/openvz/openvz_conf.h +++

[PATCH 30/43] secret: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/secret/secret_driver.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 1cb342878f..51a8a6e53e 100644 --- a/src/secret/secret_driver.c +++

[PATCH 05/43] esx: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/esx/esx_stream.c | 25 +++- src/esx/esx_vi.c | 68 +++- src/esx/esx_vi.h | 6 ++-- 3 files changed, 36 insertions(+), 63 deletions(-) diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index

[PATCH 13/43] conf: nwfilter_conf: convert virRWLock to GRWLock

Signed-off-by: Rafael Fonseca --- src/conf/nwfilter_conf.c | 21 +++-- src/conf/nwfilter_conf.h | 5 - src/libvirt_private.syms | 3 ++- src/lxc/lxc_driver.c | 4 ++-- src/nwfilter/nwfilter_driver.c | 6

[PATCH 21/43] node_device: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/conf/virnodedeviceobj.h | 4 ++-- src/node_device/node_device_driver.c | 11 +++ src/node_device/node_device_hal.c| 20 +--- src/node_device/node_device_udev.c | 21 + 4 files changed, 15

[PATCH 12/43] logging: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/logging/log_daemon.c | 26 ++ src/logging/log_daemon.h | 2 +- 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index f37054706e..f4b94adf17 100644 ---

[PATCH 08/43] util: virnodesuspend: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virnodesuspend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index 544a29783c..f336b3aa98 100644 --- a/src/util/virnodesuspend.c +++ b/src/util/virnodesuspend.c @@

[PATCH 02/43] bhyve: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_driver.c | 11 --- src/bhyve/bhyve_utils.h | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index b6204c7fb9..6e9a79cb52 100644 --- a/src/bhyve/bhyve_driver.c +++

[PATCH 07/43] vbox: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/vbox/vbox_common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index e98ae04ec0..98d6978c51 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -58,7 +58,7

[PATCH 01/43] admin: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/admin/admin_server_dispatch.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/admin/admin_server_dispatch.c b/src/admin/admin_server_dispatch.c index b3da577995..2515528779 100644 --- a/src/admin/admin_server_dispatch.c

[PATCH 06/43] util: virtpm: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virtpm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/util/virtpm.c b/src/util/virtpm.c index c734bf941a..5fd6396f2f 100644 --- a/src/util/virtpm.c +++ b/src/util/virtpm.c @@ -91,7 +91,7 @@

[PATCH 09/43] libxl: convert virMutex to GMutex in libxlPrivate

Signed-off-by: Rafael Fonseca --- src/libxl/libxl_conf.h | 6 +++--- src/libxl/libxl_driver.c | 9 ++--- tests/testutilsxen.c | 9 ++--- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 07b3373170..b29752ad0c

[PATCH 00/43] Replace virMutex & co. by the Glib equivalent

This patch series replaces virMutex and virRWLock by GMutex and GRWLock, respectively. And because virCond usage is connected to virCond, it also replaces the latter by GCond. Rafael Fonseca (43): admin: convert virMutex to GMutex bhyve: convert virMutex to GMutex conf: nwfilter_ipaddrmap:

[PATCH 11/43] locking: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/locking/lock_daemon.c | 32 +- src/locking/lock_daemon.h | 2 +- src/locking/lock_daemon_dispatch.c | 32 -- 3 files changed, 18 insertions(+), 48 deletions(-) diff --git

[PATCH 14/43] util: virlog: convert virMutex to GMutex

Signed-off-by: Rafael Fonseca --- src/util/virlog.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index e4944d1258..2c98a4cca8 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -125,19 +125,19 @@ static void

Re: [PATCH libvirt v1 0/6] Fix ZPCI address auto-generation on s390

On Thu, 2020-04-09 at 12:30 +0200, Shalini Chellathurai Saroja wrote: > The ZPCI address validation or autogeneration does not work as > expected in the following scenarios > 1. uid = 0 and fid = 0 > 2. uid = 0 and fid > 0 > 3. uid = 0 and fid not specified > 4. uid not specified and fid > 0 > 5.

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

On Thu, 2020-04-09 at 13:03 +0200, Jiri Denemark wrote: > On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > > +static int > > +armCpuDataFromRegs(virCPUarmData *data) > > +{ > > +/* Generate human readable flag list according to the order of */ > > +/* AT_HWCAP bit map */ > > +

Re: [PATCH] formatdomain.html.in: document emulator/vcpu pin delay

On Thu, 2020-04-09 at 16:45 -0300, Daniel Henrique Barboza wrote: > In a guest with only one vcpu, when pinning the emulator in say CPU184 > and the vcpu0 in CPU0 of the host, the user might expect that only > CPU0 and CPU184 of the host will be used by the guest. > > The reality is that Libvirt

[libvirt PATCH 0/3] travis: Drop xcode10.3 build, clean up

Andrea Bolognani (3): travis: Deduplicate build instructions travis: Reduce test matrix travis: Remove usage of 'sudo' .travis.yml | 52 ++-- 1 file changed, 18 insertions(+), 34 deletions(-) -- 2.25.2

[libvirt PATCH 3/3] travis: Remove usage of 'sudo'

Travis CI reports root: deprecated key sudo (The key `sudo` has no effect anymore.) so let's drop it. Signed-off-by: Andrea Bolognani --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d0ac947d15..5958d69abb 100644 --- a/.travis.yml +++

[libvirt PATCH 2/3] travis: Reduce test matrix

The xcode10.3 build has recently started failing because of issues that are not in libvirt, so get rid of it. It didn't buy us additionaly platform coverage anyway, since underneath it's using the same macOS 10.14 version as xcode11.3. Signed-off-by: Andrea Bolognani --- .travis.yml | 6 +-

[libvirt PATCH 1/3] travis: Deduplicate build instructions

All information, except for osx_image image, is identical between the two jobs so we can avoid repeating it. Signed-off-by: Andrea Bolognani --- .travis.yml | 51 --- 1 file changed, 20 insertions(+), 31 deletions(-) diff --git a/.travis.yml

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Hi Daniel, Jirka Thanks alot for the review and info, I have updated the code to only compile on aarch64 platform, and I've done the gitlab CI testing as suggested: https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317 and manually tested on aarch64. BR, On Fri, Apr 10, 2020 at 4:21 PM

[PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

Introduce getHost support for ARM CPU driver, read CPU vendor_id, part_id and flags from registers directly. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 202 +- 1 file changed, 201 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c

Re: [PATCH V2 4/5] cpu: Add helper funtions to parse vendor and model

> > > Add helper functions to parse vendor and model from > xml for ARM arch, and use them as callbacks when > load cpu maps. > > Signed-off-by: Zhenyu Zheng > > --- > src/cpu/cpu_arm.c | 171 +- > 1 file changed, 170 insertions(+), 1 deletion(-) > >

[no subject]

Subject:[PATCH V2 4/5] cpu: Add helper funtions to parse vendor and model Add helper functions to parse vendor and model from xml for ARM arch, and use them as callbacks when load cpu maps. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 171 +-

[no subject]

Add helper functions to parse vendor and model from xml for ARM arch, and use them as callbacks when load cpu maps. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 171 +- 1 file changed, 170 insertions(+), 1 deletion(-) diff --git

[no subject]

From: ZhengZhenyu Add helper functions to parse vendor and model from xml for ARM arch, and use them as callbacks when load cpu maps. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 171 +- 1 file changed, 170 insertions(+), 1 deletion(-) diff