Re: [PATCH v2 0/5] qemu: Support rbd namespace attribute

2020-04-28 Thread Han Han
ping On Tue, Apr 21, 2020 at 8:11 PM Han Han wrote: > Change from v1: > - Add rbd namespace member to aarch64 capability replies. Add rbd > namespace capability test for aarch64. > - Provide more details in news xml > > v1: https://www.redhat.com/archives/libvir-list/2020-April/msg00388.html

Live migration garp

2020-04-28 Thread Ignazio Cassano
Hello All, I am facing issues under openstack rocky with last libvirt available on centos 7. There is an open discussione here: https://bugs.launchpad.net/neutron/+bug/1866139 About sending garp when an instance live migrate. What must send garp ? The problem is this: when live migrate a vm

[PATCH] docs: Describe protected virtualization guest setup

2020-04-28 Thread Boris Fiuczynski
From: Viktor Mihajlovski Protected virtualization/IBM Secure Execution for Linux protects guest memory and state from the host. Add some basic information about technology and a brief guide on setting up secure guests with libvirt. Signed-off-by: Viktor Mihajlovski Reviewed-by: Boris

Re: Races / crashes in shutdown of libvirtd daemon

2020-04-28 Thread Nikolay Shirokovskiy
On 27.04.2020 18:54, Daniel P. Berrangé wrote: > We got a new BZ filed about a libvirtd crash in shutdown > > https://bugzilla.redhat.com/show_bug.cgi?id=1828207 > > We can see from the stack trace that the "interface" driver is in > the middle of servicing an RPC call for

Re: [PATCH 1/3] Improve blockpull man entry

2020-04-28 Thread Eric Blake
On 4/28/20 9:19 AM, Sebastian Mitterle wrote: So bandwidth indeed is a positional argument. Since all of the manpage uses the syntax we've had here originally fixing just this place would be wrong. The only fix that should be done here is to group the --bytes flag under bandwidth as specifying

[PATCH v2] Improve blockpull man entry

2020-04-28 Thread Sebastian Mitterle
1. Fix usage of bandwidth, base arguments. 2. Explain valid arguments for `base`. 3. Move explanation for `--keep-relative` to end considering it's not a very frequent use case. 4. Add reference to documentation for relative paths in backing chains. Signed-off-by: Sebastian Mitterle ---

Re: [PATCH 1/3] Improve blockpull man entry

2020-04-28 Thread Sebastian Mitterle
> So bandwidth indeed is a positional argument. Since all of the manpage > uses the syntax we've had here originally fixing just this place would > be wrong. The only fix that should be done here is to group the --bytes > flag under bandwidth as specifying --bytes is mandatory. I think there's

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-28 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > On Mon, Apr 27, 2020 at 11:37:43PM +0800, Dr. David Alan Gilbert wrote: > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > On Sat, Apr 25, 2020 at 03:10:49AM +0800, Dr. David Alan Gilbert wrote: > > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > >

[libvirt-ci PATCH 4/4] lcitool: Store paths information as a dictionary

2020-04-28 Thread Andrea Bolognani
Ansible and Python both support actual dictionaries, so make use of them in the inventory instead of having a bunch of randomly named variables lumped together. This commit is best viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 19

[libvirt-ci PATCH 2/4] lcitool: Store OS information a dictionary

2020-04-28 Thread Andrea Bolognani
Ansible and Python both support actual dictionaries, so make use of them in the inventory instead of emulating them by using variable names sharing the same prefix. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 6 ++-

[libvirt-ci PATCH 0/4] lcitool: Use more dictionaries in the inventory

2020-04-28 Thread Andrea Bolognani
It's the most sensible way to represent related data in YAML. Andrea Bolognani (4): lcitool: Tweak formatting lcitool: Store OS information a dictionary lcitool: Store packaging information as a dictionary lcitool: Store paths information as a dictionary

[libvirt-ci PATCH 1/4] lcitool: Tweak formatting

2020-04-28 Thread Andrea Bolognani
This will make further changes nicer. Signed-off-by: Andrea Bolognani --- guests/lcitool | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index dfb1ebc..f4565bc 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -714,7 +714,12

[libvirt-ci PATCH 3/4] lcitool: Store packaging information as a dictionary

2020-04-28 Thread Andrea Bolognani
Ansible and Python both support actual dictionaries, so make use of them in the inventory instead of emulating them by using variable names sharing the same prefix. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 5 +-

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Peter Krempa
On Tue, Apr 28, 2020 at 15:27:18 +0200, Michal Privoznik wrote: > On 4/28/20 1:19 PM, Peter Krempa wrote: > > On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: > > > On a Tuesday in 2020, Michal Privoznik wrote: > > > > On 4/27/20 10:22 PM, tobin wrote: > > > > > > > > > Yeah fine with me.

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Michal Privoznik
On 4/28/20 1:19 PM, Peter Krempa wrote: On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: On a Tuesday in 2020, Michal Privoznik wrote: On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState,

Entering freeze for libvirt 6.3.0

2020-04-28 Thread Daniel Veillard
We are getting close to the end of the month, so I tagged RC1 in git and pushed signed source tarball and rpms to the usual place: https://libvirt.org/sources/ Seems to work fine in my very limited testing, CI seems green except for a couple of mingw tests, so that looks good from a

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Peter Krempa
On Tue, Apr 28, 2020 at 13:13:32 +0200, Ján Tomko wrote: > On a Tuesday in 2020, Michal Privoznik wrote: > > On 4/27/20 10:22 PM, tobin wrote: > > > > > Yeah fine with me. Thank You. > > > > > > When it's a positive capability, you don't even need > > > virQEMUCapsProbeQMPTCGState, > > > you can

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Ján Tomko
On a Tuesday in 2020, Michal Privoznik wrote: On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState, you can just add the capability to virQEMUCapsObjectTypes. Yep. I've went with that. This is now

Re: [PATCH V3 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-28 Thread Zhenyu Zheng
Thanks alot I will check again about the patch series. On Tue, Apr 28, 2020 at 6:39 PM Jiri Denemark wrote: > On Wed, Apr 22, 2020 at 15:14:01 +0800, Zhenyu Zheng wrote: > > gitlab CI testing as suggested: > > https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317 > > Sending results of CI

Re: [PATCH V3 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-28 Thread Jiri Denemark
On Wed, Apr 22, 2020 at 15:14:01 +0800, Zhenyu Zheng wrote: > gitlab CI testing as suggested: > https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317 Sending results of CI pipeline makes sense only when the code submitted for CI is exactly the same as submitted for review. You should just

Re: [libvirt-ci PATCH 07/13] lcitool: Drop the get_flavor() method

2020-04-28 Thread Andrea Bolognani
On Tue, 2020-04-28 at 10:20 +0200, Erik Skultety wrote: > On Tue, Apr 28, 2020 at 09:34:54AM +0200, Andrea Bolognani wrote: > > There are also two uses of get_flavor() remaining after this > > patch: > > > > get_gitlab_runner_token_file() > > get_gitlab_url_file() > > Yeah, does it matter

Re: [libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-28 Thread Michal Privoznik
On 4/27/20 10:22 PM, tobin wrote: Yeah fine with me. Thank You. When it's a positive capability, you don't even need virQEMUCapsProbeQMPTCGState, you can just add the capability to virQEMUCapsObjectTypes. Yep. I've went with that. This is now pushed. Reviewed-by: Michal Privoznik

Re: [libvirt-ci PATCH 06/13] lcitool: Introduce methods to load and validate the TOML config

2020-04-28 Thread Andrea Bolognani
On Tue, 2020-04-28 at 10:19 +0200, Erik Skultety wrote: > On Mon, Apr 27, 2020 at 07:47:13PM +0200, Andrea Bolognani wrote: > > On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > > > +except Exception as ex: > > > +raise Exception( > > > +"Missing or

Re: [libvirt-ci PATCH 13/13] guests: README: Document the existence and usage of config.toml

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > +`ansible`, `python3-toml` and `virt-install` need to be available on the > host, > +the former two can be either installed system-wide using your package manager > +or using by `pip` (see the provided requirements.txt file). s/using

Re: [libvirt-ci PATCH 12/13] lcitool: Use the config install options rather than install facts

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > Now that we have the corresponding options available in the config, > let's start using them. > > Signed-off-by: Erik Skultety > --- > guests/lcitool | 30 +++--- > 1 file changed, 11 insertions(+), 19

Re: [libvirt-ci PATCH 11/13] config: Move the virt-install settings from install.yml to the config

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > +++ b/guests/lcitool > @@ -175,6 +175,33 @@ class Config: > flavor = cfg.get("install").get("flavor", "test") > cfg["install"]["flavor"] = flavor > > +virt_type = cfg.get("install").get("virt_type", "kvm") > +

Re: [libvirt-ci PATCH 10/13] lcitool: Use d.update() on extra_vars for options coming from the config

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > +# start with generic items not coming from the config > extra_vars = { > "base": base, > "playbook_base": playbook_base, > -"root_password": >

Re: [libvirt-ci PATCH 07/13] lcitool: Drop the get_flavor() method

2020-04-28 Thread Erik Skultety
On Tue, Apr 28, 2020 at 09:34:54AM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > > @@ -617,7 +591,7 @@ class Application: > > def _action_install(self, args): > > base = Util.get_base() > > > > -flavor = self._config.get_flavor()

Re: [libvirt-ci PATCH 06/13] lcitool: Introduce methods to load and validate the TOML config

2020-04-28 Thread Erik Skultety
On Mon, Apr 27, 2020 at 07:47:13PM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > > +def __init__(self): > > +path = self._get_config_file("config.toml") > > + > > +try: > > +self.dict = toml.load(path) > > I'm not too

Re: [libvirt-ci PATCH 05/13] config: Introduce a new global config.toml configuration file

2020-04-28 Thread Erik Skultety
On Tue, Apr 28, 2020 at 09:39:31AM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > > +[gitlab] > > +# GitLab runner agent registration options, applies only if flavor == > > 'gitlab'. > > + > > +# GitLab server URL to register the runner. > >

Re: [libvirt-ci PATCH 09/13] lcitool: Drop the gitlab-related getter methods

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > @@ -529,8 +489,8 @@ class Application: > "selected_projects": selected_projects, > "git_remote": git_remote, > "git_branch": git_branch, > -"gitlab_url_file":

Re: [libvirt-ci PATCH 06/13] lcitool: Introduce methods to load and validate the TOML config

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > +@staticmethod > +def _fill_default_options(cfg): > +flavor = cfg.get("install").get("flavor", "test") > +cfg["install"]["flavor"] = flavor > + > +if flavor == "gitlab": > +url =

Re: [libvirt-ci PATCH 05/13] config: Introduce a new global config.toml configuration file

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > +[gitlab] > +# GitLab runner agent registration options, applies only if flavor == > 'gitlab'. > + > +# GitLab server URL to register the runner. > +#gitlab_url = "https://gitlab.com; > + > +# GitLab runner registration token. (mandatory)

Re: [libvirt-ci PATCH 08/13] lcitool: Drop the get_root_password_file() method

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > We can now access this value directly in the config dictionary. > > Signed-off-by: Erik Skultety > --- > guests/lcitool | 19 +-- > guests/playbooks/update/tasks/users.yml | 2 +- > 2 files

Re: [libvirt-ci PATCH 07/13] lcitool: Drop the get_flavor() method

2020-04-28 Thread Andrea Bolognani
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote: > @@ -617,7 +591,7 @@ class Application: > def _action_install(self, args): > base = Util.get_base() > > -flavor = self._config.get_flavor() > +flavor = self._config.dict["install"]["flavor"] You can remove