[libvirt PATCH] qemu: Support vmpvscsi controller model

2020-05-08 Thread Chris Jester-Young
Signed-off-by: Chris Jester-Young --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 4 +++- src/qemu/qemu_validate.c | 9 -

Re: [PATCH v1 2/8] qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'

2020-05-08 Thread Stefan Berger
On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: Expose the TPM Proxy support for PPC64 guests by creating a new cap called QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-08 Thread Stefan Berger
On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: QEMU 4.1.0 introduced a new device type called TPM Proxy, currently implemented by PPC64 guests via a new virtual device called 'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info). The TPM Proxy device interacts with a TPM Resource Manager,

Re: [PATCH v1 0/8] Introducing TPM Proxy device support

2020-05-08 Thread Stefan Berger
On 5/8/20 5:39 PM, Daniel Henrique Barboza wrote: (CCing Mike Roth since he implemented the QEMU support for this device) On 5/8/20 5:18 PM, Stefan Berger wrote: On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: Hello, This series implements a new device type for Libvirt called "TPM Proxy".

Re: [PATCH v1 0/8] Introducing TPM Proxy device support

2020-05-08 Thread Daniel Henrique Barboza
(CCing Mike Roth since he implemented the QEMU support for this device) On 5/8/20 5:18 PM, Stefan Berger wrote: On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: Hello, This series implements a new device type for Libvirt called "TPM Proxy". This device acts as a proxy for TPM requisitions

Re: [PATCH v2 3/3] xenconfig: add support for 'seize' option of a PCI device

2020-05-08 Thread Jim Fehlig
On 4/24/20 9:07 PM, Marek Marczykowski-Górecki wrote: Add support for xl.cfg(5) pci device 'seize' option in domXML-to-xenconfig converter. And a test for it. It is functional equivalent of 'managed' attribute of a hostdev, so map it directly. This is fine for the converter. We'd never want to

Re: [PATCH v2 2/3] xenconfig: add support for 'permissive' option of a PCI device

2020-05-08 Thread Jim Fehlig
On 4/24/20 9:07 PM, Marek Marczykowski-Górecki wrote: Add support for xl.cfg(5) pci device 'permissive' option in domXML-to-xenconfig converter. And a test for it. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - new patch --- src/libxl/xen_common.c | 51

Re: [PATCH v2 1/3] libxl: Add 'permissive' option for PCI devices

2020-05-08 Thread Jim Fehlig
On 4/24/20 9:07 PM, Marek Marczykowski-Górecki wrote: From: Simon Gaiser By setting the permissive flag the Xen guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain

Re: [PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-08 Thread Stefan Berger
On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: QEMU 4.1.0 introduced a new device type called TPM Proxy, currently implemented by PPC64 guests via a new virtual device called 'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info). The TPM Proxy device interacts with a TPM Resource Manager,

Re: [PATCH v1 0/8] Introducing TPM Proxy device support

2020-05-08 Thread Stefan Berger
On 5/8/20 8:06 AM, Daniel Henrique Barboza wrote: Hello, This series implements a new device type for Libvirt called "TPM Proxy". This device acts as a proxy for TPM requisitions that the guest can make for an existing TPM Resource Manager in the host. The TPM Resource Manager multiplexes TPM

Re: [libvirt PATCH] xenconfig: Add feature gfx_passthru

2020-05-08 Thread Jim Fehlig
On 4/30/20 6:07 AM, Artur Puzio wrote: gfx_passthru xl.cfg option enables GPU specific quirks required for working Intel GPU passthru. Qemu (used for device model by xen) will refuse to start a VM when an IGD is passed, but this option was not set in Xen. Do we really need to expose this

Re: [PATCH v4 00/34] Configurable policy for handling deprecated interfaces

2020-05-08 Thread Markus Armbruster
Peter Krempa writes: > On Tue, Mar 17, 2020 at 12:54:25 +0100, Markus Armbruster wrote: >> This series extends QMP introspection to cover deprecation. >> Additionally, new option -compat lets you configure what to do when >> deprecated interfaces get used. This is intended for testing users of

[PATCH v1 8/8] docs/news.xml: update for the new TPM Proxy device

2020-05-08 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- docs/news.xml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4cef804aac..21ee98c45b 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,20 @@ + + + qemu:

[PATCH v1 2/8] qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'

2020-05-08 Thread Daniel Henrique Barboza
Expose the TPM Proxy support for PPC64 guests by creating a new cap called QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 +

[PATCH v1 6/8] qemu: build command line for the TPM Proxy device

2020-05-08 Thread Daniel Henrique Barboza
This patch wraps it up all the wiring done in previous patches, enabling a PPC64 guest to launch a guest using a TPM Proxy device. Note that device validation is already being done in qemu_validate.c, qemuValidateDomainDeviceDefTPMProxy(), on domain define time. We don't need to verify QEMU

[PATCH v1 4/8] domain_conf.c: XML parsing for VIR_DOMAIN_DEVICE_TPMPROXY

2020-05-08 Thread Daniel Henrique Barboza
Add virDomainTPMProxyDefParseXML() and virDomainTPMProxyDefFormat() to handle the creating of the TPM Proxy device via its XML description. Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 94 +- 1 file changed, 93 insertions(+), 1

[PATCH v1 7/8] tests/qemuxml2argvtest.c: add TPM Proxy command line test

2020-05-08 Thread Daniel Henrique Barboza
Add a new test to assert the QEMU command line being built for the TPM Proxy device. Signed-off-by: Daniel Henrique Barboza --- tests/qemuxml2argvdata/ppc64-tpmproxy.args | 28 ++ tests/qemuxml2argvtest.c | 4 2 files changed, 32 insertions(+) create

[PATCH v1 1/8] docs: documentation and schema for the new TPM Proxy device

2020-05-08 Thread Daniel Henrique Barboza
QEMU 4.1.0 introduced a new device type called TPM Proxy, currently implemented by PPC64 guests via a new virtual device called 'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info). The TPM Proxy device interacts with a TPM Resource Manager, a host device capable of multiplexing the host TPM

[PATCH v1 3/8] conf, qemu: adding VIR_DOMAIN_DEVICE_TPMPROXY device

2020-05-08 Thread Daniel Henrique Barboza
This new device will be used to represent a single instance of a TPM Proxy for the domain. XML functions to parse and format the device from the XML definition will be added in the next patch. Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_capabilities.c | 1 +

[PATCH v1 5/8] tests: add test for domain XML with TPM Proxy device model

2020-05-08 Thread Daniel Henrique Barboza
Update qemuxml2xmltest.c to add tests to validate the XML parsing of the new TPM Proxy device type. Signed-off-by: Daniel Henrique Barboza --- tests/qemuxml2argvdata/ppc64-tpmproxy.xml | 31 + tests/qemuxml2xmloutdata/ppc64-tpmproxy.xml | 37 +

[PATCH v1 0/8] Introducing TPM Proxy device support

2020-05-08 Thread Daniel Henrique Barboza
Hello, This series implements a new device type for Libvirt called "TPM Proxy". This device acts as a proxy for TPM requisitions that the guest can make for an existing TPM Resource Manager in the host. The TPM Resource Manager multiplexes TPM access to multiple processes, allowing more than one

[libvirt PATCH] Revert "tests: Use qemu:///embed to simplify fakerootdir management"

2020-05-08 Thread Andrea Bolognani
Turns out that it's not enough to pass the qemu:///embed root to virQEMUDriverConfigNew(), you also have to make sure the same string is copied into the virQEMUDriver structure yourself, and not doing so in our case resulted in the cleanup never happening and in distcheck failing because of that.

Re: [libvirt PATCH] qemu: Skip pre-creation of NVME disk

2020-05-08 Thread Han Han
On Thu, May 7, 2020 at 3:55 PM Michal Privoznik wrote: > On 5/7/20 8:37 AM, Han Han wrote: > > Unlike the file based disk, NVME disk cannot be pre-created by libvirt. > > So skip the step of pre-creation. > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1823639 > > > > Signed-off-by: Han Han

Re: [RFC] Faster libvirtd restart with nwfilter rules, one more time

2020-05-08 Thread Nikolay Shirokovskiy
On 08.05.2020 06:46, Laine Stump wrote: > On 3/20/20 5:25 AM, nshirokovskiy wrote: >> Hi, all. >>   >>     Some time ago I posted RFC [1] concerning an issue of unresponsive >> libvird during restart if there is large