Hello Peter,
On 5/12/20 8:33 AM, Peter Krempa wrote:
> Well, you certainly can contribute in having them merged. Even testing
> is a contribution.
> [..]
> Well, for us that means that we don't have anybody willing to give input
> on the feature. I don't have experience nor hardware for testing
Signed-off-by: Chris Jester-Young
---
.../disk-scsi.x86_64-latest.args | 37 +++
tests/qemuxml2argvdata/disk-scsi.xml | 6 +++
.../disk-scsi.x86_64-latest.xml | 11 +-
3 files changed, 38 insertions(+), 16 deletions(-)
diff --git
Availability of the vmpvscsi controller model is gated by the pvscsi
capability.
Signed-off-by: Chris Jester-Young
---
src/qemu/qemu_command.c | 4 +++-
src/qemu/qemu_validate.c | 9 -
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c
This capability flags support for `-device pvscsi`, which provides the
VMware paravirtual SCSI controller.
Signed-off-by: Chris Jester-Young
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
QEMU has supported pvscsi, the VMware paravirtual SCSI controller, since
2013, but libvirt does not currently expose support for it. Adding such
support is straightforward.
I have tested it with a Windows 10 guest, and the official VMware driver
supports it with no issues. However, booting only
Signed-off-by: Chris Jester-Young
---
.../{disk-scsi.xml => disk-scsi.x86_64-latest.xml} | 13 -
tests/qemuxml2xmltest.c | 3 +--
2 files changed, 9 insertions(+), 7 deletions(-)
rename tests/qemuxml2xmloutdata/{disk-scsi.xml =>
On Tue, May 12, 2020 at 04:51:20PM +0200, Peter Krempa wrote:
> On Tue, May 12, 2020 at 10:26:46 -0400, Chris Jester-Young wrote:
> > As Daniel P. Berrangé mentioned, this can be configured out via Kconfig.
> > Plus there are actually some files in tests/qemucapabilitiesdata that do
> > not
Hi Jirka,
Thanks alot for the review and suggestions, I will try to fix them. As for
v4, I saw there was a "email patch" button in gitlab, so I used that, so
seems it is not correct :)
BR
On Tue, May 12, 2020 at 11:38 PM Jiri Denemark wrote:
> On Wed, Apr 22, 2020 at 15:11:14 +0800,
On Wed, May 13, 2020 at 10:06:23AM +1000, David Gibson wrote:
> On Tue, May 12, 2020 at 01:29:43PM -0300, Daniel Henrique Barboza wrote:
> >
> >
> > On 5/11/20 8:50 AM, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 5/11/20 8:28 AM, Daniel P. Berrangé wrote:
> > > > On Mon, May 11, 2020
On Tue, May 12, 2020 at 01:29:43PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 5/11/20 8:50 AM, Daniel Henrique Barboza wrote:
> >
> >
> > On 5/11/20 8:28 AM, Daniel P. Berrangé wrote:
> > > On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
> > > >
> > > >
> > > >
On 5/12/20 10:32 AM, Erik Skultety wrote:
> On Tue, May 12, 2020 at 09:08:38AM +0200, Boris Fiuczynski wrote:
>> On 5/11/20 9:40 PM, Brijesh Singh wrote:
>>> Thanks for the patch Paulo, Few comments.
>>>
>>> On 5/11/20 11:41 AM, Boris Fiuczynski wrote:
From: Paulo de Rezende Pinatti
On 08.05.2020 18:41, Jim Fehlig wrote:
> On 4/30/20 6:07 AM, Artur Puzio wrote:
>> gfx_passthru xl.cfg option enables GPU specific quirks required for
>> working
>> Intel GPU passthru. Qemu (used for device model by xen) will refuse
>> to start
>> a VM when an IGD is passed, but this option was
On Tue, May 12, 2020 at 01:51:33PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 5/12/20 1:44 PM, Daniel P. Berrangé wrote:
> > On Tue, May 12, 2020 at 01:21:40PM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
> > > > On Tue, May 12,
On 5/12/20 1:44 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 01:21:40PM -0300, Daniel Henrique Barboza wrote:
On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
On Mon, May
On Tue, May 12, 2020 at 01:21:40PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
> > On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
> > > On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
> > > > On Mon, May 11, 2020 at 08:26:53AM -0300,
On 5/12/20 5:32 PM, Erik Skultety wrote:
I leave 1) and 2) to the AMD experts... :-)
3) Check if Qemu supports SEV feature (maybe we can detect the existence
of the query-sev QMP command or detect Qemu version >= 2.12)
^This is already achieved by qemuMonitorJSONGetSEVCapabilities
The idea
On 5/11/20 8:50 AM, Daniel Henrique Barboza wrote:
On 5/11/20 8:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote:
[...]
On 5/12/20 12:53 PM, Daniel P. Berrangé wrote:
On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May
On Tue, May 12, 2020 at 11:21:52AM -0400, Stefan Berger wrote:
> On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
> > On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
> > >
> > > On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
> > > > On Mon, May 11, 2020 at 11:22:57AM +1000,
On Wed, Apr 22, 2020 at 15:11:16 +0800, ZhengZhenyu wrote:
> Introduce vendors and some commonly used models
> for ARM arch, these will be used for virConnectionGetCapabilities
> for ARM CPUs.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu_map/Makefile.inc.am | 7 +++
>
On Wed, Apr 22, 2020 at 15:11:24 +0800, ZhengZhenyu wrote:
> Introduce getHost support for ARM CPU driver, read
> CPU vendor_id, part_id and flags from registers
> directly. These codes will only be compiled on
> aarch64 hardwares.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 204
On Wed, Apr 22, 2020 at 15:11:22 +0800, ZhengZhenyu wrote:
> Add helper functions to parse vendor and model from
> xml for ARM arch, and use them as callbacks when
> load cpu maps.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 173 +-
>
On Wed, Apr 22, 2020 at 15:11:20 +0800, ZhengZhenyu wrote:
> Introduce vendor and model struct and related
> cleanup functions for ARM cpu.
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/cpu_arm.c | 73 +++
> 1 file changed, 73 insertions(+)
>
>
On Wed, Apr 22, 2020 at 15:11:18 +0800, ZhengZhenyu wrote:
> Introduce virCPUarmData to virCPUData
>
> Signed-off-by: Zhenyu Zheng
> ---
> src/cpu/Makefile.inc.am | 1 +
> src/cpu/cpu.h | 2 ++
> src/cpu/cpu_arm_data.h | 31 +++
> 3 files changed, 34
On Wed, Apr 22, 2020 at 15:11:14 +0800, ZhengZhenyu wrote:
> Introduce getHost support for ARM CPU driver. First add
> some data about commonly used ARM CPU models, and their
> vendors into cpu_map, then added some helper methods as
> callbacks to load them. Read and parse vendor_id, part_id
> and
On Tue, May 12, 2020 at 09:08:38AM +0200, Boris Fiuczynski wrote:
> On 5/11/20 9:40 PM, Brijesh Singh wrote:
> > Thanks for the patch Paulo, Few comments.
> >
> > On 5/11/20 11:41 AM, Boris Fiuczynski wrote:
> > > From: Paulo de Rezende Pinatti
> > >
> > > Implement secure guest check for AMD
On 5/11/20 7:28 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 08:26:53AM -0300, Daniel Henrique Barboza wrote:
On 5/11/20 6:57 AM, Daniel P. Berrangé wrote:
On Mon, May 11, 2020 at 11:22:57AM +1000, David Gibson wrote:
[...]
It's a different guest side interface, the H_TPM_COMM
In a way, libvirt already uses -numa memdev= in a few cases. In fact, in
as few cases as possible - only configurations which can not be
configured with -numa mem=, because these two ways are incompatible when
it comes to migration.
My approach to solve this is to have a privateData flag which
As advertised in the previous commit, migration from -numa
memdev= to -numa mem= is not supported and results in error.
Fortunately, we can check whether the destination has used the
style we told it to, or if the corresponding flag in the
migration cookie is missing then we know we are talking to
In v4.1.0-rc0~9^2~25 QEMU deprecated -numa mem= in favor of -numa
memdev= + -object memory-backend-*. However, the problem is these
two are incompatible. A domain started with older cmd line can't
be migrated to the newer one and vice versa. That is why libvirt
hasn't switched to the new cmd line,
On Tue, May 12, 2020 at 10:26:46 -0400, Chris Jester-Young wrote:
> On Mon, May 11, 2020 at 09:13:42AM +0200, Peter Krempa wrote:
> > It would be great if you could describe that 'pvscsi' indeed is the
> > vmware paravirtual scsi controller even in qemu, because I had to dig
> > through the code
Looking into the future where we're able to generate cloudinit images,
we'll need to configure some of the install options which is currently
not possible without editing the install.yml group vars file within the
repository. That is suboptimal, so let's move the install options to
the global
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
guests/README.markdown | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/guests/README.markdown b/guests/README.markdown
index 7dbefed..0e70f5f 100644
--- a/guests/README.markdown
+++
We can now access the values directly in the config dictionary.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
guests/lcitool | 40
1 file changed, 40 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index 9dd4aea..a93b56e
This patch exercises the functionality added to the Config class by
defining a couple of pytest unit tests. The pytest script imports
lcitool as a local module (which is far from ideal), but in order to do
that, lcitool has to adopt the .py extension otherwise python refuses
to import it, but then
We can now access this value directly in the config dictionary.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
guests/lcitool | 17 -
1 file changed, 17 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index fa60218..9dd4aea 100755
--- a/guests/lcitool
So, the idea is to pass our YAML config to the Ansible playbooks as
extra vars. However, not all variables we need to pass on to Ansible
are exposed in the config (and they shouldn't be). Update the config
values dictionary with these variables before passing on to Ansible.
Signed-off-by: Erik
The 'with' statement doesn't define a new code block [1], thus no local
namespace is created. Therefore, we can still access the @content
variable outside of the 'with' block. So, there's really no need to
hold the @initrd_template file open longer than necessary (not that it
would be a big deal
This patch introduce a set of class Config helper methods in order to
parse and validate the new global YAML config.
Currently, only 'install' and 'gitlab' sections are recognized with
the flavor setting defaulting to "test" (backwards compatibility) and
gitlab runner registration url defaulting
We can now access this value directly in the config dictionary.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
guests/lcitool | 36
1 file changed, 4 insertions(+), 32 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index
Rather than having the configuration options split across multiple files
(root-password, flavor, gitlab-url, gitlab-runner-token, ...), let's
consolidate these settings into a global config file.
The YAML format has been chosen simply because it's the native data
format in Ansible and thus plays
Rather than requiring shutil module to get rid of the temporary
directory we're creating for virt-install, let's use the
TemporaryDirectory method instead which returns a file-like object which
can be used to clean up the standard Python way.
Although the internal exit handlers will take care of
This patch is a pre-requisite config file consolidation. Currently we've
got a number of files which serve as a configuration either to the
lcitool itself or to the ansible playbooks (majority). Once we replace
these with a single global lcitool config, we'd end up passing tokens
(potentially
This series is trying to consolidate the number of config files we currently
recognize under ~/.config/lcitool to a single global YAML config file. Thanks
to this effort we can expose more seetings than we previously could which will
come handy in terms of generating cloudinit images for
Right now, lcitool's users have 2 options to satisfy the tool's
dependencies: install them through the system package manager
system-wide or install through pip manually.
Since pip gives us the option to automate this process a tiny bit, let's
ship a requirements file. This targets users who are
On Mon, May 11, 2020 at 09:13:42AM +0200, Peter Krempa wrote:
> It would be great if you could describe that 'pvscsi' indeed is the
> vmware paravirtual scsi controller even in qemu, because I had to dig
> through the code to figure it out.
Sure, just in the commit message? Or elsewhere too?
>
On 5/12/20 8:23 AM, Ján Tomko wrote:
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm
On 5/12/20 10:48 AM, Daniel Henrique Barboza wrote:
On 5/12/20 8:23 AM, Ján Tomko wrote:
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU
On 5/12/20 8:23 AM, Ján Tomko wrote:
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm
On Tue, May 12, 2020 at 21:06:14 +0800, Zhang Bo wrote:
> It's insecure to log password, nomatter the password is encrypted or
> not. And do not log it even in debug mode, in the consideration of
> resilience, surposing that the log mode has been modified by the
> attacker.
That is true ...
>
>
It's insecure to log password, nomatter the password is encrypted or
not. And do not log it even in debug mode, in the consideration of
resilience, surposing that the log mode has been modified by the
attacker.
Signed-off-by: Zhang Bo
---
src/libvirt-domain.c| 3 +--
src/qemu/qemu_monitor.c
A failure in qemuProcessLaunch would lead to qemuExtStopDevices
being called twice - once in the cleanup section and then again
in qemuProcessStop.
However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm process, because
the swtmp_ioctl command
With the introduction of automated CI pipelines, we are now ready to switch
to using merge requests for the project. With this switch we longer wish
to have patches sent to the mailing list.
Signed-off-by: Daniel P. Berrangé
---
.gitpublish | 4
CONTRIBUTING.rst | 28
This introduces support for GitLab CI, and then recommends use of merge
requests for contribution.
Daniel P. Berrangé (2):
gitlab: introduce CI jobs for building content
gitlab: add CONTRIBUTING.rst file to indicate use of merge requests
.gitlab-ci.yml | 125
The docs build needs to validate one axis
- A variety of publican versions
We get coverage for this by running builds across various distros.
The CentOS 8 build is picked as the special one, from which we
publish the generated HTML docs, which then become browsable via
the GitLab Pages service.
With the introduction of automated CI pipelines, we are now ready to switch
to using merge requests for the project. With this switch we longer wish
to have patches sent to the mailing list.
Signed-off-by: Daniel P. Berrangé
---
.gitpublish | 4
CONTRIBUTING.rst | 28
The csharp build needs to validate two axis
- A variety of libvirt versions
- A variety of csharp versions
We get coverage for both these axis by running a build against the
distro provided libvirt packages. All that is then missing is a build
against the latest libvirt git master, which only
The 3.5 .NET version is no longer supported by the mono / monodevelop
toolchain.
Signed-off-by: Daniel P. Berrangé
---
.../virConnectOpen/virConnectOpen.csproj | 4 +-
.../virConnectOpenAuth.csproj | 4 +-
.../virConnectSetErrorFunc.csproj | 4 +-
This introduces support for GitLab CI, and then recommends use of merge
requests for contribution.
Daniel P. Berrangé (3):
Update to target newer 4.0 .NET framework version
gitlab: introduce CI jobs testing git master & distro libvirt
gitlab: add CONTRIBUTING.rst file to indicate use of
The ruby build needs to validate two axis
- A variety of libvirt versions
- A variety of ruby versions
We get coverage for both these axis by running a build against the
distro provided libvirt packages. All that is then missing is a build
against the latest libvirt git master, which only
With the introduction of automated CI pipelines, we are now ready to switch
to using merge requests for the project. With this switch we longer wish
to have patches sent to the mailing list.
Signed-off-by: Daniel P. Berrangé
---
.gitpublish | 4
CONTRIBUTING.rst | 28
Signed-off-by: Daniel P. Berrangé
---
.hgignore | 7 ---
1 file changed, 7 deletions(-)
delete mode 100644 .hgignore
diff --git a/.hgignore b/.hgignore
deleted file mode 100644
index 8158c7f..000
--- a/.hgignore
+++ /dev/null
@@ -1,7 +0,0 @@
-~$
-.o$
-.so$
-Makefile$
-^pkg/
This introduces support for GitLab CI, and then recommends use of merge
requests for contribution.
Daniel P. Berrangé (3):
gitlab: introduce CI jobs testing git master & distro libvirt
gitlab: add CONTRIBUTING.rst file to indicate use of merge requests
Remove obsolete mercurial ignore file
On 5/7/20 5:51 PM, Laine Stump wrote:
On 5/6/20 1:48 PM, Andrea Bolognani wrote:
On Mon, 2020-04-20 at 21:55 +0200, Boris Fiuczynski wrote:
On 4/10/20 2:06 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:30 +0200, Shalini Chellathurai Saroja wrote:
The ZPCI address validation or
This was removed in
commit 2cdc96c2a6ce83ea0605ad81b2e542f0daafa805
Author: Claudio Bley
Date: Wed Jan 22 16:45:14 2014 +0100
tests: remove obsolete test driver
JUnit is used for quite some time now, which supercedes the tests
defined in the old "test" class.
Signed-off-by: Daniel P. Berrangé
---
libvirt-java.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt-java.spec.in b/libvirt-java.spec.in
index 034d511..1d7fa43 100644
--- a/libvirt-java.spec.in
+++ b/libvirt-java.spec.in
@@ -20,7 +20,9 @@ Requires: java >= @java.required@
Signed-off-by: Daniel P. Berrangé
---
src/test/java/org/libvirt/TestJavaBindings.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/libvirt/TestJavaBindings.java
b/src/test/java/org/libvirt/TestJavaBindings.java
index 88ad1ba..4b55a13 100644
---
The java build needs to validate two axis
- A variety of libvirt versions
- A variety of java versions
We get coverage for both these axis by running a build against the
distro provided libvirt packages. All that is then missing is a build
against the latest libvirt git master, which only
With the introduction of automated CI pipelines, we are now ready to switch
to using merge requests for the project. With this switch we longer wish
to have patches sent to the mailing list, and thus the git-publish
config is removed.
Signed-off-by: Daniel P. Berrangé
---
.gitpublish | 4
This fixes a bugs from bit-rot and then enables GitLab CI and use of
merge requests for contribution.
Daniel P. Berrangé (6):
Fix test driver connection type
Add workaround for broken screenshot API on Ubuntu 18.04 vintage
Remove reference to test.java file that was deleted
rpm: skip
Signed-off-by: Daniel P. Berrangé
---
src/test/java/org/libvirt/TestJavaBindings.java | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/test/java/org/libvirt/TestJavaBindings.java
b/src/test/java/org/libvirt/TestJavaBindings.java
index 4b55a13..0a3bca0 100644
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/virt-admin.rst | 3 ++-
tools/virt-admin.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst
index 3e0d127790..d5cb23a1c5 100644
---
Thanks for the patch Paulo, Few comments.
On 5/11/20 11:41 AM, Boris Fiuczynski wrote:
> From: Paulo de Rezende Pinatti
>
> Implement secure guest check for AMD SEV (Secure Encrypted
> Virtualization) in order to invalidate the qemu capabilities
> cache in case the availability of the feature
On 5/11/20 9:40 PM, Brijesh Singh wrote:
Thanks for the patch Paulo, Few comments.
On 5/11/20 11:41 AM, Boris Fiuczynski wrote:
From: Paulo de Rezende Pinatti
Implement secure guest check for AMD SEV (Secure Encrypted
Virtualization) in order to invalidate the qemu capabilities
cache in case
On Tue, May 12, 2020 at 08:08:28 +0200, David Schweizer wrote:
> Hello Peter,
>
> Thank you for your answer.
>
> The problem is that i would like to use the feature in a production
> environment and can not rely on out of tree patches.
Well, you certainly can contribute in having them merged.
Hello Peter,
Thank you for your answer.
The problem is that i would like to use the feature in a production
environment and can not rely on out of tree patches.
In regard to my question i conclude the following:
- There is currently no support for iSER storage objects in libvirt.
- There will
76 matches
Mail list logo
