Re: [PATCH v3 5/9] domain_conf.c: XML parsing for VIR_DOMAIN_TPM_MODEL_SPAPR_PROXY

On 5/14/20 10:07 PM, Daniel Henrique Barboza wrote: On 5/14/20 11:32 AM, Daniel Henrique Barboza wrote: On 5/14/20 11:09 AM, Ján Tomko wrote: On a Wednesday in 2020, Daniel Henrique Barboza wrote: Aside from trivial XML parsing/format changes, this patch adds additional rules for TPM

[PATCH v4 09/10] tests/qemuxml2argvtest.c: add TPM Proxy command line tests

Add tests for both supported scenarios: a single TPM Proxy and a TPM Proxy with a regular TPM device in the same domain. Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza --- .../ppc64-tpmproxy-single.ppc64-latest.args | 34 +

[PATCH v4 04/10] qemu_tpm, security, tests: change 'switch' clauses for 'if'

This trivial rework is aimed to reduce the amount of line changes made by the next patch, when 'def->tpm' will become a 'def->tpms' array. Instead of using a 'switch' where only the VIR_DOMAIN_TPM_TYPE_EMULATOR label does something, use an 'if' clause instead. Signed-off-by: Daniel Henrique

[PATCH v4 10/10] docs/news.xml: update for the new TPM Proxy device

Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza --- docs/news.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4cef804aac..c22a0f0a18 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,23 @@ +

[PATCH v4 07/10] tests: add XML schema tests for the TPM Proxy device

This tests aims to exercise how a TPM Proxy device can be added in the domain, either alone or with a regular TPM device. It also ensures that we do not allow bogus scenarios to slip by. Reviewed-by: Stefan Berger Signed-off-by: Daniel Henrique Barboza ---

[PATCH v4 05/10] conf, qemu, security, tests: introducing 'def->tpms' array

A TPM Proxy device can coexist with a regular TPM, but the current domain definition supports only a single TPM device in the 'tpm' pointer. This patch replaces this existing pointer in the domain definition to an array of TPM devices. All files that references the old pointer were adapted to

[PATCH v4 08/10] qemu: build command line for the TPM Proxy device

This patch wraps it up all the wiring done in previous patches, enabling a PPC64 guest to launch a guest using a TPM Proxy device. Note that device validation is already being done in qemu_validate.c, qemuValidateDomainDeviceDefTPM(), on domain define time. We don't need to verify QEMU

[PATCH v4 06/10] qemu_validate.c: add validation for TPM Proxy model

Previous patch handled the conversion of def->tpm to the array def->tpms. What we're missing now is the validation code to make the VIR_DOMAIN_TPM_MODEL_SPAPR_PROXY model exclusive to PPC64 guests and VIR_DOMAIN_TPM_TYPE_PASSTHROUGH backend. Signed-off-by: Daniel Henrique Barboza ---

[PATCH v4 03/10] qemu_extdevice.c: remove unneeded 'ret' variable

qemuExtDevicesInitPaths() does not need 'ret'. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_extdevice.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 2096272761..2ff3f68f5d 100644 ---

[PATCH v4 00/10] Introducing TPM Proxy device support for PPC64

changes in v4: - patch 1: added missing tags - comma-escaped the path string in qemu_command.c (patch 8) - moved validations not-XML-parsing related from domain_conf.c to qemu_validate.c - new patches 3 and 4: cleanups - patch 5 (former 3): changed the approach to use a def->tpms array instead

[PATCH v4 01/10] docs: documentation and schema for the new TPM Proxy model

QEMU 4.1.0 introduced a new device type called TPM Proxy, currently implemented by PPC64 guests via a new virtual device called 'spapr-tpm-proxy' (see QEMU 0fb6bd073230 for more info). The TPM Proxy device interacts with a TPM Resource Manager, a host device capable of multiplexing the host TPM

[PATCH v4 02/10] qemu: Extend QEMU capabilities with 'spapr-tpm-proxy'

Expose the TPM Proxy support for PPC64 guests by creating a new cap called QEMU_CAPS_DEVICE_SPAPR_TPM_PROXY. This device is part of the machinery the guest need to orchestrate with the PPC64 Ultravisor the transition to the Secure VM (SVM) mode. Inside QEMU, this device will be used with the

Re: [libvirt PATCH] qemu: prevent attempts to detach a device on a controller with hotplug='off'

On 5/15/20 3:58 AM, Erik Skultety wrote: On Thu, May 14, 2020 at 02:12:38PM -0400, Laine Stump wrote: Although the original patches to support controllers with hotplug='off' were checking during hotplug/attach requests that the device was being plugged into a PCI controller that didn't have

Re: [PATCH 05/21] qemuBuildChannelChrDeviceStr: Remove formatting of properties for -netdev

On 5/15/20 10:27 AM, Peter Krempa wrote: The output of the function is fed as argument to '-device' command line argument or 'device_add' monitor command except for 'guestfwd' channels where it needs to be fed to -netdev/netdev_add. This is confusing and error prone. Split it up since the caller

[PATCH trivial 1/1] qemu_alias.c: fix qemuAssingDeviceMemballoonAlias() typo

Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_alias.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c index b0ea62af39..d6527cb046 100644 --- a/src/qemu/qemu_alias.c +++ b/src/qemu/qemu_alias.c @@ -390,7 +390,7 @@

Re: [PATCH 04/21] qemuBuildChannelsCommandLine: Extract common formatting of 'chardev'

On 5/15/20 10:27 AM, Peter Krempa wrote: Both active branches create the same backend chardev. Since there is no other case, extract it before the switch so that we don't have to duplicate it. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 32 +++- 1

Re: [PATCH 03/21] qemuBuildChannelsCommandLine: Use typecasted switch for channel type

On 5/15/20 10:27 AM, Peter Krempa wrote: Cover all cases of the enum. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 02/21] qemuMonitorJSONParseKeywords: remove constant argument

On 5/15/20 10:27 AM, Peter Krempa wrote: There's just one caller that always passes '1'. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c

Re: [PATCH 01/21] qemu: domain: Forbid unsupported 'tftp' protocol and handle tests

On 5/15/20 10:27 AM, Peter Krempa wrote: 'tftp' storage protocol was supported by qemu until 2.7.0. Add an interlock when blockdev is used and drop the test case for it as it's IMO not worth adding another test file just for that. Fair enough. Signed-off-by: Peter Krempa ---

Re: [PATCH 1/2] gitlab: introduce CI jobs for building content

On Fri, 2020-05-15 at 17:37 +0100, Daniel P. Berrangé wrote: > +ubuntu-2004-container: > + <<: *container_job_definition > + variables: > +NAME: ubuntu-2004 > + > + > + Way too many empty lines here :) > +# ubuntu-2004-docs is special as it is the one > +# we publish from > +pages: > +

[PATCH 1/2] gitlab: introduce CI jobs for building content

The docs build needs to validate one axis - A variety of publican versions We get coverage for this by running builds across various distros. The Ubuntu 20.04 build is picked as the special one, from which we publish the generated HTML docs, which then become browsable via the GitLab Pages

[PATCH 2/2] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we longer wish to have patches sent to the mailing list. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- .gitpublish | 4

[PATCH 0/2] Introduce GitLab CI and merge requests

In v2: - Use ubuntu for publishing pages build Daniel P. Berrangé (2): gitlab: introduce CI jobs for building content gitlab: add CONTRIBUTING.rst file to indicate use of merge requests .gitlab-ci.yml | 126 +++ .gitpublish

[PATCH] Don't require secdrivers to implement .domainMoveImageMetadata

The AppArmor secdriver does not use labels to grant access to resources. Therefore, it doesn't use XATTRs and hence it lacks implementation of .domainMoveImageMetadata callback. This leads to a harmless but needless error message appearing in the logs: virSecurityManagerMoveImageMetadata:476 :

[PATCH 18/21] qemu: Prepare for testing of 'netdev_add' props via qemuxml2argvtest

qemuxml2argv test suite is way more comprehensive than the hotplug suite. Since we share the code paths for monitor and command line hotplug we can easily test the properties of devices against the QAPI schema. To achieve this we'll need to skip the JSON->commandline conversion for the test run

[PATCH 17/21] qemuMonitorAddNetdev: Convert to the native JSON props object

Now that all code paths generate JSON props we can remove the conversion to command line arguments and back in the monitor code. Note that the test which is removed in this commit will be replaced by a stronger testsuite later. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 14

[PATCH 15/21] virQEMUBuildNetdevCommandlineFromJSON: Prepare for quirky 'guestfwd'

QEMU models guestfwd as: 'guestfwd': [ { "str": "tcp:10.0.2.1:4600-chardev:charchannel0" }, { "str": ""}, ] I guess the original idea was to make it extensible while not worrying about adding another object for it. Either way it requires us to

[PATCH 20/21] testutilsqemuschema: Allow loading non-latest schema

Add testQEMUSchemaLoad and refactor internals so that we can load the QMP schema from an arbitrary caps replies file. Signed-off-by: Peter Krempa --- tests/testutilsqemuschema.c | 64 - tests/testutilsqemuschema.h | 3 ++ 2 files changed, 45 insertions(+),

[PATCH 16/21] qemuBuildChannelGuestfwdNetdevProps: Convert to generating JSON props

Syntax of guestfwd channel also needs to be modified to conform to the QAPI schema. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 37 +++-- src/qemu/qemu_command.h | 2 +- src/qemu/qemu_hotplug.c | 6 +- 3 files changed, 37 insertions(+), 8

[PATCH 14/21] qemu: command: Generate -netdev command line via JSON->cmdline conversion

The 'netdev_add' command was recently formally described in qemu via the QMP schema. This means that it also requires the arguments to be properly formatted. Our current approach is to generate the command line and then use qemuMonitorJSONKeywordStringToJSON to get the JSON properties for the

Re: Firmware auto-select limitation

On Fri, May 15, 2020 at 17:16:57 +0200, Michal Privoznik wrote: > On 5/15/20 4:40 PM, GUOQING LI wrote: [...] > > *Detailed error * > > Error starting domain: internal error: process exited while connecting > > to monitor: 2020-05-15T14:19:06.033267Z qemu-system-x86_64: -drive > >

[PATCH 19/21] testQEMUSchemaLoad: Rename to testQEMUSchemaLoadLatest

It always loads the latest schema. Prepare for loading others as well. Signed-off-by: Peter Krempa --- tests/qemublocktest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 4 ++-- tests/testutilsqemuschema.c | 2 +- tests/testutilsqemuschema.h | 2 +- 5 files

[PATCH 10/21] util: json: Introduce virJSONValueObjectAppendStringPrintf

Add a variant similar to virJSONValueObjectAppendString which also formats more complex value strings with printf syntax. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virjson.c | 17 + src/util/virjson.h | 2 ++ 3 files changed, 20

[PATCH 21/21] qemuxml2argvtest: Add QAPI/QMP schema validation for -blockdev and -netdev

Our hotplug test cases are weak in comparison to the xml2arvtest. Use all the the data to also valiadte the arguments for -netdev and -blockdev against the appropriate commands of the QMP schema. Note that currently it's done just for the _CAPS versions of tests but commenting out a line in the

[PATCH 11/21] testCompareXMLToArgv: Split out preparation and command formatting

There are multiple steps of setting up the domain definition prior to formatting the command line for the tests. Extract it to a separate function so that it's self-contained and also will allow re-running the command line formatting which will be necessary for QMP schema validation tests.

[PATCH 13/21] util: virqemu: Introduce virQEMUBuildNetdevCommandlineFromJSON

In preparation for converting the generator of -netdev to generate JSON which will be used to do the command line rather than the other way around we need to introduce a convertor which properly configures virQEMUBuildCommandLineJSON for the quirks of -netdev. Signed-off-by: Peter Krempa ---

[PATCH 12/21] qemuMonitorJSON(Add|Remove)Netdev: Refactor cleanup

Use automatic pointer cleanup for virJSONValuePtrs to get rid of the cleanup label and ret variable. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 52 +++- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git

[PATCH 04/21] qemuBuildChannelsCommandLine: Extract common formatting of 'chardev'

Both active branches create the same backend chardev. Since there is no other case, extract it before the switch so that we don't have to duplicate it. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 32 +++- 1 file changed, 11 insertions(+), 21

[PATCH 05/21] qemuBuildChannelChrDeviceStr: Remove formatting of properties for -netdev

The output of the function is fed as argument to '-device' command line argument or 'device_add' monitor command except for 'guestfwd' channels where it needs to be fed to -netdev/netdev_add. This is confusing and error prone. Split it up since the caller needs to know which command/option to use

[PATCH 09/21] virCommand: Introduce virCommandGetArgList

The helper returns a list of arguments of a virCommand. This will be useful in tests where we'll inspect certain already formatted arguments. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/vircommand.c| 23 +++ src/util/vircommand.h| 1 +

[PATCH 03/21] qemuBuildChannelsCommandLine: Use typecasted switch for channel type

Cover all cases of the enum. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bfe70ed228..06568ae585 100644 --- a/src/qemu/qemu_command.c +++

[PATCH 07/21] virQEMUBuildCommandLineJSON: Allow skipping certain keys

Allow reusing this for formatting of netdev_add arguments into -netdev. We need to be able to skip the 'type' property as it's used without the prefix. Add infrastructure which allows skipping a certainly named property. Signed-off-by: Peter Krempa --- src/util/virqemu.c | 30

[PATCH 02/21] qemuMonitorJSONParseKeywords: remove constant argument

There's just one caller that always passes '1'. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 505b31a78a..66422a8489 100644 ---

[PATCH 06/21] qemuBuildHostNetStr: Stop using 'ipv6-net' convenience argument

In qemu the argument of 'ipv6-net' is split up into 'ipv6-prefix' and 'ipv6-prefixlen'. Additionally now that 'netdev_add' was qapified, only the real properties are allowed. Switch to using them explicitly. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 20

[PATCH 01/21] qemu: domain: Forbid unsupported 'tftp' protocol and handle tests

'tftp' storage protocol was supported by qemu until 2.7.0. Add an interlock when blockdev is used and drop the test case for it as it's IMO not worth adding another test file just for that. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 10 ++

[PATCH 08/21] virQEMUBuildCommandLineJSON: Add possibility for using 'on/off' instead of 'yes/no'

In some cases we use 'on/off' for command line arguments. Add a switch which will select the prefred spelling for a specific usage. Signed-off-by: Peter Krempa --- src/util/virqemu.c | 44 - src/util/virqemu.h | 10 ++---

[PATCH 00/21] Fix compatibility with netdev-add in qemu-5.0

This is based on top of tests: qemu: Detect deprecation in the QMP schema (deprecation part 1) https://www.redhat.com/archives/libvir-list/2020-April/msg01444.html Both can be fetched at: git fetch https://gitlab.com/pipo.sk/libvirt.git netdev_add-validate QEMU-5.0 released a fully QAPIfied

Re: [PATCH v2 3/3] qemuBuildNumaArgStr: Use modern -numa memdev= if old -numa mem= is unsupported

On a Thursday in 2020, Michal Privoznik wrote: In previous commit we started tracking whether QEMU supports '-numa mem='. This is tied to the machine type because migration from '-numa mem=' to '-numa memdev' is impossible (or vice versa). But since it's tied to a machine type (where migration

Re: [PATCH 35/40] libxl: convert libxlMigrationDstArgs to GObject

On Wed, May 13, 2020 at 01:57:19PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/libxl/libxl_migration.c | 65 + > 1 file changed, 37 insertions(+), 28 deletions(-) > > diff --git a/src/libxl/libxl_migration.c

Re: [PATCH v2 1/3] qemu: Track numa-mem-supported machine attribute

On a Thursday in 2020, Michal Privoznik wrote: There is 'numa-mem-supported' machine attribute which specifies whether '-numa mem=' is supported. Store it in our capabilities as it will be used in later commits when building the command line. Signed-off-by: Michal Privoznik ---

Re: Firmware auto-select limitation

On 5/15/20 4:40 PM, GUOQING LI wrote: Hi everyone and Martin I would like to confirm the conversation we had in regard the possible limitation of firmware auto-select feature that’s been released since v5.20.  I recall you saying that there were a lot of issues with auto select and later

Re: [PATCH 33/40] libxl: convert libxlDriverConfig to GObject

On Wed, May 13, 2020 at 01:57:17PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/libxl/libxl_conf.c | 51 ++-- > src/libxl/libxl_conf.h | 12 ++- > src/libxl/libxl_driver.c| 162 > src/libxl/libxl_migration.c

Re: [PATCH v2 2/3] qemuBuildNumaArgStr: Switch order of if() and for()

On a Thursday in 2020, Michal Privoznik wrote: When building -numa command line there is a for() loop that builds '-numa memdev=' for each guest NUMA node. And also records in a local variable whether any of memory-object-* backends must be used to satisfy desired config. Well, instead of

Re: [PATCH v2 1/3] qemu: Track numa-mem-supported machine attribute

On a Thursday in 2020, Michal Privoznik wrote: There is 'numa-mem-supported' machine attribute which specifies whether '-numa mem=' is supported. Store it in our capabilities as it will be used in later commits when building the command line. Signed-off-by: Michal Privoznik ---

Re: [PATCH 00/40] convert virObjects to GObject

On Fri, May 15, 2020 at 02:34:01PM +0200, Michal Privoznik wrote: > On 5/13/20 1:56 PM, Rafael Fonseca wrote: > > This patch series convert various simple instances of virObject to a > > GObject equivalent. > > I'm sorry upfront for misusing your patchset and I'm also sorry for bringing > this up

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

On a Friday in 2020, Gerd Hoffmann wrote: Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting audiodev via -global is enough to properly initialize pcspk. Signed-off-by: Gerd Hoffmann ---

Re: [PATCH 29/40] datatypes: convert virDomain to GObject

On Wed, May 13, 2020 at 01:57:13PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/conf/domain_event.c | 58 ++-- > src/datatypes.c | 50 ++ > src/datatypes.h | 20 ++-- > src/esx/esx_driver.c

Firmware auto-select limitation

Hi everyone and Martin I would like to confirm the conversation we had in regard the possible limitation of firmware auto-select feature that’s been released since v5.20. I recall you saying that there were a lot of issues with auto select and later they shipped it into a Json file , it

[PATCH v2 08/13] audio: deprecate -soundhw gus

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index eb4a803fb53b..61d16fad9ffb 100644 --- a/hw/audio/gus.c

[PATCH v2 07/13] audio: deprecate -soundhw cs4231a

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index ffdbb58d6a11..59705a8d4701 100644 ---

[PATCH v2 10/13] audio: deprecate -soundhw hda

Add deprecation message to the audio init function. Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 4696ae0d9a61..d491e407b317 100644 --- a/hw/audio/intel-hda.c +++

[PATCH v2 05/13] audio: deprecate -soundhw es1370

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both es1370 and ES1370 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/es1370.c | 9 ++--- qdev-monitor.c| 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff

[PATCH v2 12/13] audio: add soundhw deprecation notice

Signed-off-by: Gerd Hoffmann --- docs/system/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 3142fac38658..7de1045b7e27 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -88,6

[PATCH v2 06/13] audio: deprecate -soundhw adlib

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 7c3b67dcfb8c..65dff5b6fca4 100644 ---

[PATCH v2 01/13] stubs: add isa_create_simple

Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/isa-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/isa-bus.c diff --git a/stubs/isa-bus.c

[PATCH v2 00/13] audio: deprecate -soundhw

v2: - use g_assert_not_reached() for stubs. - add deprecation notice. Gerd Hoffmann (13): stubs: add isa_create_simple stubs: add pci_create_simple audio: add deprecated_register_soundhw audio: deprecate -soundhw ac97 audio: deprecate -soundhw es1370 audio: deprecate -soundhw adlib

[PATCH v2 11/13] audio: deprecate -soundhw pcspk

Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting audiodev via -global is enough to properly initialize pcspk. Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.c | 24 +--- 1 file

[PATCH v2 04/13] audio: deprecate -soundhw ac97

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both ac97 and AC97 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 9 ++--- qdev-monitor.c | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH v2 02/13] stubs: add pci_create_simple

Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/pci-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/pci-bus.c diff --git a/stubs/pci-bus.c

[PATCH v2 09/13] audio: deprecate -soundhw sb16

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/sb16.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index df6f755a37f8..2d9e50f99b5d 100644 ---

[PATCH v2 13/13] [RFC] audio: try use onboard audiodev for pcspk

New naming convention: Use "onboard" audiodev for onboard audio devices, using "-audiodev pa,id=onboard" for example. This patchs implements it for pcspk, it will try to use "onboard" by default. Setting another name using "-global pcspk.audiodev=" continues to work. If we want go this route

[PATCH v2 03/13] audio: add deprecated_register_soundhw

Add helper function for -soundhw deprecation. It can replace the simple init functions which just call {isa,pci}_create_simple() with a hardcoded type. It also prints a deprecation message. Signed-off-by: Gerd Hoffmann --- include/hw/audio/soundhw.h | 2 ++ hw/audio/soundhw.c | 24

Re: [PATCH 1/6] util: introduce a parser for kernel cmdline arguments

On Mon, May 11, 2020 at 06:41:56PM +0200, Boris Fiuczynski wrote: > From: Paulo de Rezende Pinatti > > Introduce two utility functions to parse a kernel command > line string according to the kernel code parsing rules in > order to enable the caller to perform operations such as > verifying

[libvirt PATCH] docs: Update after libvirt-ruby repository rename

Signed-off-by: Andrea Bolognani --- Pushed as trivial. docs/ci.rst| 10 +- docs/downloads.html.in | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/ci.rst b/docs/ci.rst index fe59b98923..2a8788d0d7 100644 --- a/docs/ci.rst +++ b/docs/ci.rst

Re: [libvirt-ruby PATCH v2 2/4] gitlab: introduce CI jobs testing git master & distro libvirt

On Fri, 2020-05-15 at 11:11 +0100, Daniel P. Berrangé wrote: > The ruby build needs to validate two axis > > - A variety of libvirt versions > - A variety of ruby versions > > We get coverage for both these axis by running a build against the > distro provided libvirt packages. All that is

Re: [libvirt-ruby PATCH v2 3/4] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

On Fri, 2020-05-15 at 11:11 +0100, Daniel P. Berrangé wrote: > With the introduction of automated CI pipelines, we are now ready to switch > to using merge requests for the project. With this switch we longer wish > to have patches sent to the mailing list. > > Signed-off-by: Daniel P. Berrangé

Re: [libvirt-ruby PATCH v2 1/4] doc: update for new git repo name and hosting

On Fri, 2020-05-15 at 11:11 +0100, Daniel P. Berrangé wrote: > +++ b/doc/site/index.html > @@ -61,7 +61,7 @@ puts dom.xml_desc > more complete examples. > Developers > The sources are available from git. To clone, run > -git clone git://libvirt.org/ruby-libvirt.git

Re: [libvirt-java PATCH v2 0/2] Introduce GitLab CI and merge requests

On Fri, 2020-05-15 at 11:30 +0100, Daniel P. Berrangé wrote: > In v2: > > - Use different approach for conditional job rules > - Use ubuntu for long term git job > > Daniel P. Berrangé (2): > gitlab: introduce CI jobs testing git master & distro libvirt > gitlab: add CONTRIBUTING.rst file

Re: [PATCH 21/40] datatypes: convert virNetwork to GObject

On Wed, May 13, 2020 at 01:57:05PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/conf/domain_conf.c | 6 ++-- > src/conf/network_event.c| 7 ++-- > src/conf/virnetworkobj.c| 5 +-- > src/datatypes.c | 50

Re: [libvirt-ci PATCH] guests: don't force user to create a config.yaml file

On Fri, 2020-05-15 at 11:06 +0100, Daniel P. Berrangé wrote: > Only the "install" command requires a per-user config.yaml with a > password set. We should not require this for the other commands > to be run. This is incorrect: the update and build actions, and in general any action that requires

Re: [PATCH] README: Replace "configure" with "autogen.sh" for correct installation

On Fri, May 15, 2020 at 12:03:01PM +0200, Michal Privoznik wrote: > On 5/15/20 11:13 AM, Daniel P. Berrangé wrote: > > Or just ignore the problem for now, since when we switch to Meson, we'll > > have the same instructions regardless of whether building from git or > > tarballs. > > > > I'm not

Re: [PATCH 02/40] conf: capabilities: convert virCaps to GOBject

On Wed, May 13, 2020 at 01:56:46PM +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/bhyve/bhyve_capabilities.c | 16 > src/bhyve/bhyve_driver.c| 29 -- > src/conf/capabilities.c | 39 ++--- >

[libvirt PATCH] cpu_arm: Drop unused variable

Signed-off-by: Jiri Denemark --- Pushed. It is trivial and should fix the build on FreeBSD. src/cpu/cpu_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 66f6942ab9..6f6c6a1479 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -325,7

Re: [PATCH 00/40] convert virObjects to GObject

On 5/13/20 1:56 PM, Rafael Fonseca wrote: This patch series convert various simple instances of virObject to a GObject equivalent. I'm sorry upfront for misusing your patchset and I'm also sorry for bringing this up again. I think we need to step back and re-evaluate whether this is worth

Re: [libvirt PATCH] docs: document proper enum for guest agent timeout

On 5/15/20 12:30 PM, Tomáš Golembiovský wrote: The documented enum and its values do not exits. The real enum has slightly different name. Signed-off-by: Tomáš Golembiovský --- src/libvirt-domain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs

On Wed, May 13, 2020 at 01:06:58PM +0200, Peter Krempa wrote: > On Wed, May 13, 2020 at 11:20:07 +0100, Daniel Berrange wrote: > > On Wed, May 13, 2020 at 12:05:44PM +0200, Peter Krempa wrote: > > > On Wed, May 13, 2020 at 10:57:33 +0100, Daniel Berrange wrote: > > > > On Wed, May 13, 2020 at

Re: [PATCH] README: Replace "configure" with "autogen.sh" for correct installation

On Fri, May 15, 2020 at 12:03:01PM +0200, Michal Privoznik wrote: > On 5/15/20 11:13 AM, Daniel P. Berrangé wrote: > > Or just ignore the problem for now, since when we switch to Meson, we'll > > have the same instructions regardless of whether building from git or > > tarballs. > > > > I'm not

[libvirt-java PATCH v2 2/2] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we longer wish to have patches sent to the mailing list, and thus the git-publish config is removed. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P.

[libvirt-java PATCH v2 1/2] gitlab: introduce CI jobs testing git master & distro libvirt

The java build needs to validate two axis - A variety of libvirt versions - A variety of java versions We get coverage for both these axis by running a build against the distro provided libvirt packages. All that is then missing is a build against the latest libvirt git master, which only

[libvirt-java PATCH v2 0/2] Introduce GitLab CI and merge requests

In v2: - Use different approach for conditional job rules - Use ubuntu for long term git job Daniel P. Berrangé (2): gitlab: introduce CI jobs testing git master & distro libvirt gitlab: add CONTRIBUTING.rst file to indicate use of merge requests .gitlab-ci.yml |

[libvirt PATCH] docs: document proper enum for guest agent timeout

The documented enum and its values do not exits. The real enum has slightly different name. Signed-off-by: Tomáš Golembiovský --- src/libvirt-domain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index

[libvirt-ruby PATCH v2 1/4] doc: update for new git repo name and hosting

Signed-off-by: Daniel P. Berrangé --- doc/site/downloads.html | 12 ++-- doc/site/index.html | 2 +- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/doc/site/downloads.html b/doc/site/downloads.html index cc656c9..41964f7 100644 --- a/doc/site/downloads.html +++

[libvirt-ruby PATCH v2 4/4] Remove obsolete mercurial ignore file

Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- .hgignore | 7 --- 1 file changed, 7 deletions(-) delete mode 100644 .hgignore diff --git a/.hgignore b/.hgignore deleted file mode 100644 index 8158c7f..000 --- a/.hgignore +++ /dev/null @@ -1,7 +0,0 @@ -~$ -.o$

[libvirt-ruby PATCH v2 3/4] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we longer wish to have patches sent to the mailing list. Signed-off-by: Daniel P. Berrangé --- .gitpublish | 4 CONTRIBUTING.rst | 28

[libvirt-ruby PATCH v2 0/4] Introduce GitLab CI and merge requests

In v2: - Renamed repo - Change way we conditionalize build rules Daniel P. Berrangé (4): doc: update for new git repo name and hosting gitlab: introduce CI jobs testing git master & distro libvirt gitlab: add CONTRIBUTING.rst file to indicate use of merge requests Remove obsolete

[libvirt-ruby PATCH v2 2/4] gitlab: introduce CI jobs testing git master & distro libvirt

The ruby build needs to validate two axis - A variety of libvirt versions - A variety of ruby versions We get coverage for both these axis by running a build against the distro provided libvirt packages. All that is then missing is a build against the latest libvirt git master, which only

[libvirt-ci PATCH] guests: don't force user to create a config.yaml file

Only the "install" command requires a per-user config.yaml with a password set. We should not require this for the other commands to be run. Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 51 +- 1 file changed, 25 insertions(+), 26

Re: [PATCH] README: Replace "configure" with "autogen.sh" for correct installation

On 5/15/20 11:13 AM, Daniel P. Berrangé wrote: Or just ignore the problem for now, since when we switch to Meson, we'll have the same instructions regardless of whether building from git or tarballs. I'm not strictly against that, but I guess that might take a while. Pavel? And this is

Re: [PATCH V5 0/4] Introduce getHost support for ARM CPU driver

On Wed, May 13, 2020 at 18:48:28 +0800, Zhenyu Zheng wrote: > Introduce getHost support for ARM CPU driver. First add > some data about commonly used ARM CPU models, and their > vendors into cpu_map, then added some helper methods as > callbacks to load them. Read and parse vendor_id, part_id >

Re: [PATCH V5 2/4] cpu: Add helper functions to parse vendor and model

On Wed, May 13, 2020 at 18:48:32 +0800, Zhenyu Zheng wrote: > Add helper functions to parse vendor and model for > ARM CPUs, and use them as callbacks when load cpu > maps. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 159 +- > 1 file

  1   2   >