On 6/15/20 12:10 PM, Peter Krempa wrote:
Reuse qemuBlockGetBitmapMergeActions which allows to remove the ad-hoc
s/allows to remove/allows the removal of/
implementatio of bitmap merging for block commit. The new approach is
implementation
way simpler and more robust and also allows us to
On 6/15/20 12:10 PM, Peter Krempa wrote:
The 'snapshots' case has multiple layers so we need to make sure that
the bitmaps are merged with the appropriate temporary bitmaps formatted
from the allocation bitmap for any backing chain layer above.
Signed-off-by: Peter Krempa
---
tests/qemublockt
On 6/15/20 12:10 PM, Peter Krempa wrote:
The 'basic' case is just a single backing store layer containing the
bitmaps so we just copy the bitmaps over to the backup bitmap.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 4 +++
.../backupmerge/basic-deep-out.
On 6/15/20 12:10 PM, Peter Krempa wrote:
Reuse qemuBlockGetBitmapMergeActions which allows to remove the ad-hoc
allows the removal of the
iplementatio of bitmap merging for backup. The new approach is simpler
implementation
and also more robust in case some of the bitmaps break as they re
On 6/15/20 12:10 PM, Peter Krempa wrote:
Add a function which allows to merge bitmaps according to the new
Another reminder about "allows to $VERB" being non-idiomatic :)
s/allows to merge/allows merging/
semantics and will allow to replace all the specific ad-hoc functions
s/allow to repl
With recent additions to the node device xml schema, an xml schema can
now describe a mdev device sufficiently for libvirt to create and start
the device using the mdevctl utility.
Note that some of the the configuration for a mediated device must be
passed to mdevctl as a JSON-formatted file. In
Add the ability to destroy mdev node devices via the mdevctl utility.
Signed-off-by: Jonathon Jongsma
---
src/node_device/node_device_driver.c | 33
src/node_device/node_device_driver.h | 2 ++
2 files changed, 35 insertions(+)
diff --git a/src/node_device/node_dev
Mediated devices support arbitrary vendor-specific attributes that can
be attached to a mediated device. These attributes are ordered, and are
written to sysfs in order after a device is created. This patch adds
support for these attributes to the mdev data types and XML schema.
Signed-off-by: Jon
In order to test the nodedev driver, we need to link against a
non-loadable module. Similar to other loadable modules already in the
repository, create an _impl library that can be linked against the unit
tests and then create a loadable module from that.
Signed-off-by: Jonathon Jongsma
---
src/
Signed-off-by: Jonathon Jongsma
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 20964b94d7..42d159b233 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -21,6 +21,13 @@ v6.5.0 (unreleased)
It's possible to either specify new value as a string or
p
Test that we run 'mdevctl' with the proper arguments when we destroy
mediated devices with virNodeDeviceDestroy()
Signed-off-by: Jonathon Jongsma
---
tests/nodedevmdevctldata/mdevctl-stop.argv | 1 +
tests/nodedevmdevctltest.c | 41 ++
2 files changed, 42 ins
In preparation for creating mediated devices in libvirt, we will need to
wait for new mediated devices to be created as well. Refactor
nodeDeviceFindNewDevice() so that we can re-use the main logic from this
function to wait for different device types by passing a different
'find' function.
Signed
Test that we run 'mdevctl' with the proper arguments when creating new
mediated devices with virNodeDeviceCreateXML().
Signed-off-by: Jonathon Jongsma
---
build-aux/syntax-check.mk | 2 +-
tests/Makefile.am | 15 +
...019_36ea_4111_8f0a_8c9a70e2
As noted by Erik Skultety, we use the same XML schema to report
existing devices and to define new devices. However, some schema
elements are "read-only". In other words, they are used to report
information from the node device driver and cannot be used to define a
new device. Note these in the doc
In order to allow libvirt to create and start new mediated devices, we
need to be able to verify that the device has been started. In order to
do this, we'll need to save the UUID of newly-discovered devices within
the virNodeDevCapMdev structure. This allows us to search the device
list by UUID an
This is the first portion of an effort to support persistent mediated devices
with libvirt. This first series simply enables creating and destroying
non-persistent mediated devices via the virNodeDeviceCreateXML() and
virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] provides the backend
i
Currently nodeDeviceCreateXML() and nodeDeviceDestroy() only support
NPIV HBAs, but we want to be able to create mdev devices as well. This
is a first step to enabling that support.
Signed-off-by: Jonathon Jongsma
---
src/node_device/node_device_driver.c | 91 ++--
1 file
When parsing a nodedev xml file, the iommuGroup element should be
optional. This element should be read-only and is determined by the
device driver. While this is a change to existing behavior, it doesn't
break backwards-compatibility because it makes the parser less strict.
Signed-off-by: Jonatho
Centos does not have the cppi package, so some code style checks are
skipped. Switch to a fedora image to do the code style checks.
Signed-off-by: Jonathon Jongsma
---
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index bfb66a6
On 6/15/20 12:10 PM, Peter Krempa wrote:
Exercise the now arguably simpler checkpoint deletion code on the
'basic', 'snapshots', and 'synthetic' test data sets.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 18
.../checkpointdelete/basic-current-out
On 6/15/20 12:10 PM, Peter Krempa wrote:
Also rename the helper struct and function.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Mechanical.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
On 6/15/20 12:10 PM, Peter Krempa wrote:
Now that we've switched to the simple handling, the first thing that can
be massively simplified is checkpoint deletion. We now need to only go
through the backing chain and find the appropriately named bitmaps and
delete them, no complex lookups or mergin
On Wed, 2020-06-17 at 17:17 -0400, Laine Stump wrote:
> Until recently, an would automatically be
> assigned model "rtl8139" (the default on x86 machinetypes), which in
> turn would lead to the device being assigned a PCI address on a
> conventional PCI controller (i.e. a pcie-to-pci-bridge). If t
On 6/15/20 12:10 PM, Peter Krempa wrote:
Based on the 'snapshots' example with manual tweaks to introduce
inactive, transient, inconsistent and duplicate bitmaps in various parts
of the chain to excercise detection and new validation code.
exercise
Signed-off-by: Peter Krempa
---
tests/qe
On 6/15/20 12:10 PM, Peter Krempa wrote:
Now that we've updated both the test data and the validator to new
semantics we can start testing again.
Signed-off-by: Peter Krempa
---
tests/qemublocktest.c | 12
1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake
--
Eric Bla
On 6/15/20 12:10 PM, Peter Krempa wrote:
Reject duplicates and other problematic bitmaps according to the new
semantics of bitmap use in libvirt.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 38 +++---
1 file changed, 23 insertions(+), 15 deletions(
Using virKModConfig would not simplify any existing code.
Signed-off-by: Daniel P. Berrangé
---
src/libvirt_private.syms | 1 -
src/util/virkmod.c | 19 ---
src/util/virkmod.h | 1 -
tests/virkmodtest.c | 29 -
4 files changed, 50 de
All callers except for the test suite pass the same value
for the second arg, so it can be removed, simplifying the
code.
Signed-off-by: Daniel P. Berrangé
---
src/util/virfile.c | 2 +-
src/util/virkmod.c | 8 +++-
src/util/virkmod.h | 2 +-
src/util/virpci.c | 2 +-
tests/virkmodt
Daniel P. Berrangé (2):
src: remove redundant arg to virKModLoad
util: remove unused virKModConfig method
src/libvirt_private.syms | 1 -
src/util/virfile.c | 2 +-
src/util/virkmod.c | 27 ++-
src/util/virkmod.h | 3 +-
src/util/virpci.c| 2 +-
tes
On Thu, Jun 18, 2020 at 09:58:35 -0500, Eric Blake wrote:
> On 6/15/20 12:10 PM, Peter Krempa wrote:
> > Use test data which conforms to the new semantics which changed in the
> > previous patch.
>
> Well, a recent patch (the previous patch only touched tests, rather than
> changing semantics)
>
On 17/06/20 23:17, Laine Stump wrote:
[...]
(Note to Paulo - I realize this doesn't describe exactly what happens
on s390, since the default interface model in that case is "virtio"
rather than "rtl8139", and this patch should actually cause no
behavior change on S390. I'm Cc'ing you since yo
On 6/15/20 12:10 PM, Peter Krempa wrote:
Use test data which conforms to the new semantics which changed in the
previous patch.
Well, a recent patch (the previous patch only touched tests, rather than
changing semantics)
The test data was created by the same set of commands as originally i
The XML format used for QEMU capabilities is not required to be
stable across releases, as we invalidate the cache whenever the
libvirt binary changes.
We none the less always try to parse te entire XML file before
we do any validity checks. Thus if we change the format of any
part of the data, or
On Wed, Jun 17, 2020 at 04:18:50PM +0200, Jiri Denemark wrote:
> The features were added to QEMU long ago.
>
> Jiri Denemark (4):
> cpu_map: Request test files update when adding x86 features
> cpu_map: Add missing x86 features in 0x7 CPUID leaf
> cpu_map: Add missing x86 features in 0x8
On Wed, Jun 17, 2020 at 04:18:50PM +0200, Jiri Denemark wrote:
> The features were added to QEMU long ago.
>
> Jiri Denemark (4):
> cpu_map: Request test files update when adding x86 features
> cpu_map: Add missing x86 features in 0x7 CPUID leaf
> cpu_map: Add missing x86 features in 0x8
On 6/15/20 12:10 PM, Peter Krempa wrote:
Use test data which conforms to the new semantics which changed in the
previous patch.
The test data was created by the same set of commands as originally in
commit 9aac9d5bdab039a50de2d8c627b3a1f1578ed471
Signed-off-by: Peter Krempa
---
tests/qemublo
On Thu, 2020-06-18 at 15:55 +0200, Ján Tomko wrote:
> On a Thursday in 2020, Andrea Bolognani wrote:
> > On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote:
> > > Some less commonly used drivers were omitted when we switched
> > > the allocator from a plain VIR_ALLOC to virDomainFSDefNew.
> > >
>
On 6/15/20 12:10 PM, Peter Krempa wrote:
Chaining bitmaps for checkpoints (disabling the active one and creating
a new) severely overcomplicated all operations in regards to bitmaps.
Specifically it requires us re-matching the on-disk state to the
internal metadata and in case of merging during
On Wed, Jun 17, 2020 at 13:21:04 -0500, Eric Blake wrote:
> On 6/15/20 12:09 PM, Peter Krempa wrote:
> > If a disk is not captured by one of the intermediate checkpoints the
> > code would fail, but we can easily calculate the bitmaps to merge
> > correctly by skipping over checkpoints which don't
On a Thursday in 2020, Andrea Bolognani wrote:
On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote:
Some less commonly used drivers were omitted when we switched
the allocator from a plain VIR_ALLOC to virDomainFSDefNew.
Signed-off-by: Ján Tomko
Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220
On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote:
> Some less commonly used drivers were omitted when we switched
> the allocator from a plain VIR_ALLOC to virDomainFSDefNew.
>
> Signed-off-by: Ján Tomko
> Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220
>
> https://bugzilla.redhat.com/show_bug
Introduced by commit 72ab0b6dc8129a388aff260a6e444d48495b0e93 which
added some code depending on libvirt's log format string into
qemuProcessReadLogOutput. This function was deleted by commit
932534e85f34a479c7eac174e997bfd9c85bd22d later.
Drop the comment.
Signed-off-by: Ján Tomko
Closes: https
Some less commonly used drivers were omitted when we switched
the allocator from a plain VIR_ALLOC to virDomainFSDefNew.
Signed-off-by: Ján Tomko
Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220
https://bugzilla.redhat.com/show_bug.cgi?id=1846450
---
src/openvz/openvz_conf.c | 2 +-
src/vbox/vbo
On 6/18/20 1:12 PM, Daniel Henrique Barboza wrote:
Although this can be considered a new feature, from the user
standpoint is more of a QoL improvement.
Suggested-by: Michal Privoznik
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
Review
On 6/18/20 7:34 AM, Michal Privoznik wrote:
On 6/17/20 10:08 PM, Daniel Henrique Barboza wrote:
On 6/17/20 4:19 PM, Michal Privoznik wrote:
On 6/10/20 8:35 PM, Daniel Henrique Barboza wrote:
changes in v2:
- removed patch 5/5
Gitlab link: https://gitlab.com/danielhb/libvirt/-/tree/vcpus_
Although this can be considered a new feature, from the user
standpoint is more of a QoL improvement.
Suggested-by: Michal Privoznik
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index a16903c7c3..20964b94d7 1
On 6/18/20 7:34 AM, Michal Privoznik wrote:
On 6/10/20 8:35 PM, Daniel Henrique Barboza wrote:
These helpers will be used in an auto-fill feature for incomplete
NUMA topologies in the next patch.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/numa_conf.c | 46
On 6/10/20 8:35 PM, Daniel Henrique Barboza wrote:
Libvirt allows the user to define an incomplete NUMA topology, where
the sum of all CPUs in each cell is less than the total of VCPUs.
What ends up happening is that QEMU allocates the non-enumerated CPUs
in the first NUMA node. This behavior is
On 6/17/20 10:08 PM, Daniel Henrique Barboza wrote:
On 6/17/20 4:19 PM, Michal Privoznik wrote:
On 6/10/20 8:35 PM, Daniel Henrique Barboza wrote:
changes in v2:
- removed patch 5/5
Gitlab link: https://gitlab.com/danielhb/libvirt/-/tree/vcpus_numa_v2
v1 link:
https://www.redhat.com/archiv
On 6/10/20 8:35 PM, Daniel Henrique Barboza wrote:
These helpers will be used in an auto-fill feature for incomplete
NUMA topologies in the next patch.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/numa_conf.c | 46
src/conf/numa_conf.h
On Wed, 2020-06-17 at 19:06 +0100, Daniel P. Berrangé wrote:
[...]
> +.script_variables: &script_variables |
> + export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)"
> + export SCRATCH_DIR="/tmp/scratch"
> + export VROOT="$SCRATCH_DIR/vroot"
> + export CCACHE_DIR="$PWD/ccache"
> + export CCACHE_M
On Tue, 16 Jun 2020 at 20:09, John Snow wrote:
> Using an explicit entry path script for sphinx can lead to confusing
> results: If the python binary belongs to a virtual environment, our
> configure script may still select a sphinx script that belongs to the
> system distribution packages.
>
> It
On Wed, Jun 17, 2020 at 05:09:31PM +0200, Paolo Bonzini wrote:
> In order to allow everyone to present at KVM Forum, including people
> who might not have been able to travel to Dublin, we are extending the
> submission deadline for presentations for 6 more weeks!
>
> * CFP Closes: Sunday, August
On Wed, Jun 17, 2020 at 01:35:40PM +0200, Michal Privoznik wrote:
> In a few cases we might set seclabels on a path outside of
> namespaces. For instance, when restoring a domain from a file,
> the file is opened, relabelled and only then the namespace is
> created and the FD is passed to QEMU (see
On Wed, Jun 17, 2020 at 01:35:39PM +0200, Michal Privoznik wrote:
> The function calls virSecurityManagerDomainRestorePathLabel()
> after all.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Wed, Jun 17, 2020 at 01:35:38PM +0200, Michal Privoznik wrote:
> The new name is virSecurityManagerDomainRestorePathLabel().
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Wed, Jun 17, 2020 at 01:35:36PM +0200, Michal Privoznik wrote:
> After previous commit this function is used no more.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Wed, Jun 17, 2020 at 01:35:37PM +0200, Michal Privoznik wrote:
> After previous commit this function is used no more.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Wed, Jun 17, 2020 at 01:35:35PM +0200, Michal Privoznik wrote:
> There are two places within qemu driver that misuse
> qemuSecuritySetSavedStateLabel() to set seclabels on tempfiles
> that are not state files: qemuDomainScreenshot() and
> qemuDomainMemoryPeek(). They are doing so because of lack
The zPCI address validation or autogeneration does not work as
expected in the following scenarios
1. uid = 0 and fid = 0
2. uid = 0 and fid > 0
3. uid = 0 and fid not specified
4. uid not specified and fid > 0
5. 2 zPCI devices with uid > 0 and fid not specified.
This is because of the following
1. Test for auto-generating uids while specifying valid fids
2. Test for auto-generating fids while specifying valid uids
3. Test for parse error while specifying a valid fid and an invalid
uid
4. Test for parse error while specifying two ZPCI devices with same
uid and fid addresses
5. Test f
Let us fix the issues with zPCI address validation and auto-generation
on s390.
Currently, there are two issues with handling the ZPCI address
extension. Firstly, when the uid is to be auto-generated with a
specified fid, .i.e.:
...
...
we expect uid='0x0001' (or the n
Add test with a ZPCI host device and a CCW memballoon device to ensure
that CCW address remains the default address assigned.
Signed-off-by: Boris Fiuczynski
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
.../hostdev-vfio-zpci-ccw-memball
Signed-off-by: Bjoern Walk
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Boris Fiuczynski
---
src/conf/device_conf.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
index 4dbd5c1a..1d06981a 100644
-
The ZPCI device validation is specific to qemu. So, let us move the
ZPCI uid validation out of domain xml parsing into qemu domain device
validation.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/conf/device_conf.c | 3 ---
src/lib
On 6/17/20 7:06 PM, Laine Stump wrote:
On 6/17/20 12:55 PM, Boris Fiuczynski wrote:
Hi Laine,
do you plan to push this patch?
Already did, about an hour ago.
Thanks and sorry I missed it.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development G
66 matches
Mail list logo
