Availability of libvirt-6.5.0 Release Candidate 2

2020-06-30 Thread Daniel Veillard
It is tagged in git, I have pushed the signed source tarball and rpm to the usual place: https://libvirt.org/sources/ No issues on my side, if everything continue to look good then we can push the release on Thursday, in the meantime please have some testing, thanks, Daniel -- Dan

[PATCH 1/1] migration.html.in: fix 'Offline migration' description

2020-06-30 Thread Daniel Henrique Barboza
'transfers inactive the definition of a domain' seems odd. Signed-off-by: Daniel Henrique Barboza --- docs/migration.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migration.html.in b/docs/migration.html.in index 355f0e89af..e95ee9de6f 100644 --- a/docs/migratio

Re: [PATCH 2/2] qemu_capabilities.c: drop 'kvm_pr' support for non-Power8 hosts

2020-06-30 Thread Daniel Henrique Barboza
On 6/30/20 2:35 PM, Andrea Bolognani wrote: On Fri, 2020-06-19 at 18:04 -0300, Daniel Henrique Barboza wrote: +static void +virQEMUCapsSetPPC64KVMState(virQEMUCapsPtr qemuCaps, virArch hostArch) +{ +g_autoptr(virCPUDef) hostCPU = virCPUProbeHost(hostArch); + +/* At this moment, PPC64

Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

2020-06-30 Thread Daniel Henrique Barboza
Hi Shalini, On 6/30/20 12:52 PM, Shalini Chellathurai Saroja wrote: Hi Daniel, Sorry for the incorrect code. Thank you for identifying and fixing it:-) Glad I could help :) I would like to know, how did you identify the error?, It was by chance. I rebased the code to master before posti

Re: [PATCH 2/2] qemu_capabilities.c: drop 'kvm_pr' support for non-Power8 hosts

2020-06-30 Thread Andrea Bolognani
On Fri, 2020-06-19 at 18:04 -0300, Daniel Henrique Barboza wrote: > +static void > +virQEMUCapsSetPPC64KVMState(virQEMUCapsPtr qemuCaps, virArch hostArch) > +{ > +g_autoptr(virCPUDef) hostCPU = virCPUProbeHost(hostArch); > + > +/* At this moment, PPC64 has two KVM modules: kvm_hv and kvm_pr

Re: Re: [RFC 05/21] util: Add two helper functions virXMLChildNode and virXMLChildNodeSet

2020-06-30 Thread Daniel P . Berrangé
On Wed, Jul 01, 2020 at 12:07:13AM +0800, Shi Lei wrote: > >On Wed, Jun 10, 2020 at 09:20:33AM +0800, Shi Lei wrote: > >> Add these helper functions to parse xml without using xmlXPathContext. > >> > >> Signed-off-by: Shi Lei > >> --- > >>  src/util/virxml.c | 57 ++

[libvirt PATCH v3 1/1] cirrus: Generate jobs dynamically

2020-06-30 Thread Andrea Bolognani
Instead of having static job definitions for FreeBSD and macOS, use a generic template for both and fill in the details that are actually different, such as the list of packages to install, in the GitLab CI job, right before calling cirrus-run. The target-specific information are provided by lcito

[libvirt PATCH v3 0/1] cirrus: Add templates and refresh script

2020-06-30 Thread Andrea Bolognani
This makes the Cirrus CI configurations as maintainable as the Dockerfiles, by shifting the responsability of keeping the list of dependencies and other details up to date to lcitool. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/161289292 For the refresh script to work, your

Re: Re: [RFC 00/21] RFC: Generate parsexml/formatbuf functions based on directives

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:28AM +0800, Shi Lei wrote: >> >> Last RFC: >> [https://www.redhat.com/archives/libvir-list/2020-April/msg00970.html] >> In last RFC, I suggested we can generate object-model code based on relax-ng >> files and Daniel gave it some comments. >> >> Follow the suggestion

Re: Re: [RFC 02/21] maint: Check libclang and its python3 binding

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:30AM +0800, Shi Lei wrote: >> Make sure libclang and its python3 binding have been installed. >> >> Signed-off-by: Shi Lei >> --- >>  configure.ac | 12 >>  1 file changed, 12 insertions(+) >> >> diff --git a/configure.ac b/configure.ac >> index 6c8ac2f..

Re: Re: [RFC 05/21] util: Add two helper functions virXMLChildNode and virXMLChildNodeSet

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:33AM +0800, Shi Lei wrote: >> Add these helper functions to parse xml without using xmlXPathContext. >> >> Signed-off-by: Shi Lei >> --- >>  src/util/virxml.c | 57 +++ >>  src/util/virxml.h |  3 +++ >>  2 files changed, 60

Re: Re: [RFC 04/21] maint: Add helper macro VIR_USED

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:32AM +0800, Shi Lei wrote: >> The macro VIR_USED is used in generated parse/format functions to >> avoid args-unused warnings. > >I mentioned in the earlier patch that we can just use G_GNUC_UNUSED >on any parameters which might be unused. It doesn't matter if they >r

Re: Re: [RFC 08/21] conf: Generate virNetworkDNSTxtDefFormatBuf

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:36AM +0800, Shi Lei wrote: >> Signed-off-by: Shi Lei >> --- >>  src/conf/network_conf.c | 4 ++-- >>  src/conf/network_conf.h | 2 +- >>  2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c >> index 964a

Re: Re: [RFC 07/21] conf: Replace virNetworkDNSTxtDefParseXML(hardcoded) with namesake(generated)

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:35AM +0800, Shi Lei wrote: >> Signed-off-by: Shi Lei >> --- >>  po/POTFILES.in   |  1 + >>  src/conf/Makefile.inc.am |  2 ++ >>  src/conf/network_conf.c  | 47 ++-- >>  src/conf/network_conf.h  |  8 --- >>  4 files chang

Re: Re: [RFC 11/21] conf: Generate virNetworkDNSSrvDefFormatBuf

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:39AM +0800, Shi Lei wrote: >> Signed-off-by: Shi Lei >> --- >>  src/conf/network_conf.c | 18 ++ >>  src/conf/network_conf.h |  4 ++-- >>  2 files changed, 4 insertions(+), 18 deletions(-) >> >> diff --git a/src/conf/network_conf.c b/src/conf/network_c

Re: Re: [RFC 01/21] build-aux: Add a tool to generate xml parse/format functions

2020-06-30 Thread Shi Lei
>On Wed, Jun 10, 2020 at 09:20:29AM +0800, Shi Lei wrote: >> This tool is used to generate parsexml/formatbuf functions for structs. >> It is based on libclang and its python-binding. >> Some directives (such as genparse, xmlattr, etc.) need to be added on >> the declarations of structs to direct t

Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

2020-06-30 Thread Shalini Chellathurai Saroja
Hi Daniel, Sorry for the incorrect code. Thank you for identifying and fixing it:-) I would like to know, how did you identify the error?, Is it possible to check for internal errors with the help of unit tests? Your answer would help me able to identify any incorrect code before sending the pa

Re: [libvirt PATCH v2 1/1] cirrus: Generate jobs dynamically

2020-06-30 Thread Andrea Bolognani
On Tue, 2020-06-30 at 16:01 +0200, Erik Skultety wrote: > On Mon, Jun 29, 2020 at 08:51:51PM +0200, Andrea Bolognani wrote: > > +# Note that the $PATH environment variable has to be treated with > > +# special care, because we can't just override it at the GitLab CI job > > +# definition level or w

Re: [libvirt PATCH v2 1/1] cirrus: Generate jobs dynamically

2020-06-30 Thread Erik Skultety
On Mon, Jun 29, 2020 at 08:51:51PM +0200, Andrea Bolognani wrote: > Instead of having static job definitions for FreeBSD and macOS, > use a generic template for both and fill in the details that are > actually different, such as the list of packages to install, in > the GitLab CI job, right before

Re: [libvirt PATCH] tools: fix misleading comments about command names

2020-06-30 Thread Erik Skultety
On Tue, Jun 30, 2020 at 12:21:46PM +0100, Daniel P. Berrangé wrote: > The srv-XXX commands were renamed to server-XXX, with the old > name being a undocumented back compat alias only. > > Signed-off-by: Daniel P. Berrangé > --- Reviewed-by: Erik Skultety

[libvirt PATCH] tools: fix misleading comments about command names

2020-06-30 Thread Daniel P . Berrangé
The srv-XXX commands were renamed to server-XXX, with the old name being a undocumented back compat alias only. Signed-off-by: Daniel P. Berrangé --- tools/virt-admin.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/tools/virt-adm