[PATCH] conf: Remove superfluous breaks

2020-07-16 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang --- src/conf/domain_conf.c | 6 -- src/conf/network_conf.c| 12 src/conf/nwfilter_params.c | 4 3 files changed, 22 deletions(

[PATCH] qemu: Remove superfluous breaks

2020-07-16 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang --- src/qemu/qemu_firmware.c | 1 - src/qemu/qemu_hostdev.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_fir

[PATCH] security: Remove the superfluous break

2020-07-16 Thread Yi Wang
From: Liao Pingfang Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang --- src/security/security_apparmor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c in

Re: [PATCH] qemu: pre-create the dbus directory in qemuStateInitialize

2020-07-16 Thread Bihong Yu
Can anyone help me review the code? On 2020/7/14 15:53, Bihong Yu wrote: >>From 187323ce736dcd9b1a177d552630b0c6859a4798 Mon Sep 17 00:00:00 2001 > From: Bihong Yu > Date: Tue, 14 Jul 2020 15:44:05 +0800 > Subject: [PATCH] qemu: pre-create the dbus directory in qemuStateInitialize > > There are

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-16 Thread Masayoshi Mizuma
Thank you for your review. On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake wrote: > On 7/7/20 2:12 AM, Peter Krempa wrote: > > > You can install a qcow2 overlay on top of a raw file too. IMO the > > implications of using allow that. > > > > As said above I'd strongly prefer if the overlay

[libvirt PATCH 16/16] virsh: add "nodedev-start" command

2020-07-16 Thread Jonathon Jongsma
This virsh command maps to virNodeDeviceCreate(), which starts a node device that has been previously defined by virNodeDeviceDefineXML(). This is only supported for mediated devices. Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 61 +++ 1 fi

[libvirt PATCH 15/16] api: add virNodeDeviceCreate()

2020-07-16 Thread Jonathon Jongsma
This new API function provides a way to start a persistently-defined mediate device that was defined by virNodeDeviceDefineXML() (or one that was defined externally via mdevctl) Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h| 2 + src/driver-nodedev.h

[libvirt PATCH 09/16] nodedev: add an mdevctl thread

2020-07-16 Thread Jonathon Jongsma
We need to peridocally query mdevctl for changes to device definitions since an administrator can define new devices with mdevctl outside of libvirt. In order to do this, a new thread is created to handle the querying. In the future, mdevctl may add a way to signal device add / remove via events,

[libvirt PATCH 07/16] nodedev: add mdevctl devices to node device list

2020-07-16 Thread Jonathon Jongsma
At startup, query devices that are defined by 'mdevctl' and add them to the node device list. This adds a complication: we now have two potential sources of information for a node device: - udev for all devices and for activated mediated devices - mdevctl for persistent mediated devices Unfortu

[libvirt PATCH 14/16] virsh: add nodedev-undefine command

2020-07-16 Thread Jonathon Jongsma
Add a virsh command that maps to virNodeDeviceUndefine(). Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 57f987a81e..2f984e8738 100644 -

[libvirt PATCH 11/16] virsh: add nodedev-define command

2020-07-16 Thread Jonathon Jongsma
Add a virsh command that maps to virNodeDeviceDefineXML(). Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index 75542530da..c02b79a349 100644

[libvirt PATCH 05/16] nodedev: add ability to list and parse defined mdevs

2020-07-16 Thread Jonathon Jongsma
This adds some internal API to query for persistent mediated devices that are defined by mdevctl. Following commits will make use of this information. This just provides the infrastructure and tests for this feature. One test verifies that we are executing mdevctl with the proper arguments, and oth

[libvirt PATCH 03/16] nodedev: Add ability to filter by active state

2020-07-16 Thread Jonathon Jongsma
Add two flag values for virConnectListAllNodeDevices() so that we can list only node devices that are active or inactive. Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h| 9 ++--- src/conf/node_device_conf.h | 8 src/conf/virnodedeviceobj.c

[libvirt PATCH 01/16] tests: remove extra trailing semicolon

2020-07-16 Thread Jonathon Jongsma
The macro should not have a trailing semicolon so that when the macro is used, the user can add a semicolon themselves. Signed-off-by: Jonathon Jongsma --- tests/nodedevmdevctltest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/nodedevmdevctltest.c b/tests/nodedevmde

[libvirt PATCH 12/16] api: add virNodeDeviceUndefine()

2020-07-16 Thread Jonathon Jongsma
This interface allows you to undefine a persistently defined (but inactive) mediated devices. It is implemented via 'mdevctl' Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h | 2 + src/driver-nodedev.h | 4 ++ src/libvirt-nodedev.c

[libvirt PATCH 13/16] virsh: Factor out function to find node device

2020-07-16 Thread Jonathon Jongsma
Several functions accept providing a node device by name or by wwnn,wwpn pair. Extract the logic to do this into a function that can be used by both callers. Signed-off-by: Jonathon Jongsma --- tools/virsh-nodedev.c | 58 +-- 1 file changed, 28 insertions(

[libvirt PATCH 10/16] api: add virNodeDeviceDefineXML()

2020-07-16 Thread Jonathon Jongsma
With mediated devices, we can now define persistent node devices that can be started and stopped. In order to take advantage of this, we need an API to define new node devices. Signed-off-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h | 4 + src/driver-nodedev.h

[libvirt PATCH 04/16] virsh: Add --active, --inactive, --all to nodedev-list

2020-07-16 Thread Jonathon Jongsma
Now that we can filter active and inactive node devices in virConnectListAllNodeDevices(), add these switches to the virsh command. Eventual output (once everything is hooked up): virsh # nodedev-list --inactive --cap mdev mdev_07d8b8b0_7e04_4c0f_97ed_9214ce12723c mdev_927c040f_ae7d_4

[libvirt PATCH 02/16] nodedev: introduce concept of 'active' node devices

2020-07-16 Thread Jonathon Jongsma
we will be able to define mediated devices that can be started or stopped, so we need to be able to indicate whether the device is active or not, similar to other resources (storage pools, domains, etc.) Signed-off-by: Jonathon Jongsma --- src/conf/virnodedeviceobj.c| 14 ++

[libvirt PATCH 08/16] nodedev: handle mdevs that disappear from mdevctl

2020-07-16 Thread Jonathon Jongsma
mdevctl does not currently provide any events when the list of defined devices changes, so we will need to poll mdevctl for the list of defined devices periodically. When a mediated device no longer exists from one iteration to the next, we need to treat it as an "undefine" event. When we get such

[libvirt PATCH 06/16] nodedev: add STOPPED/STARTED lifecycle events

2020-07-16 Thread Jonathon Jongsma
Since a mediated device can be persistently defined by the mdevctl backend, we need additional lifecycle events beyond CREATED/DELETED to indicate that e.g. the device has been stopped but the device definition still exists. Signed-off-by: Jonathon Jongsma --- examples/c/misc/event-test.c

[libvirt PATCH 00/16] Add support for persistent mediated devices

2020-07-16 Thread Jonathon Jongsma
This patch series follows the previously-merged series which added support for transient mediated devices. This series expands mdev support to include persistent device definitions. Again, it relies on mdevctl as the backend. It follows the common libvirt pattern of APIs by adding the following ne

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 08:36:42PM +0200, Jiri Denemark wrote: > On Thu, Jul 16, 2020 at 15:47:48 +0200, Pavel Hrdina wrote: > > On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > > Patches are available in m

Re: [libvirt PATCH 2/3] qemu: Do not set default value //cpu/@migratable for running domains

2020-07-16 Thread Jiri Denemark
On Thu, Jul 16, 2020 at 22:08:48 +0200, Jiri Denemark wrote: > Commit v6.4.0-61-g201bd5db63 started to fill the default value for > //cpu/@migratable attribute according to QEMU support. However, active > domains either have the migratable attribute already set or the > capabilities we use for chec

[libvirt PATCH 2/3] qemu: Do not set default value //cpu/@migratable for running domains

2020-07-16 Thread Jiri Denemark
Commit v6.4.0-61-g201bd5db63 started to fill the default value for //cpu/@migratable attribute according to QEMU support. However, active domains either have the migratable attribute already set or the capabilities we use for checking the QEMU support were created by older libvirt which didn't prob

[libvirt PATCH 1/3] qemu_monitor: Add API for checking CPU migratable property

2020-07-16 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor.c | 18 ++ src/qemu/qemu_monitor.h | 4 src/qemu/qemu_monitor_json.c | 27 +++ src/qemu/qemu_monitor_json.h | 4 4 files changed, 53 insertions(+) diff --git a/src/qemu/qemu_monit

[libvirt PATCH 3/3] qemu: Properly set //cpu/@migratable default value for running domains

2020-07-16 Thread Jiri Denemark
Since active domains which do not have the attribute already set were not started by libvirt that probed for CPU migratable property, we need to check this property on reconnect and update the domain definition accordingly. https://bugzilla.redhat.com/show_bug.cgi?id=1857967 Reported-by: Mark Mie

[libvirt PATCH 0/3] Fix migration with host-passthrough CPU

2020-07-16 Thread Jiri Denemark
Fixes a regression in libvirt 6.5.0 caused by commit 201bd5db63. See patches 2 and 3 for details. Jiri Denemark (3): qemu_monitor: Add API for checking CPU migratable property qemu: Do not set //cpu/@migratable for running domains in post-parse qemu: Properly set //cpu/@migratable default va

[libvirt PATCH 2/3] qemu: Do not set //cpu/@migratable for running domains in post-parse

2020-07-16 Thread Jiri Denemark
Commit v6.4.0-61-g201bd5db63 started to fill the default value for //cpu/@migratable attribute according to QEMU support. However, active domains either have the migratable attribute already set or the capabilities we use for checking the QEMU support were created by older libvirt which didn't prob

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Jiri Denemark
On Thu, Jul 16, 2020 at 15:47:48 +0200, Pavel Hrdina wrote: > On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > > Patches are available in my Gitlab repo as well: > > > > > > git clone -b meson https://git

[PATCH 2/2] qemu: allow configuring mem-path for ivshmem-plain device

2020-07-16 Thread Wang Xin
The shared memory path is generated by shmem name as default, however, we may need to change it to avoid filename conflict when VM migrate to other host. Signed-off-by: Yang Hang Signed-off-by: Wang Xin diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 09d4ad3e96.

[PATCH 1/2] qemu: add support for shmem-{plain, doorbell} role

2020-07-16 Thread Wang Xin
Role(master or peer) controls how the domain behaves on migration. For more details about migration with ivshmem, see https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD It's a optional attribute in libvirt, and qemu will choose default role for ivshmem device if the us

Re: [libvirt PATCH] manpages/virsh: Clarify the meaning of the '--current' flag

2020-07-16 Thread Peter Krempa
On Thu, Jul 16, 2020 at 17:45:21 +0200, Kashyap Chamarthy wrote: > Currently the documentation says: > > "If *--current* is specified, affect the current guest state." > > It's not entirely clear what states can "current" imply. E.g. `virsh > detach-device --current [...]` — does this affec

[libvirt PATCH] manpages/virsh: Clarify the meaning of the '--current' flag

2020-07-16 Thread Kashyap Chamarthy
Currently the documentation says: "If *--current* is specified, affect the current guest state." It's not entirely clear what states can "current" imply. E.g. `virsh detach-device --current [...]` — does this affect the live guest state or offline state? Answer: It affects the "current" st

Re: [libvirt PATCH 004/351] meson: drop loader_nvram build option

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 03:52:22PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 04:23:31PM +0200, Pavel Hrdina wrote: > > On Thu, Jul 16, 2020 at 04:12:31PM +0200, Ján Tomko wrote: > > > On a Thursday in 2020, Pavel Hrdina wrote: > > > > With the switch to meson it should be safe to d

Re: [libvirt PATCH 004/351] meson: drop loader_nvram build option

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 04:23:31PM +0200, Pavel Hrdina wrote: > On Thu, Jul 16, 2020 at 04:12:31PM +0200, Ján Tomko wrote: > > On a Thursday in 2020, Pavel Hrdina wrote: > > > With the switch to meson it should be safe to drop this build option. > > > We don't have any deprecation policy so let's t

[PATCH 0/5] qemu: Fix handling of bitmaps for active layer block commit and block copy

2020-07-16 Thread Peter Krempa
See patch 3 for explanation. Peter Krempa (5): qemu: blockjob: Don't base bitmap handling of active-layer block commit on QEMU_CAPS_BLOCKDEV_REOPEN qemu: blockjob: Actually delete temporary bitmap on failed active commit qemu: block: Remove 'active-write' bitmap even if there are no

[PATCH 2/5] qemu: blockjob: Actually delete temporary bitmap on failed active commit

2020-07-16 Thread Peter Krempa
Commit 20a7abc2d2d tried to delete the possibly leftover bitmap but neglected to call the actual monitor to do so. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_

[PATCH 5/5] qemuDomainBlockPivot: Ignore failures of creating active layer bitmap

2020-07-16 Thread Peter Krempa
Ignore errors from creating "libvirt-tmp-activewrite" bitmap. This prevents failures of finishing blockjobs if the bitmap already exists. Note that if the bitmap exists, the worst case that can happen is that more bits are marked as dirty in the resulting merge. Signed-off-by: Peter Krempa ---

[PATCH 3/5] qemu: block: Remove 'active-write' bitmap even if there are no bitmaps to merge

2020-07-16 Thread Peter Krempa
The 'libvirt-tmp-activewrite' bitmap is added during the 'pivot' operation of block copy and active layer block commit operations regardless of whether there are any bitmaps to merge, but was not removed unless a bitmap was merged. This meant that subsequent attempts to merge into the same image wo

Re: [libvirt PATCH 004/351] meson: drop loader_nvram build option

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 04:12:31PM +0200, Ján Tomko wrote: > On a Thursday in 2020, Pavel Hrdina wrote: > > With the switch to meson it should be safe to drop this build option. > > We don't have any deprecation policy so let's take the opportunity when > > everything will break current users. > >

Re: [libvirt PATCH 003/351] meson: drop driver_module configure argument

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 02:55:47PM +0200, Ján Tomko wrote: > On a Thursday in 2020, Pavel Hrdina wrote: > > Building without driver_module is not supported anymore so drop the > > option before switching to meson as we will not introduce it there. > > > > Signed-off-by: Pavel Hrdina > > --- > > c

[PATCH 4/5] qemuDomainBlockPivot: Rename 'actions' to 'bitmapactions'

2020-07-16 Thread Peter Krempa
There are two possible 'transaction' command arguments in the function. Rename 'actions' as they deal with creating bitmaps only. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src

[PATCH 1/5] qemu: blockjob: Don't base bitmap handling of active-layer block commit on QEMU_CAPS_BLOCKDEV_REOPEN

2020-07-16 Thread Peter Krempa
The handler finalizing the active layer block commit doesn't actually reopen the file for active layer block commit, so the comment and check are invalid. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 3 ++- src/qemu/qemu_driver.c | 6 +- 2 files changed, 3 insertions(+), 6 de

Re: [libvirt PATCH 004/351] meson: drop loader_nvram build option

2020-07-16 Thread Ján Tomko
On a Thursday in 2020, Pavel Hrdina wrote: With the switch to meson it should be safe to drop this build option. We don't have any deprecation policy so let's take the opportunity when everything will break current users. The commit message does not mention that this option is deprecated or wh

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > Patches are available in my Gitlab repo as well: > > > > git clone -b meson https://gitlab.com/phrdina/libvirt.git > > > > and link to Giltab pipeline: > >

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Pavel Hrdina
On Thu, Jul 16, 2020 at 01:59:00PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > > So I was finally able to produce the patches to port libvirt to Meson. > > Obviously, it is a lot of changes. It might look that some of the > > patches could be s

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > Patches are available in my Gitlab repo as well: > > git clone -b meson https://gitlab.com/phrdina/libvirt.git > > and link to Giltab pipeline: > > https://gitlab.com/phrdina/libvirt/-/pipelines/167276632 > > The pipeline i

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > So I was finally able to produce the patches to port libvirt to Meson. > Obviously, it is a lot of changes. It might look that some of the > patches could be squashed together but I would rather have it as > separated as possible to ma

Re: [libvirt PATCH 003/351] meson: drop driver_module configure argument

2020-07-16 Thread Ján Tomko
On a Thursday in 2020, Pavel Hrdina wrote: Building without driver_module is not supported anymore so drop the option before switching to meson as we will not introduce it there. Signed-off-by: Pavel Hrdina --- configure.ac | 1 - m4/virt-driver-modules.m4 | 17 + 2

Re: [libvirt PATCH 002/351] meson: remove automake specific directives

2020-07-16 Thread Ján Tomko
On a Thursday in 2020, Pavel Hrdina wrote: EXTRA_DIST is not relevant because meson makes a git copy when creating dist archive so everything tracked by git is part of dist tarball. BUILD_SOURCES is not relevant as all dependencies should be explicitly tracked. The remaining ones are not conver

Re: [PATCH 09/11] virDomainHostdevSubsysSCSIiSCSIDefParseXML: Use XPath to fetch elements

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Conver the code to the new approach which uses XPath to fetch known elements rather than looping through all XML children. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 51 -- 1 file changed, 19 insertio

Re: [PATCH 07/11] virDomainHostdevDefFormatSubsys: Split out formatting of mdev subsystem

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Similarly to previous commit split out formatting of the mdev subsystem related stuff. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 42 +++--- 1 file changed, 15 insertions(+), 27 deletions(-) diff --git a

Re: [PATCH 08/11] virDomainHostdevSubsysSCSIDefParseXML: Use typecasted switch

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Use a switch statement which will not be omitted when adding potential new types. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.as

Re: [PATCH 06/11] virDomainHostdevDefFormatSubsys: Split out formatting of vHBA subsystem

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Similarly to previous commit split out formatting of the vHBA subsystem related stuff. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko

Re: [PATCH 05/11] virDomainHostdevDefFormatSubsysSCSI: Avoid ternary operator when formatting address

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Split up formatting of the '' element rather that trying to optimize it with formatting string hacks. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Ja

Re: [PATCH 04/11] virDomainHostdevDefFormatSubsys: Split out formatting of SCSI subsystem

2020-07-16 Thread Ján Tomko
On a Tuesday in 2020, Peter Krempa wrote: Similarly to previous commit split out formatting of the SCSI subsystem related stuff. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 83 -- 1 file changed, 47 insertions(+), 36 deletions(-) Reviewed-b

Re: [GSoC][PATCH v4 4/4] qemu_domainjob: introduce `privateData` for `qemuDomainJobInfo`

2020-07-16 Thread Prathamesh Chavan
On Tue, Jul 14, 2020 at 10:25 PM Michal Privoznik wrote: > > On 7/14/20 5:14 PM, Prathamesh Chavan wrote: > > Currently, domainJobInfo also uses "stats" as one of the job specific > > parameters. To remove this dependency, a privateData structure is > > introduced. > > > > The plan is to even have

[GSoC][PATCH v5] qemu_domainjob: introduce `privateData` for `qemuDomainJob`

2020-07-16 Thread Prathamesh Chavan
To remove dependecy of `qemuDomainJob` on job specific paramters, a `privateData` pointer is introduced. To handle it, structure of callback functions is also introduced. Signed-off-by: Prathamesh Chavan --- Previous version of this patch can be found here[1]. This patch mainly improvises on the

Re: kvm-hint-dedicated requires host CPU passthrough?

2020-07-16 Thread Stefan Hajnoczi
On Mon, Jun 29, 2020 at 01:58:13PM +0200, Wim ten Have wrote: > Hi Stefan, sorry for my very late response as I was temporarily out > and unfortunately missed this email thread. > > For your question (remark), yes, you're right. This feature should > not apply to specific scenario. > Something

[libvirt PATCH 245/351] meson: src/access: add check-aclperms test

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am| 7 +-- src/access/meson.build | 7 +++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 3b5195f2266..d697114d7e8 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -86,13 +86,

[libvirt PATCH 292/351] meson: tests: add libxl specific tests

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- tests/Makefile.am | 30 -- tests/meson.build | 8 2 files changed, 8 insertions(+), 30 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index a927c0cb2fd..ec57dd5543b 100644 --- a/tests/Makefile.am +++ b/tests/M

[libvirt PATCH 195/351] meson: src: build libvirt_storage_backend_vstorage.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/storage/Makefile.inc.am | 23 --- src/storage/meson.build | 14 ++ 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index 94a471eb0c0..45cbe476d22 1006

[libvirt PATCH 250/351] meson: src: add check-admin-symsorting test

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/admin/Makefile.inc.am | 8 +--- src/admin/meson.build | 6 +- src/meson.build | 11 +++ 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index a2af10a158d..9d6f

[libvirt PATCH 199/351] meson: src: build virtinterfaced daemon binary

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/interface/Makefile.inc.am | 11 --- src/interface/meson.build | 8 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 9a56e0b4e0f..7d1d8ed2c4c 100644 --- a/sr

[libvirt PATCH 278/351] meson: introduce tests directory

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- meson.build | 2 ++ tests/Makefile.am | 32 tests/meson.build | 30 ++ 3 files changed, 32 insertions(+), 32 deletions(-) create mode 100644 tests/meson.build diff --git a/meson.build b/meson.bui

[libvirt PATCH 335/351] meson: docs/manpages: install man pages

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- docs/Makefile.am | 120 - docs/manpages/{index.rst => index.rst.in} | 0 .../{libvirtd.rst => libvirtd.rst.in} | 0 docs/manpages/meson.build | 126 ++ docs/manpages/{v

[libvirt PATCH 346/351] meson: remove unused bits from GNUmakefile

2020-07-16 Thread Pavel Hrdina
None of the directives from GNUmakefile are converted to meson as they don't make any sense. Signed-off-by: Pavel Hrdina --- GNUmakefile | 74 configure.ac | 7 - 2 files changed, 81 deletions(-) delete mode 100644 GNUmakefile diff --g

[libvirt PATCH 148/351] meson: src: build libvirt_driver.a static library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am | 41 - src/meson.build | 35 +++ 2 files changed, 35 insertions(+), 41 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b948ac47a6d..50807ee7491 100644 --- a/

[libvirt PATCH 178/351] meson: src: build libvirt_driver_vbox.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/vbox/Makefile.inc.am | 10 -- src/vbox/meson.build | 10 ++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 19223b1..e61c3df40d6 100644 --- a/src/vbox/Makefile.in

[libvirt PATCH 225/351] meson: src: generate libvirt daemon conf and augeas files

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am | 5 --- src/bhyve/Makefile.inc.am | 30 - src/bhyve/meson.build | 5 +++ src/interface/Makefile.inc.am | 27 src/interface/meson.build | 5 +++ src/libxl/Makefile.inc.am | 27

[libvirt PATCH 177/351] meson: src: build libvirt_driver_secret.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/meson.build| 1 + src/secret/Makefile.inc.am | 21 - src/secret/meson.build | 18 ++ 3 files changed, 19 insertions(+), 21 deletions(-) create mode 100644 src/secret/meson.build diff --git a/src/meson.build

[libvirt PATCH 183/351] meson: src: build libvirt_storage_backedn_fs.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/storage/Makefile.inc.am | 19 --- src/storage/meson.build | 14 ++ 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index c30743a1b48..15de3311c41 100644 -

[libvirt PATCH 290/351] meson: tests: add ESX specific tests

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/esx/meson.build | 2 ++ tests/Makefile.am | 14 -- tests/meson.build | 6 ++ 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/esx/meson.build b/src/esx/meson.build index 1718411d759..469c2044c63 100644 --- a/src/esx/meso

[libvirt PATCH 020/351] meson: add manywarnings

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- m4/virt-manywarnings.m4 | 339 meson.build | 192 +++ 2 files changed, 192 insertions(+), 339 deletions(-) delete mode 100644 m4/virt-manywarnings.m4 diff --git a/m4/virt-manywarnings.m4 b/m

[libvirt PATCH 004/351] meson: drop loader_nvram build option

2020-07-16 Thread Pavel Hrdina
With the switch to meson it should be safe to drop this build option. We don't have any deprecation policy so let's take the opportunity when everything will break current users. Signed-off-by: Pavel Hrdina --- configure.ac| 3 --- m4/virt-loader-nvram.m4 | 49 --

[libvirt PATCH 040/351] meson: add capng build dependency

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 3 --- m4/virt-capng.m4 | 30 -- meson.build | 6 ++ meson_options.txt | 1 + 4 files changed, 7 insertions(+), 33 deletions(-) delete mode 100644 m4/virt-capng.m4 diff --git a/configure.ac b/configure

[libvirt PATCH 158/351] meson: src: build libvirt_driver_libxl_impl.a static library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/libxl/Makefile.inc.am | 39 --- src/libxl/meson.build | 29 + src/meson.build | 1 + 3 files changed, 30 insertions(+), 39 deletions(-) create mode 100644 src/libxl/meson.build dif

[libvirt PATCH 157/351] meson: src: build libvirt_driver_bhyve_impl.a static library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/bhyve/Makefile.inc.am | 34 -- src/bhyve/meson.build | 28 src/meson.build | 1 + 3 files changed, 29 insertions(+), 34 deletions(-) create mode 100644 src/bhyve/meson.build diff --gi

[libvirt PATCH 248/351] meson: src: add check*protocol tests

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- meson.build | 1 + scripts/check-remote-protocol.py | 75 +++- src/Makefile.am | 61 -- src/admin/meson.build| 7 +++ src/locking/meson.build | 7 +++

[libvirt PATCH 059/351] meson: add libssh2 build dependency

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 4 m4/virt-ssh2.m4 | 30 -- meson.build | 11 +++ meson_options.txt | 1 + 4 files changed, 12 insertions(+), 34 deletions(-) delete mode 100644 m4/virt-ssh2.m4 diff --git a/configure.ac b/con

[libvirt PATCH 173/351] meson: src: build libvirt_driver_network.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/network/Makefile.inc.am | 13 - src/network/meson.build | 14 ++ 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index c93b2e693d0..523ae453797 100644 --- a/s

[libvirt PATCH 067/351] meson: add polkit build option

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 3 --- m4/virt-polkit.m4 | 62 --- meson.build | 13 ++ meson_options.txt | 1 + 4 files changed, 14 insertions(+), 65 deletions(-) delete mode 100644 m4/virt-polkit.m4 diff --git a/c

[libvirt PATCH 273/351] meson: tools: build libnss_libvirt_guest.so shared_library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- tools/Makefile.am | 23 --- tools/nss/meson.build | 20 2 files changed, 20 insertions(+), 23 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index d33e5a20885..4cb0a07afb8 100644 --- a/tools/Makefile.am

[libvirt PATCH 180/351] meson: src: build lockd.so shared module

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/locking/Makefile.inc.am | 13 - src/locking/meson.build | 17 + 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index b8eac29d242..5b00f5a0c9e 100644 ---

[libvirt PATCH 244/351] meson: src: add check-aclrules test

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am | 17 - src/bhyve/Makefile.inc.am | 3 --- src/bhyve/meson.build | 1 + src/interface/Makefile.inc.am | 4 src/interface/meson.build | 1 + src/libxl/Makefile.inc.am | 3 --- sr

[libvirt PATCH 134/351] meson: src: build libvirt_driver_admin.a static lib

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/admin/Makefile.inc.am | 36 src/admin/meson.build | 50 +++ src/meson.build | 2 ++ src/rpc/meson.build | 5 4 files changed, 57 insertions(+), 36 deletions(-) create m

[libvirt PATCH 263/351] meson: tools: generate virt-sanlock-cleanup script

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- tools/Makefile.am | 9 - tools/meson.build | 11 +++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index ee7f8b5b1ab..94ea385354e 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -26,

[libvirt PATCH 305/351] meson: tests: add vbox specific tests

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- tests/Makefile.am | 12 tests/meson.build | 6 ++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index b696d3434fe..ab45bdd6da4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -20,10

[libvirt PATCH 140/351] meson: src: build libvirt_hypervisor.a static library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am| 1 - src/hypervisor/Makefile.inc.am | 20 src/hypervisor/meson.build | 21 + src/meson.build| 1 + 4 files changed, 22 insertions(+), 21 deletions(-) delete mode 100644

[libvirt PATCH 348/351] meson: now we can drop all autoconf related gitignore lines

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- .gitignore | 21 - 1 file changed, 21 deletions(-) diff --git a/.gitignore b/.gitignore index 6c167e423b1..405dacb7776 100644 --- a/.gitignore +++ b/.gitignore @@ -8,27 +8,6 @@ .#* *~ -# autotools related ignores -!/m4/virt-*.m4 -*.cov -/AU

[libvirt PATCH 200/351] meson: src: build virtxend daemon binary

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/libxl/Makefile.inc.am | 11 --- src/libxl/meson.build | 8 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 35e6b3bbcd9..051b6c55bd9 100644 --- a/src/libxl/Makefile

[libvirt PATCH 222/351] meson: src: add support for installing libvirt conf and augeas files

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/Makefile.am| 5 -- src/meson.build| 103 + src/remote/meson.build | 26 +++ 3 files changed, 129 insertions(+), 5 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 99bb71e6a03..

[libvirt PATCH 113/351] meson: add debug_logs build option

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 3 --- m4/virt-debug.m4 | 33 - meson.build | 5 + meson_options.txt | 1 + 4 files changed, 6 insertions(+), 36 deletions(-) delete mode 100644 m4/virt-debug.m4 diff --git a/configure.ac b/configu

[libvirt PATCH 224/351] meson: src: generate libvirt daemon augeas test files

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/bhyve/Makefile.inc.am | 6 -- src/bhyve/meson.build | 5 + src/libxl/Makefile.inc.am | 6 -- src/libxl/meson.build | 5 + src/locking/Makefile.inc.am | 32 src/locking/meson.build | 15 +++

[libvirt PATCH 097/351] meson: add node_device driver check

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac | 9 - meson.build | 4 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 0ab742c970f..e4cd6c15e16 100644 --- a/configure.ac +++ b/configure.ac @@ -223,15 +223,6 @@ LV_LIBTOOL_OBJDIR=${lt_cv_

[libvirt PATCH 326/351] meson: docs: build news.html from news.xml

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- docs/Makefile.am | 15 --- docs/meson.build | 6 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 73d3d26422a..1a5ae23b0ae 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -277,17 +

[libvirt PATCH 150/351] meson: scripts: introduce gen-sym-files.sh script

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- scripts/gen-sym-files.sh | 15 +++ scripts/meson.build | 1 + src/Makefile.am | 14 -- 3 files changed, 16 insertions(+), 14 deletions(-) create mode 100755 scripts/gen-sym-files.sh diff --git a/scripts/gen-sym-files.sh b/sc

[libvirt PATCH 166/351] meson: src: build libvirt_driver_vbox_impl.a static library

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/meson.build | 1 + src/vbox/Makefile.inc.am | 34 -- src/vbox/meson.build | 31 +++ 3 files changed, 32 insertions(+), 34 deletions(-) create mode 100644 src/vbox/meson.build diff --git

[libvirt PATCH 235/351] meson: src/nwfilter: install nwfilter XML files

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/nwfilter/Makefile.inc.am | 9 - src/nwfilter/meson.build | 2 ++ src/nwfilter/xml/meson.build | 22 ++ 3 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 src/nwfilter/xml/meson.build diff --git a/src/nwfilte

  1   2   3   4   5   >