Re: [libvirt PATCH 0/4] tests: bhyve: use more g_auto

Laine Stump wrote: > On 7/28/20 7:44 PM, Ján Tomko wrote: > > Ján Tomko (4): > >tests: bhyve: split variable declarations > >tests: bhyve: use g_autofree where possible > >tests: bhyve: use g_autoptr where possible > >tests: bhyve: remove unnecessary labels > > > >

[PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef

From: Zheng Chuan virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix it. Signed-off-by: Zheng Chuan --- src/qemu/qemu_driver.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [PATCH] qemuDomainSaveInternal: fix memoryleak of virDomainDef

On 7/28/20 9:56 PM, Chuan Zheng wrote: From: Zheng Chuan virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix it. Signed-off-by: Zheng Chuan --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c

Re: [RFC] Dynamic creation of VFs in a network definition containing an SRIOV device

On 7/28/20 4:46 PM, Daniel Henrique Barboza wrote: On 7/28/20 12:03 PM, Paulo de Rezende Pinatti wrote: Context: Libvirt can already detect the active VFs of an SRIOV PF device specified in a network definition and automatically assign these VFs to guests via an entry referring to that

Re: [libvirt PATCH 0/4] tests: bhyve: use more g_auto

On 7/28/20 7:44 PM, Ján Tomko wrote: Ján Tomko (4): tests: bhyve: split variable declarations tests: bhyve: use g_autofree where possible tests: bhyve: use g_autoptr where possible tests: bhyve: remove unnecessary labels tests/bhyveargv2xmltest.c | 47

Re: [libvirt PATCH 0/6] tests: qemu: use more g_auto

On 7/28/20 7:43 PM, Ján Tomko wrote: Ján Tomko (6): tests: qemu: reduce scope of some variables tests: qemucapsxml2xmltest: split variable declaration tests: qemu: use g_autofree where possible tests: qemu: use g_autoptr where possible tests: qemu: use VIR_AUTOSTRINGLIST where

Re: [libvirt PATCH 0/5] tests: commandtest: use g_auto more

On 7/28/20 7:40 PM, Ján Tomko wrote: Ján Tomko (5): tests: commandtest: remove unused 'prefix' parameter tests: commandtest: use g_autofree tests: commandtest: use g_autoptr for virCommand tests: commandtest: use VIR_AUTOCLOSE tests: commandtest: drop unnecessary labels

[PATCH] qemuDomainSaveInternal: fix memoryleak of virDomainDef

From: Zheng Chuan virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix it. Signed-off-by: Zheng Chuan --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 53980d4..b145318 100644 ---

[libvirt PATCH 3/4] tests: bhyve: use g_autoptr where possible

Signed-off-by: Ján Tomko --- tests/bhyveargv2xmltest.c | 3 +-- tests/bhyvexml2argvtest.c | 12 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/bhyveargv2xmltest.c b/tests/bhyveargv2xmltest.c index e58a36d17c..e7ec3ae020 100644 --- a/tests/bhyveargv2xmltest.c

[libvirt PATCH 1/4] tests: bhyve: split variable declarations

One variable per line. Signed-off-by: Ján Tomko --- tests/bhyvexml2argvtest.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c index 9e7eb218b8..f7ae1db26d 100644 --- a/tests/bhyvexml2argvtest.c +++

[libvirt PATCH 4/4] tests: bhyve: remove unnecessary labels

Signed-off-by: Ján Tomko --- tests/bhyveargv2xmltest.c | 28 +++- tests/bhyvexml2argvtest.c | 5 + 2 files changed, 12 insertions(+), 21 deletions(-) diff --git a/tests/bhyveargv2xmltest.c b/tests/bhyveargv2xmltest.c index e7ec3ae020..2a497f48e8 100644 ---

[libvirt PATCH 0/4] tests: bhyve: use more g_auto

Ján Tomko (4): tests: bhyve: split variable declarations tests: bhyve: use g_autofree where possible tests: bhyve: use g_autoptr where possible tests: bhyve: remove unnecessary labels tests/bhyveargv2xmltest.c | 47 ++- tests/bhyvexml2argvtest.c | 33

[libvirt PATCH 2/4] tests: bhyve: use g_autofree where possible

Signed-off-by: Ján Tomko --- tests/bhyveargv2xmltest.c | 16 +--- tests/bhyvexml2argvtest.c | 21 +++-- tests/bhyvexml2xmltest.c | 6 ++ 3 files changed, 14 insertions(+), 29 deletions(-) diff --git a/tests/bhyveargv2xmltest.c b/tests/bhyveargv2xmltest.c index

[libvirt PATCH 2/6] tests: qemucapsxml2xmltest: split variable declaration

One variable per line. Signed-off-by: Ján Tomko --- tests/qemucaps2xmltest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemucaps2xmltest.c b/tests/qemucaps2xmltest.c index 7a5125fea6..f087b037ce 100644 --- a/tests/qemucaps2xmltest.c +++

[libvirt PATCH 1/6] tests: qemu: reduce scope of some variables

Reduce the scope of some variables and mark them as g_autofree. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 6 ++ tests/testutilsqemu.c| 4 +--- tests/utiltest.c | 15 ++- 3 files changed, 5 insertions(+), 20 deletions(-) diff --git

[libvirt PATCH 6/6] tests: qemu: remove unnecessary labels

Signed-off-by: Ján Tomko --- tests/qemucapabilitiestest.c | 14 --- tests/qemucaps2xmltest.c | 13 -- tests/qemudomainsnapshotxml2xmltest.c | 20 +++- tests/qemuhotplugtest.c | 14 --- tests/qemumemlocktest.c |

[libvirt PATCH 3/6] tests: qemu: use g_autofree where possible

Signed-off-by: Ján Tomko --- tests/qemuagenttest.c | 9 +++- tests/qemucapabilitiestest.c | 18 +-- tests/qemucaps2xmltest.c | 20 + tests/qemudomainsnapshotxml2xmltest.c | 9 +++- tests/qemuhotplugtest.c |

[libvirt PATCH 0/6] tests: qemu: use more g_auto

Ján Tomko (6): tests: qemu: reduce scope of some variables tests: qemucapsxml2xmltest: split variable declaration tests: qemu: use g_autofree where possible tests: qemu: use g_autoptr where possible tests: qemu: use VIR_AUTOSTRINGLIST where possible tests: qemu: remove unnecessary

[libvirt PATCH 5/6] tests: qemu: use VIR_AUTOSTRINGLIST where possible

Signed-off-by: Ján Tomko --- tests/qemuxml2argvtest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index f26de13df1..ecf6562e90 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -130,7 +130,7 @@

[libvirt PATCH 4/6] tests: qemu: use g_autoptr where possible

Signed-off-by: Ján Tomko --- tests/qemuagenttest.c| 7 ++- tests/qemublocktest.c| 2 +- tests/qemucapabilitiestest.c | 9 +++-- tests/qemucaps2xmltest.c | 7 ++- tests/qemuhotplugtest.c | 6 ++ tests/qemumemlocktest.c | 7 ++-

[libvirt PATCH 2/5] tests: commandtest: use g_autofree

Signed-off-by: Ján Tomko --- tests/commandtest.c | 76 - 1 file changed, 26 insertions(+), 50 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index a18100a705..7c6c3ec75d 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c

[libvirt PATCH 5/5] tests: commandtest: drop unnecessary labels

Signed-off-by: Ján Tomko --- tests/commandtest.c | 106 +++- 1 file changed, 36 insertions(+), 70 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index b0bf6f379a..42225a8ef2 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c

[libvirt PATCH 4/5] tests: commandtest: use VIR_AUTOCLOSE

Signed-off-by: Ján Tomko --- tests/commandtest.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index a54e467b2b..b0bf6f379a 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -173,8 +173,8 @@ static int

[libvirt PATCH 1/5] tests: commandtest: remove unused 'prefix' parameter

The 'checkoutput' function does have a parameter for a possible prefix, but it is now unused. Introduced-by: 241ac07124a3172dc38198d777eb3f04846f6c52 Used-by: 62f263a73e8202f2af7309d1a3b9a66e6b57 Unused-since: 2dfacbffea47743fff942b6401f5f36b3ae4655a Signed-off-by: Ján Tomko ---

[libvirt PATCH 0/5] tests: commandtest: use g_auto more

Ján Tomko (5): tests: commandtest: remove unused 'prefix' parameter tests: commandtest: use g_autofree tests: commandtest: use g_autoptr for virCommand tests: commandtest: use VIR_AUTOCLOSE tests: commandtest: drop unnecessary labels tests/commandtest.c | 327

[libvirt PATCH 3/5] tests: commandtest: use g_autoptr for virCommand

Except for a few cases where freeing it explicitly seems to be done on purpose. Signed-off-by: Ján Tomko --- tests/commandtest.c | 94 - 1 file changed, 25 insertions(+), 69 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index

[libvirt PATCH 0/4] ci: run clang on Linux and parallelize more

I found out we do not run tests compiled with my preferred compiler [0]: https://www.redhat.com/archives/libvir-list/2020-July/msg01280.html Run it on Fedora 31 and Rawhide, to get some variety in the coverage. Corresponding libvirt-ci change:

[libvirt PATCH 1/4] ci: refresh Dockerfiles

We dropped ncurses and added libnuma-dev on all debian archs as of libvirt-ci commit: commit 4717287565d81b747d3176332108fe0302de2669 projects: libvirt doesn't depend on ncurses Signed-off-by: Ján Tomko --- ci/containers/libvirt-centos-7.Dockerfile | 1 -

[libvirt PATCH 2/4] ci: add a job for clang

Out of the Linux distros we build on in the CI, clang is only available on Fedora. Add a job to Fedora 31 and Rawhide, to have coverage for clang on Linux as well. Includes a refresh of the Dockerfiles to commit TBD: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/38 Signed-off-by: Ján

[libvirt PATCH 3/4] ci: run Cirrus-based builds sooner

Jobs using cirrus-run don't need to wait for any jobs from the container stage. Run them as soon as possible. Signed-off-by: Ján Tomko --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f61ad7151c..077465e436 100644 ---

[libvirt PATCH 4/4] ci: use 'needs' more often

Make the pipeline chart more interesting. Signed-off-by: Ján Tomko --- .gitlab-ci.yml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 077465e436..7d23ddfdf9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -268,41 +268,49 @@

Re: [RFC] Dynamic creation of VFs in a network definition containing an SRIOV device

On 7/28/20 12:03 PM, Paulo de Rezende Pinatti wrote: Context: Libvirt can already detect the active VFs of an SRIOV PF device specified in a network definition and automatically assign these VFs to guests via an entry referring to that network in the domain definition. This

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tue, Jul 28, 2020 at 09:32:57PM +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 09:13:41PM +0200, Peter Krempa wrote: > > On Tue, Jul 28, 2020 at 18:48:18 +0200, Pavel Hrdina wrote: > > > On Tue, Jul 28, 2020 at 03:39:41PM +0200, Pavel Hrdina wrote: > > > > On Tue, Jul 28, 2020 at

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tue, Jul 28, 2020 at 09:13:41PM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 18:48:18 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:39:41PM +0200, Pavel Hrdina wrote: > > > On Tue, Jul 28, 2020 at 03:19:25PM +0200, Pino Toscano wrote: > > > > On Tuesday, 28 July 2020

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tue, Jul 28, 2020 at 18:48:18 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 03:39:41PM +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:19:25PM +0200, Pino Toscano wrote: > > > On Tuesday, 28 July 2020 14:56:45 CEST Peter Krempa wrote: > > > > On Thu, Jul 16, 2020 at 11:59:08

Re: [PATCH] doc: fix name of file containing max number of VFs

On 7/28/20 7:32 AM, Daniel Henrique Barboza wrote: On 7/28/20 6:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti ---   docs/formatnode.html.in | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in

Re: [libvirt PATCH 034/351] meson: add AppArmor build dependency

On Tue, Jul 28, 2020 at 07:03:56PM +0200, Michal Privoznik wrote: > On 7/16/20 11:54 AM, Pavel Hrdina wrote: > > APPARMOR_MOUNT is not used so dropping it in meson. > > > > Signed-off-by: Pavel Hrdina > > --- > > configure.ac| 3 --- > > m4/virt-apparmor.m4 | 41

Re: [PATCH] doc: fix name of file containing max number of VFs

s/doc/docs/ in the summary to match the directory prefix On a Tuesday in 2020, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in

Re: [libvirt PATCH 034/351] meson: add AppArmor build dependency

On 7/16/20 11:54 AM, Pavel Hrdina wrote: APPARMOR_MOUNT is not used so dropping it in meson. Signed-off-by: Pavel Hrdina --- configure.ac| 3 --- m4/virt-apparmor.m4 | 41 - meson.build | 8 meson_options.txt | 4

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tue, Jul 28, 2020 at 03:39:41PM +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 03:19:25PM +0200, Pino Toscano wrote: > > On Tuesday, 28 July 2020 14:56:45 CEST Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:59:08 +0200, Pavel Hrdina wrote: > > > > We need to modify

Re: [libvirt PATCH 281/351] meson: tests: build commandhelper binary

On Tue, Jul 28, 2020 at 01:28:20PM +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 12:49:03PM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:58:37 +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > tests/Makefile.am | 14 +- > > >

Re: [PATCH 5/5] src: add missing balloon stats docs

On 7/21/20 10:07 AM, Nikolay Shirokovskiy wrote: Signed-off-by: Nikolay Shirokovskiy --- src/libvirt-domain.c | 28 1 file changed, 28 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index fe4dab7..36fa8a2 100644 --- a/src/libvirt-domain.c

Re: [PATCH 0/5] docs: misc docs enhancements for statistic API

On 7/21/20 10:07 AM, Nikolay Shirokovskiy wrote: Nikolay Shirokovskiy (5): docs: fix typo in virsh.rst for balloon.major_fault include: clarify docs for hugetlb in virDomainMemoryStatTags docs: add missing balloon stats docs in domstats docs: add missing iothread stats docs in

Re: [PATCH 2/5] include: clarify docs for hugetlb in virDomainMemoryStatTags

On 7/21/20 10:07 AM, Nikolay Shirokovskiy wrote: The term number is used for other stats and even for hugetlb stats in virsh man page. The term number is also more clear. Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-domain.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 0/5] be consistent about error checking xmlNodeGetContent() return

On 7/20/20 10:48 PM, Laine Stump wrote: Awhile back I noticed that calls to xmlNodeGetContent() from libvirt code were inconsistent in their handling of the returned pointer. Sometimes we would assume the return was always non-NULL (dereferencing with wild abandon without concern for the

Re: [FYI PATCH 5/5] util: open code virXMLNodeContentString to access the node object directly

On 7/20/20 10:48 PM, Laine Stump wrote: (I am *NOT* advocating that we apply this patch. Just providing it for informational purposes, since we had previously discussed this possibility on the list) Since it's impossible to determine whether xmlNodeContent has returned a NULL due to OOM, or due

Re: [PATCH] qemu: Do not silently allow non-available timers on non-x86 systems

On 7/22/20 1:21 PM, Thomas Huth wrote: libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they expected otherwise. Buglink:

Re: [PATCH] doc: fix name of file containing max number of VFs

On 7/28/20 11:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 ---

[RFC] Dynamic creation of VFs in a network definition containing an SRIOV device

Context: Libvirt can already detect the active VFs of an SRIOV PF device specified in a network definition and automatically assign these VFs to guests via an entry referring to that network in the domain definition. This functionality, however, depends on the system administrator having

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 04:52:18PM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 16:46:55 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 04:23:15PM +0200, Peter Krempa wrote: > > > On Tue, Jul 28, 2020 at 16:14:03 +0200, Pavel Hrdina wrote: > > [...] > > > If there majority agrees

[PATCH v2 4/4] tests: schema: test bhyvexml2xmloutdata schemas

Signed-off-by: Roman Bogorodskiy --- tests/virschematest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/virschematest.c b/tests/virschematest.c index 8720031375..17eb2a4b34 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -201,7 +201,8 @@

[PATCH v2 1/4] bhyve: implement sound device support

bhyve supports intel hda sound devices that could be specified on the command like using "-1:0,hda,play=$play_dev,rec=$rec_dev", where "1:0" is a PCI address, and "$play_dev" and "$rec_dev" point to the playback and recording device on the host respectively. Currently, schema of the 'sound'

[PATCH v2 3/4] bhyve: allow to specify host sound device

Allow to map sound playback and recording devices to host devices using "" OSS audio backend. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 37 +-- .../bhyvexml2argv-sound.args | 2 +-

[PATCH v2 2/4] conf: allow to map sound device to host device

Introduce a new device element "" which allows to map guest sound device specified using the "" element to specific audio backend. Example: This block maps to OSS audio backend on the host using /dev/dsp0 device for both input (recording) and output (playback).

[PATCH v2 0/4] bhyve: implement sound device support

Changes from v1: Main change is the addition of the "" element that allows to map the "" device to the host audio backend. Would appreciate initial feedback on this one, and then I'll proceed with adding more validation. Roman Bogorodskiy (4): bhyve: implement sound device support conf:

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 16:46:55 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 04:23:15PM +0200, Peter Krempa wrote: > > On Tue, Jul 28, 2020 at 16:14:03 +0200, Pavel Hrdina wrote: [...] > If there majority agrees on removing the script I would rather do it as > a followup series. I

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 04:23:15PM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 16:14:03 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:59:58PM +0200, Peter Krempa wrote: > > > On Tue, Jul 28, 2020 at 15:57:16 +0200, Pavel Hrdina wrote: > > > > On Tue, Jul 28, 2020 at 03:18:23PM

Re: [libvirt PATCH 342/351] meson: add syntax-check

On Tue, Jul 28, 2020 at 03:08:11PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 04:04:39PM +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:48:29PM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:59:38 +0200, Pavel Hrdina wrote: > > > > Signed-off-by: Pavel

Re: [libvirt PATCH 0/9] Remove some unused macros

Reviewed-by: Jonathon Jongsma On Tue, 2020-07-28 at 13:54 +0200, Ján Tomko wrote: > I built with -Wunused-macros again after five years [0] > the good news is we don't really have that many - > most of them are VIR_FROM_THIS or macros we have included > for completeness. > >

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 16:14:03 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 03:59:58PM +0200, Peter Krempa wrote: > > On Tue, Jul 28, 2020 at 15:57:16 +0200, Pavel Hrdina wrote: > > > On Tue, Jul 28, 2020 at 03:18:23PM +0200, Peter Krempa wrote: > > > > On Thu, Jul 16, 2020 at 11:59:17

Re: [libvirt PATCH 342/351] meson: add syntax-check

On Tue, Jul 28, 2020 at 15:08:11 +0100, Daniel Berrange wrote: > On Tue, Jul 28, 2020 at 04:04:39PM +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:48:29PM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:59:38 +0200, Pavel Hrdina wrote: > > > > Signed-off-by: Pavel Hrdina >

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 03:59:58PM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 15:57:16 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 03:18:23PM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:59:17 +0200, Pavel Hrdina wrote: > > > > Signed-off-by: Pavel Hrdina > > >

Re: [libvirt PATCH 342/351] meson: add syntax-check

On Tue, Jul 28, 2020 at 04:04:39PM +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 03:48:29PM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:59:38 +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > build-aux/Makefile.in | 9 +++ >

Re: [libvirt PATCH 343/351] meson: update spec file to use meson

On Tue, Jul 28, 2020 at 03:51:43PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:59:39 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > libvirt.spec.in | 203 +--- > > meson.build | 1 - > > 2 files changed, 89

Re: [libvirt PATCH 342/351] meson: add syntax-check

On Tue, Jul 28, 2020 at 03:48:29PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:59:38 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > build-aux/Makefile.in | 9 +++ > > .../Makefile.nonreentrant | 0 > >

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 15:57:16 +0200, Pavel Hrdina wrote: > On Tue, Jul 28, 2020 at 03:18:23PM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:59:17 +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > docs/Makefile.am | 26 - > > >

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Tue, Jul 28, 2020 at 03:18:23PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:59:17 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > docs/Makefile.am | 26 - > > scripts/meson-html-gen.py | 49 +++

Re: [libvirt PATCH 343/351] meson: update spec file to use meson

On Thu, Jul 16, 2020 at 11:59:39 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > libvirt.spec.in | 203 +--- > meson.build | 1 - > 2 files changed, 89 insertions(+), 115 deletions(-) > > diff --git a/libvirt.spec.in

Re: [libvirt PATCH 342/351] meson: add syntax-check

On Thu, Jul 16, 2020 at 11:59:38 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > build-aux/Makefile.in | 9 +++ > .../Makefile.nonreentrant | 0 > build-aux/meson.build | 30 + >

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tue, Jul 28, 2020 at 03:19:25PM +0200, Pino Toscano wrote: > On Tuesday, 28 July 2020 14:56:45 CEST Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 11:59:08 +0200, Pavel Hrdina wrote: > > > We need to modify check-file-access.py to be usable as wrapper for > > > libvirt tests. This way we can

Re: [libvirt PATCH 326/351] meson: docs: build news.html from news.xml

On Thu, Jul 16, 2020 at 11:59:22 +0200, Pavel Hrdina wrote: Wrong subject. 'from NEWS.rst'. > Signed-off-by: Pavel Hrdina > ---

Re: [libvirt PATCH 324/351] meson: docs: build *.html files from *.rst files

On Thu, Jul 16, 2020 at 11:59:20 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > docs/Makefile.am | 3 --- > docs/meson.build | 61 > 2 files changed, 61 insertions(+), 3 deletions(-) This and the previous commit can actually be

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Tuesday, 28 July 2020 14:56:45 CEST Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:59:08 +0200, Pavel Hrdina wrote: > > We need to modify check-file-access.py to be usable as wrapper for > > libvirt tests. This way we can run the tests using this command: > > > > meson test --setup

Re: [libvirt PATCH 321/351] meson: docs: introduce meson-html-gen.py helper

On Thu, Jul 16, 2020 at 11:59:17 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > docs/Makefile.am | 26 - > scripts/meson-html-gen.py | 49 +++ > scripts/meson.build | 1 + > 3 files changed, 50

Re: [libvirt PATCH 313/351] meson: tests: add valgrind test setup

On Thu, Jul 16, 2020 at 11:59:09 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > Makefile.am | 4 +--- > configure.ac | 3 +-- > tests/Makefile.am | 23 --- > tests/meson.build | 11 +++ > 4 files changed, 13 insertions(+), 28

Re: [libvirt PATCH 312/351] meson: tests: add file access test setup

On Thu, Jul 16, 2020 at 11:59:08 +0200, Pavel Hrdina wrote: > We need to modify check-file-access.py to be usable as wrapper for > libvirt tests. This way we can run the tests using this command: > > meson test --setup access > > which will run all tests using check-file-access.py as a

Re: [libvirt PATCH 290/351] meson: tests: add ESX specific tests

On Tue, Jul 28, 2020 at 02:06:08PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:58:46 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/esx/meson.build | 2 ++ > > tests/Makefile.am | 14 -- > > tests/meson.build | 6 ++ > > 3 files

Re: [libvirt PATCH 290/351] meson: tests: add ESX specific tests

On Thu, Jul 16, 2020 at 11:58:46 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/esx/meson.build | 2 ++ > tests/Makefile.am | 14 -- > tests/meson.build | 6 ++ > 3 files changed, 8 insertions(+), 14 deletions(-) > > diff --git a/src/esx/meson.build

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

On 2020/7/28 19:44, Daniel P. Berrangé wrote: > On Tue, Jul 28, 2020 at 07:35:11PM +0800, zhukeqian wrote: >> >> >> On 2020/7/28 18:32, Daniel P. Berrangé wrote: >>> On Wed, Jul 15, 2020 at 02:18:01PM +0800, Keqian Zhu wrote: For that Qemu supports returning incoming migration info since

[libvirt PATCH 9/9] util: netdevip: remove unused VIR_NETDEV_FAMILY

Signed-off-by: Ján Tomko Fixes: cf0568b0af4ef4f903da1b184fc9b232c6f29457 --- src/util/virnetdevip.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 8b85c7beca..409f062c5c 100644 --- a/src/util/virnetdevip.c +++

[libvirt PATCH 7/9] virt-admin: remove unused VIRT_ADMIN_TIME_BUFLEN

The switch to GDateTime removed the last use. Signed-off-by: Ján Tomko Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 --- tools/virt-admin.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index fef0332a0d..cc136397bd 100644 ---

[libvirt PATCH 6/9] virsh: remove unused FILTER macro

Signed-off-by: Ján Tomko Fixes: c2dd9ddf7b18ebfb108623d4711c80b716a261d7 --- tools/virsh-network.c | 4 1 file changed, 4 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index ed90736345..b10cd03bcc 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@

[libvirt PATCH 3/9] storage: scsi: remove unused LINUX_SYSFS_SCSI_HOST_POSTFIX

Unused since its introduction. Signed-off-by: Ján Tomko Fixes: 81d0ffbc3baee53467f664ea03b1349e8b6dba5a --- src/storage/storage_backend_scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c index 37ae4325ca..e528d7622c

[libvirt PATCH 0/9] Remove some unused macros

I built with -Wunused-macros again after five years [0] the good news is we don't really have that many - most of them are VIR_FROM_THIS or macros we have included for completeness. https://gitlab.com/jano.tomko/libvirt/-/pipelines/171383854 [0] a0482396d7e0b164e71b2bdd881d9db5c6521303 Ján

[libvirt PATCH 4/9] test: remove unused NUM_CELLS

Signed-off-by: Ján Tomko Fixes: 2bd7ed78a7cd68775de8cb912c7a57db7721a10b --- src/test/test_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 993f405f3c..01c4675c30 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt PATCH 1/9] locking: sanlock: drop unused LOCKSPACE_SLEEP

After dropping support for sanlock < 2.4, this constant is no longer used. Signed-off-by: Ján Tomko Fixes: c4951694786ecd45424769979762c17e4c8e56d0 --- src/locking/lock_driver_sanlock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/locking/lock_driver_sanlock.c

[libvirt PATCH 8/9] util: vportprofile: remove unused constants

After the switch to libnl these are no longer used. Signed-off-by: Ján Tomko Fixes: 77e7c13b2ef95724c39395d92725b1a892ff84de --- src/util/virnetdevvportprofile.c | 4 1 file changed, 4 deletions(-) diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index

[libvirt PATCH 2/9] storage: logical: drop unused PV_BLANK_SECTOR_SIZE

Signed-off-by: Ján Tomko Fixes: d942bf6e9e8e3991808ca5185098257e84acab5d --- src/storage/storage_backend_logical.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 60958d3d2c..43cf3a1598 100644 ---

[libvirt PATCH 5/9] util: remove unused VIR_MCAST_ADDR_LEN

Unused since its introduction. Signed-off-by: Ján Tomko Fixes: cc0e8c244d080f56392278e836cc378ba848e7aa --- src/util/virnetdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 41dc5bd4c4..b42fa86672 100644 --- a/src/util/virnetdev.c +++

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

On a Tuesday in 2020, Daniel P. Berrangé wrote: On Tue, Jul 28, 2020 at 12:24:56PM +0200, Ján Tomko wrote: For unattended bisects, it would be nice to return 125 which is the magic value meaning 'skip' to 'git bisect run'. I don't think its possible to force the ninja/meson exit status upon

Re: [libvirt PATCH] ci: move sanity_checks after other stages

On Tue, Jul 28, 2020 at 01:42:02PM +0200, Ján Tomko wrote: > Be less hostile to developers and run the build jobs even > if the dco-check failed. That way they can test their own > "private" branches without a sign-off. > > Also specify empty `needs` for it, since it does not depend > on any of

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

On Tue, Jul 28, 2020 at 07:35:11PM +0800, zhukeqian wrote: > > > On 2020/7/28 18:32, Daniel P. Berrangé wrote: > > On Wed, Jul 15, 2020 at 02:18:01PM +0800, Keqian Zhu wrote: > >> For that Qemu supports returning incoming migration info since its commit > >> 65ace0604551 (migration: add postcopy

[libvirt PATCH] ci: move sanity_checks after other stages

Be less hostile to developers and run the build jobs even if the dco-check failed. That way they can test their own "private" branches without a sign-off. Also specify empty `needs` for it, since it does not depend on any of the jobs in the container phase and can be run right away.

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

On 2020/7/28 18:32, Daniel P. Berrangé wrote: > On Wed, Jul 15, 2020 at 02:18:01PM +0800, Keqian Zhu wrote: >> For that Qemu supports returning incoming migration info since its commit >> 65ace0604551 (migration: add postcopy total blocktime into query-migrate), >> which may contains active

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

On Tue, Jul 28, 2020 at 12:15:25PM +0200, Peter Krempa wrote: > On Tue, Jul 28, 2020 at 10:33:52 +0200, Pavel Hrdina wrote: > > On Tue, Jul 28, 2020 at 10:09:42AM +0200, Peter Krempa wrote: > > [...] > > > > > Here I disagree, it also means that compilation should not fail. We do > > comments

Re: [PATCH] doc: fix name of file containing max number of VFs

On 7/28/20 6:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 ---

Re: [PATCH] Qemu: migration: Not bind RAM info with active migration status

Hi Daniel, On 2020/7/28 18:21, Daniel Henrique Barboza wrote: > > > On 7/28/20 5:46 AM, zhukeqian wrote: >> Hi Daniel, >> >> On 2020/7/17 22:33, Daniel Henrique Barboza wrote: >>> >>> >>> On 7/15/20 3:18 AM, Keqian Zhu wrote: For that Qemu supports returning incoming migration info since

Re: [libvirt PATCH 281/351] meson: tests: build commandhelper binary

On Tue, Jul 28, 2020 at 12:49:03PM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 11:58:37 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > tests/Makefile.am | 14 +- > > tests/meson.build | 17 + > > 2 files changed, 18 insertions(+), 13

Re: [libvirt PATCH 000/351] port libvirt to Meson build system

On Tue, Jul 28, 2020 at 10:46:07AM +0100, Daniel P. Berrangé wrote: On Fri, Jul 17, 2020 at 07:27:50PM +0200, Martin Kletzander wrote: On Fri, Jul 17, 2020 at 03:12:00PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 17, 2020 at 04:10:01PM +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at

Re: [PATCH] qemu: modprobe vhost-vsock module

On 28.07.2020 13:12, Stefano Garzarella wrote: > On Tue, Jul 28, 2020 at 12:58:07PM +0300, Nikolay Shirokovskiy wrote: >> /dev/vhost-vsock is usable only if the module is loaded. Let's load the >> module >> just like in other places where kernel module is required (nbd, pci stub >> driver). >

  1   2   >