BSD sed(1) and GNU sed(1) syntax are not compatible, and as
syntax-check.mk uses the GNU flavor, set SED variable to
'gsed' by default.
Signed-off-by: Roman Bogorodskiy
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
I'm not sure if this requires a more
On Wed, Aug 05, 2020 at 03:23:44PM +0200, Erik Skultety wrote:
> On Wed, Aug 05, 2020 at 03:14:52PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote:
> > > Once we (hopefully) move remaining projects to meson and some of the
> > > projects would require
On Wed, Aug 05, 2020 at 03:14:52PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote:
> > Once we (hopefully) move remaining projects to meson and some of the
> > projects would require newer meson we would have to introduce the ugly
> > hack into these spec
On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote:
> Once we (hopefully) move remaining projects to meson and some of the
> projects would require newer meson we would have to introduce the ugly
> hack into these spec files as well (if there are any).
>
> After checking what is in the macro
On Wed, Aug 05, 2020 at 02:37:09PM +0200, Pavel Hrdina wrote:
> On Wed, Aug 05, 2020 at 02:00:14PM +0200, Erik Skultety wrote:
> > On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote:
> > > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> > > > Gross hack in our CI vs gross
On Wed, Aug 05, 2020 at 02:00:14PM +0200, Erik Skultety wrote:
> On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> > > Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> > > the hack.
> > >
> > > In
On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> > Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> > the hack.
> >
> > In addition the macros are provided by meson and there are changes in
> > the
On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> > Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> > the hack.
> >
> > In addition the macros are provided by meson and there are changes in
> > the
On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote:
> Gross hack in our CI vs gross hack in spec file. I vote for CI to have
> the hack.
>
> In addition the macros are provided by meson and there are changes in
> the macro file, for example the latest macro file uses `meson compile`
> instead
On Wed, 2020-08-05 at 13:32 +0200, Pavel Hrdina wrote:
> On Wed, Aug 05, 2020 at 01:16:01PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-08-05 at 12:51 +0200, Pavel Hrdina wrote:
> > > +correct_rl = cc.has_header_symbol('readline/readline.h',
> > > 'rl_completion_quote_character', prefix:
On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote:
> Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote:
> > On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote:
> > >
> > > On 2020/8/5 下午3:56, Jiri Pirko wrote:
> > > > Wed, Aug 05, 2020 at 04:41:54AM CEST,
On Wed, Aug 05, 2020 at 12:52:15PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 12:24 +0200, Pavel Hrdina wrote:
> > On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote:
> > > Oh, I see now the %meson macro is shipped as part of meson itself. We
> > > definitely don't want
On Wed, Aug 05, 2020 at 01:16:01PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 12:51 +0200, Pavel Hrdina wrote:
> > Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for
> > rl_completion_quote_character to make sure we have correct readline
> > library. Commit added
> >
On Wed, Aug 05, 2020 at 10:07:44AM +0200, Pavel Hrdina wrote:
> In meson.build we define sanlock_dep only if it is available but in
> addition we add 'WITH_SANLOCK' into conf. Use the presence of
> 'WITH_SANLOCK' in conf to figure out if we need to install
> virt-sanlock-cleanup man page.
>
>
On Wed, 2020-08-05 at 12:51 +0200, Pavel Hrdina wrote:
> Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for
> rl_completion_quote_character to make sure we have correct readline
> library. Commit added
> inaccurate comment that it's a function.
So it was my fault after all O:-)
>
Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote:
>On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote:
>>
>> On 2020/8/5 下午3:56, Jiri Pirko wrote:
>> > Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote:
>> > > On 2020/8/5 上午10:16, Yan Zhao wrote:
>> > > > On
On Wed, 2020-08-05 at 12:24 +0200, Pavel Hrdina wrote:
> On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote:
> > Oh, I see now the %meson macro is shipped as part of meson itself. We
> > definitely don't want to install two versions of meson, and if we end
> > up agreeing that
Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for
rl_completion_quote_character to make sure we have correct readline
library. Commit added
inaccurate comment that it's a function.
We need to check for generic symbol instead of checking for function.
In addition the
On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 11:23 +0200, Erik Skultety wrote:
> > On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote:
> > > Erik reports that there are issues with building RPMs on CentOS. He
> > > opened
libvirt currently silently allows and some
other timer tags in the guest XML definition for timers that do not
exist on non-x86 systems. We should not silently ignore these tags
since the users might not get what they expected otherwise.
Note: The error is only generated if the timer is marked
On Wed, 2020-08-05 at 11:23 +0200, Erik Skultety wrote:
> On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote:
> > Erik reports that there are issues with building RPMs on CentOS. He
> > opened https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/42, but
> > it seems to me that the
* Yan Zhao (yan.y.z...@intel.com) wrote:
> > > yes, include a device_api field is better.
> > > for mdev, "device_type=vfio-mdev", is it right?
> >
> > No, vfio-mdev is not a device API, it's the driver that attaches to the
> > mdev bus device to expose it through vfio. The device_api exposes
On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote:
>
> On 2020/8/5 下午3:56, Jiri Pirko wrote:
> > Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote:
> > > On 2020/8/5 上午10:16, Yan Zhao wrote:
> > > > On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote:
> > > > > On
On Wed, Aug 05, 2020 at 10:16:02 +0100, Daniel Berrange wrote:
> On Wed, Aug 05, 2020 at 05:06:04PM +0800, Han Han wrote:
> > Signed-off-by: Han Han
> > ---
> > NEWS.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/NEWS.rst b/NEWS.rst
> > index
On Tuesday, 4 August 2020 20:28:06 CEST Ján Tomko wrote:
> Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/
> by mistake and this file is still licensed under GPLv2.0+
>
> Undo the change.
>
> Signed-off-by: Ján Tomko
> FIxes: 0466ff28f23f4c430906efd5859f87672cf08782
> Cc: Cole
On Wed, Aug 05, 2020 at 11:06:29AM +0200, Erik Skultety wrote:
> By default, symlink re-creation fails if the link already exists, more
> specifically in case of meson-install-symlink.py:
>
> Traceback (most recent call last):
> File "//scripts/meson-install-symlink.py",
> line 15, in
>
On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote:
> On Thu, 2020-07-16 at 11:54 +0200, Pavel Hrdina wrote:
> > +++ b/meson_options.txt
> > @@ -12,3 +12,4 @@ option('test_coverage', type: 'boolean', value: false,
> > description: 'turn on cod
> > option('apparmor', type:
On Wed, Aug 5, 2020 at 5:16 PM Daniel P. Berrangé
wrote:
> On Wed, Aug 05, 2020 at 05:06:04PM +0800, Han Han wrote:
> > Signed-off-by: Han Han
> > ---
> > NEWS.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/NEWS.rst b/NEWS.rst
> > index
On Tue, Aug 04, 2020 at 08:37:25PM +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Daniel P. Berrangé wrote:
> > On Tue, Aug 04, 2020 at 08:10:02PM +0200, Ján Tomko wrote:
> > > On a Tuesday in 2020, Eric Blake wrote:
> > > > On 8/4/20 12:33 PM, Daniel P. Berrangé wrote:
> > > > > On Tue, Aug 04,
On Wed, Aug 05, 2020 at 05:06:04PM +0800, Han Han wrote:
> Signed-off-by: Han Han
> ---
> NEWS.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 63ca689b43..1887177b0e 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -47,7 +47,7 @@ v6.6.0
On Wed, Aug 05, 2020 at 09:57:17AM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote:
> > By default, symlink re-creation fails if the link already exists, more
> > specifically in case of meson-install-symlink.py:
> >
> > Traceback (most recent call
By default, symlink re-creation fails if the link already exists, more
specifically in case of meson-install-symlink.py:
Traceback (most recent call last):
File "//scripts/meson-install-symlink.py",
line 15, in
os.symlink(target, link)
FileExistsError: File exists: '../default.xml'
Signed-off-by: Han Han
---
NEWS.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NEWS.rst b/NEWS.rst
index 63ca689b43..1887177b0e 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -47,7 +47,7 @@ v6.6.0 (2020-08-02)
Specifying a virtualHW version greater or equal to 7 (ESXi 4.0)
On Wed, Aug 05, 2020 at 10:33:21AM +0200, Jiri Denemark wrote:
> When COW is not explicitly requested to be disabled or enabled, the
> function is supposed to do nothing on non-BTRFS file systems.
>
> Fixes commit 7230bc95aa78379c9ee20cf59394c5fc4305b75b.
>
>
Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote:
>
>On 2020/8/5 上午10:16, Yan Zhao wrote:
>> On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote:
>> > On 2020/8/5 上午12:35, Cornelia Huck wrote:
>> > > [sorry about not chiming in earlier]
>> > >
>> > > On Wed, 29 Jul 2020
On Thu, 2020-07-16 at 11:54 +0200, Pavel Hrdina wrote:
> +++ b/meson_options.txt
> @@ -12,3 +12,4 @@ option('test_coverage', type: 'boolean', value: false,
> description: 'turn on cod
> option('apparmor', type: 'feature', value: 'auto', description: 'apparmor
> support')
> option('attr', type:
On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote:
> By default, symlink re-creation fails if the link already exists, more
> specifically in case of meson-install-symlink.py:
>
> Traceback (most recent call last):
> File "//scripts/meson-install-symlink.py",
> line 15, in
>
On Tue, Aug 04, 2020 at 23:15:26 -0400, Laine Stump wrote:
> On 8/4/20 5:09 AM, Daniel P. Berrangé wrote:
> > On Mon, Aug 03, 2020 at 07:29:19PM +0200, Peter Krempa wrote:
> > > On Mon, Aug 03, 2020 at 19:18:53 +0200, Ján Tomko wrote:
> > > > Signed-off-by: Ján Tomko
> > > > ---
> > > >
When COW is not explicitly requested to be disabled or enabled, the
function is supposed to do nothing on non-BTRFS file systems.
Fixes commit 7230bc95aa78379c9ee20cf59394c5fc4305b75b.
https://bugzilla.redhat.com/show_bug.cgi?id=1866157
Signed-off-by: Jiri Denemark
---
src/util/virfile.c | 2
On Wed, Aug 5, 2020 at 4:19 AM Andrea Bolognani wrote:
> On Wed, 2020-08-05 at 02:09 -0400, Mark Mielke wrote:
> > In testing qemu-5.1rc2 on my Fedora 32 home system, I found that
> > the Fedora rawhide package has broken out both the QXL display
> > device and the USB redirect device into
On Tue, Aug 04, 2020 at 19:48:15 +0200, Martin Kletzander wrote:
> On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote:
> > By default, symlink re-creation fails if the link already exists, more
> > specifically in case of meson-install-symlink.py:
> >
> > Traceback (most recent call
On Wed, 2020-08-05 at 02:09 -0400, Mark Mielke wrote:
> Hi all:
>
> In testing qemu-5.1rc2 on my Fedora 32 home system, I found that
> the Fedora rawhide package has broken out both the QXL display
> device and the USB redirect device into separate RPM modules:
>
> qemu-device-display-qxl.x86_64
On Wed, Aug 05, 2020 at 02:09:46 -0400, Mark Mielke wrote:
> Hi all:
>
> In testing qemu-5.1rc2 on my Fedora 32 home system, I found that the Fedora
> rawhide package has broken out both the QXL display device and the USB
> redirect device into separate RPM modules:
>
>
In meson.build we define sanlock_dep only if it is available but in
addition we add 'WITH_SANLOCK' into conf. Use the presence of
'WITH_SANLOCK' in conf to figure out if we need to install
virt-sanlock-cleanup man page.
Reported-by: Michal Privoznik
Signed-off-by: Pavel Hrdina
---
On 2020/8/5 下午3:56, Jiri Pirko wrote:
Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redhat.com wrote:
On 2020/8/5 上午10:16, Yan Zhao wrote:
On Wed, Aug 05, 2020 at 10:22:15AM +0800, Jason Wang wrote:
On 2020/8/5 上午12:35, Cornelia Huck wrote:
[sorry about not chiming in earlier]
On Wed, 29
Signed-off-by: Han Han
---
src/locking/lock_daemon.c | 32 +-
src/locking/lock_daemon.h | 4 ++--
src/locking/lock_daemon_dispatch.c | 32 +++---
3 files changed, 27 insertions(+), 41 deletions(-)
diff --git
Signed-off-by: Han Han
---
src/logging/log_daemon.c | 26 ++
src/logging/log_daemon.h | 4 ++--
2 files changed, 8 insertions(+), 22 deletions(-)
diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c
index 028f771f14..0649a70c9d 100644
---
On Tue, Aug 04, 2020 at 07:48:15PM +0200, Martin Kletzander wrote:
> On Tue, Aug 04, 2020 at 06:27:08PM +0200, Erik Skultety wrote:
> > By default, symlink re-creation fails if the link already exists, more
> > specifically in case of meson-install-symlink.py:
> >
> > Traceback (most recent call
Hi all:
In testing qemu-5.1rc2 on my Fedora 32 home system, I found that the Fedora
rawhide package has broken out both the QXL display device and the USB
redirect device into separate RPM modules:
qemu-device-display-qxl.x86_64 2:5.1.0-0.1.rc2.fc32
@@commandline
49 matches
Mail list logo
