[PATCH] doc: add some examples for IPv6 NAT configuration

2020-08-11 Thread Ian Wienand
Add some expanded examples for the nat ipv6 introduced with 927acaedec7effbe67a154d8bfa0e67f7d08e6c7. Unfortunately while for IPv4 it's well-known what addresses ranges are useful for NAT, with IPv6 unless you enjoy digging through RFC's going back-and-forth over unique local addresses and the

[PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-11 Thread Ian Wienand
The checks modified here were added with 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing routes on hosts. However, tools such as systemd-networking and NetworkManager manage RA's in userspace and thus IPv6 may be up and working on an interface even with accept_ra == 0. This modifies the

[libvirt PATCH] docs: formatdomain: fix superscripts

2020-08-11 Thread Ján Tomko
There needs to be a space before the :sup: directive. Signed-off-by: Ján Tomko --- Pushed as trivial. docs/formatdomain.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 218f0c1718..8365fc8bbb 100644 ---

Re: [libvirt PATCH v2] kbase: sev: Provide more details on virtio-net configuration

2020-08-11 Thread Laszlo Ersek
On 08/11/20 14:12, Erik Skultety wrote: > With virtio-net we also need to disable the iPXE option ROM otherwise > a SEV-enabled guest would not boot. While at it, fix the full machine > XML examples accordingly. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Erik Skultety > --- >

[libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups

2020-08-11 Thread Pavel Hrdina
If we don't have cgroups available and user tries to update blkio parameters for running VM it will crash. It should have been protected by the virCgroupHasController() check but it was never called if the API was executed without any flags. We call virDomainObjGetDefs() which sets `def` and

Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-08-11 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 8/5/20 12:22 PM, Thomas Huth wrote: libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they

Re: [libvirt PATCH] vircgroupv2devices: fix counting entries in BPF map

2020-08-11 Thread Erik Skultety
On Tue, Aug 11, 2020 at 12:13:47PM +0200, Pavel Hrdina wrote: > BPF syscall BPF_MAP_GET_NEXT_KEY returns -1 if something fails but it > will also return -1 if trying to get next key using the last key in the > map with errno set to ENOENT. > > If there are VMs running and libvirtd is restarted and

[libvirt PATCH v2] kbase: sev: Provide more details on virtio-net configuration

2020-08-11 Thread Erik Skultety
With virtio-net we also need to disable the iPXE option ROM otherwise a SEV-enabled guest would not boot. While at it, fix the full machine XML examples accordingly. Reported-by: Dr. David Alan Gilbert Signed-off-by: Erik Skultety --- since v1: - ditched any mentions of vhost, since we can

[PATCH] docs/system: clarify deprecation scheduled

2020-08-11 Thread Stefan Hajnoczi
The sentence explaining the deprecation schedule is ambiguous. Make it clear that a feature deprecated in the Nth release is guaranteed to remain available in the N+1th release. Removal can occur in the N+2nd release or later. As an example of this in action, see commit

[libvirt PATCH] vircgroupv2devices: fix counting entries in BPF map

2020-08-11 Thread Pavel Hrdina
BPF syscall BPF_MAP_GET_NEXT_KEY returns -1 if something fails but it will also return -1 if trying to get next key using the last key in the map with errno set to ENOENT. If there are VMs running and libvirtd is restarted and user tries to call some cgroup devices operation on a VM we need to

Re: [libvirt PATCH] kbase: sev: Provide more details on virtio-net configuration

2020-08-11 Thread Erik Skultety
On Fri, Aug 07, 2020 at 07:05:22PM +0200, Laszlo Ersek wrote: > On 08/07/20 13:21, Erik Skultety wrote: > > With virtio-net further configuration settings are required, so document > > them and while at it, fix the Q35 machine XML example which wouldn't > > work with SEV because of not disabling

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

2020-08-11 Thread Zhong, Luyao
On 8/7/2020 4:24 PM, Martin Kletzander wrote: On Fri, Aug 07, 2020 at 01:27:59PM +0800, Zhong, Luyao wrote: On 8/3/2020 7:00 PM, Martin Kletzander wrote: On Mon, Aug 03, 2020 at 05:31:56PM +0800, Luyao Zhong wrote: Hi Libvirt experts, I would like enhence the numatune snippet

Re: [PATCH v2 10/13] qemu: avoid deadlock in qemuDomainObjStopWorker

2020-08-11 Thread Nikolay Shirokovskiy
On 10.08.2020 20:40, Daniel Henrique Barboza wrote: > > > On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: >> We are dropping the only reference here so that the event loop thread >> is going to be exited synchronously. In order to avoid deadlocks we >> need to unlock the VM so that any