Re: device compatibility interface for live migration with assigned devices

2020-08-12 Thread Jason Wang
On 2020/8/10 下午3:46, Yan Zhao wrote: driver is it handled by? It looks that the devlink is for network device specific, and in devlink.h, it says include/uapi/linux/devlink.h - Network physical device Netlink interface, Actually not, I think there used to have some discussion last year and

[PATCH v2] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer

2020-08-12 Thread Jin Yan
These leaks were introduced in commit 15d280fa97b0, use g_autofree for all cert_path pointers. Signed-off-by: Jin Yan --- src/rpc/virnettlscontext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-12 Thread Ian Wienand
On Wed, Aug 12, 2020 at 07:21:14PM -0400, Laine Stump wrote: > Yay! A user who follows up their conversation on the libvirt-users list with > a patch! :-) Heh, ipv6 in my work VM is my white whale, so, call me Ishmael :) > Unfortunately, on my Fedora 32 machine that has NetworkManager enabled,

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-12 Thread Laine Stump
Yay! A user who follows up their conversation on the libvirt-users list with a patch! :-) On 8/11/20 8:14 PM, Ian Wienand wrote: The checks modified here were added with 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing routes on hosts. I'm Cc'ing the author of that patch, Cédric

Re: [GSoC][PATCH 6/7] qemu_domainjob: removed reference to `qemuDomainObjPrivatePtr`

2020-08-12 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:48PM +0530, Prathamesh Chavan wrote: > References to `qemuDomainObjPrivatePtr` in qemu_domainjob > were removed as it is a qemu-hypervisor specific pointer. > > Signed-off-by: Prathamesh Chavan > --- This patch looks good. Erik

Re: [GSoC][PATCH 7/7] virmigraiton: `qemuMigrationJobPhase` transformed for more generic use

2020-08-12 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:49PM +0530, Prathamesh Chavan wrote: > `qemuMigrationJobPhase` was transformed into `virMigrationJobPhase` > and a common util file `virmigration` was created to store its > defination. > > Signed-off-by: Prathamesh Chavan > --- You basically just moved the QEMU

Re: [GSoC][PATCH 5/7] qemu_domainjob: added `getDomainXMLOptionPtr` callback function

2020-08-12 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:47PM +0530, Prathamesh Chavan wrote: > To remove dependency of funcitons to access the `privateData` of > qemu-domain, we introduce this callback funciton so that funcitons > get exactly what they need. > > Signed-off-by: Prathamesh Chavan > --- >

Re: [GSoC][PATCH 4/7] qemu_domain: funciton declarations moved to correct file

2020-08-12 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:46PM +0530, Prathamesh Chavan wrote: > Functions `qemuDomainRemoveInactiveJob` and > `qemuDomainRemoveInactiveJobLocked` had their declaration > mispalced in `qemu_domainjob` and were moved to s/mispalced/misplaced > `qemu_domain`. > > Signed-off-by: Prathamesh

Re: [GSoC][PATCH 3/7] qemu_domainjob: add `saveDomainStatus` as a callback function to jobs

2020-08-12 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:45PM +0530, Prathamesh Chavan wrote: > The function `qemuDomainObjSaveStatus` required an access to > `virQEMUDriverPtr`. > To make jobs hypervisor-agnostic we remove this funciton > and replace it with a callback function from `qemuDomainJob` > > Removal of

Re: [libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups

2020-08-12 Thread Ján Tomko
On a Tuesday in 2020, Pavel Hrdina wrote: If we don't have cgroups available and user tries to update blkio parameters for running VM it will crash. It should have been protected by the virCgroupHasController() check but it was never called if the API was executed without any flags. We call