Re: [PATCH v2] examples: Use GLib event loop impl in events.stp

2020-08-17 Thread Han Han
ping On Sun, Jul 26, 2020 at 7:33 PM Han Han wrote: > Update the events stap example because the event loop impl is replaced by > GLib based event loop impl after commit 55fe8110. > > Signed-off-by: Han Han > --- > examples/systemtap/events.stp | 26 -- > 1 file changed

Re: [PATCH v4 0/4] qemu: Support rbd namespace attribute

2020-08-17 Thread Han Han
ping On Fri, Aug 7, 2020 at 5:49 PM Han Han wrote: > Diff from v3: > - add the check for capability of rbd namespace > - rename the item of rbd namespace in disk source struct > - combine the commit of doc into the commit of patch > - remove the code for -drive > > gitlab branch: > https://gitla

Re: [PATCH 1/2] logging: Replace virMutex with GMutex

2020-08-17 Thread Han Han
ping On Wed, Aug 5, 2020 at 3:56 PM Han Han wrote: > Signed-off-by: Han Han > --- > src/logging/log_daemon.c | 26 ++ > src/logging/log_daemon.h | 4 ++-- > 2 files changed, 8 insertions(+), 22 deletions(-) > > diff --git a/src/logging/log_daemon.c b/src/logging/log_da

Re: [PATCH] kbase: Add knowledge base for libvirt systemtap

2020-08-17 Thread Han Han
ping, any more reviews? On Thu, Aug 6, 2020 at 9:44 PM Daniel Henrique Barboza < danielhb...@gmail.com> wrote: > > On 8/6/20 3:34 AM, Han Han wrote: > > Signed-off-by: Han Han > > --- > > docs/kbase.rst | 3 ++ > > docs/kbase/meson.build | 1 + > > docs/kbase/systemtap.rst |

Re: device compatibility interface for live migration with assigned devices

2020-08-17 Thread Jason Wang
On 2020/8/14 下午1:16, Yan Zhao wrote: On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote: On 2020/8/10 下午3:46, Yan Zhao wrote: driver is it handled by? It looks that the devlink is for network device specific, and in devlink.h, it says include/uapi/linux/devlink.h - Network physical d

Re: [PATCH 2/2] virdevmapper: Deal with unloading dm module

2020-08-17 Thread Andrea Bolognani
On Mon, 2020-08-17 at 17:28 +0200, Peter Krempa wrote: > On Mon, Aug 17, 2020 at 16:26:55 +0200, Michal Privoznik wrote: > > -if ((controlFD = virDMOpen()) < 0) > > +if ((controlFD = virDMOpen()) < 0) { > > +if (controlFD == -2) { > > +/* Devmapper was available but now

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Peter Krempa
On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: > On 8/17/20 5:16 PM, Peter Krempa wrote: > > On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: > > > In one of my latest patch (v6.6.0~30) I was trying to remove > > > libdevmapper use in favor of our own implementation.

Re: [PATCH 2/2] virdevmapper: Deal with unloading dm module

2020-08-17 Thread Michal Privoznik
On 8/17/20 5:28 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 16:26:55 +0200, Michal Privoznik wrote: The following situation can happen: we've initialized DM major successfully. But later, the devmapper module(s) was removed and thus kernel lost its ability to handle multipath devices. More i

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Michal Privoznik
On 8/17/20 5:16 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor of our own implementation. However, the code did not take into account that device mapper can be not comp

Re: [PATCH 2/2] virdevmapper: Deal with unloading dm module

2020-08-17 Thread Peter Krempa
On Mon, Aug 17, 2020 at 16:26:55 +0200, Michal Privoznik wrote: > The following situation can happen: we've initialized DM major > successfully. But later, the devmapper module(s) was removed and > thus kernel lost its ability to handle multipath devices. More > importantly, the /dev/mapper/control

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Peter Krempa
On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: > In one of my latest patch (v6.6.0~30) I was trying to remove > libdevmapper use in favor of our own implementation. However, the > code did not take into account that device mapper can be not > compiled into the kernel (e.g. be a sep

[PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Michal Privoznik
In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor of our own implementation. However, the code did not take into account that device mapper can be not compiled into the kernel (e.g. be a separate module that's not loaded) in which case /proc/devices won't have t

[PATCH 0/2] virdevmapper: Deal with kernels without DM support

2020-08-17 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): virdevmapper: Don't error on kernels without DM support virdevmapper: Deal with unloading dm module src/util/virdevmapper.c | 59 - 1 file changed, 47 insertions(+), 12 deletions(-) -- 2.26.2

[PATCH 2/2] virdevmapper: Deal with unloading dm module

2020-08-17 Thread Michal Privoznik
The following situation can happen: we've initialized DM major successfully. But later, the devmapper module(s) was removed and thus kernel lost its ability to handle multipath devices. More importantly, the /dev/mapper/control file is removed and thus our attempt to open it will fail. Note, we wil

Re: [PATCH] Xen: Improve parsing of PCI addresses in config converter

2020-08-17 Thread Christoph
thx! --- -- Greetz Am 11.08.2020 01:14, schrieb Jim Fehlig: There was a report on libvirt-users [1] about the domxml to/from native converter in the Xen driver not handling PCI addresses without a domain specification. This patch improves parsing of PCI addresses in the converter and allows

[PATCH] docs: build: Fix links to 'edit this page' for kbase/manpages/internals

2020-08-17 Thread Peter Krempa
Commit 862cf2ace4f04dadc175caacc74448e96c625ccb modified the generator to base edit links in the root of the repository but forgot to add the 'docs/' prefix to the code generating kbase articles, manpages and the internals documentation. Signed-off-by: Peter Krempa --- docs/internals/meson.build

Re: [libvirt PATCH] docs: improve auth service listing

2020-08-17 Thread Andrea Bolognani
On Mon, 2020-08-17 at 09:55 +0200, Pino Toscano wrote: > Slightly improve the list of known authentication service types: > - reword 'ssh' to mention it is used for the ssh driver (for remote > QEMU), and stop mentioning the removed Phyp driver > - add 'hyperv', used by the HyperV driver > - alph

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

2020-08-17 Thread Martin Kletzander
On Tue, Aug 11, 2020 at 04:39:42PM +0800, Zhong, Luyao wrote: On 8/7/2020 4:24 PM, Martin Kletzander wrote: On Fri, Aug 07, 2020 at 01:27:59PM +0800, Zhong, Luyao wrote: On 8/3/2020 7:00 PM, Martin Kletzander wrote: On Mon, Aug 03, 2020 at 05:31:56PM +0800, Luyao Zhong wrote: Hi Libvirt e

[libvirt PATCH] docs: improve auth service listing

2020-08-17 Thread Pino Toscano
Slightly improve the list of known authentication service types: - reword 'ssh' to mention it is used for the ssh driver (for remote QEMU), and stop mentioning the removed Phyp driver - add 'hyperv', used by the HyperV driver - alphabetically sort the list - use a bulletted list instead of a numb