On Wed, Aug 19, 2020 at 12:15 PM Christian Ehrhardt
wrote:
>
> In libvirt 6.6 stopping guests with libvirt-guests.sh is broken.
> As soon as there is more than one guest one can see
> `systemctl stop libvirt-guests` faiing and in the log we see:
> libvirt-guests.sh[2455]: Running guests on
On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote:
> On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote:
> > On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> > > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > > Daniel P.
On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote:
> On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Tue, Aug 18, 2020 at
On Wed, Aug 19, 2020 at 09:22:34PM -0600, Alex Williamson wrote:
> On Thu, 20 Aug 2020 08:39:22 +0800
> Yan Zhao wrote:
>
> > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Tue, Aug 18,
On Wed, Aug 19, 2020 at 09:13:45PM -0600, Alex Williamson wrote:
> On Thu, 20 Aug 2020 08:18:10 +0800
> Yan Zhao wrote:
>
> > On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
> > <...>
> > > > > > > What I care about is that we have a *standard* userspace API for
> > > > > > >
On Thu, 20 Aug 2020 08:39:22 +0800
Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > On Tue, 18 Aug 2020 10:16:28 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > > >On 2020/8/18 下午4:55,
On Thu, 20 Aug 2020 08:18:10 +0800
Yan Zhao wrote:
> On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
> <...>
> > > > > > What I care about is that we have a *standard* userspace API for
> > > > > > performing device compatibility checking / state migration, for use
> > > > > >
On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > On Tue, 18 Aug 2020 10:16:28 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > > >On 2020/8/18 下午4:55, Daniel P.
On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> On Tue, 18 Aug 2020 10:16:28 +0100
> Daniel P. Berrangé wrote:
>
> > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
> > >
> > > On Tue, Aug 18, 2020 at
On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
<...>
> > > > > What I care about is that we have a *standard* userspace API for
> > > > > performing device compatibility checking / state migration, for use by
> > > > > QEMU/libvirt/ OpenStack, such that we can write code without
Hi Philipp,
(Cc: Daniel, because IIUC you reviewed !16 which got this merged),
I'm sorry I didn't notice this earlier, but the commit f4be03b3 dated
2020-04-20 [0] is wrong. The super().__init__(*args, **kwargs) in
Callback.__init__ was there on purpose, because of how Python's inheritance in
On Wed, 19 Aug 2020 11:30:35 +0800
Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> > Hi Cornelia,
> >
> > > From: Cornelia Huck
> > > Sent: Tuesday, August 18, 2020 3:07 PM
> > > To: Daniel P. Berrangé
> > > Cc: Jason Wang ; Yan Zhao
> > > ;
On Wed, Aug 19, 2020 at 05:04:58PM +0200, Michal Privoznik wrote:
> On 8/19/20 2:00 PM, Erik Skultety wrote:
> > On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote:
> > > On 8/18/20 10:48 AM, Erik Skultety wrote:
> > > > On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan
On Tue, Aug 18, 2020 at 07:49:30AM +, Zang, Rui wrote:
-Original Message-
From: Martin Kletzander
Sent: Monday, August 17, 2020 4:58 PM
To: Zhong, Luyao
Cc: libvir-list@redhat.com; Zang, Rui ; Michal Privoznik
Subject: Re: [libvirt][RFC PATCH] add a new 'default' option for
On 8/19/20 2:00 PM, Erik Skultety wrote:
On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote:
On 8/18/20 10:48 AM, Erik Skultety wrote:
On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote:
Reference to `maxQueuedJobs` required us to access
config of the qemu-driver.
Polite ping to the mailing list regarding this bug. I recall the logic I
proposed belongs elsewhere, but I'd like to kindly request a followup
from the respective maintainer(s) for a direction.
Thanks!
On 6/26/20 2:31 PM, Collin Walling wrote:
> On 6/26/20 3:22 AM, Peter Krempa wrote:
>> On Thu,
On Wed, 19 Aug 2020 11:55:06 +0100
Daniel P. Berrangé wrote:
> On Wed, Aug 19, 2020 at 12:03:41PM +0200, Natanael Copa wrote:
> > Add a portable generic implementation of virMassClose as fallback on
> > non-FreeBSD and non-glibc.
> >
> > This implementation uses poll(2) to look for open files
On Wed, Aug 19, 2020 at 4:13 PM Michal Privoznik wrote:
>
> So far, only ENOENT is ignored (to deal with kernels without
> devmapper). However, as reported on the list, under certain
> scenarios a different error can occur. For instance, when libvirt
> is running inside a container which doesn't
Right now we're unconditionally adding RPATH information to the
installed binaries and libraries, but that's not always desired.
autotools seem to be smart enough to only include that information
when targeting a non-standard prefix, so most distro packages
don't actually contain it; moreover,
On Wed, 2020-08-19 at 15:10 +0200, Pavel Hrdina wrote:
> On Wed, Aug 19, 2020 at 02:58:07PM +0200, Andrea Bolognani wrote:
> > > > We can add an option like it was proposed in V1 but with the following
> > > > changes. In meson.build we would have this:
> > > >
> > > > if get_option('rpath')
So far, only ENOENT is ignored (to deal with kernels without
devmapper). However, as reported on the list, under certain
scenarios a different error can occur. For instance, when libvirt
is running inside a container which doesn't have permissions to
talk to the devmapper. If this is the case,
On Wed, Aug 19, 2020 at 1:39 AM Andrea Bolognani wrote:
>
> Found while updating the Debian package for libvirt to a snapshot
> taken from master. Possibly more to come.
>
> Andrea Bolognani (2):
> meson: Set WITH_APPARMOR_PROFILES
> meson: Don't hardcode /etc in APPARMOR_DIR
Thanks a lot
On Wed, Aug 19, 2020 at 02:58:07PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-08-19 at 13:16 +0100, Daniel P. Berrangé wrote:
> > On Wed, Aug 19, 2020 at 02:10:53PM +0200, Pavel Hrdina wrote:
> > > So I managed to remember what was the issue. If you run install libvirt
> > > into custom
On Wed, 2020-08-19 at 13:16 +0100, Daniel P. Berrangé wrote:
> On Wed, Aug 19, 2020 at 02:10:53PM +0200, Pavel Hrdina wrote:
> > So I managed to remember what was the issue. If you run install libvirt
> > into custom directory like this:
> >
> > meson build --prefix /my/custom/dir
> >
On Wed, Aug 19, 2020 at 01:16:17PM +0100, Daniel P. Berrangé wrote:
> On Wed, Aug 19, 2020 at 02:10:53PM +0200, Pavel Hrdina wrote:
> > On Wed, Aug 19, 2020 at 01:22:58PM +0200, Pavel Hrdina wrote:
> > > On Wed, Aug 19, 2020 at 12:47:40PM +0200, Andrea Bolognani wrote:
> > > > Right now we're
On Wed, Aug 19, 2020 at 02:10:53PM +0200, Pavel Hrdina wrote:
> On Wed, Aug 19, 2020 at 01:22:58PM +0200, Pavel Hrdina wrote:
> > On Wed, Aug 19, 2020 at 12:47:40PM +0200, Andrea Bolognani wrote:
> > > Right now we're unconditionally adding RPATH information to the
> > > installed binaries and
On Wed, Aug 19, 2020 at 01:22:58PM +0200, Pavel Hrdina wrote:
> On Wed, Aug 19, 2020 at 12:47:40PM +0200, Andrea Bolognani wrote:
> > Right now we're unconditionally adding RPATH information to the
> > installed binaries and libraries, but that's not always desired.
> >
> > Debian explicitly
On Wed, 2020-08-19 at 13:22 +0200, Pavel Hrdina wrote:
> On Wed, Aug 19, 2020 at 12:47:40PM +0200, Andrea Bolognani wrote:
> > Given the above, it looks like it's actually better to not go
> > out of our way to include that information in the first place.
>
> I need to look into this because I
On Wed, Aug 19, 2020 at 01:45:37PM +0200, Michal Privoznik wrote:
> On 8/18/20 10:48 AM, Erik Skultety wrote:
> > On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote:
> > > Reference to `maxQueuedJobs` required us to access
> > > config of the qemu-driver. And creating its copy in
>
On 8/18/20 10:48 AM, Erik Skultety wrote:
On Mon, Aug 17, 2020 at 10:37:18AM +0530, Prathamesh Chavan wrote:
Reference to `maxQueuedJobs` required us to access
config of the qemu-driver. And creating its copy in
the `qemuDomainJob` helped us access the variable
without referencing the driver's
On Wed, Aug 19, 2020 at 12:47:40PM +0200, Andrea Bolognani wrote:
> Right now we're unconditionally adding RPATH information to the
> installed binaries and libraries, but that's not always desired.
>
> Debian explicitly passes --disable-rpath to configure, and while
> I haven't been able to find
On 8/19/20 10:50 AM, Christian Ehrhardt wrote:
So EPERM it is, would you add a change ignoring that RC please?
Thanks for detailed description. Will post patch shortly.
Michal
On Wed, Aug 19, 2020 at 12:03:40PM +0200, Natanael Copa wrote:
> Doing malloc/free after fork is techincally not allowed in POSIX and
> deadlocks[1] with musl libc.
Removing one free() call isn't going to make the logging code
work with musl. It merely hides one isolated instance that
happens to
On Wed, Aug 19, 2020 at 12:03:41PM +0200, Natanael Copa wrote:
> Add a portable generic implementation of virMassClose as fallback on
> non-FreeBSD and non-glibc.
>
> This implementation uses poll(2) to look for open files to keep
> performance reasonable while not using any mallocs.
The patch
Right now we're unconditionally adding RPATH information to the
installed binaries and libraries, but that's not always desired.
Debian explicitly passes --disable-rpath to configure, and while
I haven't been able to find the same option in the spec file for
either Fedora or RHEL, by running
$
Changes since [v1]
* drop RPATH usage completely instead of making it conditional.
[v1] https://www.redhat.com/archives/libvir-list/2020-August/msg00599.html
Andrea Bolognani (1):
meson: Drop RPATH usage
src/meson.build | 6 --
tools/meson.build | 4
2 files changed, 10
On Wed, 2020-08-19 at 11:27 +0100, Daniel P. Berrangé wrote:
> On Wed, Aug 19, 2020 at 12:18:07PM +0200, Andrea Bolognani wrote:
> > Given the above I'm not actually sure whether there even is a
> > valid usecase for RPATH, but I will openly admit I don't
> > understand the problem space well
On Wed, Aug 19, 2020 at 12:18:07PM +0200, Andrea Bolognani wrote:
> Right now we're unconditionally adding RPATH information to the
> installed binaries and libraries, but that's not always desired
>
> Debian explicitly passes --disable-rpath to configure, and while
> I haven't been able to find
Neither Fedora nor RHEL seem to include RPATH information in
the binaries and libraries they currently ship, so let's make
sure RPMs built from upstream sources match that behavior.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git
See 1/2 for details.
Andrea Bolognani (2):
meson: Introduce rpath option
spec: Disable RPATH
libvirt.spec.in | 1 +
meson.build | 7 +
meson_options.txt | 1 +
src/meson.build | 485 +++---
tools/meson.build | 332
Right now we're unconditionally adding RPATH information to the
installed binaries and libraries, but that's not always desired.
Debian explicitly passes --disable-rpath to configure, and while
I haven't been able to find the same option in the spec file for
either Fedora or RHEL, by running
$
Fix a couple of deadlocks due to use of async-unsafe calls (malloc/free)
after fork() and before exec(). They don't fix all theoretical problems
but at least they make libvirt usable again with musl 1.2 on Alpine Linux.
Natanael Copa (2):
util: avoid free() when reset log after fork
util:
Doing malloc/free after fork is techincally not allowed in POSIX and
deadlocks[1] with musl libc.
[1]: https://gitlab.com/libvirt/libvirt/-/issues/52
Signed-off-by: Natanael Copa
---
src/util/vircommand.c | 4 ++--
src/util/virlog.c | 44 +--
Add a portable generic implementation of virMassClose as fallback on
non-FreeBSD and non-glibc.
This implementation uses poll(2) to look for open files to keep
performance reasonable while not using any mallocs.
This solves a deadlock with musl libc.
Signed-off-by: Natanael Copa
---
In libvirt 6.6 stopping guests with libvirt-guests.sh is broken.
As soon as there is more than one guest one can see
`systemctl stop libvirt-guests` faiing and in the log we see:
libvirt-guests.sh[2455]: Running guests on default URI:
libvirt-guests.sh[2457]:
On 2020/8/19 下午1:58, Parav Pandit wrote:
From: Yan Zhao
Sent: Wednesday, August 19, 2020 9:01 AM
On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
Please refer to my previous email which has more example and details.
hi Parav,
the example is based on a new vdpa tool running
On 2020/8/19 下午4:13, Yan Zhao wrote:
On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote:
On 2020/8/19 下午2:59, Yan Zhao wrote:
On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote:
On 2020/8/19 上午11:30, Yan Zhao wrote:
hi All,
could we decide that sysfs is the interface that
On Tue, Aug 18, 2020 at 12:47 PM Christian Ehrhardt
wrote:
>
> On Tue, Aug 18, 2020 at 12:11 PM Christian Ehrhardt
> wrote:
> >
> > On Tue, Aug 18, 2020 at 11:36 AM Michal Privoznik
> > wrote:
> > >
> > > v2 of:
> > >
> > > https://www.redhat.com/archives/libvir-list/2020-August/msg00489.html
On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote:
>
> On 2020/8/19 下午2:59, Yan Zhao wrote:
> > On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote:
> > > On 2020/8/19 上午11:30, Yan Zhao wrote:
> > > > hi All,
> > > > could we decide that sysfs is the interface that every VFIO
On 2020/8/19 下午2:59, Yan Zhao wrote:
On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote:
On 2020/8/19 上午11:30, Yan Zhao wrote:
hi All,
could we decide that sysfs is the interface that every VFIO vendor driver
needs to provide in order to support vfio live migration, otherwise the
On Tue, 2020-08-18 at 20:41 +0100, Daniel P. Berrangé wrote:
> We have dropped autotools entirely in favour of meson+ninja as our
> build system. This will be in the 6.7.0 release in just under 2
> weeks time.
>
> So I'd suggest you do the minimum possible to get 6.6.0 working on
> homebrew, by
On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote:
>
> On 2020/8/19 上午11:30, Yan Zhao wrote:
> > hi All,
> > could we decide that sysfs is the interface that every VFIO vendor driver
> > needs to provide in order to support vfio live migration, otherwise the
> > userspace management tool
On 2020/8/19 上午11:30, Yan Zhao wrote:
hi All,
could we decide that sysfs is the interface that every VFIO vendor driver
needs to provide in order to support vfio live migration, otherwise the
userspace management tool would not list the device into the compatible
list?
if that's true, let's
> From: Jason Wang
> Sent: Wednesday, August 19, 2020 12:19 PM
>
>
> On 2020/8/19 下午1:26, Parav Pandit wrote:
> >
> >> From: Jason Wang
> >> Sent: Wednesday, August 19, 2020 8:16 AM
> >
> >> On 2020/8/18 下午5:32, Parav Pandit wrote:
> >>> Hi Jason,
> >>>
> >>> From: Jason Wang
> >>> Sent:
On 2020/8/19 下午1:26, Parav Pandit wrote:
From: Jason Wang
Sent: Wednesday, August 19, 2020 8:16 AM
On 2020/8/18 下午5:32, Parav Pandit wrote:
Hi Jason,
From: Jason Wang
Sent: Tuesday, August 18, 2020 2:32 PM
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at
55 matches
Mail list logo
