Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-21 Thread Andrea Bolognani
On Friday, August 21, 2020 10:05:21 AM, Christian Ehrhardt wrote: > > , and your > > suggested change would make these assignments work even on shells that do > > not apply special parsing rules for it. > > Thanks, I also have pushed this through a bunch of tests that use > libvirt-guests.sh on mu

Re: [PATCH] virnuma: Don't work around numa_node_to_cpus() for non-existent nodes

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 05:12:08PM +0200, Michal Privoznik wrote: > In a very distant past, we came around machines that has not > continuous node IDs. This made us error out when constructing > capabilities XML. We resolved it by utilizing strange behaviour > of numa_node_to_cpus() in which it ret

[PATCH] virnuma: Don't work around numa_node_to_cpus() for non-existent nodes

2020-08-21 Thread Michal Privoznik
In a very distant past, we came around machines that has not continuous node IDs. This made us error out when constructing capabilities XML. We resolved it by utilizing strange behaviour of numa_node_to_cpus() in which it returned a mask with all bits set for a non-existent node. However, this is n

Re: [libvirt PATCH v2 06/16] nodedev: add STOPPED/STARTED lifecycle events

2020-08-21 Thread Erik Skultety
On Tue, Aug 18, 2020 at 09:47:56AM -0500, Jonathon Jongsma wrote: > Since a mediated device can be persistently defined by the mdevctl > backend, we need additional lifecycle events beyond CREATED/DELETED to > indicate that e.g. the device has been stopped but the device definition > still exists.

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-21 Thread Cornelia Huck
On Fri, 21 Aug 2020 11:14:41 +0800 Jason Wang wrote: > On 2020/8/20 下午8:27, Cornelia Huck wrote: > > On Wed, 19 Aug 2020 17:28:38 +0800 > > Jason Wang wrote: > > > >> On 2020/8/19 下午4:13, Yan Zhao wrote: > >>> On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: > On 2020/8/19

[PATCH] qemu_namespace: Don't build namespace if domain doesn't have it enabled

2020-08-21 Thread Michal Privoznik
Even if namespaces are disabled, then due to a missing check at the beginning of qemuDomainBuildNamespace(), the domain startup code still tries to populate (nonexistent) domain's namespace. Fixes: 8da362fe62766b4eee209cd3ce591ceb62299d13 Signed-off-by: Michal Privoznik --- src/qemu/qemu_namespa

Re: [PATCH v3 5/6] tests: schema: test bhyvexml2xmloutdata schemas

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 05:00:01PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrangé wrote: > > > On Fri, Aug 07, 2020 at 07:09:34PM +0400, Roman Bogorodskiy wrote: > > > Signed-off-by: Roman Bogorodskiy > > > --- > > > tests/virschematest.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1

Re: Conflicting parameters on qemu call

2020-08-21 Thread Jan Walzer
On 21. Aug 2020, at 13:55, Daniel P. Berrangé wrote: > On Fri, Aug 21, 2020 at 01:38:23PM +0200, Jan Walzer wrote: >> On 21. Aug 2020, at 11:20, Daniel P. Berrangé wrote: >>> On Fri, Aug 21, 2020 at 11:19:14AM +0200, Jan Walzer wrote: Hi Daniel, > On 21. Aug 2020, at 11:07, Daniel P. Ber

Re: [PATCH v3 5/6] tests: schema: test bhyvexml2xmloutdata schemas

2020-08-21 Thread Roman Bogorodskiy
Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 07:09:34PM +0400, Roman Bogorodskiy wrote: > > Signed-off-by: Roman Bogorodskiy > > --- > > tests/virschematest.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Daniel P. Berrangé > Will merging this patch al

[libvirt PATCH] virsh: guest-agent-timeout: set default value for optional argument

2020-08-21 Thread Tomáš Golembiovský
The timeout argument for guest-agent-timeout is optional but it did not have proper default value specified. Also update the virsh man page accordingly. Signed-off-by: Tomáš Golembiovský --- docs/manpages/virsh.rst | 7 --- tools/virsh-domain.c| 2 +- 2 files changed, 5 insertions(+), 4

[libvirt PATCH] docs: fix names of some commands

2020-08-21 Thread Tomáš Golembiovský
Some commands were improperly converted from original POD file. Their names were stripped after first dash. Signed-off-by: Tomáš Golembiovský --- docs/manpages/virsh.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/v

Re: [PATCH v4 0/4] qemu: Support rbd namespace attribute

2020-08-21 Thread Jason Dillaman
On Fri, Aug 7, 2020 at 5:50 AM Han Han wrote: > > Diff from v3: > - add the check for capability of rbd namespace > - rename the item of rbd namespace in disk source struct > - combine the commit of doc into the commit of patch > - remove the code for -drive > > gitlab branch: > https://gitlab.com

Re: Conflicting parameters on qemu call

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 01:38:23PM +0200, Jan Walzer wrote: > On 21. Aug 2020, at 11:20, Daniel P. Berrangé wrote: > > On Fri, Aug 21, 2020 at 11:19:14AM +0200, Jan Walzer wrote: > >> Hi Daniel, > >>> On 21. Aug 2020, at 11:07, Daniel P. Berrangé wrote: > >>> On Fri, Aug 21, 2020 at 11:00:27AM +0

Re: [libvirt PATCH v2 05/16] nodedev: add ability to list and parse defined mdevs

2020-08-21 Thread Erik Skultety
On Tue, Aug 18, 2020 at 09:47:55AM -0500, Jonathon Jongsma wrote: > This adds some internal API to query for persistent mediated devices > that are defined by mdevctl. Following commits will make use of this > information. This just provides the infrastructure and tests for this > feature. One test

Re: Conflicting parameters on qemu call

2020-08-21 Thread Jan Walzer
On 21. Aug 2020, at 11:20, Daniel P. Berrangé wrote: > On Fri, Aug 21, 2020 at 11:19:14AM +0200, Jan Walzer wrote: >> Hi Daniel, >>> On 21. Aug 2020, at 11:07, Daniel P. Berrangé wrote: >>> On Fri, Aug 21, 2020 at 11:00:27AM +0200, Jan Walzer wrote: On 21. Aug 2020, at 10:38, Daniel P. Berra

[libvirt PATCH] rpm: always disable ceph on 32-bit

2020-08-21 Thread Daniel P . Berrangé
The logic to disable Ceph on 32-bit was protected by a Fedora conditional. This is redundant as RHEL doesn't build on 32-bit platforms for years. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/li

[PATCH] qemu.conf: Re-word the description for *_tls_x509_verify

2020-08-21 Thread Fangge Jin
The original descirption for *_tls_x509_verify is a little misleading by saying that "Enabling this option will reject any client who does not have a ca-cert.pem certificate". Signed-off-by: Fangge Jin --- src/qemu/qemu.conf | 20 1 file changed, 8 insertions(+), 12 deletion

Re: [PATCH v4 2/4] conf: Support to parse rbd namespace attribute

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 05:49:13PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/formatdomain.rst | 5 - > docs/schemas/domaincommon.rng | 3 +++ > src/conf/domain_conf.c| 4 > src/util/virstoragefile.h | 1 + > 4 files changed, 12 insertions(+), 1 delet

Re: [PATCH v4 4/4] news: qemu: Support rbd namespace

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 05:49:15PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvir

Re: [PATCH v4 3/4] qemu: Implement rbd namespace attribute

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 05:49:14PM +0800, Han Han wrote: > Ceph Nautilus supports separate image namespaces within a pool for > tenant isolation and QEMU added it as a rbd blockdev options from 5.0.0. > This optional attribute is used to access a image with namespace. > > Add unit tests for this a

Re: [PATCH v4 1/4] qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 05:49:12PM +0800, Han Han wrote: > Add rbd namespace in aarch64 capability replies. > > The capability flag will be used for rbd namespace option. The rbd namespace > is introduced since ceph Nautilus and qemu v5.0.0. > > Signed-off-by: Han Han > --- > src/qemu/qemu_capa

Re: [PATCH v2] examples: Use GLib event loop impl in events.stp

2020-08-21 Thread Daniel P . Berrangé
On Sun, Jul 26, 2020 at 07:33:12PM +0800, Han Han wrote: > Update the events stap example because the event loop impl is replaced by > GLib based event loop impl after commit 55fe8110. > > Signed-off-by: Han Han > --- > examples/systemtap/events.stp | 26 -- > 1 file chan

Re: [PATCH] kbase: Add knowledge base for libvirt systemtap

2020-08-21 Thread Daniel P . Berrangé
On Thu, Aug 06, 2020 at 02:34:02PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/kbase.rst | 3 ++ > docs/kbase/meson.build | 1 + > docs/kbase/systemtap.rst | 113 +++ > 3 files changed, 117 insertions(+) > create mode 100644 doc

Re: [PATCH 1/2] logging: Replace virMutex with GMutex

2020-08-21 Thread Daniel P . Berrangé
On Wed, Aug 05, 2020 at 03:56:17PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > src/logging/log_daemon.c | 26 ++ > src/logging/log_daemon.h | 4 ++-- > 2 files changed, 8 insertions(+), 22 deletions(-) > > diff --git a/src/logging/log_daemon.c b/src/logging/lo

Re: [PATCH 2/2] locking: Replace virMutex with GMutex

2020-08-21 Thread Daniel P . Berrangé
On Wed, Aug 05, 2020 at 03:56:18PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > src/locking/lock_daemon.c | 32 +- > src/locking/lock_daemon.h | 4 ++-- > src/locking/lock_daemon_dispatch.c | 32 +++--- > 3 files cha

Re: [libvirt PATCH v2 04/16] virsh: Add --active, --inactive, --all to nodedev-list

2020-08-21 Thread Erik Skultety
On Tue, Aug 18, 2020 at 09:47:54AM -0500, Jonathon Jongsma wrote: > Now that we can filter active and inactive node devices in > virConnectListAllNodeDevices(), add these switches to the virsh command. > > Eventual output (once everything is hooked up): > > virsh # nodedev-list --inactive --cap

[PATCH] qemu_validate: Only allow none address for watchdog ib700

2020-08-21 Thread Han Han
Since QEMU 1.5.3, the ib700 watchdog device has no options for address, and not address in device tree: $ /usr/libexec/qemu-kvm -version QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c) 2003-2008 Fabrice Bellard $ /usr/libexec/qemu-kvm -device ib700,\? $ virsh qemu-monitor-comm

Re: Conflicting parameters on qemu call

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 11:19:14AM +0200, Jan Walzer wrote: > Hi Daniel, > > On 21. Aug 2020, at 11:07, Daniel P. Berrangé wrote: > > On Fri, Aug 21, 2020 at 11:00:27AM +0200, Jan Walzer wrote: > >> On 21. Aug 2020, at 10:38, Daniel P. Berrangé wrote: > >>> On Thu, Aug 20, 2020 at 08:11:30PM +020

Re: Conflicting parameters on qemu call

2020-08-21 Thread Jan Walzer
Hi Daniel, > On 21. Aug 2020, at 11:07, Daniel P. Berrangé wrote: > On Fri, Aug 21, 2020 at 11:00:27AM +0200, Jan Walzer wrote: >> On 21. Aug 2020, at 10:38, Daniel P. Berrangé wrote: >>> On Thu, Aug 20, 2020 at 08:11:30PM +0200, Jan Walzer wrote: Hi Lists, I currently have the is

Re: [PATCH v2 13/17] virfdstream: Allow sparse stream vol-download

2020-08-21 Thread Michal Privoznik
On 8/20/20 3:42 PM, Peter Krempa wrote: On Thu, Aug 20, 2020 at 15:31:28 +0200, Michal Privoznik wrote: On 8/20/20 1:57 PM, Peter Krempa wrote: On Tue, Jul 07, 2020 at 21:46:31 +0200, Michal Privoznik wrote: When handling sparse stream, a thread is executed. This thread runs a read() or write(

Re: Conflicting parameters on qemu call

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 11:00:27AM +0200, Jan Walzer wrote: > On 21. Aug 2020, at 10:38, Daniel P. Berrangé wrote: > > On Thu, Aug 20, 2020 at 08:11:30PM +0200, Jan Walzer wrote: > >> Hi Lists, > >> > >> I currently have the issue of wanting to use emu-system-x86_64 on a > >> ppc64le platform. >

Re: Conflicting parameters on qemu call

2020-08-21 Thread Jan Walzer
On 21. Aug 2020, at 10:38, Daniel P. Berrangé wrote: > On Thu, Aug 20, 2020 at 08:11:30PM +0200, Jan Walzer wrote: >> Hi Lists, >> >> I currently have the issue of wanting to use emu-system-x86_64 on a ppc64le >> platform. >> >> It is imperative to pass the "-accel tcg,thread=multi” parameter t

[PATCH] news: Document the `role` attribute for shmem device

2020-08-21 Thread Wang Xin
Signed-off-by: Wang Xin diff --git a/NEWS.rst b/NEWS.rst index 0669051ee6..be7274a184 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,12 @@ v6.7.0 (unreleased) * **New features** + * shmem: Add support for shmem-{plain, doorbell} ``role`` option + +The ``role`` attribute controls how

Re: Conflicting parameters on qemu call

2020-08-21 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 08:11:30PM +0200, Jan Walzer wrote: > Hi Lists, > > I currently have the issue of wanting to use emu-system-x86_64 on a ppc64le > platform. > > It is imperative to pass the "-accel tcg,thread=multi” parameter to qemu > when starting an instance, as without that, it wil

Conflicting parameters on qemu call

2020-08-21 Thread Jan Walzer
Hi Lists, I currently have the issue of wanting to use emu-system-x86_64 on a ppc64le platform. It is imperative to pass the "-accel tcg,thread=multi” parameter to qemu when starting an instance, as without that, it will only use one thread and hence of limited/no use. The problem is, that li

Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-21 Thread Christian Ehrhardt
On Thu, Aug 20, 2020 at 10:50 AM Michael Chapman wrote: > > On Thu, 20 Aug 2020, Christian Ehrhardt wrote: > > On Wed, Aug 19, 2020 at 12:15 PM Christian Ehrhardt > > wrote: > > > > > > In libvirt 6.6 stopping guests with libvirt-guests.sh is broken. > > > As soon as there is more than one guest