On Tue, Aug 25, 2020 at 07:47:09 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> tools/virsh-domain.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Jiri Denemark
On Tue, Aug 25, 2020 at 07:47:08 +0200, Martin Kletzander wrote:
> Instead of saving some data from a union up front and changing an overlayed
> struct before using said data, let's just set the new values after they are
> decided. This will increase the readability of future commit(s).
>
> Signe
On Tue, Aug 25, 2020 at 07:47:07 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 142faa2cf997..60ddfde65d4
This allows:
a) migration without access to network
b) complete control of the migration stream
c) easy migration between containerised libvirt daemons on the same host
Resolves: https://bugzilla.redhat.com/1638889
Signed-off-by: Martin Kletzander
---
docs/manpages/virsh.rst | 17 -
Instead of saving some data from a union up front and changing an overlayed
struct before using said data, let's just set the new values after they are
decided. This will increase the readability of future commit(s).
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_migration.c | 18 +-
KubeVirt would like to use this feature. For more information see individual
commits and changes in manpages and documentation.
Resolves: https://bugzilla.redhat.com/1638889
Martin Kletzander (9):
qemu: Use g_autofree in qemuMigrationSrcConnect
qemu: Rework qemuMigrationSrcConnect
virsh: R
For this we need to make the function accessible (at least privately). The
behaviour will change in following patches and the test helps explaining the
change.
Signed-off-by: Martin Kletzander
---
scripts/apibuild.py | 1 +
src/libvirt-domain.c | 4 +-
src/libvirt_internal.h | 2 +
Signed-off-by: Martin Kletzander
---
tools/virsh-domain.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1f3a549d9ab0..c606900a9268 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10704,7 +10704,6 @@ do
Adds new typed param for migration and uses this as a UNIX socket path that
should be used for the NBD part of migration. And also adds virsh support.
Partially resolves: https://bugzilla.redhat.com/1638889
Signed-off-by: Martin Kletzander
---
docs/manpages/virsh.rst | 8 +++
includ
Local socket connections were outright disabled because there was no "server"
part in the URI. However, given how requirements and usage scenarios are
evolving, some management apps might need the source libvirt daemon to connect
to the destination daemon over a UNIX socket for peer2peer migration
Signed-off-by: Martin Kletzander
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d92714c29b88..49c476be5d51 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,12 @@ v6.7.0 (unreleased)
Sparse streams (e.g. ``virsh vol-download --sparse`` or ``v
Clean up the semantics by using one extra self-describing variable.
This also fixes the port allocation when the port is specified.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_migration.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff -
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_migration.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 142faa2cf997..60ddfde65d46 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -33
On 2020-08-24 02:34, Daniel P. Berrangé wrote:
I don't think we want to keep compatibility with any libtool quirks. We
should do the right thing for the platform, and I think that means
using
the platform native suffix for shared library modles correctly.
Of course... we'd still have to deal
For iscsi-direct pool, the initiator is necessary for pool defining:
...
...
Add --source-initiator to fill the initiator iqn for
pool-create-as/pool-define-as subcommands.
https://bugzilla.redhat.com/show_bug.cgi?id=1658082
Signed-off-by: Han Han
---
docs/manpages/virsh.rs
On 8/24/20 8:01 PM, Laine Stump wrote:
On 8/24/20 6:28 PM, Daniel Henrique Barboza wrote:
On 8/23/20 1:52 AM, Laine Stump wrote:
Back when macvtap support was added in commit 315baab9443 in Feb. 2010
(libvirt-0.7.7), it was setup to autogenerate a name for the device if
one wasn't supplied
On 8/24/20 6:28 PM, Daniel Henrique Barboza wrote:
On 8/23/20 1:52 AM, Laine Stump wrote:
Back when macvtap support was added in commit 315baab9443 in Feb. 2010
(libvirt-0.7.7), it was setup to autogenerate a name for the device if
one wasn't supplied, in the pattern "macvtap%d" (or "macvlan%d
On 8/24/20 6:30 PM, Daniel Henrique Barboza wrote:
On 8/23/20 1:51 AM, Laine Stump wrote:
Back when the original version of this chunk of code was added (commit
41b087198 in libvirt-0.8.1 in April 2010), we used virExecDaemonize()
to start the qemu process, and would continue on in the functio
On 8/24/20 7:45 AM, Pino Toscano wrote:
Consider a couple of misspelt emails in B-y tags.
Signed-off-by: Pino Toscano
---
Reviewed-by: Daniel Henrique Barboza
docs/gitdm/aliases | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/gitdm/aliases b/docs/gitdm/aliases
index 83637b
On 8/23/20 1:52 AM, Laine Stump wrote:
Back when macvtap support was added in commit 315baab9443 in Feb. 2010
(libvirt-0.7.7), it was setup to autogenerate a name for the device if
one wasn't supplied, in the pattern "macvtap%d" (or "macvlan%d"),
similar to the way an unspecified standard tap
On 8/23/20 1:51 AM, Laine Stump wrote:
Back when the original version of this chunk of code was added (commit
41b087198 in libvirt-0.8.1 in April 2010), we used virExecDaemonize()
to start the qemu process, and would continue on in the function
(which at that time was called qemudStartVMDaemon
On Fri, Aug 21, 2020 at 12:30:09 +0100, Daniel P. Berrangé wrote:
> The logic to disable Ceph on 32-bit was protected by a Fedora
> conditional. This is redundant as RHEL doesn't build on 32-bit
> platforms for years.
But libvirt is still built on i686 even on RHEL for 32b libraries. And
this inc
On Thu, 2020-08-20 at 18:56 -0400, Laine Stump wrote:
> On 8/18/20 2:37 PM, Jonathon Jongsma wrote:
> > vDPA network devices allow high-performance networking in a virtual
> > machine by providing a wire-speed data path. These devices require
> > a
> > vendor-specific host driver but the data path
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d92714c29b..7ae4aa9340 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,17 @@ v6.7.0 (unreleased)
Sparse streams (e.g. ``virsh vol-download --sparse
On 8/24/20 6:52 PM, Daniel Henrique Barboza wrote:
On 8/24/20 1:44 PM, Michal Privoznik wrote:
On 7/30/20 9:47 PM, Daniel Henrique Barboza wrote:
Hi,
In [1] Andrea proposed that we should *not* auto-align down
the NVDIMM size for pSeries guests. Instead we should error
out and provide users
On 8/24/20 1:44 PM, Michal Privoznik wrote:
On 7/30/20 9:47 PM, Daniel Henrique Barboza wrote:
Hi,
In [1] Andrea proposed that we should *not* auto-align down
the NVDIMM size for pSeries guests. Instead we should error
out and provide users with a suggested aligned value. This
patch implemen
On 8/24/20 6:23 AM, Michal Privoznik wrote:
On 8/24/20 6:23 AM, Laine Stump wrote:
When these functions are called from within virnetdevmacvlan.c, they
are usually called with virNetDevMacVLanCreateMutex held, but when
virNetDevMacVLanReserveName() is called from other places (hypervisor
drivers
On Mon, Aug 24, 2020 at 17:05:54 +0200, Peter Krempa wrote:
> Use virJSONValueObjectCreate rather than creating the object
> piece-by-piece and use new accessors for bitmap to simplify the code.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration_params.c | 18 ++
> 1
On 8/24/20 1:44 PM, Michal Privoznik wrote:
On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote:
The existing auto-align behavior for pSeries has the idea to
alleviate user configuration of the NVDIMM size, given that the
alignment calculation is not trivial to do (256MiB alignment
of mem->size
On Fri, Aug 21, 2020 at 16:34:30 +0200, Michal Privoznik wrote:
> Even if namespaces are disabled, then due to a missing check at the
> beginning of qemuDomainBuildNamespace(), the domain startup code
> still tries to populate (nonexistent) domain's namespace.
>
> Fixes: 8da362fe62766b4eee209cd3ce
On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote:
The existing auto-align behavior for pSeries has the idea to
alleviate user configuration of the NVDIMM size, given that the
alignment calculation is not trivial to do (256MiB alignment
of mem->size - mem->label_size value, a.k.a guest area). We
On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote:
Next patch will use it outside of qemu_domain.c.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c
On 7/30/20 9:47 PM, Daniel Henrique Barboza wrote:
Hi,
In [1] Andrea proposed that we should *not* auto-align down
the NVDIMM size for pSeries guests. Instead we should error
out and provide users with a suggested aligned value. This
patch implements it.
[1] https://www.redhat.com/archives/libv
On 8/6/20 7:45 AM, Daniel P. Berrangé wrote:
When accessing libvirtd over a SSH tunnel, the remote driver needs a way
to proxy the SSH input/output stream to a suitable libvirt daemon. Tihs
s/Tihs/This
is currently done by spawning netcat, pointing it to the libvirtd socket
path. This is
On 8/6/20 7:45 AM, Daniel P. Berrangé wrote:
We have long had a problem with use of netcat for ssh tunnelling because
there's no guarantee the UNIX socket path the client builds will match
the UNIX socket path the remote host uses. We don't even allow session
mode SSH tunnelling for this reaso
On 8/24/20 5:39 PM, Pavel Hrdina wrote:
On Mon, Aug 24, 2020 at 05:33:21PM +0200, Peter Krempa wrote:
On Mon, Aug 24, 2020 at 17:01:50 +0200, Michal Privoznik wrote:
On 8/4/20 4:04 PM, Kashyap Chamarthy wrote:
Changes:
- Update the descriptions of --current & --config flags.
For --
On Mon, Aug 24, 2020 at 05:52:00PM +0200, Peter Krempa wrote:
> Commit 43620689794507308fbd3def6992a68ee2f8fa97 moved the function to
> util/virqemu.c which is compiled also on win32 and geteuid()/getegid()
> doesn't exist there.
>
> Move it to qemu_domain.c which is compiled only when the qemu dr
On Mon, Aug 24, 2020 at 17:52:00 +0200, Peter Krempa wrote:
> Commit 43620689794507308fbd3def6992a68ee2f8fa97 moved the function to
> util/virqemu.c which is compiled also on win32 and geteuid()/getegid()
> doesn't exist there.
>
> Move it to qemu_domain.c which is compiled only when the qemu driv
Commit 43620689794507308fbd3def6992a68ee2f8fa97 moved the function to
util/virqemu.c which is compiled also on win32 and geteuid()/getegid()
doesn't exist there.
Move it to qemu_domain.c which is compiled only when the qemu driver is
enabled. Originally I didn't want to put it here as qemu_domain.
On Mon, Aug 24, 2020 at 05:33:21PM +0200, Peter Krempa wrote:
> On Mon, Aug 24, 2020 at 17:01:50 +0200, Michal Privoznik wrote:
> > On 8/4/20 4:04 PM, Kashyap Chamarthy wrote:
> > > Changes:
> > >
> > >- Update the descriptions of --current & --config flags.
> > >
> > > For --config, the
On Mon, Aug 24, 2020 at 17:01:50 +0200, Michal Privoznik wrote:
> On 8/4/20 4:04 PM, Kashyap Chamarthy wrote:
> > Changes:
> >
> >- Update the descriptions of --current & --config flags.
> >
> > For --config, the reason to rephrase "next boot" to "next start"
> > is: "Next boot may
On Mon, Aug 24, 2020 at 05:24:51PM +0200, Peter Krempa wrote:
> On Mon, Aug 24, 2020 at 16:18:40 +0100, Daniel Berrange wrote:
> > On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter Krempa wrote:
> > > Signed-off-by: Peter Krempa
> > > ---
> > > src/libvirt_private.syms | 1 +
> > > src/qemu/qemu_
On 8/3/20 6:56 PM, Ján Tomko wrote:
Most of the changes required to build with
-Wdeclaration-after-statement seem pretty reasonable.
Not so sure about the lack of semicolon after
VIR_XPATH_NODE_AUTORESTORE
https://gitlab.com/jano.tomko/libvirt/-/pipelines/173793788
Ján Tomko (19):
util: virR
On Mon, Aug 24, 2020 at 16:18:40 +0100, Daniel Berrange wrote:
> On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter Krempa wrote:
> > Signed-off-by: Peter Krempa
> > ---
> > src/libvirt_private.syms | 1 +
> > src/qemu/qemu_driver.c | 138 ++-
> > src/util/vir
On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_driver.c | 138 ++-
> src/util/virqemu.c | 130
> src/util/virqemu
Signed-off-by: Peter Krempa
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d92714c29b..70c6684761 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,12 @@ v6.7.0 (unreleased)
* **New features**
+ * qemu: Add support for initiator IQN configurat
On Mon, Aug 24, 2020 at 10:52 AM Daniel P. Berrangé wrote:
>
> On Mon, Aug 24, 2020 at 10:19:59PM +0800, Han Han wrote:
> > On Fri, Aug 21, 2020 at 8:01 PM Jason Dillaman wrote:
> >
> > > On Fri, Aug 7, 2020 at 5:50 AM Han Han wrote:
> > > >
> > > > Diff from v3:
> > > > - add the check for capa
Use virJSONValueObjectCreate rather than creating the object
piece-by-piece and use new accessors for bitmap to simplify the code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qem
On 8/4/20 4:04 PM, Kashyap Chamarthy wrote:
Changes:
- Update the descriptions of --current & --config flags.
For --config, the reason to rephrase "next boot" to "next start"
is: "Next boot may still imply somebody selecting "reboot" in the
guest OS and fully expecting the cha
On Mon, Aug 24, 2020 at 10:19:59PM +0800, Han Han wrote:
> On Fri, Aug 21, 2020 at 8:01 PM Jason Dillaman wrote:
>
> > On Fri, Aug 7, 2020 at 5:50 AM Han Han wrote:
> > >
> > > Diff from v3:
> > > - add the check for capability of rbd namespace
> > > - rename the item of rbd namespace in disk so
On 8/24/20 11:36 AM, Ján Tomko wrote:
s/capsmoc.c/capsmock/
On a Monday in 2020, Daniel Henrique Barboza wrote:
Previous patch handled the runtime case where a non-x86 host is
fetching /proc/cpuinfo data for a microcode info that we know
it doesn't exist. This change alone speeded everything
A gentle 'ping' :-)
On Tue, Aug 04, 2020 at 04:04:03PM +0200, Kashyap Chamarthy wrote:
> Changes:
>
> - Update the descriptions of --current & --config flags.
>
> For --config, the reason to rephrase "next boot" to "next start"
> is: "Next boot may still imply somebody selecting "reboo
s/capsmoc.c/capsmock/
On a Monday in 2020, Daniel Henrique Barboza wrote:
Previous patch handled the runtime case where a non-x86 host is
fetching /proc/cpuinfo data for a microcode info that we know
it doesn't exist. This change alone speeded everything by a
bit for non-x86, but there is at lea
On Mon, Aug 24, 2020 at 15:27:40 +0200, Ján Tomko wrote:
> On a Monday in 2020, Peter Krempa wrote:
> > Use automatic memory allocation and move variables into correct scope to
> > simplify the code and remove the need for a 'error:' label.
> >
> > Signed-off-by: Peter Krempa
> > ---
> > src/qem
Signed-off-by: Jim Fehlig
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 0669051ee6..46bde7ea7a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,13 @@ v6.7.0 (unreleased)
* **New features**
+ * xen: Add ``writeFiltering`` attribute for PCI
By default Xen only allows guests to write "known safe" values into PCI
configuration space, yet many devices require writes to other areas of
the configuration space in order to operate properly. To allow writing
any values Xen supports the 'permissive' setting, see xl.cfg(5) man page.
This chang
This is V4 of Marek's series to support the xl.cfg(5) permissive setting on
PCI devices. Previous versions of the series
V3
https://www.redhat.com/archives/libvir-list/2020-August/msg00465.html
V2
https://www.redhat.com/archives/libvir-list/2020-April/msg01230.html
Changes from V3:
- Add a check
Add support for the writeFiltering attribute in the domXML to native
config converter. Also include a test.
Signed-off-by: Jim Fehlig
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/xen_common.c | 77
tests/xlconfigdata/test-fullvirt-pci.cfg |
On Fri, Aug 21, 2020 at 8:01 PM Jason Dillaman wrote:
> On Fri, Aug 7, 2020 at 5:50 AM Han Han wrote:
> >
> > Diff from v3:
> > - add the check for capability of rbd namespace
> > - rename the item of rbd namespace in disk source struct
> > - combine the commit of doc into the commit of patch
>
On a Monday in 2020, Daniel Henrique Barboza wrote:
Non-x86 archs does not have a 'microcode' version like x86. This is
covered already inside the function - just return 0 if no microcode
is found. Regardless of that, a read of /proc/cpuinfo is always made.
Each read will invoke the kernel to fil
On a Monday in 2020, Daniel Henrique Barboza wrote:
Use g_autofree and remove the cleanup label.
Signed-off-by: Daniel Henrique Barboza
---
src/util/virhostcpu.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signat
On a Monday in 2020, Peter Krempa wrote:
Use automatic memory allocation to simplify the code and remove the need
for a 'cleanup:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 33
1 file changed, 12 insertions(+), 21 deletions(-)
dif
On a Monday in 2020, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Monday in 2020, Peter Krempa wrote:
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'error:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 19 ++-
1 file changed, 6 insertions(+)
On a Monday in 2020, Peter Krempa wrote:
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'cleanup:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 40
1 file changed,
On a Monday in 2020, Peter Krempa wrote:
This function doesn't have an overly verbose cleanup section as there
isn't any error code path. Unify it with the rest of the functions which
will simplify adding a possible error path.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c |
Hi,
This started as a saga of figuring out why Libvirt was failing
to build in a Power 9 host after the switch to meson. Turns
out that one of the tests, qemuxml2argvtest, is taking almost
5 minutes to complete, and meson throws a timeout error. This
wasn't noticed before because the test actually
Use g_autofree and remove the cleanup label.
Signed-off-by: Daniel Henrique Barboza
---
src/util/virhostcpu.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 6cea75536d..d7aa39c131 100644
--- a/src/util/virhostcpu.c
On a Monday in 2020, Peter Krempa wrote:
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'error:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 24 +++-
1 file changed, 7 insertio
Previous patch handled the runtime case where a non-x86 host is
fetching /proc/cpuinfo data for a microcode info that we know
it doesn't exist. This change alone speeded everything by a
bit for non-x86, but there is at least one major culprit left.
qemuxml2argvtest does several arch-specific tests
Non-x86 archs does not have a 'microcode' version like x86. This is
covered already inside the function - just return 0 if no microcode
is found. Regardless of that, a read of /proc/cpuinfo is always made.
Each read will invoke the kernel to fill in the CPU details every time.
Now let's consider a
On a Monday in 2020, Peter Krempa wrote:
Use automatic memory cleaning and allocate via g_new0.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: P
On Tue, Aug 18, 2020 at 09:47:57AM -0500, Jonathon Jongsma wrote:
> At startup, query devices that are defined by 'mdevctl' and add them to
> the node device list.
>
> This adds a complication: we now have two potential sources of
> information for a node device:
> - udev for all devices and for a
On a Monday in 2020, Peter Krempa wrote:
The machine types for this cycle were already added and qemu also added
a property for the machine type object called "default-ram-id".
Also "block-bitmap-mapping" is supported as a migration parameter.
Signed-off-by: Peter Krempa
---
.../domaincapsdata
On Mon, Aug 24, 2020 at 13:50:21 +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> NEWS.rst | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 0669051ee6..3cd09decf6 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -15,6 +15,13 @@ v6.7
On 8/24/20 2:18 PM, Peter Krempa wrote:
qemu-v5.1.0 is released now. There weren't any noticable changes since
our last update to 'rc2'.
Signed-off-by: Peter Krempa
---
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies | 6 +++---
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 4 +
On Sat, Aug 22, 2020 at 05:11:56PM +0400, Roman Bogorodskiy wrote:
> Document the new element which allows to specify
> host audio backend for a guest device, and update
> the element description with the new
> sub-element which specifies the other end of the mapping.
>
> Signed-off-by: Roman
On Sat, Aug 22, 2020 at 05:11:55PM +0400, Roman Bogorodskiy wrote:
> Allow to map sound playback and recording devices to host devices
> using "" OSS audio backend.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> src/bhyve/bhyve_command.c | 35 +--
> src/conf/dom
On Mon, Aug 24, 2020 at 2:03 PM Kevin Locke wrote:
>
> When using [virtiofs], libvirtd must launch [virtiofsd] to provide
> filesystem access on the host. When a guest is configured with
> virtiofs, such as:
>
>
>
>
>
>
>
> Attempting to start the guest fails with:
On Sat, Aug 22, 2020 at 05:11:54PM +0400, Roman Bogorodskiy wrote:
> Introduce a new device element "" which allows
> to map guest sound device specified using the ""
> element to specific audio backend.
>
> Example:
>
>
>
>
>
>
>
>
>
> This block maps to OSS audio
On Sat, Aug 22, 2020 at 05:11:53PM +0400, Roman Bogorodskiy wrote:
> bhyve supports intel hda sound devices that could be specified
> on the command like using "-1:0,hda,play=$play_dev,rec=$rec_dev",
> where "1:0" is a PCI address, and "$play_dev" and "$rec_dev"
> point to the playback and recordin
On Sat, Aug 22, 2020 at 05:11:52PM +0400, Roman Bogorodskiy wrote:
> Add 'ich7' sound model. This is a preparation for sound support in
> bhyve, as 'ich7' is the only model it supports.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> docs/schemas/domaincommon.rng | 1 +
> src/conf/domain_conf.c
qemu-v5.1.0 is released now. There weren't any noticable changes since
our last update to 'rc2'.
Signed-off-by: Peter Krempa
---
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.replies | 6 +++---
tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 4 ++--
2 files changed, 5 insertions(+), 5 del
When using [virtiofs], libvirtd must launch [virtiofsd] to provide
filesystem access on the host. When a guest is configured with
virtiofs, such as:
Attempting to start the guest fails with:
internal error: virtiofsd died unexpectedly
/var/log/libvirt/qemu/$n
I've cleaned up the migration params code before actually going to add
new features.
Peter Krempa (7):
qemuMigrationParamsNew: Use new memory allocation to simplify code
qemuMigrationParamsFromFlags: Use 'g_autoptr' to remove 'error:' label
qemuMigrationParamsFromJSON: Unify return value han
Use automatic memory allocation to simplify the code and remove the need
for a 'cleanup:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 33
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_migration_params.
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'error:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 24 +++-
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/src/
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index f466c3c4f6..03d8d4fb49 100644
--- a/src/qemu/qemu_migration_params.c
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'error:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/src/qemu/
Use automatic memory cleaning and allocate via g_new0.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 04434e9557..f466
Use automatic memory allocation and move variables into correct scope to
simplify the code and remove the need for a 'cleanup:' label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 40
1 file changed, 15 insertions(+), 25 deletions(-)
diff -
This function doesn't have an overly verbose cleanup section as there
isn't any error code path. Unify it with the rest of the functions which
will simplify adding a possible error path.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 6 +++---
1 file changed, 3 insertions(+),
From: Boris Fiuczynski
Allow vfio-ccw mdev devices to be created besides vfio-pci mdev devices
as well.
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 ++
src/libvirt_private.syms
This series enables support for channel subsystem (CSS) devices,
Direct Access Storage Devices (DASDs) in the node_device driver and
adds support to create vfio-ccw mdev devices in the node_device driver.
Boris Fiuczynski (5):
node_device: refactor udevProcessCCW
node_device: detect CSS device
From: Boris Fiuczynski
Make Direct Access Storage Devices (DASDs) available in the node_device driver.
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/node_device/
From: Boris Fiuczynski
Make channel subsystem (CSS) devices available in the node_device driver.
The CCS devices reside in the computer system and provide CCW devices, e.g.:
+- css_0_0_003a
|
+- ccw_0_0_1a2b
|
+- scsi_host0
|
+- scsi_
From: Boris Fiuczynski
Allow to filter for CSS devices.
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
docs/formatnode.html.in | 12
docs/manpages/virsh.rst | 2 +-
include/libvirt/libvirt-nodedev.h | 1 +
src/conf/node_device_conf.h | 3
From: Boris Fiuczynski
Refactor out CCW address parsing for later reuse.
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 31 --
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/src/node_device/node_de
On 8/24/20 1:43 PM, Peter Krempa wrote:
Ensure that the migration parameters are formatted properly according to
the schema.
Signed-off-by: Peter Krempa
---
tests/qemumigparamstest.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
Reviewed-by: Michal Privoznik
This is very similar to previous commit.
The virshStreamInData() callback is used by virStreamSparseSendAll()
to detect whether the file the data is read from is in data or hole
section. The SendAll() will then send corresponding type of virStream
message to make server create a hole or write actu
1 - 100 of 126 matches
Mail list logo
