`qemuMigrationJobPhase` was transformed into `virMigrationJobPhase`
and a common util file `virmigration` was created to store its
defination.
This is one of the initial steps we are taking towards making
more and more code hypervisor agnostic. And this shall
be followed by transformation of
On Tue, Aug 25, 2020 at 03:59:47PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2020 at 04:55:06PM +0200, Erik Skultety wrote:
> > On Tue, Aug 25, 2020 at 01:44:40PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 18, 2020 at 09:47:59AM -0500, Jonathon Jongsma wrote:
> > > > We need to
When creating a standard tap device, if provided with an ifname that
contains "%d", rather than taking that literally as the name to use
for the new device, the kernel will instead use that string as a
template, and search for the lowest number that could be put in place
of %d and produce an
There have been some reports that, due to libvirt always trying to
assign the lowest numbered macvtap / tap device name possible, a new
guest would sometimes be started using the same tap device name as
previously used by another guest that is in the process of being
destroyed *as the new guest is
V1 is here:
https://www.redhat.com/archives/libvir-list/2020-August/msg00756.html
The problem and this solution are very well described in patches 2 and
3, but in short - because we (libvirt for macvtap, the kernel for tap)
always try to assign the lowest numbered names possible to macvtap and
Driver module loaders current hardcode ".so" as the file
extension. On MacOS, meson uses ".dylib" as a module file extension.
This patch adds VIR_FILE_MODULE_EXT to virfile.h defined as the
hosts module extension, and updates driver module loaders to make
use of it.
Signed-off-by: Scott
On Tue, Aug 25, 2020 at 09:42:36PM +0800, Zhong, Luyao wrote:
On 8/19/2020 11:24 PM, Martin Kletzander wrote:
On Tue, Aug 18, 2020 at 07:49:30AM +, Zang, Rui wrote:
-Original Message-
From: Martin Kletzander
Sent: Monday, August 17, 2020 4:58 PM
To: Zhong, Luyao
Cc:
On Tue, Aug 25, 2020 at 04:31:29PM +0100, Daniel P. Berrangé wrote:
On Tue, Aug 25, 2020 at 07:47:14AM +0200, Martin Kletzander wrote:
This allows:
a) migration without access to network
b) complete control of the migration stream
c) easy migration between containerised libvirt daemons on
On Tue, Aug 25, 2020 at 06:01:28PM +0200, Jiri Denemark wrote:
On Tue, Aug 25, 2020 at 16:28:12 +0100, Daniel P. Berrangé wrote:
On Tue, Aug 25, 2020 at 07:47:12AM +0200, Martin Kletzander wrote:
> Adds new typed param for migration and uses this as a UNIX socket path that
> should be used for
On Tue, Aug 25, 2020 at 05:35:52PM +0100, Daniel P. Berrangé wrote:
On Tue, Aug 25, 2020 at 06:34:05PM +0200, Jiri Denemark wrote:
On Tue, Aug 25, 2020 at 17:12:59 +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2020 at 05:53:32PM +0200, Jiri Denemark wrote:
> > On Tue, Aug 25, 2020 at
On a Monday in 2020, Daniel Henrique Barboza wrote:
Non-x86 archs does not have a 'microcode' version like x86. This is
covered already inside the function - just return 0 if no microcode
is found. Regardless of that, a read of /proc/cpuinfo is always made.
Each read will invoke the kernel to
On Tue, Aug 25, 2020 at 11:23:13AM -0600, Jim Fehlig wrote:
> Hi All,
>
> Any comments on this RFC patch? Is this something we would like to see in
> the 6.7.0 release?
Not done a full review yet, but it looks reasonable as an approach and
the code isn't too complex.
>
> On 8/20/20 5:03 PM,
Hi All,
Any comments on this RFC patch? Is this something we would like to see in the
6.7.0 release?
On 8/20/20 5:03 PM, Jim Fehlig wrote:
Add a configuration option for specifying location of the qemu modules
directory, defaulting to /usr/lib64/qemu. Then use this location to
check for
On Tue, 2020-08-25 at 18:47 +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani
>
> Missing commit message.
I figured this kind of changes didn't require much in the way of
explanation.
> > -The libvirt project was initiated by:
> > +The
On a Tuesday in 2020, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
Missing commit message.
---
AUTHORS.rst.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in
index 5a651b22db..9c4e1a3726 100644
--- a/AUTHORS.rst.in
+++
This patch takes care of just the obvious cases: there are
many more situations where the data we pass to configure_file()
could likely be obtained in a more effective way, but we can
address the low-hanging fruits as a first approximation.
Signed-off-by: Andrea Bolognani
---
On Tue, Aug 25, 2020 at 06:34:05PM +0200, Jiri Denemark wrote:
> On Tue, Aug 25, 2020 at 17:12:59 +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 25, 2020 at 05:53:32PM +0200, Jiri Denemark wrote:
> > > On Tue, Aug 25, 2020 at 07:47:14 +0200, Martin Kletzander wrote:
> > > > -/* RDMA and
On Tue, Aug 25, 2020 at 17:12:59 +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2020 at 05:53:32PM +0200, Jiri Denemark wrote:
> > On Tue, Aug 25, 2020 at 07:47:14 +0200, Martin Kletzander wrote:
> > > -/* RDMA and multi-fd migration requires QEMU to connect to the
> > > destination
> >
On Tue, Aug 25, 2020 at 07:47:15 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index d92714c29b88..49c476be5d51 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -20,6 +20,12
vim seems to be able to process the file just fine without a
modeline, so it's probably fair to assume Emacs doesn't need
any extra help either.
Signed-off-by: Andrea Bolognani
---
AUTHORS.rst.in | 5 -
1 file changed, 5 deletions(-)
diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in
index
Now that we have moved to Meson, we are no longer required to
use a specific name for this file, and since the rest of our
documentation is in reStructuredText format and uses a matching
file extension, we can give the AUTHORS file the same treatment.
Signed-off-by: Andrea Bolognani
---
On 8/25/20 9:15 AM, Michal Privoznik wrote:
On 8/5/20 12:13 AM, Jim Fehlig wrote:
Xen supports passing arbitrary arguments to the QEMU device model via
the 'extra' member of the public libxl_domain_build_info structure.
This patch adds a 'xen' namespace extension, similar to the QEMU and
bhyve
Signed-off-by: Andrea Bolognani
---
AUTHORS.rst.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in
index 5a651b22db..9c4e1a3726 100644
--- a/AUTHORS.rst.in
+++ b/AUTHORS.rst.in
@@ -2,11 +2,11 @@
libvirt Authors
===
-The
Plus some other adjustments.
Andrea Bolognani (3):
AUTHORS: Convert to reStructuredText
AUTHORS: Some small tweaks
AUTHORS: Remove Emacs file variables
AUTHORS.in | 103 ---
AUTHORS.rst.in | 99
On Tue, Aug 25, 2020 at 05:53:32PM +0200, Jiri Denemark wrote:
> On Tue, Aug 25, 2020 at 07:47:14 +0200, Martin Kletzander wrote:
> > This allows:
> >
> > a) migration without access to network
> >
> > b) complete control of the migration stream
> >
> > c) easy migration between
On Tue, Aug 25, 2020 at 16:28:12 +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2020 at 07:47:12AM +0200, Martin Kletzander wrote:
> > Adds new typed param for migration and uses this as a UNIX socket path that
> > should be used for the NBD part of migration. And also adds virsh support.
>
On Tue, Aug 25, 2020 at 07:47:14 +0200, Martin Kletzander wrote:
> This allows:
>
> a) migration without access to network
>
> b) complete control of the migration stream
>
> c) easy migration between containerised libvirt daemons on the same host
>
> Resolves:
On Tue, Aug 25, 2020 at 07:47:14AM +0200, Martin Kletzander wrote:
> This allows:
>
> a) migration without access to network
>
> b) complete control of the migration stream
>
> c) easy migration between containerised libvirt daemons on the same host
>
> Resolves:
On Tue, Aug 25, 2020 at 07:47:12AM +0200, Martin Kletzander wrote:
> Adds new typed param for migration and uses this as a UNIX socket path that
> should be used for the NBD part of migration. And also adds virsh support.
>
> Partially resolves: https://bugzilla.redhat.com/1638889
>
>
On 8/5/20 12:13 AM, Jim Fehlig wrote:
V2 of https://www.redhat.com/archives/libvir-list/2020-July/msg02043.html
Changes in V2:
- Drop use of virStringListCopy, and hence patch 1/4
- Switch to using 'xen' namespace and schema extenstion instead of qemu
- Use more glib functions
Jim Fehlig
On Tue, Aug 25, 2020 at 07:47:13 +0200, Martin Kletzander wrote:
> Local socket connections were outright disabled because there was no "server"
> part in the URI. However, given how requirements and usage scenarios are
> evolving, some management apps might need the source libvirt daemon to
On 8/5/20 12:13 AM, Jim Fehlig wrote:
Xen supports passing arbitrary arguments to the QEMU device model via
the 'extra' member of the public libxl_domain_build_info structure.
This patch adds a 'xen' namespace extension, similar to the QEMU and
bhyve drivers, to map arbitrary arguments to the
On Tue, Aug 25, 2020 at 01:44:40PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 18, 2020 at 09:47:59AM -0500, Jonathon Jongsma wrote:
> > We need to peridocally query mdevctl for changes to device definitions
> > since an administrator can define new devices with mdevctl outside of
> > libvirt.
On Tue, Aug 25, 2020 at 07:47:12 +0200, Martin Kletzander wrote:
> Adds new typed param for migration and uses this as a UNIX socket path that
> should be used for the NBD part of migration. And also adds virsh support.
>
> Partially resolves: https://bugzilla.redhat.com/1638889
>
>
On Tue, Aug 25, 2020 at 04:55:06PM +0200, Erik Skultety wrote:
> On Tue, Aug 25, 2020 at 01:44:40PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 18, 2020 at 09:47:59AM -0500, Jonathon Jongsma wrote:
> > > We need to peridocally query mdevctl for changes to device definitions
> > > since an
On Tue, Aug 25, 2020 at 04:26:01PM +0200, Christian Ehrhardt wrote:
> On Tue, Aug 25, 2020 at 4:07 PM Daniel P. Berrangé
> wrote:
> >
> > On Tue, Aug 25, 2020 at 03:16:50PM +0200, Christian Ehrhardt wrote:
> > > Hi,
> > > I expect that this falls under the "with meson now everything is
> > >
On Thu, 20 Aug 2020 11:16:21 +0800
Yan Zhao wrote:
> On Wed, Aug 19, 2020 at 09:22:34PM -0600, Alex Williamson wrote:
> > On Thu, 20 Aug 2020 08:39:22 +0800
> > Yan Zhao wrote:
> >
> > > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > > On Tue, 18 Aug 2020 10:16:28
On Tue, Aug 18, 2020 at 09:47:59AM -0500, Jonathon Jongsma wrote:
> We need to peridocally query mdevctl for changes to device definitions
> since an administrator can define new devices with mdevctl outside of
> libvirt.
>
> In order to do this, a new thread is created to handle the querying. In
On Tue, Aug 25, 2020 at 4:07 PM Daniel P. Berrangé wrote:
>
> On Tue, Aug 25, 2020 at 03:16:50PM +0200, Christian Ehrhardt wrote:
> > Hi,
> > I expect that this falls under the "with meson now everything is
> > different anyway" umbrella but wanted to let you know about this as it
> > affects
On 8/25/20 3:16 PM, Pavel Hrdina wrote:
Commit introduced a support
to fully allocate qcow2 images when matches but
it doesn't work as expected.
The issue is that info.size_arg is in KB but the info.allocation
introduced by the mentioned commit is in B. This results in using
On Tue, Aug 18, 2020 at 09:47:58AM -0500, Jonathon Jongsma wrote:
> mdevctl does not currently provide any events when the list of defined
> devices changes, so we will need to poll mdevctl for the list of defined
> devices periodically. When a mediated device no longer exists from one
> iteration
On Tue, Aug 25, 2020 at 03:16:50PM +0200, Christian Ehrhardt wrote:
> Hi,
> I expect that this falls under the "with meson now everything is
> different anyway" umbrella but wanted to let you know about this as it
> affects v6.6 in at least Ubuntu/Debian.
>
> The following recent patch has broken
On 8/19/2020 11:24 PM, Martin Kletzander wrote:
On Tue, Aug 18, 2020 at 07:49:30AM +, Zang, Rui wrote:
-Original Message-
From: Martin Kletzander
Sent: Monday, August 17, 2020 4:58 PM
To: Zhong, Luyao
Cc: libvir-list@redhat.com; Zang, Rui ; Michal
Privoznik
Subject: Re:
When using [virtiofs], libvirtd must launch [virtiofsd] to provide
filesystem access on the host. When a guest is configured with
virtiofs, such as:
Attempting to start the guest fails with:
internal error: virtiofsd died unexpectedly
On Mon, Aug 24, 2020 at 2:21 PM Christian Ehrhardt
wrote:
>
> On Mon, Aug 24, 2020 at 2:03 PM Kevin Locke wrote:
> >
> > When using [virtiofs], libvirtd must launch [virtiofsd] to provide
> > filesystem access on the host. When a guest is configured with
> > virtiofs, such as:
> >
> >
> >
On a Tuesday in 2020, Jonathon Jongsma wrote:
This interface allows you to undefine a persistently defined (but
inactive) mediated devices. It is implemented via 'mdevctl'
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 +
src/driver-nodedev.h
On Tue, Aug 25, 2020 at 09:43:28 +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 25, 2020 at 12:11:30AM +0200, Jiri Denemark wrote:
> > On Fri, Aug 21, 2020 at 12:30:09 +0100, Daniel P. Berrangé wrote:
> > > The logic to disable Ceph on 32-bit was protected by a Fedora
> > > conditional. This is
Hi,
I expect that this falls under the "with meson now everything is
different anyway" umbrella but wanted to let you know about this as it
affects v6.6 in at least Ubuntu/Debian.
The following recent patch has broken libvirt-lxc for us:
commit d7147b3797380de2d159ce6324536f3e1f2d97e3
Author:
Commit introduced a support
to fully allocate qcow2 images when matches but
it doesn't work as expected.
The issue is that info.size_arg is in KB but the info.allocation
introduced by the mentioned commit is in B. This results in using
"preallocation=falloc," in cases where
On a Tuesday in 2020, Jonathon Jongsma wrote:
This new API function provides a way to start a persistently-defined
mediate device that was defined by virNodeDeviceDefineXML() (or one that
was defined externally via mdevctl)
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h
On a Tuesday in 2020, Jonathon Jongsma wrote:
This adds some internal API to query for persistent mediated devices
that are defined by mdevctl. Following commits will make use of this
information. This just provides the infrastructure and tests for this
feature. One test verifies that we are
On a Tuesday in 2020, Jonathon Jongsma wrote:
We need to peridocally query mdevctl for changes to device definitions
since an administrator can define new devices with mdevctl outside of
libvirt.
In order to do this, a new thread is created to handle the querying. In
the future, mdevctl may add
On 8/13/20 5:37 AM, Jin Yan wrote:
These leaks were introduced in commit 15d280fa97b0, use g_autofree for all
cert_path pointers.
Signed-off-by: Jin Yan
---
src/rpc/virnettlscontext.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Pushed now. Sorry for the delay.
Michal
On Tue, Aug 18, 2020 at 09:47:59AM -0500, Jonathon Jongsma wrote:
> We need to peridocally query mdevctl for changes to device definitions
> since an administrator can define new devices with mdevctl outside of
> libvirt.
>
> In order to do this, a new thread is created to handle the querying. In
On Tue, Aug 18, 2020 at 09:48:04AM -0500, Jonathon Jongsma wrote:
> Add a virsh command that maps to virNodeDeviceUndefine().
>
> Signed-off-by: Jonathon Jongsma
> ---
> tools/virsh-nodedev.c | 65 +++
> 1 file changed, 65 insertions(+)
>
Reviewed-by: Erik
On Tue, Aug 18, 2020 at 09:48:05AM -0500, Jonathon Jongsma wrote:
> This new API function provides a way to start a persistently-defined
> mediate device that was defined by virNodeDeviceDefineXML() (or one that
> was defined externally via mdevctl)
>
> Signed-off-by: Jonathon Jongsma
> ---
>
On Tue, Aug 18, 2020 at 09:48:06AM -0500, Jonathon Jongsma wrote:
> This virsh command maps to virNodeDeviceCreate(), which starts a node
> device that has been previously defined by virNodeDeviceDefineXML().
> This is only supported for mediated devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
On Tue, Aug 18, 2020 at 09:48:03AM -0500, Jonathon Jongsma wrote:
> Several functions accept providing a node device by name or by wwnn,wwpn
> pair. Extract the logic to do this into a function that can be used by
> both callers.
>
> Signed-off-by: Jonathon Jongsma
> ---
Reviewed-by: Erik
On Tue, Aug 18, 2020 at 09:48:01AM -0500, Jonathon Jongsma wrote:
> Add a virsh command that maps to virNodeDeviceDefineXML().
>
> Signed-off-by: Jonathon Jongsma
> ---
> tools/virsh-nodedev.c | 58 +++
> 1 file changed, 58 insertions(+)
looks good.
On Tue, Aug 18, 2020 at 09:48:02AM -0500, Jonathon Jongsma wrote:
> This interface allows you to undefine a persistently defined (but
> inactive) mediated devices. It is implemented via 'mdevctl'
>
> Signed-off-by: Jonathon Jongsma
> ---
> include/libvirt/libvirt-nodedev.h | 2 +
>
On Tue, Aug 18, 2020 at 09:48:00AM -0500, Jonathon Jongsma wrote:
> With mediated devices, we can now define persistent node devices that
> can be started and stopped. In order to take advantage of this, we need
> an API to define new node devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
...
>
On Tue, Aug 18, 2020 at 09:48:00AM -0500, Jonathon Jongsma wrote:
> With mediated devices, we can now define persistent node devices that
> can be started and stopped. In order to take advantage of this, we need
> an API to define new node devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
>
On Tue, Aug 25, 2020 at 2:55 AM Han Han wrote:
>
>
>
> On Mon, Aug 24, 2020 at 11:09 PM Jason Dillaman wrote:
>>
>> On Mon, Aug 24, 2020 at 10:52 AM Daniel P. Berrangé
>> wrote:
>> >
>> > On Mon, Aug 24, 2020 at 10:19:59PM +0800, Han Han wrote:
>> > > On Fri, Aug 21, 2020 at 8:01 PM Jason
On Tue, Aug 25, 2020 at 07:47:11 +0200, Martin Kletzander wrote:
> For this we need to make the function accessible (at least privately). The
> behaviour will change in following patches and the test helps explaining the
> change.
>
> Signed-off-by: Martin Kletzander
> ---
>
On Tue, Aug 25, 2020 at 07:47:10 +0200, Martin Kletzander wrote:
> Clean up the semantics by using one extra self-describing variable.
> This also fixes the port allocation when the port is specified.
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_migration.c | 37
On Mon, 2020-08-24 at 17:12 +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
On Tue, Aug 25, 2020 at 09:44:41AM +0100, Daniel P. Berrangé wrote:
> On Mon, Aug 24, 2020 at 06:15:57PM -0700, Scott Shambarger wrote:
> > On 2020-08-24 02:34, Daniel P. Berrangé wrote:
> > > I don't think we want to keep compatibility with any libtool quirks. We
> > > should do the right thing
On Tue, Aug 25, 2020 at 11:29:21AM +0200, Pavel Hrdina wrote:
> On Tue, Aug 25, 2020 at 09:44:41AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Aug 24, 2020 at 06:15:57PM -0700, Scott Shambarger wrote:
> > > On 2020-08-24 02:34, Daniel P. Berrangé wrote:
> > > > I don't think we want to keep
On Tue, Aug 25, 2020 at 11:15:11 +0200, Ján Tomko wrote:
> On a Monday in 2020, Daniel P. Berrangé wrote:
> > On Mon, Aug 24, 2020 at 05:24:51PM +0200, Peter Krempa wrote:
> > > On Mon, Aug 24, 2020 at 16:18:40 +0100, Daniel Berrange wrote:
> > > > On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter
On a Monday in 2020, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Mon, Aug 24, 2020 at 05:33:21PM +0200, Peter Krempa wrote:
> On Mon, Aug 24, 2020 at 17:01:50 +0200, Michal Privoznik wrote:
[...]
> > > -Flag *--persistent* is used to include persistent domains in the returned
> > > +Flag *--persistent* is used to include persistent guests in the returned
>
On a Monday in 2020, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d92714c29b..7ae4aa9340 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,17 @@ v6.7.0 (unreleased)
On a Monday in 2020, Daniel P. Berrangé wrote:
On Mon, Aug 24, 2020 at 05:24:51PM +0200, Peter Krempa wrote:
On Mon, Aug 24, 2020 at 16:18:40 +0100, Daniel Berrange wrote:
> On Thu, Aug 06, 2020 at 11:55:12AM +0200, Peter Krempa wrote:
> > Signed-off-by: Peter Krempa
> > ---
> >
On Mon, Aug 24, 2020 at 06:15:57PM -0700, Scott Shambarger wrote:
> On 2020-08-24 02:34, Daniel P. Berrangé wrote:
> > I don't think we want to keep compatibility with any libtool quirks. We
> > should do the right thing for the platform, and I think that means using
> > the platform native suffix
On Tue, Aug 25, 2020 at 12:11:30AM +0200, Jiri Denemark wrote:
> On Fri, Aug 21, 2020 at 12:30:09 +0100, Daniel P. Berrangé wrote:
> > The logic to disable Ceph on 32-bit was protected by a Fedora
> > conditional. This is redundant as RHEL doesn't build on 32-bit
> > platforms for years.
>
> But
On 8/25/20 5:50 AM, Han Han wrote:
For iscsi-direct pool, the initiator is necessary for pool defining:
...
...
Add --source-initiator to fill the initiator iqn for
pool-create-as/pool-define-as subcommands.
https://bugzilla.redhat.com/show_bug.cgi?id=1658082
Roman Bogorodskiy wrote:
> BSD sed(1) and GNU sed(1) syntax are not compatible, and as
> syntax-check.mk uses the GNU flavor, set SED variable to
> 'gsed' by default.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> build-aux/syntax-check.mk | 8
> 1 file changed, 8 insertions(+)
>
On Mon, Aug 24, 2020 at 11:09 PM Jason Dillaman wrote:
> On Mon, Aug 24, 2020 at 10:52 AM Daniel P. Berrangé
> wrote:
> >
> > On Mon, Aug 24, 2020 at 10:19:59PM +0800, Han Han wrote:
> > > On Fri, Aug 21, 2020 at 8:01 PM Jason Dillaman
> wrote:
> > >
> > > > On Fri, Aug 7, 2020 at 5:50 AM Han
On Tue, Aug 25, 2020 at 07:47:09 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> tools/virsh-domain.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Jiri Denemark
On Tue, Aug 25, 2020 at 07:47:08 +0200, Martin Kletzander wrote:
> Instead of saving some data from a union up front and changing an overlayed
> struct before using said data, let's just set the new values after they are
> decided. This will increase the readability of future commit(s).
>
>
On Tue, Aug 25, 2020 at 07:47:07 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index
This allows:
a) migration without access to network
b) complete control of the migration stream
c) easy migration between containerised libvirt daemons on the same host
Resolves: https://bugzilla.redhat.com/1638889
Signed-off-by: Martin Kletzander
---
docs/manpages/virsh.rst | 17
Instead of saving some data from a union up front and changing an overlayed
struct before using said data, let's just set the new values after they are
decided. This will increase the readability of future commit(s).
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_migration.c | 18
For this we need to make the function accessible (at least privately). The
behaviour will change in following patches and the test helps explaining the
change.
Signed-off-by: Martin Kletzander
---
scripts/apibuild.py | 1 +
src/libvirt-domain.c | 4 +-
src/libvirt_internal.h | 2
KubeVirt would like to use this feature. For more information see individual
commits and changes in manpages and documentation.
Resolves: https://bugzilla.redhat.com/1638889
Martin Kletzander (9):
qemu: Use g_autofree in qemuMigrationSrcConnect
qemu: Rework qemuMigrationSrcConnect
virsh:
Signed-off-by: Martin Kletzander
---
tools/virsh-domain.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1f3a549d9ab0..c606900a9268 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10704,7 +10704,6 @@
86 matches
Mail list logo
