[PATCH] disk storage: fix allocation size for pool format dos

2020-08-28 Thread Sebastian Mitterle
The changed condition was always false because the function was always called with boundary values 0. Use the free extent's start value to get its start offset from the cylinder boundary and determine if the needed size for allocation needs to be expanded too in case the offset doesn't fit within

[PATCH] tests/meson: fix mock library link on MacOS

2020-08-28 Thread Scott Shambarger
MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed). Signed-off-by: Scott Shambarger --- tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/meson.build

Re: [PATCH] news: mention removal of autogenerated macvtap names from migration XML

2020-08-28 Thread Michal Privoznik
On 8/28/20 7:41 PM, Laine Stump wrote: Signed-off-by: Laine Stump --- NEWS.rst | 8 1 file changed, 8 insertions(+) Reviewed-by: Michal Privoznik and safe for freeze. Michal

[PATCH] news: mention removal of autogenerated macvtap names from migration XML

2020-08-28 Thread Laine Stump
Signed-off-by: Laine Stump --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 748ee3b1df..64c2b3f581 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -100,6 +100,14 @@ v6.7.0 (unreleased) implementation. But the implementation did not handle kernels

Re: libvirt-6.7.0 release candidate 2

2020-08-28 Thread Laine Stump
On 8/28/20 12:36 PM, Ján Tomko wrote: [off-list] On a Friday in 2020, Jiri Denemark wrote: I have just tagged v6.7.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Does it seem to work in your limited testing? You need to stop living in

Re: Please revert f4be03b3 (libvirtaio: Drop object(*args, **kwargs)) for theoretical reasons

2020-08-28 Thread Philipp Hahn
Hello, Am 20.08.20 um 11:20 schrieb Daniel P. Berrangé: > On Wed, Aug 19, 2020 at 11:32:10PM +0200, Wojtek Porczyk wrote: >> Hi Philipp, >> (Cc: Daniel, because IIUC you reviewed !16 which got this merged), >> >> I'm sorry I didn't notice this earlier, but the commit f4be03b3 dated >> 2020-04-20

Re: libvirt-6.7.0 release candidate 2

2020-08-28 Thread Ján Tomko
[off-list] On a Friday in 2020, Jiri Denemark wrote: I have just tagged v6.7.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Does it seem to work in your limited testing? Jano Please give the release candidate some testing and in case you

libvirt-6.7.0 release candidate 2

2020-08-28 Thread Jiri Denemark
I have just tagged v6.7.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Jim Fehlig
On 8/28/20 8:48 AM, Michal Privoznik wrote: On 8/28/20 4:19 PM, Jim Fehlig wrote: On 8/28/20 8:02 AM, Peter Krempa wrote: On Fri, Aug 28, 2020 at 07:52:23 -0600, Jim Fehlig wrote: On 8/28/20 2:00 AM, Pavel Hrdina wrote: On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: Running

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Michal Privoznik
On 8/28/20 4:19 PM, Jim Fehlig wrote: On 8/28/20 8:02 AM, Peter Krempa wrote: On Fri, Aug 28, 2020 at 07:52:23 -0600, Jim Fehlig wrote: On 8/28/20 2:00 AM, Pavel Hrdina wrote: On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: Running meson configure with '-Ddriver_hyperv=disabled'

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Jim Fehlig
On 8/28/20 8:02 AM, Peter Krempa wrote: On Fri, Aug 28, 2020 at 07:52:23 -0600, Jim Fehlig wrote: On 8/28/20 2:00 AM, Pavel Hrdina wrote: On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: Running meson configure with '-Ddriver_hyperv=disabled' fails with meson.build:1252:0:

[PATCH v2 3/7] qemu: Add transient disk handler to start and stop the guest

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma The transient disk is attached before the guest starts. Remove the transient disk when the guest does shutdown. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_process.c | 8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_process.c

[PATCH v2 4/7] qemu: Transient option gets avaiable for qcow2 and raw format disk

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_validate.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 488f258d00..82818a4fdc 100644 --- a/src/qemu/qemu_validate.c +++

[PATCH v2 6/7] qemu: Block disk hotplug when transient disk option is enabled

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Block disk hotplug when transient disk option is enabled so far. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_hotplug.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 2c6c30ce03..1c1b6c3acf 100644

[PATCH v2 7/7] qemu: Block blockjobs when transient disk option is enabled

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Block blockjobs when transient disk option is enabled so far. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e28f704dba..98a52e5476 100644 ---

[PATCH v2 5/7] qemu: Block migration when transient disk option is enabled

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Block migration when transient disk option is enabled because migration requires some blockjobs. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_migration.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/qemu/qemu_migration.c

[PATCH v2 1/7] qemuSnapshotDiskPrepareOne: Get available even if snapdisk is NULL

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Get available even if snapdisk argument is NULL at qemuSnapshotDiskPrepareOne() so that the caller can setup dd->src. Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_snapshot.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/7] qemu: Introduce functions to handle transient disk

2020-08-28 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Here is the implementation of transient option for qcow2 and raw format disk. This gets available directive in domain xml file like as: When the qemu command line options are built, a new qcow2 image is created with backing qcow2 by

[PATCH v2 0/7] qemu: implementation of transient disk option

2020-08-28 Thread Masayoshi Mizuma
This patchset tries to implement transient option for qcow2 and raw format disk. This uses the snapshot cleanup codes: https://www.redhat.com/archives/libvir-list/2020-August/msg00299.html It gets user available to set to the domain xml file like as: Any

Re: device compatibility interface for live migration with assigned devices

2020-08-28 Thread Sean Mooney
On Fri, 2020-08-28 at 15:47 +0200, Cornelia Huck wrote: > On Wed, 26 Aug 2020 14:41:17 +0800 > Yan Zhao wrote: > > > previously, we want to regard the two mdevs created with dsa-1dwq x 30 and > > dsa-2dwq x 15 as compatible, because the two mdevs consist equal resources. > > > > But, as it's a

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Peter Krempa
On Fri, Aug 28, 2020 at 07:52:23 -0600, Jim Fehlig wrote: > On 8/28/20 2:00 AM, Pavel Hrdina wrote: > > On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: > > > Running meson configure with '-Ddriver_hyperv=disabled' fails with > > > > > >meson.build:1252:0: ERROR: Dependency

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Jim Fehlig
On 8/28/20 2:00 AM, Pavel Hrdina wrote: On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: Running meson configure with '-Ddriver_hyperv=disabled' fails with meson.build:1252:0: ERROR: Dependency "openwsman" not found, tried pkgconfig and cmake openwsman is only required if the

Re: device compatibility interface for live migration with assigned devices

2020-08-28 Thread Cornelia Huck
On Wed, 26 Aug 2020 14:41:17 +0800 Yan Zhao wrote: > previously, we want to regard the two mdevs created with dsa-1dwq x 30 and > dsa-2dwq x 15 as compatible, because the two mdevs consist equal resources. > > But, as it's a burden to upper layer, we agree that if this condition > happens, we

Re: [libvirt PATCH] docs: Remove extraneous plus signs from virsh man page

2020-08-28 Thread Michal Privoznik
On 8/28/20 2:58 PM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 0482fe8b26f2..8e2fb7039046 100644 ---

[libvirt PATCH] docs: Remove extraneous plus signs from virsh man page

2020-08-28 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 0482fe8b26f2..8e2fb7039046 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@

Re: [PATCH for 6.7.0] NEWS: Document improvements/bug fixes for upcoming release

2020-08-28 Thread Andrea Bolognani
On Fri, 2020-08-28 at 13:45 +0200, Michal Privoznik wrote: > * **Improvements** > > + * Libvirt switch to Meson build system > + > +Libvirt abandoned autotools and switched to Meson build system. This should be in the "Packaging changes" section that we use from time to time specifically

Re: [PATCH for 6.7.0] NEWS: Document improvements/bug fixes for upcoming release

2020-08-28 Thread Neal Gompa
On Fri, Aug 28, 2020 at 7:45 AM Michal Privoznik wrote: > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 852746eb2a..4ed4e45590 100644 > --- a/NEWS.rst > +++ b/NEWS.rst >

[PATCH for 6.7.0] NEWS: Document improvements/bug fixes for upcoming release

2020-08-28 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 34 ++ 1 file changed, 34 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 852746eb2a..4ed4e45590 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,6 +33,10 @@ v6.7.0 (unreleased) * **Improvements** + * Libvirt

Re: [PATCH] news: Document the `role` attribute for shmem device

2020-08-28 Thread Michal Privoznik
On 8/21/20 10:53 AM, Wang Xin wrote: Signed-off-by: Wang Xin diff --git a/NEWS.rst b/NEWS.rst index 0669051ee6..be7274a184 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,12 @@ v6.7.0 (unreleased) * **New features** + * shmem: Add support for shmem-{plain, doorbell} ``role`` option

Re: [PATCH] news: mention bhyve sound support

2020-08-28 Thread Michal Privoznik
On 8/27/20 4:08 PM, Roman Bogorodskiy wrote: Signed-off-by: Roman Bogorodskiy --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2d30d5a5e8..9ded7731f8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,11 @@ v6.7.0 (unreleased) the

Re: [libvirt PATCH 0/8] Use https:// more

2020-08-28 Thread Neal Gompa
On Thu, Aug 27, 2020 at 9:28 AM Ján Tomko wrote: > > Ján Tomko (8): > docs: tlscerts: fix link to certtool invocation > tools: wireshark: fix link to wireshark repo > build-aux: vc-list-files: remove non-git support > vbox: do not repeat the innotek namespace url > Prefer https: for

[PATCH] util: Add phys_port_name support on virPCIGetNetName

2020-08-28 Thread Dmytro Linkin
Current virPCIGetNetName() logic is to get net device name by checking it's phys_port_id, if caller provide it, or by it's index (eg, by it's position at sysfs net directory). This approach worked fine up until linux kernel version 5.8, where NVIDIA Mellanox driver implemented linking of VFs'

Re: [libvirt PATCH 8/8] Prefer https: everywhere where possible

2020-08-28 Thread Ján Tomko
On a Friday in 2020, Erik Skultety wrote: On Thu, Aug 27, 2020 at 03:27:05PM +0200, Ján Tomko wrote: Use https: links for websites that support them. The URIs which are used as namespace identifiers are left alone. Signed-off-by: Ján Tomko --- 60 files changed, 116 insertions(+), 116

Re: [libvirt PATCH 3/8] build-aux: vc-list-files: remove non-git support

2020-08-28 Thread Daniel P . Berrangé
On Fri, Aug 28, 2020 at 08:34:48AM +0200, Erik Skultety wrote: > On Thu, Aug 27, 2020 at 03:27:00PM +0200, Ján Tomko wrote: > > Delete support for other VCSs than git. > > > > This also removes a http: link. > > > > Signed-off-by: Ján Tomko > > --- > > build-aux/vc-list-files | 24

Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

2020-08-28 Thread Pavel Hrdina
On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: > Running meson configure with '-Ddriver_hyperv=disabled' fails with > > meson.build:1252:0: ERROR: Dependency "openwsman" not found, tried > pkgconfig and cmake > > openwsman is only required if the hyperv driver is enabled. Don't

Re: [libvirt PATCH 10/11] remote: allocate def in remoteRelayDomainEventCheckACL

2020-08-28 Thread Peter Krempa
On Thu, Aug 27, 2020 at 22:19:52 +0200, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > src/remote/remote_daemon_dispatch.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/remote/remote_daemon_dispatch.c > b/src/remote/remote_daemon_dispatch.c >

Re: [libvirt PATCH 08/11] libxl: allocate d_config

2020-08-28 Thread Peter Krempa
On Thu, Aug 27, 2020 at 22:19:50 +0200, Ján Tomko wrote: > clang reports: > > stack frame size of 2152 bytes in function 'libxlDomainStart' > > This is mostly due to the d_config variable: > > sizeof(libxl_domain_config) = 1232 > > Use g_new0 to allocate it and bring the frame size down.

Re: [libvirt PATCH 3/8] build-aux: vc-list-files: remove non-git support

2020-08-28 Thread Erik Skultety
On Thu, Aug 27, 2020 at 03:27:00PM +0200, Ján Tomko wrote: > Delete support for other VCSs than git. > > This also removes a http: link. > > Signed-off-by: Ján Tomko > --- > build-aux/vc-list-files | 24 > 1 file changed, 24 deletions(-) > > diff --git

Re: [libvirt PATCH 0/8] Use https:// more

2020-08-28 Thread Erik Skultety
On Thu, Aug 27, 2020 at 03:26:57PM +0200, Ján Tomko wrote: > Ján Tomko (8): > docs: tlscerts: fix link to certtool invocation > tools: wireshark: fix link to wireshark repo > build-aux: vc-list-files: remove non-git support > vbox: do not repeat the innotek namespace url > Prefer https:

Re: [libvirt PATCH 8/8] Prefer https: everywhere where possible

2020-08-28 Thread Erik Skultety
On Thu, Aug 27, 2020 at 03:27:05PM +0200, Ján Tomko wrote: > Use https: links for websites that support them. > > The URIs which are used as namespace identifiers > are left alone. > > Signed-off-by: Ján Tomko > --- > docs/acl.html.in | 2 +- > docs/aclpolkit.html.in