Symbol missing in nss_libvirt.so

2020-08-31 Thread Roman Bogorodskiy
Hi, I noticed that the FreeBSD version of the nss plugin misses the 'nss_module_register' symbol (which makes the plugin fail to register). $ build/tools/nss/libnss_libvirt_impl.a libvirt_nss.c.o: r .L.str 0020 r .L.str.1 0028 r .L.str.2

Re: [libvirt PATCH v2] Adds e1000e/vmxnet3 Vnet_hdr suuport

2020-08-31 Thread Daniel Henrique Barboza
Be mindful of the typo in the commit title: suuport -> support Just a nit below: On 8/8/20 10:59 AM, Patrick Magauran wrote: Changes from Original: Moved Comparison to qemuInterfaceIsVnetCompatModel in qemu_interface.c per the recommendation of Daniel Berrangé - Libvirt bases its

Re: [PATCH] NVRAM: check NVRAM file size and recover from template

2020-08-31 Thread Daniel Henrique Barboza
On 8/8/20 7:01 AM, Hao Wang wrote: From: Hao Wang Subject: [PATCH] NVRAM: check NVRAM file size and recover from template A corrupted nvram file (e.g. caused by last unsuccessful creation due to insufficient memory) can lead to boot or migration failure. Check the size of the existed nvram

[GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-08-31 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_driver.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index ac9da4c85d..75bf41fc11 100644 --- a/src/jailhouse/jailhouse_driver.c +++

Re: [PATCH] tests/meson: fix mock library link on MacOS

2020-08-31 Thread Daniel Henrique Barboza
On 8/28/20 4:35 PM, Scott Shambarger wrote: MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed). Signed-off-by: Scott Shambarger --- Reviewed-by: Daniel Henrique Barboza tests/meson.build | 6

Re: [PATCH] tests/meson: fix mock library link on MacOS

2020-08-31 Thread Daniel Henrique Barboza
On 8/31/20 11:19 AM, Ján Tomko wrote: On a Monday in 2020, Michal Privoznik wrote: On 8/31/20 3:36 PM, Daniel Henrique Barboza wrote: On 8/28/20 4:35 PM, Scott Shambarger wrote: MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded

Re: [PATCH] tests/meson: fix mock library link on MacOS

2020-08-31 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: On 8/31/20 3:36 PM, Daniel Henrique Barboza wrote: On 8/28/20 4:35 PM, Scott Shambarger wrote: MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed).

Re: [PATCH] qemu: Validate memory hotplug in domainValidateCallback instead of cmd line generator

2020-08-31 Thread Daniel Henrique Barboza
On 8/31/20 10:44 AM, Michal Privoznik wrote: When editing a domain with hotplug enabled, I removed the only NUMA node it had and got no error. I got the error later though, when starting the domain. This is not as user friendly as it can be. Move the validation call out from command line

Re: [PATCH] virmigraiton: `qemuMigrationJobPhase` transformed for more generic use

2020-08-31 Thread Daniel Henrique Barboza
Commit title has a typo: virmigraiton -> virmigration On 8/23/20 5:37 PM, Prathamesh Chavan wrote: `qemuMigrationJobPhase` was transformed into `virMigrationJobPhase` and a common util file `virmigration` was created to store its defination. s/defination/definition This is one of the

Re: [PATCH] qemu_validate: Only allow none address for watchdog ib700

2020-08-31 Thread Ján Tomko
On a Monday in 2020, Daniel Henrique Barboza wrote: On 8/21/20 7:19 AM, Han Han wrote: Since QEMU 1.5.3, the ib700 watchdog device has no options for address, and not address in device tree: $ /usr/libexec/qemu-kvm -version QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c)

Re: [PATCH] tests/meson: fix mock library link on MacOS

2020-08-31 Thread Michal Privoznik
On 8/31/20 3:36 PM, Daniel Henrique Barboza wrote: On 8/28/20 4:35 PM, Scott Shambarger wrote: MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed). Signed-off-by: Scott Shambarger --- Given that

[PATCH] qemu: Validate memory hotplug in domainValidateCallback instead of cmd line generator

2020-08-31 Thread Michal Privoznik
When editing a domain with hotplug enabled, I removed the only NUMA node it had and got no error. I got the error later though, when starting the domain. This is not as user friendly as it can be. Move the validation call out from command line generator and into domain validator (which is called

Re: [PATCH] tests/meson: fix mock library link on MacOS

2020-08-31 Thread Daniel Henrique Barboza
On 8/28/20 4:35 PM, Scott Shambarger wrote: MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed). Signed-off-by: Scott Shambarger --- Given that this is a MacOS specific limitation it's not a good

Re: [PATCH] qemu_validate: Only allow none address for watchdog ib700

2020-08-31 Thread Daniel Henrique Barboza
On 8/21/20 7:19 AM, Han Han wrote: Since QEMU 1.5.3, the ib700 watchdog device has no options for address, and not address in device tree: $ /usr/libexec/qemu-kvm -version QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c) 2003-2008 Fabrice Bellard $ /usr/libexec/qemu-kvm

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-08-31 Thread Daniel Henrique Barboza
On 8/20/20 11:20 PM, Zhenyu Zheng wrote: Modify virCPUarmCompare in cpu_arm.c to perform actual compare actions. Compare host cpu vendor and model info with guest cpu as initial implementation, as most ARM clouds uses host-passthrogh mode. Typo: host-passthrogh -> host-passthrough

Re: [libvirt PATCH] meson: Use @BASENAME@ more

2020-08-31 Thread Daniel Henrique Barboza
On 8/25/20 1:38 PM, Andrea Bolognani wrote: This patch takes care of just the obvious cases: there are many more situations where the data we pass to configure_file() could likely be obtained in a more effective way, but we can address the low-hanging fruits as a first approximation.

Re: [PATCH] RNG: Allow interleaving of /domain/cpu/numa/cell children

2020-08-31 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: So far, the element can have two types of children elements: and (which can be repeated more times). However, there is no reason to require specific order in input XML. Allow elements to be interleaved. Signed-off-by: Michal Privoznik ---

[PATCH] RNG: Allow interleaving of /domain/cpu/numa/cell children

2020-08-31 Thread Michal Privoznik
So far, the element can have two types of children elements: and (which can be repeated more times). However, there is no reason to require specific order in input XML. Allow elements to be interleaved. Signed-off-by: Michal Privoznik --- docs/schemas/cputypes.rng | 22 --

Re: [PATCH v2 0/7] qemu: implementation of transient disk option

2020-08-31 Thread Ján Tomko
[FYI pkrempa is on PTO this week so he won't review this until the next one] On a Friday in 2020, Masayoshi Mizuma wrote: This patchset tries to implement transient option for qcow2 and raw format disk. This uses the snapshot cleanup codes:

Re: [PATCH libvirt-dbus 1/2] meson: generate systemd unit file for libvirt-dbus

2020-08-31 Thread Pavel Hrdina
On Mon, Aug 31, 2020 at 09:45:15AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/system/libvirt-dbus.service.in| 21 +++ > data/system/meson.build| 30 +- > data/system/org.libvirt-systemd.service.in | 5

Re: [PATCH] util: Add phys_port_name support on virPCIGetNetName

2020-08-31 Thread Dmytro Linkin
+Adrian,Moshe On Fri, Aug 28, 2020 at 01:53:21PM +0300, Dmytro Linkin wrote: > Current virPCIGetNetName() logic is to get net device name by checking > it's phys_port_id, if caller provide it, or by it's index (eg, by it's > position at sysfs net directory). This approach worked fine up until >

[PATCH libvirt-dbus 1/2] meson: generate systemd unit file for libvirt-dbus

2020-08-31 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/system/libvirt-dbus.service.in| 21 +++ data/system/meson.build| 30 +- data/system/org.libvirt-systemd.service.in | 5 libvirt-dbus.spec.in | 4 ++- meson.build

[PATCH libvirt-dbus 2/2] systemd: use SupplementaryGroups=libvirt so that ubuntu users can use the system connection

2020-08-31 Thread Katerina Koukiou
See https://bugs.launchpad.net/ubuntu/+source/libvirt-dbus/+bug/1892756 Signed-off-by: Katerina Koukiou --- data/system/libvirt-dbus.service.in | 1 + 1 file changed, 1 insertion(+) diff --git data/system/libvirt-dbus.service.in data/system/libvirt-dbus.service.in index 862a366..aa46217

[PATCH libvirt-dbus 0/2] Introduce libivirt-dbus systemd unit

2020-08-31 Thread Katerina Koukiou
For distributions that are using systemd introduce a libvirt-dbus.service and have 'libvirt' group as supplementary group for the spawned libvirt-dbus process. This will allow ubuntu users (SocketMode is 0660 in newer ubuntu), to use system connection without extra configuration. Katerina Koukiou