Re: [libvirt PATCH v2] Adds e1000e/vmxnet3 Vnet_hdr suuport

2020-09-01 Thread Laine Stump
On 8/8/20 9:59 AM, Patrick Magauran wrote: Changes from Original: Moved Comparison to qemuInterfaceIsVnetCompatModel in qemu_interface.c per the recommendation of Daniel Berrangé - Libvirt bases its decision about whether to apply the vnet_hdr flag to the tap interface on whether or not

Re: [PATCH] conf: Don't check virTristateBool < 0

2020-09-01 Thread Jim Fehlig
Heh, not fast enough these days. I see it's already fixed :-). Regards, Jim On 9/1/20 4:18 PM, Jim Fehlig wrote: Commit 9d15647dcb introduced a check of virtTristateBool < 0, which causes a build failure in some environments ../dist-unpack/libvirt-6.8.0/src/conf/domain_conf.c:8144:78: error:

Re: [libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-01 Thread Jim Fehlig
On 9/1/20 8:08 AM, Pavel Hrdina wrote: If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype

[PATCH] conf: Don't check virTristateBool < 0

2020-09-01 Thread Jim Fehlig
Commit 9d15647dcb introduced a check of virtTristateBool < 0, which causes a build failure in some environments ../dist-unpack/libvirt-6.8.0/src/conf/domain_conf.c:8144:78: error: result of comparison of unsigned enum expression < 0 is always false

[libvirt PATCH] conf: fix enum conversion

2020-09-01 Thread Ján Tomko
../src/conf/domain_conf.c:8144:78: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare] if ((def->writeFiltering = virTristateBoolTypeFromString(filtering)) < 0) {

[libvirt PATCH] util: virnetdevtap: stats: fix txdrop on FreeBSD

2020-09-01 Thread Ján Tomko
For older FreeBSD, we needed an ifdef guard to use if_data.ifi_oqdrops, which was introduced by: commit 61bbdbb94ce3e2f5e969c9bddb443427db07bf61 Implement interface stats for BSD But when we dropped the check because we deprecated building on FreeBSD-10 in: commit

Re: [PATCH v2 9/9] news: qemu: Allow migration over UNIX sockets

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 21:34:30 +0200, Ján Tomko wrote: > On a Tuesday in 2020, Martin Kletzander wrote: > >Signed-off-by: Martin Kletzander > >--- > > NEWS.rst | 6 ++ > > 1 file changed, 6 insertions(+) > > > >diff --git a/NEWS.rst b/NEWS.rst > >index 302b7f477904..52781b7e1677 100644 >

Re: [PATCH 0/5] Prefer WITH_* prefix for #if conditionals

2020-09-01 Thread Ján Tomko
On a Tuesday in 2020, Michal Privoznik wrote: While I was working on the actual patch 5/5 I've found couple of possible cleanups (patches 1-4/5). This is all inspired by: https://www.redhat.com/archives/libvir-list/2020-September/msg00021.html Michal Prívozník (5): util: Check for

Re: [PATCH v2 9/9] news: qemu: Allow migration over UNIX sockets

2020-09-01 Thread Ján Tomko
On a Tuesday in 2020, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 302b7f477904..52781b7e1677 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -71,6 +71,12 @@ v6.7.0 (2020-09-01) This is not in

Re: [PATCH v2 7/9] peer2peer migration: allow connecting to local sockets

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:58 +0200, Martin Kletzander wrote: > Local socket connections were outright disabled because there was no "server" > part in the URI. However, given how requirements and usage scenarios are > evolving, some management apps might need the source libvirt daemon to

Re: [PATCH v2 9/9] news: qemu: Allow migration over UNIX sockets

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:37:00 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 302b7f477904..52781b7e1677 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -71,6 +71,12

Re: [PATCH v2 6/9] qemu: Allow NBD migration over UNIX socket

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:57 +0200, Martin Kletzander wrote: > Adds new typed param for migration and uses this as a UNIX socket path that > should be used for the NBD part of migration. And also adds virsh support. > > Partially resolves: https://bugzilla.redhat.com/1638889 > >

Re: [PATCH v2 5/9] tests: Add simple test for virDomainMigrateCheckNotLocal

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:56 +0200, Martin Kletzander wrote: > For this we need to make the function accessible (at least privately). The > behaviour will change in following patches and the test helps explaining the > change. > > Signed-off-by: Martin Kletzander > --- >

Re: [PATCH v2 4/9] qemu: Rework starting NBD server for migration

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:55 +0200, Martin Kletzander wrote: > Clean up the semantics by using one extra self-describing variable. > This also fixes the port allocation when the port is specified. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_migration.c | 37

Re: [PATCH v2 3/9] virsh: Reuse existing variable when parsing migrate --disks-port

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:54 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > tools/virsh-domain.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH v2 2/9] qemu: Rework qemuMigrationSrcConnect

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:53 +0200, Martin Kletzander wrote: > Instead of saving some data from a union up front and changing an overlayed > struct before using said data, let's just set the new values after they are > decided. This will increase the readability of future commit(s). > >

Re: [PATCH v2 1/9] qemu: Use g_autofree in qemuMigrationSrcConnect

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 16:36:52 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_migration.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-01 Thread Jiri Denemark
On Fri, Aug 21, 2020 at 10:20:15 +0800, Zhenyu Zheng wrote: > Modify virCPUarmCompare in cpu_arm.c to perform > actual compare actions. Compare host cpu vendor > and model info with guest cpu as initial implementation, > as most ARM clouds uses host-passthrogh mode. In addition to the low-level

Re: [PATCH v2] qemu_validate: Only allow none address for watchdog ib700

2020-09-01 Thread Daniel Henrique Barboza
On 9/1/20 11:15 AM, Han Han wrote: Since QEMU 1.5.3, the ib700 watchdog device has no options for address, and not address in device tree: $ /usr/libexec/qemu-kvm -version QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c) 2003-2008 Fabrice Bellard $ /usr/libexec/qemu-kvm

[PATCH v2 8/9] qemu: Allow migration over UNIX socket

2020-09-01 Thread Martin Kletzander
This allows: a) migration without access to network b) complete control of the migration stream c) easy migration between containerised libvirt daemons on the same host Resolves: https://bugzilla.redhat.com/1638889 Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst |

[PATCH v2 2/9] qemu: Rework qemuMigrationSrcConnect

2020-09-01 Thread Martin Kletzander
Instead of saving some data from a union up front and changing an overlayed struct before using said data, let's just set the new values after they are decided. This will increase the readability of future commit(s). Signed-off-by: Martin Kletzander --- src/qemu/qemu_migration.c | 18

[PATCH v2 5/9] tests: Add simple test for virDomainMigrateCheckNotLocal

2020-09-01 Thread Martin Kletzander
For this we need to make the function accessible (at least privately). The behaviour will change in following patches and the test helps explaining the change. Signed-off-by: Martin Kletzander --- scripts/apibuild.py | 1 + src/libvirt-domain.c | 3 +- src/libvirt_internal.h | 2

[PATCH v2 1/9] qemu: Use g_autofree in qemuMigrationSrcConnect

2020-09-01 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/qemu/qemu_migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 142faa2cf997..60ddfde65d46 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@

[PATCH v2 4/9] qemu: Rework starting NBD server for migration

2020-09-01 Thread Martin Kletzander
Clean up the semantics by using one extra self-describing variable. This also fixes the port allocation when the port is specified. Signed-off-by: Martin Kletzander --- src/qemu/qemu_migration.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff

[PATCH v2 9/9] news: qemu: Allow migration over UNIX sockets

2020-09-01 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 302b7f477904..52781b7e1677 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -71,6 +71,12 @@ v6.7.0 (2020-09-01) forbidden and no size auto-alignment will be made.

[PATCH v2 6/9] qemu: Allow NBD migration over UNIX socket

2020-09-01 Thread Martin Kletzander
Adds new typed param for migration and uses this as a UNIX socket path that should be used for the NBD part of migration. And also adds virsh support. Partially resolves: https://bugzilla.redhat.com/1638889 Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst | 11 ++

[PATCH v2 3/9] virsh: Reuse existing variable when parsing migrate --disks-port

2020-09-01 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- tools/virsh-domain.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 36581d2c31d2..8a4a0d172dc9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10708,7 +10708,6 @@

[PATCH v2 0/9] qemu: Allow migration over UNIX sockets

2020-09-01 Thread Martin Kletzander
v2: - Allow TLS and parallel migration as well - Use simpler unix socket URIs KubeVirt would like to use this feature. For more information see individual commits and changes in manpages and documentation. Resolves: https://bugzilla.redhat.com/1638889 Martin Kletzander (9): qemu: Use

[PATCH v2 7/9] peer2peer migration: allow connecting to local sockets

2020-09-01 Thread Martin Kletzander
Local socket connections were outright disabled because there was no "server" part in the URI. However, given how requirements and usage scenarios are evolving, some management apps might need the source libvirt daemon to connect to the destination daemon over a UNIX socket for peer2peer

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Ján Tomko
On a Monday in 2020, Prakhar Bansal wrote: --- This also implements GetHostname - they would look nicer in separate pateches. src/jailhouse/jailhouse_driver.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c

Re: [GSoC PATCH 2/9] Jailhouse driver: Implementation of ConnectOpen

2020-09-01 Thread Ján Tomko
On a Monday in 2020, Prakhar Bansal wrote: --- include/libvirt/virterror.h | 1 + po/POTFILES.in | 2 + src/jailhouse/Makefile.inc.am | 34 ++- src/jailhouse/jailhouse.conf| 10 + src/jailhouse/jailhouse_api.c | 372

[PATCH v2] qemu_validate: Only allow none address for watchdog ib700

2020-09-01 Thread Han Han
Since QEMU 1.5.3, the ib700 watchdog device has no options for address, and not address in device tree: $ /usr/libexec/qemu-kvm -version QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c) 2003-2008 Fabrice Bellard $ /usr/libexec/qemu-kvm -device ib700,\? $ virsh

[libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-01 Thread Pavel Hrdina
If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype set to plain. There is an issue reported

Re: [GSoC PATCH 1/9] Jailhouse driver: first commit with skeleton code

2020-09-01 Thread Ján Tomko
On a Monday in 2020, Prakhar Bansal wrote: --- include/libvirt/virterror.h | 2 +- libvirt.spec.in | 7 + m4/virt-driver-jailhouse.m4 | 42 + meson.build | 4 + meson_options.txt| 1 +

[PATCH 3/5] meson: Drop checks for some functions and header files

2020-09-01 Thread Michal Privoznik
In meson.build, we check for presence of unshare() function explicitly (even though there is the function usability check a few hundred lines below), but never have any code depending on HAVE_UNSHARE. The same applies to stdarg.h and sys/sysctl.h header files - either we simply include them or

[PATCH 5/5] lib: Prefer WITH_* prefix for #if conditionals

2020-09-01 Thread Michal Privoznik
Currently, we are mixing: #if HAVE_BLAH with #if WITH_BLAH. Things got way better with Pavel's work on meson, but apparently, mixing these two lead to confusing and easy to miss bugs (see 31fb929eca for instance). While we were forced to use HAVE_ prefix with autotools, we are free to chose our

[PATCH 4/5] nss: Drop needless include of rpc/types.h

2020-09-01 Thread Michal Privoznik
In packet-libvirt.c in wireshark dissector we include rpc/types.h but guard the include with a condition (that is supposed to be true if we detected during configure phase that the host system has the header file). Thing is, it looks like we were never doing the configure check and thus the file

[PATCH 0/5] Prefer WITH_* prefix for #if conditionals

2020-09-01 Thread Michal Privoznik
While I was working on the actual patch 5/5 I've found couple of possible cleanups (patches 1-4/5). This is all inspired by: https://www.redhat.com/archives/libvir-list/2020-September/msg00021.html Michal Prívozník (5): util: Check for HAVE_NET_IF_H correctly virfile.c: Remove some #endif

[PATCH 2/5] virfile.c: Remove some #endif comments

2020-09-01 Thread Michal Privoznik
There are couple of conditional #includes at the beginning of virfile.c and they try to be nice and document #endifs. But they are mostly wrong because either they have the condition in the comment inverted or the comment refers to a different condition than they belong to. Just remove the

Re: [question] cpumap: why 'mpx' removed from Cooperlake model?

2020-09-01 Thread Jiri Denemark
On Thu, Aug 27, 2020 at 08:50:15 +, Wangxin (Alexander) wrote: > Hi, Jiri > > I just compared the cpu features between the 'x86_Cooperlake.xml ' and > 'x86_Cascadelake-Server.xml', > the feature 'mpx' seems removed from the Cooperlake model. Is there a reason? mpx was not removed from

[PATCH 1/5] util: Check for HAVE_NET_IF_H correctly

2020-09-01 Thread Michal Privoznik
There are two places where we try to check whether the host system has net/if.h before including it. But the check is missing '_H' suffix. Fixes: 7f3eb533f44742071366e07a35ab41070956707b Signed-off-by: Michal Privoznik --- src/util/virnetdevbridge.c | 2 +- src/util/virnetdevtap.c| 2 +- 2

Re: [libvirt PATCH] meson: add -Wformat explicitly

2020-09-01 Thread Ján Tomko
On a Tuesday in 2020, Pavel Hrdina wrote: If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the

Re: [libvirt PATCH] meson: add -Wformat explicitly

2020-09-01 Thread Michal Privoznik
On 9/1/20 3:30 PM, Pavel Hrdina wrote: If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype

[libvirt PATCH] meson: add -Wformat explicitly

2020-09-01 Thread Pavel Hrdina
If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype set to plain. There is an issue reported

[PATCH v3] virt-aa-helper: disallow graphics socket read permissions

2020-09-01 Thread Simon Arlott
The VM does not need read permission for its own sockets to create, bind(), listen(), accept() connections or to recv(), send(), etc. on those connections. This was fixed in ab9569e5460d1e4737fe8b625c67687dc2204665 (virt-aa-helper: disallow VNC socket read permissions), but then

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Michal Privoznik
On 9/1/20 11:42 AM, Daniel P. Berrangé wrote: On Tue, Sep 01, 2020 at 11:26:58AM +0200, Michal Privoznik wrote: When switching to meson, some of HAVE_* macros were renamed to WITH_ because they did not reflect whether the build platform has or doesn't have something, but whether we are building

Re: [PATCH v2] virt-aa-helper: disallow graphics socket read permissions

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 12:11:11PM +0200, Christian Ehrhardt wrote: > On Thu, May 28, 2020 at 12:45 PM Simon Arlott wrote: > > > > The VM does not need read permission for its own sockets to create, > > bind(), listen(), accept() connections or to recv(), send(), etc. on > > those connections. >

Re: [PATCH v2] virt-aa-helper: disallow graphics socket read permissions

2020-09-01 Thread Christian Ehrhardt
On Thu, May 28, 2020 at 12:45 PM Simon Arlott wrote: > > The VM does not need read permission for its own sockets to create, > bind(), listen(), accept() connections or to recv(), send(), etc. on > those connections. > > This was fixed in ab9569e5460d1e4737fe8b625c67687dc2204665 >

[PATCH REBASE 3/7] qemuBuildMemoryBackendProps: Prealloc mem for memfd backend

2020-09-01 Thread Michal Privoznik
If a domain was using hugepages through memory-backend-file or via -mem-path, we would turn prealloc on. But we are not doing that for memory-backend-memfd. Fix this, because we need QEMU to fully allocate hugepages. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 11 +++

[PATCH REBASE 7/7] qemu: Use memory-backend-* for regular guest memory

2020-09-01 Thread Michal Privoznik
So far, Libvirt configures memory-backend-* for memory hotplug, possibly NUMA nodes and in a few other cases. This patch switches to constructing the memory-backend-* command line for all cases. To keep ability to migrate guests a little hack is used: the ID of the object is set to the one that

[PATCH REBASE 6/7] qemu: Track default-ram-id machine attribute

2020-09-01 Thread Michal Privoznik
The machine structure has another (optional) attribute: default-ram-id, which specifies the alias of the default RAM object. While the alias is private, it can never change in order to not break migration. QEMU uses the alias when allocating regular, not NUMA memory. In order to switch to new

[PATCH REBASE 4/7] qemuBuildMemoryBackendProps: Fix const correctness

2020-09-01 Thread Michal Privoznik
The objects at @def and @mem pointers is only read and not written. Make the arguments const to make that explicit. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_command.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH REBASE 5/7] qemu: Introduce QEMU_CAPS_MACHINE_MEMORY_BACKEND

2020-09-01 Thread Michal Privoznik
This capability corresponds to '-machine memory-backend=' command line argument. Unfortunately, it is not possible for us to detect the capability via QMP and therefore we have to have a version check. The QEMU capability was introduced in v5.1.0-3-gc556600598. Signed-off-by: Michal Privoznik

[PATCH REBASE 1/7] qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part

2020-09-01 Thread Michal Privoznik
All three memory backends (-file, -ram and -memfd) have .prealloc attribute. Since we are setting it only for -file, the corresponding code lives only under if() that handles that specific backend. But in near future we will want to set the attribute for other backends too. Therefore, move the

[PATCH REBASE 0/7] qemu: Use memory-backend-* for regular guest memory

2020-09-01 Thread Michal Privoznik
This is a rebased version of patches posted in May: https://www.redhat.com/archives/libvir-list/2020-May/msg01114.html Fortunately, the QEMU part is now merged (v5.1.0-3-gc556600598) and thus these can get proper review. Michal Prívozník (7): qemuBuildMemoryBackendProps: Move @prealloc

[PATCH REBASE 2/7] qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate

2020-09-01 Thread Michal Privoznik
If user specifies immediate memory allocation in the domain XML, they want QEMU to fully allocate its memory. And if the memory was allocated using plain '-m' then we would honour it. But, if a memory backend is used, then we don't set the prealloc attribute of the backend. Signed-off-by: Michal

Re: [PATCH] NVRAM: check NVRAM file size and recover from template

2020-09-01 Thread Michal Privoznik
On 9/1/20 10:46 AM, Daniel P. Berrangé wrote: On Sat, Aug 08, 2020 at 06:01:22PM +0800, Hao Wang wrote: From: Hao Wang Subject: [PATCH] NVRAM: check NVRAM file size and recover from template A corrupted nvram file (e.g. caused by last unsuccessful creation due to insufficient memory) can lead

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 11:26:58AM +0200, Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 11:26:58 +0200, Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off.

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off. This is the case with > HAVE_BSD_NSS

[PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Michal Privoznik
When switching to meson, some of HAVE_* macros were renamed to WITH_ because they did not reflect whether the build platform has or doesn't have something, but whether we are building with some functionality turned on or off. This is the case with HAVE_BSD_NSS macro too. As a result, the NSS

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Erik Skultety
On Tue, Sep 01, 2020 at 12:24:11AM -0700, Prakhar Bansal wrote: > Hi Erik, > > Thanks for looking into my patch set!. > > I posted the patch set(PATCH 0-9) including the cover letter through git > send-email only from my personal email Id(prakharbansal0...@gmail.com). > Yesterday, only PATCH (3-9)

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Erik Skultety
On Tue, Sep 01, 2020 at 09:25:10AM +0200, Michal Privoznik wrote: > On 9/1/20 8:23 AM, Erik Skultety wrote: > > How did you post the patches? Normally I'd say that the first 2 may have got > > stuck in the queue due to size restrictions and they'd have to be moderated, > > but the cover letter is

Re: [PATCH libvirt-dbus 2/2] systemd: use SupplementaryGroups=libvirt so that ubuntu users can use the system connection

2020-09-01 Thread Daniel P . Berrangé
On Mon, Aug 31, 2020 at 09:45:16AM +0200, Katerina Koukiou wrote: > See https://bugs.launchpad.net/ubuntu/+source/libvirt-dbus/+bug/1892756 > > Signed-off-by: Katerina Koukiou > --- > data/system/libvirt-dbus.service.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH] NVRAM: check NVRAM file size and recover from template

2020-09-01 Thread Daniel P . Berrangé
On Sat, Aug 08, 2020 at 06:01:22PM +0800, Hao Wang wrote: > From: Hao Wang > Subject: [PATCH] NVRAM: check NVRAM file size and recover from template > > A corrupted nvram file (e.g. caused by last unsuccessful creation due to > insufficient memory) can lead to boot or migration failure. Or it

Re: Symbol missing in nss_libvirt.so

2020-09-01 Thread Michal Privoznik
On 9/1/20 10:19 AM, Roman Bogorodskiy wrote: Michal Privoznik wrote: On 9/1/20 5:20 AM, Roman Bogorodskiy wrote: WITH_BSD_NSS value is properly set: $ grep WITH_BSD_NSS build/meson-config.h #define WITH_BSD_NSS 1 $ Ah, I think this is the problem. In libvirt_nss.c we check for

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-01 Thread Cedric Bosdonnat
On Wed, 2020-08-12 at 19:21 -0400, Laine Stump wrote: > Yay! A user who follows up their conversation on the libvirt-users list > with a patch! :-) > > On 8/11/20 8:14 PM, Ian Wienand wrote: > > The checks modified here were added with > > 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing

Re: Symbol missing in nss_libvirt.so

2020-09-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > On 9/1/20 5:20 AM, Roman Bogorodskiy wrote: > > WITH_BSD_NSS value is properly set: > > > > $ grep WITH_BSD_NSS build/meson-config.h > > #define WITH_BSD_NSS 1 > > $ > > Ah, I think this is the problem. In libvirt_nss.c we check for > HAVE_BSD_NSS. Can you please

Re: Symbol missing in nss_libvirt.so

2020-09-01 Thread Michal Privoznik
On 9/1/20 5:20 AM, Roman Bogorodskiy wrote: WITH_BSD_NSS value is properly set: $ grep WITH_BSD_NSS build/meson-config.h #define WITH_BSD_NSS 1 $ Ah, I think this is the problem. In libvirt_nss.c we check for HAVE_BSD_NSS. Can you please check if something like this fixes the problem:

Re: [PATCH 0/5] Support CSS and DASD devices in node_device driver

2020-09-01 Thread Bjoern Walk
Bjoern Walk [2020-08-24, 01:59PM +0200]: > This series enables support for channel subsystem (CSS) devices, > Direct Access Storage Devices (DASDs) in the node_device driver and > adds support to create vfio-ccw mdev devices in the node_device driver. > > Boris Fiuczynski (5): > node_device:

Re: [PATCH] rpm: Fix conditional for defining %_vpath_builddir for RHEL <= 7

2020-09-01 Thread Jiri Denemark
On Sat, Aug 29, 2020 at 20:09:18 -0400, Neal Gompa wrote: > The conditional was incorrectly overriding %_vpath_builddir when > %rhel is not defined, which led to surprising behavior when the > global %_vpath_builddir path is set on Fedora already. > > Signed-off-by: Neal Gompa > --- >

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Prakhar Bansal
Hi Erik, Thanks for looking into my patch set!. I posted the patch set(PATCH 0-9) including the cover letter through git send-email only from my personal email Id(prakharbansal0...@gmail.com). Yesterday, only PATCH (3-9) were sent successfully to the mailing list and updated on the archive-list

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Michal Privoznik
On 9/1/20 8:23 AM, Erik Skultety wrote: How did you post the patches? Normally I'd say that the first 2 may have got stuck in the queue due to size restrictions and they'd have to be moderated, but the cover letter is missing too, which, unless you wrote a massive article in there, never

Re: [PATCH] qemu_validate: Only allow none address for watchdog ib700

2020-09-01 Thread Han Han
On Mon, Aug 31, 2020 at 9:48 PM Ján Tomko wrote: > On a Monday in 2020, Daniel Henrique Barboza wrote: > > > > > >On 8/21/20 7:19 AM, Han Han wrote: > >>Since QEMU 1.5.3, the ib700 watchdog device has no options for address, > >>and not address in device tree: > >> > >>$ /usr/libexec/qemu-kvm

Release of libvirt-6.7.0

2020-09-01 Thread Jiri Denemark
The 6.7.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any

Re: [GSoC] Take migration in Salt virt module to the next level

2020-09-01 Thread Cedric Bosdonnat
Hey Radostin, Thanks again for all the work you did on the Salt virt migration to make it cleaner and better tested! -- Cédric On Sat, 2020-08-29 at 10:06 +0100, Radostin Stoyanov wrote: > Hello again libvirt community! > > This summer, I once again worked on a GSoC project with libvirt. This

[GSoC PATCH 2/9] Jailhouse driver: Implementation of ConnectOpen

2020-09-01 Thread Prakhar Bansal
--- include/libvirt/virterror.h | 1 + po/POTFILES.in | 2 + src/jailhouse/Makefile.inc.am | 34 ++- src/jailhouse/jailhouse.conf| 10 + src/jailhouse/jailhouse_api.c | 372 src/jailhouse/jailhouse_api.h |

[GSoC PATCH 6/9] Jailhouse driver: Implementation of DomainLookup* callbacks

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal --- src/jailhouse/jailhouse_driver.c | 70 1 file changed, 61 insertions(+), 9 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index 2bb249f996..8c84a23388 100644 ---

[GSoC PATCH 7/9] Jailhouse driver: Implementation of DomainShutdown/Destroy callbacks

2020-09-01 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_api.c| 8 +++ src/jailhouse/jailhouse_driver.c | 101 +-- 2 files changed, 104 insertions(+), 5 deletions(-) diff --git a/src/jailhouse/jailhouse_api.c b/src/jailhouse/jailhouse_api.c index 783903e939..510e2f5f66 100644 ---

[GSoC PATCH 4/9] Jailhouse driver: Implementation of DomainCreate* callbacks

2020-09-01 Thread Prakhar Bansal
Implemented Jailhouse hypervisor APIs for cell load/start/shutdown/destroy. --- src/jailhouse/jailhouse_api.c| 100 -- src/jailhouse/jailhouse_api.h| 29 + src/jailhouse/jailhouse_driver.c | 217 +-- src/jailhouse/jailhouse_driver.h | 8 ++ 4

[GSoC PATCH 5/9] Jailhouse driver: Implementation of DomainInfo/State/List

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal --- src/jailhouse/jailhouse_driver.c | 102 +-- 1 file changed, 83 insertions(+), 19 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index 5b7bdc92d8..2bb249f996 100644 ---

[GSoC PATCH 0/9] Libvirt Driver for Jailhouse Hypervisor

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal My name is Prakhar Bansal and I am a graduate student at Iowa State University, Iowa, USA. During the last 3 months of GSoC'20, I worked on adding support for a new driver for the Jailhouse hypervisor. Following is the implementation of various Libvirt driver callbacks in

[GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_driver.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index ac9da4c85d..75bf41fc11 100644 --- a/src/jailhouse/jailhouse_driver.c +++

[GSoC PATCH 8/9] Jailhouse driver: Fixes for creation of cells, fetching cell info, disabling jailhouse hypervisor

2020-09-01 Thread Prakhar Bansal
- Added xmlopt to the Jailhouse driver - Added ACL check in ConnectOpen --- src/jailhouse/jailhouse_api.c| 48 +- src/jailhouse/jailhouse_driver.c | 58 2 files changed, 61 insertions(+), 45 deletions(-) diff --git

[GSoC PATCH 6/9] Jailhouse driver: Implementation of DomainLookup* callbacks

2020-09-01 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_driver.c | 70 1 file changed, 61 insertions(+), 9 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index 2bb249f996..8c84a23388 100644 --- a/src/jailhouse/jailhouse_driver.c +++

[GSoC] Take migration in Salt virt module to the next level

2020-09-01 Thread Radostin Stoyanov
Hello again libvirt community! This summer, I once again worked on a GSoC project with libvirt. This time, the goal of my project was to improve the libvirt integration with SaltStack and, in particular, the support for VM migration. SaltStack is an incredibly valuable tool that helps with

[GSoC PATCH 1/9] Jailhouse driver: first commit with skeleton code

2020-09-01 Thread Prakhar Bansal
--- include/libvirt/virterror.h | 2 +- libvirt.spec.in | 7 + m4/virt-driver-jailhouse.m4 | 42 + meson.build | 4 + meson_options.txt| 1 + src/conf/domain_conf.c | 1 +

[GSoC PATCH 8/9] Jailhouse driver: Fixes for creation of cells, fetching cell info, disabling jailhouse hypervisor

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal - Added xmlopt to the Jailhouse driver - Added ACL check in ConnectOpen --- src/jailhouse/jailhouse_api.c| 48 +- src/jailhouse/jailhouse_driver.c | 58 2 files changed, 61 insertions(+), 45 deletions(-) diff

[GSoC PATCH 9/9] Jailhouse driver: Add events to events queue in DomainCreate/Shutdown/Destroy

2020-09-01 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_driver.c | 20 1 file changed, 20 insertions(+) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index 45b1f35896..70f0f365cb 100644 --- a/src/jailhouse/jailhouse_driver.c +++ b/src/jailhouse/jailhouse_driver.c @@

[GSoC PATCH 5/9] Jailhouse driver: Implementation of DomainInfo/State/List

2020-09-01 Thread Prakhar Bansal
--- src/jailhouse/jailhouse_driver.c | 102 +-- 1 file changed, 83 insertions(+), 19 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index 5b7bdc92d8..2bb249f996 100644 --- a/src/jailhouse/jailhouse_driver.c +++

[GSoC PATCH 7/9] Jailhouse driver: Implementation of DomainShutdown/Destroy callbacks

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal --- src/jailhouse/jailhouse_api.c| 8 +++ src/jailhouse/jailhouse_driver.c | 101 +-- 2 files changed, 104 insertions(+), 5 deletions(-) diff --git a/src/jailhouse/jailhouse_api.c b/src/jailhouse/jailhouse_api.c index

[GSoC PATCH 4/9] Jailhouse driver: Implementation of DomainCreate* callbacks

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal Implemented Jailhouse hypervisor APIs for cell load/start/shutdown/destroy. --- src/jailhouse/jailhouse_api.c| 100 -- src/jailhouse/jailhouse_api.h| 29 + src/jailhouse/jailhouse_driver.c | 217 +--

[GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Prakhar Bansal
From: Prakhar Bansal --- src/jailhouse/jailhouse_driver.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index ac9da4c85d..75bf41fc11 100644 ---

Re: [GSoC PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType

2020-09-01 Thread Erik Skultety
How did you post the patches? Normally I'd say that the first 2 may have got stuck in the queue due to size restrictions and they'd have to be moderated, but the cover letter is missing too, which, unless you wrote a massive article in there, never happens, so I'm curious how you posted them so we