[PATCH] meson: src: Fix DESTDIR handling while creating dirs

2020-09-07 Thread Jan Kiszka
From: Jan Kiszka If the target path contains a link with an absolute path (e.g. /var/run -> /run), makedirs will target the wrong location. Resolve the path first, then append DESTDIR again if needed. Signed-off-by: Jan Kiszka --- scripts/meson-install-dirs.py | 5 - 1 file changed, 4

Re: [PATCH] qemu_process: Separate VIR_PERF_EVENT_* setting into a function

2020-09-07 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: When starting a domain, qemuProcessLaunch() iterates over all VIR_PERF_EVENT_* values and (possibly) enables them. While there is nothing wrong with the code, the for loop where its done makes *it's it harder to jump onto next block of code.

[PATCH] rpm: Remove pointless explicit dependency on 'readline'

2020-09-07 Thread Neal Gompa
The 'readline' package only contains the library, which rpm is already generating the (stricter) correct dependency for. Signed-off-by: Neal Gompa --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index d124a7ce45..379cf0d9be 100644 ---

[PATCH] wireshark: Prefer ws_version.h over config.h

2020-09-07 Thread Michal Privoznik
A wireshark plugin must declare what major and minor version it was built with as these are checked when wireshark loads plugins. On the top of that, we use major + minor + micro to adapt to changed API between releases. So far, we were getting these version numbers from wireshark/config.h. And

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-07 Thread Richard Henderson
On 9/7/20 2:05 AM, Alex Bennée wrote: > What about tweaking configure? Or should I just manually squash it in > all our CI configs? Squash in to CI, I would think. r~

Re: [libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

2020-09-07 Thread Laine Stump
On 9/7/20 10:58 AM, Tim Wiederhake wrote: This enables us to use g_auto* macros on those types. Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 91 + danielhb had sent similar patches for this file last week, which I had planned to

Re: [PATCH] news: add 1 improvement for v6.6.0

2020-09-07 Thread Andrea Bolognani
On Mon, 2020-09-07 at 16:48 +0200, Peter Krempa wrote: > On Mon, Sep 07, 2020 at 15:41:34 +0200, Andrea Bolognani wrote: > > On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > > > Incremental backup is not enabled yet, so there's no real point in > > > documenting patches implementing parts

Re: [PATCH] Revert "news: qemu: Support TLS for NBD connections for pull mode backup"

2020-09-07 Thread Andrea Bolognani
On Mon, 2020-09-07 at 16:43 +0200, Peter Krempa wrote: > Incremental backups are not enabled. There's no point documenting > individual patches implementing an incomplete feature. > > This reverts commit e6285f84faeacccdef12b69a7bc38975230d6662. > --- > NEWS.rst | 6 -- > 1 file changed, 6

[PATCH] virnuma: Report error when NUMA -> CPUs translation fails

2020-09-07 Thread Michal Privoznik
When starting a domain with set libvirt translates given NUMA nodes into a set of host CPUs which is then used to QEMU process affinity. But, if the numatune contains a non-existent NUMA node then the translation fails with no error reported. This is because virNumaNodesetToCPUset() calls

Re: [libvirt PATCH 01/15] cpu_map: Use g_auto* in loadData

2020-09-07 Thread Ján Tomko
On a Monday in 2020, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index cbf90d1395..c315ab32b2 100644 --- a/src/cpu/cpu_map.c +++

[libvirt PATCH 14/15] cpu_ppc64: Use g_auto* in virCPUppc64Baseline

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 30dd5a48c5..db59f5adbf 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -653,19

[libvirt PATCH 09/15] cpu_ppc64: Use g_auto* in ppc64ModelParse

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 81c3ce8319..44420c9cd5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@

[libvirt PATCH 11/15] cpu_ppc64: Use g_auto* in ppc64Compute

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 46 - 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 7b34fe6bbc..aef1418872 100644 --- a/src/cpu/cpu_ppc64.c +++

[libvirt PATCH 15/15] cpu_ppc64: Use g_auto* in virCPUppc64DriverGetModels

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index db59f5adbf..860e959900 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -734,33 +734,21 @@

[libvirt PATCH 01/15] cpu_map: Use g_auto* in loadData

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index cbf90d1395..c315ab32b2 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -32,6 +32,8 @@

[libvirt PATCH 02/15] cpu_map: Use g_auto* in cpuMapLoadInclude

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index c315ab32b2..1b73249649 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -81,10 +81,9 @@

[libvirt PATCH 04/15] cpu: Use g_auto* in virCPUCompareXML

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index d502c02f51..a84eb10cc4 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -111,21 +111,15 @@ virCPUCompareXML(virArch arch,

[libvirt PATCH 08/15] cpu_ppc64: Use g_auto* in ppc64VendorParse

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 9eaf9c6ae5..81c3ce8319 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -281,8 +281,7 @@

[libvirt PATCH 05/15] cpu: Use g_auto* in virCPUGetHost

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index a84eb10cc4..69e4205e4b 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -378,7 +378,7 @@ virCPUGetHost(virArch arch,

[libvirt PATCH 13/15] cpu_ppc64: Use g_auto* in virCPUppc64GetHost

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index d7ccd506fb..30dd5a48c5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -605,17 +605,16 @@ static

[libvirt PATCH 07/15] cpu_ppc64: Use g_auto* in ppc64ModelCopy

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index c7860cb1b4..9eaf9c6ae5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -188,23 +188,19 @@

[libvirt PATCH 00/15] Use g_auto* in src/cpu/*.

2020-09-07 Thread Tim Wiederhake
Mostly mechanical changes, the most "interesting" patches are the first (wher= e should the `G_DEFINE_AUTOPTR_CLEANUP_FUN` go?) and the last (removing call to `g_str= freev`, as it should not be necessary). As an added benefit, this removes all `goto` usage in this directory. Tim Wiederhake

[libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

2020-09-07 Thread Tim Wiederhake
This enables us to use g_auto* macros on those types. Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 91 + 1 file changed, 50 insertions(+), 41 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 5b34c00a18..c7860cb1b4

[libvirt PATCH 10/15] cpu_ppc64: Use g_auto* in ppc64LoadMap

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 44420c9cd5..7b34fe6bbc 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -384,19 +384,15 @@

[libvirt PATCH 03/15] cpu_map: Use g_auto* in loadIncludes

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 1b73249649..372c00a1cd 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -117,37 +117,31 @@

[libvirt PATCH 12/15] cpu_ppc64: Use g_auto* in ppc64DriverDecode

2020-09-07 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index aef1418872..d7ccd506fb 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -563,8 +563,7 @@

Re: [libvirt PATCH] wireshark: Don't include config.h

2020-09-07 Thread Andrea Bolognani
On Fri, 2020-09-04 at 17:37 +0200, Michal Prívozník wrote: > On 9/4/20 5:12 PM, Andrea Bolognani wrote: > > I don't think it's done on purpose: it's probably just a bug in the > > Debian packaging that got propagated to Ubuntu. > > > > Even assuming that's the case, it will take some time for it

Re: [PATCH] Revert "news: qemu: Support TLS for NBD connections for pull mode backup"

2020-09-07 Thread Ján Tomko
On a Monday in 2020, Peter Krempa wrote: Incremental backups are not enabled. There's no point documenting individual patches implementing an incomplete feature. This reverts commit e6285f84faeacccdef12b69a7bc38975230d6662. Please, drop the ending period. --- NEWS.rst | 6 -- 1 file

[PATCH] qemu_process: Separate VIR_PERF_EVENT_* setting into a function

2020-09-07 Thread Michal Privoznik
When starting a domain, qemuProcessLaunch() iterates over all VIR_PERF_EVENT_* values and (possibly) enables them. While there is nothing wrong with the code, the for loop where its done makes it harder to jump onto next block of code. Signed-off-by: Michal Privoznik --- Is this trivial enough

Re: [PATCH] news: add 1 improvement for v6.6.0

2020-09-07 Thread Peter Krempa
On Mon, Sep 07, 2020 at 15:41:34 +0200, Andrea Bolognani wrote: > On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > > On Thu, Sep 03, 2020 at 02:56:48 +, Yanqiu Zhang wrote: > > > + * qemu: Support TLS for NBD connections for pull mode backup > > > + > > > +Use the configured TLS

watchdog fed successfully event of 6300esb

2020-09-07 Thread ligang (P)
Hi folks, I have an question to discuss about the 6300esb watchdog. I think is it possible that qemu can send an event while the watchdog successfully fed by the vm at the first time. Here is the situation: Qemu will send an VIR_DOMAIN_EVENT_ID_WATCHDOG event while watch dog timeout, and if

[PATCH] Revert "news: qemu: Support TLS for NBD connections for pull mode backup"

2020-09-07 Thread Peter Krempa
Incremental backups are not enabled. There's no point documenting individual patches implementing an incomplete feature. This reverts commit e6285f84faeacccdef12b69a7bc38975230d6662. --- NEWS.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index

Re: [PATCH] docs: Discourage users from using fwcfg

2020-09-07 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 04:20:02PM +0200, Michal Privoznik wrote: > On 9/7/20 3:57 PM, Martin Kletzander wrote: > > On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik wrote: > > > Even though this was brought up in upstream discussion [1] it > > > missed my patches: users should prefer

Re: [libvirt PATCH 1/2] network: don't wait for IPv6 DAD completion when starting a network

2020-09-07 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 02:01:14PM -0400, Laine Stump wrote: > 0f7436ca54 added code during virtual network startup to wait for DAD > (Duplicate Address Detection) to complete if there were any IPv6 > addresses on the network. This wait was needed because (according to > the commit log) "created

Re: [PATCH] docs: Discourage users from using fwcfg

2020-09-07 Thread Michal Privoznik
On 9/7/20 3:57 PM, Martin Kletzander wrote: On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik wrote: Even though this was brought up in upstream discussion [1] it missed my patches: users should prefer over fwcfg. The reason is that fwcfg is considered somewhat internal to QEMU and it

Re: [PATCH] docs: Discourage users from using fwcfg

2020-09-07 Thread Martin Kletzander
On Mon, Sep 07, 2020 at 03:48:16PM +0200, Michal Privoznik wrote: Even though this was brought up in upstream discussion [1] it missed my patches: users should prefer over fwcfg. The reason is that fwcfg is considered somewhat internal to QEMU and it has limited number of slots and neither of

[PATCH] docs: Discourage users from using fwcfg

2020-09-07 Thread Michal Privoznik
Even though this was brought up in upstream discussion [1] it missed my patches: users should prefer over fwcfg. The reason is that fwcfg is considered somewhat internal to QEMU and it has limited number of slots and neither of these applies to . While I'm at it, I'm fixing the example too

Re: [PATCH] news: add 1 improvement for v6.6.0

2020-09-07 Thread Andrea Bolognani
On Mon, 2020-09-07 at 14:42 +0200, Peter Krempa wrote: > On Thu, Sep 03, 2020 at 02:56:48 +, Yanqiu Zhang wrote: > > + * qemu: Support TLS for NBD connections for pull mode backup > > + > > +Use the configured TLS env to setup encryption of the TLS transport. > > Add 'tls' > > +

Re: [PATCH v2] qemu_namespace: Don't leak mknod items that are being skipped over

2020-09-07 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: When building and populating domain NS a couple of functions are called that append paths to a string list. This string list is then inspected, one item at the time by qemuNamespacePrepareOneItem() which gathers all the info for given path (stat

Re: [libvirt PATCH 0/2] Fix IPv6 network startup after removal of "dummy" tap device

2020-09-07 Thread Ján Tomko
On a Friday in 2020, Laine Stump wrote: After the patch that removed the dummy tap device was added (commit ee6c936fbb), IPv6 networks would no longer start due to a "failure to complete DAD". Since this wait was only necessary because of the existence of the dummy tap device (see detailed git

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Am 07.09.20 um 13:48 schrieb Daniel P. Berrangé: > On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: ... > Switching back to -drive is out of the question. We've worked very hard > to eliminate its usage and get to an exclusively -blockdev based solution > because supporting both

Re: [PATCH] news: add 1 improvement for v6.6.0

2020-09-07 Thread Peter Krempa
On Thu, Sep 03, 2020 at 02:56:48 +, Yanqiu Zhang wrote: > Support TLS for NBD connections for pull mode backup. > > Signed-off-by: Yanqiu Zhang > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index e4b71e6563..d0b16e28fc 100644 > ---

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Peter Krempa
On Mon, Sep 07, 2020 at 12:48:21 +0100, Daniel Berrange wrote: > On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: > > Hi, [...] > > > 1. doing this transparently with a controller per device, just like the > > > usb-storage controller does internally (ok - it's just a scsi-cd

Re: [PATCH] qemu: Allow setting affinity to fail and don't report error

2020-09-07 Thread Ján Tomko
On a Monday in 2020, Martin Kletzander wrote: This is just a clean-up of commit 3791f29b085c using the new parameter of virProcessSetAffinity() introduced in commit 9514e24984ee so that there is no error reported in the logs. Signed-off-by: Martin Kletzander --- src/qemu/qemu_process.c | 65

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Hi Am 07.09.20 um 13:45 schrieb Gerd Hoffmann: >> -device nec-usb-xhci,id=xhci \ >> -device usb-bot,id=scsi0,bus=xhci.0 \ >> -device >> scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 >> \ >> -device >>

[PATCH v2] qemu_namespace: Don't leak mknod items that are being skipped over

2020-09-07 Thread Michal Privoznik
When building and populating domain NS a couple of functions are called that append paths to a string list. This string list is then inspected, one item at the time by qemuNamespacePrepareOneItem() which gathers all the info for given path (stat buffer, possible link target, ACLs, SELinux label)

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-07 Thread Zhenyu Zheng
So the suitable way of doing this will be checking for `VIR_CPU_TYPE_HOST` and perform a comparison in this case and still return IDENTICAL for all other cases right? Then the upper layer caller(like OpenStack Nova) will have to pass source host cpu info as a parameter. BR, Zhenyu On Mon, Sep

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: > Hi, > > > -device nec-usb-xhci,id=xhci \ > > -device usb-bot,id=scsi0,bus=xhci.0 \ > > -device > > scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 > > \ >

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Gerd Hoffmann
Hi, > -device nec-usb-xhci,id=xhci \ > -device usb-bot,id=scsi0,bus=xhci.0 \ > -device > scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 > \ > -device >

Re: [PATCH] Do not report error when setting affinity is allowed to fail

2020-09-07 Thread Martin Kletzander
On Mon, Sep 07, 2020 at 10:59:58AM +0200, Ján Tomko wrote: On a Sunday in 2020, Martin Kletzander wrote: Suggested-by: Ján Tomko Signed-off-by: Martin Kletzander --- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_driver.c | 7 --- src/qemu/qemu_process.c | 10 +-

[PATCH] qemu: Allow setting affinity to fail and don't report error

2020-09-07 Thread Martin Kletzander
This is just a clean-up of commit 3791f29b085c using the new parameter of virProcessSetAffinity() introduced in commit 9514e24984ee so that there is no error reported in the logs. Signed-off-by: Martin Kletzander --- src/qemu/qemu_process.c | 65 +++-- 1 file

Re: Various issues when using multiple graphic outputs

2020-09-07 Thread Christian Ehrhardt
On Fri, Sep 4, 2020 at 1:30 PM Gerd Hoffmann wrote: > > Hi, > > > Well my initial target before I realized that it seemed to affect all > > combinations in different ways was to get a mediated device to work well. > > So If the answer is "just use only one" then I need to find a way to > >

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-07 Thread Jiri Denemark
On Mon, Sep 07, 2020 at 09:21:02 +0800, Zhenyu Zheng wrote: > Thanks alot for the reply, > > This sounds like a valid use case (not sure it is that useful), but we > > need to be careful. But we should make sure implementing this does not > > break anything. This means, we need to do different

Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-09-07 Thread Nikolay Shirokovskiy
Pushed now. Thanx everyone for review. Patch "[PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks" does not have mantainer review but I guess it is ok as the patch is simple enough and it's API is used in other patches of series. I would also want to note that crashes are still

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Am 07.09.20 um 08:04 schrieb Gerd Hoffmann: >> USB disks. The main problem is, that -blockdev mechanism relies >> on the device type to handle the media type, like ide-cd and >> ide-hd. But there is just usb-storage. > > You can use -device usb-bot + -device scsi-cd ... So I tried -blockdev

Re: [libvirt PATCH] remove HAL node device driver

2020-09-07 Thread Pavel Hrdina
On Fri, Sep 04, 2020 at 02:59:33PM -0300, Daniel Henrique Barboza wrote: > This makes meson complains about POTFILES.in: > > > po_check > --- /home/danielhb/kvm-project/libvirt/po/POTFILES.in > +++ /home/danielhb/kvm-project/libvirt/po/POTFILES.in > @@ -130,7 +130,6 @@ >

Re: [PATCH] Fix linkage to libutil and libkvm on FreeBSD 11

2020-09-07 Thread Pavel Hrdina
On Fri, Sep 04, 2020 at 02:23:48PM +0100, Daniel P. Berrangé wrote: > We are currently adding -lutil and -lkvm to the linker using the > add_project_link_arguments method. On FreeBSD 11.4, this results in > build errors because the args appear too early in the command line. > > We need to pass

Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-09-07 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 10:12:08AM +0300, Nikolay Shirokovskiy wrote: > Pushed now. Thanx everyone for review. > > Patch "[PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks" does not > have mantainer > review but I guess it is ok as the patch is simple enough and it's API is > used in

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-07 Thread Richard Henderson
On 9/4/20 10:21 AM, Peter Maydell wrote: > On Fri, 4 Sep 2020 at 17:52, Alex Bennée wrote: >> >> It's buggy and we are not sure anyone uses it. > >> +``ppc64abi32`` CPUs (since 5.2.0) >> +' >> + >> +The ``ppc64abi32`` architecture has a number of issues which

[libvirt PATCH] qemu: migration: remove unused variable

2020-09-07 Thread Ján Tomko
../src/qemu/qemu_migration.c:4091:36: error: unused variable 'cfg' [-Werror,-Wunused-variable] g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); Signed-off-by: Ján Tomko Fixes: d92c2bbc6597fcb951b303a9122ec1ca71514d10 --- Pushed. src/qemu/qemu_migration.c | 1 - 1 file

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-07 Thread Alex Bennée
Peter Maydell writes: > On Fri, 4 Sep 2020 at 17:52, Alex Bennée wrote: >> >> It's buggy and we are not sure anyone uses it. > >> +``ppc64abi32`` CPUs (since 5.2.0) >> +' >> + >> +The ``ppc64abi32`` architecture has a number of issues which regularly >> +trip

Re: [PATCH] Do not report error when setting affinity is allowed to fail

2020-09-07 Thread Ján Tomko
On a Sunday in 2020, Martin Kletzander wrote: Suggested-by: Ján Tomko Signed-off-by: Martin Kletzander --- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_driver.c | 7 --- src/qemu/qemu_process.c | 10 +- src/util/virprocess.c| 32 +++-

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Gerd Hoffmann
> USB disks. The main problem is, that -blockdev mechanism relies > on the device type to handle the media type, like ide-cd and > ide-hd. But there is just usb-storage. You can use -device usb-bot + -device scsi-cd ... take care, Gerd