virshDomainFree correctly handle null pointer parameters.
There is no need to check if the parameter is null before
calling this function.
Signed-off-by: Yi Li
---
tools/virsh-domain-monitor.c | 6 ++
tools/virsh-domain.c | 3 +--
2 files changed, 3 insertions(+), 6 deletions(-)
On Thu, Sep 10, 2020 at 12:02:44PM -0600, Alex Williamson wrote:
> On Thu, 10 Sep 2020 13:50:11 +0100
> Sean Mooney wrote:
>
> > On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote:
> > > On Wed, 9 Sep 2020 10:13:09 +0800
> > > Yan Zhao wrote:
> > >
> > > > > > still, I'd like to put it
Polite ping
On 18.08.2020 13:26, Nikolay Shirokovskiy wrote:
> Nikolay Shirokovskiy (2):
> qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish
> qemu: don't needlessly unset close callback during perform phase
>
> src/qemu/qemu_migration.c | 14 +++---
> 1 file changed,
On Thu, 10 Sep 2020 13:50:11 +0100
Sean Mooney wrote:
> On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote:
> > On Wed, 9 Sep 2020 10:13:09 +0800
> > Yan Zhao wrote:
> >
> > > > > still, I'd like to put it more explicitly to make ensure it's not
> > > > > missed:
> > > > > the reason we
On 9/10/20 11:59 AM, Daniel P. Berrangé wrote:
On Thu, Jul 30, 2020 at 04:48:01PM -0300, Daniel Henrique Barboza wrote:
The existing auto-align behavior for pSeries has the idea to
alleviate user configuration of the NVDIMM size, given that the
alignment calculation is not trivial to do
On 9/10/20 8:35 AM, Martin Kletzander wrote:
On Thu, Sep 10, 2020 at 01:56:53PM +0200, Pino Toscano wrote:
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better
On Thu, Jul 30, 2020 at 04:48:01PM -0300, Daniel Henrique Barboza wrote:
> The existing auto-align behavior for pSeries has the idea to
> alleviate user configuration of the NVDIMM size, given that the
> alignment calculation is not trivial to do (256MiB alignment
> of mem->size - mem->label_size
On Thu, Sep 10, 2020 at 03:22:51PM +0200, Erik Skultety wrote:
> #useless_use_of_cat
>
You also changed semantics to avoid accidental sub-string matches
> Signed-off-by: Erik Skultety
> ---
>
> Dedicated to everyone who felt deeply offended by the useless use of cat :).
>
>
Implement the .domainGetHostname hypervisor driver API to get the
hostname of a running guest (needs VMware Tools).
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 3 +++
src/esx/esx_driver.c | 54
2 files changed, 57 insertions(+)
diff
On Thu, 2020-09-10 at 12:36 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 10, 2020 at 01:29:19PM +0200, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > src/rpc/virnetmessage.c | 2 +-
> > src/util/viralloc.h | 14 --
> > src/util/virbitmap.c| 2 +-
> >
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino Toscano
---
Changes in v2:
- remove some of the
#useless_use_of_cat
Signed-off-by: Erik Skultety
---
Dedicated to everyone who felt deeply offended by the useless use of cat :).
docs/kbase/launch_security_sev.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/kbase/launch_security_sev.rst
It's buggy and we are not sure anyone uses it.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: David Gibson
Message-Id: <20200909112742.25730-6-alex.ben...@linaro.org>
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
When a list is freed, we iterate through all the items, invoking the
free function for each; the actual free function called for each element
is the function of the actual type of each element, and thus the @_next
pointer in the element struct has the same type as the element itself.
Currently,
Daniel P. Berrangé wrote:
> We are currently adding -lutil and -lkvm to the linker using the
> add_project_link_arguments method. On FreeBSD 11.4, this results in
> build errors because the args appear too early in the command line.
>
> We need to pass the libraries as dependencies so that
On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote:
> On Wed, 9 Sep 2020 10:13:09 +0800
> Yan Zhao wrote:
>
> > > > still, I'd like to put it more explicitly to make ensure it's not
> > > > missed:
> > > > the reason we want to specify compatible_type as a trait and check
> > > > whether
On Wed, 9 Sep 2020 10:13:09 +0800
Yan Zhao wrote:
> > > still, I'd like to put it more explicitly to make ensure it's not missed:
> > > the reason we want to specify compatible_type as a trait and check
> > > whether target compatible_type is the superset of source
> > > compatible_type is for
On Thu, Sep 10, 2020 at 01:56:53PM +0200, Pino Toscano wrote:
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
This is something that
On Thu, Sep 10, 2020 at 01:44:34PM +0200, Pino Toscano wrote:
When a list is freed, we iterate through all the items, invoking the
free function for each; the actual free function called for each element
is the function of the actual type of each element, and thus the @_next
pointer in the
On a Thursday in 2020, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c | 2 +-
src/cpu/cpu_map.c | 6 +++---
src/cpu/cpu_ppc64.c | 18 +-
src/cpu/cpu_x86.c | 10 +-
4 files changed, 18 insertions(+), 18 deletions(-)
[...]
diff --git
On a Thursday in 2020, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_ppc64.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2020, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c | 4 +---
src/cpu/cpu_ppc64.c | 25 -
2 files changed, 9 insertions(+), 20 deletions(-)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index 69e4205e4b..c3eef52c79 100644
---
On Thu, Sep 10, 2020 at 12:52:52PM +0100, Daniel P. Berrangé wrote:
> We are currently adding -lutil and -lkvm to the linker using the
> add_project_link_arguments method. On FreeBSD 11.4, this results in
> build errors because the args appear too early in the command line.
>
> We need to pass
On Thu, Sep 10, 2020 at 7:57 AM Pino Toscano wrote:
>
> A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
> the number of the error, even in cases where there is one fitting more.
> Hence, replace some of them with better virErrorNumber values.
>
> Signed-off-by: Pino
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c| 4 ++--
On Wed, Sep 9, 2020 at 10:25 AM Andrea Bolognani wrote:
>
> On Wed, 2020-09-09 at 16:09 +0200, Pavel Hrdina wrote:
> > On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> > > Taking a step back,
> > > what are the reasons one might want to call either meson or ninja to
> > > run
On Thu, Sep 10, 2020 at 7:48 AM Pino Toscano wrote:
>
> When a list is freed, we iterate through all the items, invoking the
> free function for each; the actual free function called for each element
> is the function of the actual type of each element, and thus the @_next
> pointer in the
We are currently adding -lutil and -lkvm to the linker using the
add_project_link_arguments method. On FreeBSD 11.4, this results in
build errors because the args appear too early in the command line.
We need to pass the libraries as dependencies so that they get placed
at the same point in the
When a list is freed, we iterate through all the items, invoking the
free function for each; the actual free function called for each element
is the function of the actual type of each element, and thus the @_next
pointer in the element struct has the same type as the element itself.
Currently,
On Thu, Sep 10, 2020 at 01:29:19PM +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/rpc/virnetmessage.c | 2 +-
> src/util/viralloc.h | 14 --
> src/util/virbitmap.c| 2 +-
> src/util/virerror.c | 6 +++---
> src/util/virlog.c | 2 +-
>
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_domain.c | 4 ++--
src/qemu/qemu_process.c | 2 +-
src/util/viralloc.h | 15 ---
src/util/virfile.c | 2 +-
tests/virpcimock.c | 6 +++---
tools/vsh.c | 2 +-
6 files changed, 8 insertions(+), 23
This series furthers the transition from VIR_ALLOC, VIR_FREE, etc to glib fun=
ctions and
removes the "_QUIET" variants of VIR_{ALLOC,ALLOC_N,REALLOC_N,APPEND_ELEMENT}=
that by
now are aliases to their non-quiet counterparts.
Tim Wiederhake (7):
util: alloc: Remove VIR_ALLOC_QUIET
util:
Signed-off-by: Tim Wiederhake
---
src/util/viralloc.h | 15 ---
src/util/virbitmap.c| 2 +-
src/util/virdevmapper.c | 2 +-
src/util/virjson.c | 2 +-
src/util/virlog.c | 2 +-
tests/virconftest.c | 2 +-
6 files changed, 5 insertions(+), 20 deletions(-)
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c | 2 +-
src/cpu/cpu_map.c | 6 +++---
src/cpu/cpu_ppc64.c | 18 +-
src/cpu/cpu_x86.c | 10 +-
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_ppc64.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index ca2cfa0a67..6477b4bce7 100644
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -134,9 +134,7 @@
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c | 4 +---
src/cpu/cpu_ppc64.c | 25 -
2 files changed, 9 insertions(+), 20 deletions(-)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index 69e4205e4b..c3eef52c79 100644
--- a/src/cpu/cpu.c
+++ b/src/cpu/cpu.c
@@ -286,9
Signed-off-by: Tim Wiederhake
---
src/rpc/virnetmessage.c | 2 +-
src/util/viralloc.h | 14 --
src/util/virbitmap.c| 2 +-
src/util/virerror.c | 6 +++---
src/util/virlog.c | 2 +-
src/util/virthread.c| 2 +-
tests/virpcimock.c | 6 +++---
7 files
Signed-off-by: Tim Wiederhake
---
src/util/viralloc.h| 4
tests/virfilewrapper.c | 4 ++--
tests/virpcimock.c | 7 +++
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index a50cd5d632..a581a2935e 100644
---
On a Saturday in 2020, Roman Bogorodskiy wrote:
Support modeling of the 'isa' controller for bhyve. User can manually
define any PCI slot for the 'isa' controller, including PCI slot 1,
but other devices are not allowed to use this address.
When domain configuration requires the 'isa'
On a Saturday in 2020, Roman Bogorodskiy wrote:
Introduce 'isa' controller type. In domain XML it looks this way:
...
...
Currently, this is needed for the bhyve driver to allow choosing a
specific PCI address for that. In bhyve, this controller is used to
attach serial
On Sat, Aug 01, 2020 at 10:16:57AM +0400, Roman Bogorodskiy wrote:
> Support modeling of the 'isa' controller for bhyve. User can manually
> define any PCI slot for the 'isa' controller, including PCI slot 1,
> but other devices are not allowed to use this address.
>
> When domain configuration
On Sat, Aug 01, 2020 at 10:16:56AM +0400, Roman Bogorodskiy wrote:
> Introduce 'isa' controller type. In domain XML it looks this way:
>
> ...
>
> function='0x0'/>
>
> ...
>
> Currently, this is needed for the bhyve driver to allow choosing a
> specific
Roman Bogorodskiy wrote:
> Changes from v4:
>
> - Document 'isa' controller type in docs/formatdomain.html.in.
>While here, add 'xenbus' which was also missing.
>
> Roman Bogorodskiy (2):
> conf: add 'isa' controller type
> bhyve: support 'isa' controller for LPC
>
>
Hi Ian,
On Thu, 2020-09-10 at 09:48 +1000, Ian Wienand wrote:
> On Wed, Sep 09, 2020 at 06:38:04AM +, Cedric Bosdonnat wrote:
> > The check didn't involve any NetworkManager at all, but a network with
> > RA route for the default route. Completely removing the check is rather
> > likely to
On Wed, Sep 09, 2020 at 05:29:20PM +0200, Cornelia Huck wrote:
> On Wed, 9 Sep 2020 14:40:33 +0200
> Erik Skultety wrote:
>
> > On Wed, Sep 09, 2020 at 08:23:39AM +0200, Bjoern Walk wrote:
> > > Erik Skultety [2020-09-08, 06:01PM +0200]:
> > > > On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern
On 9/4/20 6:57 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 12/17/19 7:43 PM, Aleksandar Markovic wrote:
>> From: Thomas Huth
>> Sent: Tuesday, December 17, 2019 7:10 PM
>> To: Philippe Mathieu-Daudé; qemu-de...@nongnu.org
>> Cc: libvir-list@redhat.com; Hervé Poussineau; Aleksandar Markovic;
On Wed, Sep 09, 2020 at 03:47:42PM -0400, Matt Coleman wrote:
> I knew I’d miss something... Shucks!
>
> Does this work, or should I start a separate [PATCH v2] thread with the DCO
> added to the commit messages?
>
> Signed-off-by: Matt Coleman
Pushed. Congratulations on your first libvirt
47 matches
Mail list logo
