Re: [libvirt PATCH] esx: implement domainGetHostname

2020-09-12 Thread Neal Gompa
On Thu, Sep 10, 2020 at 9:28 AM Pino Toscano wrote: > > Implement the .domainGetHostname hypervisor driver API to get the > hostname of a running guest (needs VMware Tools). > > Signed-off-by: Pino Toscano > --- > docs/drvesx.html.in | 3 +++ > src/esx/esx_driver.c | 54 +++

Re: [PATCH 07/17] tests: qemustatusxml2xmldata: Rename 'disk-secinfo-upgrade' case to 'upgrade'

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: The test case tests other things besides disk secinfos, so we can make it more universal. Signed-off-by: Peter Krempa --- .../{disk-secinfo-upgrade-in.xml => upgrade-in.xml} | 0 .../{disk-secinfo-upgrade-out.xml => upgrade-out.xml}

Re: [PATCH 06/17] conf: Add virStorageSource member for SCSI host device config data

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: The backend for the SCSI host device is a storage source. While the definition doesn't look like that it's converted to a storage source when the VM is running. Add the storage source to the definition object and also parse/format it's private data which

Re: [PATCH 05/17] qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add hostdev with useralias

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: Add a SCSI host device with a user-specified alias to illustrate the upcoming changes. Signed-off-by: Peter Krempa --- .../hostdev-scsi-virtio-scsi.x86_64-2.8.0.args| 3 +++ .../hostdev-scsi-virtio-scsi.x86_64-4.1.0.args| 3 +++ ...

Re: [PATCH 03/17] virDomainHostdevSubsysSCSIHostDefParseXML: Switch to a more modern XML parsing approach

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: Use XPath instead of iterating through the nodes. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 98 +++--- 1 file changed, 35 insertions(+), 63 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/dom

Re: [libvirt PATCH] esx: implement domainGetHostname

2020-09-12 Thread Ján Tomko
On a Thursday in 2020, Pino Toscano wrote: Implement the .domainGetHostname hypervisor driver API to get the hostname of a running guest (needs VMware Tools). Signed-off-by: Pino Toscano --- docs/drvesx.html.in | 3 +++ src/esx/esx_driver.c | 54 2 f

Re: [libvirt] [PATCH 00/12] qemu/virsh/docs: various minor fixes

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Lin Ma (12): qemu: qemuDomainPMSuspendForDuration: Check availability of agent virsh: domblkinfo: options --all and --device are mutually exclusive virsh: domdisplay: options --all and --type are mutually exclusive virsh: iface-list: options --all and --inac

Re: [libvirt] [PATCH 11/12] docs: virsh: Document the IO mode 'io_uring'

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index ca5acf84ca..b8206205f6 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.

Re: [libvirt] [PATCH 12/12] docs: virsh: Drop duplicate spelling for dompmwakeup

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- docs/manpages/virsh.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt] [PATCH 10/12] virsh: pool-list: options --all and --inactive are mutually exclusive

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-pool.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt] [PATCH 09/12] virsh: iface-list: options --all and --inactive are mutually exclusive

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-interface.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt] [PATCH 08/12] virsh: domdisplay: options --all and --type are mutually exclusive

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt] [PATCH 07/12] virsh: domblkinfo: options --all and --device are mutually exclusive

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt] [PATCH 06/12] virsh: event: options --all and --event are mutually exclusive

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 86152a53b1..657a0532db 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -13696,6 +13696,8 @@ cmd

Re: [libvirt] [PATCH 05/12] virsh: net-port-create: log errors for non-existent xml file

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-network.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index f0f5358625..ce67e3f19b 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -1522,6 +1522,7 @@ cm

Re: [libvirt] [PATCH 04/12] virsh: domid: Error out if domain is not active

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-domain.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d1d3f8e566..86152a53b1 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c

Re: [libvirt] [PATCH 02/12] qemu: Return perf status that affect next boot for shutoff domains

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: While we set up perf events for a shutoff domain and check the settings, All of perf events are reported as 'disabled', unless we add --config, This is redundant for a shutoff domain. # virsh domstate $GUEST shut off # virsh perf --domain $GUEST cmt

Re: [libvirt] [PATCH 01/12] qemu: qemuDomainPMSuspendForDuration: Check availability of agent

2020-09-12 Thread Ján Tomko
On a Friday in 2020, Lin Ma wrote: It requires a guest agent configured and running in the domain's guest OS, So check qemu agent during qemuDomainPMSuspendForDuration(). Signed-off-by: Lin Ma --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Ján Tomko Jano

Re: [PATCH 0/3] numa: cleanups for 5.2

2020-09-12 Thread Paolo Bonzini
On 11/09/20 10:44, Igor Mammedov wrote: > Remove deprecated default RAM splitting beween numa > nodes that was deprecated since 4.1, and a couple of > minor numa clean ups. > > Igor Mammedov (3): > numa: drop support for '-numa node' (without memory specified) > doc: Cleanup "'-mem-path' fallb