Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 12
1 file changed, 12 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 14f098b1f6..9020696f86 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,18 @@ v6.8.0 (unreleased)
useful for containerised scenarios and can be
Hi,
In [1], Daniel pointed out that the changes made by [2]
are uncompliant with the Libvirt design of not doing
anything that can compromise guests in the wild.
This series aims to solve that by reverting the changes
made by [2]. It also enhances the auto-alignment of ppc64
NVDIMM in a way that
The alignment for the pSeries NVDIMM does not depend on runtime
constraints. This means that it can be done in device parse
time, instead of runtime, allowing the domain XML to reflect
what the auto-alignment would do when the domain starts.
This brings consistency between the NVDIMM size
We'll use the auto-alignment function during parse time, in
domain_conf.c. Let's move the function to that file, renaming
it to virDomainNVDimmAlignSizePseries(). This will also make it
clearer that, although QEMU is the only driver that currently
supports it, pSeries NVDIMM restrictions aren't
In [1], changes were made to remove the existing auto-alignment
for pSeries NVDIMM devices. That design promotes strange situations
where the NVDIMM size reported in the domain XML is different
from what QEMU is actually using. We removed the auto-alignment
and relied on standard size validation.
There is issue with second patch. Probably this unset/set was too mysterious
and I miss one point - we do need to call unset on error path as in case
of non p2p migration confirm step will not be called.
So this need to be squashed in:
diff --git a/src/qemu/qemu_migration.c
This series enables support for channel subsystem (CSS) devices,
Direct Access Storage Devices (DASDs) in the node_device driver and
adds support to create vfio-ccw mdev devices in the node_device driver.
Changed in V2:
* now filtering only supported drivers in udevProcessCSS
* renamed
Make Direct Access Storage Devices (DASDs) available in the node_device driver.
Reviewed-by: Bjoern Walk
Reviewed-by: Erik Skultety
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 27 +++
1 file changed, 27 insertions(+)
diff --git
Make channel subsystem (CSS) devices available in the node_device driver.
The CCS devices reside in the computer system and provide CCW devices, e.g.:
+- css_0_0_003a
|
+- ccw_0_0_1a2b
|
+- scsi_host0
|
+- scsi_target0_0_0
Allow to filter for CSS devices.
Reviewed-by: Bjoern Walk
Reviewed-by: Erik Skultety
Signed-off-by: Boris Fiuczynski
---
docs/formatnode.html.in | 12
docs/manpages/virsh.rst | 2 +-
include/libvirt/libvirt-nodedev.h | 1 +
src/conf/node_device_conf.h
Refactor out CCW address parsing for later reuse.
Reviewed-by: Erik Skultety
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 31 --
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git
Allow vfio-ccw mdev devices to be created besides vfio-pci mdev devices
as well.
Reviewed-by: Bjoern Walk
Signed-off-by: Boris Fiuczynski
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 +++
src/libvirt_private.syms | 1 +
On 9/14/20 6:08 PM, Ján Tomko wrote:
Ján Tomko (3):
virsh-completer: use g_clear_pointer in virshCommaStringListComplete
virsh-completer: use g_free instead of VIR_FREE
virsh-completer: use g_new0 instead of VIR_ALLOC_N
tools/virsh-completer-checkpoint.c | 11
derp! :-O
On 9/14/20 7:03 AM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
Fixes: 95089f481e003d971fe0a082018216c58c1b80e5
---
Pushed as trivial.
src/util/virnetdevtap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 +
src/esx/esx_driver.c | 170 +++
2 files changed, 174
Add the definition of the GuestNicInfo object, with all the required
objects for it.
Signed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py| 1 +
src/esx/esx_vi_generator.input | 54 ++
2 files changed, 55 insertions(+)
diff --git
On Monday, 14 September 2020 17:33:02 CEST Michal Privoznik wrote:
> > +for (dynamicProperty = virtualMachine->propSet; dynamicProperty;
> > + dynamicProperty = dynamicProperty->_next) {
> > +if (STREQ(dynamicProperty->name, "guest.net")) {
> > +if
Commit 423576679a5 implementing TLS forgot to remove the comment.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index a402730d38..2f1a612803 100644
--- a/src/qemu/qemu_backup.c
+++
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 69
1 file changed, 69 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
We've put the aliases into the backup job definition after the status
XML was already writted so they didn't appear in the on-disk state.
Move the code putting them into the private definition earlier, so that
the status XML update done by saving blockjobs already writes them out.
Also add a
Please see 3/3 for explanation.
Peter Krempa (3):
qemustatusxml2xml: backup-pull: Test private data formatting/parsing
qemu: backup: Remove note that TLS should be implemented
qemu: backup: Write TLS cert and secret object aliases into status XML
src/qemu/qemu_backup.c
Modify the test case to enable TLS and add private data containing
aliases of objects corresponding to a TLS setup.
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/backup-pull-in.xml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
On Monday, 14 September 2020 17:16:50 CEST Michal Privoznik wrote:
> On 9/14/20 11:10 AM, Pino Toscano wrote:
> > Implement the .connectListAllNetworks networks API in the esx network
> > driver.
> >
> > Signed-off-by: Pino Toscano
> > ---
> > src/esx/esx_network_driver.c | 64
This patch is just revert of [1]. Actually we should NOT pass
QEMU_ASYNC_JOB_NONE as that patch suggests while we are in async job in order
to acquire nested jobs correctly. The patch tries to fix issues introduced by
another patch [2] where jobs are mistakenly cleared out in qemuProcessStop.
Signed-off-by: Ján Tomko
---
tools/virsh-completer-checkpoint.c | 3 +--
tools/virsh-completer-domain.c | 40 ++
tools/virsh-completer-host.c | 6 ++---
tools/virsh-completer-interface.c | 4 +--
tools/virsh-completer-network.c| 13 +++---
All of them are in the cleanup section right before the variables
they free go out of scope.
Signed-off-by: Ján Tomko
---
tools/virsh-completer-checkpoint.c | 8
tools/virsh-completer-domain.c | 4 ++--
tools/virsh-completer-interface.c | 2 +-
tools/virsh-completer-network.c
Signed-off-by: Ján Tomko
---
tools/virsh-completer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index 1d9d212f8a..bb6550ee63 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -105,7 +105,7 @@
Ján Tomko (3):
virsh-completer: use g_clear_pointer in virshCommaStringListComplete
virsh-completer: use g_free instead of VIR_FREE
virsh-completer: use g_new0 instead of VIR_ALLOC_N
tools/virsh-completer-checkpoint.c | 11
tools/virsh-completer-domain.c | 44
On 8/18/20 12:26 PM, Nikolay Shirokovskiy wrote:
Nikolay Shirokovskiy (2):
qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish
qemu: don't needlessly unset close callback during perform phase
src/qemu/qemu_migration.c | 14 +++---
1 file changed, 3 insertions(+), 11
On 9/14/20 11:15 AM, Pino Toscano wrote:
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 ++
src/esx/esx_driver.c | 166
On a Monday in 2020, Tim Wiederhake wrote:
V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00633.html
Tim Wiederhake (7):
tests: Fix false positive in testConfRoundTrip.
util: Use glib memory functions in virErrorCopyNew
util: Use glib memory functions in virLastErrorObject
On a Monday in 2020, Tim Wiederhake wrote:
testConfRoundTrip would return 0 (success) if virConfWriteMem returned 0
(nothing
written) and virTestCompareToFile failed.
s/returned 0/succeeded/
The caller treats all non-negative values as a success. (as is usual in
the codebase)
Jano
On 9/14/20 11:10 AM, Pino Toscano wrote:
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 64
1 file changed, 64 insertions(+)
diff --git
On 9/14/20 1:49 PM, Ján Tomko wrote:
The first two patches have no functional impact on current code.
Ján Tomko (3):
qemu: rename qemuDomainObjFreeJob -> qemuDomainObjClearJob
qemu: qemuDomainObjClearJob: use g_clear_pointer
qemuProcessReconnect: clear 'oldjob'
On Mon, 14 Sep 2020 03:46:14 -0400
Igor Mammedov wrote:
> theses were deprecated since 4.0, remove both HMP and QMP variants.
s/theses/These/
>
> Users should use device_add command instead. To get list of
> possible CPUs and options, use 'info hotpluggable-cpus' HMP
> or
On Mon, 14 Sep 2020 13:48:43 +
"Zeng, Xin" wrote:
> On Saturday, September 12, 2020 12:52 AM
> Alex Williamson wrote:
> > To: Zhao, Yan Y
> > Cc: Sean Mooney ; Cornelia Huck
> > ; Daniel P.Berrangé ;
> > k...@vger.kernel.org; libvir-list@redhat.com; Jason Wang
> > ; qemu-de...@nongnu.org;
On Mon, 14 Sep 2020 at 15:22, Daniel P. Berrangé wrote:
> So we're changing
>
> The feature will remain functional for 2 releases prior to actual removal.
>
> to
>
> The feature will remain functional for 1 more release after deprecation.
>
> How about
>
> The feature will remain functional
On 9/14/20 9:21 AM, Daniel P. Berrangé wrote:
On Tue, Aug 11, 2020 at 11:47:36AM +0100, Stefan Hajnoczi wrote:
The sentence explaining the deprecation schedule is ambiguous. Make it
clear that a feature deprecated in the Nth release is guaranteed to
remain available in the N+1th release.
On Tue, Aug 11, 2020 at 11:47:36AM +0100, Stefan Hajnoczi wrote:
> The sentence explaining the deprecation schedule is ambiguous. Make it
> clear that a feature deprecated in the Nth release is guaranteed to
> remain available in the N+1th release. Removal can occur in the N+2nd
> release or
On Tue, Aug 11, 2020 at 11:47:36AM +0100, Stefan Hajnoczi wrote:
> The sentence explaining the deprecation schedule is ambiguous. Make it
> clear that a feature deprecated in the Nth release is guaranteed to
> remain available in the N+1th release. Removal can occur in the N+2nd
> release or
On Mon, Sep 14, 2020 at 03:48:31PM +0200, Erik Skultety wrote:
> On Mon, Sep 14, 2020 at 04:41:59PM +0300, Eli Cohen wrote:
> > On Mon, Sep 14, 2020 at 02:34:51PM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Sep 14, 2020 at 03:30:15PM +0200, Erik Skultety wrote:
> > > > On Mon, Sep 14, 2020 at
On 9/11/20 9:13 AM, Lin Ma wrote:
Lin Ma (17):
virshDomainNameCompleter: Add some of VIR_CONNECT_LIST_DOMAINS_ flags
virsh: snapshot: Only return domains that have snapshot images
virsh: managedsave-*: Only return domains that have a managed save
image
virsh: checkpoint: Only
On 9/11/20 9:13 AM, Lin Ma wrote:
Signed-off-by: Lin Ma
---
tools/virsh-completer-network.c | 42 +
tools/virsh-completer-network.h | 4
tools/virsh-network.c | 2 ++
3 files changed, 48 insertions(+)
diff --git
On 9/11/20 9:13 AM, Lin Ma wrote:
Signed-off-by: Lin Ma
---
tools/virsh-completer-domain.c | 49 ++
tools/virsh-completer-domain.h | 8 ++
tools/virsh-domain.c | 2 ++
3 files changed, 59 insertions(+)
diff --git
On Saturday, September 12, 2020 12:52 AM
Alex Williamson wrote:
> To: Zhao, Yan Y
> Cc: Sean Mooney ; Cornelia Huck
> ; Daniel P.Berrangé ;
> k...@vger.kernel.org; libvir-list@redhat.com; Jason Wang
> ; qemu-de...@nongnu.org;
> kwankh...@nvidia.com; eau...@redhat.com; Wang, Xin-ran
On a Friday in 2020, Peter Krempa wrote:
Test that we can cope with a long useralias when generating SCSI hostdev
commandline.
Signed-off-by: Peter Krempa
---
.../hostdev-scsi-virtio-scsi.x86_64-2.8.0.args| 8 +---
.../hostdev-scsi-virtio-scsi.x86_64-4.1.0.args| 8
On a Friday in 2020, Peter Krempa wrote:
The secret object is used to pass data to the backend so it's better
fitting to base the secret object name on the SCSI host device backend
name.
Since we store the object alias in the status XML this modification is
safe in regards to existing guests.
On a Friday in 2020, Peter Krempa wrote:
QEMU's blockdev nodenames which are used to back SCSI/iSCSI hostdevs are
limited to 32 characters. If a user passes a very long user alias as
name of the host device it's easy to end up with a too-long nodename.
To prevent this from happening don't base
On Mon, Sep 14, 2020 at 04:41:59PM +0300, Eli Cohen wrote:
> On Mon, Sep 14, 2020 at 02:34:51PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 14, 2020 at 03:30:15PM +0200, Erik Skultety wrote:
> > > On Mon, Sep 14, 2020 at 04:24:20PM +0300, Eli Cohen wrote:
> > > > On Mon, Sep 14, 2020 at
On a Friday in 2020, Peter Krempa wrote:
Allocate the nodename in the setup function rather than in the command
line generator.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 7 ---
src/qemu/qemu_domain.c | 8
2 files changed, 12 insertions(+), 3 deletions(-)
On a Friday in 2020, Peter Krempa wrote:
Historically we've prepared secrets for all objects in one place. This
doesn't make much sense and it's semantically more appealing to prepare
everything for a single device type in one place.
Move the setup of the (iSCSI|SCSI) hostdev secrets into a new
On a Friday in 2020, Peter Krempa wrote:
The function is no longer used once we setup per-hostdev data.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 50 --
src/qemu/qemu_domain.h | 4
2 files changed, 54 deletions(-)
Reviewed-by: Ján
On Mon, Sep 14, 2020 at 02:34:51PM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 14, 2020 at 03:30:15PM +0200, Erik Skultety wrote:
> > On Mon, Sep 14, 2020 at 04:24:20PM +0300, Eli Cohen wrote:
> > > On Mon, Sep 14, 2020 at 02:49:20PM +0200, Erik Skultety wrote:
> > > > On Mon, Sep 14, 2020 at
On a Friday in 2020, Peter Krempa wrote:
This was a hack when we were locally regenerating the nodename so that
it's not leaked. Now that we use proper virStorageSource with
persistence it's no longer required.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 1 -
src/qemu/qemu_block.h |
On a Friday in 2020, Peter Krempa wrote:
Modify the attach/detach data generators to actually use the
virStorageSourceStructure embedded in the SCSI config data rather than
creating an ad-hoc internal one.
The modification will allow us to properly store the nodename used for
the backend in the
On Mon, Sep 14, 2020 at 03:30:15PM +0200, Erik Skultety wrote:
> On Mon, Sep 14, 2020 at 04:24:20PM +0300, Eli Cohen wrote:
> > On Mon, Sep 14, 2020 at 02:49:20PM +0200, Erik Skultety wrote:
> > > On Mon, Sep 14, 2020 at 02:44:16PM +0300, Eli Cohen wrote:
> > > > On Mon, Sep 14, 2020 at 12:14:40PM
On a Friday in 2020, Peter Krempa wrote:
For upgrade reasons so that we can modify the used nodename we must
generate the old version for all status XMLs which don't have it stored
explicitly.
The change will be required as using the user-provided alias may result
in too-long nodenames which
On Mon, Sep 14, 2020 at 04:24:20PM +0300, Eli Cohen wrote:
> On Mon, Sep 14, 2020 at 02:49:20PM +0200, Erik Skultety wrote:
> > On Mon, Sep 14, 2020 at 02:44:16PM +0300, Eli Cohen wrote:
> > > On Mon, Sep 14, 2020 at 12:14:40PM +0100, Daniel P. Berrangé wrote:
> > > > >
> > > > > $ ninja -C build
On Mon, Sep 14, 2020 at 02:49:20PM +0200, Erik Skultety wrote:
> On Mon, Sep 14, 2020 at 02:44:16PM +0300, Eli Cohen wrote:
> > On Mon, Sep 14, 2020 at 12:14:40PM +0100, Daniel P. Berrangé wrote:
> > > >
> > > > $ ninja -C build
> > > > ninja: Entering directory `build'
> > > > [1124/1210]
On Mon, Sep 14, 2020 at 02:49:20PM +0200, Erik Skultety wrote:
> On Mon, Sep 14, 2020 at 02:44:16PM +0300, Eli Cohen wrote:
> > On Mon, Sep 14, 2020 at 12:14:40PM +0100, Daniel P. Berrangé wrote:
> > > >
> > > > $ ninja -C build
> > > > ninja: Entering directory `build'
> > > > [1124/1210]
On a Friday in 2020, Peter Krempa wrote:
For upgrade reasons so that we can modify the used nodename we must
generate the old version for all status XMLs which don't have it stored
explicitly.
The change will be required as using the user-provided alias may result
in too-long nodenames which
On a Friday in 2020, Peter Krempa wrote:
Add a local SCSI host device to validate upcoming generated data.
Signed-off-by: Peter Krempa
---
tests/qemustatusxml2xmldata/upgrade-in.xml | 8
tests/qemustatusxml2xmldata/upgrade-out.xml | 8
2 files changed, 16 insertions(+)
On Mon, Sep 14, 2020 at 02:44:16PM +0300, Eli Cohen wrote:
> On Mon, Sep 14, 2020 at 12:14:40PM +0100, Daniel P. Berrangé wrote:
> > >
> > > $ ninja -C build
> > > ninja: Entering directory `build'
> > > [1124/1210] Generating virsh.html.in with a meson_exe.py custom command
> > > FAILED:
On a Monday in 2020, Ján Tomko wrote:
After we started copying the privateData pointer in
qemuDomainObjRestoreJob, we should also free them
once we're done with them.
Register the clear function and use g_auto.
Also add a check for job->cb to qemuDomainObjClearJob,
to prevent freeing an
On 9/14/20 7:34 AM, Erik Skultety wrote:
On Fri, Sep 11, 2020 at 05:34:24PM +0200, Boris Fiuczynski wrote:
On 9/8/20 6:01 PM, Erik Skultety wrote:
@@ -664,11 +695,11 @@ nodeDeviceGetMdevctlStartCommand(virNodeDeviceDefPtr def,
{
virCommandPtr cmd;
g_autofree char *json = NULL;
On 9/14/20 7:17 AM, Erik Skultety wrote:
...
}
+/* dasd disk */
+if (STRPREFIX(def->caps->data.storage.block, "/dev/dasd")) {
+def->caps->data.storage.drive_type = g_strdup("dasd");
+VIR_DEBUG("Found storage type '%s' for device "
+ "with sysfs
On 9/14/20 7:41 AM, Erik Skultety wrote:
On Fri, Sep 11, 2020 at 06:11:49PM +0200, Boris Fiuczynski wrote:
On 9/9/20 9:03 AM, Cornelia Huck wrote:
[snip]
+static int
+udevProcessCSS(struct udev_device *device,
+ virNodeDeviceDefPtr def)
+{
+/* do not process EADM and CHSC
The function used g_clear_pointer for all but one pointer.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domainjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index 9f76f1ef04..e5910a11a1 100644
---
This function does not free the job.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.c| 2 +-
src/qemu/qemu_domainjob.c | 2 +-
src/qemu/qemu_domainjob.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
The first two patches have no functional impact on current code.
Ján Tomko (3):
qemu: rename qemuDomainObjFreeJob -> qemuDomainObjClearJob
qemu: qemuDomainObjClearJob: use g_clear_pointer
qemuProcessReconnect: clear 'oldjob'
src/qemu/qemu_domain.c| 2 +-
src/qemu/qemu_domainjob.c | 7
After we started copying the privateData pointer in
qemuDomainObjRestoreJob, we should also free them
once we're done with them.
Register the clear function and use g_auto.
Also add a check for job->cb to qemuDomainObjClearJob,
to prevent freeing an uninitialized job.
On Mon, Sep 14, 2020 at 12:14:40PM +0100, Daniel P. Berrangé wrote:
> >
> > $ ninja -C build
> > ninja: Entering directory `build'
> > [1124/1210] Generating virsh.html.in with a meson_exe.py custom command
> > FAILED: docs/manpages/virsh.html.in
> > /usr/bin/meson --internal exe --capture
On Mon, Sep 14, 2020 at 02:08:55PM +0300, Eli Cohen wrote:
> On Mon, Sep 14, 2020 at 11:38:06AM +0100, Daniel P. Berrangé wrote:
>
> Thanks for your reply, it is very helpful.
>
> > On Mon, Sep 14, 2020 at 01:11:01PM +0300, Eli Cohen wrote:
> > > Hello all,
> > >
> > > I hope this is being
On Mon, Sep 14, 2020 at 11:38:06AM +0100, Daniel P. Berrangé wrote:
Thanks for your reply, it is very helpful.
> On Mon, Sep 14, 2020 at 01:11:01PM +0300, Eli Cohen wrote:
> > Hello all,
> >
> > I hope this is being posted in the right mailing list.
> >
> > I am trying to build libvirt v6.7.0
Signed-off-by: Ján Tomko
Fixes: 95089f481e003d971fe0a082018216c58c1b80e5
---
Pushed as trivial.
src/util/virnetdevtap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index ab5959c646..cbce5c71b7 100644
---
On Mon, Sep 14, 2020 at 01:11:01PM +0300, Eli Cohen wrote:
> Hello all,
>
> I hope this is being posted in the right mailing list.
>
> I am trying to build libvirt v6.7.0 on RHEL8.3 x86_64 server in order to
> later apply patches for VDPA support posted recently by Jonathon Jongsma
> .
>
> I am
Hello all,
I hope this is being posted in the right mailing list.
I am trying to build libvirt v6.7.0 on RHEL8.3 x86_64 server in order to
later apply patches for VDPA support posted recently by Jonathon Jongsma
.
I am following the instrutions in https://libvirt.org/contribute.html
and running
On Mon, 14 Sep 2020 10:07:36 +0200
Michal Privoznik wrote:
> On 9/14/20 9:46 AM, Igor Mammedov wrote:
> > theses were deprecated since 4.0, remove both HMP and QMP variants.
> >
> > Users should use device_add command instead. To get list of
> > possible CPUs and options, use 'info
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 ++
src/esx/esx_driver.c | 166 +++
2 files changed, 170
Add the definition of the GuestNicInfo object, with all the required
objects for it.
Signed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py| 1 +
src/esx/esx_vi_generator.input | 54 ++
2 files changed, 55 insertions(+)
diff --git
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 64
1 file changed, 64 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
New option -compat lets you configure what to do when deprecated
interfaces get used. This is intended for testing users of the
management interfaces. It is experimental.
-compat deprecated-input= configures what to do when
deprecated input is received. Available policies:
* accept: Accept
On Thu, Sep 10, 2020 at 03:26:03PM +0200, Pino Toscano wrote:
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino
On Thu, Sep 10, 2020 at 03:10:00PM +0200, Pino Toscano wrote:
When a list is freed, we iterate through all the items, invoking the
free function for each; the actual free function called for each element
is the function of the actual type of each element, and thus the @_next
pointer in the
On 9/14/20 9:46 AM, Igor Mammedov wrote:
theses were deprecated since 4.0, remove both HMP and QMP variants.
Users should use device_add command instead. To get list of
possible CPUs and options, use 'info hotpluggable-cpus' HMP
or query-hotpluggable-cpus QMP command.
Signed-off-by: Igor
Signed-off-by: Tim Wiederhake
---
tests/virconftest.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/tests/virconftest.c b/tests/virconftest.c
index cac3718495..8269730662 100644
--- a/tests/virconftest.c
+++ b/tests/virconftest.c
@@ -32,39 +32,30
Signed-off-by: Tim Wiederhake
---
src/util/virjson.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virjson.c b/src/util/virjson.c
index 6921eccb60..ba43d6b667 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -1243,8 +1243,7 @@
Signed-off-by: Tim Wiederhake
Reviewed-by: Ján Tomko
---
src/util/viralloc.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index fa2bc8a2bc..a50cd5d632 100644
--- a/src/util/viralloc.h
+++ b/src/util/viralloc.h
@@ -90,21 +90,6 @@
Signed-off-by: Tim Wiederhake
Reviewed-by: Ján Tomko
---
src/util/viralloc.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index 3e57d8a603..fa2bc8a2bc 100644
--- a/src/util/viralloc.h
+++ b/src/util/viralloc.h
@@ -75,20 +75,6 @@
testConfRoundTrip would return 0 (success) if virConfWriteMem returned 0
(nothing
written) and virTestCompareToFile failed.
Signed-off-by: Tim Wiederhake
---
tests/virconftest.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/virconftest.c b/tests/virconftest.c
Signed-off-by: Tim Wiederhake
---
src/util/virerror.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/util/virerror.c b/src/util/virerror.c
index d89948f198..80a7cfe0ed 100644
--- a/src/util/virerror.c
+++ b/src/util/virerror.c
@@ -235,10 +235,9 @@
Signed-off-by: Tim Wiederhake
---
src/util/virerror.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/util/virerror.c b/src/util/virerror.c
index 6b057057a3..d89948f198 100644
--- a/src/util/virerror.c
+++ b/src/util/virerror.c
@@ -223,14 +223,8 @@
V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00633.html
Tim Wiederhake (7):
tests: Fix false positive in testConfRoundTrip.
util: Use glib memory functions in virErrorCopyNew
util: Use glib memory functions in virLastErrorObject
util: Remove VIR_ALLOC_QUIET
tests:
This originally started as bug 1595525 in which namespaces and
libusb used in QEMU were not playing nicely with each other. The
problem was that libusb built a cache of USB devices it saw
(which was a very limited set because of the namespace) and then
expected to receive udev events to keep the
See 2/2 for explanation why we need this.
Also, .hostdevice uses qemu_open() under the hood which enables Libvirt
to pass FD instead of /dev/bus/usb/... path. However, qemu_open() does
not support getfd style of passing FD (which is what we use), but so
called FD sets which require some more
theses were deprecated since 4.0, remove both HMP and QMP variants.
Users should use device_add command instead. To get list of
possible CPUs and options, use 'info hotpluggable-cpus' HMP
or query-hotpluggable-cpus QMP command.
Signed-off-by: Igor Mammedov
Reviewed-by: Thomas Huth
Acked-by:
On Fri, 11 Sep 2020 11:04:47 -0400
"Michael S. Tsirkin" wrote:
> On Fri, Sep 11, 2020 at 09:32:02AM -0400, Igor Mammedov wrote:
> > it's was deprecated since 3.1
> >
> > Support for invalid topologies is removed, the user must ensure
> > that topologies described with -smp include all possible
On Sun, 2020-09-13 at 13:34 -0400, Laine Stump wrote:
> On 9/11/20 1:08 PM, Laine Stump wrote:
> > On 9/11/20 7:34 AM, Ian Wienand wrote:
> > > The original motivation for adding virNetDevIPCheckIPv6Forwarding
> > > (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that networking routes
> > > would
98 matches
Mail list logo
