On 9/17/20 1:02 PM, Andrea Bolognani wrote:
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
+ * Re-introduce NVDIMM auto-alignment for pSeries Guests
+
+This feature was removed in libvirt v6.7.0 due to its shortcomings, namely
+the lack of consistency between
On 9/17/20 7:48 AM, Andrea Bolognani wrote:
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
In [1], changes were made to remove the existing auto-alignment
for pSeries NVDIMM devices. That design promotes strange situations
where the NVDIMM size reported in the domain XML
On 9/16/20 3:09 AM, Michal Privoznik wrote:
On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote:
b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl
version (4.14) the old one seems to be broken. While libxl part should
be fixed too, update the usage here and at some point drop
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 2052fd700d..a2f7ecaf1d 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,13 @@ v6.8.0 (unreleased)
useful for containerised scenarios and can be used in both
Pavel Hrdina (2):
news: node_device: remove HAL node device backend
news: dbus: use GLib implementation instead of libdbus
NEWS.rst | 14 ++
1 file changed, 14 insertions(+)
--
2.26.2
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 14f098b1f6..2052fd700d 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -30,6 +30,13 @@ v6.8.0 (unreleased)
* **Bug fixes**
+* **Removed features**
+
+ * node_device: Remove
On Thu, Sep 17, 2020 at 4:31 AM Pavel Hrdina wrote:
>
> Pavel Hrdina (14):
> remove HAL node device driver
> tests: mock libdbus in networkxml2firewalltest
> util: introduce helpers for GLib DBus implementation
> tests/virmock: extend number of arguments
> tests: introduce virgdbusmock
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
> + * Re-introduce NVDIMM auto-alignment for pSeries Guests
> +
> +This feature was removed in libvirt v6.7.0 due to its shortcomings,
> namely
> +the lack of consistency between domain XML and actual NVDIMM size the
>
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
> @@ -16981,23 +17000,11 @@ virDomainMemoryDefParseXML(virDomainXMLOptionPtr
> xmlopt,
> +if (virDomainNVDimmAlignSizePseries(def) < 0)
> +goto error;
The outcome of this change is good, and overall it doesn't
From: Prakhar Bansal
---
src/jailhouse/jailhouse_driver.c | 70
1 file changed, 61 insertions(+), 9 deletions(-)
diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c
index 2bb249f996..8c84a23388 100644
---
From: Prakhar Bansal
---
src/jailhouse/jailhouse_api.c| 8 +++
src/jailhouse/jailhouse_driver.c | 101 +--
2 files changed, 104 insertions(+), 5 deletions(-)
diff --git a/src/jailhouse/jailhouse_api.c b/src/jailhouse/jailhouse_api.c
index
From: Prakhar Bansal
---
src/jailhouse/jailhouse_driver.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c
index 45b1f35896..70f0f365cb 100644
--- a/src/jailhouse/jailhouse_driver.c
+++
From: Prakhar Bansal
Implemented Jailhouse hypervisor APIs for cell
load/start/shutdown/destroy.
---
src/jailhouse/jailhouse_api.c| 100 --
src/jailhouse/jailhouse_api.h| 29 +
src/jailhouse/jailhouse_driver.c | 217 +--
From: Prakhar Bansal
- Added xmlopt to the Jailhouse driver
- Added ACL check in ConnectOpen
---
src/jailhouse/jailhouse_api.c| 48 +-
src/jailhouse/jailhouse_driver.c | 58
2 files changed, 61 insertions(+), 45 deletions(-)
diff
From: Prakhar Bansal
---
include/libvirt/virterror.h | 2 +-
libvirt.spec.in | 7 +
m4/virt-driver-jailhouse.m4 | 42 +
meson.build | 4 +
meson_options.txt| 1 +
src/conf/domain_conf.c
From: Prakhar Bansal
---
include/libvirt/virterror.h | 1 +
po/POTFILES.in | 2 +
src/jailhouse/Makefile.inc.am | 34 ++-
src/jailhouse/jailhouse.conf| 10 +
src/jailhouse/jailhouse_api.c | 372
From: Prakhar Bansal
---
src/jailhouse/jailhouse_driver.c | 102 +--
1 file changed, 83 insertions(+), 19 deletions(-)
diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c
index 5b7bdc92d8..2bb249f996 100644
---
From: Prakhar Bansal
---
src/jailhouse/jailhouse_driver.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c
index ac9da4c85d..75bf41fc11 100644
---
I'm sending this series on behalf of Prakhar Bansal who has been unable
to sucessfully send the whole series. GMail is blocking sending of
certain patches for unknown reasons.
https://www.redhat.com/archives/libvir-list/2020-September/msg00309.html
It is also available at
On Thu, Sep 17, 2020 at 04:30:57PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-09-17 at 15:01 +0200, Michal Privoznik wrote:
> > And also it would be nice to mention this in the news file.
>
> ... in addition to the switch to GLib's DBus client implementation,
> which removes the libdbus
On Thu, Sep 17, 2020 at 06:55:36PM +0400, Roman Bogorodskiy wrote:
> Daniel P. Berrangé wrote:
>
> > On Thu, Sep 17, 2020 at 05:48:38PM +0400, Roman Bogorodskiy wrote:
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > > > >
Daniel P. Berrangé wrote:
> On Thu, Sep 17, 2020 at 05:48:38PM +0400, Roman Bogorodskiy wrote:
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > > > Daniel P. Berrangé wrote:
> > > >
> > > > > On Sat, Aug 01, 2020 at 10:16:57AM
On Thu, 2020-09-17 at 15:01 +0200, Michal Privoznik wrote:
> And also it would be nice to mention this in the news file.
... in addition to the switch to GLib's DBus client implementation,
which removes the libdbus dependency and is thus very relevant to
packagers.
--
Andrea Bolognani / Red Hat
On Thu, Sep 17, 2020 at 05:48:38PM +0400, Roman Bogorodskiy wrote:
> Daniel P. Berrangé wrote:
>
> > On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Sat, Aug 01, 2020 at 10:16:57AM +0400, Roman Bogorodskiy wrote:
> > > > >
Daniel P. Berrangé wrote:
> On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > Daniel P. Berrangé wrote:
> >
> > > On Sat, Aug 01, 2020 at 10:16:57AM +0400, Roman Bogorodskiy wrote:
> > > > Support modeling of the 'isa' controller for bhyve. User can manually
> > > >
This patchset tries to implement transient option for qcow2 and raw
format disk.
It gets user available to set to the domain xml file like as:
Any changes which the Guest does to the disk is dropped when the Guest
is shutdowned.
There are some limitations
From: Masayoshi Mizuma
Here is the implementation of transient option for qcow2 and raw format
disk. This gets available directive in domain xml file
like as:
When the qemu command line options are built, a new qcow2 image is
created with backing qcow2 by
From: Masayoshi Mizuma
Signed-off-by: Masayoshi Mizuma
---
src/qemu/qemu_hotplug.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index e2c6e14c2e..20dcec7b65 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@
From: Masayoshi Mizuma
The transient disk is attached before the guest starts.
Remove the transient disk when the guest does shutdown.
Signed-off-by: Masayoshi Mizuma
---
src/qemu/qemu_process.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_process.c
From: Masayoshi Mizuma
Update validation of transient disk option. The option for qemu is supported
with under condistions.
- qemu has blockdev feature
- the type is file and the format is qcow2 and raw
- writable disk
Signed-off-by: Masayoshi Mizuma
---
src/qemu/qemu_validate.c | 25
From: Masayoshi Mizuma
Signed-off-by: Masayoshi Mizuma
---
src/qemu/qemu_domain.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 785cee6f18..1ce0f70971 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -10794,6
From: Masayoshi Mizuma
Block migration when transient disk option is enabled because migration
requires some blockjobs.
Signed-off-by: Masayoshi Mizuma
---
src/qemu/qemu_migration.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_migration.c
On Wed, 2020-09-16 at 14:48 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 16, 2020 at 03:33:53PM +0200, Tim Wiederhake wrote:
> > We currently ignore unknown elements in the CPU XML description,
> > e.g. with vi=
> > rsh
> > cpu-compare and hypervisor-cpu-compare. This makes ' > name=3D"...=
> >
On 9/17/20 10:29 AM, Pavel Hrdina wrote:
Pavel Hrdina (14):
remove HAL node device driver
tests: mock libdbus in networkxml2firewalltest
util: introduce helpers for GLib DBus implementation
tests/virmock: extend number of arguments
tests: introduce virgdbusmock to mock GLib DBus
On 9/17/20 10:29 AM, Pavel Hrdina wrote:
There was one attempt a year ago done by me to drop HAL [1] but it was
never resolved. There was another time when Dan suggested to drop HAL
driver [2] but it was decided to keep it around in case device
assignment will be implemented for FreeBSD and the
The storage driver was wired up to support creating raw volumes in LUKS
format, but was never adapted to support LUKS-in-qcow2. This is trivial
as it merely requires the encryption properties to be prefixed with
the "encrypt." prefix, and "encrypt.format=luks" when creating the
volume.
Crypt method number 2 indicates LUKS format.
Signed-off-by: Daniel P. Berrangé
---
src/util/virstoragefile.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 97a346db28..42341150e5 100644
---
The two removed files have exactly the same config as other LUKS volume
data files, simply with different file names. Consolidate down to just
two LUKS volume data files as that's all that we need for the test
coverage.
Signed-off-by: Daniel P. Berrangé
---
.../luks-convert-encrypt.argv
We added support for LUKS with raw volumes, but never extended it to
cover qcow2 volumes.
In v2:
- Fixed confusion of src/dst volume types
- Fixed syntax check
- Now with unit tests
Daniel P. Berrang=C3=A9 (4):
scripts: fix logic error in argv wrapping code
util: detect LUKS encryption
The first piece of the command we process must be added to the list
straight away regardless of whether it starts with a '-' or not.
Signed-off-by: Daniel P. Berrangé
---
scripts/test-wrap-argv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/test-wrap-argv.py
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
> In [1], changes were made to remove the existing auto-alignment
> for pSeries NVDIMM devices. That design promotes strange situations
> where the NVDIMM size reported in the domain XML is different
> from what QEMU is actually
On 9/17/20 5:20 AM, Lin Ma wrote:
On 2020-09-16 10:40, Michal Privoznik wrote:
On 9/16/20 9:17 AM, moreca...@gmail.com wrote:
From: Lin Ma
v1 -> v2:
* Remove the merged patches.
* Follow Ján and Erik's suggestions.
Lin Ma (4):
virsh: net-port-create: log errors for non-existent xml file
Peter, could you please review and merge this patch first?
It is actually independent from the 2/2 rejected patch.
On Wed, Sep 16, 2020 at 1:49 PM Han Han wrote:
> Signed-off-by: Han Han
> ---
> docs/formatdomain.rst | 21 +
> 1 file changed, 21 insertions(+)
>
> diff
The objects at @def and @mem pointers are only read and not
written. Make the arguments const to make that explicit.
Signed-off-by: Michal Privoznik
Reviewed-by: Ján Tomko
---
src/qemu/qemu_command.c | 4 ++--
src/qemu/qemu_command.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
So far, Libvirt configures memory-backend-* for memory hotplug,
possibly NUMA nodes and in a few other cases. This patch
switches to constructing the memory-backend-* command line for
all cases. To keep ability to migrate guests a little hack is
used: the ID of the object is set to the one that
If a domain was using hugepages through memory-backend-file or
via -mem-path, we would turn prealloc on. But we are not doing
that for memory-backend-memfd. Fix this, because we need QEMU to
fully allocate hugepages.
Signed-off-by: Michal Privoznik
Reviewed-by: Ján Tomko
---
v2 of:
https://www.redhat.com/archives/libvir-list/2020-September/msg00023.html
diff to v1:
- I've dropped the capability (patch 5/7 in the original set) and am
relying on qemu providing default-ram-id.
I've tested migration from a daemon with these patches to a daemon
without and also vice
All three memory backends (-file, -ram and -memfd) have .prealloc
attribute. Since we are setting it only for -file, the
corresponding code lives only under if() that handles that
specific backend. But in near future we will want to set the
attribute for other backends too. Therefore, move the
The machine structure has another (optional) attribute:
default-ram-id, which specifies the alias of the default RAM
object. While the alias is private, it can never change in order
to not break migration. QEMU uses the alias when allocating
regular, not NUMA memory. In order to switch to new
If user specifies immediate memory allocation in the domain XML,
they want QEMU to fully allocate its memory. And if the memory
was allocated using plain '-m' then we would honour it. But, if a
memory backend is used, then we don't set the prealloc attribute
of the backend.
Signed-off-by: Michal
On Thu, Sep 17, 2020 at 1:06 AM Daniel P. Berrangé
wrote:
> The storage driver was wired up to support creating raw volumes in LUKS
> format, but was never adapted to support LUKS-in-qcow2. This is trivial
> as it merely requires the encryption properties to be prefixed with
> the "encrypt."
On Wed, 2020-09-16 at 18:05 +0100, Daniel P. Berrangé wrote:
> The current debug message reports the "mode" after selection has
> completed, however, the "mode" value can be changed by the selection
> logic. It is thus beneficial to report most values upfront, and only
> report newly changed
With libdbus our wrappers had a special syntax to create the DBus
messages by defining the DBus message signature followed by list
of arguments providing data based on the signature.
There will be no similar helper with GLib implementation as they
provide same functionality via GVariant APIs. The
Signed-off-by: Pavel Hrdina
---
src/remote/remote_daemon.c | 73 +++---
1 file changed, 37 insertions(+), 36 deletions(-)
diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
index 2ac4f6cd2e..9eb2c2bc0d 100644
--- a/src/remote/remote_daemon.c
+++
Signed-off-by: Pavel Hrdina
---
src/nwfilter/meson.build | 1 -
src/nwfilter/nwfilter_driver.c | 127 -
2 files changed, 46 insertions(+), 82 deletions(-)
diff --git a/src/nwfilter/meson.build b/src/nwfilter/meson.build
index dcdc30f373..715282ee77 100644
Signed-off-by: Pavel Hrdina
---
libvirt.spec.in |3 -
meson.build | 27 +-
meson_options.txt |1 -
po/POTFILES.in |1 -
src/libvirt_private.syms| 17 -
src/libvirt_probes.d
Signed-off-by: Pavel Hrdina
---
src/util/virpolkit.c | 115 +-
tests/meson.build | 11 ++--
tests/virpolkittest.c | 112 +++-
3 files changed, 104 insertions(+), 134 deletions(-)
diff --git a/src/util/virpolkit.c
Rewrite to use GLib DBus instead of libdbus will introduce function with
large number of arguments that we will have to mock for our tests so we
need to extend the number of arguments for our macros.
Signed-off-by: Pavel Hrdina
---
tests/virmock.h | 10 --
1 file changed, 8
Signed-off-by: Pavel Hrdina
---
src/lxc/lxc_controller.c | 6 +++---
src/lxc/meson.build | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 37a28ac2f3..c3cf485e2c 100644
--- a/src/lxc/lxc_controller.c
+++
There was one attempt a year ago done by me to drop HAL [1] but it was
never resolved. There was another time when Dan suggested to drop HAL
driver [2] but it was decided to keep it around in case device
assignment will be implemented for FreeBSD and the fact that
virt-manager uses node device
Signed-off-by: Pavel Hrdina
---
src/network/bridge_driver.c | 81 ++---
src/network/meson.build | 2 -
2 files changed, 39 insertions(+), 44 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 87d7acab06..5d9b9eaa4f
Signed-off-by: Pavel Hrdina
---
src/rpc/meson.build| 1 -
src/rpc/virnetdaemon.c | 115 +
2 files changed, 35 insertions(+), 81 deletions(-)
diff --git a/src/rpc/meson.build b/src/rpc/meson.build
index e249b9d534..cc1424140a 100644
---
This test calls into src/util/virfirewalld.c where it uses DBus to
figure out if firewalld is registered. Without the mock it luckily
fails and the test works correctly.
To isolate the tests from host environment we should mock the DBus
calls.
Signed-off-by: Pavel Hrdina
---
tests/meson.build
Signed-off-by: Pavel Hrdina
---
src/util/virsystemd.c | 371 +
tests/meson.build | 2 +-
tests/virsystemdtest.c | 173 +++
3 files changed, 254 insertions(+), 292 deletions(-)
diff --git a/src/util/virsystemd.c
Signed-off-by: Pavel Hrdina
---
tests/meson.build| 1 +
tests/virgdbusmock.c | 85
2 files changed, 86 insertions(+)
create mode 100644 tests/virgdbusmock.c
diff --git a/tests/meson.build b/tests/meson.build
index f0f3d8c1ef..0f3e4bfdd7 100644
Signed-off-by: Pavel Hrdina
---
src/util/virfirewalld.c | 197
tests/meson.build | 4 +-
tests/networkxml2firewalltest.c | 39 ---
tests/virfirewalltest.c | 154 ++---
4 files changed, 180 insertions(+),
Pavel Hrdina (14):
remove HAL node device driver
tests: mock libdbus in networkxml2firewalltest
util: introduce helpers for GLib DBus implementation
tests/virmock: extend number of arguments
tests: introduce virgdbusmock to mock GLib DBus functions
src/util/virpolkit: convert to use
67 matches
Mail list logo
