On 9/25/20 2:30 PM, Mark Mielke wrote:
On Fri, Sep 25, 2020 at 4:35 AM Daniel P. Berrangé
mailto:berra...@redhat.com>> wrote:
If you have the tarball you can trivially generate the source RPM if
you need it because the tarball still contains the .spec file. IOW
just run
$
On Fri, Sep 25, 2020 at 4:35 AM Daniel P. Berrangé
wrote:
> If you have the tarball you can trivially generate the source RPM if
> you need it because the tarball still contains the .spec file. IOW
> just run
>
> $ rpmbuild -ts libvirt-6.7.0.tar.xz
> Wrote:
On a Thursday in 2020, Peter Krempa wrote:
This version:
- is rebased on top of current refactors
- has more strict rules in the validation
- adds tests
- fixes bug with disk-unplug
Masayoshi Mizuma (5):
qemu: Block blockjobs when transient disk option is enabled
qemu: Block disk
On a Thursday in 2020, Peter Krempa wrote:
From: Masayoshi Mizuma
Extract the validation of transient disk option. We support transient
disks in qemu under the following conditions:
- -blockdev is used
- the disk source is a local file
- the disk type is 'disk'
- the disk is not readonly
On a Thursday in 2020, Peter Krempa wrote:
To implement disks we'll need to install an overlay on top
of the original disk image which will be discarded after the VM is
turned off. This was initially implemented by qemu but libvirt never
picked up this option. With blockdev the qemu feature
On Thu, 2020-09-24 at 15:05 +0200, Peter Krempa wrote:
> NEWS: Mention qcow2 cluster size being preserved accross snapshots and iSCSI
> hostdev fixes
*across
With that typo fixed,
Reviewed-by: Andrea Bolognani
and safe for freeze.
--
Andrea Bolognani / Red Hat / Virtualization
On Fri, 2020-09-25 at 05:09 -0400, Neal Gompa wrote:
> On Fri, Sep 25, 2020 at 4:35 AM Daniel P. Berrangé
> wrote:
> > On Thu, Sep 24, 2020 at 03:39:03PM -0400, Neal Gompa wrote:
> > > I like that Source RPMs are produced, because I can trivially use them
> > > in my import->build->test
> In some cases, the QMP capabilities processes possible residue. So we need to
> clear the residual QMP caps processes during starting libvirt.
I agree with you that leaving processes behind is more serious than
leaving temporary files and thus we should try to kill such processes
when libvirtd
The pygments package is required by docutils when specifying a language
for the "code-block" directive.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml | 2 +-
ci/cirrus/build.yml | 6 --
Daniel P. Berrangé (2):
ci: introduce pygments package to install
docs: specify "sh" as the language for code-block directives
.gitlab-ci.yml| 2 +-
ci/cirrus/build.yml | 6 +-
ci/cirrus/libvirt-freebsd-11.vars |
This makes the man pages compatible with both implementations of the
rst2html5 tool.
Signed-off-by: Daniel P. Berrangé
---
docs/manpages/libvirtd.rst | 4 +-
docs/manpages/virsh.rst | 582 +--
docs/manpages/virt-admin.rst | 52 ++--
On 9/24/20 6:43 AM, Peter Krempa wrote:
---
TODO | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 TODO
diff --git a/TODO b/TODO
new file mode 100644
index 00..e69de29bb2
TODO: add my review here...
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On 9/24/20 6:43 AM, Peter Krempa wrote:
To implement disks we'll need to install an overlay on top
of the original disk image which will be discarded after the VM is
turned off. This was initially implemented by qemu but libvirt never
picked up this option. With blockdev the qemu feature became
On Thu, Sep 24, 2020 at 01:43:56PM +0200, Peter Krempa wrote:
> From: Masayoshi Mizuma
>
> Extract the validation of transient disk option. We support transient
> disks in qemu under the following conditions:
>
> - -blockdev is used
> - the disk source is a local file
> - the disk type is
On Thu, Sep 24, 2020 at 01:43:55PM +0200, Peter Krempa wrote:
> From: Masayoshi Mizuma
>
> Add overlays after the VM starts before we start executing guest code.
>
> Signed-off-by: Masayoshi Mizuma
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_process.c | 5 +
> 1 file changed, 5
On Thu, Sep 24, 2020 at 01:43:54PM +0200, Peter Krempa wrote:
> Remove the overlay if the disk was . Note that even if we'd
> forbid unplug of such a disk through the API, the disk can still be
> ejected from the guest.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_hotplug.c | 9
On Thu, Sep 24, 2020 at 01:43:50PM +0200, Peter Krempa wrote:
> To implement disks we'll need to install an overlay on top
> of the original disk image which will be discarded after the VM is
> turned off. This was initially implemented by qemu but libvirt never > picked
> up this option. With
On Thu, Sep 24, 2020 at 01:43:49PM +0200, Peter Krempa wrote:
> Later patches will implement support for disks in libvirt
> by installing an overlay on top of the configured image. This will
> require cleanup after the VM will be stopped so that the state is
> correctly discarded.
>
> Since the
On Fri, Sep 25, 2020 at 6:20 PM Andrea Bolognani
wrote:
> On Fri, 2020-09-25 at 17:46 +0800, Wei Wang wrote:
> > On Fri, Sep 25, 2020 at 5:35 PM Daniel P. Berrangé
> wrote:
> > > On Fri, Sep 25, 2020 at 05:31:09PM +0800, Wei Wang wrote:
> > > > That's strange, my rst2html5 comes from docutils:
On Fri, 2020-09-25 at 12:40 +0200, Pino Toscano wrote:
> Signed-off-by: Pino Toscano
> ---
> docs/gitdm/groups/unaffiliated | 10 ++
> 1 file changed, 10 insertions(+)
Reviewed-by: Andrea Bolognani
and safe for freeze.
--
Andrea Bolognani / Red Hat / Virtualization
Ján Tomko (7):
bhyve: use g_new0 instead of VIR_ALLOC*
esx: use g_new0 instead of VIR_ALLOC*
hyperv: use g_new0 instead of VIR_ALLOC*
interface: use g_new0 instead of VIR_ALLOC*
src: libvirt-stream: use g_new0 instead of VIR_ALLOC*
storage: scsi: invert logic in createVport
storage:
Signed-off-by: Ján Tomko
---
src/bhyve/bhyve_capabilities.c | 3 +--
src/bhyve/bhyve_domain.c| 9 +++--
src/bhyve/bhyve_driver.c| 3 +--
src/bhyve/bhyve_parse_command.c | 7 +++
4 files changed, 8 insertions(+), 14 deletions(-)
diff --git
Signed-off-by: Ján Tomko
---
src/esx/esx_driver.c| 14 +-
src/esx/esx_network_driver.c| 17 ++---
src/esx/esx_storage_backend_iscsi.c | 3 +--
src/esx/esx_storage_backend_vmfs.c | 8 +++-
src/esx/esx_stream.c| 6 ++
Signed-off-by: Ján Tomko
---
src/hyperv/hyperv_driver.c | 13 +
src/hyperv/hyperv_util.c | 3 +--
src/hyperv/hyperv_wmi.c| 13 +++--
3 files changed, 9 insertions(+), 20 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index
Signed-off-by: Ján Tomko
---
src/storage/storage_backend_disk.c | 6 ++--
src/storage/storage_backend_fs.c | 8 ++---
src/storage/storage_backend_gluster.c | 12 +++-
src/storage/storage_backend_iscsi.c| 8 ++---
src/storage/storage_backend_iscsi_direct.c |
Signed-off-by: Ján Tomko
---
src/interface/interface_backend_netcf.c | 16 ++--
src/interface/interface_backend_udev.c | 22 --
2 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/src/interface/interface_backend_netcf.c
Check whether the alloc result is negative (which is
cannot happen with current code) to reduce churn in
the following commit.
Signed-off-by: Ján Tomko
---
src/storage/storage_backend_scsi.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Ján Tomko
---
src/libvirt-stream.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/libvirt-stream.c b/src/libvirt-stream.c
index aeb7562018..873d7b1d4e 100644
--- a/src/libvirt-stream.c
+++ b/src/libvirt-stream.c
@@ -588,8 +588,7 @@
Signed-off-by: Pino Toscano
---
docs/gitdm/groups/unaffiliated | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated
index 5f867fc5e4..1ca7eee81f 100644
--- a/docs/gitdm/groups/unaffiliated
+++
On Fri, Sep 25, 2020 at 11:24:21 +0100, Daniel P. Berrangé wrote:
> We stopped supportin Ubuntu 16.04 earlier in the year, so there is no
> reason to keep the HTML4 variants of rst2html around.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> meson.build | 3 +--
> 1 file changed, 1
On a Friday in 2020, Daniel P. Berrangé wrote:
We stopped supportin Ubuntu 16.04 earlier in the year, so there is no
*supporting
reason to keep the HTML4 variants of rst2html around.
If you want to include the commit that dropped it, I had it looked up
in one terminal already:
commit
We stopped supportin Ubuntu 16.04 earlier in the year, so there is no
reason to keep the HTML4 variants of rst2html around.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index
On Fri, 2020-09-25 at 17:46 +0800, Wei Wang wrote:
> On Fri, Sep 25, 2020 at 5:35 PM Daniel P. Berrangé
> wrote:
> > On Fri, Sep 25, 2020 at 05:31:09PM +0800, Wei Wang wrote:
> > > That's strange, my rst2html5 comes from docutils:
> > > python3-docutils:
On Fri, 2020-09-25 at 10:26 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 25, 2020 at 11:23:57AM +0200, Andrea Bolognani wrote:
> > On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> > > There is a completely different rst2html5 that people might get
> > > from "pip" if you did "pip
On Fri, Sep 25, 2020 at 5:35 PM Daniel P. Berrangé
wrote:
> On Fri, Sep 25, 2020 at 05:31:09PM +0800, Wei Wang wrote:
> > On Fri, Sep 25, 2020 at 5:24 PM Andrea Bolognani
> > wrote:
> >
> > > On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> > > > On Fri, Sep 25, 2020 at 05:03:24PM
On a Friday in 2020, Daniel P. Berrangé wrote:
On Fri, Sep 25, 2020 at 11:23:57AM +0200, Andrea Bolognani wrote:
On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> > /usr/local/bin/rst2html5 --stylesheet= --strict
On Fri, Sep 25, 2020 at 05:31:09PM +0800, Wei Wang wrote:
> On Fri, Sep 25, 2020 at 5:24 PM Andrea Bolognani
> wrote:
>
> > On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> > > On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> > > > /usr/local/bin/rst2html5 --stylesheet=
On Fri, Sep 25, 2020 at 5:24 PM Andrea Bolognani
wrote:
> On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> > > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst
> > > docs/manpages/virsh.rst:41:
On Fri, Sep 25, 2020 at 5:20 AM Daniel P. Berrangé wrote:
>
> The libutil.h we are after is explicitly only something we want on
> FreeBSD, we don't want to accidentally pick up this header on other
> platforms as it can lead to build failures.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Fri, Sep 25, 2020 at 11:23:57AM +0200, Andrea Bolognani wrote:
> On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> > > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst
> > >
On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst
> > docs/manpages/virsh.rst:41: (ERROR/3) Error in "code-block" directive:
> > 1 argument(s)
On a Friday in 2020, Daniel P. Berrangé wrote:
The libutil.h we are after is explicitly only something we want on
FreeBSD, we don't want to accidentally pick up this header on other
platforms as it can lead to build failures.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 5 -
1 file
The libutil.h we are after is explicitly only something we want on
FreeBSD, we don't want to accidentally pick up this header on other
platforms as it can lead to build failures.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
On Fri, Sep 25, 2020 at 10:40:34AM +0200, Andrea Bolognani wrote:
> On Fri, 2020-09-25 at 16:21 +0800, Wei Wang wrote:
> > On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani
> > wrote:
> > > On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote:
> > > > In file included from ../src/util/virfile.c:42:
On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:
> On Fri, Sep 25, 2020 at 4:54 PM Daniel P. Berrangé
> wrote:
>
> >
> > > Yes, I tried, but it fails with
> > > ../src/util/virfile.c:42:11: fatal error: libutil.h: No such file or
> > > directory
> >
> > You'd have to delete the build
On Fri, Sep 25, 2020 at 4:35 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 24, 2020 at 03:39:03PM -0400, Neal Gompa wrote:
> > On Thu, Sep 24, 2020 at 3:00 PM Jiri Denemark wrote:
> > >
> > > On Thu, Sep 24, 2020 at 18:38:18 +0200, Andrea Bolognani wrote:
> > > > On Thu, 2020-09-24 at 15:13
On Fri, Sep 25, 2020 at 4:54 PM Daniel P. Berrangé
wrote:
>
> > Yes, I tried, but it fails with
> > ../src/util/virfile.c:42:11: fatal error: libutil.h: No such file or
> > directory
>
> You'd have to delete the build dir and re-run meson so that it
> auto-detects again.
>
>
OK, that issue seems
On Fri, Sep 25, 2020 at 04:44:24PM +0800, Wei Wang wrote:
> On Fri, Sep 25, 2020 at 4:40 PM Andrea Bolognani
> wrote:
>
> > On Fri, 2020-09-25 at 16:21 +0800, Wei Wang wrote:
> > > On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani
> > wrote:
> > > > On Fri, 2020-09-25 at 10:33 +0800, Wei Wang
On Fri, Sep 25, 2020 at 4:40 PM Andrea Bolognani
wrote:
> On Fri, 2020-09-25 at 16:21 +0800, Wei Wang wrote:
> > On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani
> wrote:
> > > On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote:
> > > > In file included from ../src/util/virfile.c:42:
> > > >
On Thu, Sep 24, 2020 at 06:43:56PM -0400, Matt Coleman wrote:
> >> For example, the Windows Server 2016 Hyper-V version is 10.0.14393.0,
> >> so its “micro” is over 14 times larger than the encoding allows.
> >>
> >> My current workaround is to truncate it to something that works (E.G.
> >>
On Fri, 2020-09-25 at 16:21 +0800, Wei Wang wrote:
> On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani wrote:
> > On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote:
> > > In file included from ../src/util/virfile.c:42:
> > > /usr/include/libutil.h:43:10: fatal error: sys/_types.h: No such file or
On Thu, Sep 24, 2020 at 03:39:03PM -0400, Neal Gompa wrote:
> On Thu, Sep 24, 2020 at 3:00 PM Jiri Denemark wrote:
> >
> > On Thu, Sep 24, 2020 at 18:38:18 +0200, Andrea Bolognani wrote:
> > > On Thu, 2020-09-24 at 15:13 +0200, Jiri Denemark wrote:
> > > > I have just tagged v6.8.0-rc1 in the
On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani
wrote:
> On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote:
> > In file included from ../src/util/virfile.c:42:
> > /usr/include/libutil.h:43:10: fatal error: sys/_types.h: No such file or
> directory
> >43 | #include
> > |
On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote:
> In file included from ../src/util/virfile.c:42:
> /usr/include/libutil.h:43:10: fatal error: sys/_types.h: No such file or
> directory
>43 | #include
> | ^~
> compilation terminated.
> [51/908] Compiling C object
54 matches
Mail list logo