On Thursday, 1 October 2020 23:47:16 CEST mcole...@datto.com wrote:
> From: Matt Coleman
>
> Hyper-V version numbers are not compatible with the encoding in
> virParseVersionString():
> https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246
>
> For example, the Windows Server 2
On Thursday, 1 October 2020 23:47:13 CEST mcole...@datto.com wrote:
> diff --git a/src/hyperv/hyperv_wmi.h b/src/hyperv/hyperv_wmi.h
> index 74a74e0e09..c493a45691 100644
> --- a/src/hyperv/hyperv_wmi.h
> +++ b/src/hyperv/hyperv_wmi.h
> @@ -37,9 +37,6 @@
> #define MSVM_VIRTUALSYSTEMMANAGEMENTSERVI
On Thursday, 1 October 2020 23:47:12 CEST mcole...@datto.com wrote:
> +static int
> +hypervGetProcessorsByName(hypervPrivate *priv, const char *name,
> + Win32_Processor **processorList)
> +{
> +g_auto(virBuffer) query = VIR_BUFFER_INITIALIZER;
> +virBufferEscapeSQL
On Thursday, 1 October 2020 23:47:09 CEST mcole...@datto.com wrote:
> From: Matt Coleman
>
> These patches fix a couple bugs, consolidate duplicate code, and
> implement several APIs.
Nice!
One general note for all the patches: NEWS.rst is updated as a whole
at the end, as separate commit. Thi
Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and
commit 7556ab139fd2e503ac26ee232ab273f1ec027c21.
Signed-off-by: Pino Toscano
---
meson.build | 10 --
1 file changed, 10 deletions(-)
diff --git a/meson.build b/meson.build
index 257e4452a1..a5ce8e17a8 100644
--- a/meson.bu
> Are you sure your email configuration is set properly? It seems like
> there's a mismatch on your email addresses. I generally expect your
> authorship to be set to "Matt Coleman ", but it
> seems like your latest email patch set is confused and sending emails
> as "" with a From line in the body
On 10/1/20 5:08 PM, Jonathon Jongsma wrote:
On Tue, 29 Sep 2020 15:53:39 -0400
Laine Stump wrote:
+
+if (vdpafdset < 0) {
+VIR_WARN("Cannot determine fdset for vdpa device");
+} else {
+if (qemuMonitorRemoveFdset(priv->mon, vdpafdset) < 0) {
+
From: Matt Coleman
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
NEWS.rst| 5 +++
src/hyperv/hyperv_driver.c | 90 +
src/hyperv/hyperv_private.h | 2 +
3 files changed, 97 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
From: Matt Coleman
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
NEWS.rst | 6 +++---
src/hyperv/hyperv_driver.c | 34 ++
2 files changed, 37 insertions(+), 3 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 65fa616a03..c52
From: Matt Coleman
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
NEWS.rst | 5 +++--
src/hyperv/hyperv_driver.c | 40 ++
2 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 05e129d9cf..
From: Matt Coleman
These patches fix a couple bugs, consolidate duplicate code, and
implement several APIs.
Currently, some interactions with Hyper-V systems fail when the system
is not configured for the "en-US" locale. Additionally, some CPU names
also contain the clock frequency, making it
From: Matt Coleman
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 39 +++--
src/hyperv/hyperv_wmi.c| 87 --
src/hyperv/hyperv_wmi.h| 34 +++
3 files changed, 41 insertions(+), 119 deletions(-)
diff --git a/src/hy
From: Matt Coleman
Hyper-V version numbers are not compatible with the encoding in
virParseVersionString():
https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246
For example, the Windows Server 2016 Hyper-V version is 10.0.14393: its
micro is over 14 times larger than the enco
From: Matt Coleman
Some CPU model names were too long for _virNodeInfo.model.
For example: Intel Xeon CPU E5-2620 v2 @ 2.10GHz
This commit removes the clock frequency suffix.
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/
From: Matt Coleman
There are two specific WQL queries we're using to get either a list of
virtual machines or the hypervisor host itself from Msvm_ComputerSystem.
Those queries rely on filtering results based on the "Description"
field. Since the "Description" field is locale sensitive, the queri
From: Matt Coleman
This eliminates some duplicate code and simplifies the driver functions.
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 426 -
1 file changed, 228 insertions(+), 198 deletions(-)
diff --git a/s
On Thu, Oct 1, 2020 at 5:51 PM wrote:
>
> From: Matt Coleman
>
> These patches fix a couple bugs, consolidate duplicate code, and
> implement several APIs.
>
> Currently, some interactions with Hyper-V systems fail when the system
> is not configured for the "en-US" locale. Additionally, some CPU
On Tue, 29 Sep 2020 15:53:39 -0400
Laine Stump wrote:
> > +
> > +if (vdpafdset < 0) {
> > +VIR_WARN("Cannot determine fdset for vdpa device");
> > +} else {
> > +if (qemuMonitorRemoveFdset(priv->mon, vdpafdset) < 0) {
> > +/* if it fails, th
On 01.10.2020 17:38, Michal Prívozník wrote:
> On 9/24/20 3:24 PM, Nikolay Shirokovskiy wrote:
>> On EOF condition we always have POLLHUP event and read returns
>> 0 thus we never break loop in virLogHandlerDomainLogFileDrain.
>>
>> Signed-off-by: Nikolay Shirokovskiy
>> ---
>> src/logging/lo
I'm seeing failures building libvirt 6.8.0 rpm on fedora 32, 33, and
rawhide. virsystemdtest is segfaulting on ppc64.
https://kojipkgs.fedoraproject.org//work/tasks/5494/52595494/build.log
The output from the failed tests:
74/160 libvirt / virsystemdtest FAIL 0.44s
(ki
On 10/1/20 4:06 AM, Michal Prívozník wrote:
On 10/1/20 1:14 AM, Laine Stump wrote:
Lack of this one function (which is called for each active tap device
every time libvirtd is started) is the one thing preventing a
"WITHOUT_LIBNL" build of libvirt from being useful. With this
alternate implement
On 10/1/20 11:04 AM, Pavel Hrdina wrote:
We should also remove the 'virtualport' option from meson_options.txt .
Ah, okay. I hadn't been aware of that file. Fortunately my final sanity
builds were delayed while dealing with the daily "school issues", so I
haven't pushed yet :-)
On 10/1/20 5:27 PM, Ján Tomko wrote:
Assume nobody runs current libvirt on kernels such as 2.6.26.
Kernel commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 (released
in 3.8) mentions the new path and I believe it was added by:
commit 948af1f0bbc8526448e8cbe3f8d3bf211bdf5181
firmware: Basic dm
Assume nobody runs current libvirt on kernels such as 2.6.26.
Kernel commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 (released
in 3.8) mentions the new path and I believe it was added by:
commit 948af1f0bbc8526448e8cbe3f8d3bf211bdf5181
firmware: Basic dmi-sysfs support
(released in 2.6.39), bu
On Wed, Sep 30, 2020 at 07:14:41PM -0400, Laine Stump wrote:
> This flag was originally created to indicate that either 1) the build
> platform wasn't linux, 2) the build platform was linux, but the kernel
> was too old to have macvtap support; since there was already a switch
> there, the ability
On Wed, Sep 30, 2020 at 07:14:38PM -0400, Laine Stump wrote:
> WITH_VIRTUALPORT just checks that we are building on Linux and that
> IFLA_PORT_MAX is defined in linux/if_link.h. Back when 802.11Qb[gh]
> support was added, the IFLA_* stuff was new (introduced in kernel
> 2.6.35, backported to RHEL6
On Thu, 2020-09-24 at 14:28 +0200, Ján Tomko wrote:
> +Memory allocation
> + ``VIR_ALLOC``, ``VIR_REALLOC``, ``VIR_RESIZE_N``,
> + ``VIR_EXPAND_N``, ``VIR_SHRINK_N``, ``VIR_FREE``
> +
> Prefer the GLib APIs ``g_new0``/``g_renew``/ ``g_free`` in most
> - cases. There should rarely be a nee
On Thu, 2020-09-24 at 14:28 +0200, Ján Tomko wrote:
> Ján Tomko (6):
> Revert "docs: Drop glib-adoption.rst"
> docs: build glib-adoption.html
> docs: glib-adoption: remove stuff we alredy removed
> docs: glib-adoption: split into sections
> docs: glib-adoption: add links to GLib documenta
On 9/24/20 3:24 PM, Nikolay Shirokovskiy wrote:
On EOF condition we always have POLLHUP event and read returns
0 thus we never break loop in virLogHandlerDomainLogFileDrain.
Signed-off-by: Nikolay Shirokovskiy
---
src/logging/log_handler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
When VIR_EXEC_DAEMON is true and cmd->pidfile exists, the parent
will expect the pidfile to be written before exiting, sitting
tight in a saferead() call waiting.
The child then does process tuning (via virProcessSet* functions)
before writing the pidfile. Problem is that these tunings can
fail, a
On a Wednesday in 2020, Laine Stump wrote:
This flag was originally created to indicate that either 1) the build
platform wasn't linux, 2) the build platform was linux, but the kernel
was too old to have macvtap support; since there was already a switch
there, the ability to also disable it in ca
On 9/29/20 8:01 PM, Ján Tomko wrote:
Ján Tomko (2):
libxl: prefer g_new0 to VIR_ALLOC
locking: prefer g_new0 to VIR_ALLOC
src/libxl/libxl_capabilities.c| 13 ++--
src/libxl/libxl_conf.c| 48
src/libxl/libxl_domain.c | 19 ++---
src/libxl/libxl_
On 9/30/20 4:10 PM, Ján Tomko wrote:
Take the easy way out and use typeof, because my life
is too short to spend it reading gendispatch.pl.
Signed-off-by: Ján Tomko
---
src/rpc/gendispatch.pl | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
Fair enough. We are not sto
On 9/30/20 4:10 PM, Ján Tomko wrote:
In this episode, src/logging and src/rpc get converted.
Ján Tomko (3):
logging: use g_new0 instead of VIR_ALLOC
gendispatch: use g_new0 instead of VIR_ALLOC
rpc: use g_new0 instead of VIR_ALLOC
src/logging/log_daemon.c| 9 +++--
src/
Introduce new 'fmode' and 'dmode' options for filesystem.
These options, when used with accessmode=mapped, set the creation mode
for newly created files and directories (fmode and dmode, respectively)
on the host. When not specified, QEMU defaults to 600 for files and 700
for dire
This patch exposes QEMU's 9pfs's 'fmode' and 'dmode flags options. I
followed Ján Tomko's advice from his reply to my email to the mailing
list yesterday and heavily based this on the patches that added
'multidev' support.
The only part I am unsure of is whether modifying all of the 'caps'
files w
On 9/24/20 2:20 PM, Daniel P. Berrangé wrote:
The former has been present since
commit f43798c27684ab925adde7d8acc34c78c6e50df8
Author: Rusty Russell
Date: Thu Jul 3 03:48:02 2008 -0700
tun: Allow GSO using virtio_net_hdr
and the latter since
commit bbb009941efaece3898910a
On 10/1/20 4:06 AM, Michal Prívozník wrote:
On 10/1/20 1:14 AM, Laine Stump wrote:
IFLA_VF_MAX was introduced to the Linux kernel in 2.6.35, and was even
backported to the RHEL*6* 2.6.32 kernel downstream, so it is present
in all supported versions of all Linux distros that libvirt builds
on. Ad
On Thu, 2020-10-01 at 10:50 +0200, Peter Krempa wrote:
> + * qemu: Implement support for disks
> +
> +VM's based on the QEMU hypervisor now can use option for
> +local file-backed disks to configure a disk which discards changes to the
> +disk which happened while it was acti
On Thu, 2020-10-01 at 08:43 +0200, Michal Privoznik wrote:
> I've found two files under qemuxml2xmloutdata/ that are the same
> as in qemuxml2argvdata/. Replace them with symlinks.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/qemuxml2xmloutdata/downscript.xml | 61 +--
Thank you for your contribution, however, we have switched to using
merge requests for all except the primary libvirt.git.
Could you open a merge request at
https://gitlab.com/libvirt/libvirt-rust/
this will ensure the change gets put through the CI system too.
On Thu, Oct 01, 2020 at 02:11:41P
---
src/storage_pool.rs | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/storage_pool.rs b/src/storage_pool.rs
index 96258f0..ad0a51a 100644
--- a/src/storage_pool.rs
+++ b/src/storage_pool.rs
@@ -18,7 +18,7 @@
extern crate libc;
-use std::str;
+
On 9/23/20 8:21 PM, Ján Tomko wrote:
Ján Tomko (6):
conf: split out virDomainDefParseIDs
conf: split out virDomainDefParseMemory
conf: introduce virDomainDefTunablesParse
conf: introduce virDomainDefLifecycleParse
conf: introduce virDomainDefClockParse
conf: introduce virDomainD
Signed-off-by: Markus Schade
---
tests/cputest.c | 2 +-
.../x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml | 9 +
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/tests/cputest.c b/tests/cputest.c
index 53674f2b9a..442d91cc4c 1
Signed-off-by: Markus Schade
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/x86_EPYC-Rome.xml | 81 +++
3 files changed, 83 insertions(+)
create mode 100644 src/cpu_map/x86_EPYC-Rome.xml
diff --git a/src/cpu_map/index.
this patch series adds testdata from an AMD EPYC 7502 system,
defines and enables the qemu EPYC-Rome model and changes
the existing Ryzen 9 host definition to the new model
Markus Schade (4):
Add testdata for AMD EPYC 7502
cpu_map: Defined and enable EPYC-Rome model
Update generated testdata
Signed-off-by: Markus Schade
---
.../cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 9 +
.../cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml | 9 +
.../cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml | 9 +
3 files changed, 3 insertions(+), 24 deletions(-
Signed-off-by: Markus Schade
---
tests/cputest.c |1 +
...86_64-cpuid-EPYC-7502-32-Core-disabled.xml |9 +
...x86_64-cpuid-EPYC-7502-32-Core-enabled.xml | 11 +
.../x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 42 +
.../x86_64-cpuid-EPYC-7502-32-Core-host.
On 9/29/20 5:59 PM, Ján Tomko wrote:
On a Monday in 2020, Michal Privoznik wrote:
This originally started as bug 1595525 in which namespaces and
libusb used in QEMU were not playing nicely with each other. The
problem was that libusb built a cache of USB devices it saw
(which was a very limited
Signed-off-by: Peter Krempa
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 7663cf4208..56ccfefe4a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,12 @@ v6.9.0 (unreleased)
* **New features**
+ * qemu: Implement support for disks
+
+
On 10/1/20 1:14 AM, Laine Stump wrote:
These patches eliminate a few build flags that were necessary back 10
years ago when their associated features had been newly added to the
kernel, but are now pointless (because all supported Linuxes have the
feature) (1-6), makes it possible to to a success
On 10/1/20 1:14 AM, Laine Stump wrote:
IFLA_VF_MAX was introduced to the Linux kernel in 2.6.35, and was even
backported to the RHEL*6* 2.6.32 kernel downstream, so it is present
in all supported versions of all Linux distros that libvirt builds
on. Additionally, it can't be conditionally compile
On 10/1/20 1:14 AM, Laine Stump wrote:
Lack of this one function (which is called for each active tap device
every time libvirtd is started) is the one thing preventing a
"WITHOUT_LIBNL" build of libvirt from being useful. With this
alternate implementation, guests using standard tap devices will
The 6.8.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any other
On 10/1/20 1:08 AM, Laine Stump wrote:
While looking for something else, I noticed that there were only 2
callers to virDomainNetDefClear(), and one of those was virDomain
NetDefFree(). virDomainNetDefClear() necessarily has a lot of
VIR_FREE() in it that couldn't be changed to g_free() (because
55 matches
Mail list logo
