Hi All,
I'm not sure if the following problem is in systemd or libvirt. When restarting
services and sockets *and* libvirt-guests.service is running, the latter will
sometimes hang when trying to connect to libvirtd. Even though libvirt-guests
has 'Wants=libvirtd.service' and
On Wed, 2020-10-28 at 16:55 -0400, Neal Gompa wrote:
> On Tue, Oct 27, 2020 at 9:30 AM Andrea Bolognani wrote:
> > On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote:
[...]
> > > Note that in this case I've removed
> > >
> > > # fuse is used to provide virtualized /proc for LXC
> > >
On Tue, Oct 27, 2020 at 9:30 AM Andrea Bolognani wrote:
>
> On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote:
> > I'm not convinced reverting this was the right call.
> >
> > The way RPM conditional macros work is that, if you have
> >
> > %{!?macro:value}
> >
> > that will expand to
On Mon, 2020-10-26 at 00:54 +0300, Roman Bolshakov wrote:
> One of the cases fails on macOS:
>
> 15) Storage Pool XML-2-argv pool-netfs-gluster
> ...
> In
>
> '/Users/roolebo/dev/libvirt/tests/storagepoolxml2argvdata/pool-netfs-gluster-darwin.argv':
> Offset 39
> Expect [-o
On Wed, Oct 28, 2020 at 8:36 AM Daniel P. Berrangé wrote:
>
> The %meson macro sets "--auto-features=enabled", thus any feature in the
> RPM which has a "with_XXX" condition, needs to explicitly pass a
> "-DXXX=state" arg to %meson to override the auto features setting.
>
> The
On Wed, Oct 28, 2020 at 7:49 AM Michal Privoznik wrote:
>
> On 10/27/20 1:06 PM, Neal Gompa wrote:
> > On Tue, Oct 27, 2020 at 6:24 AM Michal Privoznik
> > wrote:
> >>
> >> On 10/26/20 11:08 PM, Neal Gompa wrote:
> >>> Contemporary versions of Fedora automatically set SOURCE_DATE_EPOCH
> >>>
On Sun, 2020-10-25 at 17:26 +0300, Roman Bolshakov wrote:
> @@ -1123,6 +1123,8 @@ opendir(const char *path)
> int
> close(int fd)
> {
> +init_syms();
This hunk is completely independent of the other one. Can you please
split this into two separate patches?
Both changes look good, they
On 10/28/20 8:16 PM, Andrea Bolognani wrote:
On Mon, 2020-10-26 at 00:25 +0300, Roman Bolshakov wrote:
There're no guidelines on what namespace should be used but it seems
thirdparty apps can select the one they like [1], i.e. freedekstop
xattrs are prefixed with xdg.
qemusecuritytest passes
On Mon, 2020-10-26 at 00:25 +0300, Roman Bolshakov wrote:
> There're no guidelines on what namespace should be used but it seems
> thirdparty apps can select the one they like [1], i.e. freedekstop
> xattrs are prefixed with xdg.
>
> qemusecuritytest passes after that.
>
> 1.
On 10/28/20 7:39 AM, Daniel Henrique Barboza wrote:
Hey,
On 10/27/20 10:35 PM, Laine Stump wrote:
I don't even remember why I started looking at this. I think that
again I was considering changing some function, and making the DIR* in
that function autoclose was a prerequisite for a reasonably
On a Tuesday in 2020, Laine Stump wrote:
Commit 53aec799fa31 introduced the function udevGetVDPACharDev(),
which scans a directory using virDirOpenIfExists() and
virDirRead(). It unfortunately forgets to close the DIR* when it is
finished with it. This patch fixes that omission.
Signed-off-by:
On Wed, Oct 28, 2020 at 12:30:37PM +, Daniel P. Berrangé wrote:
> The %meson macro sets "--auto-features=enabled", thus any feature in the
> RPM which has a "with_XXX" condition, needs to explicitly pass a
> "-DXXX=state" arg to %meson to override the auto features setting.
>
> The
On Wed, Oct 28, 2020 at 02:59:35PM +0100, Tim Wiederhake wrote:
> From: Orion Poplawski
>
> Setting SYNC_TIME=1 does not work on autostarted guests.
>
> See https://bugzilla.redhat.com/show_bug.cgi?id=1555398.
>
> Signed-off-by: Tim Wiederhake
> ---
> tools/libvirt-guests.sh.in | 6 +++---
>
On Wed, Oct 28, 2020 at 12:30:35PM +, Daniel P. Berrangé wrote:
> RHEL builds disable libssh2, and build root lack libssh2-devel. The RPM
> build fails though because meson looks for libssh2 and has it set to
> "enabled", not "auto" or "disabled".
>
> Daniel P. Berrangé (2):
> rpm: remove
From: Orion Poplawski
Setting SYNC_TIME=1 does not work on autostarted guests.
See https://bugzilla.redhat.com/show_bug.cgi?id=1555398.
Signed-off-by: Tim Wiederhake
---
tools/libvirt-guests.sh.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
ping
On Mon, 2020-10-19 at 09:36 +0200, Tim Wiederhake wrote:
> This hopefully makes synchronization with QEMU faster and less
> error prone.
>
> Patch #3 showcases the changes to the cpu models the script
> suggests for qemu 8d90bfc5c31ad60f6049dd39be636b06bc00b652.
>
> V1:
>
The %meson macro sets "--auto-features=enabled", thus any feature in the
RPM which has a "with_XXX" condition, needs to explicitly pass a
"-DXXX=state" arg to %meson to override the auto features setting.
The with_bash_completion condition is always set to 1, so rather than
adding an arg to
The %meson macro sets "--auto-features=enabled", thus any feature in the
RPM which has a "with_XXX" condition, needs to explicitly pass a
"-DXXX=state" arg to %meson to override the auto features setting.
The with_libssh and with_libssh2 conditions were not exposed to meson,
so if either was set
RHEL builds disable libssh2, and build root lack libssh2-devel. The RPM
build fails though because meson looks for libssh2 and has it set to
"enabled", not "auto" or "disabled".
Daniel P. Berrangé (2):
rpm: remove with_bash_completion condition
rpm: tell meson whether to use libssh or libssh2
Hey,
On 10/27/20 10:35 PM, Laine Stump wrote:
I don't even remember why I started looking at this. I think that
again I was considering changing some function, and making the DIR* in
that function autoclose was a prerequisite for a reasonably clean
addition to the function. I eventually gave up
On 10/27/20 1:06 PM, Neal Gompa wrote:
On Tue, Oct 27, 2020 at 6:24 AM Michal Privoznik wrote:
On 10/26/20 11:08 PM, Neal Gompa wrote:
Contemporary versions of Fedora automatically set SOURCE_DATE_EPOCH
based on the changelog entry date stamp. In scenarios where it already
is defined, we do
On 10/27/20 10:35 PM, Laine Stump wrote:
After converting all DIR* to g_autoptr(DIR), many cleanup: labels
ended up just having "return ret", and every place that set ret would
just immediately goto cleanup. Remove the cleanup label and its
return, and just return the set value immediately,
On 10/27/20 10:46 PM, Laine Stump wrote:
Commit 53aec799fa31 introduced the function udevGetVDPACharDev(),
which scans a directory using virDirOpenIfExists() and
virDirRead(). It unfortunately forgets to close the DIR* when it is
finished with it. This patch fixes that omission.
Signed-off-by: Han Han
---
NEWS.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 2fef3f706c..5dac805390 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -463,6 +463,8 @@ v6.4.0 (2020-06-02)
already does in these cases. Users are encouraged to provide complete NUMA
24 matches
Mail list logo
