Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine

On 11/3/20 7:58 AM, Thomas Huth wrote: > On 02/11/2020 21.13, Philippe Mathieu-Daudé wrote: >> We deprecated the support for the 'r4k' machine for the 5.0 release >> (commit d32dc61421), which means that our deprecation policy allows >> us to drop it in release 5.2. Remove the code. >> >> To

Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine

On 02/11/2020 21.13, Philippe Mathieu-Daudé wrote: > We deprecated the support for the 'r4k' machine for the 5.0 release > (commit d32dc61421), which means that our deprecation policy allows > us to drop it in release 5.2. Remove the code. > > To repeat the rationale from the deprecation note: >

Re: [PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

On 02/11/2020 11.26, Philippe Mathieu-Daudé wrote: > We deprecated the support for the 'r4k' machine for the 5.0 release > (commit d32dc61421), which means that our deprecation policy allows > us to drop it in release 5.2. Remove the code. > > To repeat the rationale from the deprecation note: >

[PATCH 8/8] hyperv: call openwsman's ws_serializer_free_mem

This should have been included with the upgrade to openwsman 2.6.3. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index f2c7c365fa..1d0d33ec6d 100644 ---

[PATCH 6/8] hyperv: consistent names for SettingData functions

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 27 +-- src/hyperv/hyperv_wmi.c| 12 ++-- src/hyperv/hyperv_wmi.h| 12 ++-- 3 files changed, 25 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

[PATCH 7/8] hyperv: minor formatting fix in hyperv_wmi.h

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_wmi.h b/src/hyperv/hyperv_wmi.h index bf9c3b3bd3..5c5597e27b 100644 --- a/src/hyperv/hyperv_wmi.h +++ b/src/hyperv/hyperv_wmi.h @@ -235,9 +235,8 @@

[PATCH 4/8] hyperv: move hypervGetWmiClass to hyperv_wmi.h

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- src/hyperv/hyperv_wmi.c| 15 +-- src/hyperv/hyperv_wmi.h| 14 ++ 3 files changed, 19 insertions(+), 24 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

[PATCH 2/8] hyperv: remove spaces after hypervObject* casts

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 5344d75585..c1748eed70 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 3/8] hyperv: WMI class list function general cleanup

* use the same section comment in the header and code * place the items in the same relative location within the .h and .c * one parameter per line for multiline function definitions Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 12 +--- src/hyperv/hyperv_wmi.h | 24

[PATCH 5/8] hyperv: move hypervGetProcSDByVSSDInstanceId to hyperv_wmi.c

This places it next to existing related functions. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 26 -- src/hyperv/hyperv_wmi.c| 26 ++ src/hyperv/hyperv_wmi.h| 4 3 files changed, 30 insertions(+), 26 deletions(-)

[PATCH 1/8] hyperv: g_autofree username and password in hypervConnectOpen()

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index a71d0d6261..5344d75585 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 0/8] more Hyper-V code cleanup

Here's a draft GitLab MR if you'd prefer to review the changes there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/5 Matt Coleman (8): hyperv: g_autofree username and password in hypervConnectOpen() hyperv: remove spaces after hypervObject* casts hyperv: WMI class list

Re: Libvirt Open Source Contribution

> On Nov 2, 2020, at 6:47 PM, Barrett J Schonefeld wrote: > > Hey folks, > > We have started work on issue 11, and we have some questions to ensure we > tackle the issue properly. > > • What are the different use cases for g_autoptr vs g_autofree? We > found that g_autofree is

Re:[RFCv2 00/46] RFC: Generate parsexml/formatbuf functions based on directives

Polite ping. Regards, Shi Lei From: "Shi Lei" Date: 2020-09-04 11:34:52 To: libvir-list@redhat.com Subject: [RFCv2 00/46] RFC: Generate parsexml/formatbuf functions based on directives>V1 here: [https://www.redhat.com/archives/libvir-list/2020-June/msg00357.html] > >Differ from V1: > > *

Re: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

On 11/2/20 12:27 PM, Philippe Mathieu-Daudé wrote: > The nanoMIPS ISA has been announced in 2018 for various projects: > > GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html > Linux: https://lwn.net/Articles/753605/ > QEMU:

Re: [PATCH 0/8] more Hyper-V code cleanup

On Mon, Nov 2, 2020 at 7:22 PM Matt Coleman wrote: > > Here's a draft GitLab MR if you'd prefer to review the changes there: > https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/5 > > Matt Coleman (8): > hyperv: g_autofree username and password in hypervConnectOpen() > hyperv: remove

Re: Libvirt Open Source Contribution

Hey folks, We have started work on issue 11 , and we have some questions to ensure we tackle the issue properly. - What are the different use cases for g_autoptr vs g_autofree? We found that g_autofree is preferred for anything that uses

[PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

The nanoMIPS ISA has been announced in 2018 for various projects: GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html Linux: https://lwn.net/Articles/753605/ QEMU: https://www.mail-archive.com/qemu-devel@nongnu.org/msg530721.html Unfortunately the links referenced doesn't work

[PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine

We deprecated the support for the 'r4k' machine for the 5.0 release (commit d32dc61421), which means that our deprecation policy allows us to drop it in release 5.2. Remove the code. To repeat the rationale from the deprecation note: - this virtual machine has no specification - the Linux kernel

Re: [PATCH-for-5.2 v2] hw/mips: Remove the 'r4k' machine

On 11/2/20 7:50 PM, Philippe Mathieu-Daudé wrote: > We deprecated the support for the 'r4k' machine for the 5.0 release > (commit d32dc61421), which means that our deprecation policy allows > us to drop it in release 5.2. Remove the code. > > To repeat the rationale from the deprecation note: > -

[PATCH] virDomainNetDefParseXML: Fix error message for unknown value of //mac/@type

In v6.6.0-rc1~124 we've introduced a new mechanism for MAC addresses for ESX: ignore all checks (type='static') that libvirt or ESX would do (and possibly fail) for specified MAC address. Accepted values for the @type attribute are "generated" and "static". But the error message mentions a

Re: [PATCH 0/6] Hyper-V code cleanup

On 10/27/20 11:58 AM, Michal Privoznik wrote: On 10/22/20 6:38 PM, Matt Coleman wrote: Here's a draft GitLab MR if you'd prefer to review the changes there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/3/diffs Matt Coleman (6):    hyperv: reformat WQL query strings    hyperv:

Re: [libvirt] [PATCH 10/19] virsh: Only return domains that have VNC display to vncdisplay command

On 11/2/20 9:26 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 3 ++- tools/virsh-domain.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index

Re: [libvirt] [PATCH 04/19] virsh: Rename virshInterfaceNameCompleter to virshInterfaceCompleter

On 11/2/20 9:26 AM, Lin Ma wrote: Rename the function virshInterfaceNameCompleter to virshInterfaceCompleter to make it a bit more generic. The upcoming patch invokes it for mac completion. Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 6 +++---

Re: [libvirt] [PATCH 01/19] virsh: Add current vcpu list completion to guestvcpus command

On 11/2/20 9:26 AM, Lin Ma wrote: Unlike the setvcpu command, The option --cpulist of guestvcpus command means the current vcpus list, rather than the maxvcpus list. Not really. It depends what mode the command operates in. If it's --enable then offlined vCPUs should be listed, if it's

Re: [libvirt] [PATCH 11/19] vsh: Fix completion error in case of multiple mac addresses

On 11/2/20 9:26 AM, Lin Ma wrote: We know that the bash completer automatically handle colon by preceding it with an escape character backslash. While our bash autompletion file vsh completes multiple items, In case there're multiple items which have same prefix and the content of completion

Re: [libvirt] [PATCH 02/19] virsh: Add logical CPU IDs completion for nodecpustats command

On 11/2/20 9:26 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-host.c | 35 +++ tools/virsh-completer-host.h | 4 tools/virsh-host.c | 1 + 3 files changed, 40 insertions(+) diff --git a/tools/virsh-completer-host.c

Re: [libvirt] [PATCH 03/19] virsh: Add serial/parallel device name completion to console command

On 11/2/20 9:26 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 54 ++ tools/virsh-completer-domain.h | 4 +++ tools/virsh-domain.c | 1 + 3 files changed, 59 insertions(+) diff --git a/tools/virsh-completer-domain.c

Re: [libvirt] [PATCH 08/19] virsh: Add interface mac completion to iface-name command

On 11/2/20 9:26 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 13 + tools/virsh-completer-interface.h | 4 tools/virsh-interface.c | 8 +++- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH 12/19] virsh: Add mac completion to net-dhcp-leases command

On 11/2/20 9:26 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-network.c | 45 + tools/virsh-completer-network.h | 4 +++ tools/virsh-network.c | 15 +++ 3 files changed, 59 insertions(+), 5 deletions(-) diff --git

Re: [libvirt] [PATCH 13/19] virsh-domain: Introduce 2 macros for domain options 'interface' and 'mac'

On 11/2/20 9:26 AM, Lin Ma wrote: The macro VIRSH_DOMAIN_OPT_INTERFACE for domain option '--interface', The macro VIRSH_DOMAIN_OPT_MAC for domain option '--mac'. Signed-off-by: Lin Ma --- tools/virsh-domain.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH-for-5.2 v2] hw/mips: Remove the 'r4k' machine

We deprecated the support for the 'r4k' machine for the 5.0 release (commit d32dc61421), which means that our deprecation policy allows us to drop it in release 5.2. Remove the code. To repeat the rationale from the deprecation note: - this virtual machine has no specification - the Linux kernel

Re: [PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

On 11/2/20 5:00 PM, Richard Henderson wrote: > On 11/2/20 2:26 AM, Philippe Mathieu-Daudé wrote: >> -mips ``r4k`` platform (since 5.0) >> +mips ``r4k`` platform (removed in 5.2) >> ' > > Header underline needs adjustment. Otherwise, Indeed: Warning, treated as

Re: Release of libvirt-6.9.0

On Mon, Nov 02, 2020 at 12:09:13 +0100, Andrea Bolognani wrote: > On Mon, 2020-11-02 at 11:20 +0100, Jiri Denemark wrote: > [...] > > * Improvements > > > > * Bug fixes > > It would have been nice if you had removed the empty "Improvement" > section at the same time as you updated the release

Re: [PATCH libvirt v1 2/7] nodedev: Detect AP Queues

On 10/21/20 12:59 PM, Shalini Chellathurai Saroja wrote: From: Farhan Ali Each AP Card device can support upto 256 AP Queues. AP Queues are also detected by udev, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja Reviewed-by:

Re: [PATCH libvirt v1 1/7] nodedev: Detect AP Card device

On 10/21/20 12:59 PM, Shalini Chellathurai Saroja wrote: From: Farhan Ali Introduce support for the Adjunct Processor (AP) Crypto Card device. Udev already detects the device, so add support for libvirt nodedev driver. Signed-off-by: Farhan Ali Signed-off-by: Shalini Chellathurai Saroja

Re: [PATCH] security: Use org namespace for xattrs on macOS

On Sun, 2020-11-01 at 14:38 +0300, Roman Bolshakov wrote: > On Wed, Oct 28, 2020 at 08:25:46PM +0100, Michal Privoznik wrote: > > One thing to consider here (and my rough googling did not help) is that we > > need the namespace to be RW only by root. If it were writable by a regular > > user (e.g

Re: [PATCH libvirt v1 4/7] nodedev: detect AP Matrix device

On 10/21/20 12:59 PM, Shalini Chellathurai Saroja wrote: Add support for AP matrix device in libvirt nodedev driver. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- docs/schemas/nodedev.rng | 7 ++

Re: [PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

On 11/2/20 2:26 AM, Philippe Mathieu-Daudé wrote: > -mips ``r4k`` platform (since 5.0) > +mips ``r4k`` platform (removed in 5.2) > ' Header underline needs adjustment. Otherwise, Acked-by: Richard Henderson r~

Re: [PATCH 1/3] qemu: capabilities: Disable detection of QEMU_CAPS_BLOCK_EXPORT_ADD

On Mon, Nov 02, 2020 at 08:30:28 -0600, Eric Blake wrote: > On 10/29/20 12:10 PM, Peter Krempa wrote: > > On Mon, Oct 26, 2020 at 08:36:50 -0500, Eric Blake wrote: > >> On 10/26/20 8:19 AM, Peter Krempa wrote: > >>> We use the capability to switch to using 'block-export-add' in the > >>> upcoming

Re: [PATCH 1/3] qemu: capabilities: Disable detection of QEMU_CAPS_BLOCK_EXPORT_ADD

On 10/29/20 12:10 PM, Peter Krempa wrote: > On Mon, Oct 26, 2020 at 08:36:50 -0500, Eric Blake wrote: >> On 10/26/20 8:19 AM, Peter Krempa wrote: >>> We use the capability to switch to using 'block-export-add' in the >>> upcoming qemu release instead of the at the same time deprecated >>>

Re: [libvirt PATCH] rpm: more fixes for disabling features

On Mon, Nov 02, 2020 at 12:45:21PM +, Daniel P. Berrangé wrote: > The %meson macro sets "--auto-features=enabled", so it is not enough to > disable the driver options, we must also disable any library options > which the drivers depend on. > > Signed-off-by: Daniel P. Berrangé > --- >

[libvirt PATCH] rpm: more fixes for disabling features

The %meson macro sets "--auto-features=enabled", so it is not enough to disable the driver options, we must also disable any library options which the drivers depend on. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 16 1 file changed, 8 insertions(+), 8 deletions(-)

Re: [libvirt PATCH] rpm: fix name of meson option for disabling glusterfs

On Mon, Nov 02, 2020 at 11:09:43AM +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 06afd0dab8..f0990b870b 100644 > ---

Re: [PATCH] news: Fix an RST alignment typo with '=' which breaks the pipeline

On Mon, Nov 02, 2020 at 12:27:24PM +0100, Jiri Denemark wrote: > On Mon, Nov 02, 2020 at 12:05:59 +0100, Erik Skultety wrote: > > This is just a warning, but because we're invoking rst2html5 with > > --strict, it will fail at encountering a single minor issue. > > > > Signed-off-by: Erik Skultety

Re: [PATCH] news: Fix an RST alignment typo with '=' which breaks the pipeline

On Mon, Nov 02, 2020 at 12:05:59 +0100, Erik Skultety wrote: > This is just a warning, but because we're invoking rst2html5 with > --strict, it will fail at encountering a single minor issue. > > Signed-off-by: Erik Skultety > --- > > Pushed as trivial. > > NEWS.rst | 2 +- > 1 file changed,

Re: Release of libvirt-6.9.0

On Mon, 2020-11-02 at 11:20 +0100, Jiri Denemark wrote: [...] > * Improvements > > * Bug fixes It would have been nice if you had removed the empty "Improvement" section at the same time as you updated the release date... Can you please look for such empty sections and deal with them next time?

[libvirt PATCH] rpm: fix name of meson option for disabling glusterfs

Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 06afd0dab8..f0990b870b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1056,9 +1056,9 @@ exit 1 %endif %if

[libvirt PATCH] news: Remove empty section

Signed-off-by: Andrea Bolognani --- Pushed as trivial. NEWS.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index a8dde151e0..905deba5a8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -59,8 +59,6 @@ v6.9.0 (2020-11-02) using . The node device APIs also now

[PATCH] news: Fix an RST alignment typo with '=' which breaks the pipeline

This is just a warning, but because we're invoking rst2html5 with --strict, it will fail at encountering a single minor issue. Signed-off-by: Erik Skultety --- Pushed as trivial. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index

Re: Proposal: drop support for Hyper-V 2008R2

On Mon, 2020-11-02 at 09:15 +, Daniel P. Berrangé wrote: > On Fri, Oct 30, 2020 at 07:34:47PM -0400, Matt Coleman wrote: > > On Oct 30, 2020, at 11:54 AM, Andrea Bolognani wrote: > > > Dropping 2008R2 support is a no-brainer. > > > > > > Can we got further? Our policy[1] for Linux is > > >

Re: [libvirt PATCH 0/2] Run full unit tests on i686 too

On Fri, Oct 30, 2020 at 03:28:08PM +, Daniel P. Berrangé wrote: > > > Daniel P. Berrangé (2): > gitlab: run unit tests in i686 cross build > scripts: trim "__attribute__((packed))" in RPC struct diff Reviewed-by: Erik Skultety

[PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

We deprecated the support for the 'r4k' machine for the 5.0 release (commit d32dc61421), which means that our deprecation policy allows us to drop it in release 5.2. Remove the code. To repeat the rationale from the deprecation note: - this virtual machine has no specification - the Linux kernel

Release of libvirt-6.9.0

The 6.9.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any

Re: [libvirt] [PATCH 09/19] virdomainobjlist: Add vnc into filter group to check the vnc existence of guest

On Mon, Nov 02, 2020 at 16:26:11 +0800, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > include/libvirt/libvirt-domain.h | 3 +++ > src/conf/virdomainobjlist.c | 15 +++ > src/conf/virdomainobjlist.h | 7 ++- > 3 files changed, 24 insertions(+), 1 deletion(-) I'm not

Re: Proposal: drop support for Hyper-V 2008R2

On Fri, Oct 30, 2020 at 07:34:47PM -0400, Matt Coleman wrote: > > On Oct 30, 2020, at 11:54 AM, Andrea Bolognani wrote: > > > > Dropping 2008R2 support is a no-brainer. > > > > Can we got further? Our policy[1] for Linux is > > > > The project aims to support the most recent major version at

Re: [RFC PATCH 2/2] qemu: Add support for max physical address size

On Thu, Oct 29, 2020 at 5:07 PM Dario Faggioli wrote: > This patch maps /domain/cpu/maxphysaddr into -cpu parameters: > > - becomes host-phys-bits=on > - becomes phys-bits=42 > I can't thank you enough Dario for starting this, I have waited for this quite a while and never found the time

[libvirt] [PATCH 16/19] virsh: Move/add some of function declarations to virsh-domain.h

The upcoming patches introduce completers into virsh-completer-domain.c, They will invoke the functions which are defined in virsh-domain.c, So these functions need to be declared in virsh-domain.h. Signed-off-by: Lin Ma --- tools/virsh-domain.c | 1 - tools/virsh-domain.h | 4 2 files

[libvirt] [PATCH 18/19] virsh: Add lifecycle type completion to set-lifecycle-action command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index

[libvirt] [PATCH 09/19] virdomainobjlist: Add vnc into filter group to check the vnc existence of guest

Signed-off-by: Lin Ma --- include/libvirt/libvirt-domain.h | 3 +++ src/conf/virdomainobjlist.c | 15 +++ src/conf/virdomainobjlist.h | 7 ++- 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h

[libvirt] [PATCH 19/19] virsh: Add lifecycle action completion to set-lifecycle-action command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index

[libvirt] [PATCH 14/19] virsh-domain: Apply macro VIRSH_DOMAIN_OPT_INTERFACE for interface option

Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 20 +++- tools/virsh-domain-monitor.h | 1 + tools/virsh-domain.c | 14 ++ 3 files changed, 6 insertions(+), 29 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c

[libvirt] [PATCH 15/19] virsh-domain: Apply macro VIRSH_DOMAIN_OPT_MAC for mac option

Signed-off-by: Lin Ma --- tools/virsh-domain.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d50fdbad26..ed7307cdb6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12291,12 +12291,7 @@ static const

[libvirt] [PATCH 00/19] virsh completion improvement

Lin Ma (19): virsh: Add current vcpu list completion to guestvcpus command virsh: Add logical CPU IDs completion for nodecpustats command virsh: Add serial/parallel device name completion to console command virsh: Rename virshInterfaceNameCompleter to virshInterfaceCompleter virsh:

[libvirt] [PATCH 17/19] virsh: Add signal name completion to send-process-signal command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index

[libvirt] [PATCH 05/19] virsh: create a macro with a _FULL suffix for common --interface option

Signed-off-by: Lin Ma --- tools/virsh-interface.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index bd57648779..6c47767754 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -18,15

[libvirt] [PATCH 10/19] virsh: Only return domains that have VNC display to vncdisplay command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 3 ++- tools/virsh-domain.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index ab81a0dcfe..305711151f 100644 ---

[libvirt] [PATCH 08/19] virsh: Add interface mac completion to iface-name command

Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 13 + tools/virsh-completer-interface.h | 4 tools/virsh-interface.c | 8 +++- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/tools/virsh-completer-interface.c

[libvirt] [PATCH 03/19] virsh: Add serial/parallel device name completion to console command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 54 ++ tools/virsh-completer-domain.h | 4 +++ tools/virsh-domain.c | 1 + 3 files changed, 59 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index

[libvirt] [PATCH 13/19] virsh-domain: Introduce 2 macros for domain options 'interface' and 'mac'

The macro VIRSH_DOMAIN_OPT_INTERFACE for domain option '--interface', The macro VIRSH_DOMAIN_OPT_MAC for domain option '--mac'. Signed-off-by: Lin Ma --- tools/virsh-domain.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/virsh-domain.h b/tools/virsh-domain.h

[libvirt] [PATCH 02/19] virsh: Add logical CPU IDs completion for nodecpustats command

Signed-off-by: Lin Ma --- tools/virsh-completer-host.c | 35 +++ tools/virsh-completer-host.h | 4 tools/virsh-host.c | 1 + 3 files changed, 40 insertions(+) diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index

[libvirt] [PATCH 12/19] virsh: Add mac completion to net-dhcp-leases command

Signed-off-by: Lin Ma --- tools/virsh-completer-network.c | 45 + tools/virsh-completer-network.h | 4 +++ tools/virsh-network.c | 15 +++ 3 files changed, 59 insertions(+), 5 deletions(-) diff --git a/tools/virsh-completer-network.c

[libvirt] [PATCH 07/19] virsh: Add interface name completion to iface-mac command

Signed-off-by: Lin Ma --- tools/virsh-interface.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index 13e120d7a0..df97b74c4c 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -440,11 +440,7 @@ static

[libvirt] [PATCH 04/19] virsh: Rename virshInterfaceNameCompleter to virshInterfaceCompleter

Rename the function virshInterfaceNameCompleter to virshInterfaceCompleter to make it a bit more generic. The upcoming patch invokes it for mac completion. Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 6 +++--- tools/virsh-completer-interface.h | 6 +++---

[libvirt] [PATCH 01/19] virsh: Add current vcpu list completion to guestvcpus command

Unlike the setvcpu command, The option --cpulist of guestvcpus command means the current vcpus list, rather than the maxvcpus list. Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 36 ++ tools/virsh-completer-domain.h | 4 tools/virsh-domain.c

[libvirt] [PATCH 06/19] virsh: Add interface name completion to iface-bridge command

Signed-off-by: Lin Ma --- tools/virsh-interface.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index 6c47767754..13e120d7a0 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -785,11 +785,7 @@ static

[libvirt] [PATCH 11/19] vsh: Fix completion error in case of multiple mac addresses

We know that the bash completer automatically handle colon by preceding it with an escape character backslash. While our bash autompletion file vsh completes multiple items, In case there're multiple items which have same prefix and the content of completion items contain colon(say mac address),