Re: Libvirt Open Source Contribution

2020-11-07 Thread Barrett J Schonefeld
Michal, We've struggled with the email system so far. You may have seen when we submitted a chain of 65 patches when we meant to send only the last commit. We tested this by sending it to ourselves first but must have made a mistake when submitting to libvir-list. We submitted an initial patch

Re: [PATCH v2] virsh: Allow listing just domain IDs

2020-11-07 Thread Michal Prívozník
On 11/6/20 2:59 PM, Martin Kletzander wrote: On Thu, Oct 22, 2020 at 04:41:18PM +0200, Michal Privoznik wrote: Some completers for libvirt related tools might want to list domain IDs only. Just like the one I've implemented for virt-viewer [1]. I've worked around it using some awk magic, but if

[PATCH v4 0/7] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate

2020-11-07 Thread Hao Wang
V3 -> V4: define flags to unsigned int fix some compile warnings V2 -> V3: reorganize patchset to fix compile warning V1 -> V2: replace QEMU_JOB_ASYNC with QEMU_JOB_QUERY Sometimes domain's memory dirty rate is expected by user in order to decide whether it's proper to be migrated out or not.

[PATCH v4 6/7] migration/dirtyrate: Implement qemuDomainGetDirtyRateInfo

2020-11-07 Thread Hao Wang
Implement qemuDomainGetDirtyRateInfo: using flags to control behaviors -- calculate and/or query dirtyrate. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 11 ++ src/qemu/qemu_driver.c | 68 2 files

[PATCH v4 2/7] migration/dirtyrate: set up framwork of domainGetDirtyRateInfo API

2020-11-07 Thread Hao Wang
Introduce DomainGetDirtyRateInfo API for domain's memory dirty rate calculation and query. Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 5 src/driver-hypervisor.h | 7 + src/libvirt-domain.c |

[PATCH v4 7/7] migration/dirtyrate: Introduce getdirtyrate virsh api

2020-11-07 Thread Hao Wang
Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- tools/virsh-domain.c | 112 +++ 1 file changed, 112 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ef347585e8..52608e2c1b 100644 ---

[PATCH v4 5/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-11-07 Thread Hao Wang
Implement qemuMonitorJSONExtractDirtyRateInfo to deal with the return from qmp "query-dirty-rate", and store them in virDomainDirtyRateInfo. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 17 + src/qemu/qemu_monitor_json.c | 59

[PATCH v4 3/7] migration/dirtyrate: Implement qemuDomainCalculateDirtyRate

2020-11-07 Thread Hao Wang
Implement qemuDomainCalculateDirtyRate which calculates domain's memory dirty rate calling qmp "calc-dirty-rate". Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- src/qemu/qemu_migration.c| 28 src/qemu/qemu_migration.h| 5

[PATCH v4 4/7] migration/dirtyrate: Implement qemuDomainQueryDirtyRate

2020-11-07 Thread Hao Wang
Implement qemuDomainQueryDirtyRate which query domain's memory dirty rate calling qmp "query-dirty-rate". Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- src/qemu/qemu_migration.c| 31 +++ src/qemu/qemu_migration.h| 5 +

[PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

2020-11-07 Thread Hao Wang
Introduce virDomainDirtyRateInfo structure used for domain's memory dirty rate query. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 24 1 file changed, 24 insertions(+) diff --git a/include/libvirt/libvirt-domain.h

[libvirt PATCH] qemu: add qemuAgentSSH{Add,Remove,Get}AuthorizedKeys

2020-11-07 Thread marcandre . lureau
From: Marc-André Lureau In QEMU 5.2, the guest agent learned to manipulate a user ~/.ssh/authorized_keys. Bind the JSON API to libvirt. https://wiki.qemu.org/ChangeLog/5.2#Guest_agent Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1888537 Signed-off-by: Marc-André Lureau ---