[PATCH] qemu: virtiofs: Stop virtiofsd when the qemu guest fails to start

From: Masayoshi Mizuma A qemu guest which has virtiofs config fails to start if the previous starting failed because of invalid option or something. For example of the reproduction: # virsh start guest error: Failed to start domain guest error: internal error: process exited while

Re: [PATCH] util: convert char pointers to use g_autofree

On Tue, Nov 10, 2020 at 6:36 AM Ryan Gahagan wrote: > From: Barrett Schonefeld > > additional conversions to the GLib API in src/util per issue #11. > > files updated are: > - src/util/vircgroupv1.c > - src/util/virhostcpu.c > - src/util/virlockspace.c > - src/util/virmacmap.c > -

Re: [PATCH v4 0/7] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate

I quite agree with you and will modify that in my next realeases. Thanks for your suggestion! On 2020/11/10 9:34, Han Han wrote: > > > On Sat, Nov 7, 2020 at 5:54 PM Hao Wang > wrote: > > V3 -> V4: > define flags to unsigned int > fix some compile

Re: [PATCH v4 0/7] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate

On Sat, Nov 7, 2020 at 5:54 PM Hao Wang wrote: > V3 -> V4: > define flags to unsigned int > fix some compile warnings > > V2 -> V3: > reorganize patchset to fix compile warning > > V1 -> V2: > replace QEMU_JOB_ASYNC with QEMU_JOB_QUERY > > > Sometimes domain's memory dirty rate is expected by

[PATCH] util: convert char pointers to use g_autofree

From: Barrett Schonefeld additional conversions to the GLib API in src/util per issue #11. files updated are: - src/util/vircgroupv1.c - src/util/virhostcpu.c - src/util/virlockspace.c - src/util/virmacmap.c - src/util/virresctrl.c - src/util/virsysinfo.c Related issue:

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

> On Nov 9, 2020, at 9:55 AM, Daniel P. Berrangé wrote: > > That doesn't seem to be the case. If I modify this patch so that it > only removes the Msvm_ classes for v1, everything still compiles. Sorry, I'm juggling several branches and have many commits ahead of this. I thought I had

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

> On Nov 9, 2020, at 9:28 AM, Daniel P. Berrangé wrote: > > I was expecting to see that this patch only dropped code, but > this is introducing a new v2 class. I think that ought to be > down as a separate patch. Likewise for similar changes below. This is not actually adding a new class:

Re: [PATCH 6/7] docs: drop support for Windows versions prior to 2012R2

> On Nov 9, 2020, at 8:21 AM, Daniel P. Berrangé wrote: > > On Mon, Nov 09, 2020 at 03:43:12AM -0500, Matt Coleman wrote: >> Signed-off-by: Matt Coleman >> --- >> docs/drvhyperv.html.in | 17 + >> docs/platforms.rst | 3 +-- >> 2 files changed, 2 insertions(+), 18

RE: Libvirt NVME support

> -Original Message- > From: Peter Krempa > Sent: 09 November 2020 16:44 > To: Suraj Kasi > Cc: libvirt-l...@redhat.com; Thanos Makatos > ; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 09, 2020 at 16:38:11 +, Suraj Kasi wrote: > > Hi, > > > > We wanted to check if

Re: [libvirt PATCH] virgdbus: fix getting non-shared DBus connection

On a Monday in 2020, Pavel Hrdina wrote: We need to pass some flags in order to properly initialize the connection otherwise it will not work. This copies what GLib does for g_bus_get_sync() internally. This fixes an issue with LXC driver where libvirt was not able to register any VM with

Re: Libvirt NVME support

On Mon, Nov 09, 2020 at 16:38:11 +, Suraj Kasi wrote: > Hi, > > We wanted to check if it’s possible to specify a disk’s target as nvme (so > that the disk shows up as a nvme disk to the guest VM). > > Per libvirt documentation it looks like (since Libvirt 6.0.0) we can specify > the disk

[libvirt PATCH] virgdbus: fix getting non-shared DBus connection

We need to pass some flags in order to properly initialize the connection otherwise it will not work. This copies what GLib does for g_bus_get_sync() internally. This fixes an issue with LXC driver where libvirt was not able to register any VM with machined. Reported-by: Matthias Maier

Libvirt NVME support

Hi, We wanted to check if it’s possible to specify a disk’s target as nvme (so that the disk shows up as a nvme disk to the guest VM). Per libvirt documentation it looks like (since Libvirt 6.0.0) we can specify the disk type as nvme and disks source as a nvme. But the documentation does not

Re: [PATCH 00/28] a bunch of domain_conf cleanup

On a Monday in 2020, Michal Privoznik wrote: On 11/6/20 4:32 AM, Matt Coleman wrote: Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to

Re: [PATCH] domain_conf: make virDomainDiskSetSource() void

On 11/5/20 11:26 AM, Michal Prívozník wrote: On 11/5/20 7:23 AM, Matt Coleman wrote: The function only returns zero or aborts, so it might as well be void. This has the added benefit of simplifying the code that calls it. Signed-off-by: Matt Coleman ---   src/conf/domain_conf.c   |  3 +--  

Re: [PATCH] convert char pointers to use g_autofree

The commit summary is too broad. A prefix to say which part of the codebase is touched would be nice: util: convert char pointers to use g_autofree On a Friday in 2020, Ryan Gahagan wrote: From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me

Re: [libvirt PATCH] Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE

On Mon, Nov 09, 2020 at 16:17:15 +, Daniel Berrange wrote: > The enum constant names should all have a prefix that matches the enum > name. VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE was missing the "CREATE_" > part of the name prefix. > > Signed-off-by: Daniel P. Berrangé > --- Reviewed-by:

[libvirt PATCH] Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE

The enum constant names should all have a prefix that matches the enum name. VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE was missing the "CREATE_" part of the name prefix. Signed-off-by: Daniel P. Berrangé --- include/libvirt/libvirt-domain-checkpoint.h | 4 ++-- src/libvirt-domain-checkpoint.c

Re: [libvirt PATCH 0/2] Fix dependencies for python scripts

On 11/9/20 4:37 PM, Daniel P. Berrangé wrote: Daniel P. Berrangé (2): meson: ensure python script is run in utf8 env meson: drop use of .path() for python args docs/manpages/meson.build | 4 ++-- docs/meson.build | 8 src/access/meson.build| 2 +-

Re: [PATCH 03/28] domain_conf: use g_free() in virDomainPostParseCheckISCSIPath()

On Mon, Nov 09, 2020 at 15:37:39 +0100, Michal Privoznik wrote: > On 11/6/20 4:32 AM, Matt Coleman wrote: > > Signed-off-by: Matt Coleman > > --- > > src/conf/domain_conf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/conf/domain_conf.c

[libvirt PATCH 1/2] meson: ensure python script is run in utf8 env

Signed-off-by: Daniel P. Berrangé --- src/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build index 29c8210ab2..72dad0ab45 100644 --- a/src/meson.build +++ b/src/meson.build @@ -703,7 +703,7 @@ endforeach foreach data :

[libvirt PATCH 2/2] meson: drop use of .path() for python args

When using .path() for an argument to a python script meson will not setup dependancies on the file. This means that changes to the generator script will not trigger a rebiuld Signed-off-by: Daniel P. Berrangé --- docs/manpages/meson.build | 4 ++-- docs/meson.build | 8

[libvirt PATCH 0/2] Fix dependencies for python scripts

Daniel P. Berrangé (2): meson: ensure python script is run in utf8 env meson: drop use of .path() for python args docs/manpages/meson.build | 4 ++-- docs/meson.build | 8 src/access/meson.build| 2 +- src/admin/meson.build | 4 ++-- src/esx/meson.build |

Re: [PATCH 0/7] drop support for Windows versions prior to 2012R2

On Mon, Nov 09, 2020 at 03:43:06AM -0500, Matt Coleman wrote: > Microsoft no longer supports Windows 2008R2 at all. Windows 2012 and > 2012 R2 are still within extended support until October 9, 2023. > > Hyper-V's WMI API has two versions. V1 is supported by 2008R2 and 2012. > 2012 also offered

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

On Mon, Nov 09, 2020 at 09:31:09AM -0500, Matt Coleman wrote: > > On Nov 9, 2020, at 9:28 AM, Daniel P. Berrangé wrote: > > > > I was expecting to see that this patch only dropped code, but > > this is introducing a new v2 class. I think that ought to be > > down as a separate patch. Likewise

Re: [PATCH 00/28] a bunch of domain_conf cleanup

On 11/6/20 4:32 AM, Matt Coleman wrote: Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to review. Yeah, some might be squashed. 14

Re: [PATCH 4/7] hyperv: remove hypervWmiClassInfoList, hypervWmiClassInfoListPtr, and _hypervWmiClassInfoList

On Mon, Nov 09, 2020 at 03:43:10AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > scripts/hyperv_wmi_generator.py | 21 ++--- > src/hyperv/hyperv_wmi.c | 41 ++--- > src/hyperv/hyperv_wmi.h | 13 ++- >

Re: [PATCH 05/28] domain_conf: make virDomainChr/RNG/Video/VsockDefPostParse() and virDomainNVRAMDefFormat() void

On 11/6/20 4:32 AM, Matt Coleman wrote: These functions always return zero, so they might as well be void. Signed-off-by: Matt Coleman --- src/conf/domain_conf.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) @@ -27734,7 +27730,7 @@

Re: [PATCH 03/28] domain_conf: use g_free() in virDomainPostParseCheckISCSIPath()

On 11/6/20 4:32 AM, Matt Coleman wrote: Signed-off-by: Matt Coleman --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ce49905360..a64dec8df4 100644 --- a/src/conf/domain_conf.c +++

Re: [PATCH 3/7] hyperv: remove support for multiple API versions from the WMI generator

On Mon, Nov 09, 2020 at 03:43:09AM -0500, Matt Coleman wrote: > All Msvm_* classes are assumed to be V2, now. > > Signed-off-by: Matt Coleman > --- > scripts/hyperv_wmi_generator.py | 267 +- > src/hyperv/hyperv_driver.c| 106 +- >

Re: [PATCH 2/7] hyperv: remove hypervPrivate->wmiVersion

On Mon, Nov 09, 2020 at 03:43:08AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 199 ++-- > src/hyperv/hyperv_private.h | 7 -- > src/hyperv/hyperv_wmi.c | 46 +++-- > src/hyperv/hyperv_wmi.h | 12

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

On Mon, Nov 09, 2020 at 03:43:07AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_wmi_generator.input | 424 +- > 1 file changed, 12 insertions(+), 412 deletions(-) > > diff --git a/src/hyperv/hyperv_wmi_generator.input >

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

On Mon, Nov 09, 2020 at 03:43:07AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_wmi_generator.input | 424 +- > 1 file changed, 12 insertions(+), 412 deletions(-) This patch has to be moved after the 2nd patch, otherwise the build

Re: [PATCH] viridentitytest: Run more frequently

On 11/9/20 8:19 AM, Michal Privoznik wrote: The viridentitytest tests our viridentity module which is compiled on all platforms and OSes. There is no need to have SELinux secdriver as individual test cases are skipped if SELinux is missing. Signed-off-by: Michal Privoznik ---

Re: [PATCH v2 00/10] qemu: support renaming domains with snapshots/checkpoints

On 11/3/20 8:59 AM, Nikolay Shirokovskiy wrote: This is basically just rebase of [1] as it was not get any attention at that time. [1] [PATCH 0/8] qemu: support renaming domains with snapshots/checkpoints https://www.redhat.com/archives/libvir-list/2020-March/msg00018.html Code LGTM:

Re: [PATCH v2 06/10] qemu: rename: support renaming checkpoints directory

On 11/3/20 9:00 AM, Nikolay Shirokovskiy wrote: This is basically just saves checkpoints metadata on disk after name is changed "This basically just saves ..." in memory as path to domain checkpoints directory depends on name. After that old checkpoint directory is deleted with checkpoint

Re: [PATCH v2 05/10] qemu: rename: support renaming snapshots directory

On 11/3/20 9:00 AM, Nikolay Shirokovskiy wrote: This is basically just saves snapshots metadata on disk after name is changed Extra 'is'. "This basically just saves " in memory as path to domain snapshot directory depends on name. After that old snapshot directory is deleted with

Re: [PATCH 6/7] docs: drop support for Windows versions prior to 2012R2

On Mon, Nov 09, 2020 at 03:43:12AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > docs/drvhyperv.html.in | 17 + > docs/platforms.rst | 3 +-- > 2 files changed, 2 insertions(+), 18 deletions(-) > diff --git a/docs/platforms.rst b/docs/platforms.rst >

[PATCH 5/7] hyperv: do not generate *_CLASSNAME constants

Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/hyperv_wmi_generator.py b/scripts/hyperv_wmi_generator.py index a6f5c6aeab..d72e5d8ca1 100755 --- a/scripts/hyperv_wmi_generator.py +++

[PATCH 6/7] docs: drop support for Windows versions prior to 2012R2

Signed-off-by: Matt Coleman --- docs/drvhyperv.html.in | 17 + docs/platforms.rst | 3 +-- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/docs/drvhyperv.html.in b/docs/drvhyperv.html.in index e8e2113f70..bce4e4128b 100644 --- a/docs/drvhyperv.html.in +++

[PATCH 4/7] hyperv: remove hypervWmiClassInfoList, hypervWmiClassInfoListPtr, and _hypervWmiClassInfoList

Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 21 ++--- src/hyperv/hyperv_wmi.c | 41 ++--- src/hyperv/hyperv_wmi.h | 13 ++- src/hyperv/hyperv_wmi_classes.h | 8 --- 4 files changed, 21 insertions(+), 62

[PATCH 7/7] news: drop support for Windows versions prior to 2012R2

Signed-off-by: Matt Coleman --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 905deba5a8..0e56f5dbca 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v6.10.0 (unreleased) * **Bug fixes** +* **Removed features** + + * hyperv: removed

[PATCH 3/7] hyperv: remove support for multiple API versions from the WMI generator

All Msvm_* classes are assumed to be V2, now. Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 267 +- src/hyperv/hyperv_driver.c| 106 +- src/hyperv/hyperv_wmi.c | 49 ++--- src/hyperv/hyperv_wmi.h

[PATCH 2/7] hyperv: remove hypervPrivate->wmiVersion

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 199 ++-- src/hyperv/hyperv_private.h | 7 -- src/hyperv/hyperv_wmi.c | 46 +++-- src/hyperv/hyperv_wmi.h | 12 +-- 4 files changed, 51 insertions(+), 213 deletions(-) diff --git

Re: [libvirt PATCH] qemu: add qemuAgentSSH{Add,Remove,Get}AuthorizedKeys

On 11/7/20 10:12 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau In QEMU 5.2, the guest agent learned to manipulate a user ~/.ssh/authorized_keys. Bind the JSON API to libvirt. https://wiki.qemu.org/ChangeLog/5.2#Guest_agent Fixes:

[PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi_generator.input | 424 +- 1 file changed, 12 insertions(+), 412 deletions(-) diff --git a/src/hyperv/hyperv_wmi_generator.input b/src/hyperv/hyperv_wmi_generator.input index 1377138a12..e6b53bc021 100644 ---

[PATCH 0/7] drop support for Windows versions prior to 2012R2

Microsoft no longer supports Windows 2008R2 at all. Windows 2012 and 2012 R2 are still within extended support until October 9, 2023. Hyper-V's WMI API has two versions. V1 is supported by 2008R2 and 2012. 2012 also offered initial support for V2, but it's incomplete. 2012R2 was the first version

[PATCH] qemustatusxml2xmltest: Remove 'virdeterministichash' mocking

Commit 89a3115bac2c92ac67516 was not updated after recent changes to hash table usage and was still referencing the now removed deterministic hash mock, which caused CI failure. Fixes: 89a3115bac2c92ac67516d04df6a45769f69a37c Signed-off-by: Peter Krempa --- Pushed as fix for CI.

Re: [libvirt PATCH 1/2] ci: Switch to meson build system

... > > -# $CONFIGURE_OPTS is a env that can optionally be set in the container, > > -# populated at build time from the Dockerfile. A typical use case would > > -# be to pass --host/--target args to trigger cross-compilation > > -# > > -# This can be augmented by make local args in

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

On Sat, Nov 07, 2020 at 10:41:52AM +0800, Zhong, Luyao wrote: On 11/4/2020 9:02 PM, Martin Kletzander wrote: On Fri, Oct 16, 2020 at 10:38:51PM +0800, Zhong, Luyao wrote: On 10/16/2020 9:32 PM, Zang, Rui wrote: How about if “migratable” is set, “mode” should be ignored/omitted? So any

[libvirt PATCH v2 0/2] Switch our build repo CI recipes in the ci subdirectory to meson

Since v1: - honor MESON_OPTS from our cross containers - remove several more variables - shuffle the patches a bit Erik Skultety (2): ci: Switch to meson build system ci: Drop env variables related to autotools and make ci/Makefile | 37 +++-- ci/build.sh |

[libvirt PATCH v2 2/2] ci: Drop env variables related to autotools and make

Previous patch switched the build to meson which supports only out-of-tree builds, runs by default in parallel on all available CPUs, and we don't use configure anymore - the corresponding variables are thus longer needed. Signed-off-by: Erik Skultety --- ci/Makefile | 29

Re: [PULL 0/3] MIPS patches for 5.2-rc1

in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/mips-fixes-20201109 > > for you to fetch changes up to bf4ee88ab63fcf2dcb75f0d68cc6c8d2edb68212: > > hw/mips/boston: Fix memory leak in boston_fdt_filter() error-handl

[libvirt PATCH v2 1/2] ci: Switch to meson build system

First add the meson required bits to be able to run the build. NOTE: inspired by our gitlab-ci.yml Signed-off-by: Erik Skultety --- ci/Makefile | 10 -- ci/build.sh | 20 +--- 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/ci/Makefile b/ci/Makefile

[PATCH] viridentitytest: Run more frequently

The viridentitytest tests our viridentity module which is compiled on all platforms and OSes. There is no need to have SELinux secdriver as individual test cases are skipped if SELinux is missing. Signed-off-by: Michal Privoznik --- Successfully build here:

Re: [libvirt PATCH 1/2] ci: Switch to meson build system

On Mon, Nov 09, 2020 at 11:32:45AM +0100, Erik Skultety wrote: > First add the meson required bits to be able to run the build. > NOTE: inspired by our gitlab-ci.yml > > Signed-off-by: Erik Skultety > --- > ci/Makefile | 18 ++ > ci/build.sh | 21 ++--- > 2 files

Re: [libvirt PATCH 1/2] ci: Switch to meson build system

On Mon, Nov 09, 2020 at 11:32:45AM +0100, Erik Skultety wrote: > First add the meson required bits to be able to run the build. > NOTE: inspired by our gitlab-ci.yml > > Signed-off-by: Erik Skultety > --- > ci/Makefile | 18 ++ > ci/build.sh | 21 ++--- > 2 files

[libvirt PATCH 1/2] ci: Switch to meson build system

First add the meson required bits to be able to run the build. NOTE: inspired by our gitlab-ci.yml Signed-off-by: Erik Skultety --- ci/Makefile | 18 ++ ci/build.sh | 21 ++--- 2 files changed, 12 insertions(+), 27 deletions(-) diff --git a/ci/Makefile

[libvirt PATCH 0/2] Switch our build repo CI recipes in the ci subdirectory to meson

Erik Skultety (2): ci: Switch to meson build system ci: Drop env variables related to autotools and make ci/Makefile | 29 ++--- ci/build.sh | 21 ++--- 2 files changed, 12 insertions(+), 38 deletions(-) -- 2.26.2

[libvirt PATCH 2/2] ci: Drop env variables related to autotools and make

Previous patch switched the build to meson which supports only out-of-tree builds, so these variables are no longer needed. Signed-off-by: Erik Skultety --- ci/Makefile | 11 --- 1 file changed, 11 deletions(-) diff --git a/ci/Makefile b/ci/Makefile index d3f14156c5..14a51dcb45 100644

Re: Libvirt Open Source Contribution

On Mon, Nov 09, 2020 at 09:47:16AM +, Daniel P. Berrangé wrote: > On Sun, Nov 08, 2020 at 11:57:15AM -0600, Ryan Gahagan wrote: > > We've also been having some troubles actually getting ninja and meson to > > run properly. Our team has one member on MacOS, one on Ubuntu 18.04, and > > one

Re: Libvirt Open Source Contribution

On Sat, Nov 07, 2020 at 12:04:12PM -0600, Barrett J Schonefeld wrote: > Michal, > > We've struggled with the email system so far. You may have seen when we > submitted a chain of 65 patches when we meant to send only the last commit. > We tested this by sending it to ourselves first but must have

Re: Libvirt Open Source Contribution

On Sun, Nov 08, 2020 at 11:57:15AM -0600, Ryan Gahagan wrote: > We've also been having some troubles actually getting ninja and meson to > run properly. Our team has one member on MacOS, one on Ubuntu 18.04, and > one working on a remote server (Ubuntu again) without sudo privileges. We > want to

Re: [PATCH 0/9] tests: Add testing of qemu migration cookie

On 10/30/20 1:47 PM, Peter Krempa wrote: Note that this series probably depends on the hash table refactor. Add testing of migration cookie as we don't have any schema or examples of it to prevent breakage and help with development. Peter Krempa (9): qemuxml2xmltest: Remove 'WITH_QEMU'

Re: [PATCH 8/9] qemumigrationcookiexmltest: Add synthetic test case

On 10/30/20 1:47 PM, Peter Krempa wrote: Add a test case attempting to excercise the most of the cookie XML s/excercise/exercise Reviewed-by: Daniel Henrique Barboza parsing/formatting infra. Note that the data is not based on any real case. Signed-off-by: Peter Krempa ---

[PATCH 5/5] Fixed error where char** not being promoted to const

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8abca1b65e..10ff7175a2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -227,7 +227,7 @@ static const

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

Re: [PATCH v2] virsh: Allow listing just domain IDs

On Sat, Nov 07, 2020 at 11:43:05AM +0100, Michal Prívozník wrote: On 11/6/20 2:59 PM, Martin Kletzander wrote: On Thu, Oct 22, 2020 at 04:41:18PM +0200, Michal Privoznik wrote: Some completers for libvirt related tools might want to list domain IDs only. Just like the one I've implemented for

Re: [PATCH] News: Several apparmor improvements at v6.7.0

Trivial advice: Mention your patch version in the title of the email. See the last sentence of https://libvirt.org/submitting-patches.html On Mon, Nov 9, 2020 at 3:35 PM jgao wrote: > From: jgao > > Add news about apparmor about the improvements. > > Signed-off-by: jgao > For a single patch,