Re: [PATCH 8/8] Added new params to attach-disk docs

On Tue, Nov 10, 2020 at 15:56:20 -0600, Ryan Gahagan wrote: > Signed-off-by: Ryan Gahagan > --- > docs/manpages/virsh.rst | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst > index bfd26e3120..83134ba571 100644 > ---

Re: [PATCH 6/8] Bump - rerun CI HTTP 500 err

On Tue, Nov 10, 2020 at 15:56:18 -0600, Ryan Gahagan wrote: > Signed-off-by: Ryan Gahagan > --- > tools/virsh-domain.c | 1 - > 1 file changed, 1 deletion(-) This definitely does not belong to a final submission.

Re: [PATCH 1/8] Added a few attach-disk parameters

On Tue, Nov 10, 2020 at 15:56:13 -0600, Ryan Gahagan wrote: Please describe your changes in the commit message. > Signed-off-by: Ryan Gahagan > --- > tools/virsh-domain.c | 76 +++- > 1 file changed, 68 insertions(+), 8 deletions(-) > > diff --git a/too

Re: [PATCH 3/8] Fixed code style bug for virBufferAddLit

On Tue, Nov 10, 2020 at 15:56:15 -0600, Ryan Gahagan wrote: > Signed-off-by: Ryan Gahagan > --- > tools/virsh-domain.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 810e55fa53..5862993464 10064

Re: [PATCH 00/28] a bunch of domain_conf cleanup

On 11/11/20 8:18 AM, Matt Coleman wrote: On Nov 9, 2020, at 9:43 AM, Michal Privoznik wrote: Nice cleanup. But as I say in 03/28 I think we might want glib adoption to be done in bigger chunks. Usually we rewrite VIR_ALLOC/VIR_REALLOC_N -> g_new0()/g_renew() in one patch (might be coupled wit

Re: [PATCH v2 1/2] docs: refactor mdev_types into new paragraph

Boris Fiuczynski [2020-11-10, 07:09PM +0100]: > To prevent copying the mdev_types description multiple times > it is refactored into a new paragraph for easy reuse. > > Signed-off-by: Boris Fiuczynski > --- > docs/formatnode.html.in | 70 - > 1 file chang

Re: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name

On Wed, Nov 11, 2020 at 10:24 AM Jason Dillaman wrote: > On Tue, Nov 10, 2020 at 8:43 PM Han Han wrote: > > > > Signed-off-by: Han Han > > --- > > docs/formatdomain.rst | 16 ++ > > src/conf/domain_conf.c | 47 ++ > > 2 files changed, 59 ins

Re: [PATCH v7 3/4] conf: Support to parse rbd namespace from source name

On Tue, Nov 10, 2020 at 8:43 PM Han Han wrote: > > Signed-off-by: Han Han > --- > docs/formatdomain.rst | 16 ++ > src/conf/domain_conf.c | 47 ++ > 2 files changed, 59 insertions(+), 4 deletions(-) > > diff --git a/docs/formatdomain.rst b/doc

[PATCH v7 3/4] conf: Support to parse rbd namespace from source name

Signed-off-by: Han Han --- docs/formatdomain.rst | 16 ++ src/conf/domain_conf.c | 47 ++ 2 files changed, 59 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index a6ab845f92..2b760e6a39 100644 --- a/do

[PATCH v7 4/4] qemu: Implement rbd namespace to the source name attribute

Since Nautilus ceph supports separate image namespaces within a pool for tenant isolation and QEMU adds it as a rbd blockdev options from 5.0.0. The source name with format "//" could be used to access a rbd image with namespace. Add unit tests for this attribute. https://bugzilla.redhat.com/show

[PATCH v7 2/4] util: Add member ns to the storage source struct

The member ns will be used to store the namespace string. Signed-off-by: Han Han --- src/util/virstoragefile.c | 2 ++ src/util/virstoragefile.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 35e6dcf5de..5d2fd70889 100644 --- a/s

[PATCH v7 0/4] qemu: Support rbd namespace in rbd source name

Diff from v6: rebase to 6.9.0 v6: https://www.redhat.com/archives/libvir-list/2020-October/msg00707.html gitlab repo: https://gitlab.com/hhan2/libvirt/-/commits/rbd-namespace-v7 Han Han (4): qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE util: Add member ns to the storage source struct conf

[PATCH v7 1/4] qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE

The capability flag will be used for rbd namespace option. The rbd namespace is introduced since ceph Nautilus and qemu v5.0.0. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilities

Re: [PATCH 1/8] Added a few attach-disk parameters

It is better to format the patch summary like this format: "SUBSYSTEM: TITLE" For example, this patch could be "virsh: Added a few attach-disk parameters" You can see the git log of libvirt for more reference: https://libvirt.org/git/?p=libvirt.git;a=summary On Wed, Nov 11, 2020 at 5:58 AM Ryan Ga

[PATCH 1/8] Added a few attach-disk parameters

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 76 +++- 1 file changed, 68 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 12b35c037d..16227085cc 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domai

[PATCH 6/8] Bump - rerun CI HTTP 500 err

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 9d00cb8b21..ae9a2b1101 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -711,7 +711,6 @@ cmdAttachDisk(vshControl *ctl, const vs

[PATCH 3/8] Fixed code style bug for virBufferAddLit

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 810e55fa53..5862993464 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -688,7 +688,7 @

[PATCH 4/8] Fixed error of writing to ROM in host_name

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5862993464..cda0531a37 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -587,8 +587,7 @@ cmdAttachDisk(vshC

[PATCH 2/8] Fixed compile error where &buf was missing

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 16227085cc..810e55fa53 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -707,7 +707,7 @@ cmdAttachDisk(vshContr

[PATCH 7/8] Re-wrote attach-disk to support multiple hosts

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 70 ++-- 1 file changed, 55 insertions(+), 15 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ae9a2b1101..64c7c454bd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-doma

[PATCH 5/8] Fixed error where char** not being promoted to const

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index cda0531a37..9d00cb8b21 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -227,7 +227,7 @@ static const vshCm

[PATCH 8/8] Added new params to attach-disk docs

Signed-off-by: Ryan Gahagan --- docs/manpages/virsh.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index bfd26e3120..83134ba571 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4500,9 +4500,11

Re: [PATCH] qemu: virtiofs: Stop virtiofsd when the qemu guest fails to start

On Tue, Nov 10, 2020 at 06:45:34PM +0100, Michal Privoznik wrote: > On 11/10/20 6:25 PM, Masayoshi Mizuma wrote: > > On Tue, Nov 10, 2020 at 10:10:16AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 11/10/20 2:04 AM, Masayoshi Mizuma wrote: > > > > From: Masayoshi Mizuma > > > > > >

Re: [PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

On 11/7/20 10:41 AM, Hao Wang wrote: Introduce virDomainDirtyRateInfo structure used for domain's memory dirty rate query. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 24 1 file changed, 24 insertions(+) diff --git a/inc

Re: [PATCH v4 2/7] migration/dirtyrate: set up framwork of domainGetDirtyRateInfo API

On 11/7/20 10:41 AM, Hao Wang wrote: Introduce DomainGetDirtyRateInfo API for domain's memory dirty rate calculation and query. Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 5 src/driver-hypervisor.h | 7 +

Re: [PATCH v4 7/7] migration/dirtyrate: Introduce getdirtyrate virsh api

On 11/7/20 10:41 AM, Hao Wang wrote: Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- tools/virsh-domain.c | 112 +++ 1 file changed, 112 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ef347

Re: [PATCH v4 6/7] migration/dirtyrate: Implement qemuDomainGetDirtyRateInfo

On 11/7/20 10:41 AM, Hao Wang wrote: Implement qemuDomainGetDirtyRateInfo: using flags to control behaviors -- calculate and/or query dirtyrate. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 11 ++ src/qemu/qemu_driver.c | 68 +

Re: [PATCH v4 3/7] migration/dirtyrate: Implement qemuDomainCalculateDirtyRate

On 11/7/20 10:41 AM, Hao Wang wrote: Implement qemuDomainCalculateDirtyRate which calculates domain's memory dirty rate calling qmp "calc-dirty-rate". Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- src/qemu/qemu_migration.c| 28 +++

Re: [PATCH v4 4/7] migration/dirtyrate: Implement qemuDomainQueryDirtyRate

On 11/7/20 10:41 AM, Hao Wang wrote: Implement qemuDomainQueryDirtyRate which query domain's memory dirty rate calling qmp "query-dirty-rate". Signed-off-by: Hao Wang Signed-off-by: Zhou Yimin Reviewed-by: Chuan Zheng --- src/qemu/qemu_migration.c| 31 +++ s

Re: [PATCH v4 5/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

On 11/7/20 10:41 AM, Hao Wang wrote: Implement qemuMonitorJSONExtractDirtyRateInfo to deal with the return from qmp "query-dirty-rate", and store them in virDomainDirtyRateInfo. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 17 + src/qemu/qe

[PATCH v2 0/2] Support mdev_types on CSS devices

All refactoring patches of this series in v1 were accepted except for actual patch enabling the mdev_types support on CSS devices. v2 adds one more refactoring patch in docs before the already sent enablement patch follows again. Boris Fiuczynski (2): docs: refactor mdev_types into new paragraph

[PATCH v2 1/2] docs: refactor mdev_types into new paragraph

To prevent copying the mdev_types description multiple times it is refactored into a new paragraph for easy reuse. Signed-off-by: Boris Fiuczynski --- docs/formatnode.html.in | 70 - 1 file changed, 41 insertions(+), 29 deletions(-) diff --git a/docs/form

[PATCH v2 2/2] node_device: detecting mdev_types capability on CSS devices

Add detection of mdev_types capability to channel subsystem devices. Signed-off-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- docs/drvnodedev.html.in | 5 +- docs/formatnode.html.in | 19 +++- docs/schemas/nodedev.rng | 4 +

Re: [PATCH] qemu: virtiofs: Stop virtiofsd when the qemu guest fails to start

On 11/10/20 6:25 PM, Masayoshi Mizuma wrote: On Tue, Nov 10, 2020 at 10:10:16AM -0300, Daniel Henrique Barboza wrote: On 11/10/20 2:04 AM, Masayoshi Mizuma wrote: From: Masayoshi Mizuma A qemu guest which has virtiofs config fails to start if the previous starting failed because of invalid

Re: [libvirt] [PATCH v2 05/13] virsh: Add interface mac completion to iface-name command

On 11/10/20 10:50 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 9 + tools/virsh-completer-interface.h | 4 tools/virsh-interface.c | 1 + 3 files changed, 14 insertions(+) diff --git a/tools/virsh-completer-interface.c b/tools/virs

Re: [libvirt] [PATCH v2 09/13] virsh: Add mac completion to net-dhcp-leases command

On 11/10/20 10:51 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-network.c | 44 + tools/virsh-completer-network.h | 4 +++ tools/virsh-network.c | 15 +++ 3 files changed, 58 insertions(+), 5 deletions(-) diff --git a/t

Re: [libvirt] [PATCH v2 01/13] virsh: Add vcpu list completion to guestvcpus command

On 11/10/20 10:50 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 75 ++ tools/virsh-completer-domain.h | 4 ++ tools/virsh-domain.c | 1 + 3 files changed, 80 insertions(+) diff --git a/tools/virsh-completer-domain.c

Re: [libvirt] [PATCH v2 00/13] virsh completion improvement

On 11/10/20 10:50 AM, Lin Ma wrote: Add more bash completions for some of virsh subcommands/subparameters. v1->v2 * Follow Michal's suggestions: - guestvcpus command: complete offlined vCPUs if --enable, complete onlined vCPUs if --disable - Added a static helper function for interface s

Re: [libvirt] [PATCH v2 04/13] virsh-interface: Add a static helper virshInterfaceStringHelper

On 11/10/20 10:50 AM, Lin Ma wrote: It will be helpful to get the desired string of interface name/mac in a consistent way. Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 25 - tools/virsh-completer-interface.h | 3 +++ 2 files changed, 19 insertions(

Re: [libvirt] [PATCH v2 03/13] virsh: Add serial/parallel device name completion to console command

On 11/10/20 10:50 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 55 ++ tools/virsh-completer-domain.h | 4 +++ tools/virsh-domain.c | 1 + 3 files changed, 60 insertions(+) diff --git a/tools/virsh-completer-domain.

Re: [libvirt] [PATCH v2 02/13] virsh: Add logical CPU IDs completion for nodecpustats command

On 11/10/20 10:50 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-host.c | 31 +++ tools/virsh-completer-host.h | 4 tools/virsh-host.c | 1 + 3 files changed, 36 insertions(+) diff --git a/tools/virsh-completer-host.c b/tools/

Re: [PATCH] qemu: virtiofs: Stop virtiofsd when the qemu guest fails to start

On Tue, Nov 10, 2020 at 10:10:16AM -0300, Daniel Henrique Barboza wrote: > > > On 11/10/20 2:04 AM, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma > > > > A qemu guest which has virtiofs config fails to start if the previous > > starting failed because of invalid option or something. > > Fo

[PATCH 5/6] qemu: Implement OpenSSH authorized key file mgmt APIs

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1888537 Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 81 ++ 1 file changed, 81 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5f0bb69dd5..7fd29f934f 10064

[PATCH 1/6] Introduce OpenSSH authorized key file mgmt APIs

When setting up a new guest or when a management software wants to allow access to an existing guest the virDomainSetUserPassword() API can be used, but that might be not good enough if user want to ssh into the guest. Not only sshd has to be configured to accept password authentication (which is u

[PATCH 3/6] virsh: Expose OpenSSH authorized key file mgmt APIs

The new virsh commands are: get-user-sshkeys set-user-sshkeys Signed-off-by: Michal Privoznik --- docs/manpages/virsh.rst | 37 ++ tools/virsh-domain.c| 152 2 files changed, 189 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs

[PATCH 4/6] qemu_agent: add qemuAgentSSH{Add, Remove, Get}AuthorizedKeys

From: Marc-André Lureau In QEMU 5.2, the guest agent learned to manipulate a user ~/.ssh/authorized_keys. Bind the JSON API to libvirt. https://wiki.qemu.org/ChangeLog/5.2#Guest_agent Signed-off-by: Marc-André Lureau Signed-off-by: Michal Privoznik --- src/qemu/qemu_agent.c | 140 +++

[PATCH 6/6] news: Document recent OpenSSH authorized key file mgmt APIs

Signed-off-by: Michal Privoznik --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0e56f5dbca..3fba272543 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -12,6 +12,12 @@ v6.10.0 (unreleased) * **New features** + * qemu: Implement Ope

[PATCH 0/6] Introduce OpenSSH authorized key file mgmt APIs

Marc-André posted a patch that implements agent handling. I've written the rest. Marc-André Lureau (1): qemu_agent: add qemuAgentSSH{Add,Remove,Get}AuthorizedKeys Michal Prívozník (5): Introduce OpenSSH authorized key file mgmt APIs remote: Implement OpenSSH authorized key file mgmt APIs

[PATCH 2/6] remote: Implement OpenSSH authorized key file mgmt APIs

Since both APIs accept/return an array of strings we can't have client/server dispatch code generated. But implementation is fairly trivial, although verbose. Signed-off-by: Michal Privoznik --- src/remote/remote_daemon_dispatch.c | 82 +++ src/remote/remote_driver.c

Re: [libvirt PATCH] qemu: add qemuAgentSSH{Add, Remove, Get}AuthorizedKeys

Hi On Mon, Nov 9, 2020 at 4:44 PM Michal Privoznik wrote: > > I'm stopping my review here. The wrappers are okay, but we really need > the public API and RPC first. I can work on that if you don't feel like it. I am on holiday this week and perhaps a few more days. If you have some free time, fe

Re: [PATCH] qemu: virtiofs: Stop virtiofsd when the qemu guest fails to start

On 11/10/20 2:04 AM, Masayoshi Mizuma wrote: From: Masayoshi Mizuma A qemu guest which has virtiofs config fails to start if the previous starting failed because of invalid option or something. For example of the reproduction: # virsh start guest error: Failed to start domain guest

Re: [PATCH v2 00/10] qemu: support renaming domains with snapshots/checkpoints

On 09.11.2020 16:51, Daniel Henrique Barboza wrote: > > > On 11/3/20 8:59 AM, Nikolay Shirokovskiy wrote: >> This is basically just rebase of [1] as it was not get any attention at that >> time. >> >> [1] [PATCH 0/8] qemu: support renaming domains with snapshots/checkpoints >> https://www.redh

Re: [libvirt] [PATCH 13/19] virsh-domain: Introduce 2 macros for domain options 'interface' and 'mac'

On 2020-11-02 19:40, Michal Privoznik wrote: On 11/2/20 9:26 AM, Lin Ma wrote: The macro VIRSH_DOMAIN_OPT_INTERFACE for domain option '--interface', The macro VIRSH_DOMAIN_OPT_MAC for domain option '--mac'. Signed-off-by: Lin Ma --- tools/virsh-domain.h | 18 ++ 1 file chang

[libvirt] [PATCH v2 02/13] virsh: Add logical CPU IDs completion for nodecpustats command

Signed-off-by: Lin Ma --- tools/virsh-completer-host.c | 31 +++ tools/virsh-completer-host.h | 4 tools/virsh-host.c | 1 + 3 files changed, 36 insertions(+) diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index 339390aa00..6

[libvirt] [PATCH v2 06/13] virsh: Add interface name completion to iface-bridge command

Signed-off-by: Lin Ma --- tools/virsh-interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index ae2b52bfc3..ae234e1e22 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -786,6 +786,7 @@ static const vshCmdOptDef opt

[libvirt] [PATCH v2 11/13] virsh: Add signal name completion to send-process-signal command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index dc66317561..b8

[libvirt] [PATCH v2 04/13] virsh-interface: Add a static helper virshInterfaceStringHelper

It will be helpful to get the desired string of interface name/mac in a consistent way. Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 25 - tools/virsh-completer-interface.h | 3 +++ 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/vi

[libvirt] [PATCH v2 05/13] virsh: Add interface mac completion to iface-name command

Signed-off-by: Lin Ma --- tools/virsh-completer-interface.c | 9 + tools/virsh-completer-interface.h | 4 tools/virsh-interface.c | 1 + 3 files changed, 14 insertions(+) diff --git a/tools/virsh-completer-interface.c b/tools/virsh-completer-interface.c index 407021485f..

[libvirt] [PATCH v2 10/13] virsh: Move/add some of function declarations to virsh-domain.h

The upcoming patches introduce completers into virsh-completer-domain.c, They will invoke the functions which are defined in virsh-domain.c, So these functions need to be declared in virsh-domain.h. Signed-off-by: Lin Ma --- tools/virsh-domain.c | 1 - tools/virsh-domain.h | 4 2 files chan

[libvirt] [PATCH v2 00/13] virsh completion improvement

Add more bash completions for some of virsh subcommands/subparameters. v1->v2 * Follow Michal's suggestions: - guestvcpus command: complete offlined vCPUs if --enable, complete onlined vCPUs if --disable - Added a static helper function for interface string provider, - Adjusted some needle

[libvirt] [PATCH v2 03/13] virsh: Add serial/parallel device name completion to console command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 55 ++ tools/virsh-completer-domain.h | 4 +++ tools/virsh-domain.c | 1 + 3 files changed, 60 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index f

[libvirt] [PATCH v2 08/13] vsh: Fix completion error in case of multiple mac addresses

We know that the bash completer automatically handle colon by preceding it with an escape character backslash. While our bash autompletion file vsh completes multiple items, In case there're multiple items which have same prefix and the content of completion items contain colon(say mac address), Th

[libvirt] [PATCH v2 12/13] virsh: Add lifecycle type completion to set-lifecycle-action command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index b8b6c74f8b..b1

[libvirt] [PATCH v2 13/13] Add lifecycle action completion to set-lifecycle-action command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 20 tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 1 + 3 files changed, 25 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index b1b670ffc5..a4

[libvirt] [PATCH v2 07/13] virsh: Add interface name completion to iface-mac command

Signed-off-by: Lin Ma --- tools/virsh-interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index ae234e1e22..858052d341 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -441,6 +441,7 @@ static const vshCmdOptDef opt

[libvirt] [PATCH v2 01/13] virsh: Add vcpu list completion to guestvcpus command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 75 ++ tools/virsh-completer-domain.h | 4 ++ tools/virsh-domain.c | 1 + 3 files changed, 80 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index c6

[libvirt] [PATCH v2 09/13] virsh: Add mac completion to net-dhcp-leases command

Signed-off-by: Lin Ma --- tools/virsh-completer-network.c | 44 + tools/virsh-completer-network.h | 4 +++ tools/virsh-network.c | 15 +++ 3 files changed, 58 insertions(+), 5 deletions(-) diff --git a/tools/virsh-completer-network.c b/tools/vir

Re: [PATCH] util: convert char pointers to use g_autofree

On Mon, Nov 09, 2020 at 04:34:22PM -0600, Ryan Gahagan wrote: > From: Barrett Schonefeld > > additional conversions to the GLib API in src/util per issue #11. > > files updated are: > - src/util/vircgroupv1.c > - src/util/virhostcpu.c > - src/util/virlockspace.c > - src/util/virmacmap.c > - src/